1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
use super::{
entry::{Entry, Queue},
stack::Stack,
};
#[derive(Debug)]
pub struct Wheel<E: Entry> {
stacks: [Stack<E>; 8],
pending_wake: E::Queue,
}
impl<E: Entry> Default for Wheel<E> {
fn default() -> Self {
Self {
stacks: Default::default(),
pending_wake: E::Queue::new(),
}
}
}
macro_rules! stack_map {
($stack:expr, $cb:expr) => {{
let cb = $cb;
[
cb(&$stack[0]),
cb(&$stack[1]),
cb(&$stack[2]),
cb(&$stack[3]),
cb(&$stack[4]),
cb(&$stack[5]),
cb(&$stack[6]),
cb(&$stack[7]),
]
}};
}
impl<E: Entry> Wheel<E> {
pub fn ticks(&self) -> u64 {
u64::from_le_bytes(stack_map!(self.stacks, |stack: &Stack<E>| stack.current()))
}
pub fn is_empty(&self) -> bool {
macro_rules! is_empty {
() => {
is_empty!([0, 1, 2, 3, 4, 5, 6, 7])
};
([$($idx:expr),*]) => {
$(self.stacks[$idx].is_empty())&*
};
}
is_empty!()
}
pub fn insert(&mut self, mut entry: E) {
let ticks = self.ticks();
entry.set_start_tick(ticks);
self.insert_at(entry, ticks);
}
fn insert_at(&mut self, entry: E, start_tick: u64) -> bool {
let delay = entry.delay();
let absolute_time = delay.wrapping_add(start_tick);
let now = self.ticks();
let zero_time = (absolute_time ^ now).to_be();
if zero_time == 0 {
self.pending_wake.push(entry);
return true;
}
let absolute_bytes = absolute_time.to_le_bytes();
let leading = zero_time.leading_zeros();
let index = (leading / 8) as usize;
let position = absolute_bytes[index];
self.stack_mut(index).insert(position, entry);
false
}
pub fn advance(&mut self) -> Option<u64> {
let start = self.ticks();
let has_pending = !self.pending_wake.is_empty();
if has_pending {
return Some(0);
}
if self.is_empty() {
return None;
}
let mut iterations = 0;
while !self.advance_once()? {
debug_assert!(
iterations < (u16::MAX as u32 * 4),
"advance iterated too many times"
);
iterations += 1;
}
// TODO handle wheel wrapping
Some(self.ticks() - start)
}
fn advance_once(&mut self) -> Option<bool> {
let mut can_skip = true;
let mut is_empty = true;
let mut has_pending = false;
for index in 0..self.stacks.len() {
let (mut list, did_wrap) = self.stack_mut(index).tick(can_skip);
while let Some(entry) = list.pop() {
// Drop cancelled entries immediately rather than re-inserting
// them into the wheel. Without this check, cancelled entries
// cascade between levels until their absolute_time is reached,
// potentially causing the iteration limit to be exceeded.
if entry.is_cancelled() {
continue;
}
let start_tick = entry.start_tick();
if self.insert_at(entry, start_tick) {
// A pending item is ready
has_pending = true;
} else {
// the item was pushed above the current stack so
// we can't skip anymore
can_skip = false;
}
// in either case we know there's some available entry
is_empty = false;
}
// we can only proceed to the next stack if the current wrapped
if !did_wrap {
return Some(has_pending);
}
// children can only skip if this is also empty
can_skip &= self.stack_mut(index).is_empty();
is_empty &= can_skip;
}
if is_empty {
return None;
}
Some(has_pending)
}
#[inline]
pub fn wake<F: FnMut(E)>(&mut self, mut wake: F) -> usize {
let mut count = 0;
let mut pending = self.pending_wake.take();
while let Some(entry) = pending.pop() {
count += 1;
wake(entry);
}
count
}
#[inline]
pub fn close<F: FnMut(E)>(&mut self, mut close: F) {
if self.is_empty() {
return;
}
while let Some(entry) = self.pending_wake.pop() {
close(entry);
}
for stack in self.stacks.iter_mut() {
stack.close(&mut close);
}
}
#[inline]
pub fn reset(&mut self) {
for stack in self.stacks.iter_mut() {
stack.reset();
}
}
#[inline]
fn stack_mut(&mut self, index: usize) -> &mut Stack<E> {
if cfg!(test) {
debug_assert!(index < self.stacks.len());
}
unsafe { self.stacks.get_unchecked_mut(index) }
}
}
#[cfg(test)]
mod tests {
use super::{super::entry::atomic, *};
use alloc::{vec, vec::Vec};
use bolero::{check, generator::*};
use core::time::Duration;
#[test]
fn insert_advance_wake_check() {
let max_ticks = Duration::from_secs(100_000).as_nanos() as u64;
let entry = produce::<Vec<u64>>().with().values(0..max_ticks);
let entries = produce::<Vec<_>>().with().values(entry);
check!().with_generator(entries).for_each(|entries| {
test_helper(&entries[..]);
});
}
fn test_helper<T: AsRef<[u64]>>(entries: &[T]) {
let mut wheel = Wheel::default();
let mut sorted = vec![];
let mut total_ticks = 0;
for entries in entries.iter().map(AsRef::as_ref) {
sorted.extend_from_slice(entries);
sorted.sort_unstable();
let mut should_wake = false;
// Keep one clone per entry to simulate the application holding an
// Arc (as `Timer` does). Without this, `strong_count` would be 1
// the moment an entry enters the wheel, making `is_cancelled()`
// return `true` for every entry.
let mut alive = vec![];
for entry in entries.iter().copied() {
// adding a 0-tick will immediately wake the entry
should_wake |= entry == 0;
let e = atomic::Entry::new(entry);
alive.push(e.clone());
wheel.insert(e);
}
let mut sorted = sorted.drain(..);
let woken = wheel.wake(atomic::wake);
assert_eq!(woken > 0, should_wake);
for _ in 0..woken {
sorted.next();
}
let mut elapsed = 0;
while let Some(expected) = sorted.next() {
let delta = expected - elapsed;
assert_eq!(wheel.advance(), Some(delta));
elapsed += delta;
assert_eq!(
wheel.advance(),
Some(0),
"the wheel should not advance while there are pending items"
);
for _ in (0..wheel.wake(atomic::wake)).skip(1) {
assert_eq!(
sorted.next(),
Some(expected),
"any additional items should be equal"
);
}
}
assert!(wheel.is_empty());
assert_eq!(wheel.advance(), None);
assert_eq!(wheel.wake(atomic::wake), 0);
assert!(wheel.is_empty());
total_ticks += elapsed;
assert_eq!(wheel.ticks(), total_ticks);
drop(alive);
}
}
#[test]
fn empty_test() {
let mut wheel = Wheel::default();
assert_eq!(wheel.ticks(), 0);
assert!(wheel.is_empty());
assert_eq!(wheel.advance(), None);
assert_eq!(wheel.wake(atomic::wake), 0);
}
#[test]
fn crossing_test() {
for t in [250..260, 510..520, 65790..65800]
.iter()
.flat_map(|v| v.clone())
{
test_helper(&[[t, t + 1]]);
}
}
#[test]
fn duplicate_test() {
test_helper(&[&[1, 489][..], &[24, 279][..]]);
}
#[test]
fn overflow_test() {
test_helper(&[
&[3588254211306][..],
&[799215800378, 10940666347][..],
&[][..],
]);
}
/// Regression test: cancelled entries must be dropped during cascading
/// rather than re-inserted into the wheel. Without the fix, entries
/// cascading between levels accumulate enough iterations to trigger the
/// "advance iterated too many times" debug_assert panic.
///
/// The panic threshold is `u16::MAX * 4` (262_140). To reliably exceed
/// it we insert entries whose delays span all 256 byte-0 positions across
/// several byte-1 values, cancel every one of them, and then ask the
/// wheel to advance to a single real timer placed after all cancelled
/// entries.
#[test]
fn cancelled_timers_do_not_cause_excessive_iteration() {
let mut wheel = Wheel::default();
// Fill every byte-0 slot in level-0 across 4 byte-1 values.
// Each unique (byte-0, byte-1) combination creates a distinct entry
// that would otherwise cascade between levels many times before
// expiring, quickly exhausting the iteration budget.
let mut entries = alloc::vec::Vec::new();
for byte1 in 0u64..4 {
for byte0 in 1u64..=255 {
let delay = byte1 * 256 + byte0 + 1000;
let entry = atomic::Entry::new(delay);
entries.push(entry.clone());
wheel.insert(entry);
}
}
// Cancel every entry – they remain in the wheel but should now be
// discarded when encountered during cascading.
for entry in &entries {
entry.cancel();
}
drop(entries);
// Insert one real (non-cancelled) timer beyond all cancelled ones.
wheel.insert(atomic::Entry::new(10_000));
// This must complete without hitting the iteration-limit assert.
while let Some(_ticks) = wheel.advance() {
wheel.wake(atomic::wake);
}
}
}