use std::path::{Path, PathBuf};
use anyhow::Context as _;
use cargo_metadata::Metadata;
use ostool::build::config::Cargo;
pub type StarryBuildInfo = crate::build::BuildInfo;
pub use crate::build::LogLevel;
use crate::context::{ResolvedStarryRequest, STARRY_PACKAGE, starry_arch_for_target_checked};
pub(crate) fn default_starry_build_info_for_target(target: &str) -> StarryBuildInfo {
let mut build_info = StarryBuildInfo::default_for_target(target);
build_info.plat_dyn = false;
build_info.features = vec!["qemu".to_string()];
build_info
}
pub(crate) fn resolve_build_info_path(
workspace_root: &Path,
target: &str,
explicit_path: Option<PathBuf>,
) -> anyhow::Result<PathBuf> {
if let Some(path) = explicit_path {
return Ok(path);
}
let _ = starry_arch_for_target_checked(target)?;
Ok(crate::build::default_build_info_path_in_workspace(
workspace_root,
STARRY_PACKAGE,
target,
))
}
#[cfg(test)]
pub(crate) fn load_build_info(request: &ResolvedStarryRequest) -> anyhow::Result<StarryBuildInfo> {
let makefile_features = crate::build::makefile_features_from_env();
let mut build_info = if let Some(build_info) = &request.build_info_override {
build_info.clone()
} else {
crate::build::ensure_build_info(&request.build_info_path, || {
default_starry_build_info_for_target(&request.target)
})?;
crate::build::load_build_info(&request.build_info_path)?
};
crate::build::apply_makefile_features(&mut build_info, &request.package, &makefile_features);
if let Some(smp) = request.smp {
build_info.max_cpu_num = Some(smp);
}
Ok(build_info)
}
pub(crate) fn load_cargo_config(request: &ResolvedStarryRequest) -> anyhow::Result<Cargo> {
let metadata =
crate::build::cached_workspace_metadata().context("failed to load workspace metadata")?;
let makefile_features = crate::build::makefile_features_from_env();
let mut build_info = if let Some(build_info) = &request.build_info_override {
build_info.clone()
} else {
crate::build::ensure_build_info(&request.build_info_path, || {
default_starry_build_info_for_target(&request.target)
})?;
crate::build::load_build_info(&request.build_info_path)?
};
crate::build::apply_makefile_features_with_metadata(
&mut build_info,
&request.package,
&makefile_features,
metadata,
);
if let Some(smp) = request.smp {
build_info.max_cpu_num = Some(smp);
}
let mut cargo = build_info.into_prepared_base_cargo_config_with_metadata(
&request.package,
&request.target,
request.plat_dyn,
metadata,
)?;
patch_starry_cargo_config(&mut cargo, request, metadata)?;
Ok(cargo)
}
fn patch_starry_cargo_config(
cargo: &mut Cargo,
request: &ResolvedStarryRequest,
metadata: &Metadata,
) -> anyhow::Result<()> {
let platform = crate::context::starry_default_platform_for_arch_checked(&request.arch)?;
let static_defplat = uses_static_default_platform(&cargo.features);
cargo.package = request.package.clone();
cargo.target = request.target.clone();
ensure_starry_bin_arg(&mut cargo.args, &request.package, metadata)?;
remove_qemu_feature_for_dynamic_platform(cargo);
if static_defplat {
cargo.features.push("qemu".to_string());
cargo.features.sort();
cargo.features.dedup();
}
cargo
.env
.insert("AX_ARCH".to_string(), request.arch.clone());
cargo
.env
.insert("AX_TARGET".to_string(), request.target.clone());
if static_defplat {
cargo
.env
.entry("AX_PLATFORM".to_string())
.or_insert_with(|| platform.to_string());
}
if cargo.env.get("UIMAGE").map(|v| v.as_str()) == Some("y") {
inject_uimage_post_build_cmd(cargo, &request.arch)?;
}
Ok(())
}
fn uimg_arch_for(arch: &str) -> String {
match arch {
"aarch64" => "arm64".to_string(),
"riscv64" => "riscv".to_string(),
other => other.to_string(),
}
}
fn inject_uimage_post_build_cmd(cargo: &mut Cargo, arch: &str) -> anyhow::Result<()> {
let uimg_arch = uimg_arch_for(arch);
let config_path = cargo
.env
.get("AX_CONFIG_PATH")
.cloned()
.ok_or_else(|| anyhow::anyhow!("AX_CONFIG_PATH is required for UIMAGE generation"))?;
let cmd = format!(
"paddr=$(ax-config-gen {config_path} -r plat.kernel-base-paddr | tr -d _) && \
bin=${{KERNEL_ELF%.elf}}.bin && mkimage -A {uimg_arch} -O linux -T kernel -C none -a \
\"$paddr\" -d \"$bin\" \"${{bin%.bin}}.uimg\""
);
cargo.post_build_cmds.push(cmd);
Ok(())
}
fn remove_qemu_feature_for_dynamic_platform(cargo: &mut Cargo) {
let uses_dynamic_platform = cargo.features.iter().any(|feature| {
matches!(
feature.as_str(),
"plat-dyn" | "ax-feat/plat-dyn" | "ax-std/plat-dyn"
)
});
if uses_dynamic_platform {
cargo.features.retain(|feature| feature != "qemu");
}
}
fn uses_static_default_platform(features: &[String]) -> bool {
let has_defplat = features.iter().any(|feature| {
matches!(
feature.as_str(),
"defplat" | "ax-feat/defplat" | "ax-std/defplat"
)
});
let has_dynamic = features.iter().any(|feature| {
matches!(
feature.as_str(),
"plat-dyn" | "ax-feat/plat-dyn" | "ax-std/plat-dyn"
)
});
let has_custom = features.iter().any(|feature| {
matches!(
feature.as_str(),
"myplat" | "ax-feat/myplat" | "ax-std/myplat"
)
});
has_defplat && !has_dynamic && !has_custom
}
fn ensure_starry_bin_arg(
args: &mut Vec<String>,
package: &str,
metadata: &Metadata,
) -> anyhow::Result<()> {
if args.iter().any(|arg| arg == "--bin") {
return Ok(());
}
if package_has_bin_named(package, package, metadata)? {
args.push("--bin".to_string());
args.push(package.to_string());
}
Ok(())
}
fn package_has_bin_named(
package: &str,
bin_name: &str,
metadata: &Metadata,
) -> anyhow::Result<bool> {
let package_info = metadata
.packages
.iter()
.find(|pkg| metadata.workspace_members.contains(&pkg.id) && pkg.name == package)
.ok_or_else(|| anyhow::anyhow!("workspace package `{package}` not found"))?;
Ok(package_info.targets.iter().any(|target| {
target.name == bin_name
&& target
.kind
.iter()
.any(|kind| matches!(kind, cargo_metadata::TargetKind::Bin))
}))
}
#[cfg(test)]
mod tests {
use std::{collections::HashMap, fs};
use tempfile::tempdir;
use super::*;
use crate::context::STARRY_PACKAGE;
fn write_minimal_package_manifest(path: &Path, name: &str) {
let src_dir = path.parent().unwrap().join("src");
fs::create_dir_all(&src_dir).unwrap();
fs::write(src_dir.join("lib.rs"), "").unwrap();
fs::write(
path,
format!("[package]\nname = \"{name}\"\nversion = \"0.1.0\"\nedition = \"2021\"\n"),
)
.unwrap();
}
fn request(path: PathBuf, arch: &str, target: &str) -> ResolvedStarryRequest {
ResolvedStarryRequest {
package: STARRY_PACKAGE.to_string(),
arch: arch.to_string(),
target: target.to_string(),
plat_dyn: None,
smp: None,
debug: false,
build_info_path: path,
build_info_override: None,
qemu_config: None,
uboot_config: None,
}
}
#[test]
fn resolve_build_info_path_uses_default_starry_location() {
let root = tempdir().unwrap();
let starry_dir = root.path().join("os/StarryOS/starryos");
fs::create_dir_all(&starry_dir).unwrap();
write_minimal_package_manifest(&starry_dir.join("Cargo.toml"), STARRY_PACKAGE);
fs::write(
root.path().join("Cargo.toml"),
"[workspace]\nmembers = [\"os/StarryOS/starryos\"]\n",
)
.unwrap();
let path =
resolve_build_info_path(root.path(), "aarch64-unknown-none-softfloat", None).unwrap();
assert_eq!(
path,
root.path()
.join("tmp/axbuild/config/starryos/build-aarch64-unknown-none-softfloat.toml")
);
}
#[test]
fn resolve_build_info_path_ignores_source_tree_defaults() {
let root = tempdir().unwrap();
let starry_dir = root.path().join("os/StarryOS/starryos");
fs::create_dir_all(&starry_dir).unwrap();
write_minimal_package_manifest(&starry_dir.join("Cargo.toml"), STARRY_PACKAGE);
fs::write(
root.path().join("Cargo.toml"),
"[workspace]\nmembers = [\"os/StarryOS/starryos\"]\n",
)
.unwrap();
let bare = starry_dir.join("build-aarch64-unknown-none-softfloat.toml");
let dotted = starry_dir.join(".build-aarch64-unknown-none-softfloat.toml");
fs::write(&bare, "").unwrap();
fs::write(&dotted, "").unwrap();
let path =
resolve_build_info_path(root.path(), "aarch64-unknown-none-softfloat", None).unwrap();
assert_eq!(
path,
root.path()
.join("tmp/axbuild/config/starryos/build-aarch64-unknown-none-softfloat.toml")
);
}
#[test]
fn resolve_build_info_path_prefers_explicit_path() {
let root = tempdir().unwrap();
let starry_dir = root.path().join("os/StarryOS/starryos");
fs::create_dir_all(&starry_dir).unwrap();
write_minimal_package_manifest(&starry_dir.join("Cargo.toml"), STARRY_PACKAGE);
fs::write(
root.path().join("Cargo.toml"),
"[workspace]\nmembers = [\"os/StarryOS/starryos\"]\n",
)
.unwrap();
let explicit = root.path().join("custom/build.toml");
let path =
resolve_build_info_path(root.path(), "x86_64-unknown-none", Some(explicit.clone()))
.unwrap();
assert_eq!(path, explicit);
}
#[test]
fn load_build_info_writes_default_template_when_missing() {
let root = tempdir().unwrap();
let path = root.path().join(".build-target.toml");
let request = request(path.clone(), "aarch64", "aarch64-unknown-none-softfloat");
let build_info = load_build_info(&request).unwrap();
assert_eq!(
build_info,
default_starry_build_info_for_target("aarch64-unknown-none-softfloat")
);
assert!(path.exists());
let persisted: StarryBuildInfo =
toml::from_str(&fs::read_to_string(path).unwrap()).unwrap();
assert_eq!(persisted, build_info);
}
#[test]
fn load_build_info_reads_existing_file() {
let root = tempdir().unwrap();
let path = root.path().join(".build-target.toml");
fs::write(
&path,
r#"
log = "Info"
features = ["net"]
[env]
HELLO = "world"
"#,
)
.unwrap();
let request = request(path, "aarch64", "aarch64-unknown-none-softfloat");
let build_info = load_build_info(&request).unwrap();
assert_eq!(build_info.log, LogLevel::Info);
assert_eq!(build_info.features, vec!["net".to_string()]);
assert_eq!(
build_info.env.get("HELLO").map(String::as_str),
Some("world")
);
}
#[test]
fn load_build_info_prefers_request_override_without_writing_file() {
let root = tempdir().unwrap();
let path = root.path().join(".build-target.toml");
let mut request = request(path.clone(), "aarch64", "aarch64-unknown-none-softfloat");
request.build_info_override = Some(StarryBuildInfo {
log: LogLevel::Info,
features: vec!["net".to_string()],
..default_starry_build_info_for_target("aarch64-unknown-none-softfloat")
});
let build_info = load_build_info(&request).unwrap();
assert_eq!(build_info.log, LogLevel::Info);
assert_eq!(build_info.features, vec!["net".to_string()]);
assert!(!path.exists());
}
#[test]
fn patch_starry_cargo_config_injects_required_features_and_env() {
let request = request(
PathBuf::from("/tmp/.build.toml"),
"aarch64",
"aarch64-unknown-none-softfloat",
);
let build_info = StarryBuildInfo {
env: HashMap::from([(String::from("CUSTOM"), String::from("1"))]),
features: vec!["net".to_string()],
log: LogLevel::Info,
max_cpu_num: None,
axconfig_overrides: Vec::new(),
plat_dyn: false,
std_build: false,
};
let mut cargo = build_info.into_base_cargo_config_with_log(
STARRY_PACKAGE.to_string(),
request.target.clone(),
vec![],
);
let metadata = crate::build::workspace_metadata().unwrap();
patch_starry_cargo_config(&mut cargo, &request, &metadata).unwrap();
assert_eq!(cargo.package, STARRY_PACKAGE);
assert_eq!(cargo.target, "aarch64-unknown-none-softfloat");
assert_eq!(cargo.features, vec!["net".to_string()]);
assert_eq!(
cargo.env.get("AX_ARCH").map(String::as_str),
Some("aarch64")
);
assert_eq!(
cargo.env.get("AX_TARGET").map(String::as_str),
Some("aarch64-unknown-none-softfloat")
);
assert_eq!(cargo.env.get("AX_PLATFORM").map(String::as_str), None);
assert_eq!(cargo.env.get("AX_LOG").map(String::as_str), Some("info"));
assert_eq!(cargo.env.get("CUSTOM").map(String::as_str), Some("1"));
assert!(cargo.to_bin);
}
#[test]
fn patch_starry_cargo_config_preserves_request_package() {
let request = ResolvedStarryRequest {
package: STARRY_PACKAGE.to_string(),
arch: "x86_64".to_string(),
target: "x86_64-unknown-none".to_string(),
plat_dyn: None,
smp: None,
debug: false,
build_info_path: PathBuf::from("/tmp/.build.toml"),
build_info_override: None,
qemu_config: None,
uboot_config: None,
};
let build_info = default_starry_build_info_for_target("x86_64-unknown-none");
let mut cargo = build_info.into_base_cargo_config_with_log(
"placeholder".to_string(),
request.target.clone(),
vec![],
);
let metadata = crate::build::workspace_metadata().unwrap();
patch_starry_cargo_config(&mut cargo, &request, &metadata).unwrap();
assert_eq!(cargo.package, STARRY_PACKAGE);
assert_eq!(
cargo.args,
vec!["--bin".to_string(), STARRY_PACKAGE.to_string()]
);
}
#[test]
fn patch_starry_cargo_config_skips_qemu_for_dynamic_platforms() {
let request = request(
PathBuf::from("/tmp/.build.toml"),
"aarch64",
"aarch64-unknown-none-softfloat",
);
let build_info = StarryBuildInfo {
env: HashMap::new(),
features: vec![
"common".to_string(),
"ax-feat/bus-mmio".to_string(),
"ax-feat/driver-sdmmc".to_string(),
"ax-feat/plat-dyn".to_string(),
"axplat-dyn/rockchip-soc".to_string(),
"axplat-dyn/rockchip-sdhci".to_string(),
],
log: LogLevel::Info,
max_cpu_num: Some(8),
axconfig_overrides: Vec::new(),
plat_dyn: true,
std_build: false,
};
let mut cargo = build_info.into_base_cargo_config_with_log(
STARRY_PACKAGE.to_string(),
request.target.clone(),
StarryBuildInfo::build_cargo_args(&request.target, true, &[]),
);
let metadata = crate::build::workspace_metadata().unwrap();
patch_starry_cargo_config(&mut cargo, &request, &metadata).unwrap();
assert!(
cargo
.features
.contains(&"axplat-dyn/rockchip-soc".to_string())
);
assert!(
cargo
.features
.contains(&"axplat-dyn/rockchip-sdhci".to_string())
);
assert!(!cargo.features.contains(&"qemu".to_string()));
assert!(!cargo.env.contains_key("AX_PLATFORM"));
assert!(
cargo
.args
.iter()
.any(|arg| arg.contains("-Clink-arg=-Taxplat.x"))
);
}
#[test]
fn patch_starry_cargo_config_removes_qemu_for_dynamic_platforms() {
let request = request(
PathBuf::from("/tmp/.build.toml"),
"aarch64",
"aarch64-unknown-none-softfloat",
);
let build_info = StarryBuildInfo {
env: HashMap::new(),
features: vec![
"qemu".to_string(),
"ax-feat/plat-dyn".to_string(),
"starry-kernel/plat-dyn".to_string(),
],
log: LogLevel::Info,
max_cpu_num: None,
axconfig_overrides: Vec::new(),
plat_dyn: true,
std_build: false,
};
let mut cargo = build_info.into_base_cargo_config_with_log(
STARRY_PACKAGE.to_string(),
request.target.clone(),
StarryBuildInfo::build_cargo_args(&request.target, true, &[]),
);
let metadata = crate::build::workspace_metadata().unwrap();
patch_starry_cargo_config(&mut cargo, &request, &metadata).unwrap();
assert!(!cargo.features.contains(&"qemu".to_string()));
assert!(!cargo.env.contains_key("AX_PLATFORM"));
}
#[test]
fn resolve_build_info_path_supports_starry_subworkspace_root() {
let root = tempdir().unwrap();
let starry_dir = root.path().join("starryos");
fs::create_dir_all(&starry_dir).unwrap();
write_minimal_package_manifest(&starry_dir.join("Cargo.toml"), STARRY_PACKAGE);
fs::write(
root.path().join("Cargo.toml"),
"[workspace]\nmembers = [\"starryos\"]\n",
)
.unwrap();
let path =
resolve_build_info_path(root.path(), "aarch64-unknown-none-softfloat", None).unwrap();
assert_eq!(
path,
root.path()
.join("tmp/axbuild/config/starryos/build-aarch64-unknown-none-softfloat.toml")
);
}
#[test]
fn patch_starry_cargo_config_keeps_linker_x_arg() {
let request = ResolvedStarryRequest {
package: STARRY_PACKAGE.to_string(),
arch: "aarch64".to_string(),
target: "aarch64-unknown-none-softfloat".to_string(),
plat_dyn: None,
smp: None,
debug: false,
build_info_path: PathBuf::from(
"/tmp/os/StarryOS/starryos/.build-aarch64-unknown-none-softfloat.toml",
),
build_info_override: None,
qemu_config: None,
uboot_config: None,
};
let build_info = default_starry_build_info_for_target(&request.target);
let mut cargo = build_info.into_base_cargo_config_with_log(
request.package.clone(),
request.target.clone(),
StarryBuildInfo::build_cargo_args(&request.target, false, &[]),
);
let metadata = crate::build::workspace_metadata().unwrap();
patch_starry_cargo_config(&mut cargo, &request, &metadata).unwrap();
assert!(
cargo
.args
.iter()
.any(|arg| arg.contains("-Clink-arg=-Tlinker.x"))
);
}
#[test]
fn ensure_starry_bin_arg_adds_bin_for_starryos_package() {
let mut args = Vec::new();
let metadata = crate::build::workspace_metadata().unwrap();
ensure_starry_bin_arg(&mut args, "starryos", &metadata).unwrap();
assert_eq!(args, vec!["--bin".to_string(), "starryos".to_string()]);
}
#[test]
fn ensure_starry_bin_arg_keeps_existing_bin_arg() {
let mut args = vec!["--bin".to_string(), "starryos".to_string()];
let metadata = crate::build::workspace_metadata().unwrap();
ensure_starry_bin_arg(&mut args, STARRY_PACKAGE, &metadata).unwrap();
assert_eq!(args, vec!["--bin".to_string(), "starryos".to_string()]);
}
}