1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
use crate::completion::CompletionBatcherHandle;
use crate::context::JobContext;
use crate::runtime::{InFlightMap, InFlightState, ProgressState};
use awa_model::{AwaError, JobRow};
use sqlx::PgPool;
use std::any::Any;
use std::collections::HashMap;
use std::sync::atomic::{AtomicBool, AtomicU32, Ordering};
use std::sync::Arc;
use tracing::{error, info, info_span, warn, Instrument};
/// Result of executing a job handler.
#[derive(Debug)]
pub enum JobResult {
/// Job completed successfully.
Completed,
/// Job should be retried after the given duration. Increments attempt.
RetryAfter(std::time::Duration),
/// Job should be snoozed (re-available after duration). Does NOT increment attempt.
Snooze(std::time::Duration),
/// Job should be cancelled.
Cancel(String),
/// Job is waiting for an external callback (webhook completion).
/// The handler must have called `ctx.register_callback()` before returning this.
WaitForCallback,
}
/// Error type for job handlers — any error is retryable unless it's terminal.
#[derive(Debug, thiserror::Error)]
pub enum JobError {
/// Retryable error — will be retried if attempts remain.
#[error("{0}")]
Retryable(#[source] Box<dyn std::error::Error + Send + Sync>),
/// Terminal error — immediately fails the job regardless of remaining attempts.
#[error("terminal: {0}")]
Terminal(String),
}
impl JobError {
pub fn retryable(err: impl std::error::Error + Send + Sync + 'static) -> Self {
JobError::Retryable(Box::new(err))
}
pub fn terminal(msg: impl Into<String>) -> Self {
JobError::Terminal(msg.into())
}
}
/// Worker trait — implement this for each job type.
#[async_trait::async_trait]
pub trait Worker: Send + Sync + 'static {
/// The kind string for this worker (must match the job's kind).
fn kind(&self) -> &'static str;
/// Execute the job. The raw args JSON and context are provided.
async fn perform(&self, job_row: &JobRow, ctx: &JobContext) -> Result<JobResult, JobError>;
}
/// Type-erased worker wrapper for the registry.
pub(crate) type BoxedWorker = Box<dyn Worker>;
/// Manages job execution — spawns worker futures and tracks in-flight jobs.
pub struct JobExecutor {
pool: PgPool,
workers: Arc<HashMap<String, BoxedWorker>>,
in_flight: InFlightMap,
queue_in_flight: Arc<HashMap<String, Arc<AtomicU32>>>,
state: Arc<HashMap<std::any::TypeId, Box<dyn Any + Send + Sync>>>,
metrics: crate::metrics::AwaMetrics,
completion_batcher: CompletionBatcherHandle,
}
impl JobExecutor {
pub(crate) fn new(
pool: PgPool,
workers: Arc<HashMap<String, BoxedWorker>>,
in_flight: InFlightMap,
queue_in_flight: Arc<HashMap<String, Arc<AtomicU32>>>,
state: Arc<HashMap<std::any::TypeId, Box<dyn Any + Send + Sync>>>,
metrics: crate::metrics::AwaMetrics,
completion_batcher: CompletionBatcherHandle,
) -> Self {
Self {
pool,
workers,
in_flight,
queue_in_flight,
state,
metrics,
completion_batcher,
}
}
/// Build the future that executes a claimed job.
///
/// The caller is responsible for spawning it onto the runtime.
pub fn execute_task(
&self,
job: JobRow,
cancel: Arc<AtomicBool>,
) -> impl std::future::Future<Output = ()> + Send + 'static {
let pool = self.pool.clone();
let workers = self.workers.clone();
let in_flight = self.in_flight.clone();
let queue_in_flight = self.queue_in_flight.clone();
let state = self.state.clone();
let metrics = self.metrics.clone();
let completion_batcher = self.completion_batcher.clone();
let job_id = job.id;
let job_run_lease = job.run_lease;
let job_kind = job.kind.clone();
let job_queue = job.queue.clone();
let span = info_span!(
"job.execute",
job.id = job_id,
job.kind = %job_kind,
job.queue = %job_queue,
job.attempt = job.attempt,
otel.name = %format!("job.execute {}", job_kind),
otel.status_code = tracing::field::Empty,
);
async move {
// Seed progress from the persisted checkpoint (for retries/snoozes)
let progress_state = Arc::new(std::sync::Mutex::new(ProgressState::new(
job.progress.clone(),
)));
// Register as in-flight with cancel + progress
let in_flight_state = InFlightState {
cancel: cancel.clone(),
progress: progress_state.clone(),
};
in_flight.insert((job_id, job_run_lease), in_flight_state);
if let Some(counter) = queue_in_flight.get(&job_queue) {
counter.fetch_add(1, Ordering::SeqCst);
}
metrics.record_in_flight_change(&job_queue, 1);
let start = std::time::Instant::now();
let ctx = JobContext::new(
job.clone(),
cancel,
state,
pool.clone(),
progress_state.clone(),
);
let result = match workers.get(&job.kind) {
Some(worker) => worker.perform(&job, &ctx).await,
None => {
error!(kind = %job.kind, job_id, "No worker registered for job kind");
Err(JobError::Terminal(format!(
"unknown job kind: {}",
job.kind
)))
}
};
let duration = start.elapsed();
// Snapshot progress for state transition
let progress_snapshot = {
let guard = progress_state.lock().expect("progress lock poisoned");
guard.clone_latest()
};
// Complete the job based on the result, then record metrics
// only if the state transition actually happened (not stale).
match complete_job(&pool, &job, &result, &completion_batcher, progress_snapshot).await {
Ok(true) => {
// State transition succeeded — record metrics
match &result {
Ok(JobResult::Completed) => {
metrics.record_job_completed(&job_kind, &job_queue, duration);
}
Ok(JobResult::RetryAfter(_)) => {
metrics.record_job_retried(&job_kind, &job_queue);
}
Ok(JobResult::Cancel(_)) => {
metrics.jobs_cancelled.add(
1,
&[
opentelemetry::KeyValue::new("awa.job.kind", job_kind.clone()),
opentelemetry::KeyValue::new(
"awa.job.queue",
job_queue.clone(),
),
],
);
}
Ok(JobResult::Snooze(_)) => {} // Not a terminal outcome
Ok(JobResult::WaitForCallback) => {
metrics.jobs_waiting_external.add(
1,
&[
opentelemetry::KeyValue::new("awa.job.kind", job_kind.clone()),
opentelemetry::KeyValue::new(
"awa.job.queue",
job_queue.clone(),
),
],
);
}
Err(JobError::Terminal(_)) => {
metrics.record_job_failed(&job_kind, &job_queue, true);
}
Err(JobError::Retryable(_)) => {
metrics.record_job_retried(&job_kind, &job_queue);
}
}
}
Ok(false) => {
// Job was already rescued/cancelled — no metrics
}
Err(err) => {
error!(job_id, error = %err, "Failed to complete job");
}
}
// Remove from in-flight
in_flight.remove((job_id, job_run_lease));
if let Some(counter) = queue_in_flight.get(&job_queue) {
counter.fetch_sub(1, Ordering::SeqCst);
}
metrics.record_in_flight_change(&job_queue, -1);
}
.instrument(span)
}
}
/// Update job state in the database based on handler result.
///
/// Returns `true` if the state transition happened, `false` if the job was
/// already rescued/cancelled by maintenance (stale completion).
async fn complete_job(
pool: &PgPool,
job: &JobRow,
result: &Result<JobResult, JobError>,
completion_batcher: &CompletionBatcherHandle,
progress_snapshot: Option<serde_json::Value>,
) -> Result<bool, AwaError> {
match result {
Ok(JobResult::Completed) => {
tracing::Span::current().record("otel.status_code", "OK");
info!(job_id = job.id, kind = %job.kind, attempt = job.attempt, "Job completed");
let result = match completion_batcher.complete(job.id, job.run_lease).await {
Ok(updated) => updated,
Err(err) => {
warn!(
job_id = job.id,
error = %err,
"Completion batch flush failed, falling back to direct finalize"
);
direct_complete_job(pool, job).await?
}
};
if !result {
warn!(
job_id = job.id,
"Job already rescued/cancelled, completion ignored"
);
return Ok(false);
}
}
Ok(JobResult::RetryAfter(duration)) => {
let seconds = duration.as_secs() as f64;
info!(
job_id = job.id,
kind = %job.kind,
retry_after_secs = seconds,
"Job requested retry after duration"
);
let result = sqlx::query(
r#"
UPDATE awa.jobs
SET state = 'retryable',
run_at = now() + make_interval(secs => $2),
finalized_at = now(),
progress = $4
WHERE id = $1 AND state = 'running' AND run_lease = $3
"#,
)
.bind(job.id)
.bind(seconds)
.bind(job.run_lease)
.bind(&progress_snapshot)
.execute(pool)
.await?;
if result.rows_affected() == 0 {
warn!(
job_id = job.id,
"Job already rescued/cancelled, retry ignored"
);
return Ok(false);
}
}
Ok(JobResult::Snooze(duration)) => {
let seconds = duration.as_secs() as f64;
info!(
job_id = job.id,
kind = %job.kind,
snooze_secs = seconds,
"Job snoozed (attempt not incremented)"
);
// Snooze: back to available with new run_at, decrement attempt
// (since it was already incremented at claim time)
let result = sqlx::query(
r#"
UPDATE awa.jobs
SET state = 'scheduled',
run_at = now() + make_interval(secs => $2),
attempt = attempt - 1,
heartbeat_at = NULL,
deadline_at = NULL,
progress = $4
WHERE id = $1 AND state = 'running' AND run_lease = $3
"#,
)
.bind(job.id)
.bind(seconds)
.bind(job.run_lease)
.bind(&progress_snapshot)
.execute(pool)
.await?;
if result.rows_affected() == 0 {
warn!(
job_id = job.id,
"Job already rescued/cancelled, snooze ignored"
);
return Ok(false);
}
}
Ok(JobResult::Cancel(reason)) => {
info!(
job_id = job.id,
kind = %job.kind,
reason = %reason,
"Job cancelled by handler"
);
let result = sqlx::query(
r#"
UPDATE awa.jobs
SET state = 'cancelled',
finalized_at = now(),
errors = errors || $2::jsonb,
progress = $4
WHERE id = $1 AND state = 'running' AND run_lease = $3
"#,
)
.bind(job.id)
.bind(serde_json::json!({
"error": format!("cancelled: {}", reason),
"attempt": job.attempt,
"at": chrono::Utc::now().to_rfc3339()
}))
.bind(job.run_lease)
.bind(&progress_snapshot)
.execute(pool)
.await?;
if result.rows_affected() == 0 {
warn!(
job_id = job.id,
"Job already rescued/cancelled, cancel ignored"
);
return Ok(false);
}
}
Ok(JobResult::WaitForCallback) => {
info!(
job_id = job.id,
kind = %job.kind,
"Job waiting for external callback"
);
// Transition to waiting_external. Requires callback_id to be set
// (handler must have called register_callback).
let result = sqlx::query(
r#"
UPDATE awa.jobs
SET state = 'waiting_external',
heartbeat_at = NULL,
deadline_at = NULL,
progress = $3
WHERE id = $1 AND state = 'running' AND run_lease = $2 AND callback_id IS NOT NULL
"#,
)
.bind(job.id)
.bind(job.run_lease)
.bind(&progress_snapshot)
.execute(pool)
.await?;
if result.rows_affected() == 0 {
// Check if a racing callback already completed/failed the job,
// or if the handler forgot to call register_callback.
let current: Option<(awa_model::JobState, Option<uuid::Uuid>)> =
sqlx::query_as("SELECT state, callback_id FROM awa.jobs WHERE id = $1")
.bind(job.id)
.fetch_optional(pool)
.await?;
match current {
Some((state, _)) if state.is_terminal() => {
// Racing callback already completed the job — all good
info!(
job_id = job.id,
state = %state,
"Job already completed by racing callback"
);
return Ok(true);
}
Some((_, None)) => {
// Still running but no callback_id — programming error
error!(
job_id = job.id,
"WaitForCallback returned without calling register_callback"
);
sqlx::query(
r#"
UPDATE awa.jobs
SET state = 'failed',
finalized_at = now(),
errors = errors || $2::jsonb
WHERE id = $1 AND state = 'running' AND run_lease = $3
"#,
)
.bind(job.id)
.bind(serde_json::json!({
"error": "WaitForCallback returned without calling register_callback",
"attempt": job.attempt,
"at": chrono::Utc::now().to_rfc3339(),
"terminal": true
}))
.bind(job.run_lease)
.execute(pool)
.await?;
return Ok(true);
}
_ => {
warn!(
job_id = job.id,
"Job already rescued/cancelled, wait-for-callback ignored"
);
return Ok(false);
}
}
}
}
Err(JobError::Terminal(msg)) => {
tracing::Span::current().record("otel.status_code", "ERROR");
error!(
job_id = job.id,
kind = %job.kind,
error = %msg,
"Job failed terminally"
);
let result = sqlx::query(
r#"
UPDATE awa.jobs
SET state = 'failed',
finalized_at = now(),
errors = errors || $2::jsonb,
progress = $4
WHERE id = $1 AND state = 'running' AND run_lease = $3
"#,
)
.bind(job.id)
.bind(serde_json::json!({
"error": msg.to_string(),
"attempt": job.attempt,
"at": chrono::Utc::now().to_rfc3339(),
"terminal": true
}))
.bind(job.run_lease)
.bind(&progress_snapshot)
.execute(pool)
.await?;
if result.rows_affected() == 0 {
warn!(
job_id = job.id,
"Job already rescued/cancelled, terminal failure ignored"
);
return Ok(false);
}
}
Err(JobError::Retryable(err)) => {
let error_msg = err.to_string();
if job.attempt >= job.max_attempts {
tracing::Span::current().record("otel.status_code", "ERROR");
error!(
job_id = job.id,
kind = %job.kind,
attempt = job.attempt,
max_attempts = job.max_attempts,
error = %error_msg,
"Job failed (max attempts exhausted)"
);
let result = sqlx::query(
r#"
UPDATE awa.jobs
SET state = 'failed',
finalized_at = now(),
errors = errors || $2::jsonb,
progress = $4
WHERE id = $1 AND state = 'running' AND run_lease = $3
"#,
)
.bind(job.id)
.bind(serde_json::json!({
"error": error_msg,
"attempt": job.attempt,
"at": chrono::Utc::now().to_rfc3339()
}))
.bind(job.run_lease)
.bind(&progress_snapshot)
.execute(pool)
.await?;
if result.rows_affected() == 0 {
warn!(
job_id = job.id,
"Job already rescued/cancelled, failure ignored"
);
return Ok(false);
}
} else {
warn!(
job_id = job.id,
kind = %job.kind,
attempt = job.attempt,
error = %error_msg,
"Job failed (will retry)"
);
// Use database-side backoff calculation
let result = sqlx::query(
r#"
UPDATE awa.jobs
SET state = 'retryable',
run_at = now() + awa.backoff_duration($2, $3),
finalized_at = now(),
heartbeat_at = NULL,
deadline_at = NULL,
errors = errors || $4::jsonb,
progress = $6
WHERE id = $1 AND state = 'running' AND run_lease = $5
"#,
)
.bind(job.id)
.bind(job.attempt)
.bind(job.max_attempts)
.bind(serde_json::json!({
"error": error_msg,
"attempt": job.attempt,
"at": chrono::Utc::now().to_rfc3339()
}))
.bind(job.run_lease)
.bind(&progress_snapshot)
.execute(pool)
.await?;
if result.rows_affected() == 0 {
warn!(
job_id = job.id,
"Job already rescued/cancelled, retry ignored"
);
return Ok(false);
}
}
}
}
Ok(true)
}
async fn direct_complete_job(pool: &PgPool, job: &JobRow) -> Result<bool, AwaError> {
let result = sqlx::query(
r#"
UPDATE awa.jobs_hot
SET state = 'completed',
finalized_at = now(),
progress = NULL
WHERE id = $1 AND state = 'running' AND run_lease = $2
"#,
)
.bind(job.id)
.bind(job.run_lease)
.execute(pool)
.await?;
Ok(result.rows_affected() > 0)
}