1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
use std::sync::Arc;
use crate::{
ActorMessage, NetworkMessage,
approval::types::VotationType,
db::Storable,
governance::data::GovernanceData,
helpers::network::service::NetworkSender,
model::common::{
emit_fail,
node::{SignTypesNode, UpdateData, get_sign, update_ledger_network},
purge_storage,
subject::get_metadata,
},
subject::RequestSubjectData,
};
use async_trait::async_trait;
use ave_actors::{
Actor, ActorContext, ActorError, ActorPath, Event, Handler, Message,
Response,
};
use ave_actors::{LightPersistence, PersistentActor};
use ave_common::{
Namespace, SchemaType,
bridge::request::{ApprovalState, ApprovalStateRes},
identity::{
DigestIdentifier, HashAlgorithm, PublicKey, Signed, hash_borsh,
},
};
use ave_network::ComunicateInfo;
use borsh::{BorshDeserialize, BorshSerialize};
use serde::{Deserialize, Serialize};
use tracing::{Span, debug, error, info_span, warn};
use super::{
Approval, ApprovalMessage, request::ApprovalReq, response::ApprovalRes,
};
#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct ApprPersist {
#[serde(skip)]
helpers: Option<(HashAlgorithm, Arc<NetworkSender>)>,
#[serde(skip)]
our_key: Arc<PublicKey>,
#[serde(skip)]
subject_id: DigestIdentifier,
#[serde(skip)]
pass_votation: VotationType,
#[serde(skip)]
node_key: PublicKey,
request_id: String,
version: u64,
state: Option<ApprovalState>,
request: Option<Signed<ApprovalReq>>,
}
impl BorshSerialize for ApprPersist {
fn serialize<W: std::io::Write>(
&self,
writer: &mut W,
) -> std::io::Result<()> {
// Serialize only the fields we want to persist, skipping 'owner'
BorshSerialize::serialize(&self.request_id, writer)?;
BorshSerialize::serialize(&self.version, writer)?;
BorshSerialize::serialize(&self.state, writer)?;
BorshSerialize::serialize(&self.request, writer)?;
Ok(())
}
}
impl BorshDeserialize for ApprPersist {
fn deserialize_reader<R: std::io::Read>(
reader: &mut R,
) -> std::io::Result<Self> {
// Deserialize the persisted fields
let request_id = String::deserialize_reader(reader)?;
let version = u64::deserialize_reader(reader)?;
let state = Option::<ApprovalState>::deserialize_reader(reader)?;
let request =
Option::<Signed<ApprovalReq>>::deserialize_reader(reader)?;
let node_key = PublicKey::default();
let our_key = Arc::new(PublicKey::default());
let pass_votation = VotationType::AlwaysAccept;
let subject_id = DigestIdentifier::default();
Ok(Self {
helpers: None,
our_key,
request_id,
version,
subject_id,
pass_votation,
state,
request,
node_key,
})
}
}
pub struct InitApprPersist {
pub our_key: Arc<PublicKey>,
pub node_key: PublicKey,
pub subject_id: DigestIdentifier,
pub pass_votation: VotationType,
pub helpers: (HashAlgorithm, Arc<NetworkSender>),
}
impl ApprPersist {
async fn check_governance(
&self,
ctx: &mut ActorContext<Self>,
governance_id: &DigestIdentifier,
gov_version: u64,
) -> Result<Option<String>, ActorError> {
let Some((.., network)) = &self.helpers else {
return Err(ActorError::FunctionalCritical {
description: "Helpers are None".to_owned(),
});
};
let metadata = get_metadata(ctx, governance_id).await?;
let governance =
match GovernanceData::try_from(metadata.properties.clone()) {
Ok(gov) => gov,
Err(e) => {
error!(
governance_id = %governance_id,
error = %e,
"Failed to convert governance from properties"
);
return Err(ActorError::FunctionalCritical {
description: format!(
"can not convert governance from properties: {}",
e
),
});
}
};
match gov_version.cmp(&governance.version) {
std::cmp::Ordering::Equal => {
// If it is the same it means that we have the latest version of governance, we are up to date.
}
std::cmp::Ordering::Greater => {
// Me llega una versión mayor a la mĆa.
let data = UpdateData {
sn: metadata.sn,
gov_version: governance.version,
subject_id: governance_id.clone(),
other_node: self.node_key.clone(),
};
update_ledger_network(data, network.clone()).await?;
}
std::cmp::Ordering::Less => {
return Ok(Some(format!(
"Abort approval, governance update is required by signer: local={}, request={}",
governance.version, gov_version
)));
}
}
Ok(None)
}
async fn send_signed_response(
&self,
ctx: &mut ActorContext<Self>,
response: ApprovalRes,
request: &Signed<ApprovalReq>,
request_id: &str,
version: u64,
) -> Result<(), ActorError> {
let Some((.., network)) = self.helpers.clone() else {
return Err(ActorError::FunctionalCritical {
description: "Helpers are None".to_owned(),
});
};
let sign_type = SignTypesNode::ApprovalRes(Box::new(response.clone()));
let signature = get_sign(ctx, sign_type).await?;
let subject_id = request.content().subject_id.clone();
if self.node_key == *self.our_key {
let subject_id = ctx.path().parent().key();
let approval_actor = ctx
.system()
.get_actor::<Approval>(&ActorPath::from(&format!(
"/user/request/{}/approval",
subject_id
)))
.await;
if let Ok(approval_actor) = approval_actor {
approval_actor
.tell(ApprovalMessage::Response {
approval_res: response,
sender: (*self.our_key).clone(),
signature: Some(signature),
})
.await?;
}
} else {
let signed_response: Signed<ApprovalRes> =
Signed::from_parts(response, signature);
let new_info = ComunicateInfo {
receiver: self.node_key.clone(),
request_id: request_id.to_string(),
version,
receiver_actor: format!(
"/user/request/{}/approval/{}",
subject_id, self.our_key
),
};
if let Err(e) = network
.send_command(ave_network::CommandHelper::SendMessage {
message: NetworkMessage {
info: new_info,
message: ActorMessage::ApprovalRes {
res: Box::new(signed_response),
},
},
})
.await
{
return Err(emit_fail(ctx, e).await);
};
}
Ok(())
}
async fn send_response(
&self,
ctx: &mut ActorContext<Self>,
request: &Signed<ApprovalReq>,
response: bool,
request_id: &str,
version: u64,
) -> Result<(), ActorError> {
let Some((hash, ..)) = self.helpers.clone() else {
return Err(ActorError::FunctionalCritical {
description: "Helpers are None".to_owned(),
});
};
let approval_req_hash = hash_borsh(&*hash.hasher(), request.content())
.map_err(|e| ActorError::FunctionalCritical {
description: format!(
"Can not obtain approval request hash {}",
e
),
})?;
let req_subject_data_hash = hash_borsh(
&*hash.hasher(),
&RequestSubjectData {
subject_id: request.content().subject_id.clone(),
governance_id: request.content().subject_id.clone(),
sn: request.content().sn,
namespace: Namespace::new(),
schema_id: SchemaType::Governance,
gov_version: request.content().gov_version,
signer: request.content().signer.clone(),
},
)
.map_err(|e| ActorError::FunctionalCritical {
description: format!("Can not obtain approval request hash {}", e),
})?;
let res = ApprovalRes::Response {
approval_req_hash,
agrees: response,
req_subject_data_hash,
};
self.send_signed_response(ctx, res, request, request_id, version)
.await
}
}
#[derive(Debug, Clone)]
pub enum ApprPersistMessage {
MakeObsolete,
PurgeStorage,
// Mensaje para aprobar localmente
LocalApproval {
request_id: DigestIdentifier,
version: u64,
approval_req: Signed<ApprovalReq>,
},
// Mensaje para pedir aprobación desde el helper y devolver ahi
NetworkRequest {
approval_req: Signed<ApprovalReq>,
info: ComunicateInfo,
sender: PublicKey,
},
GetApproval {
state: Option<ApprovalState>,
},
ChangeResponse {
response: ApprovalStateRes,
}, // Necesito poder emitir un evento de aprobación, no solo el automÔtico
}
impl Message for ApprPersistMessage {
fn is_critical(&self) -> bool {
matches!(self, Self::MakeObsolete | Self::PurgeStorage)
}
}
#[derive(
Debug, Clone, Serialize, Deserialize, BorshDeserialize, BorshSerialize,
)]
pub enum ApprPersistEvent {
ChangeState {
state: ApprovalState,
},
SafeState {
subject_id: DigestIdentifier,
request_id: String,
version: u64,
request: Box<Signed<ApprovalReq>>,
state: ApprovalState,
},
}
impl Event for ApprPersistEvent {}
pub enum ApprPersistResponse {
Ok,
Approval {
request: ApprovalReq,
state: ApprovalState,
},
}
impl Response for ApprPersistResponse {}
#[async_trait]
impl Actor for ApprPersist {
type Event = ApprPersistEvent;
type Message = ApprPersistMessage;
type Response = ApprPersistResponse;
fn get_span(_id: &str, parent_span: Option<Span>) -> tracing::Span {
parent_span.map_or_else(
|| info_span!("ApprPersist"),
|parent_span| info_span!(parent: parent_span, "ApprPersist"),
)
}
async fn pre_start(
&mut self,
ctx: &mut ActorContext<Self>,
) -> Result<(), ActorError> {
let prefix = ctx.path().parent().key();
if let Err(e) = self
.init_store("approver", Some(prefix.clone()), false, ctx)
.await
{
error!(
error = %e,
"Failed to initialize approver store"
);
return Err(e);
}
Ok(())
}
}
#[async_trait]
impl Handler<Self> for ApprPersist {
async fn handle_message(
&mut self,
_sender: ActorPath,
msg: ApprPersistMessage,
ctx: &mut ActorContext<Self>,
) -> Result<ApprPersistResponse, ActorError> {
match msg {
ApprPersistMessage::PurgeStorage => {
purge_storage(ctx).await?;
debug!(
msg_type = "PurgeStorage",
subject_id = %self.subject_id,
"Approval storage purged"
);
return Ok(ApprPersistResponse::Ok);
}
ApprPersistMessage::GetApproval { state } => {
let res = if let Some(req) = &self.request
&& let Some(req_state) = &self.state
{
state.map_or_else(
|| ApprPersistResponse::Approval {
request: req.content().clone(),
state: req_state.clone(),
},
|query| {
if &query == req_state {
ApprPersistResponse::Approval {
request: req.content().clone(),
state: query,
}
} else {
ApprPersistResponse::Ok
}
},
)
} else {
ApprPersistResponse::Ok
};
return Ok(res);
}
ApprPersistMessage::MakeObsolete => {
let state = if let Some(state) = self.state.clone() {
state
} else {
return Ok(ApprPersistResponse::Ok);
};
if state == ApprovalState::Pending {
self.on_event(
ApprPersistEvent::ChangeState {
state: ApprovalState::Obsolete,
},
ctx,
)
.await;
debug!(
msg_type = "MakeObsolete",
"State changed to obsolete"
);
}
}
ApprPersistMessage::ChangeResponse { response } => {
let Some(state) = self.state.clone() else {
warn!(
msg_type = "ChangeResponse",
"Approval state not found"
);
return Err(ActorError::Functional {
description: "Can not get approval state".to_owned(),
});
};
if response == ApprovalStateRes::Obsolete {
warn!(
msg_type = "ChangeResponse",
"Invalid state transition to Obsolete"
);
return Err(ActorError::Functional {
description:
"New state is Obsolete, is an invalid state"
.to_owned(),
});
}
if state == ApprovalState::Pending {
let (response, state) =
if ApprovalStateRes::Accepted == response {
(true, ApprovalState::Accepted)
} else {
(false, ApprovalState::Rejected)
};
let Some(approval_req) = self.request.clone() else {
error!(
msg_type = "ChangeResponse",
"Approval request not found"
);
return Err(ActorError::Functional {
description: "Can not get approval request"
.to_owned(),
});
};
if let Err(e) = self
.send_response(
ctx,
&approval_req,
response,
&self.request_id.to_string(),
self.version,
)
.await
{
error!(
msg_type = "ChangeResponse",
error = %e,
"Failed to send approval response"
);
return Err(emit_fail(ctx, e).await);
};
debug!(
msg_type = "ChangeResponse",
new_state = ?state,
"State changed successfully"
);
self.on_event(ApprPersistEvent::ChangeState { state }, ctx)
.await;
}
}
// aprobar si esta por defecto
ApprPersistMessage::LocalApproval {
request_id,
version,
approval_req,
} => {
if request_id.to_string() != self.request_id
|| version != self.version
{
let state =
if self.pass_votation == VotationType::AlwaysAccept {
if let Err(e) = self
.send_response(
ctx,
&approval_req,
true,
&request_id.to_string(),
version,
)
.await
{
error!(
msg_type = "LocalApproval",
error = %e,
"Failed to send approval response"
);
return Err(emit_fail(ctx, e).await);
}
ApprovalState::Accepted
} else {
ApprovalState::Pending
};
debug!(
msg_type = "LocalApproval",
request_id = %request_id,
version = version,
new_state = ?state,
"New approval request processed"
);
self.on_event(
ApprPersistEvent::SafeState {
subject_id: self.subject_id.clone(),
version,
request_id: request_id.to_string(),
request: Box::new(approval_req),
state,
},
ctx,
)
.await;
} else if let Some(state) = self.state.clone() {
let response = if state == ApprovalState::Accepted {
true
} else if state == ApprovalState::Rejected {
false
} else {
return Ok(ApprPersistResponse::Ok);
};
if let Err(e) = self
.send_response(
ctx,
&approval_req,
response,
&request_id.to_string(),
version,
)
.await
{
error!(
msg_type = "LocalApproval",
error = %e,
"Failed to resend approval response"
);
return Err(emit_fail(ctx, e).await);
}
debug!(
msg_type = "LocalApproval",
request_id = %request_id,
version = version,
"Response resent successfully"
);
}
}
ApprPersistMessage::NetworkRequest {
approval_req,
info,
sender,
} => {
if sender != approval_req.signature().signer
|| sender != self.node_key
{
warn!(
msg_type = "NetworkRequest",
expected_sender = %self.node_key,
received_sender = %sender,
"Unexpected sender"
);
return Ok(ApprPersistResponse::Ok);
}
if info.request_id != self.request_id
|| info.version != self.version
{
if let Err(e) = approval_req.verify() {
error!(
msg_type = "NetworkRequest",
error = %e,
"Invalid approval signature"
);
return Err(ActorError::Functional {
description: format!(
"Can not verify signature of request: {}",
e
),
});
}
let governance_check = match self
.check_governance(
ctx,
&approval_req.content().subject_id,
approval_req.content().gov_version,
)
.await
{
Ok(check) => check,
Err(e) => {
warn!(
msg_type = "NetworkRequest",
error = %e,
"Failed to check governance"
);
return Err(emit_fail(ctx, e).await);
}
};
if let Some(reason) = governance_check {
if let Err(e) = self
.send_signed_response(
ctx,
ApprovalRes::Abort(reason),
&approval_req,
&info.request_id,
info.version,
)
.await
{
error!(
msg_type = "NetworkRequest",
error = %e,
"Failed to send approval abort response"
);
return Err(emit_fail(ctx, e).await);
}
return Ok(ApprPersistResponse::Ok);
}
let state =
if self.pass_votation == VotationType::AlwaysAccept {
ApprovalState::Accepted
} else {
ApprovalState::Pending
};
self.on_event(
ApprPersistEvent::SafeState {
subject_id: self.subject_id.clone(),
request_id: info.request_id.clone(),
version: info.version,
request: Box::new(approval_req.clone()),
state: state.clone(),
},
ctx,
)
.await;
if state == ApprovalState::Accepted
&& let Err(e) = self
.send_response(
ctx,
&approval_req,
true,
&info.request_id,
info.version,
)
.await
{
error!(
msg_type = "NetworkRequest",
error = %e,
"Failed to send approval response"
);
return Err(emit_fail(ctx, e).await);
};
debug!(
msg_type = "NetworkRequest",
request_id = %info.request_id,
version = info.version,
new_state = ?state,
"Network approval request processed"
);
} else if !self.request_id.is_empty() {
let state = if let Some(state) = self.state.clone() {
state
} else {
warn!(
msg_type = "NetworkRequest",
"Approval state not found"
);
let e = ActorError::FunctionalCritical {
description: "Can not get state".to_owned(),
};
return Err(emit_fail(ctx, e).await);
};
let response = if ApprovalState::Accepted == state {
true
} else if ApprovalState::Rejected == state {
false
} else {
return Ok(ApprPersistResponse::Ok);
};
let approval_req =
if let Some(approval_req) = self.request.clone() {
approval_req
} else {
error!(
msg_type = "NetworkRequest",
"Approval request not found"
);
let e = ActorError::FunctionalCritical {
description: "Can not get approve request"
.to_owned(),
};
return Err(emit_fail(ctx, e).await);
};
if let Err(e) = self
.send_response(
ctx,
&approval_req,
response,
&self.request_id.to_string(),
self.version,
)
.await
{
error!(
msg_type = "NetworkRequest",
error = %e,
"Failed to resend approval response"
);
return Err(emit_fail(ctx, e).await);
};
debug!(
msg_type = "NetworkRequest",
request_id = %self.request_id,
version = self.version,
"Response resent successfully"
);
}
}
}
Ok(ApprPersistResponse::Ok)
}
async fn on_event(
&mut self,
event: ApprPersistEvent,
ctx: &mut ActorContext<Self>,
) {
if let Err(e) = self.persist(&event, ctx).await {
error!(error = %e, "Failed to persist event");
emit_fail(ctx, e).await;
};
if let Err(e) = ctx.publish_event(event).await {
error!(error = %e, "Failed to publish event");
emit_fail(ctx, e).await;
};
}
}
// Debemos persistir el estado de la petición hasta que se apruebe
#[async_trait]
impl PersistentActor for ApprPersist {
type Persistence = LightPersistence;
type InitParams = InitApprPersist;
fn update(&mut self, state: Self) {
self.request_id = state.request_id;
self.version = state.version;
self.state = state.state;
self.request = state.request;
}
fn create_initial(params: Self::InitParams) -> Self {
let Self::InitParams {
our_key,
node_key,
subject_id,
pass_votation,
helpers,
} = params;
Self {
helpers: Some(helpers),
node_key,
our_key,
request_id: String::default(),
version: 0,
subject_id,
pass_votation,
state: None,
request: None,
}
}
fn apply(&mut self, event: &Self::Event) -> Result<(), ActorError> {
match event {
ApprPersistEvent::ChangeState { state, .. } => {
debug!(
event_type = "ChangeState",
new_state = ?state,
"Approval state changed"
);
self.state = Some(state.clone());
}
ApprPersistEvent::SafeState {
request,
state,
request_id,
version,
..
} => {
debug!(
event_type = "SafeState",
request_id = %request_id,
version = version,
new_state = ?state,
"Approval state saved"
);
self.version = *version;
self.request_id.clone_from(request_id);
self.request = Some(*request.clone());
self.state = Some(state.clone());
}
};
Ok(())
}
}
impl Storable for ApprPersist {}