autd3-rs 0.1.0

Core async client library for the AUTD3 phased-array kit.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
use std::num::{NonZeroU32, NonZeroUsize};
use std::sync::Arc;
use std::sync::Mutex as StdMutex;
use std::time::Duration;

use crate::datagram::Datagram;
use crate::error::Error;
use crate::firmware_version::FirmwareVersion;
use crate::geometry::{Autd3, Geometry};
use crate::link::{CycleOutcome, Link};
use crate::operation::{Operation, XOR_HASH_MAX_DATA_LEN, XorHashCmd};
use crate::protocol::{
    Cmd, MAX_IN_FLIGHT, MODE_FIFO, MODE_LOW_LATENCY, PAYLOAD_BYTES, RX_FRAME_BYTES, TX_FRAME_BYTES,
    TxFrame,
};

use super::{Client, ClientConfig};

fn geometry(n: usize) -> Geometry {
    Geometry::new((0..n).map(|_| Autd3::default()).collect())
}

async fn xor_hash(client: &Client, cmd: &XorHashCmd) -> Result<(), Error> {
    let datagrams = client.datagram_builder().push(cmd).build()?;
    for frame in &datagrams {
        client.send_checked(frame).await?;
    }
    Ok(())
}

struct LoopbackLink {
    slaves: Vec<Arc<StdMutex<Slave>>>,
}

struct Slave {
    expected_seq: u8,
    ack: u8,
    data: u8,
    fw_version_major: u8,
    fw_version_minor: u8,
    fw_version_patch: u8,
    error_detail: u8,
    fpga_state: u8,
    drop_next: u32,
    stale_for_next: u32,
    sent_log: Vec<(u8, Cmd)>,
    xor_hash_total_sleep_ms: u32,
    mode: u8,
}

impl Slave {
    fn new() -> Self {
        Self {
            expected_seq: 0,
            ack: 0xFF,
            data: 0,
            fw_version_major: 0,
            fw_version_minor: 0,
            fw_version_patch: 0,
            error_detail: 0,
            fpga_state: 0,
            drop_next: 0,
            stale_for_next: 0,
            sent_log: Vec::new(),
            xor_hash_total_sleep_ms: 0,
            mode: MODE_FIFO,
        }
    }
}

const ERR_INVALID_PAYLOAD: u8 = 0x02;
const ERR_INVALID_DATA: u8 = 0x03;

fn handle_xor_hash(payload: &[u8; PAYLOAD_BYTES], slave: &mut Slave) -> u8 {
    let sleep_ms = u16::from_le_bytes([payload[0], payload[1]]);
    let data_len = u16::from_le_bytes([payload[2], payload[3]]) as usize;
    if data_len > XOR_HASH_MAX_DATA_LEN {
        slave.error_detail = ERR_INVALID_PAYLOAD;
        return ERR_INVALID_PAYLOAD;
    }
    slave.xor_hash_total_sleep_ms = slave
        .xor_hash_total_sleep_ms
        .saturating_add(u32::from(sleep_ms));
    let mut h: u8 = 0;
    for b in &payload[4..4 + data_len] {
        h ^= *b;
    }
    if h != 0 {
        slave.error_detail = ERR_INVALID_DATA;
        ERR_INVALID_DATA
    } else {
        0
    }
}

fn slave_cycle(
    slave: &mut Slave,
    tx: &[u8; TX_FRAME_BYTES],
    rx: &mut [u8; RX_FRAME_BYTES],
) -> bool {
    let parsed = TxFrame::parse(tx).expect("loopback only sees known cmds");
    slave.sent_log.push((parsed.seq.get(), parsed.cmd));

    if parsed.cmd == Cmd::Reset {
        slave.expected_seq = 0;
        slave.ack = 0xFF;
        slave.data = 0;
        *rx = [slave.ack, slave.data];
        return true;
    }

    if slave.stale_for_next > 0 {
        slave.stale_for_next -= 1;
        *rx = [slave.ack, slave.data];
        return false;
    }

    if parsed.seq.get() != slave.expected_seq {
        *rx = [slave.ack, slave.data];
        return true;
    }

    if slave.drop_next > 0 {
        slave.drop_next -= 1;
        *rx = [slave.ack, slave.data];
        return true;
    }

    slave.expected_seq = slave.expected_seq.wrapping_add(1);
    let data = match parsed.cmd {
        Cmd::XorHash => handle_xor_hash(&parsed.payload, slave),
        Cmd::ReadCpuFwVersionMajor => slave.fw_version_major,
        Cmd::ReadCpuFwVersionMinor => slave.fw_version_minor,
        Cmd::ReadCpuFwVersionPatch => slave.fw_version_patch,
        Cmd::ReadErrorDetail => slave.error_detail,
        Cmd::ReadFpgaState => slave.fpga_state,
        Cmd::WritePatternBuffer
        | Cmd::WritePatternCompressed
        | Cmd::WriteModulationBuffer
        | Cmd::ConfigModulation
        | Cmd::ConfigPattern
        | Cmd::ChangePatternBank
        | Cmd::ChangeModulationBank
        | Cmd::SetSilencer
        | Cmd::SetPhaseCorrection
        | Cmd::SetOutputMask
        | Cmd::SetPulseWidthTable
        | Cmd::EmulateGpioIn
        | Cmd::SetGpioOut
        | Cmd::ForceFan
        | Cmd::Synchronize
        | Cmd::Clear
        | Cmd::Nop => 0,
        Cmd::SetMode => {
            slave.mode = parsed.payload[0];
            0
        }
        Cmd::Reset => unreachable!(),
    };
    slave.ack = parsed.seq.get();
    slave.data = data;
    *rx = [slave.ack, slave.data];
    true
}

impl Link for LoopbackLink {
    type Error = std::convert::Infallible;
    type Checker = crate::link::ConstStateChecker;

    fn num_devices(&self) -> usize {
        self.slaves.len()
    }

    fn state_checker(&self) -> Self::Checker {
        crate::link::ConstStateChecker::new(self.slaves.len())
    }

    fn cycle(
        &mut self,
        tx: &[[u8; TX_FRAME_BYTES]],
        rx: &mut [[u8; RX_FRAME_BYTES]],
    ) -> Result<CycleOutcome, Self::Error> {
        let mut rx_valid = true;
        for ((tx, rx), slave) in tx.iter().zip(rx.iter_mut()).zip(&self.slaves) {
            let mut s = slave.lock().unwrap();
            rx_valid &= slave_cycle(&mut s, tx, rx);
        }
        Ok(CycleOutcome { rx_valid })
    }
}

fn slaves_pair(n: usize) -> (LoopbackLink, Vec<Arc<StdMutex<Slave>>>) {
    let slaves: Vec<_> = (0..n)
        .map(|_| Arc::new(StdMutex::new(Slave::new())))
        .collect();
    (
        LoopbackLink {
            slaves: slaves.clone(),
        },
        slaves,
    )
}

fn slave_pair() -> (LoopbackLink, Arc<StdMutex<Slave>>) {
    let (link, mut slaves) = slaves_pair(1);
    (link, slaves.pop().expect("one slave"))
}

async fn open_client() -> (Client, Arc<StdMutex<Slave>>) {
    let (link, slave) = slave_pair();
    let client = Client::open(&geometry(1), link, ClientConfig::default())
        .await
        .unwrap();
    (client, slave)
}

#[tokio::test]
async fn xor_hash_with_checksum_returns_ok() {
    let (client, slave) = open_client().await;
    let cmd = XorHashCmd::with_checksum(3, vec![0x01, 0x02, 0x04, 0x08]);
    xor_hash(&client, &cmd).await.unwrap();

    let s = slave.lock().unwrap();
    assert_eq!(s.ack, 2);
    assert_eq!(s.expected_seq, 3);
    assert_eq!(s.xor_hash_total_sleep_ms, 3);
    assert_eq!(s.error_detail, 0);
}

#[tokio::test]
async fn xor_hash_with_non_zero_xor_returns_device_error() {
    let (client, _slave) = open_client().await;
    let cmd = XorHashCmd {
        sleep_ms: 0,
        data: vec![0xAA],
    };
    let err = xor_hash(&client, &cmd).await.unwrap_err();
    match err {
        Error::DeviceError { device, code } => {
            assert_eq!(device, 0);
            assert_eq!(code, ERR_INVALID_DATA);
        }
        other => panic!("expected DeviceError, got {other:?}"),
    }
}

#[tokio::test]
async fn xor_hash_rejects_oversize_data_locally() {
    let (client, _slave) = open_client().await;
    let cmd = XorHashCmd {
        sleep_ms: 0,
        data: vec![0; XOR_HASH_MAX_DATA_LEN + 1],
    };
    let err = xor_hash(&client, &cmd).await.unwrap_err();
    assert!(matches!(err, Error::InvalidPayload(_)));
}

#[tokio::test]
async fn read_firmware_version_returns_full_triplet() {
    let (client, slave) = open_client().await;
    {
        let mut s = slave.lock().unwrap();
        s.fw_version_major = 1;
        s.fw_version_minor = 2;
        s.fw_version_patch = 3;
    }
    let v = client.read_firmware_version().await.unwrap();
    assert_eq!(
        v,
        vec![FirmwareVersion {
            major: 1,
            minor: 2,
            patch: 3,
        }]
    );
    assert_eq!(v[0].to_string(), "1.2.3");
}

#[tokio::test]
async fn read_error_detail_returns_error_code() {
    let (client, slave) = open_client().await;
    slave.lock().unwrap().error_detail = 0x7A;
    let e = client.read_error_detail().await.unwrap();
    assert_eq!(e, vec![0x7A]);
}

#[tokio::test]
async fn xor_hash_error_is_observable_via_read_error_detail() {
    let (client, _slave) = open_client().await;
    let bad = XorHashCmd {
        sleep_ms: 0,
        data: vec![0xAA],
    };
    let _ = xor_hash(&client, &bad).await;
    let detail = client.read_error_detail().await.unwrap();
    assert_eq!(detail, vec![ERR_INVALID_DATA]);
}

#[tokio::test]
async fn read_is_exclusive_and_correct_under_concurrent_writes() {
    let (link, slaves) = slaves_pair(2);
    {
        let mut s0 = slaves[0].lock().unwrap();
        s0.fw_version_major = 0xA0;
        s0.fw_version_minor = 0xA1;
        s0.fw_version_patch = 0xA2;
        let mut s1 = slaves[1].lock().unwrap();
        s1.fw_version_major = 0xB0;
        s1.fw_version_minor = 0xB1;
        s1.fw_version_patch = 0xB2;
    }
    let client = Arc::new(
        Client::open(&geometry(2), link, ClientConfig::default())
            .await
            .unwrap(),
    );

    let writer = {
        let client = Arc::clone(&client);
        tokio::spawn(async move {
            for _ in 0..50 {
                xor_hash(&client, &XorHashCmd::with_checksum(0, vec![0x01, 0x02]))
                    .await
                    .unwrap();
            }
        })
    };

    let expected = vec![
        FirmwareVersion {
            major: 0xA0,
            minor: 0xA1,
            patch: 0xA2,
        },
        FirmwareVersion {
            major: 0xB0,
            minor: 0xB1,
            patch: 0xB2,
        },
    ];
    for _ in 0..10 {
        assert_eq!(client.read_firmware_version().await.unwrap(), expected);
    }
    writer.await.unwrap();
}

#[tokio::test]
async fn multi_device_per_device_payloads_yield_per_device_results() {
    let (link, _slaves) = slaves_pair(2);
    let client = Client::open(&geometry(2), link, ClientConfig::default())
        .await
        .unwrap();

    let mut ok_payload = [0u8; PAYLOAD_BYTES];
    XorHashCmd::with_checksum(0, vec![0x01, 0x02])
        .encode(0, 0, &mut ok_payload)
        .unwrap();
    let ok = Datagram {
        cmd: Cmd::XorHash,
        payload: ok_payload,
    };

    let mut bad_payload = [0u8; PAYLOAD_BYTES];
    bad_payload[2] = 1;
    bad_payload[4] = 0xAA;

    let fut = client
        .send_datagrams(&[
            ok,
            Datagram {
                cmd: Cmd::XorHash,
                payload: bad_payload,
            },
        ])
        .await
        .unwrap();
    let resp = fut.await.unwrap();
    assert_eq!(resp.data, vec![0, ERR_INVALID_DATA]);
}

#[tokio::test]
async fn multi_device_xor_hash_reports_failing_device_index() {
    let (link, slaves) = slaves_pair(2);
    let client = Client::open(&geometry(2), link, ClientConfig::default())
        .await
        .unwrap();
    let bad = XorHashCmd {
        sleep_ms: 0,
        data: vec![0xAA],
    };
    let err = xor_hash(&client, &bad).await.unwrap_err();
    match err {
        Error::DeviceError { device, code } => {
            assert_eq!(device, 0);
            assert_eq!(code, ERR_INVALID_DATA);
        }
        other => panic!("expected DeviceError, got {other:?}"),
    }
    for slave in &slaves {
        assert_eq!(slave.lock().unwrap().error_detail, ERR_INVALID_DATA);
    }
}

#[tokio::test]
async fn multi_device_skip_on_one_device_recovers_via_resync() {
    let (link, slaves) = slaves_pair(2);
    slaves[1].lock().unwrap().fw_version_major = 0xB1;
    slaves[0].lock().unwrap().fw_version_major = 0xB0;
    let client = Client::open(
        &geometry(2),
        link,
        ClientConfig {
            timeout_cycles: 10,
            max_inflight: NonZeroUsize::new(16).unwrap(),
            send_interval_cycles: NonZeroU32::new(1).unwrap(),
            max_resync_rounds: NonZeroU32::new(8).unwrap(),
            low_latency: false,
            reset_resend_cycles: 2,
            rt_priority: None,
            rt_affinity: None,
            validate_state: true,
        },
    )
    .await
    .unwrap();
    slaves[1].lock().unwrap().drop_next = 1;

    let mut futs = Vec::new();
    for _ in 0..8 {
        futs.push(
            client
                .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
                .await
                .unwrap(),
        );
    }
    for f in futs {
        assert_eq!(
            f.await.unwrap().data,
            vec![0xB0, 0xB1],
            "resync must recover as success with per-device data"
        );
    }
    assert_eq!(slaves[0].lock().unwrap().expected_seq, 10);
    assert_eq!(slaves[1].lock().unwrap().expected_seq, 10);
}

#[tokio::test]
async fn send_rejects_wrong_datagram_count() {
    let (link, _slaves) = slaves_pair(2);
    let client = Client::open(&geometry(2), link, ClientConfig::default())
        .await
        .unwrap();
    let err = client
        .send_datagrams(&[Datagram::no_payload(Cmd::ReadCpuFwVersionMajor)])
        .await
        .err()
        .expect("send with wrong datagram count must fail");
    assert!(matches!(err, Error::InvalidPayload(_)));
}

#[tokio::test]
async fn handshake_sends_two_resets_with_seqs_zero_then_one() {
    let (_client, slave) = open_client().await;
    tokio::time::sleep(Duration::from_millis(20)).await;
    let s = slave.lock().unwrap();
    assert!(s.sent_log.len() >= 2);
    assert_eq!(s.sent_log[0], (0, Cmd::Reset));
    assert_eq!(s.sent_log[1], (1, Cmd::Reset));
    assert!(s.sent_log.contains(&(0, Cmd::Clear)));
    assert!(s.sent_log.contains(&(1, Cmd::Synchronize)));
}

#[tokio::test]
async fn low_latency_handshake_switches_slave_mode_and_continues_traffic() {
    let (link, slave) = slave_pair();
    let config = ClientConfig {
        low_latency: true,
        ..ClientConfig::default()
    };
    let client = Client::open(&geometry(1), link, config).await.unwrap();
    {
        let s = slave.lock().unwrap();
        assert_eq!(s.mode, MODE_LOW_LATENCY, "slave must switch to low-latency");
        assert!(s.sent_log.contains(&(0, Cmd::SetMode)));
        assert_eq!(s.expected_seq, 3);
    }
    xor_hash(&client, &XorHashCmd::with_checksum(0, vec![]))
        .await
        .unwrap();
    assert_eq!(slave.lock().unwrap().expected_seq, 4);
}

#[tokio::test]
async fn default_config_leaves_slave_in_fifo_mode() {
    let (_client, slave) = open_client().await;
    tokio::time::sleep(Duration::from_millis(20)).await;
    let s = slave.lock().unwrap();
    assert_eq!(s.mode, MODE_FIFO);
    assert!(!s.sent_log.iter().any(|(_, cmd)| *cmd == Cmd::SetMode));
}

#[tokio::test]
async fn handshake_resets_slave_proto_state() {
    let (link, slave) = slave_pair();
    {
        let mut s = slave.lock().unwrap();
        s.expected_seq = 42;
        s.ack = 41;
    }
    let client = Client::open(&geometry(1), link, ClientConfig::default())
        .await
        .unwrap();
    {
        let s = slave.lock().unwrap();
        assert_eq!(s.expected_seq, 2);
        assert_eq!(s.ack, 1);
    }
    xor_hash(&client, &XorHashCmd::with_checksum(0, vec![]))
        .await
        .unwrap();
    assert_eq!(slave.lock().unwrap().expected_seq, 3);
}

#[tokio::test]
async fn two_stage_await_resolves_in_order() {
    let (client, slave) = open_client().await;
    {
        let mut s = slave.lock().unwrap();
        s.fw_version_major = 0xAA;
        s.fw_version_minor = 0xBB;
    }
    let f1 = client
        .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
        .await
        .unwrap();
    let f2 = client
        .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMinor))
        .await
        .unwrap();
    let r1 = f1.await.unwrap();
    let r2 = f2.await.unwrap();
    assert_eq!(r1.data, vec![0xAA]);
    assert_eq!(r2.data, vec![0xBB]);
}

#[tokio::test]
async fn pipeline_continues_after_device_error_in_the_middle() {
    let (client, slave) = open_client().await;
    slave.lock().unwrap().fw_version_major = 0x42;

    let mut bad_payload = [0u8; PAYLOAD_BYTES];
    bad_payload[2] = 1;
    bad_payload[4] = 0xAA;

    let f1 = client
        .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
        .await
        .unwrap();
    let f2 = client
        .send_broadcast(&Datagram {
            cmd: Cmd::XorHash,
            payload: bad_payload,
        })
        .await
        .unwrap();
    let f3 = client
        .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
        .await
        .unwrap();

    assert_eq!(f1.await.unwrap().data, vec![0x42]);
    let mid = f2.await.unwrap();
    assert_eq!(mid.data, vec![ERR_INVALID_DATA]);
    assert_eq!(f3.await.unwrap().data, vec![0x42]);
}

#[tokio::test]
async fn streaming_skip_recovers_via_resync_without_timeout() {
    let (link, slave) = slave_pair();
    slave.lock().unwrap().fw_version_major = 0xAB;
    let client = Client::open(
        &geometry(1),
        link,
        ClientConfig {
            timeout_cycles: 10,
            max_inflight: NonZeroUsize::new(16).unwrap(),
            send_interval_cycles: NonZeroU32::new(1).unwrap(),
            max_resync_rounds: NonZeroU32::new(8).unwrap(),
            low_latency: false,
            reset_resend_cycles: 2,
            rt_priority: None,
            rt_affinity: None,
            validate_state: true,
        },
    )
    .await
    .unwrap();
    slave.lock().unwrap().drop_next = 1;

    let mut futs = Vec::new();
    for _ in 0..8 {
        futs.push(
            client
                .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
                .await
                .unwrap(),
        );
    }
    for f in futs {
        assert_eq!(
            f.await.unwrap().data,
            vec![0xAB],
            "resync must recover as success"
        );
    }
    assert_eq!(slave.lock().unwrap().expected_seq, 10);
}

#[tokio::test]
async fn dead_link_gives_up_whole_window_in_bounded_time() {
    let (link, slave) = slave_pair();
    let client = Client::open(
        &geometry(1),
        link,
        ClientConfig {
            timeout_cycles: 5,
            max_inflight: NonZeroUsize::new(8).unwrap(),
            send_interval_cycles: NonZeroU32::new(1).unwrap(),
            max_resync_rounds: NonZeroU32::new(3).unwrap(),
            low_latency: false,
            reset_resend_cycles: 2,
            rt_priority: None,
            rt_affinity: None,
            validate_state: true,
        },
    )
    .await
    .unwrap();
    slave.lock().unwrap().drop_next = u32::MAX;

    let mut futs = Vec::new();
    for _ in 0..3 {
        futs.push(
            client
                .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
                .await
                .unwrap(),
        );
    }
    for f in futs {
        assert!(
            matches!(f.await, Err(Error::Timeout { .. })),
            "dead link must surface Timeout, not hang",
        );
    }
}

#[tokio::test]
async fn stale_cycles_block_false_positive_ack_match() {
    let (client, slave) = open_client().await;
    {
        let mut s = slave.lock().unwrap();
        s.ack = 0;
        s.data = 0;
        s.stale_for_next = u32::MAX;
    }
    let err = xor_hash(&client, &XorHashCmd::with_checksum(0, vec![]))
        .await
        .unwrap_err();
    match err {
        Error::Timeout { cycles } => assert_eq!(cycles, 10),
        other => panic!("expected Timeout, got {other:?}"),
    }
}

#[tokio::test]
async fn recovers_after_transient_stale_cycles() {
    let (client, slave) = open_client().await;
    slave.lock().unwrap().stale_for_next = 3;
    xor_hash(&client, &XorHashCmd::with_checksum(0, vec![]))
        .await
        .expect("xor_hash should recover after the stale burst");
    let s = slave.lock().unwrap();
    assert_eq!(s.expected_seq, 3);
    assert_eq!(s.ack, 2);
}

fn seq0_reset_count(slave: &Arc<StdMutex<Slave>>) -> usize {
    slave
        .lock()
        .unwrap()
        .sent_log
        .iter()
        .filter(|(seq, cmd)| *cmd == Cmd::Reset && *seq == 0)
        .count()
}

#[tokio::test]
async fn inflight_held_across_stale_recovers_without_reset() {
    let (link, slave) = slave_pair();
    slave.lock().unwrap().fw_version_major = 0xAB;
    let client = Client::open(&geometry(1), link, ClientConfig::default())
        .await
        .unwrap();
    slave.lock().unwrap().stale_for_next = 40;

    let fut = client
        .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
        .await
        .unwrap();
    assert_eq!(
        fut.await.unwrap().data,
        vec![0xAB],
        "held in-flight must recover after the stale burst, not time out"
    );
    let s = slave.lock().unwrap();
    assert_eq!(
        s.expected_seq, 3,
        "Clear(seq0) + Synchronize(seq1) + one command, each once"
    );
    assert_eq!(s.ack, 2);
    drop(s);
    assert_eq!(
        seq0_reset_count(&slave),
        1,
        "no Reset escalation when the held front still matches expected_seq"
    );
}

#[tokio::test]
async fn streaming_holds_window_across_stale_and_recovers() {
    let (link, slave) = slave_pair();
    slave.lock().unwrap().fw_version_major = 0xAB;
    let client = Client::open(
        &geometry(1),
        link,
        ClientConfig {
            timeout_cycles: 10,
            max_inflight: NonZeroUsize::new(8).unwrap(),
            send_interval_cycles: NonZeroU32::new(1).unwrap(),
            max_resync_rounds: NonZeroU32::new(8).unwrap(),
            low_latency: false,
            reset_resend_cycles: 2,
            rt_priority: None,
            rt_affinity: None,
            validate_state: true,
        },
    )
    .await
    .unwrap();
    slave.lock().unwrap().stale_for_next = 30;

    let mut futs = Vec::new();
    for _ in 0..8 {
        futs.push(
            client
                .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
                .await
                .unwrap(),
        );
    }
    for f in futs {
        assert_eq!(
            f.await.unwrap().data,
            vec![0xAB],
            "every held in-flight must recover after the stale burst"
        );
    }
    assert_eq!(slave.lock().unwrap().expected_seq, 10);
    assert_eq!(seq0_reset_count(&slave), 1, "no Reset escalation needed");
}

#[tokio::test]
async fn frozen_ahead_desync_recovers_via_reset_resync() {
    let (link, slave) = slave_pair();
    slave.lock().unwrap().fw_version_major = 0xCD;
    let client = Client::open(&geometry(1), link, ClientConfig::default())
        .await
        .unwrap();
    slave.lock().unwrap().expected_seq = 200;

    let fut = client
        .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
        .await
        .unwrap();
    assert_eq!(
        fut.await.unwrap().data,
        vec![0xCD],
        "Reset re-sync must recover the desync instead of waiting for SEQ wraparound"
    );
    assert!(
        seq0_reset_count(&slave) > 1,
        "expected a Reset escalation beyond the single handshake seq-0 reset"
    );
}

#[tokio::test]
async fn close_resolves_pending_with_rt_closed() {
    let (client, slave) = open_client().await;
    slave.lock().unwrap().drop_next = u32::MAX;
    let f = client
        .send_broadcast(&Datagram::no_payload(Cmd::ReadCpuFwVersionMajor))
        .await
        .unwrap();
    client.close().await.unwrap();
    let err = f.await.unwrap_err();
    assert!(
        matches!(err, Error::RtClosed) || matches!(err, Error::Timeout { .. }),
        "expected RtClosed or Timeout, got {err:?}",
    );
}

#[tokio::test]
async fn open_rejects_oversize_max_inflight() {
    let (link, _slave) = slave_pair();
    let res = Client::open(
        &geometry(1),
        link,
        ClientConfig {
            timeout_cycles: 10,
            max_inflight: NonZeroUsize::new(MAX_IN_FLIGHT + 1).unwrap(),
            send_interval_cycles: NonZeroU32::new(1).unwrap(),
            max_resync_rounds: NonZeroU32::new(8).unwrap(),
            low_latency: false,
            reset_resend_cycles: 2,
            rt_priority: None,
            rt_affinity: None,
            validate_state: true,
        },
    )
    .await;
    assert!(matches!(res, Err(Error::InvalidPayload(_))));
}

#[tokio::test]
async fn open_rejects_zero_devices() {
    let (link, _slaves) = slaves_pair(0);
    let res = Client::open(&geometry(0), link, ClientConfig::default()).await;
    assert!(matches!(res, Err(Error::InvalidPayload(_))));
}

#[tokio::test]
async fn commands_still_succeed_with_send_interval_above_one() {
    let (link, slave) = slave_pair();
    {
        let mut s = slave.lock().unwrap();
        s.fw_version_major = 0x11;
        s.fw_version_minor = 0x22;
        s.fw_version_patch = 0x33;
    }
    let client = Client::open(
        &geometry(1),
        link,
        ClientConfig {
            timeout_cycles: 10,
            max_inflight: NonZeroUsize::new(8).unwrap(),
            send_interval_cycles: NonZeroU32::new(3).unwrap(),
            max_resync_rounds: NonZeroU32::new(8).unwrap(),
            low_latency: false,
            reset_resend_cycles: 2,
            rt_priority: None,
            rt_affinity: None,
            validate_state: true,
        },
    )
    .await
    .unwrap();
    let v = client.read_firmware_version().await.unwrap();
    assert_eq!(
        v,
        vec![FirmwareVersion {
            major: 0x11,
            minor: 0x22,
            patch: 0x33,
        }]
    );
}

#[tokio::test]
async fn build_rejects_too_fast_pattern_under_strict_silencer() {
    use crate::operation::{ConfigPattern, SetSilencer};
    use crate::value::{LoopBehavior, PatternBank, SamplingConfig};

    let (client, _slave) = open_client().await;
    let mut builder = client.datagram_builder();
    builder.push(SetSilencer::default()).push(ConfigPattern {
        bank: PatternBank::B0,
        config: SamplingConfig::FREQ_40K,
        size: 1,
        loop_behavior: LoopBehavior::Infinite,
    });
    match builder.build().unwrap_err() {
        Error::SilencerConstraint {
            device,
            axis,
            completion_steps,
            sampling_div,
        } => {
            assert_eq!(device, 0);
            assert_eq!(axis, crate::SilencerAxis::Intensity);
            assert_eq!(completion_steps, 10);
            assert_eq!(sampling_div, 1);
        }
        other => panic!("expected SilencerConstraint, got {other:?}"),
    }
}

#[tokio::test]
async fn build_rejects_strict_silencer_when_active_sampling_too_fast() {
    use crate::common::ULTRASOUND_PERIOD;
    use crate::operation::{ConfigModulation, FixedCompletionTime, SetSilencer};
    use crate::value::{LoopBehavior, ModulationBank, SamplingConfig};
    use core::num::NonZeroU16;

    let (client, _slave) = open_client().await;
    let mut builder = client.datagram_builder();
    builder
        .push(ConfigModulation {
            bank: ModulationBank::B0,
            config: SamplingConfig::new(NonZeroU16::new(5).unwrap()),
            size: 1,
            loop_behavior: LoopBehavior::Infinite,
        })
        .push(SetSilencer::new(FixedCompletionTime {
            intensity: ULTRASOUND_PERIOD * 8,
            phase: ULTRASOUND_PERIOD * 40,
            strict_mode: true,
        }));
    assert!(matches!(
        builder.build().unwrap_err(),
        Error::SilencerConstraint {
            axis: crate::SilencerAxis::Intensity,
            completion_steps: 8,
            sampling_div: 5,
            ..
        }
    ));
}

#[tokio::test]
async fn opt_out_disables_precheck() {
    use crate::operation::{ConfigPattern, SetSilencer};
    use crate::value::{LoopBehavior, PatternBank, SamplingConfig};

    let (link, _slave) = slave_pair();
    let config = ClientConfig {
        validate_state: false,
        ..ClientConfig::default()
    };
    let client = Client::open(&geometry(1), link, config).await.unwrap();
    let mut builder = client.datagram_builder();
    builder.push(SetSilencer::default()).push(ConfigPattern {
        bank: PatternBank::B0,
        config: SamplingConfig::FREQ_40K,
        size: 1,
        loop_behavior: LoopBehavior::Infinite,
    });
    assert!(
        builder.build().is_ok(),
        "opt-out must skip the local pre-check and defer to the CPU guard"
    );
}

#[tokio::test]
async fn desync_after_send_failure_stops_precheck() {
    use crate::operation::{ConfigPattern, SetSilencer};
    use crate::value::{LoopBehavior, PatternBank, SamplingConfig};

    let too_fast = |client: &Client| {
        let mut builder = client.datagram_builder();
        builder.push(ConfigPattern {
            bank: PatternBank::B0,
            config: SamplingConfig::FREQ_40K,
            size: 1,
            loop_behavior: LoopBehavior::Infinite,
        });
        builder.build()
    };

    let (client, slave) = open_client().await;

    let datagrams = client
        .datagram_builder()
        .push(SetSilencer::default())
        .build()
        .unwrap();
    for frame in &datagrams {
        client.send_checked(frame).await.unwrap();
    }

    assert!(matches!(
        too_fast(&client),
        Err(Error::SilencerConstraint { .. })
    ));

    slave.lock().unwrap().stale_for_next = u32::MAX;
    assert!(matches!(
        xor_hash(&client, &XorHashCmd::with_checksum(0, vec![]))
            .await
            .unwrap_err(),
        Error::Timeout { .. }
    ));

    assert!(
        too_fast(&client).is_ok(),
        "desynced mirror must stop pre-checking until the next Clear/reopen"
    );
}

#[tokio::test]
async fn build_rejects_transition_mode_incompatible_with_loop() {
    use crate::command::Modulation;
    use crate::value::{LoopBehavior, SamplingConfig, TransitionMode};
    use core::num::NonZeroU16;

    let data = [0x80u8; 4];
    let finite = LoopBehavior::Finite(NonZeroU16::new(2).unwrap());

    let (client, _slave) = open_client().await;

    let mut builder = client.datagram_builder();
    builder.push(Modulation {
        loop_behavior: finite,
        transition_mode: TransitionMode::Immediate,
        ..Modulation::new(SamplingConfig::FREQ_4K, &data)
    });
    assert!(
        matches!(
            builder.build().unwrap_err(),
            Error::TransitionConstraint {
                device: 0,
                transition_mode: TransitionMode::Immediate,
                bank_loop: crate::BankLoop::Finite,
            }
        ),
        "finite loop must reject an immediate transition"
    );

    let mut builder = client.datagram_builder();
    builder.push(Modulation {
        loop_behavior: finite,
        transition_mode: TransitionMode::SyncIdx,
        ..Modulation::new(SamplingConfig::FREQ_4K, &data)
    });
    assert!(
        builder.build().is_ok(),
        "finite loop with a timed transition is valid"
    );
}

#[tokio::test]
async fn build_rejects_timed_transition_on_infinite_loop() {
    use crate::geometry::Point3;
    use crate::stm::{FociStm, FociStmOption};
    use crate::value::{ControlPoints, GpioIn, LoopBehavior, SamplingConfig, TransitionMode};

    let points = [ControlPoints::from(Point3::new(0.0, 0.0, 150.0))];

    let (client, _slave) = open_client().await;

    let mut builder = client.datagram_builder();
    builder.push(FociStm::new(
        SamplingConfig::FREQ_4K,
        &points,
        FociStmOption {
            loop_behavior: LoopBehavior::Infinite,
            transition_mode: TransitionMode::Gpio(GpioIn::I1),
            ..Default::default()
        },
    ));
    assert!(
        matches!(
            builder.build().unwrap_err(),
            Error::TransitionConstraint {
                bank_loop: crate::BankLoop::Infinite,
                ..
            }
        ),
        "infinite loop must reject a GPIO-timed transition"
    );

    let mut builder = client.datagram_builder();
    builder.push(FociStm::new(
        SamplingConfig::FREQ_4K,
        &points,
        FociStmOption::default(),
    ));
    assert!(
        builder.build().is_ok(),
        "infinite loop with the default immediate transition is valid"
    );
}

#[tokio::test]
async fn transition_precheck_opts_out_with_validate_state() {
    use crate::command::Modulation;
    use crate::value::{LoopBehavior, SamplingConfig, TransitionMode};
    use core::num::NonZeroU16;

    let (link, _slave) = slave_pair();
    let config = ClientConfig {
        validate_state: false,
        ..ClientConfig::default()
    };
    let client = Client::open(&geometry(1), link, config).await.unwrap();

    let data = [0x80u8; 4];
    let mut builder = client.datagram_builder();
    builder.push(Modulation {
        loop_behavior: LoopBehavior::Finite(NonZeroU16::new(2).unwrap()),
        transition_mode: TransitionMode::Immediate,
        ..Modulation::new(SamplingConfig::FREQ_4K, &data)
    });
    assert!(
        builder.build().is_ok(),
        "opt-out must skip the transition pre-check and defer to the firmware"
    );
}

#[tokio::test]
async fn build_rejects_per_device_group_under_strict_silencer() {
    use crate::operation::{ConfigModulation, SetSilencer};
    use crate::value::{LoopBehavior, ModulationBank, SamplingConfig};
    use core::num::NonZeroU16;

    let (link, _slaves) = slaves_pair(2);
    let client = Client::open(&geometry(2), link, ClientConfig::default())
        .await
        .unwrap();

    let datagrams = client
        .datagram_builder()
        .push(SetSilencer::default())
        .build()
        .unwrap();
    for frame in &datagrams {
        client.send_checked(frame).await.unwrap();
    }

    let mut builder = client.datagram_builder();
    builder.push_each(|device| {
        Some(ConfigModulation {
            bank: ModulationBank::B0,
            config: SamplingConfig::new(NonZeroU16::new(if device == 0 { 5 } else { 20 }).unwrap()),
            size: 1,
            loop_behavior: LoopBehavior::Infinite,
        })
    });
    match builder.build().unwrap_err() {
        Error::SilencerConstraint { device, .. } => assert_eq!(device, 0),
        other => panic!("expected SilencerConstraint on device 0, got {other:?}"),
    }
}

#[tokio::test]
async fn separate_builders_share_committed_mirror_state() {
    use crate::operation::{ConfigPattern, SetSilencer};
    use crate::value::{LoopBehavior, PatternBank, SamplingConfig};

    let (client, _slave) = open_client().await;
    client
        .datagram_builder()
        .push(SetSilencer::default())
        .build()
        .unwrap();
    let mut b2 = client.datagram_builder();
    b2.push(ConfigPattern {
        bank: PatternBank::B0,
        config: SamplingConfig::FREQ_40K,
        size: 1,
        loop_behavior: LoopBehavior::Infinite,
    });
    assert!(matches!(b2.build(), Err(Error::SilencerConstraint { .. })));
}