aurora-lint 0.4.336

aurora-lint - a fast CERT C static analyzer
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
use super::super::{CertRule, RuleViolation};
use crate::manifest::{RuleCategory, Severity};
use crate::utility::cert_c::ast_utils::get_node_text;
use lang_parsing_substrate::query;
use std::collections::HashSet;
use tree_sitter::Node;

pub struct Exp40C;

impl CertRule for Exp40C {
    fn rule_id(&self) -> &'static str {
        "EXP40-C"
    }

    fn description(&self) -> &'static str {
        "Do not modify constant objects"
    }

    fn severity(&self) -> Severity {
        Severity::Low
    }

    fn category(&self) -> RuleCategory {
        RuleCategory::Rule
    }

    fn cert_id(&self) -> &'static str {
        "EXP40-C"
    }

    fn check(&self, node: &Node, source: &str) -> Vec<RuleViolation> {
        let mut violations = Vec::new();

        // Global (true file-scope) const vars are visible from every function,
        // but locals must stay scoped to the function they're declared in --
        // otherwise a const-qualified local in one function conflates with a
        // same-named non-const local in another (same bug class as task 389's
        // EXP39-C/ARR30-C and the follow-on sweep of 7 other rules).
        let mut global_const_vars = HashSet::new();
        collect_top_level_const_vars(node, source, &mut global_const_vars);

        // Check assignments/declarations that live outside any function body
        // using only the global set.
        check_node_recursive_pruned(node, source, &global_const_vars, &mut violations);

        // Check each function independently, seeded with the global consts
        // plus that function's own locals/parameters.
        for function in collect_function_definitions(node) {
            let mut const_vars = global_const_vars.clone();
            collect_const_vars(&function, source, &mut const_vars);
            check_node_recursive(&function, source, &const_vars, &mut violations);
        }

        violations
    }
}

/// Collect all `function_definition` nodes from the AST. Uses an explicit
/// stack instead of recursion; pruning at nested `function_definition`
/// boundaries (which can't occur in C, but keeps the shape consistent with
/// the other rules in this family) keeps this shallow in practice.
fn collect_function_definitions<'a>(node: &Node<'a>) -> Vec<Node<'a>> {
    let mut functions = Vec::new();
    let mut stack = vec![*node];
    while let Some(n) = stack.pop() {
        if n.kind() == "function_definition" {
            functions.push(n);
            continue;
        }
        for i in (0..n.child_count()).rev() {
            if let Some(child) = n.child(i) {
                stack.push(child);
            }
        }
    }
    functions
}

/// Collect const-qualified variable names declared outside any function body
/// (true file scope), pruning descent at `function_definition` boundaries so
/// function-local declarations aren't mistaken for globals.
fn collect_top_level_const_vars(node: &Node, source: &str, const_vars: &mut HashSet<String>) {
    let mut stack = vec![*node];
    while let Some(n) = stack.pop() {
        if n.kind() == "function_definition" {
            continue;
        }
        collect_const_vars_from_node(&n, source, const_vars);
        for i in (0..n.child_count()).rev() {
            if let Some(child) = n.child(i) {
                stack.push(child);
            }
        }
    }
}

/// Same traversal shape as [`collect_function_definitions`]/
/// [`collect_top_level_const_vars`]: check assignment/declaration nodes that
/// live outside any function body, pruning descent at `function_definition`
/// boundaries so per-function checks (run separately, with per-function
/// scoped `const_vars`) don't get duplicated here.
fn check_node_recursive_pruned(
    node: &Node,
    source: &str,
    const_vars: &HashSet<String>,
    violations: &mut Vec<RuleViolation>,
) {
    let mut stack = vec![*node];
    while let Some(n) = stack.pop() {
        if n.kind() == "function_definition" {
            continue;
        }
        match n.kind() {
            "assignment_expression" => {
                check_assignment(&n, source, const_vars, violations);
            }
            "init_declarator" => {
                check_init_declarator(&n, source, const_vars, violations);
            }
            "pointer_declarator" => {
                check_pointer_assignment(&n, source, violations);
            }
            _ => {}
        }
        for i in (0..n.child_count()).rev() {
            if let Some(child) = n.child(i) {
                stack.push(child);
            }
        }
    }
}

/// Collect all const-qualified variable names from declarations and parameters
/// anywhere in `node`'s subtree (callers scope `node` to a single function to
/// keep locals from conflating across functions).
fn collect_const_vars(node: &Node, source: &str, const_vars: &mut HashSet<String>) {
    for descendant in
        query::find_descendants_of_kinds(*node, &["declaration", "parameter_declaration"])
    {
        collect_const_vars_from_node(&descendant, source, const_vars);
    }
}

/// Same per-node matching as [`collect_const_vars`], but applied to a single
/// node rather than a whole subtree -- used by the pruned stack walk in
/// [`collect_top_level_const_vars`], which needs to skip descent at
/// `function_definition` boundaries.
fn collect_const_vars_from_node(node: &Node, source: &str, const_vars: &mut HashSet<String>) {
    match node.kind() {
        "declaration" => {
            // Check if declaration has const qualifier
            let decl_text = get_node_text(node, source);
            if decl_text.contains("const") {
                // Extract variable names from this declaration
                for i in 0..node.child_count() {
                    if let Some(child) = node.child(i) {
                        if child.kind() == "init_declarator" {
                            if let Some(declarator) = child.child_by_field_name("declarator") {
                                if let Some(name) = extract_var_name(&declarator, source) {
                                    const_vars.insert(name);
                                }
                            }
                        } else if child.kind() == "pointer_declarator"
                            || child.kind() == "identifier"
                        {
                            if let Some(name) = extract_var_name(&child, source) {
                                const_vars.insert(name);
                            }
                        }
                    }
                }
            }
        }
        "parameter_declaration" => {
            let param_text = get_node_text(node, source);
            if param_text.contains("const") {
                if let Some(declarator) = node.child_by_field_name("declarator") {
                    if let Some(name) = extract_var_name(&declarator, source) {
                        const_vars.insert(name);
                    }
                }
            }
        }
        _ => {}
    }
}

/// Extract variable name from a declarator node
fn extract_var_name(node: &Node, source: &str) -> Option<String> {
    match node.kind() {
        "identifier" => Some(get_node_text(node, source).to_string()),
        "pointer_declarator" | "array_declarator" => {
            if let Some(declarator) = node.child_by_field_name("declarator") {
                return extract_var_name(&declarator, source);
            }
            for i in 0..node.child_count() {
                if let Some(child) = node.child(i) {
                    if child.kind() == "identifier" {
                        return Some(get_node_text(&child, source).to_string());
                    }
                }
            }
            None
        }
        _ => None,
    }
}

fn check_node_recursive(
    node: &Node,
    source: &str,
    const_vars: &HashSet<String>,
    violations: &mut Vec<RuleViolation>,
) {
    for descendant in query::find_descendants_of_kinds(
        *node,
        &[
            "assignment_expression",
            "init_declarator",
            "pointer_declarator",
        ],
    ) {
        match descendant.kind() {
            "assignment_expression" => {
                check_assignment(&descendant, source, const_vars, violations);
            }
            "init_declarator" => {
                check_init_declarator(&descendant, source, const_vars, violations);
            }
            "pointer_declarator" => {
                check_pointer_assignment(&descendant, source, violations);
            }
            _ => {}
        }
    }
}

/// Check if an assignment removes const qualification
fn check_assignment(
    node: &Node,
    source: &str,
    _const_vars: &HashSet<String>,
    violations: &mut Vec<RuleViolation>,
) {
    if let (Some(left), Some(right)) = (
        node.child_by_field_name("left"),
        node.child_by_field_name("right"),
    ) {
        let left_text = get_node_text(&left, source);
        let right_text = get_node_text(&right, source);

        // Check if we're assigning through a pointer that removes const
        // Pattern: *ptr = value where ptr might point to const data
        if left_text.starts_with('*') {
            // Get the pointer variable
            let _ptr_var = left_text.trim_start_matches('*').trim();

            // If the RHS contains a const object or const pointer, flag it
            if is_potentially_const_violating(&right, source) {
                report_violation(
                    node,
                    source,
                    violations,
                    &format!(
                        "Potential modification of const object through pointer: '{}' = '{}'",
                        left_text, right_text
                    ),
                );
            }
        }

        // Check for assigning &non_const_ptr to const_ptr_ptr (const T ** = &(T *))
        // Pattern: ipp = &ip where ipp is const int ** and ip is int *
        if left.kind() == "identifier" && right.kind() == "pointer_expression" {
            if let Some(op) = right.child_by_field_name("operator") {
                if get_node_text(&op, source) == "&" {
                    // Check if this identifier was declared with const ** pattern
                    if is_const_pointer_to_pointer_var(&left_text, node, source) {
                        report_violation(
                            node,
                            source,
                            violations,
                            &format!(
                                "Assigning address of non-const pointer to const-qualified pointer-to-pointer: {} = {}",
                                left_text, right_text
                            ),
                        );
                    }
                }
            }
        }
    }
}

/// Check if a variable name was declared as const T **
fn is_const_pointer_to_pointer_var(var_name: &str, node: &Node, source: &str) -> bool {
    // Find the translation_unit (root)
    let mut root = *node;
    while let Some(parent) = root.parent() {
        root = parent;
    }

    // Search for declarations of this variable
    find_const_ptr_ptr_decl(&root, var_name, source)
}

fn find_const_ptr_ptr_decl(node: &Node, var_name: &str, source: &str) -> bool {
    query::find_descendants_of_kind(*node, "declaration")
        .into_iter()
        .any(|decl| {
            let decl_text = get_node_text(&decl, source);
            // Check for patterns like "const int **varname" or "const T **varname"
            if decl_text.contains("const")
                && decl_text.contains("**")
                && decl_text.contains(var_name)
            {
                // Make sure const is before ** (not after like int * const *)
                if let Some(const_pos) = decl_text.find("const") {
                    if let Some(ptr_ptr_pos) = decl_text.find("**") {
                        if const_pos < ptr_ptr_pos {
                            return true;
                        }
                    }
                }
            }
            false
        })
}

/// Check init_declarator for const removal in initialization
fn check_init_declarator(
    node: &Node,
    source: &str,
    const_vars: &HashSet<String>,
    violations: &mut Vec<RuleViolation>,
) {
    // Get declarator and value
    if let Some(declarator) = node.child_by_field_name("declarator") {
        if let Some(value) = node.child_by_field_name("value") {
            // Check if this is a pointer declaration
            if is_pointer_declarator(&declarator) {
                let decl_text = get_node_text(&declarator, source);
                let value_text = get_node_text(&value, source);

                // Check if const is in the parent declaration's type specifiers
                let parent_has_const = node
                    .parent()
                    .filter(|p| p.kind() == "declaration")
                    .is_some_and(|decl| {
                        // Check type specifiers in the declaration for const
                        let mut cursor = decl.walk();
                        for child in decl.children(&mut cursor) {
                            if child.kind() == "type_qualifier" {
                                let q = get_node_text(&child, source);
                                if q == "const" {
                                    return true;
                                }
                            }
                        }
                        false
                    });

                // If the declarator is a non-const pointer but the value is const, flag it
                // Skip if the parent declaration already has const qualifier
                if !parent_has_const
                    && !contains_const_keyword(&declarator, source)
                    && is_const_qualified(&value, source, const_vars)
                {
                    report_violation(
                        node,
                        source,
                        violations,
                        &format!(
                            "Pointer to const assigned to non-const pointer without cast: {} = {}",
                            decl_text, value_text
                        ),
                    );
                }
            }
        }
    }
}

/// Check pointer assignments in declarations
fn check_pointer_assignment(node: &Node, source: &str, violations: &mut Vec<RuleViolation>) {
    let node_text = get_node_text(node, source);

    // Look for patterns like "int **ipp" where const qualification might be violated
    // This is a simplified check - a full implementation would need type tracking
    if node_text.contains("**") && node.parent().is_some() {
        if let Some(parent) = node.parent() {
            if parent.kind() == "init_declarator" {
                if let Some(value) = parent.child_by_field_name("value") {
                    let value_text = get_node_text(&value, source);
                    // Check if we're creating a pointer-to-pointer that could bypass const
                    if value_text.contains('&') && !contains_const_in_pointer_chain(node, source) {
                        // This could be a const bypass - check more carefully
                        check_pointer_to_pointer_const(&parent, source, violations);
                    }
                }
            }
        }
    }
}

/// Check if a node is a pointer declarator
fn is_pointer_declarator(node: &Node) -> bool {
    node.kind() == "pointer_declarator" || (node.kind() == "declarator" && has_pointer_child(node))
}

/// Check if node has a pointer child
fn has_pointer_child(node: &Node) -> bool {
    for i in 0..node.child_count() {
        if let Some(child) = node.child(i) {
            if child.kind() == "pointer_declarator" || child.kind() == "*" {
                return true;
            }
            if has_pointer_child(&child) {
                return true;
            }
        }
    }
    false
}

/// Check if a node or its ancestors contain const keyword
fn contains_const_keyword(node: &Node, source: &str) -> bool {
    // Check current node
    let text = get_node_text(node, source);
    if text.contains("const") {
        return true;
    }

    // Check children
    query::find_first_descendant(*node, |n| {
        n.kind() == "type_qualifier" && get_node_text(&n, source) == "const"
    })
    .is_some()
}

/// Check if a value is const-qualified
fn is_const_qualified(node: &Node, source: &str, const_vars: &HashSet<String>) -> bool {
    match node.kind() {
        "pointer_expression" => {
            // &const_var
            if let Some(argument) = node.child_by_field_name("argument") {
                return is_const_qualified(&argument, source, const_vars);
            }
        }
        "identifier" => {
            let name = get_node_text(node, source);
            return const_vars.contains(name);
        }
        _ => {
            // Check if node has const in its type
            return contains_const_keyword(node, source);
        }
    }
    false
}

/// Check if expression might be violating const
fn is_potentially_const_violating(node: &Node, source: &str) -> bool {
    // Look for address-of expressions (&var) - only flag if argument is const
    if node.kind() == "pointer_expression" {
        if let Some(operator) = node.child_by_field_name("operator") {
            let op_text = get_node_text(&operator, source);
            if op_text == "&" {
                // Only flag if taking address of const-qualified object
                if let Some(argument) = node.child_by_field_name("argument") {
                    return contains_const_keyword(&argument, source);
                }
            }
        }
    }

    // Check for const keyword directly in expression
    contains_const_keyword(node, source)
}

/// Check if pointer declaration chain contains const
fn contains_const_in_pointer_chain(node: &Node, source: &str) -> bool {
    let mut current = *node;

    // Walk up to declaration
    while let Some(parent) = current.parent() {
        if parent.kind() == "declaration" {
            return contains_const_keyword(&parent, source);
        }
        current = parent;
    }

    false
}

/// Check pointer-to-pointer const bypass patterns
fn check_pointer_to_pointer_const(node: &Node, source: &str, violations: &mut Vec<RuleViolation>) {
    // Pattern from wiki: const int **ipp; int *ip; ipp = &ip;
    // This allows *ipp to be assigned a const int*, then *ip can modify it

    if let Some(declarator) = node.child_by_field_name("declarator") {
        let decl_text = get_node_text(&declarator, source);
        if let Some(value) = node.child_by_field_name("value") {
            let value_text = get_node_text(&value, source);

            // Check if we have const ** pattern assigned from non-const *
            // This is a simplified heuristic
            if decl_text.contains("**") {
                if value_text.contains('&') && !value_text.contains("const") {
                    report_violation(
                        node,
                        source,
                        violations,
                        &format!(
                            "Pointer-to-pointer assignment may allow const circumvention: {} = {}",
                            decl_text, value_text
                        ),
                    );
                }
            }
        }
    }
}

/// Report a violation
fn report_violation(node: &Node, source: &str, violations: &mut Vec<RuleViolation>, message: &str) {
    let start_point = node.start_position();
    let node_text = get_node_text(node, source);

    violations.push(RuleViolation {
        rule_id: "EXP40-C".to_string(),
        severity: Severity::Low,
        message: format!("{}: '{}'", message, node_text),
        file_path: String::new(),
        line: start_point.row + 1,
        column: start_point.column + 1,
        suggestion: Some(
            "Either remove const qualifier if the object should be modifiable, or use explicit casts to show intentional const removal"
                .to_string(),
        ),
        ..Default::default()
    });
}