aube 1.5.0

Aube — a fast Node.js package manager
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
//! `aube doctor` — broad install-health diagnostic.
//!
//! Prints a grouped snapshot of aube's environment (version, directories,
//! project layout, registries, node version) followed by any warnings and
//! errors we can detect statically. Mirrors the shape of `mise doctor`:
//! info sections first, then an accumulated list of warnings, then a list
//! of errors. Exits non-zero when the error list is non-empty.
//!
//! Individual checks (`check_virtual_store_links`, `check_install_state`,
//! `check_foreign_package_manager_dirs`) are kept as free functions so
//! they can be reused from more focused commands in the future without
//! round-tripping through the formatter.
//!
//! The diagnostic itself is read-only: reads config, package.json,
//! `.aube-state`, and walks `node_modules/.aube/` — never writes the
//! project. After the report renders, fires the async update notifier
//! (network-bound on a cold cache, cached for 24 h thereafter), which
//! also writes `<cacheDir>/update-check.json` on a successful fetch.

use clap::Args;
use miette::Context;
use serde_json::{Map, Value};
use std::path::{Path, PathBuf};

pub const AFTER_LONG_HELP: &str = "\
Examples:

  $ aube doctor
  version: 1.0.0-beta.4
  node: v22.11.0
  ...
  No problems found

  $ aube doctor --json | jq .warnings
";

#[derive(Debug, Args)]
pub struct DoctorArgs {
    /// Emit a machine-readable JSON report instead of the grouped text.
    #[arg(long, short = 'J')]
    pub json: bool,
}

pub async fn run(args: DoctorArgs) -> miette::Result<()> {
    let cwd = crate::dirs::cwd()?;
    let project_root = crate::dirs::find_project_root(&cwd);
    let anchor = project_root.clone().unwrap_or_else(|| cwd.clone());

    let report = build_report(&anchor, project_root.is_some())?;

    if args.json {
        print_json(&report);
    } else {
        print_human(&report);
    }

    crate::update_check::check_and_notify(&anchor).await;

    if !report.errors.is_empty() {
        std::process::exit(1);
    }
    Ok(())
}

#[derive(Debug, Default)]
struct Report {
    sections: Vec<Section>,
    warnings: Vec<String>,
    errors: Vec<String>,
}

#[derive(Debug)]
struct Section {
    title: &'static str,
    items: Vec<(String, String)>,
}

impl Section {
    fn new(title: &'static str) -> Self {
        Self {
            title,
            items: Vec::new(),
        }
    }

    fn push(&mut self, key: impl Into<String>, value: impl Into<String>) {
        self.items.push((key.into(), value.into()));
    }
}

fn build_report(anchor: &Path, in_project: bool) -> miette::Result<Report> {
    let mut report = Report::default();

    report.sections.push(version_section());
    report.sections.push(runtime_section(&mut report.warnings));
    report.sections.push(dirs_section(anchor));

    if in_project {
        let project = project_section(anchor, &mut report);
        report.sections.push(project);
        check_install_state(anchor, &mut report);
        check_foreign_package_manager_dirs(anchor, &mut report);
        check_virtual_store_links(anchor, &mut report)?;
    } else {
        let mut s = Section::new("project");
        s.push(
            "status",
            "no package.json at or above the current directory",
        );
        report.sections.push(s);
    }

    report.sections.push(registry_section(anchor));

    Ok(report)
}

fn version_section() -> Section {
    let mut s = Section::new("version");
    s.push("aube", env!("CARGO_PKG_VERSION"));
    s.push(
        "build-profile",
        if cfg!(debug_assertions) {
            "debug"
        } else {
            "release"
        },
    );
    s.push("target", std::env::consts::OS);
    s.push("arch", std::env::consts::ARCH);
    s
}

fn runtime_section(warnings: &mut Vec<String>) -> Section {
    let mut s = Section::new("runtime");
    match crate::engines::resolve_node_version(None) {
        Some(v) => s.push("node", format!("v{v}")),
        None => {
            s.push("node", "(not found)");
            warnings.push(
                "`node` is not available on PATH — lifecycle scripts and `aube run` will fail"
                    .to_string(),
            );
        }
    }
    if let Some(shell) = std::env::var_os("SHELL")
        && let Some(text) = shell.to_str()
    {
        s.push("shell", text);
    }
    s
}

fn dirs_section(anchor: &Path) -> Section {
    let mut s = Section::new("dirs");
    let store_root = aube_store::dirs::store_dir()
        .map(display_path_owned)
        .unwrap_or_else(|| "(unresolved)".into());
    s.push("store", store_root);
    s.push(
        "cache",
        display_path_owned(super::resolved_cache_dir(anchor)),
    );
    s.push(
        "packument-cache",
        display_path_owned(super::resolved_cache_dir(anchor).join("packuments-v1")),
    );
    s.push(
        "virtual-store",
        display_path_owned(super::resolve_virtual_store_dir_for_cwd(anchor)),
    );
    s
}

fn project_section(anchor: &Path, report: &mut Report) -> Section {
    let mut s = Section::new("project");
    s.push("root", display_path_owned(anchor));

    match aube_manifest::PackageJson::from_path(&anchor.join("package.json")) {
        Ok(manifest) => {
            let label = match (&manifest.name, &manifest.version) {
                (Some(n), Some(v)) => format!("{n}@{v}"),
                (Some(n), None) => n.clone(),
                _ => "(unnamed)".into(),
            };
            s.push("package", label);
            if let Some(range) = manifest.engines.get("node")
                && let Some(node) = crate::engines::resolve_node_version(None)
            {
                match (
                    node_semver::Version::parse(&node),
                    node_semver::Range::parse(range),
                ) {
                    (Ok(v), Ok(r)) if !v.satisfies(&r) => {
                        report.errors.push(format!(
                            "root package requires node {range}, but this is v{node}"
                        ));
                    }
                    _ => {}
                }
            }
            if let Some(pm) = manifest
                .extra
                .get("packageManager")
                .and_then(|v| v.as_str())
            {
                s.push("package-manager", pm);
            }
        }
        Err(err) => {
            report.errors.push(format!(
                "failed to parse package.json at {}: {err}",
                display_path_owned(anchor.join("package.json"))
            ));
        }
    }

    let lockfile = aube_lockfile::detect_existing_lockfile_kind(anchor);
    s.push(
        "lockfile",
        lockfile
            .map(|k| k.filename().to_string())
            .unwrap_or_else(|| "(none — first install will create aube-lock.yaml)".to_string()),
    );

    s
}

fn registry_section(anchor: &Path) -> Section {
    let mut s = Section::new("registry");
    let config = super::load_npm_config(anchor);
    s.push("default", &config.registry);
    if !config.scoped_registries.is_empty() {
        let scoped = config
            .scoped_registries
            .iter()
            .map(|(k, v)| format!("{k} -> {v}"))
            .collect::<Vec<_>>()
            .join(", ");
        s.push("scoped", scoped);
    }
    let client = super::make_client(anchor);
    let auth_state = if client.has_resolved_auth_for(&config.registry) {
        "configured"
    } else {
        "(none)"
    };
    s.push("auth", auth_state);
    s
}

fn check_install_state(anchor: &Path, report: &mut Report) {
    if let Some(reason) = crate::state::check_needs_install(anchor) {
        // "install state not found" on a project that has no
        // `node_modules/` yet is expected — it's informational, not an
        // error. Any *other* reason (lockfile/manifest hash drift,
        // missing modules dir on a state file that otherwise exists)
        // is a real staleness signal.
        let modules_dir = super::project_modules_dir(anchor);
        if modules_dir.exists() {
            report.warnings.push(format!(
                "node_modules is stale: {reason}. Run `aube install`."
            ));
        }
    }
}

/// Scan for artifacts other package managers leave behind. aube
/// deliberately co-exists with whatever's already on disk — we never
/// reach into `.pnpm/` / `.yarn/` — but a user running two PMs against
/// the same project is a recipe for drift, so surface any leftovers as
/// warnings. We cover every layout that writes a marker at a known
/// path:
///
/// - `node_modules/.pnpm/`  → pnpm's isolated virtual store
/// - `<project>/.yarn/`     → yarn berry (zero-install cache / PnP support files)
/// - `<project>/.pnp.cjs`
///   or `<project>/.pnp.loader.mjs` → yarn PnP (no `node_modules` at all)
///
/// Yarn-classic and npm leave no distinctive marker — both write plain
/// flat `node_modules/` trees — so we can't detect them here. Users
/// running either against an aube project will still notice at
/// `aube install` time when the lockfile is rewritten.
fn check_foreign_package_manager_dirs(anchor: &Path, report: &mut Report) {
    let modules = super::project_modules_dir(anchor);
    if modules.join(".pnpm").is_dir() {
        report.warnings.push(
            "node_modules/.pnpm/ exists alongside aube's tree — this project was last installed with pnpm. aube and pnpm can co-exist, but expect both trees to drift unless you pick one."
                .to_string(),
        );
    }
    if anchor.join(".yarn").is_dir() {
        report.warnings.push(
            ".yarn/ exists at the project root — this project was last touched with yarn (berry or the zero-install flow). Safe to delete if you've committed to aube.".to_string(),
        );
    }
    if anchor.join(".pnp.cjs").is_file() || anchor.join(".pnp.loader.mjs").is_file() {
        report.warnings.push(
            "yarn PnP loader files (.pnp.cjs / .pnp.loader.mjs) are present — Node may still run from PnP instead of aube's node_modules/ until they're removed.".to_string(),
        );
    }
}

fn check_virtual_store_links(anchor: &Path, report: &mut Report) -> miette::Result<()> {
    let links = super::check::run_report(anchor).wrap_err("failed to walk the virtual store")?;
    if !links.issues.is_empty() {
        report.errors.push(format!(
            "{} broken {} in node_modules/.aube/ (run `aube check` for details)",
            links.issues.len(),
            if links.issues.len() == 1 {
                "dependency link"
            } else {
                "dependency links"
            }
        ));
    }
    Ok(())
}

fn display_path_owned(p: impl AsRef<Path>) -> String {
    let p = p.as_ref();
    if let Some(home) = std::env::var_os("HOME")
        && let Ok(rest) = p.strip_prefix(PathBuf::from(&home))
    {
        return format!("~/{}", rest.display());
    }
    p.display().to_string()
}

fn print_human(report: &Report) {
    for section in &report.sections {
        if section.items.is_empty() {
            continue;
        }
        println!("{}:", section.title);
        let max = section
            .items
            .iter()
            .map(|(k, _)| k.len())
            .max()
            .unwrap_or(0);
        for (k, v) in &section.items {
            println!("  {:<width$}  {}", k, v, width = max);
        }
        println!();
    }

    if !report.warnings.is_empty() {
        let label = if report.warnings.len() == 1 {
            "warning"
        } else {
            "warnings"
        };
        println!("{} {label}:", report.warnings.len());
        for (i, w) in report.warnings.iter().enumerate() {
            println!("  {}. {w}", i + 1);
        }
        println!();
    }

    if report.errors.is_empty() {
        println!("No problems found");
    } else {
        let label = if report.errors.len() == 1 {
            "problem"
        } else {
            "problems"
        };
        println!("{} {label} found:", report.errors.len());
        for (i, e) in report.errors.iter().enumerate() {
            println!("  {}. {e}", i + 1);
        }
    }
}

fn print_json(report: &Report) {
    let mut root = Map::new();
    let mut sections = Map::new();
    for section in &report.sections {
        let mut items = Map::new();
        for (k, v) in &section.items {
            items.insert(k.clone(), Value::String(v.clone()));
        }
        sections.insert(section.title.to_string(), Value::Object(items));
    }
    root.insert("sections".into(), Value::Object(sections));
    root.insert(
        "warnings".into(),
        Value::Array(report.warnings.iter().cloned().map(Value::String).collect()),
    );
    root.insert(
        "errors".into(),
        Value::Array(report.errors.iter().cloned().map(Value::String).collect()),
    );
    let out =
        serde_json::to_string_pretty(&Value::Object(root)).unwrap_or_else(|_| "{}".to_string());
    println!("{out}");
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn doctor_runs_outside_a_project() {
        let tmp = tempfile::tempdir().unwrap();
        let report = build_report(tmp.path(), false).unwrap();
        assert!(
            !report.sections.is_empty(),
            "expected at least version + dirs sections"
        );
    }

    #[test]
    fn doctor_runs_inside_a_minimal_project() {
        let tmp = tempfile::tempdir().unwrap();
        let cwd = tmp.path();
        std::fs::write(
            cwd.join("package.json"),
            r#"{"name":"demo","version":"0.1.0"}"#,
        )
        .unwrap();
        let report = build_report(cwd, true).unwrap();
        assert!(report.sections.iter().any(|s| s.title == "project"));
    }
}