aria2-core 0.3.3

aria2-rust core download engine: multi-protocol segmented downloads, rate limiting, configuration, session persistence, and BitTorrent seeding
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
//! Tests for session persistence module.

use super::*;
use std::fs;
use std::path::PathBuf;
use std::sync::Arc;

use crate::engine::resume_data::ResumeData;
use crate::request::request_group::{
    DownloadOptions, FollowMode, GroupId, MetadataInfo, RequestGroup,
};
use crate::util::rwlock_ext::RwLockRecover;

/// Helper to create a temporary directory for tests
fn create_test_session_dir() -> PathBuf {
    let ts = std::time::SystemTime::now()
        .duration_since(std::time::UNIX_EPOCH)
        .unwrap_or_default()
        .as_nanos()
        % 1_000_000_000;
    let dir =
        std::env::temp_dir().join(format!("aria2_session_test_{}_{}", std::process::id(), ts));
    let _ = fs::remove_dir_all(&dir);
    fs::create_dir_all(&dir).expect("Failed to create test session directory");
    dir
}

/// Helper to create test RequestGroups
fn create_test_groups(count: usize) -> Vec<Arc<std::sync::RwLock<RequestGroup>>> {
    let mut groups = Vec::new();
    for i in 0..count {
        let gid = GroupId::new(i as u64 + 1000);
        let uri = format!("http://example.com/file{}.bin", i);
        let options = DownloadOptions {
            dir: Some("/downloads".to_string()),
            split: Some(4),
            ..Default::default()
        };
        let group = Arc::new(std::sync::RwLock::new(RequestGroup::new(
            gid,
            vec![uri],
            options,
        )));
        groups.push(group);
    }
    groups
}

#[tokio::test]
async fn test_session_save_creates_files() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);

    let groups = create_test_groups(3);

    // Save state
    let saved_count = persistence
        .save_state(&groups)
        .await
        .expect("Save should succeed");

    assert_eq!(saved_count, 3, "Should save 3 commands");

    // Verify .aria2 files were created
    let entries: Vec<_> = fs::read_dir(&session_dir)
        .expect("Should read session dir")
        .filter_map(|e| e.ok())
        .collect();

    // Should have at least 3 .aria2 files + 1 options file
    let aria2_count = entries
        .iter()
        .filter(|e| {
            e.path()
                .extension()
                .map(|ext| ext == "aria2")
                .unwrap_or(false)
        })
        .count();

    assert_eq!(aria2_count, 3, "Should have 3 .aria2 files");

    // Verify each file contains valid JSON with GID
    for entry in entries.iter().filter(|e| {
        e.path()
            .extension()
            .map(|ext| ext == "aria2")
            .unwrap_or(false)
    }) {
        let content = fs::read_to_string(entry.path()).expect("Should read file");
        let parsed: serde_json::Value =
            serde_json::from_str(&content).expect("Should be valid JSON");
        assert!(
            parsed.get("gid").is_some(),
            "Each .aria2 file should contain a GID field"
        );
    }

    // Clean up
    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_session_save_removes_stale_resume_files() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);
    let groups = create_test_groups(1);
    let resume_path = session_dir.join(format!(
        "{}.aria2",
        groups[0].recover().gid().to_hex_string()
    ));

    persistence.save_state(&groups).await.unwrap();
    assert!(resume_path.exists());

    let empty_groups: Vec<Arc<std::sync::RwLock<RequestGroup>>> = Vec::new();
    persistence.save_state(&empty_groups).await.unwrap();

    assert!(
        !resume_path.exists(),
        "an empty authoritative snapshot must remove stale resume files"
    );

    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_generated_children_are_excluded_from_json_persistence() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);

    let parent = Arc::new(std::sync::RwLock::new(RequestGroup::new(
        GroupId::new(2001),
        vec!["http://example.com/metadata.torrent".to_string()],
        DownloadOptions::default(),
    )));
    let child = Arc::new(std::sync::RwLock::new(RequestGroup::new(
        GroupId::new(2002),
        vec!["http://example.com/payload.bin".to_string()],
        DownloadOptions::default(),
    )));
    child.recover().set_belongs_to_gid(GroupId::new(2001));

    let saved = persistence.save_state(&[parent, child]).await.unwrap();
    assert_eq!(saved, 1);
    assert!(session_dir.join("00000000000007d1.aria2").exists());
    assert!(!session_dir.join("00000000000007d2.aria2").exists());

    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_session_load_restores_commands() {
    let session_dir = create_test_session_dir();
    let mut persistence = SessionPersistence::new(&session_dir);

    // Create and save original groups
    let original_groups = create_test_groups(2);
    let saved = persistence
        .save_state(&original_groups)
        .await
        .expect("Save should succeed");
    assert_eq!(saved, 2, "Should save 2 commands");

    // Load into empty groups vector
    let mut loaded_groups: Vec<Arc<std::sync::RwLock<RequestGroup>>> = Vec::new();
    let loaded = persistence
        .load_state(&mut loaded_groups)
        .await
        .expect("Load should succeed");

    assert_eq!(loaded, 2, "Should restore 2 commands");

    // Verify restored groups have URIs
    let mut found_uris: Vec<String> = Vec::new();
    for group_lock in &loaded_groups {
        let group = group_lock.recover();
        for uri in group.uris() {
            found_uris.push(uri.clone());
        }
    }

    assert!(
        found_uris.iter().any(|u| u.contains("file0.bin")),
        "Should restore first file URI"
    );
    assert!(
        found_uris.iter().any(|u| u.contains("file1.bin")),
        "Should restore second file URI"
    );

    // Clean up
    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_session_restore_preserves_progress_pause_and_bt_state() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);
    let group = Arc::new(std::sync::RwLock::new(RequestGroup::new(
        GroupId::new(0x456),
        vec!["bt://payload".to_string()],
        DownloadOptions {
            dir: Some(session_dir.to_string_lossy().into_owned()),
            out: Some("payload.bin".to_string()),
            checksum: Some(("sha-256".to_string(), "deadbeef".to_string())),
            ..Default::default()
        },
    )));
    group.recover().set_total_length(4096);
    group.recover().set_completed_length(1024);
    group.recover().set_uploaded_length(512);
    group.recover().set_bt_bitfield(Some(vec![0x80, 0x01]));
    group.recover().set_bt_metadata(
        8,
        512,
        "00112233445566778899aabbccddeeff00112233".to_string(),
    );
    group.recover_mut().pause().unwrap();

    assert_eq!(
        persistence.save_state(&[Arc::clone(&group)]).await.unwrap(),
        1
    );

    let mut restored = Vec::new();
    assert_eq!(
        SessionPersistence::new(&session_dir)
            .load_state(&mut restored)
            .await
            .unwrap(),
        1
    );
    let restored = restored[0].recover();
    assert_eq!(restored.total_length(), 4096);
    assert_eq!(restored.completed_length(), 1024);
    assert_eq!(restored.upload_length(), 512);
    assert_eq!(restored.get_bt_bitfield(), Some(vec![0x80, 0x01]));
    assert_eq!(restored.get_bt_num_pieces(), 8);
    assert_eq!(restored.get_bt_piece_length(), 512);
    assert_eq!(
        restored.get_bt_info_hash_hex().as_deref(),
        Some("00112233445566778899aabbccddeeff00112233")
    );
    assert!(restored.status().is_paused());
    assert_eq!(
        restored
            .options()
            .checksum
            .as_ref()
            .map(|(_, value)| value.as_str()),
        Some("deadbeef")
    );
    assert_eq!(
        restored.options().dir.as_deref(),
        Some(session_dir.to_string_lossy().as_ref())
    );
    assert_eq!(restored.options().out.as_deref(), Some("payload.bin"));

    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_session_save_empty_no_error() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);

    // Save empty groups list - should succeed without error
    let empty_groups: Vec<Arc<std::sync::RwLock<RequestGroup>>> = Vec::new();
    let result = persistence.save_state(&empty_groups).await;

    assert!(result.is_ok(), "Saving empty session should not error");
    let saved_count = result.unwrap();
    assert_eq!(saved_count, 0, "Empty session should report 0 saved");

    // Session directory should still exist (with options file at least)
    assert!(
        session_dir.exists(),
        "Session dir should be created even for empty save"
    );

    // Clean up
    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_session_corrupted_file_skipped_gracefully() {
    let session_dir = create_test_session_dir();
    fs::create_dir_all(&session_dir).expect("Session directory should exist");

    // Create a corrupted .aria2 file
    let corrupt_file = session_dir.join("corrupt-gid.aria2");
    fs::write(&corrupt_file, "THIS IS NOT VALID JSON {{{{").expect("Should write corrupt file");

    // Also create a valid .aria2 file
    let valid_file = session_dir.join("valid-gid.aria2");
    let valid_resume_data = ResumeData {
        gid: "abc123".to_string(),
        uris: vec![crate::engine::resume_data::UriState {
            uri: "http://example.com/valid-file.bin".to_string(),
            tried: true,
            used: false,
            last_result: None,
            speed_bytes_per_sec: None,
        }],
        total_length: 1024,
        completed_length: 512,
        uploaded_length: 0,
        bitfield: vec![],
        num_pieces: None,
        piece_length: None,
        status: "paused".to_string(),
        error_message: None,
        last_download_time: 0,
        created_at: 0,
        output_path: Some("/downloads/valid-file.bin".to_string()),
        checksum: None,
        options: std::collections::HashMap::new(),
        resume_offset: Some(512),
        bt_info_hash: None,
        bt_saved_metadata_path: None,
        metalink_data: None,
        metalink_file_index: None,
    };
    valid_resume_data
        .save_to_file(&valid_file)
        .expect("Should write valid file");

    let mut persistence = SessionPersistence::new(&session_dir);
    let mut loaded_groups: Vec<Arc<std::sync::RwLock<RequestGroup>>> = Vec::new();

    // Load should succeed despite corrupt file
    let result = persistence.load_state(&mut loaded_groups).await;

    assert!(result.is_ok(), "Load should succeed despite corrupt file");
    let loaded_count = result.unwrap();
    assert_eq!(
        loaded_count, 1,
        "Should load 1 valid file (corrupt one skipped)"
    );

    // Verify the valid one was loaded correctly
    assert_eq!(loaded_groups.len(), 1, "Should have 1 restored group");

    // Clean up
    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_session_load_rejects_duplicate_gid() {
    let session_dir = create_test_session_dir();
    let first = ResumeData {
        gid: "2a".to_string(),
        uris: vec![crate::engine::resume_data::UriState {
            uri: "http://example.com/first.bin".to_string(),
            ..Default::default()
        }],
        ..Default::default()
    };
    let second = ResumeData {
        gid: "2a".to_string(),
        uris: vec![crate::engine::resume_data::UriState {
            uri: "http://example.com/second.bin".to_string(),
            ..Default::default()
        }],
        ..Default::default()
    };
    first
        .save_to_file(&session_dir.join("first.aria2"))
        .unwrap();
    second
        .save_to_file(&session_dir.join("second.aria2"))
        .unwrap();

    let mut persistence = SessionPersistence::new(&session_dir);
    let mut groups = Vec::new();
    assert_eq!(persistence.load_state(&mut groups).await.unwrap(), 1);
    assert_eq!(groups[0].recover().gid(), GroupId::new(0x2a));

    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_metadata_provenance_roundtrip_via_json_persistence() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);
    let group = Arc::new(std::sync::RwLock::new(RequestGroup::new(
        GroupId::new(0xabc),
        vec!["bt://payload".to_string()],
        DownloadOptions::default(),
    )));
    group.recover().set_metadata_info(
        MetadataInfo::new(GroupId::new(0xabc), "https://example.test/meta.torrent")
            .with_metadata_path(session_dir.join("payload.torrent").to_string_lossy()),
    );

    assert_eq!(
        persistence.save_state(&[Arc::clone(&group)]).await.unwrap(),
        1
    );
    let mut restored = Vec::new();
    assert_eq!(
        SessionPersistence::new(&session_dir)
            .load_state(&mut restored)
            .await
            .unwrap(),
        1
    );
    let restored_info = restored[0].recover().metadata_info();
    assert!(restored_info.is_some());
    assert_eq!(
        restored_info.as_ref().and_then(|info| info.metadata_path()),
        Some(
            session_dir
                .join("payload.torrent")
                .to_string_lossy()
                .as_ref()
        )
    );

    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_follow_mode_variants_roundtrip_via_persistence() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);
    let modes = [
        (FollowMode::Follow, FollowMode::Disabled),
        (FollowMode::Disabled, FollowMode::Follow),
        (FollowMode::Memory, FollowMode::Memory),
    ];
    let groups = modes
        .iter()
        .enumerate()
        .map(|(index, &(follow_torrent, follow_metalink))| {
            Arc::new(std::sync::RwLock::new(RequestGroup::new(
                GroupId::new(0x400 + index as u64),
                vec![format!("https://example.test/metadata-{index}.bin")],
                DownloadOptions {
                    follow_torrent: Some(follow_torrent),
                    follow_metalink: Some(follow_metalink),
                    ..Default::default()
                },
            )))
        })
        .collect::<Vec<_>>();

    assert_eq!(persistence.save_state(&groups).await.unwrap(), modes.len());

    let mut restored = Vec::new();
    assert_eq!(
        SessionPersistence::new(&session_dir)
            .load_state(&mut restored)
            .await
            .unwrap(),
        modes.len()
    );

    for (index, &(follow_torrent, follow_metalink)) in modes.iter().enumerate() {
        let group = restored
            .iter()
            .find(|group| group.recover().gid() == GroupId::new(0x400 + index as u64))
            .expect("follow-mode group should be restored");
        let options = group.recover().options().clone();
        assert_eq!(options.follow_torrent, Some(follow_torrent));
        assert_eq!(options.follow_metalink, Some(follow_metalink));
    }

    let _ = fs::remove_dir_all(&session_dir);
}

#[cfg(all(feature = "metalink", feature = "bittorrent"))]
#[tokio::test]
async fn test_metalink_torrent_graph_is_rebuilt_after_session_load() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);
    let metadata_path = session_dir.join("payload.torrent");
    let payload = Arc::new(std::sync::RwLock::new(RequestGroup::new(
        GroupId::new(0x222),
        vec!["bt://metadata".to_string()],
        DownloadOptions {
            dir: Some(session_dir.to_string_lossy().into_owned()),
            out: Some("payload.bin".to_string()),
            ..Default::default()
        },
    )));
    payload.recover().set_metadata_info(
        MetadataInfo::new(GroupId::new(0x111), "https://example.test/payload.torrent")
            .with_metadata_path(metadata_path.to_string_lossy()),
    );

    assert_eq!(
        persistence
            .save_state(&[Arc::clone(&payload)])
            .await
            .unwrap(),
        1
    );

    let mut restored = Vec::new();
    assert_eq!(
        SessionPersistence::new(&session_dir)
            .load_state(&mut restored)
            .await
            .unwrap(),
        1
    );
    assert_eq!(restored.len(), 2);

    let metadata = restored
        .iter()
        .find(|group| group.recover().gid() == GroupId::new(0x111))
        .expect("metadata prerequisite should be restored");
    assert_eq!(
        metadata.recover().uris(),
        &["https://example.test/payload.torrent".to_string()]
    );
    assert_eq!(
        metadata.recover().belongs_to_gid(),
        Some(GroupId::new(0x222))
    );

    let restored_payload = restored
        .iter()
        .find(|group| group.recover().gid() == GroupId::new(0x222))
        .expect("payload should be restored");
    assert!(!restored_payload.recover().is_dependency_resolved());
    assert_eq!(
        restored_payload.recover().metadata_info().unwrap().gid(),
        Some(GroupId::new(0x111))
    );

    let _ = fs::remove_dir_all(&session_dir);
}

#[cfg(all(feature = "metalink", feature = "bittorrent"))]
#[tokio::test]
async fn test_json_session_roundtrip_preserves_metalink_graph_descriptor() {
    let session_dir = create_test_session_dir();
    let options = DownloadOptions {
        dir: Some(session_dir.to_string_lossy().into_owned()),
        ..Default::default()
    };
    let graph = crate::engine::metalink_request_graph::MetalinkRequestGraph::new_memory_with_fallback_and_mappings(
        "https://example.test/payload.torrent",
        "payload.bin",
        &options,
        GroupId::new(0x501),
        GroupId::new(0x502),
        vec!["https://mirror.example.test/payload.bin".to_string()],
        vec![crate::request::request_group::BtFileMapping {
            original_name: "payload.bin".to_string(),
            path: session_dir.join("payload.bin").to_string_lossy().into_owned(),
            uris: vec!["https://mirror.example.test/payload.bin".to_string()],
            max_connection_per_server: 3,
            unique_protocol: true,
        }],
    )
    .unwrap();
    let torrent_data = {
        let mut data =
            b"d8:announce28:http://tracker.test/announce4:infod6:lengthi0e4:name4:test12:piece lengthi16384e6:pieces20:".to_vec();
        data.extend_from_slice(&[
            0xda, 0x39, 0xa3, 0xee, 0x5e, 0x6b, 0x4b, 0x0d, 0x32, 0x55, 0xbf, 0xef, 0x95, 0x60,
            0x18, 0x90, 0xaf, 0xd8, 0x07, 0x09,
        ]);
        data.extend_from_slice(b"ee");
        data
    };
    let torrent_len = torrent_data.len();
    graph
        .payload
        .recover()
        .set_bt_metadata_data(torrent_data.clone());

    let persistence = SessionPersistence::new(&session_dir);
    assert_eq!(
        persistence
            .save_state(&[Arc::clone(&graph.payload)])
            .await
            .unwrap(),
        1
    );

    let mut restored = Vec::new();
    assert_eq!(
        SessionPersistence::new(&session_dir)
            .load_state(&mut restored)
            .await
            .unwrap(),
        1
    );
    assert_eq!(restored.len(), 2);

    let payload = restored
        .iter()
        .find(|group| group.recover().gid() == GroupId::new(0x502))
        .expect("payload should be restored");
    let descriptor = payload
        .recover()
        .bt_dependency_descriptor()
        .expect("BT dependency descriptor should be rebuilt");
    assert!(descriptor.0);
    assert_eq!(
        descriptor.1,
        vec!["https://mirror.example.test/payload.bin"]
    );
    assert_eq!(descriptor.2.len(), 1);
    assert_eq!(descriptor.2[0].max_connection_per_server, 3);
    assert!(descriptor.2[0].unique_protocol);
    assert_eq!(payload.recover().bt_metadata_data(), Some(torrent_data));

    let metadata = restored
        .iter()
        .find(|group| group.recover().gid() == GroupId::new(0x501))
        .expect("metadata source should be restored");
    assert!(metadata.recover().is_in_memory_download());
    assert_eq!(
        metadata.recover().in_memory_data().map(|data| data.len()),
        Some(torrent_len)
    );

    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_session_load_nonexistent_dir_returns_zero() {
    let nonexistent_dir =
        PathBuf::from("/tmp/aria2_nonexistent_test_dir_that_should_not_exist_12345");
    let mut persistence = SessionPersistence::new(&nonexistent_dir);

    let mut groups: Vec<Arc<std::sync::RwLock<RequestGroup>>> = Vec::new();
    let result = persistence.load_state(&mut groups).await;

    assert!(result.is_ok(), "Nonexistent dir should return Ok");
    assert_eq!(result.unwrap(), 0, "Nonexistent dir should return 0 loaded");
    assert!(groups.is_empty(), "No groups should be added");
}

#[tokio::test]
async fn test_session_cleanup_removes_all_files() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);

    // Create some files
    let groups = create_test_groups(2);
    let _ = persistence.save_state(&groups).await.unwrap();

    // Verify files exist
    assert!(
        session_dir.exists(),
        "Session dir should exist before cleanup"
    );

    // Cleanup
    persistence.cleanup().await.expect("Cleanup should succeed");

    // Verify directory is empty or removed
    if session_dir.exists() {
        let remaining: Vec<_> = fs::read_dir(&session_dir)
            .expect("Should read dir")
            .filter_map(|e| e.ok())
            .collect();
        assert!(
            remaining.is_empty(),
            "All files should be removed after cleanup"
        );
    }

    // Clean up
    let _ = fs::remove_dir_all(&session_dir);
}

#[tokio::test]
async fn test_resume_data_roundtrip_via_persistence() {
    let session_dir = create_test_session_dir();
    let mut persistence = SessionPersistence::new(&session_dir);

    // Create a group with specific properties
    let gid = GroupId::new(0xDEADBEEF);
    let options = DownloadOptions {
        dir: Some("/test/downloads".to_string()),
        out: Some("special_file.iso".to_string()),
        split: Some(16),
        ..Default::default()
    };
    let group = Arc::new(std::sync::RwLock::new(RequestGroup::new(
        gid,
        vec!["http://example.com/special_file.iso".to_string()],
        options,
    )));

    // Set some progress
    {
        let g = group.recover_mut();
        g.set_total_length_atomic(10485760); // 10MB
        g.set_completed_length(5242880); // 5MB
    }

    // Save
    let saved = persistence.save_state(&[group]).await.unwrap();
    assert_eq!(saved, 1);

    // Load back
    let mut loaded: Vec<Arc<std::sync::RwLock<RequestGroup>>> = Vec::new();
    let loaded_count = persistence.load_state(&mut loaded).await.unwrap();
    assert_eq!(loaded_count, 1);

    // Verify the loaded group has correct URIs
    let restored = loaded[0].read().unwrap();
    let uris = restored.uris();
    assert_eq!(uris.len(), 1);
    assert!(uris[0].contains("special_file.iso"));

    // Clean up
    let _ = fs::remove_dir_all(&session_dir);
}

// =====================================================================
// K2.4 — New Tests for Session Enhancements
// =====================================================================

/// Test K2.4 #1: Selective save of active downloads only.
///
/// Creates a mix of active and completed downloads, then verifies that
/// save_active_only() only persists the active/waiting ones.
#[tokio::test]
async fn test_selective_save_active_only() {
    let session_dir = create_test_session_dir();
    let persistence = SessionPersistence::new(&session_dir);

    // Create groups with different statuses
    let mut groups: Vec<Arc<std::sync::RwLock<RequestGroup>>> = Vec::new();

    // Active download (should be saved)
    let active_gid = GroupId::new(1001);
    let active_group = Arc::new(std::sync::RwLock::new(RequestGroup::new(
        active_gid,
        vec!["http://example.com/active.bin".to_string()],
        DownloadOptions::default(),
    )));
    {
        let mut g = active_group.recover_mut();
        g.start().unwrap(); // Set to Active status
    }
    groups.push(active_group);

    // Waiting download (should be saved)
    let waiting_gid = GroupId::new(1002);
    let waiting_group = Arc::new(std::sync::RwLock::new(RequestGroup::new(
        waiting_gid,
        vec!["http://example.com/waiting.bin".to_string()],
        DownloadOptions::default(),
    )));
    // Waiting is default status, no need to change
    groups.push(waiting_group);

    // Completed download (should NOT be saved)
    let complete_gid = GroupId::new(1003);
    let complete_group = Arc::new(std::sync::RwLock::new(RequestGroup::new(
        complete_gid,
        vec!["http://example.com/complete.bin".to_string()],
        DownloadOptions::default(),
    )));
    {
        let mut g = complete_group.recover_mut();
        g.complete().unwrap(); // Set to Complete status
    }
    groups.push(complete_group);

    // Save only active/waiting
    let saved_count = persistence.save_active_only(&groups).await.unwrap();

    // Should save exactly 2 (active + waiting)
    assert_eq!(
        saved_count, 2,
        "save_active_only should save only active and waiting downloads"
    );

    // Verify files on disk - should have 2 .aria2 files
    let entries: Vec<_> = fs::read_dir(&session_dir)
        .expect("Should read session dir")
        .filter_map(|e| e.ok())
        .filter(|e| {
            e.path()
                .extension()
                .map(|ext| ext == "aria2")
                .unwrap_or(false)
        })
        .collect();

    assert_eq!(
        entries.len(),
        2,
        "Should have exactly 2 .aria2 files for active+waiting"
    );

    // Clean up
    let _ = fs::remove_dir_all(&session_dir);
}

/// Test K2.4 #2: DHT snapshot roundtrip preserves data.
///
/// Creates a DhtStateSnapshot with sample data, serializes it to JSON,
/// then deserializes and verifies all fields are preserved correctly.
#[test]
fn test_dht_snapshot_roundtrip() {
    use crate::session::session_persistence::{DhtNodeInfo, DhtStateSnapshot};

    // Create original snapshot with data
    let node1 = DhtNodeInfo {
        id: [1u8; 20],
        addr: "192.168.1.100:6881".to_string(),
        last_seen_epoch_secs: 1700000000,
    };

    let node2 = DhtNodeInfo {
        id: [2u8; 20],
        addr: "10.0.0.5:6881".to_string(),
        last_seen_epoch_secs: 1700000100,
    };

    let token_secret: [u8; 20] = [0xAB; 20];

    let original = DhtStateSnapshot::new(vec![node1, node2], token_secret, Some(1699999000));

    // Verify initial state
    assert_eq!(original.total_nodes, 2);
    assert_eq!(original.nodes.len(), 2);
    assert!(original.last_bootstrap_epoch_secs.is_some());

    // Serialize to JSON
    let json = original
        .to_json_string()
        .expect("Serialization should succeed");
    assert!(!json.is_empty(), "JSON output should not be empty");
    assert!(
        json.contains("192.168.1.100"),
        "JSON should contain first node address"
    );
    assert!(
        json.contains("10.0.0.5"),
        "JSON should contain second node address"
    );

    // Deserialize from JSON
    let restored =
        DhtStateSnapshot::from_json_string(&json).expect("Deserialization should succeed");

    // Verify all fields match
    assert_eq!(restored.total_nodes, 2, "total_nodes should be preserved");
    assert_eq!(restored.nodes.len(), 2, "nodes count should be preserved");
    assert_eq!(
        restored.token_secret, token_secret,
        "token_secret should be preserved"
    );
    assert_eq!(
        restored.last_bootstrap_epoch_secs,
        Some(1699999000),
        "last_bootstrap_epoch_secs should be preserved"
    );

    // Verify individual node data
    assert_eq!(
        restored.nodes[0].id, [1u8; 20],
        "First node ID should match"
    );
    assert_eq!(
        restored.nodes[0].addr, "192.168.1.100:6881",
        "First node address should match"
    );
    assert_eq!(
        restored.nodes[0].last_seen_epoch_secs, 1700000000,
        "First node timestamp should match"
    );

    assert_eq!(
        restored.nodes[1].id, [2u8; 20],
        "Second node ID should match"
    );
    assert_eq!(
        restored.nodes[1].addr, "10.0.0.5:6881",
        "Second node address should match"
    );

    // Test empty snapshot
    let empty = DhtStateSnapshot::empty();
    assert_eq!(empty.total_nodes, 0, "Empty snapshot should have 0 nodes");
    assert!(
        empty.nodes.is_empty(),
        "Empty snapshot should have no nodes"
    );

    let empty_json = empty
        .to_json_string()
        .expect("Empty serialization should succeed");
    let empty_restored =
        DhtStateSnapshot::from_json_string(&empty_json).expect("Empty deserialization should work");
    assert_eq!(
        empty_restored.total_nodes, 0,
        "Restored empty should still be empty"
    );
}

/// Test K2.4 #3: Cookie persistence integration - cookies survive save/load cycle.
///
/// Creates a SessionPersistence with cookies, saves state, loads it into
/// a new instance, and verifies cookies are preserved.
#[tokio::test]
async fn test_cookie_persist_integration() {
    use crate::http::cookie_storage::{CookieJar, JarCookie};

    let session_dir = create_test_session_dir();

    // Create original session with cookie jar
    let mut jar = CookieJar::new();
    jar.store(JarCookie::new("session_id", "abc123", "example.com"));
    jar.store(JarCookie::new("auth_token", "xyz789", "api.example.com"));

    let persistence_with_cookies = SessionPersistence::new(&session_dir).with_cookie_jar(jar);

    // Verify cookies are set
    assert!(
        persistence_with_cookies.cookie_jar().is_some(),
        "Cookie jar should be set"
    );
    assert_eq!(
        persistence_with_cookies.cookie_jar().unwrap().len(),
        2,
        "Should have 2 cookies before save"
    );

    // Save session (includes cookies)
    let groups: Vec<Arc<std::sync::RwLock<RequestGroup>>> = Vec::new();
    let _saved = persistence_with_cookies.save_state(&groups).await.unwrap();

    // Verify cookies.json file was created
    let cookie_path = session_dir.join("cookies.json");
    assert!(
        cookie_path.exists(),
        "cookies.json file should exist after save"
    );

    // Load into new instance (without pre-set cookies)
    let mut persistence_new = SessionPersistence::new(&session_dir);
    let mut loaded_groups: Vec<Arc<std::sync::RwLock<RequestGroup>>> = Vec::new();
    let _loaded = persistence_new
        .load_state(&mut loaded_groups)
        .await
        .unwrap();

    // Verify cookies were loaded
    assert!(
        persistence_new.cookie_jar().is_some(),
        "Cookie jar should exist after load"
    );
    let loaded_jar = persistence_new.cookie_jar().unwrap();
    assert_eq!(
        loaded_jar.len(),
        2,
        "Should have loaded 2 cookies from file"
    );

    // Verify specific cookies were preserved
    let example_cookies = loaded_jar.get_cookies_for_url("http://example.com/", false);
    assert_eq!(
        example_cookies.len(),
        1,
        "Should find 1 cookie for example.com"
    );
    assert_eq!(example_cookies[0].name, "session_id");
    assert_eq!(example_cookies[0].value, "abc123");

    let api_cookies = loaded_jar.get_cookies_for_url("http://api.example.com/api", false);
    assert_eq!(
        api_cookies.len(),
        2,
        "Should find 2 cookies for api.example.com (parent domain + exact)"
    );
    let auth_cookie = api_cookies
        .iter()
        .find(|c| c.name == "auth_token")
        .expect("Should find auth_token cookie");
    assert_eq!(auth_cookie.value, "xyz789");
    let session_cookie = api_cookies
        .iter()
        .find(|c| c.name == "session_id")
        .expect("Should find session_id cookie from parent domain");
    assert_eq!(session_cookie.value, "abc123");

    // Clean up
    let _ = fs::remove_dir_all(&session_dir);
}