aria2-core 0.3.1

aria2-rust core download engine: multi-protocol segmented downloads, rate limiting, configuration, session persistence, and BitTorrent seeding
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
//! Runtime option updates and rate limiter management.
//!
//! Implements `RequestGroup::update_option()` for dynamically changing
//! download options at runtime (e.g. via `aria2.changeOption`), and
//! the `set_rate_limiter` / `set_download_context` methods.

use std::collections::HashMap;
use std::sync::Arc;

use crate::rate_limiter::RateLimiter;
use crate::util::rwlock_ext::RwLockRecover;

fn rpc_option_string(value: &serde_json::Value, key: &str) -> Result<String, String> {
    super::options::option_value_to_string(value)
        .ok_or_else(|| format!("Option '{}' must be a string", key))
}

fn rpc_option_u64(value: &serde_json::Value, key: &str) -> Result<u64, String> {
    rpc_option_string(value, key)?
        .parse()
        .map_err(|_| format!("Option '{}' must be a non-negative integer", key))
}

fn rpc_option_size(value: &serde_json::Value, key: &str) -> Result<u64, String> {
    let raw = rpc_option_string(value, key)?;
    crate::config::OptionValue::parse_size_str_checked(&raw)
        .map_err(|error| format!("Option '{}': {}", key, error))
}

fn rpc_option_f64(value: &serde_json::Value, key: &str) -> Result<f64, String> {
    let number = rpc_option_string(value, key)?
        .parse::<f64>()
        .map_err(|_| format!("Option '{}' must be a number", key))?;
    if number.is_finite() {
        Ok(number)
    } else {
        Err(format!("Option '{}' must be a finite number", key))
    }
}

fn rpc_option_bool(value: &serde_json::Value, key: &str) -> Result<bool, String> {
    match rpc_option_string(value, key)?.as_str() {
        "true" => Ok(true),
        "false" => Ok(false),
        _ => Err(format!("Option '{}' must be either 'true' or 'false'", key)),
    }
}

fn rpc_option_u16(value: &serde_json::Value, key: &str) -> Result<u16, String> {
    let value = rpc_option_u64(value, key)?;
    u16::try_from(value).map_err(|_| format!("Option '{}' is too large", key))
}

fn rpc_option_u32(value: &serde_json::Value, key: &str) -> Result<u32, String> {
    let value = rpc_option_u64(value, key)?;
    u32::try_from(value).map_err(|_| format!("Option '{}' is too large", key))
}

/// Validate a known aria2 option that has no dedicated `DownloadOptions`
/// field yet. Keeping this fallback behind the core registry prevents RPC
/// adapters from accepting arbitrary keys while preserving the wire value for
/// later execution integration.
fn validate_unmapped_rpc_option(key: &str, value: &serde_json::Value) -> Result<bool, String> {
    if matches!(
        crate::config::is_option_changeable(key, false),
        crate::config::ChangeableKind::NotChangeable
    ) {
        return Ok(false);
    }
    let registry = crate::config::OptionRegistry::new();
    if registry.get(key).is_none() {
        return Ok(false);
    }
    registry
        .parse_rpc_value(key, value)
        .map(|_| true)
        .map_err(|error| format!("Option '{}': {}", key, error))
}

/// Runtime option changes partitioned by the lifecycle phase in which aria2
/// applies them. This is an internal core seam shared by RPC and C adapters.
#[derive(Debug, Default)]
pub(crate) struct RuntimeOptionChanges {
    pub(crate) immediate: HashMap<String, serde_json::Value>,
    pub(crate) pending: HashMap<String, serde_json::Value>,
}

fn apply_rpc_option(
    opts: &mut super::DownloadOptions,
    key: &str,
    value: &serde_json::Value,
) -> Result<bool, String> {
    match key {
        "split" => {
            let value = rpc_option_u16(value, key)?;
            if value == 0 {
                return Err(format!("Option '{}' must be greater than zero", key));
            }
            opts.split = Some(value);
            Ok(true)
        }
        "max-download-limit" => {
            opts.max_download_limit = Some(rpc_option_size(value, key)?);
            Ok(true)
        }
        "max-upload-limit" => {
            opts.max_upload_limit = Some(rpc_option_size(value, key)?);
            Ok(true)
        }
        "max-tries" | "max-retries" => {
            opts.max_retries = rpc_option_u32(value, key)?;
            Ok(true)
        }
        "retry-wait" => {
            let value = rpc_option_u64(value, key)?;
            if value > 600 {
                return Err(format!("Option '{}' must be between 0 and 600", key));
            }
            opts.retry_wait = value;
            Ok(true)
        }
        "header" => {
            opts.header = match value {
                serde_json::Value::Array(values) => values
                    .iter()
                    .map(|value| rpc_option_string(value, key))
                    .collect::<Result<Vec<_>, _>>()?,
                serde_json::Value::String(value) => value
                    .split('\n')
                    .map(str::trim)
                    .filter(|value| !value.is_empty())
                    .map(str::to_string)
                    .collect(),
                _ => return Err(format!("Option '{}' must be a string or array", key)),
            };
            Ok(true)
        }
        "user-agent" | "referer" | "dir" | "out" | "file-allocation" | "cookie-file"
        | "cookies" | "dht-file-path" | "http-proxy" | "http-proxy-user" | "http-proxy-passwd"
        | "all-proxy" | "all-proxy-user" | "all-proxy-passwd" | "https-proxy"
        | "https-proxy-user" | "https-proxy-passwd" | "ftp-proxy" | "ftp-proxy-user"
        | "ftp-proxy-passwd" | "no-proxy" => {
            let value = rpc_option_string(value, key)?;
            match key {
                "user-agent" => opts.user_agent = Some(value),
                "referer" => opts.referer = Some(value),
                "dir" => opts.dir = Some(value),
                "out" => opts.out = Some(value),
                "file-allocation" => opts.file_allocation = Some(value),
                "cookie-file" => opts.cookie_file = Some(value),
                "cookies" => opts.cookies = Some(value),
                "dht-file-path" => opts.dht_file_path = Some(value),
                "http-proxy" => opts.http_proxy = Some(value),
                "http-proxy-user" => opts.http_proxy_user = Some(value),
                "http-proxy-passwd" => opts.http_proxy_passwd = Some(value),
                "all-proxy" => opts.all_proxy = Some(value),
                "all-proxy-user" => opts.all_proxy_user = Some(value),
                "all-proxy-passwd" => opts.all_proxy_passwd = Some(value),
                "https-proxy" => opts.https_proxy = Some(value),
                "https-proxy-user" => opts.https_proxy_user = Some(value),
                "https-proxy-passwd" => opts.https_proxy_passwd = Some(value),
                "ftp-proxy" => opts.ftp_proxy = Some(value),
                "ftp-proxy-user" => opts.ftp_proxy_user = Some(value),
                "ftp-proxy-passwd" => opts.ftp_proxy_passwd = Some(value),
                "no-proxy" => opts.no_proxy = Some(value),
                _ => unreachable!("string option handled above"),
            }
            Ok(true)
        }
        "max-connection-per-server" => {
            let value = rpc_option_u16(value, key)?;
            if value == 0 {
                return Err(format!("Option '{}' must be greater than zero", key));
            }
            opts.max_connection_per_server = Some(value);
            Ok(true)
        }
        "bt-max-peers" => {
            opts.bt_max_peers = usize::try_from(rpc_option_u64(value, key)?)
                .map_err(|_| format!("Option '{}' is too large", key))?;
            Ok(true)
        }
        "bt-max-upload-slots" => {
            opts.bt_max_upload_slots = Some(rpc_option_u32(value, key)?);
            Ok(true)
        }
        "bt-snubbed-timeout" => {
            opts.bt_snubbed_timeout = Some(rpc_option_u64(value, key)?);
            Ok(true)
        }
        "bt-optimistic-unchoke-interval" => {
            opts.bt_optimistic_unchoke_interval = Some(rpc_option_u64(value, key)?);
            Ok(true)
        }
        "bt-endgame-threshold" => {
            opts.bt_endgame_threshold = rpc_option_u32(value, key)?;
            Ok(true)
        }
        "seed-time" | "seed-ratio" => {
            let value = rpc_option_f64(value, key)?;
            if value < 0.0 {
                return Err(format!("Option '{}' must not be negative", key));
            }
            if key == "seed-time" {
                opts.seed_time = Some(value);
            } else {
                opts.seed_ratio = Some(value);
            }
            Ok(true)
        }
        "bt-detach-seed-only" => {
            opts.bt_detach_seed_only = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "mmap-threshold" => {
            opts.mmap_threshold = Some(rpc_option_size(value, key)?);
            Ok(true)
        }
        "secure-falloc" => {
            opts.secure_falloc = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "checksum" => {
            let value = rpc_option_string(value, key)?;
            let (algorithm, digest) = value
                .split_once('=')
                .filter(|(algorithm, digest)| !algorithm.is_empty() && !digest.is_empty())
                .ok_or_else(|| format!("Option '{}' must be in HASH=VALUE form", key))?;
            opts.checksum = Some((algorithm.to_string(), digest.to_string()));
            Ok(true)
        }
        "bt-force-encryption" | "bt-force-encrypt" => {
            opts.bt_force_encrypt = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "bt-require-crypto" => {
            opts.bt_require_crypto = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "enable-dht" => {
            opts.enable_dht = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "dht-listen-port" => {
            opts.dht_listen_port = Some(rpc_option_string(value, key)?);
            Ok(true)
        }
        "dht-entry-point" => {
            opts.dht_entry_point = match value {
                serde_json::Value::Array(values) => Some(
                    values
                        .iter()
                        .map(|value| rpc_option_string(value, key))
                        .collect::<Result<Vec<_>, _>>()?,
                ),
                _ => Some(vec![rpc_option_string(value, key)?]),
            };
            Ok(true)
        }
        "enable-public-trackers" => {
            opts.enable_public_trackers = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "bt-piece-selection-strategy" => {
            opts.bt_piece_selection_strategy = rpc_option_string(value, key)?;
            Ok(true)
        }
        "bt-prioritize-piece" => {
            opts.bt_prioritize_piece = rpc_option_string(value, key)?;
            Ok(true)
        }
        "enable-utp" => {
            opts.enable_utp = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "utp-listen-port" => {
            opts.utp_listen_port = Some(rpc_option_u16(value, key)?);
            Ok(true)
        }
        "check-integrity"
        | "conditional-get"
        | "dry-run"
        | "ftp-pasv"
        | "ftp-reuse-connection"
        | "no-netrc"
        | "realtime-chunk-checksum"
        | "remote-time"
        | "bt-enable-lpd"
        | "http-auth-challenge" => {
            let value = rpc_option_bool(value, key)?;
            match key {
                "check-integrity" => opts.check_integrity = value,
                "conditional-get" => opts.conditional_get = value,
                "dry-run" => opts.dry_run = value,
                "ftp-pasv" => opts.ftp_pasv = value,
                "ftp-reuse-connection" => opts.ftp_reuse_connection = value,
                "no-netrc" => opts.no_netrc = value,
                "realtime-chunk-checksum" => opts.realtime_chunk_checksum = value,
                "remote-time" => opts.remote_time = value,
                "bt-enable-lpd" => opts.bt_enable_lpd = value,
                "http-auth-challenge" => opts.http_auth_challenge = value,
                _ => unreachable!("boolean option handled above"),
            }
            Ok(true)
        }
        "hash-check-only" => {
            let value = rpc_option_bool(value, key)?;
            opts.hash_check_only = value;
            if value {
                opts.check_integrity = true;
            }
            Ok(true)
        }
        "bt-enable-hook-after-hash-check" => {
            opts.bt_enable_hook_after_hash_check = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "bt-hash-check-seed" => {
            opts.bt_hash_check_seed = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "bt-seed-unverified" => {
            opts.bt_seed_unverified = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "bt-remove-unselected-file" => {
            opts.bt_remove_unselected_file = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "timeout" | "connect-timeout" | "bt-stop-timeout" => {
            let value = rpc_option_u64(value, key)?;
            match key {
                "timeout" => opts.timeout = Some(value),
                "connect-timeout" => opts.connect_timeout = Some(value),
                "bt-stop-timeout" => opts.bt_stop_timeout = Some(value),
                _ => unreachable!("duration option handled above"),
            }
            Ok(true)
        }
        "lowest-speed-limit" | "piece-length" => {
            let value = rpc_option_size(value, key)?;
            match key {
                "lowest-speed-limit" => opts.lowest_speed_limit = Some(value),
                "piece-length" => opts.piece_length = Some(value),
                _ => unreachable!("size option handled above"),
            }
            Ok(true)
        }
        "metalink-version"
        | "metalink-language"
        | "metalink-os"
        | "metalink-location"
        | "metalink-preferred-protocol"
        | "select-file"
        | "index-out"
        | "listen-port"
        | "bt-lpd-interface"
        | "http-user"
        | "http-passwd"
        | "ftp-user"
        | "ftp-passwd"
        | "ssh-host-key-md" => {
            let value = rpc_option_string(value, key)?;
            match key {
                "metalink-version" => opts.metalink_version = Some(value),
                "metalink-language" => opts.metalink_language = Some(value),
                "metalink-os" => opts.metalink_os = Some(value),
                "metalink-location" => opts.metalink_location = Some(value),
                "metalink-preferred-protocol" => opts.metalink_preferred_protocol = Some(value),
                "select-file" => opts.select_file = Some(value),
                "index-out" => opts.index_out = Some(value),
                "listen-port" => opts.listen_port = Some(value),
                "bt-lpd-interface" => opts.bt_lpd_interface = Some(value),
                "http-user" => opts.http_user = Some(value),
                "http-passwd" => opts.http_passwd = Some(value),
                "ftp-user" => opts.ftp_user = Some(value),
                "ftp-passwd" => opts.ftp_passwd = Some(value),
                "ssh-host-key-md" => opts.ssh_host_key_md = Some(value),
                _ => unreachable!("string option handled above"),
            }
            Ok(true)
        }
        "metalink-enable-unique-protocol" => {
            opts.metalink_enable_unique_protocol = rpc_option_bool(value, key)?;
            Ok(true)
        }
        "follow-torrent" | "follow-metalink" => {
            let raw = rpc_option_string(value, key)?;
            let mode = super::FollowMode::parse(&raw)
                .ok_or_else(|| format!("Option '{}' must be true, false, or mem", key))?;
            if key == "follow-torrent" {
                opts.follow_torrent = Some(mode);
            } else {
                opts.follow_metalink = Some(mode);
            }
            Ok(true)
        }
        "bt-tracker" => {
            let values = match value {
                serde_json::Value::Array(values) => values
                    .iter()
                    .map(|value| rpc_option_string(value, key))
                    .collect::<Result<Vec<_>, _>>()?,
                _ => rpc_option_string(value, key)?
                    .split([',', '\n'])
                    .map(str::trim)
                    .filter(|entry| !entry.is_empty())
                    .map(str::to_string)
                    .collect(),
            };
            if values.is_empty() {
                return Err(format!("Option '{}' must not be empty", key));
            }
            opts.bt_tracker = Some(values);
            Ok(true)
        }
        _ => Ok(false),
    }
}

impl super::RequestGroup {
    // ── Basic Accessors ─────────────────────────────────────────────────

    /// Resolve the effective minimum range split size from the canonical task
    /// option snapshot. This option remains outside `DownloadOptions` so the
    /// public Rust struct does not gain a breaking field; CLI, RPC, session,
    /// and runtime option paths still preserve its original wire value.
    pub(crate) fn effective_min_split_size(&self) -> u64 {
        self.effective_option_snapshot()
            .and_then(|options| options.get("min-split-size").cloned())
            .and_then(|value| super::options::option_value_to_string(&value))
            .and_then(|value| crate::config::OptionValue::parse_size_str_checked(&value).ok())
            .filter(|value| *value > 0)
            .unwrap_or(crate::constants::DEFAULT_MIN_SPLIT_SIZE)
    }

    /// Return the group ID.
    pub fn gid(&self) -> super::GroupId {
        self.gid
    }

    /// Return the initial URI list.
    ///
    /// Note: This returns the *initial* URIs provided when the group was
    /// created. For the current remaining/spent URI state, use
    /// `get_remaining_uris()` / `get_spent_uris()` which delegate to
    /// `FileEntry` via `DownloadContext`.
    pub fn uris(&self) -> &[String] {
        &self.uris
    }

    /// Replace the initial URI set before a download context is attached.
    ///
    /// Dependency fallbacks use this to remove the synthetic `bt://` dispatch
    /// URI after torrent metadata failed and continue with direct mirrors.
    pub fn replace_uris(&mut self, uris: Vec<String>) {
        self.uris = uris;
    }

    /// Set a per-group output filename, used by Metalink entries.
    pub fn set_output_name(&self, name: impl Into<String>) {
        *self.output_name.recover_mut() = Some(name.into());
    }

    /// Return the per-group output filename, if configured.
    pub fn output_name(&self) -> Option<String> {
        self.output_name.recover().clone()
    }

    /// Return a reference to the download options.
    pub fn options(&self) -> &super::DownloadOptions {
        &self.options
    }

    /// Cheap clone of the options `Arc` — O(1) refcount bump instead of
    /// deep-cloning all `Vec<String>` fields.
    pub fn options_arc(&self) -> Arc<super::DownloadOptions> {
        Arc::clone(&self.options)
    }

    /// Record the canonical option values that created this task.
    ///
    /// Callers set this while the group is constructed or restored. It is
    /// intentionally separate from runtime overrides so a later global option
    /// change cannot alter the observable task state.
    pub fn set_option_snapshot(&mut self, options: HashMap<String, serde_json::Value>) {
        self.option_snapshot = Some(crate::config::project_initial_options(options));
    }

    /// Return the creation snapshot with only already-applied runtime changes
    /// overlaid. Pending changes remain absent until a restart applies them.
    pub fn effective_option_snapshot(&self) -> Option<HashMap<String, serde_json::Value>> {
        let mut options = self.option_snapshot.clone()?;
        options.extend(self.runtime_options());
        Some(crate::config::project_initial_options(options))
    }

    /// Return the configured maximum number of 404 responses for this group.
    ///
    /// `max-file-not-found=0` disables 404 retries and therefore reports the
    /// first response as `RESOURCE_NOT_FOUND`, matching aria2's wire behavior.
    pub fn max_file_not_found(&self) -> u32 {
        self.effective_option_snapshot()
            .and_then(|options| options.get("max-file-not-found").cloned())
            .and_then(|value| super::options::option_value_to_string(&value))
            .and_then(|value| value.parse::<u32>().ok())
            .unwrap_or(0)
    }

    /// Record a not-found response and return the terminal or retryable code.
    pub fn record_file_not_found(&self) -> super::result_code::DownloadResultCode {
        let count = self
            .file_not_found_count
            .fetch_add(1, std::sync::atomic::Ordering::Relaxed)
            .saturating_add(1);
        let max = self.max_file_not_found();

        if max > 0 && count >= max && self.completed_length() == 0 {
            super::result_code::DownloadResultCode::MaxFileNotFound
        } else {
            super::result_code::DownloadResultCode::ResourceNotFound
        }
    }

    /// Convert the next HTTP 404 response into the public download error.
    pub fn file_not_found_error(&self) -> crate::error::Aria2Error {
        match self.record_file_not_found() {
            super::result_code::DownloadResultCode::MaxFileNotFound => {
                crate::error::Aria2Error::Recoverable(
                    crate::error::RecoverableError::MaxFileNotFound,
                )
            }
            _ => crate::error::Aria2Error::Recoverable(
                crate::error::RecoverableError::ResourceNotFound,
            ),
        }
    }

    /// Return whether another 404 request is permitted by the group option.
    pub fn can_retry_file_not_found(&self) -> bool {
        let max = self.max_file_not_found();
        max > 0
            && (self
                .file_not_found_count
                .load(std::sync::atomic::Ordering::Relaxed)
                < max
                || self.completed_length() > 0)
    }

    // ── Rate Limiter ────────────────────────────────────────────────────

    /// Store a handle to the download's `RateLimiter` so that runtime option
    /// updates (e.g. via `aria2.changeOption`) can dynamically adjust the rate.
    pub fn set_rate_limiter(&self, limiter: RateLimiter) {
        *self.rate_limiter.recover_mut() = Some(limiter);
    }

    /// Store options that take effect when the next command generation starts.
    pub fn set_pending_options(
        &self,
        changes: std::collections::HashMap<String, serde_json::Value>,
    ) {
        if let Ok(mut pending) = self.pending_options.write() {
            pending.extend(changes);
        }
    }

    /// Apply and clear options deferred by `changeOption`.
    pub fn apply_pending_options(&mut self) {
        let changes = self
            .pending_options
            .write()
            .map(|mut pending| std::mem::take(&mut *pending))
            .unwrap_or_default();
        for (key, value) in changes {
            self.update_option(&key, value);
        }
    }

    pub fn pending_options(&self) -> std::collections::HashMap<String, serde_json::Value> {
        self.pending_options
            .read()
            .map(|pending| pending.clone())
            .unwrap_or_default()
    }

    /// Return the task-level overrides that have actually been applied.
    pub fn runtime_options(&self) -> std::collections::HashMap<String, serde_json::Value> {
        self.runtime_options
            .read()
            .map(|options| options.clone())
            .unwrap_or_default()
    }

    /// Validate and partition a batch using the same policy for every
    /// external adapter. Waiting and paused groups are reserved; only a
    /// group in the `Active` state receives pending changes.
    pub(crate) fn classify_runtime_options(
        &self,
        changes: HashMap<String, serde_json::Value>,
    ) -> Result<RuntimeOptionChanges, String> {
        let is_running = self.status().is_running();
        let mut classified = RuntimeOptionChanges::default();
        for (key, value) in changes {
            match crate::config::is_option_changeable(&key, is_running) {
                crate::config::ChangeableKind::Immediate => {
                    if Self::validate_option_update(&key, &value)? {
                        classified.immediate.insert(key, value);
                    }
                }
                crate::config::ChangeableKind::Pending => {
                    if Self::validate_option_update(&key, &value)? {
                        classified.pending.insert(key, value);
                    }
                }
                crate::config::ChangeableKind::NotChangeable => {}
            }
        }
        Ok(classified)
    }

    /// Apply a previously classified immediate batch. Validation is repeated
    /// at this seam so direct core callers cannot bypass the runtime contract.
    pub(crate) fn apply_runtime_options(
        &mut self,
        changes: HashMap<String, serde_json::Value>,
    ) -> Result<(), String> {
        for (key, value) in changes {
            if !self.try_update_option(&key, value)? {
                return Err(format!("Option '{}' cannot be changed at runtime", key));
            }
        }
        Ok(())
    }

    // ── Runtime Option Updates ──────────────────────────────────────────

    /// Update a single runtime-changeable option by key (using aria2's
    /// kebab-case option names, e.g. `"max-download-limit"`).
    ///
    /// Returns `true` if the option was recognized and updated, `false` if the
    /// key is not a runtime-changeable option. Invalid values are reported by
    /// [`Self::try_update_option`] and are intentionally not hidden here.
    ///
    /// For `max-download-limit` / `max-upload-limit`, the stored
    /// `RateLimiter` (if any) is also updated so the change takes effect
    /// immediately on the live download.
    pub fn validate_option_update(key: &str, value: &serde_json::Value) -> Result<bool, String> {
        let registry = crate::config::OptionRegistry::new();
        if registry.get(key).is_some() {
            registry
                .parse_rpc_value(key, value)
                .map_err(|error| format!("Option '{}': {}", key, error))?;
        }
        let mut options = super::DownloadOptions::default();
        if apply_rpc_option(&mut options, key, value)? {
            Ok(true)
        } else {
            validate_unmapped_rpc_option(key, value)
        }
    }

    /// Apply a runtime option while preserving parse failures for RPC callers.
    pub fn try_update_option(
        &mut self,
        key: &str,
        value: serde_json::Value,
    ) -> Result<bool, String> {
        if !Self::validate_option_update(key, &value)? {
            return Ok(false);
        }

        let opts = Arc::make_mut(&mut self.options);
        let applied = apply_rpc_option(opts, key, &value)?;
        if !applied {
            debug_assert!(validate_unmapped_rpc_option(key, &value)?);
        }

        match key {
            "max-download-limit" => {
                if let Some(ref limiter) = *self.rate_limiter.recover() {
                    limiter.set_download_rate(opts.max_download_limit);
                }
            }
            "max-upload-limit" => {
                if let Some(ref limiter) = *self.rate_limiter.recover() {
                    limiter.set_upload_rate(opts.max_upload_limit);
                }
            }
            "split" => {
                tracing::warn!(
                    new_split = opts.split,
                    "split changed but will take effect on download restart/retry, \
                     not mid-download (current segments unchanged)"
                );
            }
            _ => {}
        }
        if applied || validate_unmapped_rpc_option(key, &value)? {
            if let Ok(mut runtime_options) = self.runtime_options.write() {
                runtime_options.insert(key.to_string(), value);
            }
            Ok(true)
        } else {
            Ok(false)
        }
    }

    /// Compatibility wrapper for internal callers that only need to know
    /// whether a key is recognized. RPC-facing code should use
    /// [`Self::try_update_option`] so invalid values cannot be swallowed.
    pub fn update_option(&mut self, key: &str, value: serde_json::Value) -> bool {
        self.try_update_option(key, value).unwrap_or(false)
    }
}