arcbox-hypervisor 0.4.10

Cross-platform hypervisor abstraction layer for ArcBox
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
//! FFI bindings for Linux KVM API.
//!
//! This module provides safe Rust wrappers around the KVM ioctl interface.
//! All ioctl commands are defined according to the Linux kernel headers.

#![allow(non_camel_case_types)]
#![allow(dead_code)]

use std::fs::OpenOptions;
use std::os::unix::io::{AsRawFd, FromRawFd, IntoRawFd, OwnedFd, RawFd};
use std::ptr;

// ============================================================================
// KVM ioctl Numbers
// ============================================================================

/// KVM magic number for ioctl encoding.
const KVMIO: u8 = 0xAE;

/// Macro to create KVM ioctl numbers.
macro_rules! kvm_io {
    ($nr:expr) => {
        nix::request_code_none!(KVMIO, $nr)
    };
}

macro_rules! kvm_ior {
    ($nr:expr, $ty:ty) => {
        nix::request_code_read!(KVMIO, $nr, std::mem::size_of::<$ty>())
    };
}

macro_rules! kvm_iow {
    ($nr:expr, $ty:ty) => {
        nix::request_code_write!(KVMIO, $nr, std::mem::size_of::<$ty>())
    };
}

macro_rules! kvm_iowr {
    ($nr:expr, $ty:ty) => {
        nix::request_code_readwrite!(KVMIO, $nr, std::mem::size_of::<$ty>())
    };
}

// System ioctls
pub const KVM_GET_API_VERSION: nix::sys::ioctl::ioctl_num_type = kvm_io!(0x00);
pub const KVM_CREATE_VM: nix::sys::ioctl::ioctl_num_type = kvm_io!(0x01);
pub const KVM_CHECK_EXTENSION: nix::sys::ioctl::ioctl_num_type = kvm_io!(0x03);
pub const KVM_GET_VCPU_MMAP_SIZE: nix::sys::ioctl::ioctl_num_type = kvm_io!(0x04);

// VM ioctls
pub const KVM_SET_USER_MEMORY_REGION: nix::sys::ioctl::ioctl_num_type =
    kvm_iow!(0x46, KvmUserspaceMemoryRegion);
pub const KVM_CREATE_VCPU: nix::sys::ioctl::ioctl_num_type = kvm_io!(0x41);
pub const KVM_SET_TSS_ADDR: nix::sys::ioctl::ioctl_num_type = kvm_io!(0x47);
pub const KVM_CREATE_IRQCHIP: nix::sys::ioctl::ioctl_num_type = kvm_io!(0x60);
pub const KVM_CREATE_PIT2: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x77, KvmPitConfig);
pub const KVM_SET_IDENTITY_MAP_ADDR: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x48, u64);
pub const KVM_IRQFD: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x76, KvmIrqfd);
pub const KVM_IOEVENTFD: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x79, KvmIoeventfd);
pub const KVM_IRQ_LINE: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x61, KvmIrqLevel);
pub const KVM_SET_GSI_ROUTING: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x6a, KvmIrqRouting);
pub const KVM_GET_DIRTY_LOG: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x42, KvmDirtyLog);

// vCPU ioctls for interrupt injection
pub const KVM_INTERRUPT: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x86, KvmInterrupt);

// vCPU ioctls
pub const KVM_RUN: nix::sys::ioctl::ioctl_num_type = kvm_io!(0x80);
pub const KVM_GET_REGS: nix::sys::ioctl::ioctl_num_type = kvm_ior!(0x81, KvmRegs);
pub const KVM_SET_REGS: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x82, KvmRegs);
pub const KVM_GET_SREGS: nix::sys::ioctl::ioctl_num_type = kvm_ior!(0x83, KvmSregs);
pub const KVM_SET_SREGS: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x84, KvmSregs);
pub const KVM_SET_CPUID2: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0x90, KvmCpuid2);
pub const KVM_GET_CPUID2: nix::sys::ioctl::ioctl_num_type = kvm_iowr!(0x91, KvmCpuid2);

// ARM64-specific ioctls
#[cfg(target_arch = "aarch64")]
pub const KVM_ARM_PREFERRED_TARGET: nix::sys::ioctl::ioctl_num_type = kvm_ior!(0xaf, KvmVcpuInit);
#[cfg(target_arch = "aarch64")]
pub const KVM_ARM_VCPU_INIT: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0xae, KvmVcpuInit);
#[cfg(target_arch = "aarch64")]
pub const KVM_GET_ONE_REG: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0xab, KvmOneReg);
#[cfg(target_arch = "aarch64")]
pub const KVM_SET_ONE_REG: nix::sys::ioctl::ioctl_num_type = kvm_iow!(0xac, KvmOneReg);

// ============================================================================
// KVM Capability Constants
// ============================================================================

pub const KVM_CAP_IRQCHIP: u32 = 0;
pub const KVM_CAP_USER_MEMORY: u32 = 3;
pub const KVM_CAP_SET_TSS_ADDR: u32 = 4;
pub const KVM_CAP_EXT_CPUID: u32 = 7;
pub const KVM_CAP_NR_VCPUS: u32 = 9;
pub const KVM_CAP_NR_MEMSLOTS: u32 = 10;
pub const KVM_CAP_PIT2: u32 = 33;
pub const KVM_CAP_IOEVENTFD: u32 = 36;
pub const KVM_CAP_IRQFD: u32 = 32;
pub const KVM_CAP_MAX_VCPUS: u32 = 66;
pub const KVM_CAP_MAX_VCPU_ID: u32 = 128;
#[cfg(target_arch = "aarch64")]
pub const KVM_CAP_ARM_VM_IPA_SIZE: u32 = 165;

// ============================================================================
// ARM64 Register IDs
// ============================================================================

#[cfg(target_arch = "aarch64")]
pub mod arm64_regs {
    /// KVM register type bits
    const KVM_REG_ARM64: u64 = 0x6000_0000_0000_0000;
    const KVM_REG_SIZE_U64: u64 = 0x0030_0000_0000_0000;
    const KVM_REG_ARM_CORE: u64 = 0x0010_0000_0000_0000;

    /// Macro to create ARM64 core register IDs
    macro_rules! arm64_core_reg {
        ($offset:expr) => {
            KVM_REG_ARM64 | KVM_REG_SIZE_U64 | KVM_REG_ARM_CORE | (($offset as u64) * 2)
        };
    }

    // General purpose registers x0-x30
    pub const X0: u64 = arm64_core_reg!(0);
    pub const X1: u64 = arm64_core_reg!(1);
    pub const X2: u64 = arm64_core_reg!(2);
    pub const X3: u64 = arm64_core_reg!(3);
    pub const X29: u64 = arm64_core_reg!(29); // FP
    pub const X30: u64 = arm64_core_reg!(30); // LR

    // Stack pointer
    pub const SP: u64 = arm64_core_reg!(31);

    // Program counter
    pub const PC: u64 = arm64_core_reg!(32);

    // Processor state (PSTATE/CPSR)
    pub const PSTATE: u64 = arm64_core_reg!(33);

    /// PSTATE bits for EL1h (Exception Level 1, SP_ELx)
    pub const PSTATE_EL1H: u64 = 0x0000_0005;

    /// PSTATE bits for EL1 with interrupts masked
    pub const PSTATE_D: u64 = 1 << 9; // Debug mask
    pub const PSTATE_A: u64 = 1 << 8; // SError mask
    pub const PSTATE_I: u64 = 1 << 7; // IRQ mask
    pub const PSTATE_F: u64 = 1 << 6; // FIQ mask
}

// ============================================================================
// KVM Exit Reasons
// ============================================================================

pub const KVM_EXIT_UNKNOWN: u32 = 0;
pub const KVM_EXIT_EXCEPTION: u32 = 1;
pub const KVM_EXIT_IO: u32 = 2;
pub const KVM_EXIT_HYPERCALL: u32 = 3;
pub const KVM_EXIT_DEBUG: u32 = 4;
pub const KVM_EXIT_HLT: u32 = 5;
pub const KVM_EXIT_MMIO: u32 = 6;
pub const KVM_EXIT_IRQ_WINDOW_OPEN: u32 = 7;
pub const KVM_EXIT_SHUTDOWN: u32 = 8;
pub const KVM_EXIT_FAIL_ENTRY: u32 = 9;
pub const KVM_EXIT_INTR: u32 = 10;
pub const KVM_EXIT_SET_TPR: u32 = 11;
pub const KVM_EXIT_TPR_ACCESS: u32 = 12;
pub const KVM_EXIT_INTERNAL_ERROR: u32 = 17;
pub const KVM_EXIT_SYSTEM_EVENT: u32 = 24;

// I/O direction
pub const KVM_EXIT_IO_IN: u8 = 0;
pub const KVM_EXIT_IO_OUT: u8 = 1;

// ============================================================================
// Memory Region Flags
// ============================================================================

pub const KVM_MEM_LOG_DIRTY_PAGES: u32 = 1 << 0;
pub const KVM_MEM_READONLY: u32 = 1 << 1;

// ============================================================================
// Dirty Log Structures
// ============================================================================

/// Structure for KVM_GET_DIRTY_LOG ioctl.
///
/// This is used to retrieve a bitmap of dirty pages for a memory slot.
/// Each bit in the bitmap represents one page (typically 4KB).
#[repr(C)]
#[derive(Debug, Clone)]
pub struct KvmDirtyLog {
    /// Memory slot ID.
    pub slot: u32,
    /// Padding for alignment.
    pub padding: u32,
    /// Pointer to userspace bitmap buffer.
    /// The buffer must be large enough to hold (memory_size / page_size / 8) bytes.
    pub dirty_bitmap: *mut u64,
}

// ============================================================================
// Data Structures
// ============================================================================

/// Userspace memory region descriptor.
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmUserspaceMemoryRegion {
    pub slot: u32,
    pub flags: u32,
    pub guest_phys_addr: u64,
    pub memory_size: u64,
    pub userspace_addr: u64,
}

/// PIT configuration (x86 only).
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmPitConfig {
    pub flags: u32,
    pub pad: [u32; 15],
}

/// IRQFD configuration.
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmIrqfd {
    pub fd: u32,
    pub gsi: u32,
    pub flags: u32,
    pub resamplefd: u32,
    pub pad: [u8; 16],
}

/// IOEVENTFD configuration.
#[repr(C)]
#[derive(Debug, Clone)]
pub struct KvmIoeventfd {
    pub datamatch: u64,
    pub addr: u64,
    pub len: u32,
    pub fd: i32,
    pub flags: u32,
    pub pad: [u8; 36],
}

impl Default for KvmIoeventfd {
    fn default() -> Self {
        Self {
            datamatch: 0,
            addr: 0,
            len: 0,
            fd: 0,
            flags: 0,
            pad: [0; 36],
        }
    }
}

/// IRQ level for KVM_IRQ_LINE.
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmIrqLevel {
    /// IRQ number (GSI for in-kernel irqchip, or legacy PIC IRQ).
    /// For ARM, this encodes: (irq & 0xff) | ((irq_type & 0xff) << 24)
    pub irq: u32,
    /// Level: 0 = deassert, 1 = assert.
    pub level: u32,
}

/// External interrupt injection (for vCPU).
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmInterrupt {
    /// Interrupt vector (0-255 for x86).
    pub irq: u32,
}

/// IRQFD flags.
pub const KVM_IRQFD_FLAG_DEASSIGN: u32 = 1 << 0;
pub const KVM_IRQFD_FLAG_RESAMPLE: u32 = 1 << 1;

/// IOEVENTFD flags.
pub const KVM_IOEVENTFD_FLAG_PIO: u32 = 1 << 0;
pub const KVM_IOEVENTFD_FLAG_DATAMATCH: u32 = 1 << 1;
pub const KVM_IOEVENTFD_FLAG_DEASSIGN: u32 = 1 << 2;
pub const KVM_IOEVENTFD_FLAG_VIRTIO_CCW_NOTIFY: u32 = 1 << 3;

/// GSI routing entry type.
pub const KVM_IRQ_ROUTING_IRQCHIP: u32 = 1;
pub const KVM_IRQ_ROUTING_MSI: u32 = 2;
pub const KVM_IRQ_ROUTING_S390_ADAPTER: u32 = 3;
pub const KVM_IRQ_ROUTING_HV_SINT: u32 = 4;

/// IRQ routing entry for in-kernel irqchip.
#[repr(C)]
#[derive(Debug, Clone, Copy, Default)]
pub struct KvmIrqRoutingIrqchip {
    pub irqchip: u32,
    pub pin: u32,
}

/// IRQ routing entry for MSI.
#[repr(C)]
#[derive(Debug, Clone, Copy, Default)]
pub struct KvmIrqRoutingMsi {
    pub address_lo: u32,
    pub address_hi: u32,
    pub data: u32,
    pub devid: u32,
}

/// Union for IRQ routing entry data.
#[repr(C)]
#[derive(Clone, Copy)]
pub union KvmIrqRoutingUnion {
    pub irqchip: KvmIrqRoutingIrqchip,
    pub msi: KvmIrqRoutingMsi,
    pub pad: [u32; 8],
}

impl Default for KvmIrqRoutingUnion {
    fn default() -> Self {
        Self { pad: [0; 8] }
    }
}

/// Single IRQ routing entry.
#[repr(C)]
#[derive(Clone, Copy)]
pub struct KvmIrqRoutingEntry {
    pub gsi: u32,
    pub type_: u32,
    pub flags: u32,
    pub pad: u32,
    pub u: KvmIrqRoutingUnion,
}

impl Default for KvmIrqRoutingEntry {
    fn default() -> Self {
        Self {
            gsi: 0,
            type_: 0,
            flags: 0,
            pad: 0,
            u: KvmIrqRoutingUnion::default(),
        }
    }
}

/// IRQ routing table header.
/// Note: The actual entries follow this header in memory (variable length).
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmIrqRouting {
    pub nr: u32,
    pub flags: u32,
    // Followed by: entries: [KvmIrqRoutingEntry; nr]
}

/// x86_64 general purpose registers.
#[cfg(target_arch = "x86_64")]
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmRegs {
    pub rax: u64,
    pub rbx: u64,
    pub rcx: u64,
    pub rdx: u64,
    pub rsi: u64,
    pub rdi: u64,
    pub rsp: u64,
    pub rbp: u64,
    pub r8: u64,
    pub r9: u64,
    pub r10: u64,
    pub r11: u64,
    pub r12: u64,
    pub r13: u64,
    pub r14: u64,
    pub r15: u64,
    pub rip: u64,
    pub rflags: u64,
}

/// x86_64 segment descriptor.
#[cfg(target_arch = "x86_64")]
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmSegment {
    pub base: u64,
    pub limit: u32,
    pub selector: u16,
    pub type_: u8,
    pub present: u8,
    pub dpl: u8,
    pub db: u8,
    pub s: u8,
    pub l: u8,
    pub g: u8,
    pub avl: u8,
    pub unusable: u8,
    pub padding: u8,
}

/// x86_64 descriptor table.
#[cfg(target_arch = "x86_64")]
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmDtable {
    pub base: u64,
    pub limit: u16,
    pub padding: [u16; 3],
}

/// x86_64 special registers.
#[cfg(target_arch = "x86_64")]
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmSregs {
    pub cs: KvmSegment,
    pub ds: KvmSegment,
    pub es: KvmSegment,
    pub fs: KvmSegment,
    pub gs: KvmSegment,
    pub ss: KvmSegment,
    pub tr: KvmSegment,
    pub ldt: KvmSegment,
    pub gdt: KvmDtable,
    pub idt: KvmDtable,
    pub cr0: u64,
    pub cr2: u64,
    pub cr3: u64,
    pub cr4: u64,
    pub cr8: u64,
    pub efer: u64,
    pub apic_base: u64,
    pub interrupt_bitmap: [u64; 4],
}

/// CPUID entry.
#[cfg(target_arch = "x86_64")]
#[repr(C)]
#[derive(Debug, Clone, Copy, Default)]
pub struct KvmCpuidEntry2 {
    pub function: u32,
    pub index: u32,
    pub flags: u32,
    pub eax: u32,
    pub ebx: u32,
    pub ecx: u32,
    pub edx: u32,
    pub padding: [u32; 3],
}

/// CPUID array header (x86 only).
#[cfg(target_arch = "x86_64")]
#[repr(C)]
#[derive(Debug, Clone)]
pub struct KvmCpuid2 {
    pub nent: u32,
    pub padding: u32,
    pub entries: [KvmCpuidEntry2; 256],
}

#[cfg(target_arch = "x86_64")]
impl Default for KvmCpuid2 {
    fn default() -> Self {
        Self {
            nent: 0,
            padding: 0,
            entries: [KvmCpuidEntry2::default(); 256],
        }
    }
}

/// ARM64 vCPU initialization.
#[cfg(target_arch = "aarch64")]
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmVcpuInit {
    pub target: u32,
    pub features: [u32; 7],
}

/// ARM64 register access.
#[cfg(target_arch = "aarch64")]
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmOneReg {
    pub id: u64,
    pub addr: u64,
}

/// ARM64 registers (placeholder - real implementation uses KVM_GET/SET_ONE_REG).
#[cfg(target_arch = "aarch64")]
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmRegs {
    pub regs: [u64; 31], // x0-x30
    pub sp: u64,
    pub pc: u64,
    pub pstate: u64,
}

/// ARM64 special registers (placeholder).
#[cfg(target_arch = "aarch64")]
#[repr(C)]
#[derive(Debug, Clone, Default)]
pub struct KvmSregs {
    // ARM64 uses different register access mechanism
    _placeholder: u64,
}

// ============================================================================
// KVM Run Structure
// ============================================================================

/// KVM run structure for vCPU execution.
/// This is mmap'd and shared between kernel and userspace.
#[repr(C)]
pub struct KvmRun {
    // Request flags
    pub request_interrupt_window: u8,
    pub immediate_exit: u8,
    pub padding1: [u8; 6],

    // Exit information
    pub exit_reason: u32,
    pub ready_for_interrupt_injection: u8,
    pub if_flag: u8,
    pub flags: u16,

    // CR8 value
    pub cr8: u64,

    // APIC base
    pub apic_base: u64,

    // Exit data (union in C, using largest variant)
    pub exit_data: KvmRunExitData,
}

/// Exit data union (using repr(C) struct to represent the union).
#[repr(C)]
pub union KvmRunExitData {
    pub io: KvmRunIo,
    pub mmio: KvmRunMmio,
    pub hypercall: KvmRunHypercall,
    pub system_event: KvmRunSystemEvent,
    pub padding: [u8; 256],
}

/// I/O exit data.
#[repr(C)]
#[derive(Debug, Clone, Copy)]
pub struct KvmRunIo {
    pub direction: u8,
    pub size: u8,
    pub port: u16,
    pub count: u32,
    pub data_offset: u64,
}

/// MMIO exit data.
#[repr(C)]
#[derive(Debug, Clone, Copy)]
pub struct KvmRunMmio {
    pub phys_addr: u64,
    pub data: [u8; 8],
    pub len: u32,
    pub is_write: u8,
    pub padding: [u8; 3],
}

/// Hypercall exit data.
#[repr(C)]
#[derive(Debug, Clone, Copy)]
pub struct KvmRunHypercall {
    pub nr: u64,
    pub args: [u64; 6],
    pub ret: u64,
    pub longmode: u32,
    pub pad: u32,
}

/// System event exit data.
#[repr(C)]
#[derive(Debug, Clone, Copy)]
pub struct KvmRunSystemEvent {
    pub type_: u32,
    pub ndata: u32,
    pub data: [u64; 16],
}

// ============================================================================
// Safe Wrapper Types
// ============================================================================

/// Result type for KVM operations.
pub type KvmResult<T> = Result<T, KvmError>;

/// KVM error type.
#[derive(Debug, Clone)]
pub struct KvmError {
    pub errno: i32,
    pub message: String,
}

impl std::fmt::Display for KvmError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "KVM error ({}): {}", self.errno, self.message)
    }
}

impl std::error::Error for KvmError {}

impl From<std::io::Error> for KvmError {
    fn from(e: std::io::Error) -> Self {
        Self {
            errno: e.raw_os_error().unwrap_or(-1),
            message: e.to_string(),
        }
    }
}

impl From<nix::Error> for KvmError {
    fn from(e: nix::Error) -> Self {
        Self {
            errno: e as i32,
            message: e.to_string(),
        }
    }
}

/// Safe wrapper for KVM system handle (/dev/kvm).
pub struct KvmSystem {
    fd: OwnedFd,
}

impl KvmSystem {
    /// Opens /dev/kvm and creates a new KVM system handle.
    pub fn open() -> KvmResult<Self> {
        let file = OpenOptions::new()
            .read(true)
            .write(true)
            .open("/dev/kvm")
            .map_err(|e| KvmError {
                errno: e.raw_os_error().unwrap_or(-1),
                message: format!("Failed to open /dev/kvm: {}", e),
            })?;

        let fd = unsafe { OwnedFd::from_raw_fd(file.into_raw_fd()) };

        Ok(Self { fd })
    }

    /// Gets the KVM API version.
    pub fn api_version(&self) -> KvmResult<i32> {
        let ret = unsafe { libc::ioctl(self.fd.as_raw_fd(), KVM_GET_API_VERSION) };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(ret)
    }

    /// Checks if an extension is supported.
    pub fn check_extension(&self, extension: u32) -> KvmResult<i32> {
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_CHECK_EXTENSION,
                extension as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(ret)
    }

    /// Gets the size of the vCPU mmap region.
    pub fn vcpu_mmap_size(&self) -> KvmResult<usize> {
        let ret = unsafe { libc::ioctl(self.fd.as_raw_fd(), KVM_GET_VCPU_MMAP_SIZE) };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(ret as usize)
    }

    /// Creates a new VM.
    pub fn create_vm(&self) -> KvmResult<KvmVmFd> {
        let ret = unsafe { libc::ioctl(self.fd.as_raw_fd(), KVM_CREATE_VM, 0) };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(KvmVmFd {
            fd: unsafe { OwnedFd::from_raw_fd(ret) },
        })
    }

    /// Returns the raw file descriptor.
    pub fn as_raw_fd(&self) -> RawFd {
        self.fd.as_raw_fd()
    }
}

/// Safe wrapper for KVM VM file descriptor.
pub struct KvmVmFd {
    fd: OwnedFd,
}

impl KvmVmFd {
    /// Sets a memory region for the VM.
    pub fn set_user_memory_region(&self, region: &KvmUserspaceMemoryRegion) -> KvmResult<()> {
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_SET_USER_MEMORY_REGION,
                region as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Creates a new vCPU.
    pub fn create_vcpu(&self, id: u32, mmap_size: usize) -> KvmResult<KvmVcpuFd> {
        let ret = unsafe { libc::ioctl(self.fd.as_raw_fd(), KVM_CREATE_VCPU, id as libc::c_ulong) };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }

        let fd = unsafe { OwnedFd::from_raw_fd(ret) };

        // mmap the kvm_run structure
        let run = unsafe {
            libc::mmap(
                ptr::null_mut(),
                mmap_size,
                libc::PROT_READ | libc::PROT_WRITE,
                libc::MAP_SHARED,
                fd.as_raw_fd(),
                0,
            )
        };

        if run == libc::MAP_FAILED {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }

        Ok(KvmVcpuFd {
            fd,
            kvm_run: run.cast(),
            mmap_size,
        })
    }

    /// Sets the TSS address (x86 only).
    #[cfg(target_arch = "x86_64")]
    pub fn set_tss_addr(&self, addr: u64) -> KvmResult<()> {
        let ret =
            unsafe { libc::ioctl(self.fd.as_raw_fd(), KVM_SET_TSS_ADDR, addr as libc::c_ulong) };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Sets the identity map address (x86 only).
    #[cfg(target_arch = "x86_64")]
    pub fn set_identity_map_addr(&self, addr: u64) -> KvmResult<()> {
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_SET_IDENTITY_MAP_ADDR,
                &addr as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Creates an in-kernel IRQ chip (x86 only).
    #[cfg(target_arch = "x86_64")]
    pub fn create_irqchip(&self) -> KvmResult<()> {
        let ret = unsafe { libc::ioctl(self.fd.as_raw_fd(), KVM_CREATE_IRQCHIP, 0) };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Creates a PIT2 (x86 only).
    #[cfg(target_arch = "x86_64")]
    pub fn create_pit2(&self, config: &KvmPitConfig) -> KvmResult<()> {
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_CREATE_PIT2,
                config as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Gets the preferred target for ARM64.
    #[cfg(target_arch = "aarch64")]
    pub fn get_preferred_target(&self) -> KvmResult<KvmVcpuInit> {
        let mut init = KvmVcpuInit::default();
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_ARM_PREFERRED_TARGET,
                &mut init as *mut _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(init)
    }

    /// Sets the IRQ line level.
    ///
    /// This is used to assert or deassert an IRQ line on the in-kernel irqchip.
    /// For edge-triggered interrupts, assert then deassert.
    /// For level-triggered interrupts, assert and keep asserted until acknowledged.
    ///
    /// # Arguments
    /// * `irq` - The GSI (Global System Interrupt) number
    /// * `level` - true to assert, false to deassert
    pub fn set_irq_line(&self, irq: u32, level: bool) -> KvmResult<()> {
        let irq_level = KvmIrqLevel {
            irq,
            level: if level { 1 } else { 0 },
        };
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_IRQ_LINE,
                &irq_level as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Registers an eventfd for IRQ injection (IRQFD).
    ///
    /// When the eventfd is written to, KVM will inject the specified GSI
    /// into the guest. This is the preferred method for high-performance
    /// interrupt delivery as it avoids kernel transitions.
    ///
    /// # Arguments
    /// * `fd` - The eventfd file descriptor
    /// * `gsi` - The GSI to inject
    /// * `resample_fd` - Optional eventfd for level-triggered IRQ resampling
    pub fn register_irqfd(&self, fd: RawFd, gsi: u32, resample_fd: Option<RawFd>) -> KvmResult<()> {
        let mut irqfd = KvmIrqfd {
            fd: fd as u32,
            gsi,
            flags: 0,
            resamplefd: 0,
            pad: [0; 16],
        };

        if let Some(resample) = resample_fd {
            irqfd.flags |= KVM_IRQFD_FLAG_RESAMPLE;
            irqfd.resamplefd = resample as u32;
        }

        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_IRQFD,
                &irqfd as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Unregisters an eventfd for IRQ injection.
    pub fn unregister_irqfd(&self, fd: RawFd, gsi: u32) -> KvmResult<()> {
        let irqfd = KvmIrqfd {
            fd: fd as u32,
            gsi,
            flags: KVM_IRQFD_FLAG_DEASSIGN,
            resamplefd: 0,
            pad: [0; 16],
        };

        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_IRQFD,
                &irqfd as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Registers an IOEVENTFD for MMIO writes.
    ///
    /// When a guest write occurs at the specified address, KVM will signal
    /// the eventfd instead of exiting to userspace. This is used for VirtIO
    /// queue notification.
    ///
    /// # Arguments
    /// * `addr` - The MMIO address to watch
    /// * `len` - The access size (1, 2, 4, or 8 bytes)
    /// * `fd` - The eventfd file descriptor to signal
    /// * `datamatch` - Optional: only trigger on matching data value
    pub fn register_ioeventfd(
        &self,
        addr: u64,
        len: u32,
        fd: RawFd,
        datamatch: Option<u64>,
    ) -> KvmResult<()> {
        let mut ioeventfd = KvmIoeventfd {
            addr,
            len,
            fd: fd as i32,
            flags: 0,
            datamatch: 0,
            pad: [0; 36],
        };

        if let Some(match_val) = datamatch {
            ioeventfd.datamatch = match_val;
            ioeventfd.flags |= KVM_IOEVENTFD_FLAG_DATAMATCH;
        }

        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_IOEVENTFD,
                &ioeventfd as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Unregisters an IOEVENTFD.
    pub fn unregister_ioeventfd(&self, addr: u64, len: u32, fd: RawFd) -> KvmResult<()> {
        let ioeventfd = KvmIoeventfd {
            addr,
            len,
            fd: fd as i32,
            flags: KVM_IOEVENTFD_FLAG_DEASSIGN,
            datamatch: 0,
            pad: [0; 36],
        };

        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_IOEVENTFD,
                &ioeventfd as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Enables dirty page logging for a memory slot.
    ///
    /// This updates the memory region to enable the `KVM_MEM_LOG_DIRTY_PAGES` flag.
    /// After enabling, dirty pages can be retrieved with `get_dirty_log`.
    ///
    /// # Arguments
    /// * `slot` - The memory slot ID
    /// * `guest_phys_addr` - Guest physical address of the region
    /// * `memory_size` - Size of the memory region
    /// * `userspace_addr` - Host virtual address of the memory
    pub fn enable_dirty_logging(
        &self,
        slot: u32,
        guest_phys_addr: u64,
        memory_size: u64,
        userspace_addr: u64,
    ) -> KvmResult<()> {
        let region = KvmUserspaceMemoryRegion {
            slot,
            flags: KVM_MEM_LOG_DIRTY_PAGES,
            guest_phys_addr,
            memory_size,
            userspace_addr,
        };

        self.set_user_memory_region(&region)
    }

    /// Disables dirty page logging for a memory slot.
    ///
    /// This updates the memory region to remove the `KVM_MEM_LOG_DIRTY_PAGES` flag.
    ///
    /// # Arguments
    /// * `slot` - The memory slot ID
    /// * `guest_phys_addr` - Guest physical address of the region
    /// * `memory_size` - Size of the memory region
    /// * `userspace_addr` - Host virtual address of the memory
    pub fn disable_dirty_logging(
        &self,
        slot: u32,
        guest_phys_addr: u64,
        memory_size: u64,
        userspace_addr: u64,
    ) -> KvmResult<()> {
        let region = KvmUserspaceMemoryRegion {
            slot,
            flags: 0,
            guest_phys_addr,
            memory_size,
            userspace_addr,
        };

        self.set_user_memory_region(&region)
    }

    /// Gets the dirty page bitmap for a memory slot.
    ///
    /// The bitmap is a bit array where each bit represents one page.
    /// A bit set to 1 indicates the corresponding page was written to since
    /// the last call to `get_dirty_log`.
    ///
    /// **Important**: Calling this function clears the dirty log for the slot.
    ///
    /// # Arguments
    /// * `slot` - The memory slot ID
    /// * `memory_size` - Size of the memory region (used to determine bitmap size)
    /// * `page_size` - Page size (typically 4096 bytes)
    ///
    /// # Returns
    /// A vector of u64 values representing the dirty bitmap.
    /// Each bit corresponds to a page: bit 0 of word 0 is page 0, etc.
    pub fn get_dirty_log(
        &self,
        slot: u32,
        memory_size: u64,
        page_size: u64,
    ) -> KvmResult<Vec<u64>> {
        // Calculate the number of pages and bitmap size.
        let num_pages = (memory_size + page_size - 1) / page_size;
        let bitmap_size = ((num_pages + 63) / 64) as usize; // Round up to u64

        // Allocate and zero the bitmap buffer.
        let mut bitmap: Vec<u64> = vec![0; bitmap_size];

        let dirty_log = KvmDirtyLog {
            slot,
            padding: 0,
            dirty_bitmap: bitmap.as_mut_ptr(),
        };

        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_GET_DIRTY_LOG,
                &dirty_log as *const _ as libc::c_ulong,
            )
        };

        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }

        Ok(bitmap)
    }

    /// Returns the raw file descriptor.
    pub fn as_raw_fd(&self) -> RawFd {
        self.fd.as_raw_fd()
    }
}

/// Safe wrapper for KVM vCPU file descriptor.
pub struct KvmVcpuFd {
    fd: OwnedFd,
    kvm_run: *mut KvmRun,
    mmap_size: usize,
}

// Safety: The kvm_run pointer is only accessed through controlled methods.
unsafe impl Send for KvmVcpuFd {}

impl KvmVcpuFd {
    /// Runs the vCPU until a VM exit occurs.
    pub fn run(&self) -> KvmResult<()> {
        let ret = unsafe { libc::ioctl(self.fd.as_raw_fd(), KVM_RUN, 0) };
        if ret < 0 {
            let err = std::io::Error::last_os_error();
            // EINTR is not an error, it just means we were interrupted
            if err.raw_os_error() == Some(libc::EINTR) {
                return Ok(());
            }
            return Err(KvmError::from(err));
        }
        Ok(())
    }

    /// Gets the exit reason from the last run.
    pub fn exit_reason(&self) -> u32 {
        unsafe { (*self.kvm_run).exit_reason }
    }

    /// Gets the KVM run structure.
    ///
    /// # Safety
    ///
    /// The returned reference is only valid while the vCPU is not running.
    pub unsafe fn kvm_run(&self) -> &KvmRun {
        unsafe { &*self.kvm_run }
    }

    /// Gets the KVM run structure mutably.
    ///
    /// # Safety
    ///
    /// The returned reference is only valid while the vCPU is not running.
    pub unsafe fn kvm_run_mut(&self) -> &mut KvmRun {
        unsafe { &mut *self.kvm_run }
    }

    /// Gets the general purpose registers.
    pub fn get_regs(&self) -> KvmResult<KvmRegs> {
        let mut regs = KvmRegs::default();
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_GET_REGS,
                &mut regs as *mut _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(regs)
    }

    /// Sets the general purpose registers.
    pub fn set_regs(&self, regs: &KvmRegs) -> KvmResult<()> {
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_SET_REGS,
                regs as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Gets the special registers (x86 only).
    #[cfg(target_arch = "x86_64")]
    pub fn get_sregs(&self) -> KvmResult<KvmSregs> {
        let mut sregs = KvmSregs::default();
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_GET_SREGS,
                &mut sregs as *mut _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(sregs)
    }

    /// Sets the special registers (x86 only).
    #[cfg(target_arch = "x86_64")]
    pub fn set_sregs(&self, sregs: &KvmSregs) -> KvmResult<()> {
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_SET_SREGS,
                sregs as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Sets CPUID entries (x86 only).
    #[cfg(target_arch = "x86_64")]
    pub fn set_cpuid2(&self, cpuid: &KvmCpuid2) -> KvmResult<()> {
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_SET_CPUID2,
                cpuid as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Initializes the vCPU (ARM64 only).
    #[cfg(target_arch = "aarch64")]
    pub fn vcpu_init(&self, init: &KvmVcpuInit) -> KvmResult<()> {
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_ARM_VCPU_INIT,
                init as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Gets a single register (ARM64 only).
    #[cfg(target_arch = "aarch64")]
    pub fn get_one_reg(&self, reg_id: u64) -> KvmResult<u64> {
        let mut value: u64 = 0;
        let reg = KvmOneReg {
            id: reg_id,
            addr: &mut value as *mut u64 as u64,
        };
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_GET_ONE_REG,
                &reg as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(value)
    }

    /// Sets a single register (ARM64 only).
    #[cfg(target_arch = "aarch64")]
    pub fn set_one_reg(&self, reg_id: u64, value: u64) -> KvmResult<()> {
        let mut val = value;
        let reg = KvmOneReg {
            id: reg_id,
            addr: &mut val as *mut u64 as u64,
        };
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_SET_ONE_REG,
                &reg as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Sets the immediate_exit flag to cause the next KVM_RUN to return immediately.
    pub fn set_immediate_exit(&self, enable: bool) {
        unsafe {
            (*self.kvm_run).immediate_exit = if enable { 1 } else { 0 };
        }
    }

    /// Injects an external interrupt into the vCPU (x86 only).
    ///
    /// This is used to inject an interrupt directly into the vCPU.
    /// The vCPU must be in a state where it can receive interrupts
    /// (i.e., `ready_for_interrupt_injection` is true).
    ///
    /// # Arguments
    /// * `irq` - The interrupt vector (0-255)
    #[cfg(target_arch = "x86_64")]
    pub fn inject_interrupt(&self, irq: u32) -> KvmResult<()> {
        let interrupt = KvmInterrupt { irq };
        let ret = unsafe {
            libc::ioctl(
                self.fd.as_raw_fd(),
                KVM_INTERRUPT,
                &interrupt as *const _ as libc::c_ulong,
            )
        };
        if ret < 0 {
            return Err(KvmError::from(std::io::Error::last_os_error()));
        }
        Ok(())
    }

    /// Checks if the vCPU is ready for interrupt injection.
    ///
    /// Returns true if an interrupt can be injected via `inject_interrupt`.
    pub fn ready_for_interrupt(&self) -> bool {
        unsafe { (*self.kvm_run).ready_for_interrupt_injection != 0 }
    }

    /// Requests an interrupt window exit.
    ///
    /// When set, the next KVM_RUN will exit with KVM_EXIT_IRQ_WINDOW_OPEN
    /// when the vCPU becomes ready to receive interrupts.
    pub fn request_interrupt_window(&self, enable: bool) {
        unsafe {
            (*self.kvm_run).request_interrupt_window = if enable { 1 } else { 0 };
        }
    }

    /// Returns the raw file descriptor.
    pub fn as_raw_fd(&self) -> RawFd {
        self.fd.as_raw_fd()
    }
}

impl Drop for KvmVcpuFd {
    fn drop(&mut self) {
        unsafe {
            libc::munmap(self.kvm_run.cast(), self.mmap_size);
        }
    }
}

// ============================================================================
// Memory Allocation Helpers
// ============================================================================

/// Allocates guest memory using mmap.
pub fn allocate_memory(size: u64) -> KvmResult<*mut u8> {
    let ptr = unsafe {
        libc::mmap(
            ptr::null_mut(),
            size as usize,
            libc::PROT_READ | libc::PROT_WRITE,
            libc::MAP_PRIVATE | libc::MAP_ANONYMOUS,
            -1,
            0,
        )
    };

    if ptr == libc::MAP_FAILED {
        return Err(KvmError::from(std::io::Error::last_os_error()));
    }

    // Zero the memory
    unsafe {
        libc::memset(ptr, 0, size as usize);
    }

    tracing::debug!("Allocated {}MB of guest memory", size / (1024 * 1024));

    Ok(ptr.cast::<u8>())
}

/// Frees guest memory.
pub fn free_memory(ptr: *mut u8, size: u64) {
    if !ptr.is_null() {
        unsafe {
            libc::munmap(ptr.cast(), size as usize);
        }
    }
}

// ============================================================================
// Tests
// ============================================================================

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    #[ignore] // Requires /dev/kvm
    fn test_kvm_open() {
        let kvm = KvmSystem::open().expect("Failed to open /dev/kvm");
        let version = kvm.api_version().expect("Failed to get API version");
        println!("KVM API version: {}", version);
        assert_eq!(version, 12); // KVM API is stable at version 12
    }

    #[test]
    #[ignore] // Requires /dev/kvm
    fn test_kvm_extensions() {
        let kvm = KvmSystem::open().expect("Failed to open /dev/kvm");

        let user_mem = kvm
            .check_extension(KVM_CAP_USER_MEMORY)
            .expect("Failed to check extension");
        println!("KVM_CAP_USER_MEMORY: {}", user_mem);
        assert!(user_mem > 0);

        let max_vcpus = kvm
            .check_extension(KVM_CAP_MAX_VCPUS)
            .expect("Failed to check extension");
        println!("KVM_CAP_MAX_VCPUS: {}", max_vcpus);
        assert!(max_vcpus > 0);
    }

    #[test]
    #[ignore] // Requires /dev/kvm
    fn test_create_vm() {
        let kvm = KvmSystem::open().expect("Failed to open /dev/kvm");
        let vm = kvm.create_vm().expect("Failed to create VM");
        assert!(vm.as_raw_fd() >= 0);
    }

    #[test]
    fn test_allocate_memory() {
        let size = 16 * 1024 * 1024; // 16MB
        let ptr = allocate_memory(size).expect("Failed to allocate memory");
        assert!(!ptr.is_null());

        // Write and read back
        unsafe {
            *ptr = 42;
            assert_eq!(*ptr, 42);
        }

        free_memory(ptr, size);
    }
}