arcan-core 0.3.0

Core traits, protocol types, and state management for the Arcan agent runtime
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
//! Message queue and steering semantics for concurrent message handling (Phase 2.5).
//!
//! Enables safe preemption at tool boundaries, message queuing during active runs,
//! and priority-based drain ordering: interrupt > steer > followup > collect.

use aios_protocol::SteeringMode;
use serde::{Deserialize, Serialize};
use std::collections::VecDeque;
use std::sync::{Arc, Mutex};
use std::time::{Duration, Instant};

// ─── Configuration ───────────────────────────────────────────────

/// Configuration for the message queue.
#[derive(Debug, Clone)]
pub struct QueueConfig {
    /// Maximum number of pending messages (default: 10).
    pub max_queue_depth: usize,
    /// Max time to wait for a tool boundary when steering (default: 30s).
    pub steer_timeout: Duration,
    /// Batch collect messages within this window (default: 2s).
    pub collect_coalesce_window: Duration,
}

impl Default for QueueConfig {
    fn default() -> Self {
        Self {
            max_queue_depth: 10,
            steer_timeout: Duration::from_secs(30),
            collect_coalesce_window: Duration::from_secs(2),
        }
    }
}

// ─── Queued message ──────────────────────────────────────────────

/// A message waiting in the queue.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct QueuedMessage {
    /// Unique identifier for this queued message.
    pub id: String,
    /// How this message should interact with the active run.
    pub mode: SteeringMode,
    /// The message content (user text, instruction, etc.).
    pub content: String,
    /// When the message was queued (not serialized — set on enqueue).
    #[serde(skip)]
    pub queued_at: Option<Instant>,
}

// ─── Steering action ─────────────────────────────────────────────

/// Action to take at a tool boundary based on queue state.
#[derive(Debug, Clone)]
pub enum SteeringAction {
    /// Continue current run (no preemption).
    Continue,
    /// Inject a new message into the current run context.
    InjectMessage(String),
    /// Complete current run early and start new run with queued message.
    CompleteAndSwitch(QueuedMessage),
    /// Abort current run (emergency interrupt).
    Abort { reason: String },
}

// ─── Preemption check trait ──────────────────────────────────────

/// Trait for checking preemption at tool boundaries.
///
/// Called after each tool execution completes. Implementors inspect the
/// queue state and decide whether the run should continue or be redirected.
pub trait PreemptionCheck: Send + Sync {
    /// Called after each tool execution completes.
    /// Returns a `SteeringAction` indicating what should happen next.
    fn check_preemption(&self) -> Result<SteeringAction, QueueError>;
}

// ─── Queue status ────────────────────────────────────────────────

/// Snapshot of the queue state for API responses.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct QueueStatus {
    pub depth: usize,
    pub pending: Vec<QueuedMessage>,
    pub has_active_run: bool,
    pub oldest_message_age_ms: Option<u64>,
}

// ─── Queue error ─────────────────────────────────────────────────

/// Errors from queue operations.
#[derive(Debug, Clone, thiserror::Error)]
pub enum QueueError {
    #[error("queue is full (depth: {depth}, max: {max})")]
    QueueFull { depth: usize, max: usize },
    #[error("message not found: {id}")]
    NotFound { id: String },
    #[error("internal lock poisoned: {0}")]
    LockPoisoned(String),
}

// ─── Message queue ───────────────────────────────────────────────

/// Thread-safe message queue with steering semantics.
///
/// Messages are enqueued with a [`SteeringMode`] that determines how they
/// interact with an active run. The queue supports priority-based ordering
/// and safe preemption at tool boundaries.
pub struct MessageQueue {
    inner: Arc<Mutex<QueueInner>>,
    config: QueueConfig,
}

struct QueueInner {
    pending: VecDeque<QueuedMessage>,
    has_active_run: bool,
}

impl MessageQueue {
    /// Create a new message queue with the given configuration.
    pub fn new(config: QueueConfig) -> Self {
        Self {
            inner: Arc::new(Mutex::new(QueueInner {
                pending: VecDeque::new(),
                has_active_run: false,
            })),
            config,
        }
    }

    /// Enqueue a message. Returns error if queue is full.
    pub fn enqueue(&self, message: QueuedMessage) -> Result<(), QueueError> {
        let mut inner = self
            .inner
            .lock()
            .map_err(|e| QueueError::LockPoisoned(e.to_string()))?;
        if inner.pending.len() >= self.config.max_queue_depth {
            return Err(QueueError::QueueFull {
                depth: inner.pending.len(),
                max: self.config.max_queue_depth,
            });
        }
        let mut msg = message;
        msg.queued_at = Some(Instant::now());
        inner.pending.push_back(msg);
        Ok(())
    }

    /// Remove a specific queued message by ID.
    pub fn remove(&self, id: &str) -> Result<QueuedMessage, QueueError> {
        let mut inner = self
            .inner
            .lock()
            .map_err(|e| QueueError::LockPoisoned(e.to_string()))?;
        let pos = inner
            .pending
            .iter()
            .position(|m| m.id == id)
            .ok_or_else(|| QueueError::NotFound { id: id.to_owned() })?;
        Ok(inner.pending.remove(pos).expect("position valid"))
    }

    /// Get a snapshot of the current queue state.
    pub fn status(&self) -> Result<QueueStatus, QueueError> {
        let inner = self
            .inner
            .lock()
            .map_err(|e| QueueError::LockPoisoned(e.to_string()))?;
        let oldest_age = inner
            .pending
            .front()
            .and_then(|m| m.queued_at.map(|t| t.elapsed().as_millis() as u64));
        Ok(QueueStatus {
            depth: inner.pending.len(),
            pending: inner.pending.iter().cloned().collect(),
            has_active_run: inner.has_active_run,
            oldest_message_age_ms: oldest_age,
        })
    }

    /// Mark that an active run has started.
    pub fn set_active_run(&self, active: bool) -> Result<(), QueueError> {
        let mut inner = self
            .inner
            .lock()
            .map_err(|e| QueueError::LockPoisoned(e.to_string()))?;
        inner.has_active_run = active;
        Ok(())
    }

    /// Whether there is an active run.
    pub fn has_active_run(&self) -> Result<bool, QueueError> {
        let inner = self
            .inner
            .lock()
            .map_err(|e| QueueError::LockPoisoned(e.to_string()))?;
        Ok(inner.has_active_run)
    }

    /// Check for preemption at a tool boundary.
    ///
    /// Inspects the queue for `Interrupt` or `Steer` messages and returns
    /// the appropriate `SteeringAction`. Priority: interrupt > steer.
    pub fn check_preemption(&self) -> Result<SteeringAction, QueueError> {
        let mut inner = self
            .inner
            .lock()
            .map_err(|e| QueueError::LockPoisoned(e.to_string()))?;

        // Priority 1: Interrupt messages — abort immediately
        if let Some(pos) = inner
            .pending
            .iter()
            .position(|m| m.mode == SteeringMode::Interrupt)
        {
            let msg = inner.pending.remove(pos).expect("position valid");
            return Ok(SteeringAction::Abort {
                reason: format!("interrupted by queue message: {}", msg.id),
            });
        }

        // Priority 2: Steer messages — complete and switch
        if let Some(pos) = inner
            .pending
            .iter()
            .position(|m| m.mode == SteeringMode::Steer)
        {
            let msg = inner.pending.remove(pos).expect("position valid");
            return Ok(SteeringAction::CompleteAndSwitch(msg));
        }

        Ok(SteeringAction::Continue)
    }

    /// Drain messages after a run completes, in priority order.
    ///
    /// Returns messages ordered: followup first (same context), then collect (fresh runs).
    /// Collect messages within the coalesce window are batched together.
    pub fn drain_after_run(&self) -> Result<Vec<QueuedMessage>, QueueError> {
        let mut inner = self
            .inner
            .lock()
            .map_err(|e| QueueError::LockPoisoned(e.to_string()))?;
        inner.has_active_run = false;

        if inner.pending.is_empty() {
            return Ok(Vec::new());
        }

        let mut followups = Vec::new();
        let mut collects = Vec::new();
        let mut remaining = VecDeque::new();

        for msg in inner.pending.drain(..) {
            match msg.mode {
                SteeringMode::Followup => followups.push(msg),
                SteeringMode::Collect => collects.push(msg),
                // Interrupt/Steer messages that weren't consumed during the run
                // are treated as fresh collects.
                SteeringMode::Interrupt | SteeringMode::Steer => collects.push(msg),
            }
        }

        // Coalesce collect messages within the window
        let window = self.config.collect_coalesce_window;
        if collects.len() > 1 {
            let now = Instant::now();
            let (within_window, outside): (Vec<_>, Vec<_>) = collects
                .into_iter()
                .partition(|m| m.queued_at.is_some_and(|t| now.duration_since(t) <= window));
            for msg in outside {
                remaining.push_back(msg);
            }
            collects = within_window;
        }

        inner.pending = remaining;

        let mut result = followups;
        result.extend(collects);
        Ok(result)
    }

    /// Check queue health for heartbeat integration.
    pub fn health_check(&self) -> Result<Vec<String>, QueueError> {
        let inner = self
            .inner
            .lock()
            .map_err(|e| QueueError::LockPoisoned(e.to_string()))?;
        let mut warnings = Vec::new();

        let depth = inner.pending.len();
        let threshold = self.config.max_queue_depth / 2;
        if depth > threshold {
            warnings.push(format!(
                "queue depth {depth} exceeds warning threshold {threshold}"
            ));
        }

        let stale_timeout = self.config.steer_timeout * 2;
        if let Some(oldest) = inner.pending.front()
            && let Some(queued_at) = oldest.queued_at
            && queued_at.elapsed() > stale_timeout
        {
            warnings.push(format!(
                "oldest message {} is stale ({:.1}s old)",
                oldest.id,
                queued_at.elapsed().as_secs_f64()
            ));
        }

        Ok(warnings)
    }

    /// Current queue depth.
    pub fn depth(&self) -> Result<usize, QueueError> {
        let inner = self
            .inner
            .lock()
            .map_err(|e| QueueError::LockPoisoned(e.to_string()))?;
        Ok(inner.pending.len())
    }

    /// Get a reference to the queue config.
    pub fn config(&self) -> &QueueConfig {
        &self.config
    }
}

impl PreemptionCheck for MessageQueue {
    fn check_preemption(&self) -> Result<SteeringAction, QueueError> {
        self.check_preemption()
    }
}

impl Clone for MessageQueue {
    fn clone(&self) -> Self {
        Self {
            inner: self.inner.clone(),
            config: self.config.clone(),
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn make_msg(id: &str, mode: SteeringMode, content: &str) -> QueuedMessage {
        QueuedMessage {
            id: id.to_string(),
            mode,
            content: content.to_string(),
            queued_at: None,
        }
    }

    #[test]
    fn collect_mode_queued_and_drained() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue.set_active_run(true).unwrap();

        queue
            .enqueue(make_msg("q1", SteeringMode::Collect, "do this later"))
            .unwrap();

        assert_eq!(queue.depth().unwrap(), 1);
        assert!(queue.has_active_run().unwrap());

        assert!(matches!(
            queue.check_preemption().unwrap(),
            SteeringAction::Continue
        ));

        let drained = queue.drain_after_run().unwrap();
        assert_eq!(drained.len(), 1);
        assert_eq!(drained[0].id, "q1");
        assert!(!queue.has_active_run().unwrap());
    }

    #[test]
    fn steer_mode_preempts_at_tool_boundary() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue.set_active_run(true).unwrap();

        queue
            .enqueue(make_msg("q1", SteeringMode::Steer, "do this instead"))
            .unwrap();

        match queue.check_preemption().unwrap() {
            SteeringAction::CompleteAndSwitch(msg) => {
                assert_eq!(msg.id, "q1");
                assert_eq!(msg.content, "do this instead");
            }
            other => panic!("expected CompleteAndSwitch, got {other:?}"),
        }

        assert_eq!(queue.depth().unwrap(), 0);
    }

    #[test]
    fn followup_inherits_context_order() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue.set_active_run(true).unwrap();

        queue
            .enqueue(make_msg("c1", SteeringMode::Collect, "fresh run"))
            .unwrap();
        queue
            .enqueue(make_msg("f1", SteeringMode::Followup, "same context"))
            .unwrap();

        let drained = queue.drain_after_run().unwrap();
        assert_eq!(drained.len(), 2);
        assert_eq!(drained[0].id, "f1");
        assert_eq!(drained[1].id, "c1");
    }

    #[test]
    fn interrupt_aborts_at_tool_boundary() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue.set_active_run(true).unwrap();

        queue
            .enqueue(make_msg("i1", SteeringMode::Interrupt, "stop now"))
            .unwrap();

        match queue.check_preemption().unwrap() {
            SteeringAction::Abort { reason } => {
                assert!(reason.contains("i1"));
            }
            other => panic!("expected Abort, got {other:?}"),
        }
    }

    #[test]
    fn queue_depth_limit_enforced() {
        let config = QueueConfig {
            max_queue_depth: 2,
            ..Default::default()
        };
        let queue = MessageQueue::new(config);

        queue
            .enqueue(make_msg("q1", SteeringMode::Collect, "1"))
            .unwrap();
        queue
            .enqueue(make_msg("q2", SteeringMode::Collect, "2"))
            .unwrap();

        let result = queue.enqueue(make_msg("q3", SteeringMode::Collect, "3"));
        assert!(result.is_err());
        assert!(matches!(
            result.unwrap_err(),
            QueueError::QueueFull { depth: 2, max: 2 }
        ));
    }

    #[test]
    fn steer_timeout_falls_back_to_collect() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue.set_active_run(true).unwrap();

        queue
            .enqueue(make_msg("s1", SteeringMode::Steer, "should steer"))
            .unwrap();

        let drained = queue.drain_after_run().unwrap();
        assert_eq!(drained.len(), 1);
        assert_eq!(drained[0].id, "s1");
    }

    #[test]
    fn collect_messages_coalesced_within_window() {
        let config = QueueConfig {
            collect_coalesce_window: Duration::from_secs(10),
            ..Default::default()
        };
        let queue = MessageQueue::new(config);
        queue.set_active_run(true).unwrap();

        queue
            .enqueue(make_msg("c1", SteeringMode::Collect, "a"))
            .unwrap();
        queue
            .enqueue(make_msg("c2", SteeringMode::Collect, "b"))
            .unwrap();
        queue
            .enqueue(make_msg("c3", SteeringMode::Collect, "c"))
            .unwrap();

        let drained = queue.drain_after_run().unwrap();
        assert_eq!(drained.len(), 3);
    }

    #[test]
    fn drain_order_interrupt_steer_followup_collect() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue.set_active_run(true).unwrap();

        queue
            .enqueue(make_msg("c1", SteeringMode::Collect, "collect"))
            .unwrap();
        queue
            .enqueue(make_msg("f1", SteeringMode::Followup, "followup"))
            .unwrap();
        queue
            .enqueue(make_msg("i1", SteeringMode::Interrupt, "interrupt"))
            .unwrap();
        queue
            .enqueue(make_msg("s1", SteeringMode::Steer, "steer"))
            .unwrap();

        match queue.check_preemption().unwrap() {
            SteeringAction::Abort { .. } => {}
            other => panic!("expected Abort from interrupt, got {other:?}"),
        }

        match queue.check_preemption().unwrap() {
            SteeringAction::CompleteAndSwitch(msg) => assert_eq!(msg.id, "s1"),
            other => panic!("expected CompleteAndSwitch from steer, got {other:?}"),
        }

        let drained = queue.drain_after_run().unwrap();
        assert_eq!(drained.len(), 2);
        assert_eq!(drained[0].id, "f1");
        assert_eq!(drained[1].id, "c1");
    }

    #[test]
    fn preemption_returns_continue_on_empty_queue() {
        let queue = MessageQueue::new(QueueConfig::default());
        assert!(matches!(
            queue.check_preemption().unwrap(),
            SteeringAction::Continue
        ));
    }

    #[test]
    fn remove_specific_message() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue
            .enqueue(make_msg("q1", SteeringMode::Collect, "a"))
            .unwrap();
        queue
            .enqueue(make_msg("q2", SteeringMode::Collect, "b"))
            .unwrap();

        let removed = queue.remove("q1").unwrap();
        assert_eq!(removed.id, "q1");
        assert_eq!(queue.depth().unwrap(), 1);

        assert!(queue.remove("q99").is_err());
    }

    #[test]
    fn status_snapshot() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue.set_active_run(true).unwrap();
        queue
            .enqueue(make_msg("q1", SteeringMode::Collect, "test"))
            .unwrap();

        let status = queue.status().unwrap();
        assert_eq!(status.depth, 1);
        assert!(status.has_active_run);
        assert_eq!(status.pending.len(), 1);
        assert!(status.oldest_message_age_ms.is_some());
    }

    #[test]
    fn health_check_warns_on_depth() {
        let config = QueueConfig {
            max_queue_depth: 4,
            ..Default::default()
        };
        let queue = MessageQueue::new(config);

        for i in 0..3 {
            queue
                .enqueue(make_msg(&format!("q{i}"), SteeringMode::Collect, "x"))
                .unwrap();
        }

        let warnings = queue.health_check().unwrap();
        assert!(
            warnings
                .iter()
                .any(|w| w.contains("exceeds warning threshold"))
        );
    }

    #[test]
    fn clone_shares_state() {
        let queue = MessageQueue::new(QueueConfig::default());
        let queue2 = queue.clone();

        queue
            .enqueue(make_msg("q1", SteeringMode::Collect, "shared"))
            .unwrap();
        assert_eq!(queue2.depth().unwrap(), 1);
    }

    #[test]
    fn multiple_followups_preserved_in_order() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue.set_active_run(true).unwrap();

        queue
            .enqueue(make_msg("f1", SteeringMode::Followup, "first"))
            .unwrap();
        queue
            .enqueue(make_msg("f2", SteeringMode::Followup, "second"))
            .unwrap();
        queue
            .enqueue(make_msg("f3", SteeringMode::Followup, "third"))
            .unwrap();

        let drained = queue.drain_after_run().unwrap();
        assert_eq!(drained.len(), 3);
        assert_eq!(drained[0].id, "f1");
        assert_eq!(drained[1].id, "f2");
        assert_eq!(drained[2].id, "f3");
    }

    #[test]
    fn drain_empty_queue_returns_empty() {
        let queue = MessageQueue::new(QueueConfig::default());
        queue.set_active_run(true).unwrap();
        let drained = queue.drain_after_run().unwrap();
        assert!(drained.is_empty());
    }
}