arc-web 0.2.2

Arc framework runtime: Actix/Tera web machinery, event-sourcing wiring, and the application builder seam.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103

use actix_web::{HttpResponse, ResponseError};
use arc_core::command_bus::CommandBusError;
use arc_core::event_store::EventStoreError;

#[derive(Debug, thiserror::Error)]
pub enum AppError {
    #[error("Command failed: {0}")]
    CommandFailed(#[from] CommandBusError),
    #[error("Audit failed: {message}")]
    AuditFailed {
        status: actix_web::http::StatusCode,
        message: String,
    },
}

// AppError is already handled by derive(thiserror::Error) for Display
impl ResponseError for AppError {
    fn error_response(&self) -> HttpResponse {
        match self {
            AppError::AuditFailed { status, message } => {
                HttpResponse::build(*status).json(serde_json::json!({
                    "error": "AuditFailed",
                    "message": message
                }))
            }
            AppError::CommandFailed(err) => match err {
                CommandBusError::HandleFailed { message, .. } => {
                    HttpResponse::UnprocessableEntity().json(serde_json::json!({
                        "error": "ValidationFailed",
                        "message": message
                    }))
                }
                CommandBusError::AppendFailed { source, .. } => match source {
                    EventStoreError::ConcurrencyConflict { .. } => {
                        HttpResponse::Conflict().json(serde_json::json!({
                            "error": "ConcurrencyConflict",
                            "message": "Resource was modified by another request. Please try again."
                        }))
                    }
                    _ => HttpResponse::InternalServerError().json(serde_json::json!({
                        "error": "InternalServerError",
                        "message": "Storage error."
                    })),
                },
                CommandBusError::LoadFailed { .. } => {
                    HttpResponse::NotFound().json(serde_json::json!({
                        "error": "NotFound",
                        "message": "Resource not found."
                    }))
                }
                CommandBusError::InvalidAudit { .. } => {
                    HttpResponse::BadRequest().json(serde_json::json!({
                        "error": "InvalidAudit",
                        "message": "Audit metadata for this request is missing or malformed."
                    }))
                }
                _ => HttpResponse::InternalServerError().json(serde_json::json!({
                    "error": "InternalServerError",
                    "message": "An unexpected error occurred."
                })),
            },
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use actix_web::http::StatusCode;
    use arc_core::audit::AuditError;

    #[test]
    fn test_invalid_audit_maps_to_bad_request() {
        let err = AppError::CommandFailed(CommandBusError::InvalidAudit {
            aggregate_id: "u-1".to_string(),
            source: AuditError::EmptyActorId,
        });
        let resp = err.error_response();
        assert_eq!(resp.status(), StatusCode::BAD_REQUEST);
    }

    #[test]
    fn test_handle_failed_maps_to_unprocessable_entity() {
        let err = AppError::CommandFailed(CommandBusError::handle_failed("u-1", "bad email"));
        assert_eq!(
            err.error_response().status(),
            StatusCode::UNPROCESSABLE_ENTITY
        );
    }

    #[test]
    fn test_concurrency_conflict_maps_to_conflict() {
        let err = AppError::CommandFailed(CommandBusError::AppendFailed {
            aggregate_id: "u-1".to_string(),
            source: EventStoreError::ConcurrencyConflict {
                aggregate_id: "u-1".to_string(),
                expected: 1,
                actual: 2,
            },
        });
        assert_eq!(err.error_response().status(), StatusCode::CONFLICT);
    }
}