aranet-cli 0.2.0

Command-line interface for Aranet environmental sensors
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
//! Native menu bar integration for the Aranet GUI.
//!
//! This module provides cross-platform native menu bar support using the `muda` crate
//! (via the tray-icon re-export to avoid Objective-C class conflicts).
//! It creates native menus on:
//! - macOS: NSMenu (system menu bar at top of screen)
//! - Windows: Win32 menus
//! - Linux: GTK3 menus
//!
//! The menu mirrors the application's keyboard shortcuts and provides access to
//! all major features.

// Use tray_icon's re-export of muda to avoid Objective-C class registration conflicts
use tracing::{debug, info};
use tray_icon::menu::{
    CheckMenuItem, Menu, MenuEvent, MenuItem, PredefinedMenuItem, Submenu,
    accelerator::{Accelerator, Code, Modifiers},
};

/// Commands that can be triggered from the native menu bar.
#[derive(Debug, Clone)]
pub enum MenuCommand {
    // === File Menu ===
    /// Scan for nearby devices (F5)
    Scan,
    /// Refresh all connected devices (Cmd+R)
    RefreshAll,
    /// Export history as CSV (Cmd+E)
    ExportCsv,
    /// Export history as JSON (Cmd+Shift+E)
    ExportJson,

    // === View Menu ===
    /// Toggle dark/light theme
    ToggleTheme,
    /// Set theme to system default
    ThemeSystem,
    /// Set theme to light mode
    ThemeLight,
    /// Set theme to dark mode
    ThemeDark,
    /// Toggle auto-refresh (A)
    ToggleAutoRefresh,
    /// Set refresh interval
    SetRefreshInterval(u16),
    /// Toggle notifications
    ToggleNotifications,
    /// Toggle Do Not Disturb mode
    ToggleDoNotDisturb,
    /// Toggle data logging to CSV file
    ToggleDataLogging,
    /// Toggle sticky alerts (don't auto-clear)
    ToggleStickyAlerts,
    /// Toggle CO2 display
    ToggleCo2Display,
    /// Toggle temperature display
    ToggleTemperatureDisplay,
    /// Toggle humidity display
    ToggleHumidityDisplay,
    /// Toggle pressure display
    TogglePressureDisplay,
    /// Switch to Dashboard tab (Cmd+1)
    ShowDashboard,
    /// Switch to History tab (Cmd+2)
    ShowHistory,
    /// Switch to Settings tab (Cmd+3)
    ShowSettings,
    /// Switch to Service tab (Cmd+4)
    ShowService,

    // === Device Menu ===
    /// Connect to a specific device by index
    ConnectDevice(usize),
    /// Disconnect from a device by index
    DisconnectDevice(usize),
    /// Open device aliases configuration
    ManageAliases,
    /// Forget/remove a device
    ForgetDevice(usize),

    // === Help Menu ===
    /// Open online documentation
    OpenDocumentation,
    /// Open GitHub issues page
    ReportIssue,
    /// Check for updates
    CheckForUpdates,
    /// Show about dialog (Windows/Linux)
    ShowAbout,

    /// Quit the application
    Quit,
}

/// Holds menu item IDs for event matching.
pub struct MenuManager {
    // === File menu items ===
    scan_item: MenuItem,
    refresh_item: MenuItem,
    export_csv_item: MenuItem,
    export_json_item: MenuItem,

    // === View menu items ===
    /// Appearance submenu items
    theme_system_item: CheckMenuItem,
    theme_light_item: CheckMenuItem,
    theme_dark_item: CheckMenuItem,
    /// Legacy toggle (for backwards compat with keyboard shortcut)
    #[allow(dead_code)]
    theme_toggle_item: CheckMenuItem,
    auto_refresh_item: CheckMenuItem,
    /// Refresh interval submenu items
    interval_30s_item: CheckMenuItem,
    interval_1m_item: CheckMenuItem,
    interval_5m_item: CheckMenuItem,
    interval_10m_item: CheckMenuItem,
    /// Notifications toggle
    notifications_item: CheckMenuItem,
    /// Do Not Disturb toggle
    do_not_disturb_item: CheckMenuItem,
    /// Data logging toggle
    data_logging_item: CheckMenuItem,
    /// Sticky alerts toggle
    sticky_alerts_item: CheckMenuItem,
    /// Display toggles
    show_co2_item: CheckMenuItem,
    show_temp_item: CheckMenuItem,
    show_humidity_item: CheckMenuItem,
    show_pressure_item: CheckMenuItem,
    /// Tab navigation
    dashboard_item: MenuItem,
    history_item: MenuItem,
    settings_item: MenuItem,
    service_item: MenuItem,

    // === Device menu ===
    device_menu: Submenu,
    manage_aliases_item: MenuItem,

    // === Help menu items ===
    documentation_item: MenuItem,
    report_issue_item: MenuItem,
    check_updates_item: MenuItem,
    #[cfg(not(target_os = "macos"))]
    about_item: MenuItem,

    /// The main menu bar
    #[allow(dead_code)]
    menu: Menu,
}

impl MenuManager {
    /// Create the native menu bar.
    ///
    /// On macOS, this should be called from the main thread before the event loop.
    pub fn new() -> Result<Self, tray_icon::menu::Error> {
        let menu = Menu::new();

        // Platform-specific modifier key
        #[cfg(target_os = "macos")]
        let cmd = Modifiers::META;
        #[cfg(not(target_os = "macos"))]
        let cmd = Modifiers::CONTROL;

        // === App menu (macOS only) ===
        #[cfg(target_os = "macos")]
        {
            let app_menu = Submenu::new("Aranet", true);
            app_menu.append(&PredefinedMenuItem::about(Some("About Aranet"), None))?;
            app_menu.append(&PredefinedMenuItem::separator())?;
            app_menu.append(&PredefinedMenuItem::services(None))?;
            app_menu.append(&PredefinedMenuItem::separator())?;
            app_menu.append(&PredefinedMenuItem::hide(Some("Hide Aranet")))?;
            app_menu.append(&PredefinedMenuItem::hide_others(None))?;
            app_menu.append(&PredefinedMenuItem::show_all(None))?;
            app_menu.append(&PredefinedMenuItem::separator())?;
            app_menu.append(&PredefinedMenuItem::quit(Some("Quit Aranet")))?;
            menu.append(&app_menu)?;
        }

        // === File menu ===
        let file_menu = Submenu::new("File", true);

        let scan_item = MenuItem::new(
            "Scan for Devices",
            true,
            Some(Accelerator::new(None, Code::F5)),
        );
        let refresh_item = MenuItem::new(
            "Refresh All",
            true,
            Some(Accelerator::new(Some(cmd), Code::KeyR)),
        );

        file_menu.append(&scan_item)?;
        file_menu.append(&refresh_item)?;
        file_menu.append(&PredefinedMenuItem::separator())?;

        // Export submenu
        let export_menu = Submenu::new("Export History", true);
        let export_csv_item = MenuItem::new(
            "Export as CSV...",
            true,
            Some(Accelerator::new(Some(cmd), Code::KeyE)),
        );
        let export_json_item = MenuItem::new(
            "Export as JSON...",
            true,
            Some(Accelerator::new(Some(cmd | Modifiers::SHIFT), Code::KeyE)),
        );
        export_menu.append(&export_csv_item)?;
        export_menu.append(&export_json_item)?;
        file_menu.append(&export_menu)?;

        file_menu.append(&PredefinedMenuItem::separator())?;
        file_menu.append(&PredefinedMenuItem::close_window(None))?;

        #[cfg(not(target_os = "macos"))]
        {
            file_menu.append(&PredefinedMenuItem::separator())?;
            file_menu.append(&PredefinedMenuItem::quit(None))?;
        }

        menu.append(&file_menu)?;

        // === Edit menu (standard system items) ===
        let edit_menu = Submenu::new("Edit", true);
        edit_menu.append(&PredefinedMenuItem::undo(None))?;
        edit_menu.append(&PredefinedMenuItem::redo(None))?;
        edit_menu.append(&PredefinedMenuItem::separator())?;
        edit_menu.append(&PredefinedMenuItem::cut(None))?;
        edit_menu.append(&PredefinedMenuItem::copy(None))?;
        edit_menu.append(&PredefinedMenuItem::paste(None))?;
        edit_menu.append(&PredefinedMenuItem::select_all(None))?;
        menu.append(&edit_menu)?;

        // === View menu ===
        let view_menu = Submenu::new("View", true);

        // Navigation section
        let dashboard_item = MenuItem::new(
            "Dashboard",
            true,
            Some(Accelerator::new(Some(cmd), Code::Digit1)),
        );
        let history_item = MenuItem::new(
            "History",
            true,
            Some(Accelerator::new(Some(cmd), Code::Digit2)),
        );
        let settings_item = MenuItem::new(
            "Settings",
            true,
            Some(Accelerator::new(Some(cmd), Code::Digit3)),
        );
        let service_item = MenuItem::new(
            "Service",
            true,
            Some(Accelerator::new(Some(cmd), Code::Digit4)),
        );

        view_menu.append(&dashboard_item)?;
        view_menu.append(&history_item)?;
        view_menu.append(&settings_item)?;
        view_menu.append(&service_item)?;
        view_menu.append(&PredefinedMenuItem::separator())?;

        // Appearance submenu
        let appearance_menu = Submenu::new("Appearance", true);
        let theme_system_item = CheckMenuItem::new("System", true, false, None);
        let theme_light_item = CheckMenuItem::new("Light", true, false, None);
        let theme_dark_item = CheckMenuItem::new("Dark", true, true, None); // Default to dark
        appearance_menu.append(&theme_system_item)?;
        appearance_menu.append(&theme_light_item)?;
        appearance_menu.append(&theme_dark_item)?;
        view_menu.append(&appearance_menu)?;

        // Hidden theme toggle for keyboard shortcut compatibility
        let theme_toggle_item = CheckMenuItem::new(
            "Dark Mode",
            false, // Hidden
            false,
            Some(Accelerator::new(None, Code::KeyT)),
        );

        view_menu.append(&PredefinedMenuItem::separator())?;

        // Display options submenu
        let display_menu = Submenu::new("Display", true);
        let show_co2_item = CheckMenuItem::new("CO2 Level", true, true, None);
        let show_temp_item = CheckMenuItem::new("Temperature", true, true, None);
        let show_humidity_item = CheckMenuItem::new("Humidity", true, true, None);
        let show_pressure_item = CheckMenuItem::new("Pressure", true, true, None);
        display_menu.append(&show_co2_item)?;
        display_menu.append(&show_temp_item)?;
        display_menu.append(&show_humidity_item)?;
        display_menu.append(&show_pressure_item)?;
        view_menu.append(&display_menu)?;

        view_menu.append(&PredefinedMenuItem::separator())?;

        // Auto-refresh and interval
        let auto_refresh_item = CheckMenuItem::new(
            "Auto Refresh",
            true,
            true,
            Some(Accelerator::new(None, Code::KeyA)),
        );
        view_menu.append(&auto_refresh_item)?;

        let interval_menu = Submenu::new("Refresh Interval", true);
        let interval_30s_item = CheckMenuItem::new("30 seconds", true, false, None);
        let interval_1m_item = CheckMenuItem::new("1 minute", true, true, None); // Default
        let interval_5m_item = CheckMenuItem::new("5 minutes", true, false, None);
        let interval_10m_item = CheckMenuItem::new("10 minutes", true, false, None);
        interval_menu.append(&interval_30s_item)?;
        interval_menu.append(&interval_1m_item)?;
        interval_menu.append(&interval_5m_item)?;
        interval_menu.append(&interval_10m_item)?;
        view_menu.append(&interval_menu)?;

        view_menu.append(&PredefinedMenuItem::separator())?;

        // Notifications
        let notifications_item = CheckMenuItem::new("Enable Notifications", true, true, None);
        view_menu.append(&notifications_item)?;

        // Alerts submenu
        let alerts_menu = Submenu::new("Alerts", true);
        let do_not_disturb_item = CheckMenuItem::new(
            "Do Not Disturb",
            true,
            false,
            Some(Accelerator::new(Some(cmd | Modifiers::SHIFT), Code::KeyD)),
        );
        let sticky_alerts_item = CheckMenuItem::new("Sticky Alerts", true, false, None);
        alerts_menu.append(&do_not_disturb_item)?;
        alerts_menu.append(&sticky_alerts_item)?;
        view_menu.append(&alerts_menu)?;

        view_menu.append(&PredefinedMenuItem::separator())?;

        // Data logging
        let data_logging_item = CheckMenuItem::new(
            "Log Data to CSV",
            true,
            false,
            Some(Accelerator::new(Some(cmd | Modifiers::SHIFT), Code::KeyL)),
        );
        view_menu.append(&data_logging_item)?;

        view_menu.append(&PredefinedMenuItem::separator())?;
        view_menu.append(&PredefinedMenuItem::fullscreen(None))?;

        menu.append(&view_menu)?;

        // === Device menu ===
        let device_menu = Submenu::new("Device", true);

        // Scan is duplicated here for discoverability
        let device_scan_item = MenuItem::new(
            "Scan for Devices",
            true,
            None, // No accelerator, F5 is on File menu
        );
        device_menu.append(&device_scan_item)?;
        device_menu.append(&PredefinedMenuItem::separator())?;

        // Placeholder for dynamic device list - will be populated at runtime
        let no_devices_item = MenuItem::new("No devices", false, None);
        device_menu.append(&no_devices_item)?;

        device_menu.append(&PredefinedMenuItem::separator())?;

        let manage_aliases_item = MenuItem::new("Manage Aliases...", true, None);
        device_menu.append(&manage_aliases_item)?;

        menu.append(&device_menu)?;

        // === Window menu ===
        let window_menu = Submenu::new("Window", true);
        window_menu.append(&PredefinedMenuItem::minimize(None))?;
        window_menu.append(&PredefinedMenuItem::maximize(None))?;
        window_menu.append(&PredefinedMenuItem::separator())?;
        window_menu.append(&PredefinedMenuItem::fullscreen(None))?;

        #[cfg(target_os = "macos")]
        {
            window_menu.append(&PredefinedMenuItem::separator())?;
            window_menu.append(&PredefinedMenuItem::bring_all_to_front(None))?;
        }

        menu.append(&window_menu)?;

        // === Help menu ===
        let help_menu = Submenu::new("Help", true);

        let documentation_item = MenuItem::new("Aranet Documentation", true, None);
        let report_issue_item = MenuItem::new("Report an Issue...", true, None);
        let check_updates_item = MenuItem::new("Check for Updates...", true, None);

        help_menu.append(&documentation_item)?;
        help_menu.append(&report_issue_item)?;
        help_menu.append(&PredefinedMenuItem::separator())?;
        help_menu.append(&check_updates_item)?;

        // About item for Windows/Linux (macOS has it in App menu)
        #[cfg(not(target_os = "macos"))]
        let about_item = {
            help_menu.append(&PredefinedMenuItem::separator())?;
            let item = MenuItem::new("About Aranet", true, None);
            help_menu.append(&item)?;
            item
        };

        menu.append(&help_menu)?;

        info!("Native menu bar created with enhanced menus");

        Ok(Self {
            // File menu
            scan_item,
            refresh_item,
            export_csv_item,
            export_json_item,

            // View menu - appearance
            theme_system_item,
            theme_light_item,
            theme_dark_item,
            theme_toggle_item,

            // View menu - auto refresh
            auto_refresh_item,
            interval_30s_item,
            interval_1m_item,
            interval_5m_item,
            interval_10m_item,

            // View menu - notifications
            notifications_item,

            // View menu - alerts
            do_not_disturb_item,
            sticky_alerts_item,

            // View menu - data logging
            data_logging_item,

            // View menu - display
            show_co2_item,
            show_temp_item,
            show_humidity_item,
            show_pressure_item,

            // View menu - tabs
            dashboard_item,
            history_item,
            settings_item,
            service_item,

            // Device menu
            device_menu,
            manage_aliases_item,

            // Help menu
            documentation_item,
            report_issue_item,
            check_updates_item,
            #[cfg(not(target_os = "macos"))]
            about_item,

            menu,
        })
    }

    /// Initialize the menu for macOS (call from main thread before event loop).
    #[cfg(target_os = "macos")]
    pub fn init_for_macos(&self) {
        self.menu.init_for_nsapp();
        debug!("Menu initialized for macOS NSApp");
    }

    /// Initialize the menu (no-op on non-macOS platforms - they need window handle).
    #[cfg(not(target_os = "macos"))]
    pub fn init_for_macos(&self) {
        // On Windows/Linux, we need to init after window creation
        // This is handled separately
    }

    /// Process pending menu events and return any commands.
    pub fn process_events(&self) -> Vec<MenuCommand> {
        let mut commands = Vec::new();

        while let Ok(event) = MenuEvent::receiver().try_recv() {
            // === File menu ===
            if event.id == self.scan_item.id() {
                debug!("Menu: Scan clicked");
                commands.push(MenuCommand::Scan);
            } else if event.id == self.refresh_item.id() {
                debug!("Menu: Refresh All clicked");
                commands.push(MenuCommand::RefreshAll);
            } else if event.id == self.export_csv_item.id() {
                debug!("Menu: Export CSV clicked");
                commands.push(MenuCommand::ExportCsv);
            } else if event.id == self.export_json_item.id() {
                debug!("Menu: Export JSON clicked");
                commands.push(MenuCommand::ExportJson);
            }
            // === View menu - appearance ===
            else if event.id == *self.theme_system_item.id() {
                debug!("Menu: Theme System clicked");
                commands.push(MenuCommand::ThemeSystem);
            } else if event.id == *self.theme_light_item.id() {
                debug!("Menu: Theme Light clicked");
                commands.push(MenuCommand::ThemeLight);
            } else if event.id == *self.theme_dark_item.id() {
                debug!("Menu: Theme Dark clicked");
                commands.push(MenuCommand::ThemeDark);
            } else if event.id == *self.theme_toggle_item.id() {
                debug!("Menu: Toggle Theme clicked");
                commands.push(MenuCommand::ToggleTheme);
            }
            // === View menu - auto refresh ===
            else if event.id == *self.auto_refresh_item.id() {
                debug!("Menu: Toggle Auto Refresh clicked");
                commands.push(MenuCommand::ToggleAutoRefresh);
            } else if event.id == *self.interval_30s_item.id() {
                debug!("Menu: Interval 30s clicked");
                commands.push(MenuCommand::SetRefreshInterval(30));
            } else if event.id == *self.interval_1m_item.id() {
                debug!("Menu: Interval 1m clicked");
                commands.push(MenuCommand::SetRefreshInterval(60));
            } else if event.id == *self.interval_5m_item.id() {
                debug!("Menu: Interval 5m clicked");
                commands.push(MenuCommand::SetRefreshInterval(300));
            } else if event.id == *self.interval_10m_item.id() {
                debug!("Menu: Interval 10m clicked");
                commands.push(MenuCommand::SetRefreshInterval(600));
            }
            // === View menu - notifications ===
            else if event.id == *self.notifications_item.id() {
                debug!("Menu: Toggle Notifications clicked");
                commands.push(MenuCommand::ToggleNotifications);
            }
            // === View menu - alerts ===
            else if event.id == *self.do_not_disturb_item.id() {
                debug!("Menu: Toggle Do Not Disturb clicked");
                commands.push(MenuCommand::ToggleDoNotDisturb);
            } else if event.id == *self.sticky_alerts_item.id() {
                debug!("Menu: Toggle Sticky Alerts clicked");
                commands.push(MenuCommand::ToggleStickyAlerts);
            }
            // === View menu - data logging ===
            else if event.id == *self.data_logging_item.id() {
                debug!("Menu: Toggle Data Logging clicked");
                commands.push(MenuCommand::ToggleDataLogging);
            }
            // === View menu - display toggles ===
            else if event.id == *self.show_co2_item.id() {
                debug!("Menu: Toggle CO2 Display clicked");
                commands.push(MenuCommand::ToggleCo2Display);
            } else if event.id == *self.show_temp_item.id() {
                debug!("Menu: Toggle Temperature Display clicked");
                commands.push(MenuCommand::ToggleTemperatureDisplay);
            } else if event.id == *self.show_humidity_item.id() {
                debug!("Menu: Toggle Humidity Display clicked");
                commands.push(MenuCommand::ToggleHumidityDisplay);
            } else if event.id == *self.show_pressure_item.id() {
                debug!("Menu: Toggle Pressure Display clicked");
                commands.push(MenuCommand::TogglePressureDisplay);
            }
            // === View menu - tabs ===
            else if event.id == self.dashboard_item.id() {
                debug!("Menu: Dashboard clicked");
                commands.push(MenuCommand::ShowDashboard);
            } else if event.id == self.history_item.id() {
                debug!("Menu: History clicked");
                commands.push(MenuCommand::ShowHistory);
            } else if event.id == self.settings_item.id() {
                debug!("Menu: Settings clicked");
                commands.push(MenuCommand::ShowSettings);
            } else if event.id == self.service_item.id() {
                debug!("Menu: Service clicked");
                commands.push(MenuCommand::ShowService);
            }
            // === Device menu ===
            else if event.id == self.manage_aliases_item.id() {
                debug!("Menu: Manage Aliases clicked");
                commands.push(MenuCommand::ManageAliases);
            }
            // === Help menu ===
            else if event.id == self.documentation_item.id() {
                debug!("Menu: Documentation clicked");
                commands.push(MenuCommand::OpenDocumentation);
            } else if event.id == self.report_issue_item.id() {
                debug!("Menu: Report Issue clicked");
                commands.push(MenuCommand::ReportIssue);
            } else if event.id == self.check_updates_item.id() {
                debug!("Menu: Check Updates clicked");
                commands.push(MenuCommand::CheckForUpdates);
            }
            #[cfg(not(target_os = "macos"))]
            if event.id == self.about_item.id() {
                debug!("Menu: About clicked");
                commands.push(MenuCommand::ShowAbout);
            }
        }

        commands
    }

    // =========================================================================
    // State synchronization methods
    // =========================================================================

    /// Update the theme selection in the Appearance submenu.
    pub fn set_theme(&self, theme: &str) {
        match theme {
            "system" => {
                self.theme_system_item.set_checked(true);
                self.theme_light_item.set_checked(false);
                self.theme_dark_item.set_checked(false);
            }
            "light" => {
                self.theme_system_item.set_checked(false);
                self.theme_light_item.set_checked(true);
                self.theme_dark_item.set_checked(false);
            }
            _ => {
                self.theme_system_item.set_checked(false);
                self.theme_light_item.set_checked(false);
                self.theme_dark_item.set_checked(true);
            }
        }
    }

    /// Update the theme checkbox state (legacy, for backwards compatibility).
    pub fn set_dark_mode(&self, dark_mode: bool) {
        if dark_mode {
            self.set_theme("dark");
        } else {
            self.set_theme("light");
        }
    }

    /// Update the auto-refresh checkbox state.
    pub fn set_auto_refresh(&self, enabled: bool) {
        self.auto_refresh_item.set_checked(enabled);
    }

    /// Update the refresh interval selection.
    pub fn set_refresh_interval(&self, seconds: u16) {
        self.interval_30s_item.set_checked(seconds == 30);
        self.interval_1m_item.set_checked(seconds == 60);
        self.interval_5m_item.set_checked(seconds == 300);
        self.interval_10m_item.set_checked(seconds == 600);
    }

    /// Update the notifications enabled state.
    pub fn set_notifications_enabled(&self, enabled: bool) {
        self.notifications_item.set_checked(enabled);
    }

    /// Update the Do Not Disturb state.
    pub fn set_do_not_disturb(&self, enabled: bool) {
        self.do_not_disturb_item.set_checked(enabled);
    }

    /// Update the sticky alerts state.
    pub fn set_sticky_alerts(&self, enabled: bool) {
        self.sticky_alerts_item.set_checked(enabled);
    }

    /// Update the data logging state.
    pub fn set_data_logging(&self, enabled: bool) {
        self.data_logging_item.set_checked(enabled);
    }

    /// Update display toggle states.
    pub fn set_display_options(&self, co2: bool, temp: bool, humidity: bool, pressure: bool) {
        self.show_co2_item.set_checked(co2);
        self.show_temp_item.set_checked(temp);
        self.show_humidity_item.set_checked(humidity);
        self.show_pressure_item.set_checked(pressure);
    }

    /// Enable or disable the scan menu item.
    pub fn set_scan_enabled(&self, enabled: bool) {
        self.scan_item.set_enabled(enabled);
    }

    /// Enable or disable the export menu items (based on whether history is available).
    pub fn set_export_enabled(&self, enabled: bool) {
        self.export_csv_item.set_enabled(enabled);
        self.export_json_item.set_enabled(enabled);
    }

    /// Get the device menu submenu for dynamic updates.
    pub fn device_menu(&self) -> &Submenu {
        &self.device_menu
    }
}