aprender-serve 0.71.1

Pure Rust ML inference engine built from scratch - model serving for GGUF and safetensors
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
//! The engine's loop, judged on a scripted forward: prefix reuse, the witness,
//! stop tokens, the context cap and the scoring walk.

use super::*;

/// A forward whose logits make `next` the argmax after every position, and
/// which records each `forward` call's `(len, start)`.
struct Scripted {
    next: u32,
    context: usize,
    calls: Vec<(usize, usize)>,
    reserves: usize,
    drop_on_reserve: bool,
    /// Checkpoint before the last position holding this token (#4214).
    marker: Option<u32>,
    /// Positions the state holds, as the forward itself tracks them.
    held: usize,
    /// Positions the saved checkpoint holds.
    saved: Option<usize>,
    restores: usize,
    /// The forward loses its checkpoint (a reallocation, a fallback).
    lose_checkpoint: bool,
    /// What `set_layer_timing` answers: whether this forward times its layers.
    times_layers: bool,
    /// Every `set_layer_timing` argument, in order.
    timing_log: Vec<bool>,
    /// What `take_layer_timings` hands back, once.
    timed: Option<Vec<LayerTiming>>,
    /// The forward call (0-based) from which every forward errors.
    fail_from: Option<usize>,
    /// What each `validate` call judged the backend on (#4342).
    probes: Vec<Vec<u32>>,
}

impl Scripted {
    fn new(next: u32, context: usize) -> Self {
        Self {
            next,
            context,
            calls: Vec::new(),
            reserves: 0,
            drop_on_reserve: false,
            marker: None,
            held: 0,
            saved: None,
            restores: 0,
            lose_checkpoint: false,
            times_layers: false,
            timing_log: Vec::new(),
            timed: None,
            fail_from: None,
            probes: Vec::new(),
        }
    }

    fn checkpointing(next: u32, context: usize, marker: u32) -> Self {
        Self {
            marker: Some(marker),
            ..Self::new(next, context)
        }
    }
}

impl ArchForward for Scripted {
    fn arch(&self) -> &'static str {
        "scripted"
    }
    fn on_gpu(&self) -> bool {
        false
    }
    fn context_length(&self) -> usize {
        self.context
    }
    fn batched_prefills(&self) -> usize {
        0
    }
    fn notices(&self) -> &[String] {
        &[]
    }
    fn reserve(&mut self, _positions: usize) -> Result<bool> {
        self.reserves += 1;
        Ok(self.drop_on_reserve)
    }
    fn validate(&mut self, probe: &[u32]) -> Result<()> {
        self.probes.push(probe.to_vec());
        Ok(())
    }
    fn checkpoint_at(&self, prompt: &[u32]) -> Option<usize> {
        let marker = self.marker?;
        prompt.iter().rposition(|&t| t == marker)
    }
    fn save_checkpoint(&mut self) -> Result<()> {
        assert!(self.marker.is_some(), "saved on a forward that keeps none");
        self.saved = Some(self.held);
        Ok(())
    }
    fn restore_checkpoint(&mut self) -> Result<bool> {
        if self.lose_checkpoint {
            self.saved = None;
        }
        let Some(saved) = self.saved else {
            return Ok(false);
        };
        self.held = saved;
        self.restores += 1;
        Ok(true)
    }
    fn forward(&mut self, tokens: &[u32], start: usize) -> Result<Vec<f32>> {
        // The session may only claim positions the state holds.
        assert!(
            start == 0 || start == self.held,
            "forward from {start}, but the state holds {}",
            self.held
        );
        if self.fail_from.is_some_and(|n| self.calls.len() >= n) {
            return Err(RealizarError::InvalidShape {
                reason: "scripted forward failure".to_string(),
            });
        }
        self.calls.push((tokens.len(), start));
        self.held = tokens.len();
        let mut logits = vec![0.0; 8];
        logits[self.next as usize] = 1.0;
        Ok(logits)
    }
    fn set_layer_timing(&mut self, on: bool) -> bool {
        self.timing_log.push(on);
        self.times_layers
    }
    fn take_layer_timings(&mut self) -> Option<Vec<LayerTiming>> {
        self.timed.take()
    }
}

fn greedy(max_tokens: usize) -> QuantizedGenerateConfig {
    QuantizedGenerateConfig {
        max_tokens,
        temperature: 0.0,
        top_k: 1,
        ..Default::default()
    }
}

#[test]
fn generate_prefills_once_then_decodes_one_token_per_step() {
    let mut s = Session::new(Scripted::new(3, 100));
    let prompt = [7101, 7102, 7103];
    let turn = s
        .generate(&prompt, &greedy(3), &mut |_| true)
        .expect("turn");
    assert_eq!(turn.tokens, vec![7101, 7102, 7103, 3, 3, 3]);
    assert_eq!(turn.reused, 0);
    assert!(!turn.context_capped);
    // The prompt whole from 0, then each chosen token (not the last) from where it left.
    assert_eq!(s.engine().calls, vec![(3, 0), (4, 3), (5, 4)]);
    assert_eq!(s.processed_len(), 5);
}

/// A tracer that records what a `step` or `layer` serve trace records.
fn step_tracer() -> crate::inference_trace::InferenceTracer {
    use crate::inference_trace::{InferenceTracer, TraceConfig, TraceStep};
    let mut config = TraceConfig::enabled();
    config.steps = [TraceStep::TransformerBlock, TraceStep::Decode]
        .into_iter()
        .collect();
    InferenceTracer::new(config)
}

/// What a traced turn filed, as `(step, iteration)` in order.
fn filed(
    tracer: &crate::inference_trace::InferenceTracer,
) -> Vec<(crate::inference_trace::TraceStep, usize)> {
    tracer
        .events()
        .iter()
        .map(|e| (e.step, e.iteration))
        .collect()
}

const TIMED: LayerTiming = LayerTiming {
    total_us: 7,
    calls: 2,
    kind: "scripted",
};

/// APR-OBS-001 OBS-09: a traced turn files one `TransformerBlock` per forward,
/// iteration 0 being the prompt's, and one `Decode` per `on_token` at the
/// iteration of the token it emits. `serve_trace` splits prefill from decode
/// on exactly this shape, so a shifted iteration would report a decode as
/// prefill and still fit under the wall clock.
#[test]
fn a_traced_turn_files_one_event_per_forward_and_per_token() {
    use crate::inference_trace::TraceStep::{Decode, TransformerBlock};
    let mut s = Session::new(Scripted {
        times_layers: true,
        timed: Some(vec![TIMED]),
        ..Scripted::new(3, 100)
    });
    let mut tracer = step_tracer();
    let turn = s
        .generate_traced(
            &[7901, 7902, 7903],
            &greedy(3),
            &mut |_| true,
            Some(TurnTrace {
                tracer: &mut tracer,
                layers: true,
            }),
        )
        .expect("turn");
    assert_eq!(turn.tokens, vec![7901, 7902, 7903, 3, 3, 3]);
    assert_eq!(
        filed(&tracer),
        [
            (TransformerBlock, 0),
            (Decode, 0),
            (TransformerBlock, 1),
            (Decode, 1),
            (TransformerBlock, 2),
            (Decode, 2),
        ]
    );
    assert_eq!(
        s.engine().timing_log,
        [true, false],
        "on for the turn, then off"
    );
    assert_eq!(s.take_layer_timings(), Some(vec![TIMED]));
    assert_eq!(s.take_layer_timings(), None, "taking it clears it");
}

/// Layer timing is asked for only by a layer trace, and turned off after the
/// turn, Ok or Err, on every forward that said it would time its layers. A
/// forward left timing would run every later decode eager, syncing after each
/// layer, with nothing in any reply to show it.
#[test]
fn layer_timing_is_on_for_the_turn_and_off_after_it_ok_or_err() {
    // (layer trace, forward times layers, first failing forward call,
    // the set_layer_timing calls the forward sees)
    let cases: [(bool, bool, Option<usize>, &[bool]); 6] = [
        (true, true, None, &[true, false]),
        (true, true, Some(0), &[true, false]), // the prompt's forward errors
        (true, true, Some(2), &[true, false]), // a decode forward errors
        (true, false, None, &[true]),          // a CPU forward: nothing to undo
        (false, true, None, &[]),              // a step trace times no layer
        (false, true, Some(0), &[]),
    ];
    for (layers, times, fail_from, want) in cases {
        let case = format!("layers={layers} times={times} fail_from={fail_from:?}");
        let mut s = Session::new(Scripted {
            times_layers: times,
            fail_from,
            ..Scripted::new(3, 100)
        });
        let mut tracer = step_tracer();
        let r = s.generate_traced(
            &[7911, 7912],
            &greedy(3),
            &mut |_| true,
            Some(TurnTrace {
                tracer: &mut tracer,
                layers,
            }),
        );
        assert_eq!(r.is_err(), fail_from.is_some(), "{case}");
        assert_eq!(s.engine().timing_log, want, "{case}");
    }
    // An untraced turn asks nothing of the forward's timing.
    let mut s = Session::new(Scripted {
        times_layers: true,
        ..Scripted::new(3, 100)
    });
    s.generate(&[7913], &greedy(2), &mut |_| true)
        .expect("turn");
    assert!(s.engine().timing_log.is_empty());
}

#[test]
fn an_extending_prompt_reuses_the_state_and_a_diverging_one_resets() {
    let mut s = Session::new(Scripted::new(3, 100));
    let t1 = s
        .generate(&[7201, 7202], &greedy(1), &mut |_| true)
        .expect("t1");
    let mut p2 = t1.tokens.clone();
    p2.extend([7203, 7204]);
    let t2 = s.generate(&p2, &greedy(1), &mut |_| true).expect("t2");
    // t1 held [7201, 7202] (its one chosen token was never forwarded).
    assert_eq!(t2.reused, 2);
    let t3 = s
        .generate(&[7299, 7202], &greedy(1), &mut |_| true)
        .expect("t3");
    assert_eq!(t3.reused, 0);
    assert_eq!(s.engine().calls.last(), Some(&(2, 0)));
}

#[test]
fn a_dropped_state_is_never_reused() {
    let mut f = Scripted::new(3, 100);
    f.drop_on_reserve = true;
    let mut s = Session::new(f);
    let t1 = s
        .generate(&[7301, 7302], &greedy(1), &mut |_| true)
        .expect("t1");
    let mut p2 = t1.tokens;
    p2.push(7303);
    let t2 = s.generate(&p2, &greedy(1), &mut |_| true).expect("t2");
    assert_eq!(t2.reused, 0, "reserve said the state was dropped");
}

#[test]
fn a_stop_token_ends_the_turn_and_the_context_caps_it_by_name() {
    let mut s = Session::new(Scripted::new(3, 100));
    let mut cfg = greedy(10);
    cfg.stop_tokens = vec![3];
    let turn = s.generate(&[7401], &cfg, &mut |_| true).expect("turn");
    assert_eq!(turn.tokens, vec![7401, 3]);
    assert!(!turn.context_capped);

    let mut s = Session::new(Scripted::new(3, 4));
    let turn = s
        .generate(&[7402, 7403], &greedy(10), &mut |_| true)
        .expect("turn");
    assert_eq!(turn.tokens.len(), 4, "two positions of room");
    assert!(turn.context_capped);
    assert!(s
        .generate(&[1, 2, 3, 4], &greedy(1), &mut |_| true)
        .is_err());
}

#[test]
fn generate_leaves_exactly_one_entry() {
    let prompt = [7501, 7502, 7503, 7504];
    let mut s = Session::new(Scripted::new(3, 100));
    s.generate(&prompt, &greedy(2), &mut |_| true)
        .expect("turn");
    let entries = entries_for(&prompt);
    assert_eq!(entries.len(), 1);
    assert_eq!(entries[0].arch, "scripted");
    assert_eq!(entries[0].kind, EntryKind::Generate);
}

#[test]
fn score_leaves_a_score_entry_and_visits_every_position() {
    let seq = [7601, 7602, 7603];
    let mut s = Session::new(Scripted::new(3, 100));
    let mut seen = Vec::new();
    s.score(&seq, &mut |pos, logits| {
        seen.push((pos, logits.len()));
        true
    })
    .expect("score");
    assert_eq!(seen, vec![(0, 8), (1, 8), (2, 8)]);
    // Teacher-forced: each position extends the last.
    assert_eq!(s.engine().calls, vec![(1, 0), (2, 1), (3, 2)]);
    let entries = entries_for(&seq);
    assert_eq!(entries.len(), 1);
    assert_eq!(entries[0].kind, EntryKind::Score);
    assert!(s.score(&[1; 101], &mut |_, _| true).is_err());
}

#[test]
fn digest_separates_order_and_length() {
    assert_ne!(prompt_digest(&[1, 2]), prompt_digest(&[2, 1]));
    assert_ne!(prompt_digest(&[1]), prompt_digest(&[1, 0]));
    assert_eq!(prompt_digest(&[5, 6]), prompt_digest(&[5, 6]));
}

/// Scripted with a device argmax: counts `forward_greedy` calls and answers
/// `greedy_answer` without logits.
struct DeviceGreedy {
    inner: Scripted,
    greedy_answer: u32,
    greedy_calls: usize,
}

impl ArchForward for DeviceGreedy {
    fn arch(&self) -> &'static str {
        "scripted-greedy"
    }
    fn on_gpu(&self) -> bool {
        true
    }
    fn context_length(&self) -> usize {
        self.inner.context
    }
    fn batched_prefills(&self) -> usize {
        0
    }
    fn notices(&self) -> &[String] {
        &[]
    }
    fn reserve(&mut self, positions: usize) -> Result<bool> {
        self.inner.reserve(positions)
    }
    fn forward(&mut self, tokens: &[u32], start: usize) -> Result<Vec<f32>> {
        self.inner.forward(tokens, start)
    }
    fn checkpoint_at(&self, prompt: &[u32]) -> Option<usize> {
        self.inner.checkpoint_at(prompt)
    }
    fn save_checkpoint(&mut self) -> Result<()> {
        self.inner.save_checkpoint()
    }
    fn restore_checkpoint(&mut self) -> Result<bool> {
        self.inner.restore_checkpoint()
    }
    fn forward_greedy(&mut self, tokens: &[u32], start: usize) -> Result<Option<u32>> {
        self.inner.calls.push((tokens.len(), start));
        self.inner.held = tokens.len();
        self.greedy_calls += 1;
        Ok(Some(self.greedy_answer))
    }
}

#[test]
fn plain_greedy_takes_the_device_argmax_and_a_penalty_or_sampling_does_not() {
    let device = |answer| DeviceGreedy {
        inner: Scripted::new(3, 100),
        greedy_answer: answer,
        greedy_calls: 0,
    };
    let mut s = Session::new(device(5));
    let turn = s
        .generate(&[7701, 7702], &greedy(2), &mut |_| true)
        .expect("turn");
    assert_eq!(turn.tokens, vec![7701, 7702, 5, 5]);
    assert_eq!(s.engine().greedy_calls, 2);
    assert_eq!(
        s.engine().inner.calls,
        vec![(2, 0), (3, 2)],
        "the state still advances by extension"
    );

    let mut penalized = greedy(2);
    penalized.repeat_penalty = 1.3;
    let mut s = Session::new(device(5));
    s.generate(&[7703], &penalized, &mut |_| true)
        .expect("turn");
    assert_eq!(
        s.engine().greedy_calls,
        0,
        "a repeat penalty needs the logits"
    );
}
// #4445: `apr bench` repeats one prompt and must time a whole prefill each time.
// An extending prompt would resume the held state; after forget_prefix it may not.
#[test]
fn forget_prefix_makes_an_extending_prompt_prefill_whole_again() {
    let mut s = Session::new(Scripted::new(3, 100));
    let t1 = s
        .generate(&[7401, 7402], &greedy(1), &mut |_| true)
        .expect("t1");
    let mut p2 = t1.tokens.clone();
    p2.extend([7403, 7404]);
    s.forget_prefix();
    assert_eq!(s.processed_len(), 0);
    let t2 = s.generate(&p2, &greedy(1), &mut |_| true).expect("t2");
    assert_eq!(t2.reused, 0, "resumed a prefix after forget_prefix");
    assert_eq!(s.engine().calls.last(), Some(&(p2.len(), 0)));
}

// #4214 / #4274: a prompt that repeats, or re-renders, an earlier turn's history
// resumes from the checkpoint the earlier turn left, not from position 0.

const MARK: u32 = 7;

#[test]
fn an_identical_prompt_again_restores_the_checkpoint_before_its_last_marker() {
    let mut s = Session::new(Scripted::checkpointing(3, 100, MARK));
    let prompt = [7801, 7802, MARK, 7803];
    let t1 = s.generate(&prompt, &greedy(1), &mut |_| true).expect("t1");
    assert_eq!(t1.reused, 0);
    // Prefilled in two spans: up to the checkpoint, then the rest.
    assert_eq!(s.engine().calls, vec![(2, 0), (4, 2)]);
    let t2 = s.generate(&prompt, &greedy(1), &mut |_| true).expect("t2");
    assert_eq!(
        t2.reused, 2,
        "the repeat prefilled only from the checkpoint"
    );
    assert_eq!(t2.tokens, t1.tokens);
    assert_eq!(s.engine().calls.last(), Some(&(4, 2)));
    assert_eq!(s.engine().restores, 1);
}

#[test]
fn a_re_rendered_history_resumes_from_the_last_turns_checkpoint() {
    let mut s = Session::new(Scripted::checkpointing(3, 100, MARK));
    let t1 = s
        .generate(&[7811, MARK, 7812], &greedy(2), &mut |_| true)
        .expect("t1");
    assert_eq!(t1.tokens, vec![7811, MARK, 7812, 3, 3]);
    // Turn 2 re-renders turn 1's reply (7899, not the 3 it generated), so it
    // does not extend what the state holds.
    let p2 = [7811, MARK, 7812, 7899, MARK, 7813];
    let before = s.engine().calls.len();
    let t2 = s.generate(&p2, &greedy(2), &mut |_| true).expect("t2");
    assert_eq!(t2.reused, 1, "resumed at turn 1's checkpoint, not at 0");
    // From the checkpoint to turn 2's own (its last marker), then the rest.
    assert_eq!(s.engine().calls[before..before + 2], [(4, 1), (6, 4)]);
    // Turn 3 re-renders turn 2's reply too, and resumes at turn 2's checkpoint.
    let p3 = [7811, MARK, 7812, 7899, MARK, 7813, 7898, MARK, 7814];
    let t3 = s.generate(&p3, &greedy(1), &mut |_| true).expect("t3");
    assert_eq!(t3.reused, 4);
}

#[test]
fn a_prompt_that_diverges_before_the_checkpoint_starts_over() {
    let mut s = Session::new(Scripted::checkpointing(3, 100, MARK));
    s.generate(&[7821, 7822, MARK, 7823], &greedy(1), &mut |_| true)
        .expect("t1");
    let t2 = s
        .generate(&[7829, 7822, MARK, 7823], &greedy(1), &mut |_| true)
        .expect("t2");
    assert_eq!(t2.reused, 0);
    assert_eq!(s.engine().restores, 0);
}

#[test]
fn a_checkpoint_does_not_survive_a_dropped_state() {
    let mut f = Scripted::checkpointing(3, 100, MARK);
    f.drop_on_reserve = true;
    let mut s = Session::new(f);
    let prompt = [7831, 7832, MARK, 7833];
    s.generate(&prompt, &greedy(1), &mut |_| true).expect("t1");
    let t2 = s.generate(&prompt, &greedy(1), &mut |_| true).expect("t2");
    assert_eq!(t2.reused, 0, "reserve said the state was dropped");
    assert_eq!(s.engine().restores, 0);
}

#[test]
fn a_checkpoint_the_forward_lost_is_not_reused() {
    let mut f = Scripted::checkpointing(3, 100, MARK);
    f.lose_checkpoint = true;
    let mut s = Session::new(f);
    let prompt = [7841, 7842, MARK, 7843];
    s.generate(&prompt, &greedy(1), &mut |_| true).expect("t1");
    let t2 = s.generate(&prompt, &greedy(1), &mut |_| true).expect("t2");
    assert_eq!(t2.reused, 0);
    assert_eq!(
        s.engine().calls.last(),
        Some(&(4, 2)),
        "re-checkpointed from 0"
    );
    assert_eq!(s.engine().calls[s.engine().calls.len() - 2], (2, 0));
}

#[test]
fn scoring_rewrites_the_state_so_the_checkpoint_is_dropped() {
    let mut s = Session::new(Scripted::checkpointing(3, 100, MARK));
    let prompt = [7851, 7852, MARK, 7853];
    s.generate(&prompt, &greedy(1), &mut |_| true).expect("t1");
    s.score(&[7859, 7858], &mut |_, _| true).expect("score");
    let t2 = s.generate(&prompt, &greedy(1), &mut |_| true).expect("t2");
    assert_eq!(
        t2.reused, 0,
        "the positions under the checkpoint were rewritten"
    );
    assert_eq!(s.engine().restores, 0);
}

#[test]
fn a_device_argmax_from_below_the_checkpoint_drops_it() {
    // The device-argmax path rewrites positions too: a prompt it prefills from
    // under the checkpoint leaves a copy whose KV rows no longer match.
    let mut s = Session::new(DeviceGreedy {
        inner: Scripted::checkpointing(3, 100, MARK),
        greedy_answer: 5,
        greedy_calls: 0,
    });
    let prompt = [7861, 7862, MARK, 7863];
    s.generate(&prompt, &greedy(1), &mut |_| true).expect("t1");
    s.generate(&[7869], &greedy(1), &mut |_| true).expect("t2");
    assert!(s.engine().greedy_calls > 0, "t2 took the device argmax");
    let t3 = s.generate(&prompt, &greedy(1), &mut |_| true).expect("t3");
    assert_eq!(
        t3.reused, 0,
        "position 0 was rewritten under the checkpoint"
    );
    assert_eq!(s.engine().inner.restores, 0);
}

// #4445 x #4214: `apr bench` on a checkpointing arch (qwen35) repeats the same
// prompt. forget_prefix must drop the checkpoint too, or the repeat restores it
// and the bench times a partial prefill.
#[test]
fn forget_prefix_makes_the_same_prompt_prefill_whole_again() {
    let mut s = Session::new(Scripted::checkpointing(3, 100, MARK));
    let prompt = [7871, 7872, MARK, 7873];
    s.generate(&prompt, &greedy(1), &mut |_| true).expect("t1");
    for turn in 2..=3 {
        s.forget_prefix();
        let t = s
            .generate(&prompt, &greedy(1), &mut |_| true)
            .expect("turn");
        assert_eq!(
            t.reused, 0,
            "turn {turn}: restored a checkpoint after forget_prefix"
        );
    }
    assert_eq!(s.engine().restores, 0);
}

/// A forward that implements only the required methods, so every checkpoint
/// hook is the trait default.
struct Bare;

impl ArchForward for Bare {
    fn arch(&self) -> &'static str {
        "bare"
    }
    fn on_gpu(&self) -> bool {
        false
    }
    fn context_length(&self) -> usize {
        100
    }
    fn batched_prefills(&self) -> usize {
        0
    }
    fn notices(&self) -> &[String] {
        &[]
    }
    fn reserve(&mut self, _positions: usize) -> Result<bool> {
        Ok(false)
    }
    fn forward(&mut self, tokens: &[u32], _start: usize) -> Result<Vec<f32>> {
        let mut logits = vec![0.0; 8];
        logits[tokens.len() % 8] = 1.0;
        Ok(logits)
    }
}

#[test]
fn the_default_forward_keeps_no_checkpoint() {
    let mut b = Bare;
    assert_eq!(b.checkpoint_at(&[1, 2, 3]), None);
    assert_eq!(b.checkpoint_at(&[]), None);
    assert!(b.save_checkpoint().is_ok());
    assert!(
        !b.restore_checkpoint().expect("default restore"),
        "the default has nothing to return to"
    );
}

/// The default times nothing and says so: a layer trace on such a forward
/// turns no timing on and leaves no per-layer rows (APR-OBS-001 OBS-09).
#[test]
fn the_default_forward_times_no_layer() {
    let mut b = Bare;
    assert!(!b.set_layer_timing(true), "the default times no layer");
    assert!(!b.set_layer_timing(false));
    assert!(b.take_layer_timings().is_none());

    let mut s = Session::new(Bare);
    let mut tracer = step_tracer();
    s.generate_traced(
        &[1, 2],
        &greedy(2),
        &mut |_| true,
        Some(TurnTrace {
            tracer: &mut tracer,
            layers: true,
        }),
    )
    .expect("a layer trace on a forward that cannot time layers still runs the turn");
    assert!(s.take_layer_timings().is_none());
}

/// A forward that names a fixed checkpoint position whatever the prompt.
struct FixedCheckpoint {
    inner: Scripted,
    at: usize,
}

impl ArchForward for FixedCheckpoint {
    fn arch(&self) -> &'static str {
        "fixed"
    }
    fn on_gpu(&self) -> bool {
        false
    }
    fn context_length(&self) -> usize {
        self.inner.context
    }
    fn batched_prefills(&self) -> usize {
        0
    }
    fn notices(&self) -> &[String] {
        &[]
    }
    fn reserve(&mut self, positions: usize) -> Result<bool> {
        self.inner.reserve(positions)
    }
    fn forward(&mut self, tokens: &[u32], start: usize) -> Result<Vec<f32>> {
        self.inner.forward(tokens, start)
    }
    fn checkpoint_at(&self, _prompt: &[u32]) -> Option<usize> {
        Some(self.at)
    }
    fn save_checkpoint(&mut self) -> Result<()> {
        self.inner.saved = Some(self.inner.held);
        Ok(())
    }
}

#[test]
fn a_prompt_equal_to_the_checkpoint_does_not_restore_it() {
    let mut s = Session::new(Scripted::checkpointing(3, 100, MARK));
    s.generate(&[7851, MARK, 7852], &greedy(1), &mut |_| true)
        .expect("t1");
    assert_eq!(s.checkpoint, Some(vec![7851]));
    // Exactly the checkpoint: nothing beyond it to resume into.
    let reused = s.prepare_prompt(&[7851]).expect("prepare");
    assert_eq!(reused, 0);
    assert_eq!(s.engine().restores, 0);
    assert_eq!(s.checkpoint, Some(vec![7851]), "kept, not restored");
}

#[test]
fn a_checkpoint_at_the_resume_point_is_not_taken() {
    let mut s = Session::new(Scripted::checkpointing(3, 100, MARK));
    // The marker is the first token: k == start == 0.
    let reused = s.prepare_prompt(&[MARK, 7861, 7862]).expect("prepare");
    assert_eq!(reused, 0);
    assert!(
        s.engine().calls.is_empty(),
        "no prefill span for k == start"
    );
    assert_eq!(s.engine().saved, None);
    assert_eq!(s.checkpoint, None);
}

#[test]
fn a_checkpoint_at_the_prompt_end_is_not_taken() {
    let mut s = Session::new(FixedCheckpoint {
        inner: Scripted::new(3, 100),
        at: 3,
    });
    let reused = s.prepare_prompt(&[7871, 7872, 7873]).expect("prepare");
    assert_eq!(reused, 0);
    assert!(
        s.engine().inner.calls.is_empty(),
        "k == prompt.len() is no checkpoint"
    );
    assert_eq!(s.engine().inner.saved, None);
    assert_eq!(s.checkpoint, None);
}

#[test]
fn a_checkpoint_inside_the_prompt_is_taken() {
    let mut s = Session::new(FixedCheckpoint {
        inner: Scripted::new(3, 100),
        at: 2,
    });
    s.prepare_prompt(&[7881, 7882, 7883]).expect("prepare");
    assert_eq!(s.engine().inner.calls, vec![(2, 0)]);
    assert_eq!(s.checkpoint, Some(vec![7881, 7882]));
}

// #4954: the turn's prefill marks, which the server's `timings` split the TTFT
// on. Judged by order against the forwards themselves, not by magnitudes, so
// a loaded machine cannot turn them red (FALSIFY-APR-TTFT-014).

const PLANT: std::time::Duration = std::time::Duration::from_millis(5);

/// A [`Scripted`] forward that sleeps in `reserve` and in each of its first
/// `prefill_calls` forwards, and records when each forward ran.
struct Clocked {
    inner: Scripted,
    prefill_calls: usize,
    reserved_at: Option<Instant>,
    /// `(entered, left)` of each forward, in call order.
    spans: Vec<(Instant, Instant)>,
}

impl Clocked {
    fn new(inner: Scripted, prefill_calls: usize) -> Self {
        Self {
            inner,
            prefill_calls,
            reserved_at: None,
            spans: Vec::new(),
        }
    }
}

impl ArchForward for Clocked {
    fn arch(&self) -> &'static str {
        "clocked"
    }
    fn on_gpu(&self) -> bool {
        false
    }
    fn context_length(&self) -> usize {
        self.inner.context_length()
    }
    fn batched_prefills(&self) -> usize {
        0
    }
    fn notices(&self) -> &[String] {
        &[]
    }
    fn reserve(&mut self, positions: usize) -> Result<bool> {
        std::thread::sleep(PLANT);
        let dropped = self.inner.reserve(positions)?;
        self.reserved_at = Some(Instant::now());
        Ok(dropped)
    }
    fn checkpoint_at(&self, prompt: &[u32]) -> Option<usize> {
        self.inner.checkpoint_at(prompt)
    }
    fn save_checkpoint(&mut self) -> Result<()> {
        self.inner.save_checkpoint()
    }
    fn restore_checkpoint(&mut self) -> Result<bool> {
        self.inner.restore_checkpoint()
    }
    fn forward(&mut self, tokens: &[u32], start: usize) -> Result<Vec<f32>> {
        let entered = Instant::now();
        if self.spans.len() < self.prefill_calls {
            std::thread::sleep(PLANT);
        }
        let logits = self.inner.forward(tokens, start)?;
        self.spans.push((entered, Instant::now()));
        Ok(logits)
    }
}

/// The gx10 shape: a prompt prefilled in two calls, up to its checkpoint and
/// then the rest. Both calls are prefill; the reserve before them is not, and
/// no decode forward is.
#[test]
fn prefill_marks_bracket_every_prompt_forward_and_nothing_else() {
    let mut s = Session::new(Clocked::new(Scripted::checkpointing(3, 100, MARK), 2));
    let prompt = [7901, 7902, MARK, 7903];
    let turn = s
        .generate(&prompt, &greedy(3), &mut |_| true)
        .expect("turn");
    let f = s.engine();
    assert_eq!(f.inner.calls[..2], [(2, 0), (4, 2)], "two prefill calls");
    assert_eq!(f.spans.len(), 4, "two prefill calls and two decode steps");

    let reserved = f.reserved_at.expect("the turn reserved");
    assert!(
        reserved <= turn.prefill_started,
        "the reserve was counted as prefill"
    );
    for (i, (entered, left)) in f.spans[..2].iter().enumerate() {
        assert!(
            turn.prefill_started <= *entered && *left <= turn.prefill_ended,
            "prefill call {i} ran outside the prefill marks"
        );
    }
    for (i, (entered, _)) in f.spans[2..].iter().enumerate() {
        assert!(
            turn.prefill_ended <= *entered,
            "decode step {i} began inside the prefill marks"
        );
    }
    assert!(turn.prefill_ended.duration_since(turn.prefill_started) >= 2 * PLANT);
}

/// What the caller does with a token — send it down a channel, sleep — happens
/// after prefill has ended, so it can only ever show up as decode.
#[test]
fn prefill_marks_exclude_time_the_caller_spends_in_on_token() {
    let mut s = Session::new(Clocked::new(Scripted::new(3, 100), 1));
    let mut first_call: Option<Instant> = None;
    let turn = s
        .generate(&[7911, 7912, 7913], &greedy(3), &mut |_| {
            first_call.get_or_insert_with(Instant::now);
            std::thread::sleep(PLANT);
            true
        })
        .expect("turn");
    let first_call = first_call.expect("on_token ran");
    assert!(
        turn.prefill_ended <= first_call,
        "prefill ended after the first token reached the caller"
    );
    let (first_decode, _) = s.engine().spans[1];
    assert!(
        first_decode.duration_since(turn.prefill_ended) >= PLANT,
        "the caller's delay landed inside prefill"
    );
}

/// #4342: `prepare_turn` is `generate`'s setup run ahead of it, so a caller can
/// time generation alone. It refuses what `generate` refuses, reserves the
/// turn, runs no forward, and the turn after it is the turn `generate` alone
/// would have produced.
#[test]
fn prepare_turn_is_the_setup_generate_would_do() {
    let mut s = Session::new(Scripted::new(3, 10));
    assert!(
        s.prepare_turn(&[], 4).is_err(),
        "an empty prompt is refused"
    );
    assert!(
        s.prepare_turn(&[7401; 10], 4).is_err(),
        "a prompt the context cannot hold is refused"
    );
    assert_eq!(s.engine().reserves, 0, "a refused prompt reserves nothing");
    s.prepare_turn(&[7401, 7402, 7403], 4)
        .expect("a prompt that fits");
    assert_eq!(s.engine().reserves, 1);
    assert!(s.engine().calls.is_empty(), "setup runs no forward");
    let turn = s
        .generate(&[7401, 7402, 7403], &greedy(4), &mut |_| true)
        .expect("turn");
    assert_eq!(turn.tokens, vec![7401, 7402, 7403, 3, 3, 3, 3]);
    assert_eq!(s.engine().calls, vec![(3, 0), (4, 3), (5, 4), (6, 5)]);
}

/// #4342: the guard `prepare_turn` runs judges the positions it judged when it
/// ran inside `generate`, on the turn's first forward: the prefix the session
/// checkpoints when it takes one (a chat prompt's last turn marker), else the
/// whole prompt.
#[test]
fn prepare_turn_probes_what_the_first_forward_covers() {
    let mut s = Session::new(Scripted::new(3, 10));
    s.prepare_turn(&[7401, 7402, 7403], 4)
        .expect("a prompt that fits");
    assert_eq!(s.engine().probes, vec![vec![7401, 7402, 7403]]);

    let mut s = Session::new(Scripted::checkpointing(3, 16, 7900));
    let prompt = [7401, 7900, 7402, 7403];
    s.prepare_turn(&prompt, 4).expect("a prompt that fits");
    assert_eq!(
        s.engine().probes,
        vec![vec![7401]],
        "the checkpointed prefix"
    );
    s.generate(&prompt, &greedy(2), &mut |_| true)
        .expect("turn");
    assert_eq!(
        s.engine().calls[0],
        (1, 0),
        "the first forward covers the probe"
    );
}