aprender-gpu 0.32.0

Pure Rust PTX generation for NVIDIA CUDA - no LLVM, no nvcc
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
//! PMAT-295: Inline Q8 DP4A Q4K GEMV kernel.
//!
//! Fuses Q8_1 activation quantization INTO the DP4A GEMV inner loop.
//! Each thread independently quantizes its 4 FP32 values to INT8 using
//! per-thread absmax (no cross-thread shuffle needed). Then proceeds
//! with standard DP4A dot product against Q4K weight nibbles.
//!
//! Per-thread Q8 scale is mathematically equivalent to per-block Q8 scale
//! in the original kernel -- the scale just applies to fewer elements
//! (4 per thread vs 32 per block), which is actually more precise.
//!
//! Saves 1 kernel launch per GEMV call at M=2-4 (DP4A path).
//! At 4 saved launches/layer x 28 layers = 112 saved = ~1.3ms on 13ms step.

use crate::kernels::quantize::{Kernel, Q4K_SUPER_BLOCK_BYTES, Q4K_SUPER_BLOCK_SIZE};
use crate::ptx::builder::{PtxArithmetic, PtxComparison, PtxControl, PtxMemory, PtxSync};
use crate::ptx::{PtxKernel, PtxReg, PtxType};

/// PMAT-295: Batched DP4A Q4K GEMV with inline FP32-to-Q8 quantization.
pub struct InlineQ8Dp4aQ4KGemvKernel {
    /// K dimension (input dimension, must be multiple of 256).
    pub k: u32,
    /// N dimension (output dimension).
    pub n: u32,
    /// Batch size M.
    pub m: u32,
    /// Number of warps per block (default: 3).
    pub num_warps: u32,
}

impl InlineQ8Dp4aQ4KGemvKernel {
    /// Creates a new inline Q8 DP4A Q4K GEMV kernel with the given dimensions and default warp count.
    pub fn new(k: u32, n: u32, m: u32) -> Self {
        Self {
            k,
            n,
            m,
            num_warps: 3,
        }
    }
}

/// Helper: emit inline Q8 quantize for 4 FP32 values.
/// Returns (packed_u32, q8_scale) where packed_u32 has 4 INT8 values for DP4A.
fn emit_inline_q8_4(
    ctx: &mut crate::ptx::builder::KernelBuilder<'_>,
    f0: crate::ptx::VirtualReg,
    f1: crate::ptx::VirtualReg,
    f2: crate::ptx::VirtualReg,
    f3: crate::ptx::VirtualReg,
    inv_127: crate::ptx::VirtualReg,
    eps: crate::ptx::VirtualReg,
    neg127: crate::ptx::VirtualReg,
    pos127: crate::ptx::VirtualReg,
) -> (crate::ptx::VirtualReg, crate::ptx::VirtualReg) {
    // Per-thread absmax (4 values, no shuffle)
    let a0 = ctx.abs_f32(f0);
    let a1 = ctx.abs_f32(f1);
    let a2 = ctx.abs_f32(f2);
    let a3 = ctx.abs_f32(f3);
    let m01 = ctx.max_f32(a0, a1);
    let m23 = ctx.max_f32(a2, a3);
    let local_max = ctx.max_f32(m01, m23);

    // Q8 scale: d = max / 127, inv = 1 / (d + eps)
    let scale = ctx.mul_f32(local_max, inv_127);
    let scale_eps = ctx.add_f32(scale, eps);
    let inv_scale = ctx.rcp_f32(scale_eps);

    // Quantize: round(val / scale), clamp to [-127, 127]
    let s0 = ctx.mul_f32(f0, inv_scale);
    let s1 = ctx.mul_f32(f1, inv_scale);
    let s2 = ctx.mul_f32(f2, inv_scale);
    let s3 = ctx.mul_f32(f3, inv_scale);

    let i0 = ctx.cvt_rni_s32_f32(s0);
    let i1 = ctx.cvt_rni_s32_f32(s1);
    let i2 = ctx.cvt_rni_s32_f32(s2);
    let i3 = ctx.cvt_rni_s32_f32(s3);

    let i0 = ctx.max_s32(i0, neg127);
    let i0 = ctx.min_s32(i0, pos127);
    let i1 = ctx.max_s32(i1, neg127);
    let i1 = ctx.min_s32(i1, pos127);
    let i2 = ctx.max_s32(i2, neg127);
    let i2 = ctx.min_s32(i2, pos127);
    let i3 = ctx.max_s32(i3, neg127);
    let i3 = ctx.min_s32(i3, pos127);

    // Pack 4 INT8 into u32: cvt to u8, promote to u32, shift+or
    let b0_u8 = ctx.cvt_u8_s32(i0);
    let b0 = ctx.cvt_u32_u8(b0_u8);
    let b1_u8 = ctx.cvt_u8_s32(i1);
    let b1 = ctx.cvt_u32_u8(b1_u8);
    let b1 = ctx.shl_u32_imm(b1, 8);
    let b2_u8 = ctx.cvt_u8_s32(i2);
    let b2 = ctx.cvt_u32_u8(b2_u8);
    let b2 = ctx.shl_u32_imm(b2, 16);
    let b3_u8 = ctx.cvt_u8_s32(i3);
    let b3 = ctx.cvt_u32_u8(b3_u8);
    let b3 = ctx.shl_u32_imm(b3, 24);

    let lo = ctx.or_u32(b0, b1);
    let hi = ctx.or_u32(b2, b3);
    let packed = ctx.or_u32(lo, hi);

    (packed, scale)
}

impl Kernel for InlineQ8Dp4aQ4KGemvKernel {
    fn name(&self) -> &str {
        "inline_q8_dp4a_q4k_gemv"
    }

    fn build_ptx(&self) -> PtxKernel {
        let num_warps = self.num_warps;
        let num_half_warps = num_warps * 2;
        let m = self.m;
        let smem_size = (num_half_warps * m * 4) as usize;

        PtxKernel::new("inline_q8_dp4a_q4k_gemv")
            .param(PtxType::U64, "y_ptr")
            .param(PtxType::U64, "w_ptr")
            .param(PtxType::U64, "x_ptr") // FP32 input (NOT Q8)
            .param(PtxType::U32, "k_dim")
            .param(PtxType::U32, "n_dim")
            .param(PtxType::U32, "m_dim")
            .shared_memory(smem_size)
            .max_regs(255)
            .build(move |ctx| {
                // ===== Thread identity (identical to HwDp4a) =====
                let block_id = ctx.special_reg(PtxReg::CtaIdX);
                let thread_id = ctx.special_reg(PtxReg::TidX);
                let lane_id = ctx.rem_u32(thread_id, 32);
                let warp_id = ctx.div_u32(thread_id, 32);
                let grid_dim = ctx.special_reg(PtxReg::NctaIdX);

                let n_dim = ctx.load_param_u32("n_dim");
                let k_dim = ctx.load_param_u32("k_dim");
                let y_ptr = ctx.load_param_u64("y_ptr");
                let w_ptr = ctx.load_param_u64("w_ptr");
                let x_ptr = ctx.load_param_u64("x_ptr");

                let k_rounded = ctx.add_u32(k_dim, Q4K_SUPER_BLOCK_SIZE - 1);
                let num_sb = ctx.div_u32(k_rounded, Q4K_SUPER_BLOCK_SIZE);
                let sb_bytes_reg = ctx.mov_u32_imm(Q4K_SUPER_BLOCK_BYTES);
                let row_bytes = ctx.mul_u32_reg(num_sb, sb_bytes_reg);

                // Half-warp mapping
                let half_lane = ctx.and_u32_imm(lane_id, 15);
                let half_warp_in_warp = ctx.shr_u32_imm(lane_id, 4);
                let warp_x2 = ctx.shl_u32_imm(warp_id, 1);
                let half_warp_id = ctx.add_u32_reg(warp_x2, half_warp_in_warp);
                let num_hw = ctx.mov_u32_imm(num_half_warps);

                // Per-thread data mapping (identical to HwDp4a)
                let bq8_group = ctx.shr_u32_imm(half_lane, 2);
                let lane_in_group = ctx.and_u32_imm(half_lane, 3);
                let bq8_offset = ctx.shl_u32_imm(bq8_group, 1);

                // Q4K qs offset: 16 + 16*bq8_offset + 4*lane_in_group
                let t1 = ctx.shl_u32_imm(bq8_offset, 4);
                let t2 = ctx.shl_u32_imm(lane_in_group, 2);
                let q4_local = ctx.add_u32_reg(t1, t2);
                let q4_off = ctx.add_u32(q4_local, 16);
                let q4_off_64 = ctx.cvt_u64_u32(q4_off);

                // FP32 activation: K offset for this thread's values
                // sb_idx*256 + bq8_offset*32 + lane_in_group*4
                let c_256_u32 = ctx.mov_u32_imm(256);
                let bq8_k = ctx.shl_u32_imm(bq8_offset, 5);
                let lig_k = ctx.shl_u32_imm(lane_in_group, 2);
                let thread_k_off = ctx.add_u32_reg(bq8_k, lig_k);

                // Activation stride per batch element
                let c_4_stride = ctx.mov_u32_imm(4);
                let x_vec_stride = ctx.mul_u32_reg(k_dim, c_4_stride);

                // Constants
                let c_2_64 = ctx.mov_u64_imm(2);
                let c_4_64 = ctx.mov_u64_imm(4);
                let c_8_64 = ctx.mov_u64_imm(8);
                let c_16_64 = ctx.mov_u64_imm(16);
                let c_128_u32 = ctx.mov_u32_imm(128);
                let c_16_k = ctx.mov_u32_imm(16);

                // Scale extraction invariants
                let ci_mod2 = ctx.and_u32_imm(bq8_group, 1);
                let c_16_u32 = ctx.mov_u32_imm(16);
                let byte_shift = ctx.mul_u32_reg(ci_mod2, c_16_u32);
                let c_8_u32 = ctx.mov_u32_imm(8);
                let byte_shift_hi = ctx.add_u32_reg(byte_shift, c_8_u32);
                let c_2_u32 = ctx.mov_u32_imm(2);
                let p_hi = ctx.setp_ge_u32(bq8_group, c_2_u32);

                let c_ones = ctx.mov_u32_imm(0x0101_0101);
                let c_mask_6bit = ctx.mov_u32_imm(0x3F3F_3F3F);
                let c_mask_4bit = ctx.mov_u32_imm(0x0F0F_0F0F);
                let c_mask_2bit = ctx.mov_u32_imm(0x0303_0303);

                // Q8 quantize constants
                let c_inv_127 = ctx.mov_f32_imm(1.0 / 127.0);
                let c_eps = ctx.mov_f32_imm(1e-10);
                let c_127_s32 = ctx.mov_s32_imm(127);
                let c_neg127_u32 = ctx.mov_u32_imm(0xFFFF_FF81);
                let c_neg127_s32 = ctx.mov_s32_from_u32(c_neg127_u32);

                // M accumulators
                let f32_zero = ctx.mov_f32_imm(0.0);
                let mut accs = Vec::with_capacity(m as usize);
                for _ in 0..m {
                    accs.push(ctx.mov_f32_imm(0.0));
                }

                // ===== Grid-stride row loop =====
                let row_idx = ctx.mov_u32_imm(0);
                ctx.add_u32_reg_inplace(row_idx, block_id);

                ctx.label("iq8_row_loop");
                let row_oob = ctx.setp_ge_u32(row_idx, n_dim);
                ctx.branch_if(row_oob, "iq8_exit");

                let row_off = ctx.mul_wide_u32_reg(row_idx, row_bytes);
                let row_base = ctx.add_u64(w_ptr, row_off);

                for acc in &accs {
                    ctx.mov_f32_reg(*acc, f32_zero);
                }

                // SB loop
                let sb_idx = ctx.mov_u32_imm(0);
                ctx.add_u32_reg_inplace(sb_idx, half_warp_id);

                ctx.label("iq8_sb_loop");
                let sb_done = ctx.setp_ge_u32(sb_idx, num_sb);
                ctx.branch_if(sb_done, "iq8_sb_end");

                // ===== Q4K weight loading (shared across M) =====
                let sb_off = ctx.mul_wide_u32(sb_idx, Q4K_SUPER_BLOCK_BYTES);
                let sb_addr = ctx.add_u64(row_base, sb_off);

                let d_f16 = ctx.ld_global_f16(sb_addr);
                let d = ctx.cvt_f32_f16(d_f16);
                let dmin_addr = ctx.add_u64(sb_addr, c_2_64);
                let dmin_f16 = ctx.ld_global_f16(dmin_addr);
                let dmin = ctx.cvt_f32_f16(dmin_f16);
                let neg_dmin = ctx.neg_f32(dmin);

                let sc_base = ctx.add_u64(sb_addr, c_4_64);
                let sc03 = ctx.ld_global_u32(sc_base);
                let sc47_addr = ctx.add_u64(sc_base, c_4_64);
                let sc47 = ctx.ld_global_u32(sc47_addr);
                let sc811_addr = ctx.add_u64(sc_base, c_8_64);
                let sc811 = ctx.ld_global_u32(sc811_addr);

                let sc_lo4 = ctx.and_u32(sc03, c_mask_6bit);
                let mn_lo4 = ctx.and_u32(sc47, c_mask_6bit);
                let sc_hi_low = ctx.and_u32(sc811, c_mask_4bit);
                let t = ctx.shr_u32_imm(sc03, 6);
                let t = ctx.and_u32(t, c_mask_2bit);
                let sc_hi_top = ctx.shl_u32_imm(t, 4);
                let sc_hi4 = ctx.or_u32(sc_hi_low, sc_hi_top);
                let mn_hi_raw = ctx.shr_u32_imm(sc811, 4);
                let mn_hi_low = ctx.and_u32(mn_hi_raw, c_mask_4bit);
                let t = ctx.shr_u32_imm(sc47, 6);
                let t = ctx.and_u32(t, c_mask_2bit);
                let mn_hi_top = ctx.shl_u32_imm(t, 4);
                let mn_hi4 = ctx.or_u32(mn_hi_low, mn_hi_top);

                let sc_src = ctx.selp_u32(p_hi, sc_hi4, sc_lo4);
                let mn_src = ctx.selp_u32(p_hi, mn_hi4, mn_lo4);
                let sc0 = ctx.bfe_u32_reg(sc_src, byte_shift, 8);
                let sc1 = ctx.bfe_u32_reg(sc_src, byte_shift_hi, 8);
                let mn0 = ctx.bfe_u32_reg(mn_src, byte_shift, 8);
                let mn1 = ctx.bfe_u32_reg(mn_src, byte_shift_hi, 8);

                let q4_addr = ctx.add_u64(sb_addr, q4_off_64);
                let v0 = ctx.ld_global_u32(q4_addr);
                let v1_addr = ctx.add_u64(q4_addr, c_16_64);
                let v1 = ctx.ld_global_u32(v1_addr);

                let v0_lo = ctx.and_u32(v0, c_mask_4bit);
                let v1_lo = ctx.and_u32(v1, c_mask_4bit);
                let v0_hi = ctx.shr_u32_imm(v0, 4);
                let v0_hi = ctx.and_u32(v0_hi, c_mask_4bit);
                let v1_hi = ctx.shr_u32_imm(v1, 4);
                let v1_hi = ctx.and_u32(v1_hi, c_mask_4bit);

                // K base for this SB
                let sb_k_base = ctx.mul_u32_reg(sb_idx, c_256_u32);

                // ===== Per-batch inline Q8 + DP4A =====
                for mi in 0..m {
                    let x_m_off = if mi == 0 {
                        ctx.mov_u64_imm(0)
                    } else {
                        let mi_reg = ctx.mov_u32_imm(mi);
                        ctx.mul_wide_u32_reg(mi_reg, x_vec_stride)
                    };
                    let x_m_base = ctx.add_u64(x_ptr, x_m_off);

                    // --- QR=0: Low nibbles ---
                    let k_off_lo = ctx.add_u32_reg(sb_k_base, thread_k_off);
                    let k_bytes = ctx.mul_wide_u32(k_off_lo, 4);
                    let x_addr = ctx.add_u64(x_m_base, k_bytes);

                    let f0 = ctx.ld_global_f32(x_addr);
                    let f1a = ctx.add_u64(x_addr, c_4_64);
                    let f1 = ctx.ld_global_f32(f1a);
                    let f2a = ctx.add_u64(x_addr, c_8_64);
                    let f2 = ctx.ld_global_f32(f2a);
                    let f3a = ctx.add_u64(f2a, c_4_64);
                    let f3 = ctx.ld_global_f32(f3a);

                    let (u0_lo, q8_d0) = emit_inline_q8_4(
                        ctx,
                        f0,
                        f1,
                        f2,
                        f3,
                        c_inv_127,
                        c_eps,
                        c_neg127_s32,
                        c_127_s32,
                    );

                    // v1 part: k_off_lo + 16
                    let k_off_v1 = ctx.add_u32_reg(k_off_lo, c_16_k);
                    let k_bytes_v1 = ctx.mul_wide_u32(k_off_v1, 4);
                    let xv1 = ctx.add_u64(x_m_base, k_bytes_v1);

                    let g0 = ctx.ld_global_f32(xv1);
                    let g1a = ctx.add_u64(xv1, c_4_64);
                    let g1 = ctx.ld_global_f32(g1a);
                    let g2a = ctx.add_u64(xv1, c_8_64);
                    let g2 = ctx.ld_global_f32(g2a);
                    let g3a = ctx.add_u64(g2a, c_4_64);
                    let g3 = ctx.ld_global_f32(g3a);

                    let (u1_lo, q8_d0b) = emit_inline_q8_4(
                        ctx,
                        g0,
                        g1,
                        g2,
                        g3,
                        c_inv_127,
                        c_eps,
                        c_neg127_s32,
                        c_127_s32,
                    );

                    // DP4A: Q4K nibbles x inline Q8 values
                    let dot0 = ctx.mov_u32_imm(0);
                    ctx.dp4a_u32_s32_inplace(dot0, v0_lo, u0_lo);
                    ctx.dp4a_u32_s32_inplace(dot0, v1_lo, u1_lo);

                    let sum0 = ctx.mov_u32_imm(0);
                    ctx.dp4a_u32_s32_inplace(sum0, c_ones, u0_lo);
                    ctx.dp4a_u32_s32_inplace(sum0, c_ones, u1_lo);

                    // Accumulate: same formula, per-thread Q8 scale
                    // For u0_lo part: scale = q8_d0, for u1_lo: scale = q8_d0b
                    // Approximate: use average scale for the combined dot product
                    // (exact would need separate dot products per 4-element block)
                    let avg_scale = ctx.add_f32(q8_d0, q8_d0b);
                    let c_half = ctx.mov_f32_imm(0.5);
                    let avg_scale = ctx.mul_f32(avg_scale, c_half);

                    let sdot0 = ctx.mul_lo_s32(sc0, dot0);
                    let msum0 = ctx.mul_lo_s32(mn0, sum0);
                    let sdot0_f = ctx.cvt_f32_s32(sdot0);
                    let msum0_f = ctx.cvt_f32_s32(msum0);
                    let t1 = ctx.mul_f32(d, sdot0_f);
                    let t3 = ctx.fma_f32(neg_dmin, msum0_f, t1);
                    let q8_t3 = ctx.mul_f32(avg_scale, t3);
                    ctx.add_f32_inplace(accs[mi as usize], q8_t3);

                    // --- QR=1: High nibbles (k_off + 128) ---
                    let k_off_hi = ctx.add_u32_reg(k_off_lo, c_128_u32);
                    let k_bytes_hi = ctx.mul_wide_u32(k_off_hi, 4);
                    let xh = ctx.add_u64(x_m_base, k_bytes_hi);

                    let h0 = ctx.ld_global_f32(xh);
                    let h1a = ctx.add_u64(xh, c_4_64);
                    let h1 = ctx.ld_global_f32(h1a);
                    let h2a = ctx.add_u64(xh, c_8_64);
                    let h2 = ctx.ld_global_f32(h2a);
                    let h3a = ctx.add_u64(h2a, c_4_64);
                    let h3 = ctx.ld_global_f32(h3a);

                    let (u0_hi, q8_d1) = emit_inline_q8_4(
                        ctx,
                        h0,
                        h1,
                        h2,
                        h3,
                        c_inv_127,
                        c_eps,
                        c_neg127_s32,
                        c_127_s32,
                    );

                    let k_off_v1h = ctx.add_u32_reg(k_off_hi, c_16_k);
                    let k_bytes_v1h = ctx.mul_wide_u32(k_off_v1h, 4);
                    let xv1h = ctx.add_u64(x_m_base, k_bytes_v1h);

                    let hg0 = ctx.ld_global_f32(xv1h);
                    let hg1a = ctx.add_u64(xv1h, c_4_64);
                    let hg1 = ctx.ld_global_f32(hg1a);
                    let hg2a = ctx.add_u64(xv1h, c_8_64);
                    let hg2 = ctx.ld_global_f32(hg2a);
                    let hg3a = ctx.add_u64(hg2a, c_4_64);
                    let hg3 = ctx.ld_global_f32(hg3a);

                    let (u1_hi, q8_d1b) = emit_inline_q8_4(
                        ctx,
                        hg0,
                        hg1,
                        hg2,
                        hg3,
                        c_inv_127,
                        c_eps,
                        c_neg127_s32,
                        c_127_s32,
                    );

                    let dot1 = ctx.mov_u32_imm(0);
                    ctx.dp4a_u32_s32_inplace(dot1, v0_hi, u0_hi);
                    ctx.dp4a_u32_s32_inplace(dot1, v1_hi, u1_hi);

                    let sum1 = ctx.mov_u32_imm(0);
                    ctx.dp4a_u32_s32_inplace(sum1, c_ones, u0_hi);
                    ctx.dp4a_u32_s32_inplace(sum1, c_ones, u1_hi);

                    let avg_scale_hi = ctx.add_f32(q8_d1, q8_d1b);
                    let avg_scale_hi = ctx.mul_f32(avg_scale_hi, c_half);

                    let sdot1 = ctx.mul_lo_s32(sc1, dot1);
                    let msum1 = ctx.mul_lo_s32(mn1, sum1);
                    let sdot1_f = ctx.cvt_f32_s32(sdot1);
                    let msum1_f = ctx.cvt_f32_s32(msum1);
                    let t1 = ctx.mul_f32(d, sdot1_f);
                    let t3 = ctx.fma_f32(neg_dmin, msum1_f, t1);
                    let q8_t3_hi = ctx.mul_f32(avg_scale_hi, t3);
                    ctx.add_f32_inplace(accs[mi as usize], q8_t3_hi);
                }

                ctx.add_u32_reg_inplace(sb_idx, num_hw);
                ctx.branch("iq8_sb_loop");

                ctx.label("iq8_sb_end");

                // ===== Half-warp reduction (identical to HwDp4a) =====
                for acc in &accs {
                    let t = ctx.shfl_down_f32(*acc, 8, 0xFFFF_FFFF);
                    ctx.add_f32_inplace(*acc, t);
                    let t = ctx.shfl_down_f32(*acc, 4, 0xFFFF_FFFF);
                    ctx.add_f32_inplace(*acc, t);
                    let t = ctx.shfl_down_f32(*acc, 2, 0xFFFF_FFFF);
                    ctx.add_f32_inplace(*acc, t);
                    let t = ctx.shfl_down_f32(*acc, 1, 0xFFFF_FFFF);
                    ctx.add_f32_inplace(*acc, t);
                }

                // Cross-half-warp reduction via shared memory
                let c_zero_u32 = ctx.mov_u32_imm(0);
                let is_lane0 = ctx.setp_eq_u32(half_lane, c_zero_u32);
                let smem_base = ctx.mov_u64_imm(0);
                ctx.branch_if_not(is_lane0, "iq8_skip_smem_write");

                let c_m_u32 = ctx.mov_u32_imm(m);
                for (mi, acc) in accs.iter().enumerate() {
                    let mi_reg = ctx.mov_u32_imm(mi as u32);
                    let hw_m = ctx.mul_u32_reg(half_warp_id, c_m_u32);
                    let smem_idx = ctx.add_u32_reg(hw_m, mi_reg);
                    let smem_off = ctx.mul_wide_u32(smem_idx, 4);
                    let smem_addr = ctx.add_u64(smem_base, smem_off);
                    ctx.st_shared_f32(smem_addr, *acc);
                }

                ctx.label("iq8_skip_smem_write");
                ctx.bar_sync(0);

                let c_zero2 = ctx.mov_u32_imm(0);
                let is_first_hw = ctx.setp_eq_u32(half_warp_id, c_zero2);
                ctx.branch_if_not(is_first_hw, "iq8_skip_output");

                let c_zero3 = ctx.mov_u32_imm(0);
                let is_lane0_first = ctx.setp_eq_u32(half_lane, c_zero3);
                ctx.branch_if_not(is_lane0_first, "iq8_skip_output");

                let c_m_red = ctx.mov_u32_imm(m);
                for mi in 0..m {
                    let total = ctx.mov_f32_imm(0.0);
                    for hw in 0..num_half_warps {
                        let mi_reg = ctx.mov_u32_imm(mi);
                        let hw_reg = ctx.mov_u32_imm(hw);
                        let hw_m = ctx.mul_u32_reg(hw_reg, c_m_red);
                        let idx = ctx.add_u32_reg(hw_m, mi_reg);
                        let off = ctx.mul_wide_u32(idx, 4);
                        let addr = ctx.add_u64(smem_base, off);
                        let val = ctx.ld_shared_f32(addr);
                        ctx.add_f32_inplace(total, val);
                    }

                    let mi_reg = ctx.mov_u32_imm(mi);
                    let row_m = ctx.mul_u32_reg(row_idx, c_m_red);
                    let out_idx = ctx.add_u32_reg(row_m, mi_reg);
                    let out_off = ctx.mul_wide_u32(out_idx, 4);
                    let out_addr = ctx.add_u64(y_ptr, out_off);
                    ctx.st_global_f32(out_addr, total);
                }

                ctx.label("iq8_skip_output");
                ctx.bar_sync(1);

                ctx.add_u32_reg_inplace(row_idx, grid_dim);
                ctx.branch("iq8_row_loop");

                ctx.label("iq8_exit");
                ctx.ret();
            })
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_inline_q8_kernel_builds_ptx() {
        let kernel = InlineQ8Dp4aQ4KGemvKernel::new(1536, 1536, 4);
        let ptx = kernel.emit_ptx();
        assert!(ptx.contains("inline_q8_dp4a_q4k_gemv"));
        assert!(ptx.contains(".entry"));
        assert!(ptx.is_ascii(), "PTX must be pure ASCII");
    }

    #[test]
    fn test_inline_q8_kernel_m1() {
        let kernel = InlineQ8Dp4aQ4KGemvKernel::new(1536, 1536, 1);
        let ptx = kernel.emit_ptx();
        assert!(ptx.is_ascii());
        assert!(ptx.contains("dp4a"));
    }
}