apk-info-zip 1.1.0

A library for correctly unpacking APK files that use the BadPack technique
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
use std::sync::Arc;

use ahash::AHashMap;
use log::warn;
use winnow::binary::{le_u16, le_u32};
use winnow::combinator::repeat;
use winnow::error::{ErrMode, Needed};
use winnow::prelude::*;
use winnow::token::take;

use crate::anomaly::ZipAnomaly;

#[derive(Debug)]
pub(crate) struct CentralDirectoryEntry {
    #[expect(dead_code, reason = "parsed for completeness, not read yet")]
    pub(crate) version_made_by: u16,

    #[expect(dead_code, reason = "parsed for completeness, not read yet")]
    pub(crate) version_needed: u16,

    pub(crate) general_purpose: u16,

    pub(crate) compression_method: u16,

    #[expect(dead_code, reason = "parsed for completeness, not read yet")]
    pub(crate) last_mod_time: u16,

    #[expect(dead_code, reason = "parsed for completeness, not read yet")]
    pub(crate) last_mod_date: u16,

    #[expect(dead_code, reason = "parsed for completeness, not read yet")]
    pub(crate) crc32: u32,

    /// Compressed size, from the ZIP64 extra field when the record holds `0xFFFFFFFF`
    pub(crate) compressed_size: u64,

    /// Uncompressed size, from the ZIP64 extra field when the record holds `0xFFFFFFFF`
    pub(crate) uncompressed_size: u64,

    #[expect(dead_code, reason = "parsed for completeness, not read yet")]
    pub(crate) file_name_length: u16,

    #[cfg_attr(not(test), expect(dead_code, reason = "read only by the tests"))]
    pub(crate) extra_field_length: u16,

    #[cfg_attr(not(test), expect(dead_code, reason = "read only by the tests"))]
    pub(crate) file_comment_length: u16,

    #[expect(dead_code, reason = "parsed for completeness, not read yet")]
    pub(crate) disk_number_start: u16,

    #[expect(dead_code, reason = "parsed for completeness, not read yet")]
    pub(crate) internal_attrs: u16,

    #[expect(dead_code, reason = "parsed for completeness, not read yet")]
    pub(crate) external_attrs: u32,

    /// Local header offset, from the ZIP64 extra field when the record holds `0xFFFFFFFF`
    pub(crate) local_header_offset: u64,

    /// The name as UTF-8; invalid bytes are replaced with U+FFFD
    pub(crate) file_name: Arc<str>,

    /// The name as stored, kept only when it isn't valid UTF-8: the local
    /// header is matched against these bytes
    pub(crate) raw_file_name: Option<Arc<[u8]>>,
}

impl CentralDirectoryEntry {
    const MAGIC: u32 = 0x02014b50;

    /// Header id of the ZIP64 extended information extra field.
    ///
    /// See: <https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT> (4.5.3)
    const ZIP64_EXTRA_ID: u16 = 0x0001;

    #[inline(always)]
    fn parse(input: &mut &[u8]) -> ModalResult<CentralDirectoryEntry> {
        let (
            _,
            version_made_by,
            version_needed,
            general_purpose,
            compression_method,
            last_mod_time,
            last_mod_date,
            crc32,
            compressed_size,
            uncompressed_size,
        ) = (
            le_u32.verify(|magic| *magic == Self::MAGIC), // magic
            le_u16,                                       // version_made_by
            le_u16,                                       // version_needed
            le_u16,                                       // general_purpose
            le_u16,                                       // compression_method
            le_u16,                                       // last_mod_time
            le_u16,                                       // last_mod_date
            le_u32,                                       // crc32
            le_u32,                                       // compressed_size
            le_u32,                                       // uncompressed_size
        )
            .parse_next(input)?;

        let (
            file_name_length,
            extra_field_length,
            file_comment_length,
            disk_number_start,
            internal_attrs,
            external_attrs,
            local_header_offset,
        ) = (
            le_u16, // file_name_length
            le_u16, // extra_field_length
            le_u16, // file_comment_length
            le_u16, // disk_number_start
            le_u16, // internal_attrs
            le_u32, // external_attrs
            le_u32, // local_header_offset
        )
            .parse_next(input)?;

        // the comment is unused: skip it without copying
        let (file_name, extra_field, _) = (
            take(file_name_length),
            take(extra_field_length),
            take(file_comment_length),
        )
            .parse_next(input)?;

        // Android rejects a name that isn't UTF-8, but the rest of the archive
        // is still worth reading; U+FFFD can't turn such a name into a valid one
        let (file_name, raw_file_name) = match std::str::from_utf8(file_name) {
            Ok(name) => (Arc::from(name), None),
            Err(_) => (
                Arc::from(String::from_utf8_lossy(file_name).as_ref()),
                Some(Arc::from(file_name)),
            ),
        };

        let (uncompressed_size, compressed_size, local_header_offset) = Self::apply_zip64(
            extra_field,
            uncompressed_size,
            compressed_size,
            local_header_offset,
        );

        Ok(CentralDirectoryEntry {
            version_made_by,
            version_needed,
            general_purpose,
            compression_method,
            last_mod_time,
            last_mod_date,
            crc32,
            compressed_size,
            uncompressed_size,
            file_name_length,
            extra_field_length,
            file_comment_length,
            disk_number_start,
            internal_attrs,
            external_attrs,
            local_header_offset,
            file_name,
            raw_file_name,
        })
    }

    /// Replaces the 32-bit fields that hold `0xFFFFFFFF` with their 64-bit
    /// values from the ZIP64 extra field.
    ///
    /// The extra field carries only the saturated fields, in this order:
    /// uncompressed size, compressed size, local header offset. A missing or
    /// short extra field leaves the 32-bit values as they are.
    fn apply_zip64(
        mut extra: &[u8],
        uncompressed_size: u32,
        compressed_size: u32,
        local_header_offset: u32,
    ) -> (u64, u64, u64) {
        let mut fields = [
            u64::from(uncompressed_size),
            u64::from(compressed_size),
            u64::from(local_header_offset),
        ];
        if !fields.contains(&u64::from(u32::MAX)) {
            return (fields[0], fields[1], fields[2]);
        }

        while let Some((header, rest)) = extra.split_first_chunk::<4>() {
            let id = u16::from_le_bytes([header[0], header[1]]);
            let size = u16::from_le_bytes([header[2], header[3]]) as usize;
            let Some(data) = rest.get(..size) else {
                break;
            };
            extra = &rest[size..];

            if id != Self::ZIP64_EXTRA_ID {
                continue;
            }

            let mut data = data;
            for field in fields
                .iter_mut()
                .filter(|field| **field == u64::from(u32::MAX))
            {
                let Some((value, rest)) = data.split_first_chunk::<8>() else {
                    break;
                };
                *field = u64::from_le_bytes(*value);
                data = rest;
            }
            break;
        }

        (fields[0], fields[1], fields[2])
    }
}

#[derive(Debug)]
pub(crate) struct CentralDirectory {
    pub(crate) entries: AHashMap<Arc<str>, CentralDirectoryEntry>,

    /// Entry names in central directory record order (first occurrence wins).
    ///
    /// Iteration over the hash map is random per process; extraction and repack
    /// follow the file's own order instead, so it is preserved here.
    pub(crate) ordered_names: Vec<Arc<str>>,

    /// Defects of the record list.
    pub(crate) anomalies: Vec<ZipAnomaly>,
}

impl CentralDirectory {
    /// Parses at most `expected_entries` records, matching Android's loop over
    /// `num_records`, so a decoy appended past the count can't shadow a real
    /// entry. Stops early on a failed record, staying lenient for truncation.
    pub(crate) fn parse(
        input: &[u8],
        cd_offset: usize,
        expected_entries: usize,
    ) -> ModalResult<CentralDirectory> {
        let mut input = input
            .get(cd_offset..)
            .ok_or(ErrMode::Incomplete(Needed::Unknown))?;

        let parsed = repeat::<_, CentralDirectoryEntry, Vec<CentralDirectoryEntry>, _, _>(
            0..=expected_entries,
            CentralDirectoryEntry::parse,
        )
        .parse_next(&mut input)?;

        let mut anomalies = Vec::new();
        if parsed.len() < expected_entries {
            anomalies.push(ZipAnomaly::MissingCentralDirectoryRecords {
                declared: expected_entries as u64,
                parsed: parsed.len() as u64,
            });
        } else {
            // records past the count are ignored, as Android does, but noted
            let mut extra = 0u64;
            while CentralDirectoryEntry::parse(&mut input).is_ok() {
                extra += 1;
            }
            if extra != 0 {
                anomalies.push(ZipAnomaly::ExtraCentralDirectoryRecords {
                    declared: expected_entries as u64,
                    extra,
                });
            }
        }

        // `read` looks names up in the map, so a duplicated name keeps the last
        // record's data; `ordered_names` keeps the first record's position.
        let mut entries = AHashMap::with_capacity(parsed.len());
        let mut ordered_names = Vec::with_capacity(parsed.len());
        for (index, entry) in parsed.into_iter().enumerate() {
            if entry.raw_file_name.is_some() {
                warn!(
                    "entry {index}: name is not valid UTF-8, read as {:?}; Android rejects this archive",
                    entry.file_name
                );
                anomalies.push(ZipAnomaly::InvalidUtf8Name {
                    entry: entry.file_name.to_string(),
                });
            }

            let name = Arc::clone(&entry.file_name);
            if entries
                .insert(Arc::clone(&entry.file_name), entry)
                .is_none()
            {
                ordered_names.push(name);
            } else {
                anomalies.push(ZipAnomaly::DuplicateEntry {
                    entry: name.to_string(),
                });
            }
        }

        // a file name used as a directory by another entry
        for name in &ordered_names {
            if let Some(file) = name
                .match_indices('/')
                .map(|(end, _)| &name[..end])
                .find(|parent| entries.contains_key(*parent))
            {
                anomalies.push(ZipAnomaly::EntryPathConflict {
                    entry: name.to_string(),
                    file: file.to_owned(),
                });
            }
        }

        Ok(CentralDirectory {
            entries,
            ordered_names,
            anomalies,
        })
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn make_cde_record(
        file_name: &str,
        extra_field: &[u8],
        comment: &[u8],
        compressed_size: u32,
        uncompressed_size: u32,
        local_header_offset: u32,
    ) -> Vec<u8> {
        let mut data = Vec::new();

        data.extend_from_slice(&CentralDirectoryEntry::MAGIC.to_le_bytes()); // magic
        data.extend_from_slice(&45u16.to_le_bytes()); // version_made_by
        data.extend_from_slice(&20u16.to_le_bytes()); // version_needed
        data.extend_from_slice(&0u16.to_le_bytes()); // general_purpose
        data.extend_from_slice(&8u16.to_le_bytes()); // compression_method
        data.extend_from_slice(&1234u16.to_le_bytes()); // last_mod_time
        data.extend_from_slice(&5678u16.to_le_bytes()); // last_mod_date
        data.extend_from_slice(&0xAABBCCDDu32.to_le_bytes()); // crc32
        data.extend_from_slice(&compressed_size.to_le_bytes());
        data.extend_from_slice(&uncompressed_size.to_le_bytes());
        data.extend_from_slice(&(file_name.len() as u16).to_le_bytes());
        data.extend_from_slice(&(extra_field.len() as u16).to_le_bytes());
        data.extend_from_slice(&(comment.len() as u16).to_le_bytes());
        data.extend_from_slice(&0u16.to_le_bytes()); // disk_number_start
        data.extend_from_slice(&0u16.to_le_bytes()); // internal_attrs
        data.extend_from_slice(&0x11223344u32.to_le_bytes()); // external_attrs
        data.extend_from_slice(&local_header_offset.to_le_bytes());

        data.extend_from_slice(file_name.as_bytes()); // file_name
        data.extend_from_slice(extra_field); // extra_field
        data.extend_from_slice(comment); // comment
        data
    }

    #[test]
    fn test_parse_valid_cde_entry() {
        let file_name = "hello.txt";
        let extra = b"extra field";
        let comment = b"comment field";
        let data = make_cde_record(file_name, extra, comment, 111, 222, 333);

        let mut input = &data[..];
        let entry = CentralDirectoryEntry::parse(&mut input).unwrap();

        assert_eq!(entry.file_name.as_ref(), file_name);
        assert_eq!(entry.extra_field_length as usize, extra.len());
        assert_eq!(entry.file_comment_length as usize, comment.len());
        assert_eq!(entry.compressed_size, 111);
        assert_eq!(entry.uncompressed_size, 222);
        assert_eq!(entry.local_header_offset, 333);
        assert!(input.is_empty());
    }

    #[test]
    fn test_parse_invalid_magic() {
        let mut data = make_cde_record("x", &[], &[], 1, 2, 3);
        data[0] = 0x00; // corrupt magic
        let mut input = &data[..];
        let result = CentralDirectoryEntry::parse(&mut input);
        assert!(result.is_err(), "expected error on invalid magic");
    }

    #[test]
    fn test_parse_non_utf8_filename() {
        // Filename bytes that are invalid UTF-8
        let bad_bytes = [b'a', 0xFF, 0xFE, b'b'];
        let mut data = make_cde_record("", &[], &[], 0, 0, 0);
        let name_len = bad_bytes.len() as u16;

        // Patch in new filename length and name
        data[28..30].copy_from_slice(&name_len.to_le_bytes());
        data.extend_from_slice(&bad_bytes);

        let mut input = &data[..];
        let entry = CentralDirectoryEntry::parse(&mut input).unwrap();

        assert_eq!(entry.file_name.as_ref(), "a\u{fffd}\u{fffd}b");
        assert_eq!(entry.raw_file_name.as_deref(), Some(&bad_bytes[..]));
    }

    #[test]
    fn non_utf8_name_does_not_end_the_directory() {
        let mut bad = make_cde_record("ab", &[], &[], 0, 0, 0);
        let name_at = bad.len() - 2;
        bad[name_at] = 0xC0; // an overlong lead byte

        let mut data = make_cde_record("first.txt", &[], &[], 0, 0, 0);
        data.extend_from_slice(&bad);
        data.extend_from_slice(&make_cde_record("resources.arsc", &[], &[], 0, 0, 0));

        let cd = CentralDirectory::parse(&data, 0, 3).unwrap();
        assert_eq!(cd.ordered_names.len(), 3);
        assert!(cd.entries.contains_key("resources.arsc"));
        assert!(cd.entries.contains_key("\u{fffd}b"));
    }

    #[test]
    fn test_parse_multiple_entries_in_directory() {
        // Two entries back-to-back
        let e1 = make_cde_record("a.txt", b"", b"", 10, 20, 30);
        let e2 = make_cde_record("b.txt", b"extra information", b"comment field", 40, 50, 60);
        let mut data = Vec::new();
        data.extend_from_slice(&e1);
        data.extend_from_slice(&e2);

        let cd = CentralDirectory::parse(&data, 0, 2).unwrap();
        assert_eq!(cd.entries.len(), 2);
        assert!(cd.entries.contains_key("a.txt"));
        assert!(cd.entries.contains_key("b.txt"));

        let b = cd.entries.get("b.txt").unwrap();
        assert_eq!(b.extra_field_length as usize, b"extra information".len());
        assert_eq!(b.file_comment_length as usize, b"comment field".len());
    }

    #[test]
    fn test_parse_central_directory_with_offset() {
        let entry = make_cde_record("offset.txt", b"", b"", 100, 200, 300);
        let mut file = vec![0xAA; 50]; // padding before
        let offset = file.len();
        file.extend_from_slice(&entry);

        let cd = CentralDirectory::parse(&file, offset, 1).unwrap();
        assert_eq!(cd.entries.len(), 1);
        assert!(cd.entries.contains_key("offset.txt"));
    }

    #[test]
    fn test_parse_central_directory_invalid_offset() {
        let data = vec![0x00; 10];

        let result = CentralDirectory::parse(&data, 9999, 1);
        assert!(result.is_err(), "expected error for out-of-bounds offset");
    }

    fn zip64_extra(values: &[u64]) -> Vec<u8> {
        let mut extra = Vec::new();
        extra.extend_from_slice(&0x0001u16.to_le_bytes());
        extra.extend_from_slice(&((values.len() * 8) as u16).to_le_bytes());
        for value in values {
            extra.extend_from_slice(&value.to_le_bytes());
        }
        extra
    }

    #[test]
    fn zip64_extra_replaces_saturated_fields() {
        // an unrelated extra block first, then ZIP64 with all three fields
        let mut extra = vec![0xfe, 0xca, 0x02, 0x00, 0xaa, 0xbb];
        extra.extend(zip64_extra(&[5 << 32, 4 << 32, 6 << 32]));
        let data = make_cde_record("big.obb", &extra, b"", u32::MAX, u32::MAX, u32::MAX);

        let entry = CentralDirectoryEntry::parse(&mut &data[..]).unwrap();
        assert_eq!(entry.uncompressed_size, 5 << 32);
        assert_eq!(entry.compressed_size, 4 << 32);
        assert_eq!(entry.local_header_offset, 6 << 32);
    }

    #[test]
    fn zip64_extra_holds_only_saturated_fields() {
        // only the offset is saturated, so the extra field has one value
        let extra = zip64_extra(&[7 << 32]);
        let data = make_cde_record("base.apk", &extra, b"", 10, 20, u32::MAX);

        let entry = CentralDirectoryEntry::parse(&mut &data[..]).unwrap();
        assert_eq!(entry.compressed_size, 10);
        assert_eq!(entry.uncompressed_size, 20);
        assert_eq!(entry.local_header_offset, 7 << 32);
    }

    #[test]
    fn short_zip64_extra_keeps_32_bit_values() {
        let mut extra = zip64_extra(&[1 << 32]);
        extra.truncate(8); // declares 8 bytes, has 4
        let data = make_cde_record("x", &extra, b"", u32::MAX, u32::MAX, 0);

        let entry = CentralDirectoryEntry::parse(&mut &data[..]).unwrap();
        assert_eq!(entry.uncompressed_size, u64::from(u32::MAX));
        assert_eq!(entry.compressed_size, u64::from(u32::MAX));
    }

    #[test]
    fn test_decoy_record_beyond_num_records_is_ignored() {
        // Real entry plus a decoy reusing its name; the count (1) excludes the
        // decoy, so the real entry's data wins.
        let real = make_cde_record("AndroidManifest.xml", b"", b"", 10, 20, 30);
        let decoy = make_cde_record("AndroidManifest.xml", b"", b"", 99, 99, 999);
        let mut data = Vec::new();
        data.extend_from_slice(&real);
        data.extend_from_slice(&decoy);

        let cd = CentralDirectory::parse(&data, 0, 1).unwrap();
        assert_eq!(cd.entries.len(), 1);
        let entry = cd.entries.get("AndroidManifest.xml").unwrap();
        assert_eq!(entry.local_header_offset, 30, "decoy must not win");
        assert_eq!(entry.compressed_size, 10);
    }
}