apihunter 0.1.2

Async API security scanner with passive and active checks for CORS, CSP, GraphQL, JWT, OpenAPI, and API posture.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
//! Central orchestration layer.
//!
//! Responsibilities:
//!   1. Accept a deduplicated list of seed URLs.
//!   2. Gate the work queue against `config.max_endpoints`.
//!   3. Fan work out across a bounded Tokio worker pool (semaphore-limited).
//!   4. Run every enabled [`Scanner`] against each URL concurrently.
//!   5. Aggregate all [`Finding`]s and [`CapturedError`]s thread-safely.
//!   6. Return a [`RunResult`] ready for the reporter.

use std::{
    collections::{BTreeMap, HashSet},
    future::Future,
    sync::Arc,
    time::{Duration, Instant},
};

use rand::seq::SliceRandom;
use tokio::{
    sync::{mpsc, Mutex, Semaphore},
    task::JoinSet,
};
use tracing::{debug, error, info, warn};
use url::Url;

use crate::{
    config::Config,
    discovery::{
        common_paths::CommonPathDiscovery, headers::HeaderDiscovery, js::JsDiscovery,
        robots::RobotsDiscovery, sitemap::SitemapDiscovery, swagger::SwaggerDiscovery,
    },
    error::CapturedError,
    http_client::HttpClient,
    progress_tracker::{ProgressConfig, ProgressTracker},
    reports::{Finding, Reporter},
    scanner::{
        api_security::ApiSecurityScanner, cors::CorsScanner, csp::CspScanner,
        cve_templates::CveTemplateScanner, graphql::GraphqlScanner, jwt::JwtScanner,
        mass_assignment::MassAssignmentScanner, oauth_oidc::OAuthOidcScanner,
        openapi::OpenApiScanner, rate_limit::RateLimitScanner, websocket::WebSocketScanner,
        Scanner,
    },
};

// ── Public surface ─────────────────────────────────────────────────────────────

/// Everything produced by a completed run.
#[derive(Debug, Default)]
pub struct RunResult {
    /// Deduplicated, sorted list of findings across all scanners + URLs.
    pub findings: Vec<Finding>,
    /// Every non-fatal error encountered during the run.
    pub errors: Vec<CapturedError>,
    /// Wall-clock time for the full run.
    pub elapsed: Duration,
    /// How many URLs were actually scanned (may be < input list due to cap).
    pub scanned: usize,
    /// How many URLs were skipped (cap or dedup).
    pub skipped: usize,
    /// Runtime metrics captured during the run.
    pub metrics: RuntimeMetrics,
}

/// Runtime metrics emitted in report metadata.
#[derive(Debug, Clone, Default, serde::Serialize, serde::Deserialize)]
pub struct RuntimeMetrics {
    /// Total HTTP requests sent (includes retry attempts).
    pub http_requests: u64,
    /// Total retry attempts performed by the transport layer.
    pub http_retries: u64,
    /// Finding counts grouped by scanner name.
    pub scanner_findings: BTreeMap<String, usize>,
    /// Error counts grouped by scanner name.
    pub scanner_errors: BTreeMap<String, usize>,
}

#[derive(Debug, Default, Clone)]
struct ScannerRunStats {
    findings: usize,
    errors: usize,
}

type ScannerStatsMap = BTreeMap<String, ScannerRunStats>;
type StreamFindingKey = (String, String);
type StreamSeenSet = Arc<Mutex<HashSet<StreamFindingKey>>>;

#[derive(Debug, Default, Clone, Copy)]
struct UrlScanSummary {
    findings: usize,
    critical: usize,
    high: usize,
    medium: usize,
}

/// Entry point called from `main`.
pub async fn run(
    urls: Vec<String>,
    config: Arc<Config>,
    http_client: Arc<HttpClient>,
    http_client_b: Option<Arc<HttpClient>>,
    reporter: Arc<Reporter>,
    _quiet: bool,
) -> RunResult {
    let start = Instant::now();

    // ── 1. Normalise + deduplicate ────────────────────────────────────────────
    let (unique_seeds, skipped_dedup) = dedup(urls);
    info!(
        seeds = unique_seeds.len(),
        discovery_enabled = !config.no_discovery,
        active_checks = config.active_checks,
        "Scan lifecycle: seeds prepared"
    );

    // ── 2. Discovery phase with per-site cap ────────────────────────────────
    let (discovered, mut discovery_errors, skipped_cap) = if config.no_discovery {
        (Vec::new(), Vec::new(), 0usize)
    } else {
        run_discovery_per_site(&unique_seeds, &config, &http_client).await
    };
    if config.no_discovery {
        info!(
            seeds = unique_seeds.len(),
            "Discovery skipped (--no-discovery)"
        );
    } else {
        info!(
            discovered = discovered.len() + unique_seeds.len(),
            "Discovery complete"
        );
    }

    let mut merged = unique_seeds;
    merged.extend(discovered);
    let (work_list, skipped_merged) = dedup(merged);

    info!(
        discovered = work_list.len(),
        skipped_dedup, skipped_merged, "Scan lifecycle: discovery merged"
    );

    let scanned = work_list.len();
    let skipped = skipped_dedup + skipped_merged + skipped_cap;

    if scanned == 0 {
        return RunResult {
            elapsed: start.elapsed(),
            skipped,
            ..Default::default()
        };
    }

    // ── 5. Shared state ───────────────────────────────────────────────────────
    let semaphore = Arc::new(Semaphore::new(config.concurrency));
    let scanners = build_scanners(&config, http_client_b.clone());
    let scanner_names: Vec<&str> = scanners.iter().map(|s| s.name()).collect();
    info!(
        scanner_count = scanners.len(),
        scanners = ?scanner_names,
        concurrency = config.concurrency,
        "Scan lifecycle: scanner registry ready"
    );

    // Progress tracking
    let tracker = Arc::new(ProgressTracker::with_config(ProgressConfig {
        total: scanned,
        tty_update_frequency: 1,
        non_tty_update_frequency: 1,
        show_elapsed: false,
        show_eta: false,
        show_rate: false,
        prefix: "".to_string(),
        show_details: false,
    }));

    // mpsc channels — workers send back results; main task collects
    let (finding_tx, mut finding_rx) = mpsc::unbounded_channel::<Vec<Finding>>();
    let (error_tx, mut error_rx) = mpsc::unbounded_channel::<Vec<CapturedError>>();
    let (scanner_stats_tx, mut scanner_stats_rx) = mpsc::unbounded_channel::<ScannerStatsMap>();
    let stream_seen: StreamSeenSet = Arc::new(Mutex::new(HashSet::new()));

    // ── 6. Spawn worker tasks ─────────────────────────────────────────────────
    let mut join_set: JoinSet<()> = JoinSet::new();

    info!(
        started_at = %chrono::Local::now().format("%Y-%m-%d %H:%M:%S"),
        scanned,
        "Scan started"
    );

    for url in work_list {
        let sem = Arc::clone(&semaphore);
        let client = Arc::clone(&http_client);
        let scanners = scanners.clone();
        let ftx = finding_tx.clone();
        let etx = error_tx.clone();
        let stx = scanner_stats_tx.clone();
        let cfg = Arc::clone(&config);
        let rpt = Arc::clone(&reporter);
        let stream_seen = Arc::clone(&stream_seen);
        let progress_handle = tracker.handle();

        join_set.spawn(async move {
            let _permit = match sem.acquire().await {
                Ok(p) => p,
                Err(e) => {
                    error!(url = %url, "Semaphore closed: {e}");
                    return;
                }
            };

            let (url_summary, scanner_stats) = scan_url_with_results(
                url.clone(),
                &client,
                &scanners,
                &cfg,
                &rpt,
                (ftx.clone(), etx.clone()),
                stream_seen,
            )
            .await;

            if !scanner_stats.is_empty() {
                let _ = stx.send(scanner_stats);
            }

            // Build summary message for detailed logging
            let mut msg = url.clone();
            if url_summary.findings > 0 {
                msg.push_str(&format!(" | 🔍 {} findings", url_summary.findings));
                if url_summary.critical > 0 {
                    msg.push_str(&format!(" (🔴 {}C", url_summary.critical));
                }
                if url_summary.high > 0 {
                    msg.push_str(&format!(" 🟠 {}H", url_summary.high));
                }
                if url_summary.medium > 0 {
                    msg.push_str(&format!(" 🟡 {}M", url_summary.medium));
                }
                if url_summary.critical > 0 || url_summary.high > 0 || url_summary.medium > 0 {
                    msg.push(')');
                }
            } else {
                msg.push_str(" | ✅ Clean");
            }

            // Progress increment (details suppressed by show_details=false)
            progress_handle.increment(Some(&msg)).await;
        });
    }

    // Drop the sender halves we kept in main; workers hold their own clones.
    drop(finding_tx);
    drop(error_tx);
    drop(scanner_stats_tx);

    // ── 7. Collect results while workers run ──────────────────────────────────
    let mut findings: Vec<Finding> = Vec::new();
    let mut errors: Vec<CapturedError> = Vec::new();
    let mut scanner_stats: ScannerStatsMap = BTreeMap::new();
    errors.append(&mut discovery_errors);

    loop {
        tokio::select! {
            Some(result) = join_set.join_next() => {
                match result {
                    Ok(()) => {}
                    Err(e) => error!("Worker task panicked: {e}"),
                }
            }
            Some(batch) = finding_rx.recv() => {
                findings.extend(batch);
            }
            Some(batch) = error_rx.recv() => {
                errors.extend(batch);
            }
            Some(batch) = scanner_stats_rx.recv() => {
                merge_scanner_stats(&mut scanner_stats, batch);
            }
            else => break,
        }
    }

    // ── 8. Post-process ───────────────────────────────────────────────────────
    tracker.finish().await;

    findings = crate::reports::dedup_findings(findings);
    sort_findings(&mut findings);
    dedup_errors(&mut errors);

    let elapsed = start.elapsed();
    let primary_http_metrics = http_client.runtime_metrics();
    let secondary_http_metrics = http_client_b
        .as_ref()
        .map(|client| client.runtime_metrics())
        .unwrap_or_default();

    let mut scanner_findings = BTreeMap::new();
    let mut scanner_errors = BTreeMap::new();
    for (name, stats) in scanner_stats {
        scanner_findings.insert(name.clone(), stats.findings);
        scanner_errors.insert(name, stats.errors);
    }

    info!(
        findings = findings.len(),
        errors = errors.len(),
        scanned,
        skipped,
        elapsed_ms = elapsed.as_millis(),
        "Scan lifecycle: completed"
    );

    info!(
        finished_at = %chrono::Local::now().format("%Y-%m-%d %H:%M:%S"),
        findings = findings.len(),
        scanned,
        elapsed_secs = elapsed.as_secs_f64(),
        "Scan finished"
    );

    RunResult {
        findings,
        errors,
        elapsed,
        scanned,
        skipped,
        metrics: RuntimeMetrics {
            http_requests: primary_http_metrics.requests_sent
                + secondary_http_metrics.requests_sent,
            http_retries: primary_http_metrics.retries_performed
                + secondary_http_metrics.retries_performed,
            scanner_findings,
            scanner_errors,
        },
    }
}

// ── Per-URL scan ───────────────────────────────────────────────────────────────

async fn scan_url_with_results(
    url: String,
    client: &HttpClient,
    scanners: &[RegisteredScanner],
    config: &Config,
    reporter: &Reporter,
    channels: (
        mpsc::UnboundedSender<Vec<Finding>>,
        mpsc::UnboundedSender<Vec<CapturedError>>,
    ),
    stream_seen: StreamSeenSet,
) -> (UrlScanSummary, ScannerStatsMap) {
    debug!(url = %url, scanners = scanners.len(), "Scanning URL");

    let mut scanner_set: JoinSet<(String, Vec<Finding>, Vec<CapturedError>)> = JoinSet::new();
    let mut summary = UrlScanSummary::default();
    let mut scanner_stats: ScannerStatsMap = BTreeMap::new();

    for scanner in scanners {
        let scanner_name = scanner.name().to_string();
        let s = Arc::clone(&scanner.scanner);
        let u = url.clone();
        let client = client.clone();
        let cfg = config.clone();

        scanner_set.spawn(async move {
            let (findings, errors) = s.scan(&u, &client, &cfg).await;
            (scanner_name, findings, errors)
        });
    }

    while let Some(result) = scanner_set.join_next().await {
        match result {
            Ok((scanner_name, mut f, e)) => {
                let stats = scanner_stats.entry(scanner_name).or_default();
                stats.findings += f.len();
                stats.errors += e.len();

                summary.findings += f.len();
                summary.critical += f
                    .iter()
                    .filter(|x| matches!(x.severity, crate::reports::Severity::Critical))
                    .count();
                summary.high += f
                    .iter()
                    .filter(|x| matches!(x.severity, crate::reports::Severity::High))
                    .count();
                summary.medium += f
                    .iter()
                    .filter(|x| matches!(x.severity, crate::reports::Severity::Medium))
                    .count();

                for finding in &mut f {
                    if finding.url.is_empty() {
                        finding.url = url.clone();
                    }
                }
                if reporter.stream_enabled() {
                    let mut seen = stream_seen.lock().await;
                    for finding in &f {
                        if seen.insert((finding.url.clone(), finding.check.clone())) {
                            reporter.flush_finding(finding);
                        }
                    }
                }
                if !f.is_empty() {
                    let (ftx, _) = &channels;
                    let _ = ftx.send(f);
                }
                if !e.is_empty() {
                    let (_, etx) = &channels;
                    let _ = etx.send(e);
                }
            }
            Err(join_err) => {
                let ce = CapturedError::internal(format!("Scanner panic on {url}: {join_err}"));
                let (_, etx) = &channels;
                let _ = etx.send(vec![ce]);
            }
        }
    }

    (summary, scanner_stats)
}

// ── Scanner registry ───────────────────────────────────────────────────────────

fn build_scanners(
    config: &Config,
    http_client_b: Option<Arc<HttpClient>>,
) -> Vec<RegisteredScanner> {
    let mut scanners: Vec<RegisteredScanner> = Vec::new();

    if config.toggles.cors {
        scanners.push(RegisteredScanner::new(Arc::new(CorsScanner::new(config))));
    }
    if config.toggles.csp {
        scanners.push(RegisteredScanner::new(Arc::new(CspScanner::new(config))));
    }
    if config.toggles.graphql {
        scanners.push(RegisteredScanner::new(Arc::new(GraphqlScanner::new(
            config,
        ))));
    }
    if config.toggles.api_security {
        scanners.push(RegisteredScanner::new(Arc::new(ApiSecurityScanner::new(
            config,
            http_client_b.clone(),
        ))));
    }
    if config.toggles.jwt {
        scanners.push(RegisteredScanner::new(Arc::new(JwtScanner::new(config))));
    }
    if config.toggles.openapi {
        scanners.push(RegisteredScanner::new(Arc::new(OpenApiScanner::new(
            config,
        ))));
    }
    if config.active_checks {
        if config.toggles.mass_assignment {
            scanners.push(RegisteredScanner::new(Arc::new(
                MassAssignmentScanner::new(config),
            )));
        }
        if config.toggles.oauth_oidc {
            scanners.push(RegisteredScanner::new(Arc::new(OAuthOidcScanner::new(
                config,
            ))));
        }
        if config.toggles.rate_limit {
            scanners.push(RegisteredScanner::new(Arc::new(RateLimitScanner::new(
                config,
            ))));
        }
        if config.toggles.cve_templates {
            scanners.push(RegisteredScanner::new(Arc::new(CveTemplateScanner::new(
                config,
            ))));
        }
        if config.toggles.websocket {
            scanners.push(RegisteredScanner::new(Arc::new(WebSocketScanner::new(
                config,
            ))));
        }
    }

    if scanners.is_empty() {
        warn!("All scanners disabled");
    } else if scanners.len() > 1 && should_shuffle_scanners() {
        // Reduce deterministic scanner ordering fingerprints across runs.
        let mut rng = rand::thread_rng();
        scanners.shuffle(&mut rng);
    }

    scanners
}

#[derive(Clone)]
struct RegisteredScanner {
    scanner: Arc<dyn Scanner>,
}

impl RegisteredScanner {
    fn new(scanner: Arc<dyn Scanner>) -> Self {
        Self { scanner }
    }

    fn name(&self) -> &'static str {
        self.scanner.name()
    }
}

// ── Helpers ────────────────────────────────────────────────────────────────────

fn dedup(raw: Vec<String>) -> (Vec<String>, usize) {
    let mut seen = HashSet::with_capacity(raw.len());
    let mut unique = Vec::with_capacity(raw.len());
    let mut dropped = 0usize;

    for raw_url in raw {
        let canonical = match canonicalise(&raw_url) {
            Some(c) => c,
            None => {
                debug!(url = %raw_url, "URL canonicalization failed; using raw value");
                raw_url.clone()
            }
        };

        if seen.insert(canonical.clone()) {
            unique.push(canonical);
        } else {
            dropped += 1;
            debug!(url = %raw_url, "Duplicate URL dropped");
        }
    }

    (unique, dropped)
}

fn canonicalise(raw: &str) -> Option<String> {
    let mut u = Url::parse(raw).ok()?;

    let host = u.host_str()?.to_ascii_lowercase();
    u.set_host(Some(&host)).ok()?;

    let default_port = match u.scheme() {
        "https" => Some(443),
        "http" => Some(80),
        _ => None,
    };
    if u.port() == default_port {
        u.set_port(None).ok()?;
    }

    u.set_fragment(None);

    let path = u.path().to_owned();
    if path.len() > 1 && path.ends_with('/') {
        u.set_path(path.trim_end_matches('/'));
    }

    if let Some(query) = u.query() {
        let mut pairs: Vec<(String, String)> = url::form_urlencoded::parse(query.as_bytes())
            .map(|(k, v)| (k.into_owned(), v.into_owned()))
            .collect();
        if pairs.is_empty() {
            u.set_query(None);
        } else {
            pairs.sort_unstable();
            let mut serializer = url::form_urlencoded::Serializer::new(String::new());
            for (k, v) in pairs {
                serializer.append_pair(&k, &v);
            }
            let normalised_query = serializer.finish();
            u.set_query(Some(&normalised_query));
        }
    }

    Some(u.to_string())
}

// ── Discovery orchestration ─────────────────────────────────────────────────

async fn run_discovery_per_site(
    seeds: &[String],
    config: &Config,
    client: &HttpClient,
) -> (Vec<String>, Vec<CapturedError>, usize) {
    const MAX_SITEMAPS: usize = 5;
    const MAX_SCRIPTS: usize = 10;
    let discovery_timeout_secs = config.politeness.timeout_secs.saturating_mul(2).max(1);
    let discovery_timeout = Duration::from_secs(discovery_timeout_secs);

    let mut all_discovered: HashSet<String> = HashSet::new();
    let mut all_errors: Vec<CapturedError> = Vec::new();
    let mut all_capped_dropped = 0usize;

    let sites = group_seeds_by_site(seeds);

    for (base, (host, site_seeds)) in sites {
        let js_seed = match site_seeds.first() {
            Some(s) => s.as_str(),
            None => continue,
        };

        let mut site_discovered: HashSet<String> = HashSet::new();
        let mut errors: Vec<CapturedError> = Vec::new();
        let robots = RobotsDiscovery::new(client, &base, &host);
        let sitemap = SitemapDiscovery::new(client, &base, &host, MAX_SITEMAPS);
        let swagger = SwaggerDiscovery::new(client, &base, &host);
        let js = JsDiscovery::new(client, js_seed, &host, MAX_SCRIPTS);
        let headers = HeaderDiscovery::new(client, &base, &host);
        let common_paths = CommonPathDiscovery::new(client, &base, config.concurrency, Vec::new());

        let robots_fut =
            run_discovery_with_timeout(&base, "robots", discovery_timeout, robots.run());
        let sitemap_fut =
            run_discovery_with_timeout(&base, "sitemap", discovery_timeout, sitemap.run());
        let swagger_fut =
            run_discovery_with_timeout(&base, "swagger", discovery_timeout, swagger.run());
        let js_fut = run_discovery_with_timeout(&base, "js", discovery_timeout, js.run());
        let headers_fut =
            run_discovery_with_timeout(&base, "headers", discovery_timeout, headers.run());
        let common_paths_fut = run_discovery_with_timeout(
            &base,
            "common-paths",
            discovery_timeout,
            common_paths.run(),
        );

        let (
            (robots_paths, robots_errs),
            (sitemap_paths, sitemap_errs),
            (swagger_paths, swagger_errs),
            (js_paths, js_errs),
            (header_paths, header_errs),
            (common_paths, common_errs),
        ) = tokio::join!(
            robots_fut,
            sitemap_fut,
            swagger_fut,
            js_fut,
            headers_fut,
            common_paths_fut
        );

        errors.extend(robots_errs);
        insert_paths(&base, robots_paths, &mut site_discovered);

        errors.extend(sitemap_errs);
        insert_paths(&base, sitemap_paths, &mut site_discovered);

        errors.extend(swagger_errs);
        insert_paths(&base, swagger_paths, &mut site_discovered);

        errors.extend(js_errs);
        insert_paths(&base, js_paths, &mut site_discovered);

        errors.extend(header_errs);
        insert_paths(&base, header_paths, &mut site_discovered);

        errors.extend(common_errs);
        insert_paths(&base, common_paths, &mut site_discovered);

        let max_per_site = if config.max_endpoints == 0 {
            usize::MAX
        } else {
            config.max_endpoints
        };

        let site_urls: Vec<String> = site_discovered.into_iter().collect();
        let capped_count = site_urls.len().min(max_per_site);
        let dropped_by_cap = site_urls.len().saturating_sub(capped_count);
        all_capped_dropped += dropped_by_cap;

        if site_urls.len() > max_per_site {
            debug!(
                site = %host,
                discovered = site_urls.len(),
                capped = capped_count,
                dropped_by_cap,
                "Site endpoints capped"
            );
        }

        all_discovered.extend(site_urls.into_iter().take(capped_count));
        all_errors.extend(errors);
    }

    let urls = all_discovered.into_iter().collect();
    (urls, all_errors, all_capped_dropped)
}

fn group_seeds_by_site(seeds: &[String]) -> BTreeMap<String, (String, Vec<String>)> {
    let mut sites: BTreeMap<String, (String, Vec<String>)> = BTreeMap::new();

    for seed in seeds {
        let parsed = match Url::parse(seed) {
            Ok(u) => u,
            Err(_) => continue,
        };

        let host = match parsed.host_str() {
            Some(h) => h.to_string(),
            None => continue,
        };

        let base = {
            let mut b = format!("{}://{}", parsed.scheme(), host);
            if let Some(port) = parsed.port() {
                b.push_str(&format!(":{port}"));
            }
            b
        };

        sites
            .entry(base)
            .and_modify(|(_, list)| list.push(seed.clone()))
            .or_insert_with(|| (host, vec![seed.clone()]));
    }

    sites
}

fn insert_paths(base: &str, paths: HashSet<String>, out: &mut HashSet<String>) {
    let base = base.trim_end_matches('/');
    for path in paths {
        let url = format!("{base}{path}");
        out.insert(url);
    }
}

async fn run_discovery_with_timeout<F>(
    base: &str,
    step: &'static str,
    timeout: Duration,
    fut: F,
) -> (HashSet<String>, Vec<CapturedError>)
where
    F: Future<Output = (HashSet<String>, Vec<CapturedError>)>,
{
    match tokio::time::timeout(timeout, fut).await {
        Ok((paths, errs)) => (paths, errs),
        Err(_) => (
            HashSet::new(),
            vec![CapturedError::from_str(
                format!("discovery/{step}"),
                Some(base.to_string()),
                format!(
                    "Discovery step '{step}' timed out after {}s",
                    timeout.as_secs()
                ),
            )],
        ),
    }
}

fn sort_findings(findings: &mut [Finding]) {
    findings.sort_by(|a, b| {
        b.severity
            .rank()
            .cmp(&a.severity.rank())
            .then_with(|| a.url.cmp(&b.url))
            .then_with(|| a.check.cmp(&b.check))
    });
}

fn dedup_errors(errors: &mut Vec<CapturedError>) {
    let mut seen = HashSet::new();
    errors.retain(|error| {
        seen.insert((
            error.context.clone(),
            error.url.clone(),
            error.error_type.clone(),
            error.message.clone(),
        ))
    });
}

fn merge_scanner_stats(target: &mut ScannerStatsMap, batch: ScannerStatsMap) {
    for (name, stats) in batch {
        let entry = target.entry(name).or_default();
        entry.findings += stats.findings;
        entry.errors += stats.errors;
    }
}

fn should_shuffle_scanners() -> bool {
    if cfg!(test) {
        return false;
    }
    // Integration tests run the library as a normal dependency, so cfg(test)
    // is not always set. RUST_TEST_THREADS is present in cargo test binaries.
    if std::env::var_os("RUST_TEST_THREADS").is_some() {
        return false;
    }
    std::env::var_os("APIHUNTER_DETERMINISTIC_SCANNER_ORDER").is_none()
}