apif-utils 0.2.1

Utility functions for .apif/.gctf test file processing
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
//! gRPC method and protobuf message field coverage collector.
//!
//! Tracks which gRPC service/method calls were made during test execution
//! and which protobuf message fields were covered by assertions.

use prost_reflect::{DescriptorPool, MessageDescriptor};
use serde::{Deserialize, Serialize};
use std::collections::{HashMap, HashSet};
use std::sync::{Arc, Mutex};

/// Coverage data for a single file.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CoverageFile {
    pub uri: String,
    pub statements: CoverageStats,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub branches: Option<CoverageStats>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub functions: Option<CoverageStats>,
    #[serde(skip_serializing_if = "Option::is_none")]
    pub fields: Option<CoverageStats>,
}

/// Coverage statistics (covered vs total).
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CoverageStats {
    pub covered: usize,
    pub total: usize,
}

/// Coverage data for a protobuf message type's fields.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct MessageFieldCoverage {
    pub message_type: String,
    pub covered_fields: Vec<String>,
    pub total_fields: usize,
}

/// Full coverage report with file and message-level statistics.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CoverageReport {
    pub files: Vec<CoverageFile>,
    pub messages: Vec<MessageFieldCoverage>,
    pub summary: CoverageStats,
    pub field_summary: CoverageStats,
}

/// Collects gRPC method call and protobuf field coverage during test execution.
#[derive(Debug, Clone)]
pub struct CoverageCollector {
    calls: Arc<Mutex<HashMap<String, HashMap<String, u64>>>>,
    pool: Arc<Mutex<DescriptorPool>>,
    fields_covered: Arc<Mutex<HashMap<String, HashSet<String>>>>,
}

impl CoverageCollector {
    pub fn new() -> Self {
        Self {
            calls: Arc::new(Mutex::new(HashMap::new())),
            pool: Arc::new(Mutex::new(DescriptorPool::new())),
            fields_covered: Arc::new(Mutex::new(HashMap::new())),
        }
    }

    pub fn record_call(&self, service: &str, method: &str) {
        let mut calls = self.calls.lock().unwrap_or_else(|e| e.into_inner());
        let service_calls = calls.entry(service.to_string()).or_default();
        *service_calls.entry(method.to_string()).or_insert(0) += 1;
    }

    pub fn record_fields_from_json(&self, message_type: &str, json: &serde_json::Value) {
        let mut fields = self
            .fields_covered
            .lock()
            .unwrap_or_else(|e| e.into_inner());
        let message_fields = fields.entry(message_type.to_string()).or_default();
        Self::extract_fields_from_json(json, message_fields, "");
    }

    fn extract_fields_from_json(
        json: &serde_json::Value,
        fields: &mut HashSet<String>,
        prefix: &str,
    ) {
        if let serde_json::Value::Object(map) = json {
            for (key, value) in map {
                let field_path = if prefix.is_empty() {
                    key.clone()
                } else {
                    format!("{}.{}", prefix, key)
                };
                fields.insert(field_path.clone());
                Self::extract_fields_from_json(value, fields, &field_path);
            }
        } else if let serde_json::Value::Array(arr) = json {
            for item in arr {
                Self::extract_fields_from_json(item, fields, prefix);
            }
        }
    }

    pub fn register_pool(&self, other: &DescriptorPool) {
        let mut pool = self.pool.lock().unwrap_or_else(|e| e.into_inner());
        for file in other.files() {
            let _ = pool.add_file_descriptor_proto(file.file_descriptor_proto().clone());
        }
    }

    fn count_message_fields(pool: &DescriptorPool, message_type: &str) -> usize {
        if let Some(msg) = pool.get_message_by_name(message_type) {
            Self::count_fields_recursive(&msg)
        } else {
            0
        }
    }

    /// Count fields the way `extract_fields_from_json` records covered ones:
    /// every field contributes its own dotted path, and message-typed fields
    /// additionally contribute the nested paths of their sub-message. Without
    /// this the denominator only counted top-level fields while the numerator
    /// counted nested `parent.child` paths, understating the total.
    fn count_fields_recursive(msg: &MessageDescriptor) -> usize {
        fn count(msg: &MessageDescriptor, visited: &mut HashSet<String>) -> usize {
            // Guard against recursive message types (e.g. a tree node whose
            // field points back at its own type) to avoid unbounded recursion.
            if !visited.insert(msg.full_name().to_string()) {
                return 0;
            }
            let mut total = 0;
            for field in msg.fields() {
                total += 1;
                // Recurse into nested messages, but not map entries: a map's
                // keys are dynamic and can't be enumerated from the schema.
                if !field.is_map()
                    && let prost_reflect::Kind::Message(sub) = field.kind()
                {
                    total += count(&sub, visited);
                }
            }
            visited.remove(msg.full_name());
            total
        }
        count(msg, &mut HashSet::new())
    }

    pub fn generate_json_report(&self) -> CoverageReport {
        let calls = self.calls.lock().unwrap_or_else(|e| e.into_inner());
        let pool = self.pool.lock().unwrap_or_else(|e| e.into_inner());
        let fields_covered = self
            .fields_covered
            .lock()
            .unwrap_or_else(|e| e.into_inner());

        let mut files = Vec::new();
        let mut messages = Vec::new();
        let mut total_covered = 0;
        let mut total_methods = 0;
        let mut total_fields_covered = 0;
        let mut total_fields = 0;

        // Method coverage - deduplicated iteration pattern
        let mut services: Vec<_> = pool.services().collect();
        services.sort_by(|a, b| a.name().cmp(b.name()));

        for service in services {
            let service_name = service.name();
            if service_name.contains("reflection") {
                continue;
            }

            let methods: Vec<_> = service.methods().collect();
            // Calls are recorded under the fully-qualified service name
            // ("package.Service", see runner.rs). Look up with the same
            // FQN so services inside a proto `package` aren't reported 0%.
            let called_methods = calls.get(service.full_name()).cloned().unwrap_or_default();

            let covered = methods
                .iter()
                .filter(|m| called_methods.get(m.name()).unwrap_or(&0) > &0)
                .count();
            let total = methods.len();

            if total > 0 {
                total_covered += covered;
                total_methods += total;

                files.push(CoverageFile {
                    uri: format!("grpc://{}", service_name),
                    statements: CoverageStats { covered, total },
                    branches: None,
                    functions: Some(CoverageStats { covered, total }),
                    fields: None,
                });
            }
        }

        // Message field coverage
        let mut all_message_types: HashSet<String> = HashSet::new();
        for message_type in fields_covered.keys() {
            all_message_types.insert(message_type.clone());
        }

        let mut sorted_messages: Vec<_> = all_message_types.into_iter().collect();
        sorted_messages.sort();

        for message_type in sorted_messages {
            let covered = fields_covered
                .get(&message_type)
                .map(|s| s.len())
                .unwrap_or(0);
            let total = Self::count_message_fields(&pool, &message_type);

            if total > 0 {
                total_fields_covered += covered.min(total);
                total_fields += total;

                let covered_fields: Vec<String> = fields_covered
                    .get(&message_type)
                    .map(|s| {
                        let mut v: Vec<_> = s.iter().cloned().collect();
                        v.sort();
                        v
                    })
                    .unwrap_or_default();

                messages.push(MessageFieldCoverage {
                    message_type,
                    covered_fields,
                    total_fields: total,
                });
            }
        }

        CoverageReport {
            files,
            messages,
            summary: CoverageStats {
                covered: total_covered,
                total: total_methods,
            },
            field_summary: CoverageStats {
                covered: total_fields_covered,
                total: total_fields,
            },
        }
    }

    pub fn generate_text_report(&self) -> String {
        let calls = self.calls.lock().unwrap_or_else(|e| e.into_inner());
        let pool = self.pool.lock().unwrap_or_else(|e| e.into_inner());
        let fields_covered = self
            .fields_covered
            .lock()
            .unwrap_or_else(|e| e.into_inner());

        let mut report = String::new();
        report.push_str("--- gRPC API Coverage Report ---\n\n");

        // Method coverage
        let mut services: Vec<_> = pool.services().collect();
        services.sort_by(|a, b| a.name().cmp(b.name()));

        if services.is_empty() {
            report.push_str("No services found in descriptors.\n");
            return report;
        }

        for service in services {
            let service_name = service.name();
            if service_name == "grpc.reflection.v1alpha.ServerReflection"
                || service_name == "grpc.reflection.v1.ServerReflection"
            {
                continue;
            }

            report.push_str(&format!("Service: {}\n", service_name));

            // Match the fully-qualified name used when recording calls.
            let called_methods = calls.get(service.full_name()).cloned().unwrap_or_default();

            let mut methods: Vec<_> = service.methods().collect();
            methods.sort_by(|a, b| a.name().cmp(b.name()));

            let mut covered_count = 0;
            let total_count = methods.len();

            for method in methods {
                let method_name = method.name();
                let count = called_methods.get(method_name).unwrap_or(&0);

                let status = if *count > 0 {
                    covered_count += 1;
                    format!("✅ ({} calls)", count)
                } else {
                    "❌ (0 calls)".to_string()
                };

                report.push_str(&format!("  - {}: {}\n", method_name, status));
            }

            let coverage_pct = if total_count > 0 {
                (covered_count as f64 / total_count as f64) * 100.0
            } else {
                0.0
            };

            report.push_str(&format!(
                "  Coverage: {:.1}% ({}/{})\n\n",
                coverage_pct, covered_count, total_count
            ));
        }

        // Message field coverage
        if !fields_covered.is_empty() {
            report.push_str("--- Message Field Coverage ---\n\n");

            let mut message_types: Vec<_> = fields_covered.keys().cloned().collect();
            message_types.sort();

            for message_type in message_types {
                let covered = fields_covered
                    .get(&message_type)
                    .map(|s| s.len())
                    .unwrap_or(0);
                let total = Self::count_message_fields(&pool, &message_type);

                if total > 0 {
                    let pct = (covered.min(total) as f64 / total as f64) * 100.0;
                    let status = if pct >= 100.0 {
                        ""
                    } else if pct > 0.0 {
                        "⚠️"
                    } else {
                        ""
                    };
                    report.push_str(&format!(
                        "{} {} ({}/{})\n",
                        status,
                        message_type,
                        covered.min(total),
                        total
                    ));
                }
            }
        }

        report
    }
}

impl Default for CoverageCollector {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use prost_reflect::prost_types::{
        DescriptorProto, FileDescriptorProto, MethodDescriptorProto, ServiceDescriptorProto,
    };

    /// Build a pool with a service inside a proto `package`, so its
    /// fully-qualified name ("my.pkg.Greeter") differs from its short name.
    fn pool_with_packaged_service() -> DescriptorPool {
        let mut pool = DescriptorPool::new();
        let file = FileDescriptorProto {
            name: Some("test.proto".to_string()),
            package: Some("my.pkg".to_string()),
            message_type: vec![DescriptorProto {
                name: Some("Empty".to_string()),
                ..Default::default()
            }],
            service: vec![ServiceDescriptorProto {
                name: Some("Greeter".to_string()),
                method: vec![MethodDescriptorProto {
                    name: Some("SayHello".to_string()),
                    input_type: Some(".my.pkg.Empty".to_string()),
                    output_type: Some(".my.pkg.Empty".to_string()),
                    ..Default::default()
                }],
                ..Default::default()
            }],
            ..Default::default()
        };
        pool.add_file_descriptor_proto(file).unwrap();
        pool
    }

    // Bug 6: calls are recorded under the fully-qualified service name, so
    // coverage lookup must use the same FQN or packaged services report 0%.
    #[test]
    fn coverage_matches_fully_qualified_service_name() {
        let collector = CoverageCollector::new();
        collector.register_pool(&pool_with_packaged_service());
        // Recorded exactly as runner.rs does: "package.Service".
        collector.record_call("my.pkg.Greeter", "SayHello");

        let report = collector.generate_json_report();
        assert_eq!(report.summary.total, 1, "one method total");
        assert_eq!(
            report.summary.covered, 1,
            "packaged service call should be counted as covered"
        );

        let text = collector.generate_text_report();
        assert!(text.contains("100.0%"), "text report: {text}");
    }

    /// Build a pool with a message that nests two levels of sub-messages:
    /// `Outer { id, inner: Inner }`, `Inner { name, addr: Addr }`,
    /// `Addr { city }`. Recursively that is 5 fields (id, inner, inner.name,
    /// inner.addr, inner.addr.city).
    fn pool_with_nested_message() -> DescriptorPool {
        use prost_reflect::prost_types::FieldDescriptorProto;
        use prost_reflect::prost_types::field_descriptor_proto::{Label, Type};

        let field =
            |name: &str, number: i32, ty: Type, type_name: Option<&str>| FieldDescriptorProto {
                name: Some(name.to_string()),
                number: Some(number),
                label: Some(Label::Optional as i32),
                r#type: Some(ty as i32),
                type_name: type_name.map(|s| s.to_string()),
                ..Default::default()
            };

        let mut pool = DescriptorPool::new();
        let file = FileDescriptorProto {
            name: Some("nested.proto".to_string()),
            message_type: vec![
                DescriptorProto {
                    name: Some("Outer".to_string()),
                    field: vec![
                        field("id", 1, Type::String, None),
                        field("inner", 2, Type::Message, Some(".Inner")),
                    ],
                    ..Default::default()
                },
                DescriptorProto {
                    name: Some("Inner".to_string()),
                    field: vec![
                        field("name", 1, Type::String, None),
                        field("addr", 2, Type::Message, Some(".Addr")),
                    ],
                    ..Default::default()
                },
                DescriptorProto {
                    name: Some("Addr".to_string()),
                    field: vec![field("city", 1, Type::String, None)],
                    ..Default::default()
                },
            ],
            ..Default::default()
        };
        pool.add_file_descriptor_proto(file).unwrap();
        pool
    }

    // Bug 2: the field-count denominator must recurse into nested messages so
    // it matches the nested dotted paths counted as covered.
    #[test]
    fn nested_message_field_count_is_recursive() {
        let pool = pool_with_nested_message();
        let outer = pool.get_message_by_name("Outer").unwrap();
        // Before the fix this returned 2 (only id, inner).
        assert_eq!(CoverageCollector::count_fields_recursive(&outer), 5);
    }

    #[test]
    fn nested_message_full_coverage_is_100_percent() {
        let collector = CoverageCollector::new();
        collector.register_pool(&pool_with_nested_message());
        collector.record_fields_from_json(
            "Outer",
            &serde_json::json!({
                "id": "x",
                "inner": { "name": "y", "addr": { "city": "z" } }
            }),
        );

        let report = collector.generate_json_report();
        assert_eq!(report.field_summary.total, 5, "recursive field total");
        assert_eq!(report.field_summary.covered, 5, "all nested fields covered");
        let msg = report
            .messages
            .iter()
            .find(|m| m.message_type == "Outer")
            .unwrap();
        assert_eq!(msg.total_fields, 5);
        assert_eq!(msg.covered_fields.len(), 5);
    }

    #[test]
    fn nested_message_partial_coverage_uses_recursive_total() {
        let collector = CoverageCollector::new();
        collector.register_pool(&pool_with_nested_message());
        // Only 3 of the 5 recursive paths are exercised (id, inner, inner.name).
        collector.record_fields_from_json(
            "Outer",
            &serde_json::json!({ "id": "x", "inner": { "name": "y" } }),
        );

        let report = collector.generate_json_report();
        assert_eq!(report.field_summary.total, 5);
        assert_eq!(report.field_summary.covered, 3);
    }
}