anofox-forecast 0.15.0

Time series forecasting library
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
//! Croston's method for intermittent demand forecasting.
//!
//! Croston's method separately forecasts demand sizes and inter-arrival times
//! using exponential smoothing, then combines them for the final forecast.

use crate::core::{Forecast, TimeSeries};
use crate::error::{ForecastError, Result};
use crate::models::{validate_series_complete, Forecaster};
use crate::utils::optimization::{nelder_mead, NelderMeadConfig};

/// Croston's method variant.
#[derive(Debug, Clone, Copy, PartialEq)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub enum CrostonVariant {
    /// Classic Croston method.
    Classic,
    /// Syntetos-Boylan Approximation (SBA) - applies bias correction.
    SBA,
    /// Syntetos-Boylan Approximation with optimized alpha.
    SBAOptimized,
}

/// Croston's method for intermittent demand forecasting.
#[derive(Debug, Clone)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct Croston {
    /// Smoothing parameter (0.0 to 1.0).
    alpha: f64,
    /// Whether to optimize alpha.
    optimize_alpha: bool,
    /// Variant of Croston's method.
    variant: CrostonVariant,
    /// Estimated demand level.
    demand_level: Option<f64>,
    /// Estimated interval level.
    interval_level: Option<f64>,
    /// Fitted values.
    #[cfg_attr(feature = "serde", serde(with = "crate::utils::persistence::nan_vec"))]
    fitted: Option<Vec<f64>>,
    /// Residuals.
    #[cfg_attr(feature = "serde", serde(with = "crate::utils::persistence::nan_vec"))]
    residuals: Option<Vec<f64>>,
    /// Original series length.
    n: usize,
}

impl Croston {
    /// Create a new Croston model with default alpha (0.1).
    pub fn new() -> Self {
        Self {
            alpha: 0.1,
            optimize_alpha: false,
            variant: CrostonVariant::Classic,
            demand_level: None,
            interval_level: None,
            fitted: None,
            residuals: None,
            n: 0,
        }
    }

    /// Create Croston model with specified alpha.
    pub fn with_alpha(mut self, alpha: f64) -> Self {
        self.alpha = alpha.clamp(0.01, 0.99);
        self.optimize_alpha = false;
        self
    }

    /// Enable alpha optimization.
    pub fn optimized(mut self) -> Self {
        self.optimize_alpha = true;
        self
    }

    /// Use SBA (Syntetos-Boylan Approximation) variant.
    pub fn sba(mut self) -> Self {
        self.variant = CrostonVariant::SBA;
        self
    }

    /// Use SBA variant with optimized alpha.
    pub fn sba_optimized(mut self) -> Self {
        self.variant = CrostonVariant::SBAOptimized;
        self.optimize_alpha = true;
        self
    }

    /// Get the estimated demand level.
    pub fn demand_level(&self) -> Option<f64> {
        self.demand_level
    }

    /// Get the estimated interval level.
    pub fn interval_level(&self) -> Option<f64> {
        self.interval_level
    }

    /// Get the current alpha value.
    pub fn alpha(&self) -> f64 {
        self.alpha
    }

    /// Get the variant being used.
    pub fn variant(&self) -> CrostonVariant {
        self.variant
    }

    /// Extract demand sizes and intervals from the series (statsforecast compatible).
    ///
    /// Demands: positive values only (x[x > 0])
    /// Intervals: for each non-zero value, count of zeros since last non-zero + 1
    ///
    /// This matches statsforecast's _demand(x) and _intervals(x) functions.
    fn extract_demands(values: &[f64]) -> (Vec<f64>, Vec<usize>) {
        // Extract positive demands (statsforecast: x[x > 0])
        let demands: Vec<f64> = values.iter().filter(|&&v| v > 0.0).copied().collect();

        // Compute intervals (statsforecast: count zeros since last non-zero + 1)
        let mut intervals = Vec::new();
        let mut zero_count = 0usize;

        for &v in values {
            if v == 0.0 {
                zero_count += 1;
            } else {
                // Non-zero value: interval = zeros since last non-zero + 1
                intervals.push(zero_count + 1);
                zero_count = 0;
            }
        }

        (demands, intervals)
    }

    /// Fit SES to a sequence and return the final level.
    fn fit_ses(values: &[f64], alpha: f64) -> f64 {
        if values.is_empty() {
            return 1.0;
        }
        let mut level = values[0];
        for &v in values.iter().skip(1) {
            level = alpha * v + (1.0 - alpha) * level;
        }
        level
    }

    /// Compute objective (MSE) for alpha optimization.
    fn compute_mse(values: &[f64], alpha: f64) -> f64 {
        let (demands, intervals) = Self::extract_demands(values);
        if demands.len() < 2 || intervals.is_empty() {
            return f64::INFINITY;
        }

        let intervals_f64: Vec<f64> = intervals.iter().map(|&i| i as f64).collect();

        // Compute one-step-ahead forecast errors for demand
        let mut demand_level = demands[0];
        let mut demand_sse = 0.0;
        for &d in demands.iter().skip(1) {
            let error = d - demand_level;
            demand_sse += error * error;
            demand_level = alpha * d + (1.0 - alpha) * demand_level;
        }

        // Compute one-step-ahead forecast errors for intervals
        let mut interval_level = intervals_f64[0];
        let mut interval_sse = 0.0;
        for &i in intervals_f64.iter().skip(1) {
            let error = i - interval_level;
            interval_sse += error * error;
            interval_level = alpha * i + (1.0 - alpha) * interval_level;
        }

        (demand_sse + interval_sse) / (demands.len() + intervals.len() - 2) as f64
    }

    /// Optimize alpha using Nelder-Mead.
    fn optimize_alpha(values: &[f64]) -> f64 {
        let objective = |params: &[f64]| {
            let alpha = params[0];
            if alpha <= 0.01 || alpha >= 0.99 {
                return f64::INFINITY;
            }
            Self::compute_mse(values, alpha)
        };

        let config = NelderMeadConfig {
            tolerance: 1e-4,
            ..Default::default()
        };

        let result = nelder_mead(objective, &[0.1], Some(&[(0.01, 0.99)]), config);
        result.optimal_point[0].clamp(0.01, 0.99)
    }

    /// Compute fitted values for the original series.
    fn compute_fitted(&self, values: &[f64], alpha: f64) -> Vec<f64> {
        let n = values.len();
        let mut fitted = vec![0.0; n];

        let (demands, intervals) = Self::extract_demands(values);
        if demands.is_empty() {
            return fitted;
        }

        let intervals_f64: Vec<f64> = intervals.iter().map(|&i| i as f64).collect();

        // Initialize levels
        let mut demand_level = demands[0];
        let mut interval_level = if intervals_f64.is_empty() {
            1.0
        } else {
            intervals_f64[0]
        };

        // Compute forecast at each point
        let mut demand_idx = 0;
        let mut _interval_idx = 0;
        let mut periods_since_demand = 0;

        for i in 0..n {
            // Compute forecast
            let forecast = self.apply_bias_correction(demand_level, interval_level, alpha);
            fitted[i] = forecast;

            // Update if this is a demand point
            if values[i] > 0.0 {
                if demand_idx > 0 {
                    demand_level = alpha * values[i] + (1.0 - alpha) * demand_level;
                    interval_level =
                        alpha * (periods_since_demand as f64) + (1.0 - alpha) * interval_level;
                    _interval_idx += 1;
                }
                demand_idx += 1;
                periods_since_demand = 0;
            }
            periods_since_demand += 1;
        }

        fitted
    }

    /// Apply bias correction based on variant.
    fn apply_bias_correction(&self, demand_level: f64, interval_level: f64, alpha: f64) -> f64 {
        let base_forecast = demand_level / interval_level.max(0.001);
        match self.variant {
            CrostonVariant::Classic => base_forecast,
            CrostonVariant::SBA | CrostonVariant::SBAOptimized => {
                // SBA bias correction factor
                base_forecast * (1.0 - alpha / 2.0)
            }
        }
    }
}

impl Default for Croston {
    fn default() -> Self {
        Self::new()
    }
}

impl Forecaster for Croston {
    fn fit(&mut self, series: &TimeSeries) -> Result<()> {
        validate_series_complete(series)?;
        let values = series.primary_values();
        self.n = values.len();

        if values.len() < 4 {
            return Err(ForecastError::InsufficientData {
                needed: 4,
                got: values.len(),
                hint: Some("Croston requires at least 4 observations for demand estimation".into()),
            });
        }

        // Extract demands and intervals
        let (demands, intervals) = Self::extract_demands(values);

        if demands.len() < 2 {
            return Err(ForecastError::ComputationError(
                "Insufficient demand occurrences (need at least 2)".to_string(),
            ));
        }

        if intervals.is_empty() {
            return Err(ForecastError::ComputationError(
                "No intervals between demands".to_string(),
            ));
        }

        // Optimize alpha if requested
        if self.optimize_alpha {
            self.alpha = Self::optimize_alpha(values);
        }

        let intervals_f64: Vec<f64> = intervals.iter().map(|&i| i as f64).collect();

        // Fit SES to demands and intervals
        self.demand_level = Some(Self::fit_ses(&demands, self.alpha));
        self.interval_level = Some(Self::fit_ses(&intervals_f64, self.alpha));

        // Compute fitted values
        let fitted = self.compute_fitted(values, self.alpha);

        // Compute residuals
        let residuals: Vec<f64> = values
            .iter()
            .zip(fitted.iter())
            .map(|(y, f)| y - f)
            .collect();

        self.fitted = Some(fitted);
        self.residuals = Some(residuals);

        Ok(())
    }

    fn predict(&self, horizon: usize) -> Result<Forecast> {
        let demand_level = self
            .demand_level
            .ok_or(ForecastError::FitRequired { model: None })?;
        let interval_level = self
            .interval_level
            .ok_or(ForecastError::FitRequired { model: None })?;

        if horizon == 0 {
            return Ok(Forecast::from_values(Vec::new()));
        }

        // Croston produces flat forecasts
        let forecast_value = self.apply_bias_correction(demand_level, interval_level, self.alpha);
        let values = vec![forecast_value; horizon];

        Ok(Forecast::from_values(values))
    }

    fn predict_with_intervals(&self, horizon: usize, level: f64) -> Result<Forecast> {
        let point_forecast = self.predict(horizon)?;

        if horizon == 0 {
            return Ok(point_forecast);
        }

        // Compute variance from residuals
        let residuals = self
            .residuals
            .as_ref()
            .ok_or(ForecastError::FitRequired { model: None })?;
        let variance = if residuals.len() > 1 {
            let mean_resid: f64 = residuals.iter().sum::<f64>() / residuals.len() as f64;
            residuals
                .iter()
                .map(|r| (r - mean_resid).powi(2))
                .sum::<f64>()
                / (residuals.len() - 1) as f64
        } else {
            1.0
        };
        let std_dev = variance.sqrt();

        let z = crate::utils::quantile_normal(0.5 + level / 2.0);

        let lower: Vec<f64> = point_forecast
            .primary()
            .iter()
            .map(|&f| f - z * std_dev)
            .collect();
        let upper: Vec<f64> = point_forecast
            .primary()
            .iter()
            .map(|&f| f + z * std_dev)
            .collect();

        Ok(Forecast::from_values_with_intervals(
            point_forecast.primary().to_vec(),
            lower,
            upper,
        ))
    }

    fn fitted_values(&self) -> Option<&[f64]> {
        self.fitted.as_deref()
    }

    fn fitted_values_with_intervals(&self, level: f64) -> Option<Forecast> {
        let fitted = self.fitted.as_ref()?;
        let residuals = self.residuals.as_ref()?;

        // Compute variance from residuals
        let valid_residuals: Vec<f64> = residuals.iter().copied().filter(|r| !r.is_nan()).collect();

        if valid_residuals.is_empty() {
            return Some(Forecast::from_values(fitted.clone()));
        }

        let n = valid_residuals.len() as f64;
        let variance = crate::simd::sum_of_squares(&valid_residuals) / n;

        if variance <= 0.0 {
            return Some(Forecast::from_values(fitted.clone()));
        }

        let z = crate::utils::quantile_normal(0.5 + level / 2.0);
        let sigma = variance.sqrt();

        let lower: Vec<f64> = fitted.iter().map(|&f| f - z * sigma).collect();
        let upper: Vec<f64> = fitted.iter().map(|&f| f + z * sigma).collect();

        Some(Forecast::from_values_with_intervals(
            fitted.clone(),
            lower,
            upper,
        ))
    }

    fn residuals(&self) -> Option<&[f64]> {
        self.residuals.as_deref()
    }

    fn name(&self) -> &str {
        match self.variant {
            CrostonVariant::Classic => {
                if self.optimize_alpha {
                    "Croston (Optimized)"
                } else {
                    "Croston"
                }
            }
            CrostonVariant::SBA => "Croston SBA",
            CrostonVariant::SBAOptimized => "Croston SBA (Optimized)",
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use chrono::{Duration, TimeZone, Utc};

    fn make_timestamps(n: usize) -> Vec<chrono::DateTime<Utc>> {
        let base = Utc.with_ymd_and_hms(2024, 1, 1, 0, 0, 0).unwrap();
        (0..n).map(|i| base + Duration::hours(i as i64)).collect()
    }

    fn make_intermittent_series() -> TimeSeries {
        let timestamps = make_timestamps(20);
        // Intermittent demand pattern: demand occurs at irregular intervals
        let values = vec![
            5.0, 0.0, 0.0, 3.0, 0.0, 0.0, 0.0, 4.0, 0.0, 2.0, 0.0, 0.0, 0.0, 0.0, 6.0, 0.0, 0.0,
            3.0, 0.0, 0.0,
        ];
        TimeSeries::univariate(timestamps, values).unwrap()
    }

    #[test]
    fn croston_basic() {
        let ts = make_intermittent_series();
        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        assert!(model.demand_level().is_some());
        assert!(model.interval_level().is_some());

        let forecast = model.predict(5).unwrap();
        assert_eq!(forecast.horizon(), 5);

        // Forecast should be positive for intermittent demand
        for &v in forecast.primary() {
            assert!(v > 0.0, "Forecast should be positive");
        }
    }

    #[test]
    fn croston_flat_forecast() {
        let ts = make_intermittent_series();
        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        let forecast = model.predict(10).unwrap();

        // Croston produces flat forecasts
        let first = forecast.primary()[0];
        for &v in forecast.primary() {
            assert!(
                (v - first).abs() < 1e-10,
                "Croston should produce flat forecasts"
            );
        }
    }

    #[test]
    fn croston_with_alpha() {
        let ts = make_intermittent_series();
        let mut model = Croston::new().with_alpha(0.2);
        model.fit(&ts).unwrap();

        assert!((model.alpha() - 0.2).abs() < 1e-10);
    }

    #[test]
    fn croston_optimized() {
        let ts = make_intermittent_series();
        let mut model = Croston::new().optimized();
        model.fit(&ts).unwrap();

        // Alpha should be within valid range
        assert!(model.alpha() > 0.0 && model.alpha() < 1.0);
    }

    #[test]
    fn croston_sba() {
        let ts = make_intermittent_series();
        let mut model = Croston::new().sba();
        model.fit(&ts).unwrap();

        assert_eq!(model.variant(), CrostonVariant::SBA);

        let forecast = model.predict(5).unwrap();
        assert_eq!(forecast.horizon(), 5);
    }

    #[test]
    fn croston_sba_lower_than_classic() {
        let ts = make_intermittent_series();

        let mut classic = Croston::new().with_alpha(0.1);
        classic.fit(&ts).unwrap();
        let classic_forecast = classic.predict(1).unwrap();

        let mut sba = Croston::new().with_alpha(0.1).sba();
        sba.fit(&ts).unwrap();
        let sba_forecast = sba.predict(1).unwrap();

        // SBA applies bias correction (1 - alpha/2), so forecast should be lower
        assert!(
            sba_forecast.primary()[0] < classic_forecast.primary()[0],
            "SBA forecast should be lower due to bias correction"
        );
    }

    #[test]
    fn croston_sba_optimized() {
        let ts = make_intermittent_series();
        let mut model = Croston::new().sba_optimized();
        model.fit(&ts).unwrap();

        assert_eq!(model.variant(), CrostonVariant::SBAOptimized);
    }

    #[test]
    fn croston_insufficient_data() {
        let timestamps = make_timestamps(3);
        let values = vec![1.0, 0.0, 2.0];
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model = Croston::new();
        assert!(matches!(
            model.fit(&ts),
            Err(ForecastError::InsufficientData { .. })
        ));
    }

    #[test]
    fn croston_no_demands() {
        let timestamps = make_timestamps(10);
        let values = vec![0.0; 10]; // All zeros
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model = Croston::new();
        assert!(model.fit(&ts).is_err());
    }

    #[test]
    fn croston_requires_fit() {
        let model = Croston::new();
        assert!(matches!(
            model.predict(5),
            Err(ForecastError::FitRequired { .. })
        ));
    }

    #[test]
    fn croston_zero_horizon() {
        let ts = make_intermittent_series();
        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        let forecast = model.predict(0).unwrap();
        assert_eq!(forecast.horizon(), 0);
    }

    #[test]
    fn croston_confidence_intervals() {
        let ts = make_intermittent_series();
        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        let forecast = model.predict_with_intervals(5, 0.95).unwrap();
        assert!(forecast.has_lower());
        assert!(forecast.has_upper());

        // Lower < point < upper
        let lower = forecast.lower_series(0).unwrap();
        let upper = forecast.upper_series(0).unwrap();
        for i in 0..5 {
            assert!(lower[i] <= forecast.primary()[i]);
            assert!(forecast.primary()[i] <= upper[i]);
        }
    }

    #[test]
    fn croston_fitted_and_residuals() {
        let ts = make_intermittent_series();
        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        assert!(model.fitted_values().is_some());
        assert!(model.residuals().is_some());
        assert_eq!(model.fitted_values().unwrap().len(), 20);
        assert_eq!(model.residuals().unwrap().len(), 20);
    }

    #[test]
    fn croston_name() {
        let classic = Croston::new();
        assert_eq!(classic.name(), "Croston");

        let optimized = Croston::new().optimized();
        assert_eq!(optimized.name(), "Croston (Optimized)");

        let sba = Croston::new().sba();
        assert_eq!(sba.name(), "Croston SBA");

        let sba_opt = Croston::new().sba_optimized();
        assert_eq!(sba_opt.name(), "Croston SBA (Optimized)");
    }

    #[test]
    fn croston_default() {
        let model = Croston::default();
        assert!((model.alpha() - 0.1).abs() < 1e-10);
        assert_eq!(model.variant(), CrostonVariant::Classic);
    }

    #[test]
    fn croston_alpha_clamped() {
        let model = Croston::new().with_alpha(2.0);
        assert!(model.alpha() <= 0.99);

        let model = Croston::new().with_alpha(-0.5);
        assert!(model.alpha() >= 0.01);
    }

    // ==================== Edge cases ====================

    #[test]
    fn croston_all_zero_demand() {
        // All zeros should error (insufficient demand occurrences)
        let timestamps = make_timestamps(20);
        let values = vec![0.0; 20];
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model = Croston::new();
        assert!(model.fit(&ts).is_err());
    }

    #[test]
    fn croston_single_nonzero_demand() {
        // Only one non-zero demand -> insufficient demand occurrences
        let timestamps = make_timestamps(10);
        let mut values = vec![0.0; 10];
        values[5] = 10.0;
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model = Croston::new();
        assert!(model.fit(&ts).is_err());
    }

    #[test]
    fn croston_very_sparse_data() {
        // >90% zeros with demand at beginning and end
        let timestamps = make_timestamps(30);
        let mut values = vec![0.0; 30];
        values[0] = 5.0;
        values[15] = 3.0;
        values[29] = 7.0;
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        let forecast = model.predict(5).unwrap();
        for &v in forecast.primary() {
            assert!(
                v > 0.0,
                "Forecast should be positive even for very sparse data"
            );
            assert!(v.is_finite(), "Forecast should be finite");
        }
    }

    #[test]
    fn croston_negative_values_ignored() {
        // Croston extracts positive demands only (v > 0.0)
        // Negative values are treated like zeros
        let timestamps = make_timestamps(20);
        let values = vec![
            5.0, -1.0, 0.0, 3.0, -2.0, 0.0, 0.0, 4.0, 0.0, 2.0, 0.0, 0.0, -3.0, 0.0, 6.0, 0.0, 0.0,
            3.0, 0.0, -1.0,
        ];
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        let forecast = model.predict(5).unwrap();
        for &v in forecast.primary() {
            assert!(v > 0.0);
        }
    }

    #[test]
    fn croston_very_long_inter_demand_intervals() {
        // Two demands separated by a very long zero interval
        let timestamps = make_timestamps(50);
        let mut values = vec![0.0; 50];
        values[0] = 10.0;
        values[49] = 10.0;
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        let forecast = model.predict(5).unwrap();
        for &v in forecast.primary() {
            assert!(v > 0.0, "Forecast should be positive");
            assert!(v.is_finite(), "Forecast should be finite");
            // With long interval, forecast rate should be small
            assert!(
                v < 10.0,
                "Forecast should be smaller than demand size due to long interval"
            );
        }
    }

    #[test]
    fn croston_two_demands_minimum() {
        // Exactly two non-zero demands (minimum for fit)
        let timestamps = make_timestamps(10);
        let mut values = vec![0.0; 10];
        values[0] = 5.0;
        values[5] = 3.0;
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        let forecast = model.predict(5).unwrap();
        assert_eq!(forecast.horizon(), 5);
        for &v in forecast.primary() {
            assert!(v > 0.0);
        }
    }

    #[test]
    fn croston_consecutive_demands() {
        // All non-zero (no intermittency)
        let timestamps = make_timestamps(10);
        let values = vec![5.0, 3.0, 4.0, 6.0, 2.0, 5.0, 3.0, 4.0, 6.0, 2.0];
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model = Croston::new();
        model.fit(&ts).unwrap();

        let forecast = model.predict(5).unwrap();
        for &v in forecast.primary() {
            assert!(v > 0.0);
        }
        // With all demands consecutive, interval ≈ 1, forecast ≈ demand level
        assert!(forecast.primary()[0] > 1.0);
    }

    #[test]
    fn croston_sba_sparse_with_different_alphas() {
        let timestamps = make_timestamps(30);
        let mut values = vec![0.0; 30];
        values[0] = 5.0;
        values[10] = 3.0;
        values[20] = 7.0;
        let ts = TimeSeries::univariate(timestamps, values).unwrap();

        let mut model_low = Croston::new().with_alpha(0.05).sba();
        model_low.fit(&ts).unwrap();
        let f_low = model_low.predict(1).unwrap();

        let mut model_high = Croston::new().with_alpha(0.5).sba();
        model_high.fit(&ts).unwrap();
        let f_high = model_high.predict(1).unwrap();

        // Both should be positive and finite
        assert!(f_low.primary()[0] > 0.0 && f_low.primary()[0].is_finite());
        assert!(f_high.primary()[0] > 0.0 && f_high.primary()[0].is_finite());
    }
}