1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
use crate::publish_evidence::PublishEvidence;
use serde::{Deserialize, Serialize};
/// Three-group dispatch classification for publishers. Dispatch order is
/// always Assets → Manager → Submitter. The one-way-door gate (historically
/// "the submitter gate") arms once any `required: true` publisher in an
/// already-run group fails, and from that point skips **both** the Manager
/// and Submitter groups — every publisher that writes a surface we cannot
/// cleanly reclaim. Only the reversible Assets group runs ungated. This is
/// why a botched blob mirror or homebrew tap push cannot burn a crates.io
/// version slot, and why a failed required blob upload no longer lets the
/// homebrew/scoop/nix/AUR/MCP one-way doors fire against an incomplete
/// release.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub enum PublisherGroup {
/// Writes uploadable bytes to systems we control end-to-end. Failures
/// are reversible via API delete (github-release, dockerhub,
/// artifactory, cloudsmith, blob).
Assets,
/// Writes to package-manager state. Server-side deletable, but
/// consumer machines may have already pulled the artifact
/// (homebrew, scoop, nix, krew, mcp, our-AUR repos, custom).
Manager,
/// Writes to a third-party submission queue, an immutable registry
/// slot, or a channel position we cannot reclaim. Gated behind the
/// Submitter gate. Rollback is informational-only for most members
/// (chocolatey, winget, snapcraft, upstream-AUR force-push), with one
/// exception: **cargo** has a real programmatic rollback. A multi-crate
/// `cargo publish` that succeeds on crate A then fails on crate B
/// records A and opts in via
/// [`Publisher::programmatic_rollback_on_failure`](crate::Publisher::programmatic_rollback_on_failure),
/// so the rollback path issues `cargo yank` for A even though the row's
/// outcome is `Failed`.
Submitter,
}
/// Per-publisher terminal state in [`PublishReport`]. Stage-level statuses
/// like `pending-moderation` / `pending-validation` / `announce-gated`
/// live on the run summary, not here.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub enum PublisherOutcome {
/// `Publisher::run` returned `Ok` and the artifact is live.
Succeeded,
/// Publisher did not execute; see [`SkipReason`] for why.
Skipped(SkipReason),
/// `Publisher::run` returned `Err`; the carried `String` is the error
/// message (already rendered via `{:#}`).
Failed(String),
/// Initially [`PublisherOutcome::Succeeded`], then revert dispatch
/// successfully reverted the action.
RolledBack,
/// Initial run succeeded but revert dispatch failed; manual
/// intervention required. The carried `String` is the rollback
/// error message.
RollbackFailed(String),
/// Rollback was skipped because the required scope token env var
/// (per `Publisher::rollback_scope_needed`) is not set in the
/// environment.
RollbackSkippedNoScope,
/// Publisher succeeded but the version is queued for moderation (chocolatey, AUR-like).
PendingModeration,
/// Publisher succeeded but a downstream validation step is still polling (winget).
PendingValidation,
/// Publisher succeeded; rollback was skipped because `--rollback=none` was set.
PublishedNoRollback,
}
impl PublisherOutcome {
/// Whether this outcome is a terminal failure of a *required* publisher —
/// the failure class that must fail the release and close the submitter
/// gate. True for [`PublisherOutcome::Failed`] (the publish itself failed)
/// and [`PublisherOutcome::RollbackFailed`] (the publish ran, rollback was
/// attempted, and the rollback also failed, leaving a half-published
/// surface needing manual intervention).
///
/// Written as an exhaustive `match` (not `matches!`) so a future
/// hard-failure variant cannot silently slip past a gate: adding one
/// forces a compile error here and a conscious classification decision.
pub fn is_required_release_failure(&self) -> bool {
match self {
PublisherOutcome::Failed(_) | PublisherOutcome::RollbackFailed(_) => true,
PublisherOutcome::Succeeded
| PublisherOutcome::Skipped(_)
| PublisherOutcome::RolledBack
| PublisherOutcome::RollbackSkippedNoScope
| PublisherOutcome::PendingModeration
| PublisherOutcome::PendingValidation
| PublisherOutcome::PublishedNoRollback => false,
}
}
}
/// Reason a publisher was [`PublisherOutcome::Skipped`]. Serialized as
/// kebab-case (e.g. `"submitter-gated"`).
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[serde(rename_all = "kebab-case")]
pub enum SkipReason {
/// Skipped because a required publisher in an already-run group
/// failed and the one-way-door gate closed before this publisher
/// could dispatch. Recorded for gated Manager AND Submitter
/// publishers (the variant keeps its historical name). Preserves
/// rollback safety by never firing an irreversible publisher past a
/// known required failure.
SubmitterGated,
/// Publisher entry absent from the workspace config; the
/// `Publisher::run` impl was never invoked.
NotConfigured,
/// Pipeline ran in `--snapshot` mode; publishers do not fire.
Snapshot,
/// Pipeline ran in `--dry-run` mode; publishers do not fire.
DryRun,
/// Pipeline ran in `--nightly` mode and this publisher opts out of
/// nightly publishes (e.g. homebrew, scoop, aur, krew, nix, every
/// announcer — the nightly skip-list).
Nightly,
/// No artifact in the current crate scope matches this publisher's
/// applicability rules (e.g. top-level homebrew_casks declared
/// `binaries: [cfgd]` but the current per-crate iteration is on
/// `cfgd-core` and has no `cfgd` binary in scope; or cloudsmith
/// targets `.deb` / `.rpm` / `.apk` but the current crate produces
/// only library archives). Distinct from `NotConfigured` (where
/// the publisher block is absent entirely) and from
/// `PublisherOutcome::Failed` (where the publisher TRIED to run
/// and hit a real error). Required Manager publishers reporting
/// `NotApplicable` MUST NOT trigger the submitter gate — there is
/// nothing to roll back, and the absence of applicable artifacts
/// is not a publish failure.
NotApplicable,
/// This version was already published to the target registry/store on a
/// prior run, so the publisher detected it and skipped re-publishing
/// (idempotent re-run). Distinct from `PublisherOutcome::Succeeded`
/// because nothing was published THIS run — and distinct from
/// `PublisherOutcome::Failed` because an already-published version is the
/// desired end-state, not an error. A publisher reporting
/// `AlreadyPublished` records NO rollback evidence: the version it found
/// was published by an earlier run (or another actor), and deleting it on
/// rollback would destroy state this run never created.
AlreadyPublished,
/// Excluded by `--skip` (the unified stage/publisher denylist) or absent
/// from a non-empty `--publishers` allowlist. The operator opted this
/// publisher out of the run; it was never invoked. Distinct from
/// `NotConfigured` (the publisher block is absent from config) and from
/// `NotApplicable` (the publisher is configured but no in-scope artifact
/// matches it) — here the config and artifacts may both be present, and the
/// publisher would otherwise have run, but the operator's selection
/// suppressed it.
Deselected,
}
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub struct PublisherResult {
pub name: String,
pub group: PublisherGroup,
pub required: bool,
pub outcome: PublisherOutcome,
pub evidence: Option<PublishEvidence>,
}
#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
pub struct PublishReport {
pub results: Vec<PublisherResult>,
#[serde(default)]
pub submitter_gated: bool,
#[serde(default)]
pub announce_gated: bool,
}
impl PublishReport {
pub fn required_failures(&self) -> usize {
self.required_failure_names().len()
}
/// Names of every *required* publisher that finished in a terminal
/// failure state ([`PublisherOutcome::is_required_release_failure`]).
/// The one filter behind [`Self::required_failures`] and the
/// required-failure exit gate ([`gate_required_failures`]), so the
/// count, the gate, and the operator-facing name list cannot diverge.
pub fn required_failure_names(&self) -> Vec<&str> {
self.results
.iter()
.filter(|r| r.required && r.outcome.is_required_release_failure())
.map(|r| r.name.as_str())
.collect()
}
/// A concise, run-wide human summary of the required failure(s) that
/// triggered a rollback — each failed required publisher rendered as
/// `<name>: <error>` and joined with `; `. Empty when no required
/// publisher failed.
///
/// Threaded into the `on_rollback` hook surface as `{{ .Reason }}` /
/// `ANODIZER_ROLLBACK_REASON` so a reverted-but-never-failed publisher's
/// hook learns WHY the unwind fired (which sibling failure), a fact
/// `{{ .Error }}` (that publisher's own revert error, empty on a clean
/// revert) cannot carry. Shares the required-failure filter with
/// [`Self::required_failure_names`] so the reason names exactly the set
/// the exit gate reports.
pub fn required_failure_reason(&self) -> String {
self.results
.iter()
.filter(|r| r.required && r.outcome.is_required_release_failure())
.map(|r| {
// Exhaustive match (not `_ =>`) mirrors
// `is_required_release_failure`: a future message-carrying
// required-failure variant must be compile-forced to extract
// its message here rather than silently rendering `<name>: `
// with an empty reason.
let msg = match &r.outcome {
PublisherOutcome::Failed(m) | PublisherOutcome::RollbackFailed(m) => m.as_str(),
PublisherOutcome::Succeeded
| PublisherOutcome::Skipped(_)
| PublisherOutcome::RolledBack
| PublisherOutcome::RollbackSkippedNoScope
| PublisherOutcome::PendingModeration
| PublisherOutcome::PendingValidation
| PublisherOutcome::PublishedNoRollback => "",
};
format!("{}: {}", r.name, msg)
})
.collect::<Vec<_>>()
.join("; ")
}
/// Returns true if any publisher in `group` failed.
///
/// When `required_only` is true, only publishers with `required: true` count.
/// The Submitter gate consults this with `required_only = true` against the
/// Assets and Manager groups to decide whether to skip Submitter dispatch.
pub fn any_failed(&self, group: PublisherGroup, required_only: bool) -> bool {
self.results.iter().any(|r| {
r.group == group
&& (!required_only || r.required)
&& matches!(r.outcome, PublisherOutcome::Failed(_))
})
}
/// The single authoritative one-way-door gate predicate: `true` when
/// any already-run **required** publisher failed and every downstream
/// one-way door (Manager or Submitter) must therefore be skipped.
///
/// A required failure in Assets, Manager, **or the Submitter group
/// itself** closes the gate. Both the intra-Manager and intra-Submitter
/// checks are load-bearing: each group runs sequentially, and a
/// required failure partway through must stop the remaining
/// irreversible publishers in that group and every later group from
/// pushing against an incomplete release — the gate is not a single
/// boundary, it is a running "any required publish already broke" check
/// that every remaining one-way door consults.
///
/// Every gate site — the in-dispatch Manager+Submitter loop, the
/// `SnapcraftPublishStage` (a Submitter that runs as its own stage after
/// the trait dispatch), and the `BlobStage` self-check — calls this one
/// predicate so the rule cannot drift between copies. (The name is
/// historical: the gate originally covered only the Submitter group.)
pub fn submitter_gate_closed(&self) -> bool {
self.any_failed(PublisherGroup::Assets, true)
|| self.any_failed(PublisherGroup::Manager, true)
|| self.any_failed(PublisherGroup::Submitter, true)
}
}
/// Required-failure exit gate: bail when any *required* publisher finished
/// in a terminal failure state, so the caller exits non-zero even though
/// the pipeline body ran to completion.
///
/// One definition serves both layers of the defense — the publish stage's
/// in-stage bail (so any embedding of the stage cannot report green over a
/// failed required publisher) and the CLI's end-of-pipeline gate (so shell
/// / CI callers see a non-zero exit). `ran_context` is the caller-specific
/// sentence describing what completed before this error; everything else —
/// the snapshot / dry-run skip, the failure filter, the name list, the
/// recovery hint — is shared so the two layers cannot drift.
///
/// **Snapshot / dry-run skip**: publishers don't actually publish in those
/// modes, so a recorded failure there must not abort the preview pipeline;
/// the explicit skip is defense-in-depth in case a future stage starts
/// recording publisher results in those modes.
pub fn gate_required_failures(
ctx: &crate::context::Context,
ran_context: &str,
) -> anyhow::Result<()> {
if ctx.is_snapshot() || ctx.is_dry_run() {
return Ok(());
}
let Some(report) = ctx.publish_report() else {
return Ok(());
};
let failed = report.required_failure_names();
if failed.is_empty() {
return Ok(());
}
anyhow::bail!(
"{} required publisher(s) failed: {}. {} Inspect dist/run-<id>/report.json \
for details and use --rollback-only --from-run=<id> to retry rollback.",
failed.len(),
failed.join(", "),
ran_context
);
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn empty_report_has_zero_failures() {
let r = PublishReport::default();
assert!(r.results.is_empty());
assert!(!r.submitter_gated);
assert_eq!(r.required_failures(), 0);
}
#[test]
fn required_failures_counts_only_required() {
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "optional-pub".to_string(),
group: PublisherGroup::Manager,
required: false,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
r.results.push(PublisherResult {
name: "required-pub".to_string(),
group: PublisherGroup::Submitter,
required: true,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
assert_eq!(r.required_failures(), 1);
}
/// The name list feeding the operator-facing gate message applies the
/// SAME filter as the count — a required Failed/RollbackFailed row is
/// named, a non-required or non-terminal row is not.
#[test]
fn required_failure_names_matches_count_filter() {
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "optional-pub".to_string(),
group: PublisherGroup::Manager,
required: false,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
r.results.push(PublisherResult {
name: "required-pub".to_string(),
group: PublisherGroup::Submitter,
required: true,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
r.results.push(PublisherResult {
name: "required-rollback-failed".to_string(),
group: PublisherGroup::Manager,
required: true,
outcome: PublisherOutcome::RollbackFailed("cleanup".to_string()),
evidence: None,
});
assert_eq!(
r.required_failure_names(),
vec!["required-pub", "required-rollback-failed"]
);
assert_eq!(r.required_failures(), 2);
}
#[test]
fn required_failures_counts_rollback_failed() {
// Regression: a required publisher whose publish succeeded but whose
// rollback then failed leaves a half-published surface and MUST count
// as a required failure. The prior `matches!(Failed(_))`-only filter
// silently dropped it.
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "required-rollback-failed".to_string(),
group: PublisherGroup::Submitter,
required: true,
outcome: PublisherOutcome::RollbackFailed("manual cleanup needed".to_string()),
evidence: None,
});
assert_eq!(r.required_failures(), 1);
}
#[test]
fn is_required_release_failure_classifies_terminal_failures() {
assert!(PublisherOutcome::Failed("boom".into()).is_required_release_failure());
assert!(PublisherOutcome::RollbackFailed("boom".into()).is_required_release_failure());
assert!(!PublisherOutcome::Succeeded.is_required_release_failure());
assert!(!PublisherOutcome::RolledBack.is_required_release_failure());
assert!(!PublisherOutcome::RollbackSkippedNoScope.is_required_release_failure());
assert!(!PublisherOutcome::PendingModeration.is_required_release_failure());
assert!(!PublisherOutcome::PendingValidation.is_required_release_failure());
assert!(!PublisherOutcome::PublishedNoRollback.is_required_release_failure());
assert!(!PublisherOutcome::Skipped(SkipReason::DryRun).is_required_release_failure());
}
#[test]
fn skip_reason_serializes_as_kebab_case() {
let s = serde_json::to_string(&SkipReason::SubmitterGated).expect("serialize");
assert_eq!(s, "\"submitter-gated\"");
}
#[test]
fn skip_reason_deselected_serializes_as_kebab_case() {
let s = serde_json::to_string(&SkipReason::Deselected).expect("serialize");
assert_eq!(s, "\"deselected\"");
}
#[test]
fn publisher_group_serializes_pascal_case() {
let s = serde_json::to_string(&PublisherGroup::Submitter).expect("serialize");
assert_eq!(s, "\"Submitter\"");
}
#[test]
fn publisher_outcome_succeeded_serializes_as_bare_string() {
let s = serde_json::to_string(&PublisherOutcome::Succeeded).expect("serialize");
assert_eq!(s, "\"Succeeded\"");
}
#[test]
fn publisher_outcome_failed_serializes_as_externally_tagged() {
let s = serde_json::to_string(&PublisherOutcome::Failed("boom".into())).expect("serialize");
assert_eq!(s, r#"{"Failed":"boom"}"#);
}
#[test]
fn any_failed_returns_true_only_for_required_when_required_only_is_true() {
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "required-mgr".to_string(),
group: PublisherGroup::Manager,
required: true,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
r.results.push(PublisherResult {
name: "optional-mgr".to_string(),
group: PublisherGroup::Manager,
required: false,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
assert!(r.any_failed(PublisherGroup::Manager, true));
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "optional-mgr".to_string(),
group: PublisherGroup::Manager,
required: false,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
assert!(!r.any_failed(PublisherGroup::Manager, true));
assert!(r.any_failed(PublisherGroup::Manager, false));
}
fn failed(name: &str, group: PublisherGroup, required: bool) -> PublisherResult {
PublisherResult {
name: name.to_string(),
group,
required,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
}
}
#[test]
fn submitter_gate_closes_on_required_failure_in_any_group() {
for group in [
PublisherGroup::Assets,
PublisherGroup::Manager,
PublisherGroup::Submitter,
] {
let mut r = PublishReport::default();
r.results.push(failed("p", group, true));
assert!(
r.submitter_gate_closed(),
"a required failure in {group:?} must close the submitter gate"
);
}
}
#[test]
fn submitter_gate_closes_on_required_intra_submitter_failure() {
// The load-bearing case for the v0.8.0 fix: a required cargo
// (Submitter) failure must close the gate so later irreversible
// submitters (winget, snapcraft) are skipped.
let mut r = PublishReport::default();
r.results
.push(failed("cargo", PublisherGroup::Submitter, true));
assert!(r.submitter_gate_closed());
}
#[test]
fn submitter_gate_stays_open_on_optional_failures_only() {
let mut r = PublishReport::default();
r.results.push(failed("a", PublisherGroup::Assets, false));
r.results.push(failed("m", PublisherGroup::Manager, false));
r.results
.push(failed("cargo", PublisherGroup::Submitter, false));
assert!(
!r.submitter_gate_closed(),
"optional failures must not close the gate (continue-on-error)"
);
}
#[test]
fn submitter_gate_stays_open_on_all_success() {
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "github-release".to_string(),
group: PublisherGroup::Assets,
required: true,
outcome: PublisherOutcome::Succeeded,
evidence: None,
});
assert!(!r.submitter_gate_closed());
}
}