1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
use crate::publish_evidence::PublishEvidence;
use serde::{Deserialize, Serialize};
/// Three-group dispatch classification for publishers. Dispatch order is
/// always Assets → Manager → Submitter. The Submitter gate sits between
/// Manager and Submitter and short-circuits Submitter dispatch when any
/// `required: true` publisher in Assets or Manager failed (so a botched
/// homebrew tap push cannot burn a crates.io version slot).
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub enum PublisherGroup {
/// Writes uploadable bytes to systems we control end-to-end. Failures
/// are reversible via API delete (github-release, dockerhub,
/// artifactory, cloudsmith, blob).
Assets,
/// Writes to package-manager state. Server-side deletable, but
/// consumer machines may have already pulled the artifact
/// (homebrew, scoop, nix, krew, mcp, our-AUR repos, custom).
Manager,
/// Writes to a third-party submission queue, an immutable registry
/// slot, or a channel position we cannot reclaim. Gated behind the
/// Submitter gate. Rollback is informational-only for most members
/// (chocolatey, winget, snapcraft, upstream-AUR force-push), with one
/// exception: **cargo** has a real programmatic rollback. A multi-crate
/// `cargo publish` that succeeds on crate A then fails on crate B
/// records A and opts in via
/// [`Publisher::programmatic_rollback_on_failure`](crate::Publisher::programmatic_rollback_on_failure),
/// so the rollback path issues `cargo yank` for A even though the row's
/// outcome is `Failed`.
Submitter,
}
/// Per-publisher terminal state in [`PublishReport`]. Stage-level statuses
/// like `pending-moderation` / `pending-validation` / `announce-gated`
/// live on the run summary, not here.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub enum PublisherOutcome {
/// `Publisher::run` returned `Ok` and the artifact is live.
Succeeded,
/// Publisher did not execute; see [`SkipReason`] for why.
Skipped(SkipReason),
/// `Publisher::run` returned `Err`; the carried `String` is the error
/// message (already rendered via `{:#}`).
Failed(String),
/// Initially [`PublisherOutcome::Succeeded`], then revert dispatch
/// successfully reverted the action.
RolledBack,
/// Initial run succeeded but revert dispatch failed; manual
/// intervention required. The carried `String` is the rollback
/// error message.
RollbackFailed(String),
/// Rollback was skipped because the required scope token env var
/// (per `Publisher::rollback_scope_needed`) is not set in the
/// environment.
RollbackSkippedNoScope,
/// Publisher succeeded but the version is queued for moderation (chocolatey, AUR-like).
PendingModeration,
/// Publisher succeeded but a downstream validation step is still polling (winget).
PendingValidation,
/// Publisher succeeded; rollback was skipped because `--rollback=none` was set.
PublishedNoRollback,
}
/// Reason a publisher was [`PublisherOutcome::Skipped`]. Serialized as
/// kebab-case (e.g. `"submitter-gated"`).
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[serde(rename_all = "kebab-case")]
pub enum SkipReason {
/// Skipped because a required Assets/Manager publisher failed; the
/// Submitter gate closed before this publisher could dispatch.
/// Preserves rollback safety on irreversible publishers.
SubmitterGated,
/// Publisher entry absent from the workspace config; the
/// `Publisher::run` impl was never invoked.
NotConfigured,
/// Pipeline ran in `--snapshot` mode; publishers do not fire.
Snapshot,
/// Pipeline ran in `--dry-run` mode; publishers do not fire.
DryRun,
/// Pipeline ran in `--nightly` mode and this publisher opts out of
/// nightly publishes (e.g. homebrew, scoop, aur, krew, nix, every
/// announcer — the nightly skip-list).
Nightly,
/// No artifact in the current crate scope matches this publisher's
/// applicability rules (e.g. top-level homebrew_casks declared
/// `binaries: [cfgd]` but the current per-crate iteration is on
/// `cfgd-core` and has no `cfgd` binary in scope; or cloudsmith
/// targets `.deb` / `.rpm` / `.apk` but the current crate produces
/// only library archives). Distinct from `NotConfigured` (where
/// the publisher block is absent entirely) and from
/// `PublisherOutcome::Failed` (where the publisher TRIED to run
/// and hit a real error). Required Manager publishers reporting
/// `NotApplicable` MUST NOT trigger the submitter gate — there is
/// nothing to roll back, and the absence of applicable artifacts
/// is not a publish failure.
NotApplicable,
/// This version was already published to the target registry/store on a
/// prior run, so the publisher detected it and skipped re-publishing
/// (idempotent re-run). Distinct from `PublisherOutcome::Succeeded`
/// because nothing was published THIS run — and distinct from
/// `PublisherOutcome::Failed` because an already-published version is the
/// desired end-state, not an error. A publisher reporting
/// `AlreadyPublished` records NO rollback evidence: the version it found
/// was published by an earlier run (or another actor), and deleting it on
/// rollback would destroy state this run never created.
AlreadyPublished,
/// Excluded by `--skip` (the unified stage/publisher denylist) or absent
/// from a non-empty `--publishers` allowlist. The operator opted this
/// publisher out of the run; it was never invoked. Distinct from
/// `NotConfigured` (the publisher block is absent from config) and from
/// `NotApplicable` (the publisher is configured but no in-scope artifact
/// matches it) — here the config and artifacts may both be present, and the
/// publisher would otherwise have run, but the operator's selection
/// suppressed it.
Deselected,
}
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub struct PublisherResult {
pub name: String,
pub group: PublisherGroup,
pub required: bool,
pub outcome: PublisherOutcome,
pub evidence: Option<PublishEvidence>,
}
#[derive(Debug, Clone, Default, PartialEq, Eq, Serialize, Deserialize)]
pub struct PublishReport {
pub results: Vec<PublisherResult>,
#[serde(default)]
pub submitter_gated: bool,
#[serde(default)]
pub announce_gated: bool,
}
impl PublishReport {
pub fn required_failures(&self) -> usize {
self.results
.iter()
.filter(|r| r.required && matches!(r.outcome, PublisherOutcome::Failed(_)))
.count()
}
/// Returns true if any publisher in `group` failed.
///
/// When `required_only` is true, only publishers with `required: true` count.
/// The Submitter gate consults this with `required_only = true` against the
/// Assets and Manager groups to decide whether to skip Submitter dispatch.
pub fn any_failed(&self, group: PublisherGroup, required_only: bool) -> bool {
self.results.iter().any(|r| {
r.group == group
&& (!required_only || r.required)
&& matches!(r.outcome, PublisherOutcome::Failed(_))
})
}
/// The single authoritative submitter-gate predicate: `true` when any
/// already-run **required** publisher failed and a downstream
/// irreversible Submitter must therefore be skipped.
///
/// A required failure in Assets, Manager, **or the Submitter group
/// itself** closes the gate. The intra-Submitter check is load-bearing:
/// submitters run sequentially (cargo first), and a required cargo
/// failure must stop the later irreversible submitters (winget,
/// chocolatey, snapcraft) from pushing against an incomplete release —
/// the gate is not just an Assets/Manager → Submitter boundary, it is a
/// running "any required publish already broke" check that every
/// remaining irreversible submitter consults.
///
/// Every gate site — the in-dispatch Submitter loop, the
/// `SnapcraftPublishStage` (a Submitter that runs as its own stage after
/// the trait dispatch) — calls this one predicate so the rule cannot
/// drift between copies.
pub fn submitter_gate_closed(&self) -> bool {
self.any_failed(PublisherGroup::Assets, true)
|| self.any_failed(PublisherGroup::Manager, true)
|| self.any_failed(PublisherGroup::Submitter, true)
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn empty_report_has_zero_failures() {
let r = PublishReport::default();
assert!(r.results.is_empty());
assert!(!r.submitter_gated);
assert_eq!(r.required_failures(), 0);
}
#[test]
fn required_failures_counts_only_required() {
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "optional-pub".to_string(),
group: PublisherGroup::Manager,
required: false,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
r.results.push(PublisherResult {
name: "required-pub".to_string(),
group: PublisherGroup::Submitter,
required: true,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
assert_eq!(r.required_failures(), 1);
}
#[test]
fn skip_reason_serializes_as_kebab_case() {
let s = serde_json::to_string(&SkipReason::SubmitterGated).expect("serialize");
assert_eq!(s, "\"submitter-gated\"");
}
#[test]
fn skip_reason_deselected_serializes_as_kebab_case() {
let s = serde_json::to_string(&SkipReason::Deselected).expect("serialize");
assert_eq!(s, "\"deselected\"");
}
#[test]
fn publisher_group_serializes_pascal_case() {
let s = serde_json::to_string(&PublisherGroup::Submitter).expect("serialize");
assert_eq!(s, "\"Submitter\"");
}
#[test]
fn publisher_outcome_succeeded_serializes_as_bare_string() {
let s = serde_json::to_string(&PublisherOutcome::Succeeded).expect("serialize");
assert_eq!(s, "\"Succeeded\"");
}
#[test]
fn publisher_outcome_failed_serializes_as_externally_tagged() {
let s = serde_json::to_string(&PublisherOutcome::Failed("boom".into())).expect("serialize");
assert_eq!(s, r#"{"Failed":"boom"}"#);
}
#[test]
fn any_failed_returns_true_only_for_required_when_required_only_is_true() {
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "required-mgr".to_string(),
group: PublisherGroup::Manager,
required: true,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
r.results.push(PublisherResult {
name: "optional-mgr".to_string(),
group: PublisherGroup::Manager,
required: false,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
assert!(r.any_failed(PublisherGroup::Manager, true));
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "optional-mgr".to_string(),
group: PublisherGroup::Manager,
required: false,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
});
assert!(!r.any_failed(PublisherGroup::Manager, true));
assert!(r.any_failed(PublisherGroup::Manager, false));
}
fn failed(name: &str, group: PublisherGroup, required: bool) -> PublisherResult {
PublisherResult {
name: name.to_string(),
group,
required,
outcome: PublisherOutcome::Failed("boom".to_string()),
evidence: None,
}
}
#[test]
fn submitter_gate_closes_on_required_failure_in_any_group() {
for group in [
PublisherGroup::Assets,
PublisherGroup::Manager,
PublisherGroup::Submitter,
] {
let mut r = PublishReport::default();
r.results.push(failed("p", group, true));
assert!(
r.submitter_gate_closed(),
"a required failure in {group:?} must close the submitter gate"
);
}
}
#[test]
fn submitter_gate_closes_on_required_intra_submitter_failure() {
// The load-bearing case for the v0.8.0 fix: a required cargo
// (Submitter) failure must close the gate so later irreversible
// submitters (winget, snapcraft) are skipped.
let mut r = PublishReport::default();
r.results
.push(failed("cargo", PublisherGroup::Submitter, true));
assert!(r.submitter_gate_closed());
}
#[test]
fn submitter_gate_stays_open_on_optional_failures_only() {
let mut r = PublishReport::default();
r.results.push(failed("a", PublisherGroup::Assets, false));
r.results.push(failed("m", PublisherGroup::Manager, false));
r.results
.push(failed("cargo", PublisherGroup::Submitter, false));
assert!(
!r.submitter_gate_closed(),
"optional failures must not close the gate (continue-on-error)"
);
}
#[test]
fn submitter_gate_stays_open_on_all_success() {
let mut r = PublishReport::default();
r.results.push(PublisherResult {
name: "github-release".to_string(),
group: PublisherGroup::Assets,
required: true,
outcome: PublisherOutcome::Succeeded,
evidence: None,
});
assert!(!r.submitter_gate_closed());
}
}