amaters-cluster 0.2.2

Consensus layer for AmateRS (Ukehi)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
//! Alert rule engine for the AmateRS cluster layer.
//!
//! Provides a [`RuleEngine`] that evaluates [`AlertRule`]s against incoming
//! [`AlertEvent`]s, assigns [`AlertSeverity`], deduplicates within a
//! configurable time window, and fans out [`FiredAlert`]s to registered
//! [`AlertSink`]s.

use crate::failover::AlertEvent;
use std::collections::HashMap;
use std::sync::{Arc, Mutex};
use std::time::{Duration, Instant};

// ── Severity ────────────────────────────────────────────────────────────────

/// Severity level assigned to a fired alert.
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum AlertSeverity {
    Info,
    Warning,
    Critical,
}

// ── Rule ────────────────────────────────────────────────────────────────────

/// A predicate function that inspects an [`AlertEvent`] and optionally returns
/// the severity at which the rule should fire.  Returning `None` means the
/// rule does not match this event.
pub type RulePredicate = Arc<dyn Fn(&AlertEvent) -> Option<AlertSeverity> + Send + Sync>;

/// A named rule with its matching predicate.
pub struct AlertRule {
    /// Human-readable rule identifier (used as part of the dedup key).
    pub name: String,
    /// Predicate that maps an event to an optional severity.
    pub predicate: RulePredicate,
}

// ── FiredAlert ───────────────────────────────────────────────────────────────

/// A fully-resolved alert that has passed rule evaluation and dedup checks.
#[derive(Debug, Clone)]
pub struct FiredAlert {
    /// Name of the rule that produced this alert.
    pub rule_name: String,
    /// Severity assigned by the rule.
    pub severity: AlertSeverity,
    /// The original event that triggered the alert.
    pub event: AlertEvent,
    /// Stable dedup key derived from the event (see [`event_dedup_key`]).
    pub dedup_key: String,
}

// ── Sinks ────────────────────────────────────────────────────────────────────

/// Trait implemented by all alert receivers.
pub trait AlertSink: Send + Sync {
    fn on_alert(&self, alert: &FiredAlert);
}

/// A sink that emits alerts via the `tracing` crate.
pub struct LogSink;

impl AlertSink for LogSink {
    fn on_alert(&self, alert: &FiredAlert) {
        match alert.severity {
            AlertSeverity::Critical => {
                tracing::error!(
                    rule = %alert.rule_name,
                    dedup_key = %alert.dedup_key,
                    "CRITICAL alert fired"
                );
            }
            AlertSeverity::Warning => {
                tracing::warn!(
                    rule = %alert.rule_name,
                    dedup_key = %alert.dedup_key,
                    "WARNING alert fired"
                );
            }
            AlertSeverity::Info => {
                tracing::info!(
                    rule = %alert.rule_name,
                    dedup_key = %alert.dedup_key,
                    "INFO alert fired"
                );
            }
        }
    }
}

/// A sink that collects fired alerts into an in-memory vector; intended for
/// unit tests.
pub struct CollectingSink {
    alerts: Mutex<Vec<FiredAlert>>,
}

impl Default for CollectingSink {
    fn default() -> Self {
        Self::new()
    }
}

impl CollectingSink {
    /// Create a new, empty collecting sink.
    pub fn new() -> Self {
        Self {
            alerts: Mutex::new(Vec::new()),
        }
    }

    /// Return a clone of all collected alerts.
    pub fn collected(&self) -> Vec<FiredAlert> {
        self.alerts
            .lock()
            .unwrap_or_else(|e| e.into_inner())
            .clone()
    }

    /// Clear all collected alerts.
    pub fn clear(&self) {
        self.alerts
            .lock()
            .unwrap_or_else(|e| e.into_inner())
            .clear();
    }
}

impl AlertSink for CollectingSink {
    fn on_alert(&self, alert: &FiredAlert) {
        self.alerts
            .lock()
            .unwrap_or_else(|e| e.into_inner())
            .push(alert.clone());
    }
}

// ── Dedup key ────────────────────────────────────────────────────────────────

/// Return a stable string that uniquely identifies the *entity* (node, cluster,
/// …) that an event concerns.  Used as the second component of the dedup key.
pub fn event_dedup_key(event: &AlertEvent) -> String {
    match event {
        AlertEvent::NodeFailed { node_id } => format!("node_failed:{node_id}"),
        AlertEvent::NodeRecovered { node_id } => format!("node_recovered:{node_id}"),
        AlertEvent::LeaderChanged { new_leader, .. } => format!("leader_changed:{new_leader}"),
        AlertEvent::QuorumLost { .. } => "quorum_lost".to_owned(),
        AlertEvent::SlowReplication { follower, .. } => format!("slow_replication:{follower}"),
    }
}

// ── RuleEngine ───────────────────────────────────────────────────────────────

/// Evaluates alert rules, deduplicates firings within a time window, and fans
/// out [`FiredAlert`]s to registered [`AlertSink`]s.
pub struct RuleEngine {
    rules: Vec<AlertRule>,
    sinks: Vec<Arc<dyn AlertSink>>,
    dedup_window: Duration,
    /// Maps `(rule_name, dedup_key)` → time of last firing.
    dedup: Mutex<HashMap<(String, String), Instant>>,
}

impl RuleEngine {
    /// Create a rule engine with the given dedup window.
    ///
    /// An event fired within `dedup_window` of a previous identical event
    /// (same rule + same entity) is suppressed.
    pub fn new_with_window(dedup_window: Duration) -> Self {
        Self {
            rules: Vec::new(),
            sinks: Vec::new(),
            dedup_window,
            dedup: Mutex::new(HashMap::new()),
        }
    }

    /// Register an alert rule.  Returns `&mut Self` for chaining.
    pub fn add_rule(&mut self, rule: AlertRule) -> &mut Self {
        self.rules.push(rule);
        self
    }

    /// Register an alert sink.  Returns `&mut Self` for chaining.
    pub fn add_sink(&mut self, sink: Arc<dyn AlertSink>) -> &mut Self {
        self.sinks.push(sink);
        self
    }

    /// Process one event against all registered rules.
    ///
    /// `now` is injected so that unit tests can advance time deterministically
    /// without sleeping.
    pub fn process_event(&self, event: &AlertEvent, now: Instant) {
        let dedup_key = event_dedup_key(event);

        for rule in &self.rules {
            let Some(severity) = (rule.predicate)(event) else {
                continue;
            };

            let dup_tuple = (rule.name.clone(), dedup_key.clone());

            // --- dedup check ---
            {
                let mut guard = self.dedup.lock().unwrap_or_else(|e| e.into_inner());
                if let Some(last) = guard.get(&dup_tuple) {
                    if now.duration_since(*last) < self.dedup_window {
                        continue; // within window — suppress
                    }
                }
                guard.insert(dup_tuple, now);
            } // release lock before calling sinks

            let alert = FiredAlert {
                rule_name: rule.name.clone(),
                severity,
                event: event.clone(),
                dedup_key: dedup_key.clone(),
            };

            for sink in &self.sinks {
                sink.on_alert(&alert);
            }
        }
    }
}

// ── Default rule set ─────────────────────────────────────────────────────────

/// Build the standard set of alert rules used by the cluster layer.
///
/// `slow_repl_threshold` — minimum `lag_entries` value for a
/// [`AlertEvent::SlowReplication`] event to trigger a warning.
pub fn default_rules(slow_repl_threshold: u64) -> Vec<AlertRule> {
    vec![
        AlertRule {
            name: "node_failed".to_owned(),
            predicate: Arc::new(|event| match event {
                AlertEvent::NodeFailed { .. } => Some(AlertSeverity::Critical),
                _ => None,
            }),
        },
        AlertRule {
            name: "quorum_lost".to_owned(),
            predicate: Arc::new(|event| match event {
                AlertEvent::QuorumLost { .. } => Some(AlertSeverity::Critical),
                _ => None,
            }),
        },
        AlertRule {
            name: "leader_changed".to_owned(),
            predicate: Arc::new(|event| match event {
                AlertEvent::LeaderChanged { .. } => Some(AlertSeverity::Warning),
                _ => None,
            }),
        },
        AlertRule {
            name: "slow_replication".to_owned(),
            predicate: Arc::new(move |event| match event {
                AlertEvent::SlowReplication { lag_entries, .. }
                    if *lag_entries >= slow_repl_threshold =>
                {
                    Some(AlertSeverity::Warning)
                }
                _ => None,
            }),
        },
    ]
}

// ── Tests ─────────────────────────────────────────────────────────────────────

#[cfg(test)]
mod tests {
    use super::*;
    use std::time::{Duration, Instant};

    fn build_engine(sink: Arc<CollectingSink>) -> RuleEngine {
        let mut engine = RuleEngine::new_with_window(Duration::from_secs(60));
        for rule in default_rules(100) {
            engine.add_rule(rule);
        }
        engine.add_sink(sink);
        engine
    }

    #[test]
    fn test_node_failed_fires_critical() {
        let sink = Arc::new(CollectingSink::new());
        let engine = build_engine(Arc::clone(&sink));
        engine.process_event(&AlertEvent::NodeFailed { node_id: 1 }, Instant::now());
        let alerts = sink.collected();
        assert_eq!(alerts.len(), 1);
        assert_eq!(alerts[0].severity, AlertSeverity::Critical);
        assert_eq!(alerts[0].rule_name, "node_failed");
    }

    #[test]
    fn test_quorum_lost_fires_critical() {
        let sink = Arc::new(CollectingSink::new());
        let engine = build_engine(Arc::clone(&sink));
        engine.process_event(
            &AlertEvent::QuorumLost {
                cluster_size: 5,
                reachable: 2,
            },
            Instant::now(),
        );
        let alerts = sink.collected();
        assert_eq!(alerts.len(), 1);
        assert_eq!(alerts[0].severity, AlertSeverity::Critical);
        assert_eq!(alerts[0].rule_name, "quorum_lost");
    }

    #[test]
    fn test_leader_changed_fires_warning() {
        let sink = Arc::new(CollectingSink::new());
        let engine = build_engine(Arc::clone(&sink));
        engine.process_event(
            &AlertEvent::LeaderChanged {
                old_leader: Some(1),
                new_leader: 2,
            },
            Instant::now(),
        );
        let alerts = sink.collected();
        assert_eq!(alerts.len(), 1);
        assert_eq!(alerts[0].severity, AlertSeverity::Warning);
        assert_eq!(alerts[0].rule_name, "leader_changed");
    }

    #[test]
    fn test_slow_replication_fires_warning_above_threshold() {
        let sink = Arc::new(CollectingSink::new());
        let engine = build_engine(Arc::clone(&sink));
        engine.process_event(
            &AlertEvent::SlowReplication {
                follower: 3,
                lag_entries: 200,
            },
            Instant::now(),
        );
        let alerts = sink.collected();
        assert_eq!(alerts.len(), 1);
        assert_eq!(alerts[0].severity, AlertSeverity::Warning);
        assert_eq!(alerts[0].rule_name, "slow_replication");
    }

    #[test]
    fn test_slow_replication_silent_below_threshold() {
        let sink = Arc::new(CollectingSink::new());
        let engine = build_engine(Arc::clone(&sink));
        engine.process_event(
            &AlertEvent::SlowReplication {
                follower: 3,
                lag_entries: 50, // below 100 threshold
            },
            Instant::now(),
        );
        assert!(sink.collected().is_empty());
    }

    #[test]
    fn test_dedup_suppresses_repeat_within_window() {
        let sink = Arc::new(CollectingSink::new());
        let engine = build_engine(Arc::clone(&sink));
        let t0 = Instant::now();
        let event = AlertEvent::NodeFailed { node_id: 7 };
        engine.process_event(&event, t0);
        // Second fire 1 second later — still within 60-second window
        engine.process_event(&event, t0 + Duration::from_secs(1));
        assert_eq!(
            sink.collected().len(),
            1,
            "second fire should be suppressed"
        );
    }

    #[test]
    fn test_dedup_refires_after_window() {
        let sink = Arc::new(CollectingSink::new());
        let engine = build_engine(Arc::clone(&sink));
        let t0 = Instant::now();
        let event = AlertEvent::NodeFailed { node_id: 8 };
        engine.process_event(&event, t0);
        // Second fire 61 seconds later — window has expired
        engine.process_event(&event, t0 + Duration::from_secs(61));
        assert_eq!(
            sink.collected().len(),
            2,
            "should refire after window expires"
        );
    }

    #[test]
    fn test_collecting_sink_captures_alerts() {
        let sink = Arc::new(CollectingSink::new());
        let engine = build_engine(Arc::clone(&sink));
        let t0 = Instant::now();
        engine.process_event(&AlertEvent::NodeFailed { node_id: 10 }, t0);
        engine.process_event(
            &AlertEvent::QuorumLost {
                cluster_size: 3,
                reachable: 1,
            },
            t0,
        );
        let alerts = sink.collected();
        assert_eq!(alerts.len(), 2);
        sink.clear();
        assert!(sink.collected().is_empty());
    }
}