allow-report 0.1.8

Report and receipt rendering for cargo-allow source exception scans.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
use crate::diff_finding_detail::structural_identity_summary;
use crate::diff_policy_detail::policy_change_detail;
use crate::diff_posture::{
    diff_evidence_delta_summary, diff_net_posture, diff_posture_summary,
    diff_structural_delta_summary,
};
use crate::evidence_repair::evidence_repair_queues_from_counts;
use crate::text::markdown_cell;
use crate::{CLAIM_BOUNDARY_TEXT, DiffFindingChange, DiffPolicyChange};

const PR_SUMMARY_HIGHLIGHT_LIMIT: usize = 8;
const DIFF_MARKDOWN_CHANGE_LIMIT: usize = 120;

pub fn render_diff_pr_summary_markdown(
    current_failures: usize,
    finding_changes: &[DiffFindingChange<'_>],
    policy_changes: &[DiffPolicyChange<'_>],
) -> String {
    render_diff_pr_summary_markdown_with_evidence_health(
        current_failures,
        0,
        0,
        finding_changes,
        policy_changes,
    )
}

pub fn render_diff_pr_summary_markdown_with_evidence_health_counts(
    current_failures: usize,
    broken_evidence_links: usize,
    missing_evidence: usize,
    weak_evidence_references: usize,
    finding_changes: &[DiffFindingChange<'_>],
    policy_changes: &[DiffPolicyChange<'_>],
) -> String {
    render_diff_pr_summary_markdown_with_evidence_health_counts_inner(
        current_failures,
        broken_evidence_links,
        missing_evidence,
        weak_evidence_references,
        finding_changes,
        policy_changes,
    )
}

pub fn render_diff_pr_summary_markdown_with_evidence_health(
    current_failures: usize,
    broken_evidence_links: usize,
    weak_evidence_references: usize,
    finding_changes: &[DiffFindingChange<'_>],
    policy_changes: &[DiffPolicyChange<'_>],
) -> String {
    render_diff_pr_summary_markdown_with_evidence_health_counts_inner(
        current_failures,
        broken_evidence_links,
        0,
        weak_evidence_references,
        finding_changes,
        policy_changes,
    )
}

fn render_diff_pr_summary_markdown_with_evidence_health_counts_inner(
    current_failures: usize,
    broken_evidence_links: usize,
    missing_evidence: usize,
    weak_evidence_references: usize,
    finding_changes: &[DiffFindingChange<'_>],
    policy_changes: &[DiffPolicyChange<'_>],
) -> String {
    let summary = diff_posture_summary(current_failures, finding_changes, policy_changes);
    let posture = diff_net_posture(summary);
    let mut out = String::new();
    out.push_str("## PR Summary\n\n");
    out.push_str(&format!("**Net posture:** `{}`\n\n", posture.as_str()));
    out.push_str("| Signal | Count |\n|---|---:|\n");
    out.push_str(&format!(
        "| Current check failures | {} |\n",
        summary.current_failures
    ));
    if broken_evidence_links > 0 {
        out.push_str(&format!(
            "| Broken evidence links | {broken_evidence_links} |\n"
        ));
    }
    if missing_evidence > 0 {
        out.push_str(&format!("| Missing evidence | {missing_evidence} |\n"));
    }
    if weak_evidence_references > 0 {
        out.push_str(&format!(
            "| Weak evidence/link references | {weak_evidence_references} |\n"
        ));
    }
    let structural_delta = diff_structural_delta_summary(policy_changes);
    if structural_delta.scope_broadened > 0 {
        out.push_str(&format!(
            "| Scope broadened | {} |\n",
            structural_delta.scope_broadened
        ));
    }
    if structural_delta.scope_changed > 0 {
        out.push_str(&format!(
            "| Scope changed | {} |\n",
            structural_delta.scope_changed
        ));
    }
    if structural_delta.scope_narrowed > 0 {
        out.push_str(&format!(
            "| Scope narrowed | {} |\n",
            structural_delta.scope_narrowed
        ));
    }
    if structural_delta.selector_changed > 0 {
        out.push_str(&format!(
            "| Selector changed | {} |\n",
            structural_delta.selector_changed
        ));
    }
    if structural_delta.selector_precision_decreased > 0 {
        out.push_str(&format!(
            "| Selector precision decreased | {} |\n",
            structural_delta.selector_precision_decreased
        ));
    }
    if structural_delta.selector_precision_increased > 0 {
        out.push_str(&format!(
            "| Selector precision increased | {} |\n",
            structural_delta.selector_precision_increased
        ));
    }
    let evidence_delta = diff_evidence_delta_summary(policy_changes);
    if evidence_delta.evidence_added > 0 {
        out.push_str(&format!(
            "| Evidence added | {} |\n",
            evidence_delta.evidence_added
        ));
    }
    if evidence_delta.weak_evidence_added > 0 {
        out.push_str(&format!(
            "| Weak evidence added | {} |\n",
            evidence_delta.weak_evidence_added
        ));
    }
    if evidence_delta.broken_evidence_added > 0 {
        out.push_str(&format!(
            "| Broken evidence added | {} |\n",
            evidence_delta.broken_evidence_added
        ));
    }
    if evidence_delta.evidence_removed > 0 {
        out.push_str(&format!(
            "| Evidence removed | {} |\n",
            evidence_delta.evidence_removed
        ));
    }
    if evidence_delta.evidence_removal_failures > 0 {
        out.push_str(&format!(
            "| Evidence removal failures | {} |\n",
            evidence_delta.evidence_removal_failures
        ));
    }
    if evidence_delta.evidence_removal_review_items > 0 {
        out.push_str(&format!(
            "| Evidence removal review items | {} |\n",
            evidence_delta.evidence_removal_review_items
        ));
    }
    if evidence_delta.evidence_removal_improvements > 0 {
        out.push_str(&format!(
            "| Evidence removal improvements | {} |\n",
            evidence_delta.evidence_removal_improvements
        ));
    }
    if evidence_delta.link_added > 0 {
        out.push_str(&format!(
            "| Links added | {} |\n",
            evidence_delta.link_added
        ));
    }
    if evidence_delta.weak_link_added > 0 {
        out.push_str(&format!(
            "| Weak links added | {} |\n",
            evidence_delta.weak_link_added
        ));
    }
    if evidence_delta.broken_link_added > 0 {
        out.push_str(&format!(
            "| Broken links added | {} |\n",
            evidence_delta.broken_link_added
        ));
    }
    if evidence_delta.link_removed > 0 {
        out.push_str(&format!(
            "| Links removed | {} |\n",
            evidence_delta.link_removed
        ));
    }
    if evidence_delta.link_removal_failures > 0 {
        out.push_str(&format!(
            "| Link removal failures | {} |\n",
            evidence_delta.link_removal_failures
        ));
    }
    if evidence_delta.link_removal_review_items > 0 {
        out.push_str(&format!(
            "| Link removal review items | {} |\n",
            evidence_delta.link_removal_review_items
        ));
    }
    if evidence_delta.link_removal_improvements > 0 {
        out.push_str(&format!(
            "| Link removal improvements | {} |\n",
            evidence_delta.link_removal_improvements
        ));
    }
    out.push_str(&format!(
        "| New source findings | {} |\n",
        summary.new_findings
    ));
    out.push_str(&format!(
        "| Removed source findings | {} |\n",
        summary.removed_findings
    ));
    out.push_str(&format!(
        "| Policy failures | {} |\n",
        summary.policy_failures
    ));
    out.push_str(&format!(
        "| Policy review items | {} |\n",
        summary.policy_review_items
    ));
    out.push_str(&format!(
        "| Policy improvements | {} |\n",
        summary.policy_improvements
    ));
    out.push_str(&format!(
        "\n**Reviewer action:** {}\n\n",
        posture.reviewer_action()
    ));
    let evidence_repair_queues = evidence_repair_queues_from_counts(
        broken_evidence_links,
        missing_evidence,
        weak_evidence_references,
    );
    if !evidence_repair_queues.is_empty() {
        out.push_str("**Evidence repair queues:**\n");
        for queue in evidence_repair_queues {
            out.push_str(&format!("- `{}`\n", queue.command));
        }
        out.push('\n');
    }
    out.push_str("> ");
    out.push_str(CLAIM_BOUNDARY_TEXT);
    out.push_str("\n\n");
    append_finding_highlights(&mut out, finding_changes);
    append_policy_highlights(&mut out, policy_changes);
    out
}

fn append_finding_highlights(out: &mut String, finding_changes: &[DiffFindingChange<'_>]) {
    let new_count = finding_changes
        .iter()
        .filter(|change| change.change == "new")
        .count();
    if new_count > 0 {
        out.push_str("### Finding Attention\n\n");
        let include_source_package = finding_changes_have_source_package(finding_changes, "new");
        let include_identity = finding_changes_have_identity(finding_changes, "new");
        append_finding_highlight_header(out, include_source_package, include_identity);
        for change in finding_changes
            .iter()
            .filter(|change| change.change == "new")
            .take(PR_SUMMARY_HIGHLIGHT_LIMIT)
        {
            append_finding_highlight_row(out, change, include_source_package, include_identity);
        }
        append_omitted_summary_note(out, new_count, "new finding change");
        out.push('\n');
    }

    let removed_count = finding_changes
        .iter()
        .filter(|change| change.change == "removed")
        .count();
    if removed_count > 0 {
        out.push_str("### Finding Improvements\n\n");
        let include_source_package =
            finding_changes_have_source_package(finding_changes, "removed");
        let include_identity = finding_changes_have_identity(finding_changes, "removed");
        append_finding_highlight_header(out, include_source_package, include_identity);
        for change in finding_changes
            .iter()
            .filter(|change| change.change == "removed")
            .take(PR_SUMMARY_HIGHLIGHT_LIMIT)
        {
            append_finding_highlight_row(out, change, include_source_package, include_identity);
        }
        append_omitted_summary_note(out, removed_count, "removed finding change");
        out.push('\n');
    }
}

fn append_finding_highlight_header(
    out: &mut String,
    include_source_package: bool,
    include_identity: bool,
) {
    out.push_str("| Change | Kind | Family | Path |");
    if include_source_package {
        out.push_str(" Source Package |");
    }
    if include_identity {
        out.push_str(" Identity |");
    }
    out.push_str("\n|---|---|---|---|");
    if include_source_package {
        out.push_str("---|");
    }
    if include_identity {
        out.push_str("---|");
    }
    out.push('\n');
}

fn append_finding_highlight_row(
    out: &mut String,
    change: &DiffFindingChange<'_>,
    include_source_package: bool,
    include_identity: bool,
) {
    out.push_str(&format!(
        "| `{}` | `{}` | `{}` | `{}` |",
        markdown_cell(change.change),
        markdown_cell(change.kind),
        markdown_cell(change.family.unwrap_or("")),
        markdown_cell(&finding_location(change))
    ));
    if include_source_package {
        out.push_str(&format!(
            " `{}` |",
            markdown_cell(change.source_package.unwrap_or(""))
        ));
    }
    if include_identity {
        out.push_str(&format!(
            " `{}` |",
            markdown_cell(&finding_identity_summary(change))
        ));
    }
    out.push('\n');
}

fn append_policy_highlights(out: &mut String, policy_changes: &[DiffPolicyChange<'_>]) {
    append_policy_severity_highlights(
        out,
        policy_changes,
        "fail",
        "### Policy Failures",
        "policy failure",
    );
    append_policy_severity_highlights(
        out,
        policy_changes,
        "review",
        "### Policy Review Required",
        "policy review item",
    );

    let improvement_count = policy_changes
        .iter()
        .filter(|change| change.severity == "improvement")
        .count();
    if improvement_count > 0 {
        out.push_str("### Policy Improvements\n\n");
        out.push_str("| Allow ID | Kind | Detail | Message |\n|---|---|---|---|\n");
        for change in policy_changes
            .iter()
            .filter(|change| change.severity == "improvement")
            .take(PR_SUMMARY_HIGHLIGHT_LIMIT)
        {
            let detail = policy_change_detail(change).unwrap_or_else(|| "none".to_string());
            out.push_str(&format!(
                "| `{}` | `{}` | {} | {} |\n",
                markdown_cell(change.allow_id),
                markdown_cell(change.kind),
                markdown_cell(&detail),
                markdown_cell(change.message)
            ));
        }
        append_omitted_summary_note(out, improvement_count, "policy improvement change");
        out.push('\n');
    }
}

fn append_policy_severity_highlights(
    out: &mut String,
    policy_changes: &[DiffPolicyChange<'_>],
    severity: &str,
    heading: &str,
    singular_label: &str,
) {
    let count = policy_changes
        .iter()
        .filter(|change| change.severity == severity)
        .count();
    if count == 0 {
        return;
    }

    out.push_str(heading);
    out.push_str("\n\n");
    out.push_str("| Severity | Allow ID | Kind | Detail | Message |\n|---|---|---|---|---|\n");
    for change in policy_changes
        .iter()
        .filter(|change| change.severity == severity)
        .take(PR_SUMMARY_HIGHLIGHT_LIMIT)
    {
        append_policy_highlight_row(out, change);
    }
    append_omitted_summary_note(out, count, singular_label);
    out.push('\n');
}

fn append_omitted_summary_note(out: &mut String, count: usize, singular_label: &str) {
    if count > PR_SUMMARY_HIGHLIGHT_LIMIT {
        let omitted = count - PR_SUMMARY_HIGHLIGHT_LIMIT;
        let plural = if omitted == 1 { "" } else { "s" };
        out.push_str(&format!(
            "\n{omitted} additional {singular_label}{plural} omitted from this summary.\n"
        ));
    }
}

fn append_policy_highlight_row(out: &mut String, change: &DiffPolicyChange<'_>) {
    let detail = policy_change_detail(change).unwrap_or_else(|| "none".to_string());
    out.push_str(&format!(
        "| `{}` | `{}` | `{}` | {} | {} |\n",
        markdown_cell(change.severity),
        markdown_cell(change.allow_id),
        markdown_cell(change.kind),
        markdown_cell(&detail),
        markdown_cell(change.message)
    ));
}

pub fn insert_markdown_pr_summary(text: &mut String, summary: &str) {
    let marker = "Findings scanned:";
    if let Some(index) = text.find(marker) {
        text.insert_str(index, summary);
    } else {
        text.push('\n');
        text.push_str(summary);
    }
}

pub fn render_diff_finding_changes_markdown(changes: &[DiffFindingChange<'_>]) -> String {
    let mut out = String::new();
    out.push_str("\n## Finding Posture Changes\n\n");
    if changes.is_empty() {
        out.push_str("No source finding posture changes detected.\n");
        return out;
    }
    append_finding_changes_markdown_section(&mut out, "Finding Attention", changes, "new");
    append_finding_changes_markdown_section(&mut out, "Finding Improvements", changes, "removed");
    let known_changes = ["new", "removed"];
    if changes
        .iter()
        .any(|change| !known_changes.contains(&change.change))
    {
        out.push_str("### Other Finding Changes\n\n");
        append_finding_changes_markdown_table(
            &mut out,
            changes
                .iter()
                .filter(|change| !known_changes.contains(&change.change)),
        );
    }
    out
}

fn append_finding_changes_markdown_section<'a>(
    out: &mut String,
    heading: &str,
    changes: &'a [DiffFindingChange<'a>],
    change_kind: &str,
) {
    if !changes.iter().any(|change| change.change == change_kind) {
        return;
    }
    out.push_str(&format!("### {heading}\n\n"));
    append_finding_changes_markdown_table(
        out,
        changes.iter().filter(|change| change.change == change_kind),
    );
}

fn append_finding_changes_markdown_table<'a>(
    out: &mut String,
    changes: impl Iterator<Item = &'a DiffFindingChange<'a>>,
) {
    let changes = changes.collect::<Vec<_>>();
    let include_source_package = changes.iter().any(|change| change.source_package.is_some());
    let include_identity = changes.iter().any(|change| change.identity.is_some());
    append_finding_change_table_header(out, include_source_package, include_identity);
    for change in changes.iter().take(DIFF_MARKDOWN_CHANGE_LIMIT) {
        append_finding_change_markdown_row(out, change, include_source_package, include_identity);
    }
    if changes.len() > DIFF_MARKDOWN_CHANGE_LIMIT {
        out.push_str(&format!(
            "\n{} additional finding posture changes omitted.\n",
            changes.len() - DIFF_MARKDOWN_CHANGE_LIMIT
        ));
    }
    out.push('\n');
}

fn append_finding_change_table_header(
    out: &mut String,
    include_source_package: bool,
    include_identity: bool,
) {
    out.push_str("| Change | Kind | Family | Path |");
    if include_source_package {
        out.push_str(" Source Package |");
    }
    if include_identity {
        out.push_str(" Identity |");
    }
    out.push_str("\n|---|---|---|---|");
    if include_source_package {
        out.push_str("---|");
    }
    if include_identity {
        out.push_str("---|");
    }
    out.push('\n');
}

fn append_finding_change_markdown_row(
    out: &mut String,
    change: &DiffFindingChange<'_>,
    include_source_package: bool,
    include_identity: bool,
) {
    out.push_str(&format!(
        "| `{}` | `{}` | `{}` | `{}` |",
        markdown_cell(change.change),
        markdown_cell(change.kind),
        markdown_cell(change.family.unwrap_or("")),
        markdown_cell(&finding_location(change))
    ));
    if include_source_package {
        out.push_str(&format!(
            " `{}` |",
            markdown_cell(change.source_package.unwrap_or(""))
        ));
    }
    if include_identity {
        out.push_str(&format!(
            " `{}` |",
            markdown_cell(&finding_identity_summary(change))
        ));
    }
    out.push('\n');
}

fn finding_location(change: &DiffFindingChange<'_>) -> String {
    match (change.line, change.column) {
        (Some(line), Some(column)) => format!("{}:{line}:{column}", change.path),
        (Some(line), None) => format!("{}:{line}", change.path),
        (None, Some(column)) => format!("{} column={column}", change.path),
        (None, None) => change.path.to_string(),
    }
}

fn finding_identity_summary(change: &DiffFindingChange<'_>) -> String {
    change
        .identity
        .map(structural_identity_summary)
        .unwrap_or_default()
}

fn finding_changes_have_source_package(
    changes: &[DiffFindingChange<'_>],
    change_kind: &str,
) -> bool {
    changes
        .iter()
        .any(|change| change.change == change_kind && change.source_package.is_some())
}

fn finding_changes_have_identity(changes: &[DiffFindingChange<'_>], change_kind: &str) -> bool {
    changes
        .iter()
        .any(|change| change.change == change_kind && change.identity.is_some())
}

pub fn render_diff_policy_changes_markdown(changes: &[DiffPolicyChange<'_>]) -> String {
    let mut out = String::new();
    out.push_str("\n## Policy Posture Changes\n\n");
    if changes.is_empty() {
        out.push_str("No policy weakening detected.\n");
        return out;
    }
    append_policy_changes_markdown_section(&mut out, "Policy Failures", changes, "fail");
    append_policy_changes_markdown_section(&mut out, "Policy Review Required", changes, "review");
    append_policy_changes_markdown_section(&mut out, "Policy Improvements", changes, "improvement");
    let known_severities = ["fail", "review", "improvement"];
    if changes
        .iter()
        .any(|change| !known_severities.contains(&change.severity))
    {
        out.push_str("### Other Policy Changes\n\n");
        append_policy_changes_markdown_table(
            &mut out,
            changes
                .iter()
                .filter(|change| !known_severities.contains(&change.severity)),
        );
    }
    out
}

fn append_policy_changes_markdown_section<'a>(
    out: &mut String,
    heading: &str,
    changes: &'a [DiffPolicyChange<'a>],
    severity: &str,
) {
    if !changes.iter().any(|change| change.severity == severity) {
        return;
    }
    out.push_str(&format!("### {heading}\n\n"));
    append_policy_changes_markdown_table(
        out,
        changes.iter().filter(|change| change.severity == severity),
    );
}

fn append_policy_changes_markdown_table<'a>(
    out: &mut String,
    changes: impl Iterator<Item = &'a DiffPolicyChange<'a>>,
) {
    let changes = changes.collect::<Vec<_>>();
    out.push_str("| Severity | Allow ID | Kind | Detail | Message |\n|---|---|---|---|---|\n");
    for change in changes.iter().take(DIFF_MARKDOWN_CHANGE_LIMIT) {
        let detail = policy_change_detail(change).unwrap_or_else(|| "none".to_string());
        out.push_str(&format!(
            "| `{}` | `{}` | `{}` | {} | {} |\n",
            markdown_cell(change.severity),
            markdown_cell(change.allow_id),
            markdown_cell(change.kind),
            markdown_cell(&detail),
            markdown_cell(change.message)
        ));
    }
    if changes.len() > DIFF_MARKDOWN_CHANGE_LIMIT {
        out.push_str(&format!(
            "\n{} additional policy posture changes omitted.\n",
            changes.len() - DIFF_MARKDOWN_CHANGE_LIMIT
        ));
    }
    out.push('\n');
}