allow-policy-legacy 0.1.9

Legacy policy adapters for cargo-allow migrations.
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145

use toml::Value;

pub(crate) fn normalize_unsafe_family(kind: &str) -> String {
    match kind.trim() {
        "unsafe-block" | "unsafe block" => "unsafe_block".to_string(),
        "unsafe-fn" | "unsafe function" | "unsafe_fn" => "unsafe_fn".to_string(),
        "unsafe-impl" | "unsafe impl" => "unsafe_impl".to_string(),
        "unsafe-trait" | "unsafe trait" => "unsafe_trait".to_string(),
        "unsafe-extern" | "unsafe extern" | "unsafe-extern-block" | "unsafe extern block" => {
            "unsafe_extern_block".to_string()
        }
        "unsafe-attr" | "unsafe attribute" | "unsafe-attribute" => "unsafe_attr".to_string(),
        other => other.replace('-', "_"),
    }
}

pub(crate) fn has_glob_meta(input: &str) -> bool {
    input
        .chars()
        .any(|ch| matches!(ch, '*' | '?' | '[' | ']' | '{' | '}' | ','))
}

pub(crate) fn normalize_legacy_expires(expires: Option<String>) -> Option<String> {
    expires.map(|value| {
        if value == "permanent" {
            "never".to_string()
        } else {
            value
        }
    })
}

pub(crate) fn is_clippy_exceptions_policy(table: &toml::Table) -> bool {
    matches!(
        table.get("policy").and_then(Value::as_str),
        Some("clippy-exceptions" | "clippy-exception-allowlist" | "clippy-allowlist")
    )
}

pub(crate) fn normalize_lint_attribute_family(family: &str) -> String {
    match family.trim() {
        "allow" | "allow-attribute" | "allow_attribute" => "allow_attribute".to_string(),
        "expect" | "expect-attribute" | "expect_attribute" => "expect_attribute".to_string(),
        other => other.to_string(),
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn normalizes_unsafe_family_aliases_and_fallbacks() {
        let cases = [
            (" unsafe-block ", "unsafe_block"),
            ("unsafe block", "unsafe_block"),
            ("unsafe-fn", "unsafe_fn"),
            ("unsafe function", "unsafe_fn"),
            ("unsafe_fn", "unsafe_fn"),
            ("unsafe-impl", "unsafe_impl"),
            ("unsafe impl", "unsafe_impl"),
            ("unsafe-trait", "unsafe_trait"),
            ("unsafe trait", "unsafe_trait"),
            ("unsafe-extern", "unsafe_extern_block"),
            ("unsafe extern", "unsafe_extern_block"),
            ("unsafe-extern-block", "unsafe_extern_block"),
            ("unsafe extern block", "unsafe_extern_block"),
            ("unsafe-attr", "unsafe_attr"),
            ("unsafe attribute", "unsafe_attr"),
            ("unsafe-attribute", "unsafe_attr"),
            ("custom-family", "custom_family"),
        ];

        for (input, expected) in cases {
            assert_eq!(normalize_unsafe_family(input), expected);
        }
    }

    #[test]
    fn detects_glob_meta_characters() {
        for input in [
            "src/*.rs",
            "src/file?.rs",
            "src/[ab].rs",
            "src/file].rs",
            "src/{lib,main}.rs",
            "src/file}.rs",
            "src/lib.rs,src/main.rs",
        ] {
            assert!(has_glob_meta(input));
        }

        assert!(!has_glob_meta("src/lib.rs"));
        assert!(!has_glob_meta("src/path-with-dashes.rs"));
    }

    #[test]
    fn normalizes_legacy_permanent_expiry_only() {
        assert_eq!(
            normalize_legacy_expires(Some("permanent".to_string())),
            Some("never".to_string())
        );
        assert_eq!(
            normalize_legacy_expires(Some("2026-12-31".to_string())),
            Some("2026-12-31".to_string())
        );
        assert_eq!(normalize_legacy_expires(None), None);
    }

    #[test]
    fn recognizes_clippy_exception_policy_aliases() {
        for policy in [
            "clippy-exceptions",
            "clippy-exception-allowlist",
            "clippy-allowlist",
        ] {
            let mut table = toml::Table::new();
            table.insert("policy".to_string(), Value::String(policy.to_string()));

            assert!(is_clippy_exceptions_policy(&table));
        }

        let mut table = toml::Table::new();
        table.insert("policy".to_string(), Value::String("other".to_string()));
        assert!(!is_clippy_exceptions_policy(&table));
        assert!(!is_clippy_exceptions_policy(&toml::Table::new()));
    }

    #[test]
    fn normalizes_lint_attribute_family_aliases_and_fallbacks() {
        let cases = [
            (" allow ", "allow_attribute"),
            ("allow-attribute", "allow_attribute"),
            ("allow_attribute", "allow_attribute"),
            ("expect", "expect_attribute"),
            ("expect-attribute", "expect_attribute"),
            ("expect_attribute", "expect_attribute"),
            ("custom", "custom"),
        ];

        for (input, expected) in cases {
            assert_eq!(normalize_lint_attribute_family(input), expected);
        }
    }
}