allium-cli 3.7.2

CLI for checking Allium specification files
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
//! Cross-module reverse aggregation: an importer's qualified contributions to
//! an imported module's entities and triggers must be credited when both are
//! in the check set. Covers issues #62 (qualified creation), #63 (qualified
//! `provides:`), #64 (a transition witnessed across an import), and #65 (an
//! importer-owned trigger whose binding is typed to the imported entity by a
//! qualified surface context).
//!
//! The oracle throughout is the merged single-file control: the two-file pair
//! must produce exactly what the equivalent one-file spec produces. Analysing
//! the imported module alone must keep its local warnings — crediting requires
//! a real `use` import edge, not arbitrary co-supply.

use std::fs;
use std::path::Path;
use std::process::Command;

fn allium() -> Command {
    Command::new(env!("CARGO_BIN_EXE_allium"))
}

struct Diag {
    code: String,
    message: String,
}

struct Finding {
    kind: String,
    summary: String,
}

fn parse_diagnostics(stdout: &str) -> Vec<Diag> {
    let mut diags = Vec::new();
    for doc in split_json_docs(stdout) {
        if let Ok(v) = serde_json::from_str::<serde_json::Value>(&doc) {
            if let Some(arr) = v["diagnostics"].as_array() {
                for d in arr {
                    if let (Some(c), Some(m)) = (d["code"].as_str(), d["message"].as_str()) {
                        diags.push(Diag { code: c.to_string(), message: m.to_string() });
                    }
                }
            }
        }
    }
    diags
}

fn parse_findings(stdout: &str) -> Vec<Finding> {
    let mut findings = Vec::new();
    for doc in split_json_docs(stdout) {
        if let Ok(v) = serde_json::from_str::<serde_json::Value>(&doc) {
            if let Some(arr) = v["findings"].as_array() {
                for f in arr {
                    let kind = f["type"].as_str().unwrap_or_default().to_string();
                    let summary = f["summary"].as_str().unwrap_or_default().to_string();
                    findings.push(Finding { kind, summary });
                }
            }
        }
    }
    findings
}

/// Split concatenated pretty-printed JSON objects.
fn split_json_docs(s: &str) -> Vec<String> {
    let mut docs = Vec::new();
    let mut depth = 0i32;
    let mut start = None;
    let mut in_str = false;
    let mut escaped = false;
    for (i, ch) in s.char_indices() {
        if in_str {
            if escaped {
                escaped = false;
            } else if ch == '\\' {
                escaped = true;
            } else if ch == '"' {
                in_str = false;
            }
            continue;
        }
        match ch {
            '"' => in_str = true,
            '{' => {
                if depth == 0 {
                    start = Some(i);
                }
                depth += 1;
            }
            '}' => {
                depth -= 1;
                if depth == 0 {
                    if let Some(s_idx) = start {
                        docs.push(s[s_idx..=i].to_string());
                    }
                    start = None;
                }
            }
            _ => {}
        }
    }
    docs
}

struct TempDir {
    path: std::path::PathBuf,
}

impl TempDir {
    fn new(name: &str) -> Self {
        let path = std::env::temp_dir().join(format!("allium-xmod-{name}-{}", std::process::id()));
        let _ = fs::remove_dir_all(&path);
        fs::create_dir_all(&path).unwrap();
        Self { path }
    }

    fn write(&self, name: &str, content: &str) {
        fs::write(self.path.join(name), content).unwrap();
    }

    fn path(&self) -> &Path {
        &self.path
    }

    fn file(&self, name: &str) -> String {
        self.path.join(name).to_string_lossy().into_owned()
    }
}

impl Drop for TempDir {
    fn drop(&mut self) {
        let _ = fs::remove_dir_all(&self.path);
    }
}

fn run(cmd: &str, args: &[&str]) -> (bool, String) {
    let output = allium().arg(cmd).args(args).output().expect("spawn allium");
    (output.status.success(), String::from_utf8_lossy(&output.stdout).into_owned())
}

// ===========================================================================
// Repro sources, transcribed from the issues.
// ===========================================================================

// --- #62: qualified creation ------------------------------------------------

const TICKET_62: &str = r#"-- allium: 3

entity Ticket {
    status: open | closed
}

rule CloseOpenTicket {
    when: CloseTicket(ticket)
    requires: ticket.status = open
    ensures: ticket.status = closed
}

surface TicketWorklist {
    context ticket: Ticket

    exposes:
        ticket.status

    provides:
        CloseTicket(ticket)
            when ticket.status = open
}
"#;

const CONSOLE_62: &str = r#"-- allium: 3

use "./ticket.allium" as tickets

rule CreateTicket {
    when: OpenTicketRequested()

    ensures: tickets/Ticket.created(
        status: open
    )
}

surface TicketIntake {
    provides:
        OpenTicketRequested()
}
"#;

const MERGED_62: &str = r#"-- allium: 3

entity Ticket {
    status: open | closed
}

rule CloseOpenTicket {
    when: CloseTicket(ticket)
    requires: ticket.status = open
    ensures: ticket.status = closed
}

surface TicketWorklist {
    context ticket: Ticket

    exposes:
        ticket.status

    provides:
        CloseTicket(ticket)
            when ticket.status = open
}

rule CreateTicket {
    when: OpenTicketRequested()
    ensures: Ticket.created(status: open)
}

surface TicketIntake {
    provides:
        OpenTicketRequested()
}
"#;

// --- #63: qualified provides ------------------------------------------------

const TICKET_63: &str = r#"-- allium: 3

entity Ticket {
    status: open | closed

    transitions status {
        open -> closed
        terminal: closed
    }
}

rule CreateTicket {
    when: OpenTicket()

    ensures: Ticket.created(
        status: open
    )
}

rule CloseOpenTicket {
    when: CloseTicket(ticket)

    requires: ticket.status = open

    ensures: ticket.status = closed
}
"#;

const CONSOLE_63: &str = r#"-- allium: 3

use "./ticket.allium" as tickets

surface TicketIntake {
    provides:
        tickets/OpenTicket()
        tickets/CloseTicket(ticket)
}
"#;

const MERGED_63: &str = r#"-- allium: 3

entity Ticket {
    status: open | closed

    transitions status {
        open -> closed
        terminal: closed
    }
}

rule CreateTicket {
    when: OpenTicket()
    ensures: Ticket.created(status: open)
}

rule CloseOpenTicket {
    when: CloseTicket(ticket)
    requires: ticket.status = open
    ensures: ticket.status = closed
}

surface TicketIntake {
    provides:
        OpenTicket()
        CloseTicket(ticket)
}
"#;

// --- #64: transition witnessed across an import -----------------------------

const TICKET_64: &str = r#"-- allium: 3

entity Ticket {
    status: closed | archived

    transitions status {
        closed -> archived
        terminal: archived
    }
}

rule CreateTicket {
    when: CreateTicketRequested()

    ensures: Ticket.created(
        status: closed
    )
}

surface TicketDesk {
    provides:
        CreateTicketRequested()
        ArchiveTicketRequested(ticket: Ticket)
            when ticket.status = closed
}
"#;

const CONSOLE_64: &str = r#"-- allium: 3

use "./ticket.allium" as tickets

rule ArchiveClosedTicket {
    when: tickets/ArchiveTicketRequested(ticket)

    requires: ticket.status = closed

    ensures: ticket.status = archived
}
"#;

const MERGED_64: &str = r#"-- allium: 3

entity Ticket {
    status: closed | archived

    transitions status {
        closed -> archived
        terminal: archived
    }
}

rule CreateTicket {
    when: CreateTicketRequested()
    ensures: Ticket.created(status: closed)
}

rule ArchiveClosedTicket {
    when: ArchiveTicketRequested(ticket)
    requires: ticket.status = closed
    ensures: ticket.status = archived
}

surface TicketDesk {
    provides:
        CreateTicketRequested()
        ArchiveTicketRequested(ticket: Ticket)
            when ticket.status = closed
}
"#;

// ===========================================================================
// #62 — qualified imported-entity creation credited to status lifecycle
// ===========================================================================

#[test]
fn t62_qualified_creation_credits_status_in_pair() {
    let dir = TempDir::new("62-pair");
    dir.write("ticket.allium", TICKET_62);
    dir.write("operator-console.allium", CONSOLE_62);

    let (ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    let unreachable: Vec<_> = parse_diagnostics(&stdout)
        .into_iter()
        .filter(|d| d.code == "allium.status.unreachableValue" && d.message.contains("open"))
        .collect();

    assert!(
        unreachable.is_empty(),
        "console creates Ticket with status open — 'open' must be reachable in the pair.\nDiagnostics: {:?}",
        unreachable.iter().map(|d| &d.message).collect::<Vec<_>>()
    );
    assert!(ok, "check on the pair should exit 0 once the creation is credited.\n{stdout}");
}

#[test]
fn t62_status_still_unreachable_when_ticket_checked_alone() {
    let dir = TempDir::new("62-alone");
    dir.write("ticket.allium", TICKET_62);

    let (_ok, stdout) = run("check", &[&dir.file("ticket.allium")]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.status.unreachableValue" && d.message.contains("open")),
        "checked alone, ticket.allium has no assignment of 'open' and must still warn.\n{stdout}"
    );
}

#[test]
fn t62_merged_control_is_clean() {
    let dir = TempDir::new("62-merged");
    dir.write("merged.allium", MERGED_62);

    let (ok, stdout) = run("check", &[&dir.file("merged.allium")]);
    assert!(
        !parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.status.unreachableValue"),
        "merged control must be clean (the oracle).\n{stdout}"
    );
    assert!(ok, "merged control check should exit 0.\n{stdout}");
}

// ===========================================================================
// #63 — qualified `provides: alias/Trigger` credited to trigger reachability
// ===========================================================================

#[test]
fn t63_qualified_provides_credits_triggers_in_pair() {
    let dir = TempDir::new("63-pair");
    dir.write("ticket.allium", TICKET_63);
    dir.write("operator-console.allium", CONSOLE_63);

    let (ok, stdout) = run("analyse", &[dir.path().to_str().unwrap()]);

    let unreachable: Vec<_> = parse_diagnostics(&stdout)
        .into_iter()
        .filter(|d| d.code == "allium.rule.unreachableTrigger")
        .collect();
    assert!(
        unreachable.is_empty(),
        "the console provides both triggers by qualified name — no rule should be unreachable.\nDiagnostics: {:?}",
        unreachable.iter().map(|d| &d.message).collect::<Vec<_>>()
    );

    let findings: Vec<_> = parse_findings(&stdout)
        .into_iter()
        .filter(|f| f.kind == "unreachable_trigger")
        .collect();
    assert!(
        findings.is_empty(),
        "no unreachable_trigger findings expected in the pair.\nFindings: {:?}",
        findings.iter().map(|f| &f.summary).collect::<Vec<_>>()
    );
    assert!(ok, "analyse on the pair should exit 0 once the provides are credited.\n{stdout}");
}

// #109 — qualified `ensures: alias/Trigger(...)` emissions credit reachability
// the same way a qualified `provides:` does.
const EMITTER_109: &str = r#"-- allium: 3

use "./ticket.allium" as ticket

rule Escalate {
    when: Escalated(ticket_ref)
    ensures: ticket/OpenTicket()
}

surface Desk {
    facing _: Actor
    provides:
        Escalated(ticket_ref)
}
"#;

#[test]
fn t109_qualified_emission_credits_imported_listener() {
    let dir = TempDir::new("109-pair");
    dir.write("ticket.allium", TICKET_63);
    dir.write("emitter.allium", EMITTER_109);

    let (_ok, stdout) = run("analyse", &[dir.path().to_str().unwrap()]);
    let unreachable: Vec<String> = parse_diagnostics(&stdout)
        .into_iter()
        .filter(|d| d.code == "allium.rule.unreachableTrigger")
        .map(|d| d.message)
        .collect();
    assert!(
        !unreachable.iter().any(|m| m.contains("CreateTicket")),
        "the emitter emits ticket/OpenTicket, so CreateTicket is reachable.\n{unreachable:?}"
    );
    // Don't overcorrect: CloseTicket is neither provided nor emitted anywhere.
    assert!(
        unreachable.iter().any(|m| m.contains("CloseOpenTicket")),
        "CloseTicket has no source, so CloseOpenTicket stays unreachable.\n{unreachable:?}"
    );
    let findings: Vec<String> = parse_findings(&stdout)
        .into_iter()
        .filter(|f| f.kind == "unreachable_trigger")
        .map(|f| f.summary)
        .collect();
    assert!(
        !findings.iter().any(|f| f.contains("'OpenTicket'")),
        "no unreachable_trigger finding for OpenTicket expected.\n{findings:?}"
    );
}

#[test]
fn t63_triggers_unreachable_when_ticket_analysed_alone() {
    let dir = TempDir::new("63-alone");
    dir.write("ticket.allium", TICKET_63);

    let (_ok, stdout) = run("analyse", &[&dir.file("ticket.allium")]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.rule.unreachableTrigger"),
        "analysed alone, ticket.allium's rules have no local provider and must warn.\n{stdout}"
    );
}

#[test]
fn t63_merged_control_is_clean() {
    let dir = TempDir::new("63-merged");
    dir.write("merged.allium", MERGED_63);

    let (ok, stdout) = run("analyse", &[&dir.file("merged.allium")]);
    assert!(
        !parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.rule.unreachableTrigger"),
        "merged control must be clean (the oracle).\n{stdout}"
    );
    assert!(
        !parse_findings(&stdout).iter().any(|f| f.kind == "unreachable_trigger"),
        "merged control must have no unreachable_trigger findings.\n{stdout}"
    );
    assert!(ok, "merged control analyse should exit 0.\n{stdout}");
}

// The same witness expressed with the `becomes` transition-trigger form, which
// #64 records as failing identically. Same semantics, different trigger syntax.
const CONSOLE_64_BECOMES: &str = r#"-- allium: 3

use "./ticket.allium" as tickets

rule ArchiveClosedTicket {
    when: t: tickets/Ticket.status becomes closed
    ensures: t.status = archived
}
"#;

// ===========================================================================
// #64 — a declared transition witnessed by an importing rule
// ===========================================================================

#[test]
fn t64_qualified_witness_credits_transition_no_deadlock() {
    let dir = TempDir::new("64-pair");
    dir.write("ticket.allium", TICKET_64);
    dir.write("operator-console.allium", CONSOLE_64);

    let (analyse_ok, analyse_out) = run("analyse", &[dir.path().to_str().unwrap()]);
    assert!(
        !parse_findings(&analyse_out).iter().any(|f| f.kind == "deadlock"),
        "the console witnesses closed -> archived — no deadlock should be reported.\nFindings: {:?}",
        parse_findings(&analyse_out).iter().map(|f| f.summary.clone()).collect::<Vec<_>>()
    );
    assert!(analyse_ok, "analyse on the pair should exit 0.\n{analyse_out}");

    let (check_ok, check_out) = run("check", &[dir.path().to_str().unwrap()]);
    let diags = parse_diagnostics(&check_out);
    assert!(
        !diags.iter().any(|d| d.code == "allium.status.noExit" && d.message.contains("closed")),
        "closed has a witnessed exit to archived — no noExit expected.\n{check_out}"
    );
    assert!(
        !diags.iter().any(|d| d.code == "allium.status.unreachableValue" && d.message.contains("archived")),
        "archived is assigned by the witnessing rule — not unreachable.\n{check_out}"
    );
    assert!(check_ok, "check on the pair should exit 0.\n{check_out}");
}

#[test]
fn t64_becomes_form_witness_also_credits_transition() {
    let dir = TempDir::new("64-becomes");
    dir.write("ticket.allium", TICKET_64);
    dir.write("operator-console.allium", CONSOLE_64_BECOMES);

    let (analyse_ok, analyse_out) = run("analyse", &[dir.path().to_str().unwrap()]);
    assert!(
        !parse_findings(&analyse_out).iter().any(|f| f.kind == "deadlock"),
        "the becomes-form witness must credit closed -> archived just as the subscription form does.\nFindings: {:?}",
        parse_findings(&analyse_out).iter().map(|f| f.summary.clone()).collect::<Vec<_>>()
    );
    assert!(analyse_ok, "analyse on the becomes-form pair should exit 0.\n{analyse_out}");

    let (check_ok, check_out) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(check_ok, "check on the becomes-form pair should exit 0.\n{check_out}");
}

#[test]
fn t64_deadlock_when_ticket_analysed_alone() {
    let dir = TempDir::new("64-alone");
    dir.write("ticket.allium", TICKET_64);

    let (_ok, stdout) = run("analyse", &[&dir.file("ticket.allium")]);
    assert!(
        parse_findings(&stdout).iter().any(|f| f.kind == "deadlock"),
        "analysed alone, ticket.allium has no witness for closed -> archived and must deadlock.\n{stdout}"
    );
}

#[test]
fn t64_merged_control_is_clean() {
    let dir = TempDir::new("64-merged");
    dir.write("merged.allium", MERGED_64);

    let (ok, stdout) = run("analyse", &[&dir.file("merged.allium")]);
    assert!(
        !parse_findings(&stdout).iter().any(|f| f.kind == "deadlock"),
        "merged control must have no deadlock (the oracle).\n{stdout}"
    );
    assert!(ok, "merged control analyse should exit 0.\n{stdout}");
}

// ===========================================================================
// #65 — importer owns the trigger; binding typed via a qualified surface context
// ===========================================================================

const TICKET_65: &str = r#"-- allium: 3

entity Ticket {
    status: closed | archived

    transitions status {
        closed -> archived
        terminal: archived
    }
}

rule CreateTicket {
    when: CreateTicketRequested()
    ensures: Ticket.created(status: closed)
}

surface TicketDesk {
    provides:
        CreateTicketRequested()
}
"#;

const CONSOLE_65: &str = r#"-- allium: 3

use "./ticket.allium" as tickets

surface ArchiveDesk {
    context t: tickets/Ticket
    provides:
        ArchiveTicketRequested(t)
            when t.status = closed
}

rule ArchiveClosedTicket {
    when: ArchiveTicketRequested(ticket)
    requires: ticket.status = closed
    ensures: ticket.status = archived
}
"#;

#[test]
fn t65_importer_owned_trigger_credits_transition() {
    let dir = TempDir::new("65-pair");
    dir.write("ticket.allium", TICKET_65);
    dir.write("operator-console.allium", CONSOLE_65);

    let (analyse_ok, analyse_out) = run("analyse", &[dir.path().to_str().unwrap()]);
    assert!(
        !parse_findings(&analyse_out).iter().any(|f| f.kind == "deadlock"),
        "the console witnesses closed -> archived on tickets/Ticket — no deadlock.\nFindings: {:?}",
        parse_findings(&analyse_out).iter().map(|f| f.summary.clone()).collect::<Vec<_>>()
    );
    assert!(analyse_ok, "analyse on the pair should exit 0.\n{analyse_out}");

    let (check_ok, check_out) = run("check", &[dir.path().to_str().unwrap()]);
    let diags = parse_diagnostics(&check_out);
    assert!(
        !diags.iter().any(|d| d.code == "allium.status.noExit" && d.message.contains("closed")),
        "closed has a witnessed exit — no noExit.\n{check_out}"
    );
    assert!(
        !diags.iter().any(|d| d.code == "allium.status.unreachableValue" && d.message.contains("archived")),
        "archived is assigned by the witnessing rule — not unreachable.\n{check_out}"
    );
    assert!(check_ok, "check on the pair should exit 0.\n{check_out}");
}

#[test]
fn t65_deadlock_when_ticket_analysed_alone() {
    let dir = TempDir::new("65-alone");
    dir.write("ticket.allium", TICKET_65);

    let (_ok, stdout) = run("analyse", &[&dir.file("ticket.allium")]);
    assert!(
        parse_findings(&stdout).iter().any(|f| f.kind == "deadlock"),
        "analysed alone, ticket.allium has no witness for closed -> archived and must deadlock.\n{stdout}"
    );
}

// ===========================================================================
// #70 — split-invariance: a spec as one file produces the same reports as the
// same spec split across a `use` edge. The transition-trigger start state must
// be credited locally, not only across the module boundary. This is the #66
// oracle I asserted in prose but never tested, which is how the regression got
// in.
// ===========================================================================

const T70_SINGLE: &str = r#"-- allium: 3

entity Ticket {
    status: closed | archived
    transitions status { closed -> archived  terminal: archived }
}

rule CreateTicket {
    when: CreateTicketRequested()
    ensures: Ticket.created(status: closed)
}

rule ArchiveClosedTicket {
    when: t: Ticket.status becomes closed
    ensures: t.status = archived
}

surface TicketDesk {
    provides:
        CreateTicketRequested()
}
"#;

const T70_DOMAIN: &str = r#"-- allium: 3

entity Ticket {
    status: closed | archived
    transitions status { closed -> archived  terminal: archived }
}

rule CreateTicket {
    when: CreateTicketRequested()
    ensures: Ticket.created(status: closed)
}

surface TicketDesk {
    provides:
        CreateTicketRequested()
}
"#;

const T70_CONSOLE: &str = r#"-- allium: 3

use "./ticket.allium" as tickets

rule ArchiveClosedTicket {
    when: t: tickets/Ticket.status becomes closed
    ensures: t.status = archived
}
"#;

/// A comparable report set (code + message for diagnostics, kind + summary for
/// findings), independent of which file a report lands in.
fn report_set(stdout: &str) -> Vec<String> {
    let mut rows: Vec<String> = parse_diagnostics(stdout)
        .into_iter()
        .map(|d| format!("D {} {}", d.code, d.message))
        .collect();
    rows.extend(
        parse_findings(stdout)
            .into_iter()
            .map(|f| format!("F {} {}", f.kind, f.summary)),
    );
    rows.sort();
    rows
}

#[test]
fn t70_single_file_matches_split_for_becomes_trigger() {
    let single = TempDir::new("70-single");
    single.write("ticket.allium", T70_SINGLE);
    let split = TempDir::new("70-split");
    split.write("ticket.allium", T70_DOMAIN);
    split.write("operator-console.allium", T70_CONSOLE);

    for cmd in ["check", "analyse"] {
        let (_o1, single_out) = run(cmd, &[&single.file("ticket.allium")]);
        let (_o2, split_out) = run(cmd, &[split.path().to_str().unwrap()]);
        assert_eq!(
            report_set(&single_out),
            report_set(&split_out),
            "{cmd}: the one-file spec and its split must produce the same reports.\nsingle: {:?}\nsplit: {:?}",
            report_set(&single_out),
            report_set(&split_out)
        );
    }
}

// A generator-driven version of the split-invariance oracle, so it covers the
// matrix (both trigger forms, varied entity/state names) rather than one cell.
// Seeded SplitMix64, pure std. The CLI is spawned per case, so the seed count is
// modest.

struct Rng(u64);
impl Rng {
    fn new(seed: u64) -> Self {
        Rng(seed.wrapping_mul(0x9E37_79B9_7F4A_7C15).wrapping_add(1))
    }
    fn next(&mut self) -> u64 {
        self.0 = self.0.wrapping_add(0x9E37_79B9_7F4A_7C15);
        let mut z = self.0;
        z = (z ^ (z >> 30)).wrapping_mul(0xBF58_476D_1CE4_E5B9);
        z = (z ^ (z >> 27)).wrapping_mul(0x94D0_49BB_1331_11EB);
        z ^ (z >> 31)
    }
    fn below(&mut self, n: usize) -> usize {
        (self.next() % n as u64) as usize
    }
}

/// One logical spec in two shapes: as a single file, and split into a domain
/// module plus a console module that owns the transition-trigger rule and
/// refers to the entity by qualified name.
fn gen_single_and_split(seed: u64) -> (String, String, String) {
    let mut r = Rng::new(seed);
    let name = format!("E{}", r.below(10000));
    let s0 = format!("a{}", r.below(1000));
    let s1 = format!("b{}", r.below(1000));
    let trig = if r.below(2) == 0 { "becomes" } else { "transitions_to" };

    let entity = format!(
        "entity {name} {{\n    status: {s0} | {s1}\n    transitions status {{ {s0} -> {s1}  terminal: {s1} }}\n}}\n"
    );
    let create = format!(
        "rule Create{name} {{\n    when: Create{name}Requested()\n    ensures: {name}.created(status: {s0})\n}}\n"
    );
    let surface = format!(
        "surface {name}Desk {{\n    provides:\n        Create{name}Requested()\n}}\n"
    );
    let advance_local = format!(
        "rule Advance{name} {{\n    when: t: {name}.status {trig} {s0}\n    ensures: t.status = {s1}\n}}\n"
    );
    let advance_qualified = format!(
        "rule Advance{name} {{\n    when: t: dom/{name}.status {trig} {s0}\n    ensures: t.status = {s1}\n}}\n"
    );

    let single = format!("-- allium: 3\n\n{entity}\n{create}\n{advance_local}\n{surface}");
    let domain = format!("-- allium: 3\n\n{entity}\n{create}\n{surface}");
    let console = format!("-- allium: 3\n\nuse \"./domain.allium\" as dom\n\n{advance_qualified}");
    (single, domain, console)
}

#[test]
fn prop_single_file_matches_split_for_transition_trigger() {
    for seed in 0..16u64 {
        let (single_src, domain_src, console_src) = gen_single_and_split(seed);
        let sdir = TempDir::new(&format!("splitinv-s{seed}"));
        sdir.write("spec.allium", &single_src);
        let pdir = TempDir::new(&format!("splitinv-p{seed}"));
        pdir.write("domain.allium", &domain_src);
        pdir.write("console.allium", &console_src);

        for cmd in ["check", "analyse"] {
            let (_a, single_out) = run(cmd, &[&sdir.file("spec.allium")]);
            let (_b, split_out) = run(cmd, &[pdir.path().to_str().unwrap()]);
            assert_eq!(
                report_set(&single_out),
                report_set(&split_out),
                "seed {seed} {cmd}: one-file spec and its split diverge.\nSINGLE:\n{single_src}\n-> {:?}\n\nSPLIT domain:\n{domain_src}\nconsole:\n{console_src}\n-> {:?}",
                report_set(&single_out),
                report_set(&split_out)
            );
        }
    }
}

// ===========================================================================
// #72 — an unresolvable qualified provides entry is diagnosed at the entry,
// not only as a misleading downstream unreachableTrigger on the imported module.
// ===========================================================================

const TICKET_72: &str = r#"-- allium: 3

entity Ticket {
    status: open | closed
    transitions status { open -> closed  terminal: closed }
}

rule CreateTicket {
    when: OpenTicket()
    ensures: Ticket.created(status: open)
}

rule CloseOpenTicket {
    when: CloseTicket(ticket)
    requires: ticket.status = open
    ensures: ticket.status = closed
}
"#;

const CONSOLE_72_BAD_ALIAS: &str = r#"-- allium: 3

use "./ticket.allium" as tickets

surface TicketIntake {
    provides:
        tickets/OpenTicket()
        nosuch/CloseTicket(ticket)
}
"#;

const CONSOLE_72_BAD_TRIGGER: &str = r#"-- allium: 3

use "./ticket.allium" as tickets

surface TicketIntake {
    provides:
        tickets/OpenTicket()
        tickets/AbsentTrigger()
}
"#;

const CONSOLE_72_OK: &str = r#"-- allium: 3

use "./ticket.allium" as tickets

surface TicketIntake {
    provides:
        tickets/OpenTicket()
        tickets/CloseTicket(ticket)
}
"#;

#[test]
fn t72_unknown_provides_alias_diagnosed_at_entry() {
    let dir = TempDir::new("72-bad-alias");
    dir.write("ticket.allium", TICKET_72);
    dir.write("console.allium", CONSOLE_72_BAD_ALIAS);

    let (_ok, out) = run("check", &[dir.path().to_str().unwrap()]);
    let diags = parse_diagnostics(&out);
    assert!(
        diags.iter().any(|d| d.message.contains("nosuch")),
        "the unresolvable provides alias 'nosuch' must be diagnosed at the entry. Diags: {:?}",
        diags.iter().map(|d| (&d.code, &d.message)).collect::<Vec<_>>()
    );
}

#[test]
fn t72_unknown_provides_trigger_diagnosed_at_entry() {
    let dir = TempDir::new("72-bad-trigger");
    dir.write("ticket.allium", TICKET_72);
    dir.write("console.allium", CONSOLE_72_BAD_TRIGGER);

    let (_ok, out) = run("check", &[dir.path().to_str().unwrap()]);
    let diags = parse_diagnostics(&out);
    assert!(
        diags.iter().any(|d| d.message.contains("AbsentTrigger")),
        "the unknown provides trigger 'AbsentTrigger' must be diagnosed at the entry. Diags: {:?}",
        diags.iter().map(|d| (&d.code, &d.message)).collect::<Vec<_>>()
    );
}

#[test]
fn t72_well_formed_provides_draws_no_resolution_diagnostic() {
    let dir = TempDir::new("72-ok");
    dir.write("ticket.allium", TICKET_72);
    dir.write("console.allium", CONSOLE_72_OK);

    let (_ok, out) = run("check", &[dir.path().to_str().unwrap()]);
    let diags = parse_diagnostics(&out);
    assert!(
        !diags.iter().any(|d| d.code.contains("undefinedImportedAlias")
            || d.code.contains("unknownTrigger")),
        "well-formed qualified provides must not draw resolution diagnostics. Diags: {:?}",
        diags.iter().map(|d| (&d.code, &d.message)).collect::<Vec<_>>()
    );
    // And it stays credited: no rule reads unreachable.
    assert!(
        !diags.iter().any(|d| d.code == "allium.rule.unreachableTrigger"),
        "well-formed provides must keep the domain's rules reachable. Diags: {:?}",
        diags.iter().map(|d| (&d.code, &d.message)).collect::<Vec<_>>()
    );
}

// Anchoring property: corrupting one provides entry (its alias or its trigger
// name) draws a resolution diagnostic naming the bad token, which the
// well-formed variant does not. Generator-driven so it covers varied names.

fn gen_provides_case(seed: u64) -> (String, String, String, String, String, String) {
    let mut r = Rng::new(seed);
    let e = format!("E{}", r.below(10000));
    let t1 = format!("T{}a", r.below(10000));
    let t2 = format!("T{}b", r.below(10000));
    let alias = format!("dom{}", r.below(1000));
    let absent = format!("Absent{}", r.below(10000));

    let domain = format!(
        "-- allium: 3\n\nentity {e} {{\n    status: open | closed\n    transitions status {{ open -> closed  terminal: closed }}\n}}\n\nrule R1 {{\n    when: {t1}()\n    ensures: {e}.created(status: open)\n}}\n\nrule R2 {{\n    when: {t2}(x)\n    requires: x.status = open\n    ensures: x.status = closed\n}}\n"
    );
    let head = format!("-- allium: 3\n\nuse \"./domain.allium\" as {alias}\n\nsurface S {{\n    provides:\n");
    let ok = format!("{head}        {alias}/{t1}()\n        {alias}/{t2}(x)\n}}\n");
    let bad_alias = format!("{head}        {alias}/{t1}()\n        nosuch/{t2}(x)\n}}\n");
    let bad_trigger = format!("{head}        {alias}/{t1}()\n        {alias}/{absent}()\n}}\n");
    (domain, ok, bad_alias, bad_trigger, t2, absent)
}

#[test]
fn prop_malformed_provides_entry_is_anchored() {
    for seed in 0..12u64 {
        let (domain, ok, bad_alias, bad_trigger, _t2, absent) = gen_provides_case(seed);

        let run_case = |label: &str, console: &str| -> Vec<Diag> {
            let dir = TempDir::new(&format!("anchor-{label}-{seed}"));
            dir.write("domain.allium", &domain);
            dir.write("console.allium", console);
            let (_ok, out) = run("check", &[dir.path().to_str().unwrap()]);
            parse_diagnostics(&out)
        };

        let ok_diags = run_case("ok", &ok);
        assert!(
            !ok_diags.iter().any(|d| d.code == "allium.reference.undefinedImportedAlias"
                || d.code == "allium.reference.unknownName"),
            "seed {seed}: well-formed provides drew a resolution diagnostic.\n{:?}",
            ok_diags.iter().map(|d| (&d.code, &d.message)).collect::<Vec<_>>()
        );

        let alias_diags = run_case("badalias", &bad_alias);
        assert!(
            alias_diags.iter().any(|d| d.code == "allium.reference.undefinedImportedAlias"
                && d.message.contains("nosuch")),
            "seed {seed}: a bad provides alias must be anchored.\n{:?}",
            alias_diags.iter().map(|d| (&d.code, &d.message)).collect::<Vec<_>>()
        );

        let trigger_diags = run_case("badtrigger", &bad_trigger);
        assert!(
            trigger_diags.iter().any(|d| d.code == "allium.reference.unknownName"
                && d.message.contains(&absent)),
            "seed {seed}: a bad provides trigger must be anchored.\n{:?}",
            trigger_diags.iter().map(|d| (&d.code, &d.message)).collect::<Vec<_>>()
        );
    }
}

// ===========================================================================
// Gate: crediting requires a real import edge, not arbitrary co-supply
// ===========================================================================

#[test]
fn gate_no_import_edge_means_no_credit() {
    // `unrelated.allium` creates a `Ticket` by bare name but does NOT `use`
    // the domain module. The two files share a directory but no import edge,
    // so the domain's `open` must remain unreachable.
    let dir = TempDir::new("gate-no-edge");
    dir.write("ticket.allium", TICKET_62);
    dir.write(
        "unrelated.allium",
        "-- allium: 3\n\nrule Make {\n    when: Go()\n    ensures: Ticket.created(status: open)\n}\n",
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.status.unreachableValue" && d.message.contains("open")),
        "without a `use` edge, a co-supplied file's creation must not credit the domain.\n{stdout}"
    );
}

// ===========================================================================
// #82: a qualified entity-collection reference (`alias/Tickets`, the plural of
// an imported entity) must not draw `allium.reference.unknownName`. The offered
// set holds declared singular names, never the pluralised collection form, and
// the checker has no pluralisation model, so the name-membership test can
// neither confirm nor refute a collection reference. It leaves them alone. The
// same commit's alias check and its genuine trigger/type checks are unaffected.
// ===========================================================================

const TICKETS_82: &str = "-- allium: 3\n-- tickets.allium\n\n\
    entity Ticket {\n    reference: String\n    escalated: Boolean\n}\n\n\
    rule RaiseTicket {\n    when: TicketRaised()\n    ensures: Ticket.created(reference: \"\", escalated: false)\n}\n\n\
    surface TicketDesk {\n    provides:\n        TicketRaised()\n}\n";

#[test]
fn qualified_collection_reference_is_not_diagnosed_at_any_site() {
    // The homes of an entity collection, per the language reference and the
    // reports: a top-level invariant, a rule-level `for`, a surface `let`, and
    // the receiver of a built-in collection method (#108).
    let sites: [(&str, &str); 5] = [
        (
            "invariant",
            "-- allium: 3\nuse \"./tickets.allium\" as tickets\n\n\
             invariant EveryTicketEscalatable {\n    for t in tickets/Tickets:\n        t.escalated = false or t.escalated = true\n}\n",
        ),
        (
            "rule-for",
            "-- allium: 3\nuse \"./tickets.allium\" as tickets\n\n\
             rule AllEscalated {\n    when: SweepRequested()\n    for t in tickets/Tickets:\n        ensures: t.escalated = true\n}\n\n\
             surface Sweeper {\n    provides:\n        SweepRequested()\n}\n",
        ),
        (
            "surface-let",
            "-- allium: 3\nuse \"./tickets.allium\" as tickets\n\n\
             surface TicketBoard {\n    let open = tickets/Tickets\n    provides:\n        BoardOpened()\n}\n",
        ),
        (
            "method-count",
            "-- allium: 3\nuse \"./tickets.allium\" as tickets\n\n\
             invariant AtMostTenTickets {\n    tickets/Tickets.count <= 10\n}\n",
        ),
        (
            "method-any",
            "-- allium: 3\nuse \"./tickets.allium\" as tickets\n\n\
             invariant SomeTicketIsCalm {\n    tickets/Tickets.any(t => not t.escalated)\n}\n",
        ),
    ];

    for (label, console) in sites {
        let dir = TempDir::new(&format!("i82-{label}"));
        dir.write("tickets.allium", TICKETS_82);
        dir.write("console.allium", console);
        let (ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
        assert!(
            !parse_diagnostics(&stdout)
                .iter()
                .any(|d| d.code == "allium.reference.unknownName"),
            "site {label}: a qualified collection drew a false unknownName.\n{stdout}"
        );
        assert!(ok, "site {label}: a valid qualified collection must exit 0.\n{stdout}");
    }
}

#[test]
fn missing_qualified_trigger_is_still_diagnosed() {
    // Don't overcorrect: a genuinely absent qualified trigger in `provides:` is
    // still anchored. Only collection-position references are exempt.
    let dir = TempDir::new("i82-guard-trigger");
    dir.write("tickets.allium", TICKETS_82);
    dir.write(
        "console.allium",
        "-- allium: 3\nuse \"./tickets.allium\" as tickets\n\n\
         surface S {\n    provides:\n        tickets/NoSuchTrigger()\n}\n",
    );
    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.reference.unknownName" && d.message.contains("NoSuchTrigger")),
        "a missing qualified trigger must still be diagnosed.\n{stdout}"
    );
}

#[test]
fn bad_alias_on_a_collection_is_still_diagnosed() {
    // Don't overcorrect: exempting the name-membership check must not silence
    // the alias check. A collection qualified by an unknown alias still errors.
    let dir = TempDir::new("i82-guard-alias");
    dir.write("tickets.allium", TICKETS_82);
    dir.write(
        "console.allium",
        "-- allium: 3\nuse \"./tickets.allium\" as tickets\n\n\
         invariant I {\n    for t in nosuch/Tickets:\n        t.escalated = true\n}\n",
    );
    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.reference.undefinedImportedAlias" && d.message.contains("nosuch")),
        "an unknown alias on a collection must still be diagnosed.\n{stdout}"
    );
}

#[test]
fn bad_alias_on_a_collection_method_receiver_is_still_diagnosed() {
    let dir = TempDir::new("i108-guard-alias");
    dir.write("tickets.allium", TICKETS_82);
    dir.write(
        "console.allium",
        "-- allium: 3\nuse \"./tickets.allium\" as tickets\n\n\
         invariant I {\n    nosuch/Tickets.count <= 10\n}\n",
    );
    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.reference.undefinedImportedAlias" && d.message.contains("nosuch")),
        "an unknown alias on a method receiver must still be diagnosed.\n{stdout}"
    );
}

// ===========================================================================
// config parameters and deferred declarations resolve through an alias
// ===========================================================================

const CONFIG_DEFERRED_PROVIDER: &str = r#"-- allium: 3
config {
    page_size: Integer = 25
}

deferred ExternalHelper    -- see: elsewhere.allium
"#;

// The config-default reference is the exact form the language reference
// documents ("Config parameter references"): a local parameter defaulting to
// an imported module's config value.
const CONFIG_DEFERRED_CONSUMER: &str = r#"-- allium: 3
use "./provider.allium" as p

config {
    local_page_size: Integer = p/config.page_size
}

surface Api {
    provides:
        Go(size)
}

rule ReadsConfigInRule {
    when: Go(size)

    requires: size > p/config.page_size

    ensures: Accepted(size: size)
}

rule UsesDeferred {
    when: Go(size)

    requires: p/ExternalHelper(size)

    ensures: Delegated(size: size)
}
"#;

#[test]
fn imported_config_and_deferred_references_resolve() {
    // `alias/config.param` is documented ("Config parameter references",
    // checker rule 46) and `alias/DeferredName` names a declaration the
    // module visibly carries; neither may warn unknownName.
    let dir = TempDir::new("config-deferred");
    dir.write("provider.allium", CONFIG_DEFERRED_PROVIDER);
    dir.write("consumer.allium", CONFIG_DEFERRED_CONSUMER);

    let (ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    let false_positives: Vec<_> = parse_diagnostics(&stdout)
        .into_iter()
        .filter(|d| d.code == "allium.reference.unknownName")
        .collect();
    assert!(
        false_positives.is_empty(),
        "config and deferred references through an alias must resolve.\nGot: {:?}",
        false_positives.iter().map(|d| &d.message).collect::<Vec<_>>()
    );
    assert!(ok, "check on the pair should exit 0.\n{stdout}");
}

#[test]
fn a_deferred_name_the_provider_never_declares_still_warns() {
    // Don't overcorrect: a name that is neither declared, referenced,
    // deferred nor `config` still fails membership.
    let dir = TempDir::new("config-deferred-guard");
    dir.write("provider.allium", CONFIG_DEFERRED_PROVIDER);
    dir.write(
        "consumer.allium",
        "-- allium: 3\nuse \"./provider.allium\" as p\n\n\
         surface Api {\n    provides:\n        Go(size)\n}\n\n\
         rule UsesGhost {\n    when: Go(size)\n\n    requires: p/NoSuchDeferred(size)\n\n    ensures: Done(size: size)\n}\n",
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.reference.unknownName" && d.message.contains("NoSuchDeferred")),
        "a name the provider never mentions must still warn.\n{stdout}"
    );
}

#[test]
fn config_reference_against_a_module_without_config_still_warns() {
    // Don't overcorrect: `alias/config` resolves only when the aliased module
    // actually declares a config block.
    let dir = TempDir::new("config-absent-guard");
    dir.write(
        "provider.allium",
        "-- allium: 3\nentity Thing {\n    id: Integer\n}\n",
    );
    dir.write(
        "consumer.allium",
        "-- allium: 3\nuse \"./provider.allium\" as p\n\n\
         surface Api {\n    provides:\n        Go(size)\n}\n\n\
         rule ReadsMissingConfig {\n    when: Go(size)\n\n    requires: size > p/config.page_size\n\n    ensures: Done(size: size)\n}\n",
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.reference.unknownName" && d.message.contains("config")),
        "referencing config on a module with no config block must still warn.\n{stdout}"
    );
}

// ===========================================================================
// Emissions after the first ensures statement export to importers
// ===========================================================================

// A provider whose rules emit triggers in every position an ensures block
// offers: alone, first-of-two, second-of-two, and after an assignment. Plus
// one trigger emitted only through a `requires: ... otherwise:` clause.
const EMISSIONS_PROVIDER: &str = r#"-- allium: 3
surface Api {
    accepts:
        Do1(x)
        Do2(x)
        Do3(x)
        Do4(form)
}

rule ExportsFirst {
    when: Do1(x)

    ensures: AloneEmitted(value: x)
}

rule EmissionAfterEmission {
    when: Do2(x)

    ensures:
        FirstEmitted(value: x)
        SecondEmitted(value: x)
}

rule EmissionAfterAssignment {
    when: Do3(x)

    ensures:
        x.field = 1
        AfterAssignEmitted(value: x)
}

rule ValidatesForm {
    when: Do4(form)

    requires: form.name != null
        otherwise: ValidationFailed(form, "name_required")

    ensures: FormAccepted(form: form)
}
"#;

const EMISSIONS_CONSUMER: &str = r#"-- allium: 3
use "./provider.allium" as p

rule ConsumesAlone {
    when: p/AloneEmitted(value)

    ensures: R1(value: value)
}

rule ConsumesFirst {
    when: p/FirstEmitted(value)

    ensures: R2(value: value)
}

rule ConsumesSecond {
    when: p/SecondEmitted(value)

    ensures: R3(value: value)
}

rule ConsumesAfterAssign {
    when: p/AfterAssignEmitted(value)

    ensures: R4(value: value)
}

rule ConsumesOtherwise {
    when: p/ValidationFailed(form, reason)

    ensures: R5(form: form)
}
"#;

#[test]
fn triggers_emitted_after_the_first_ensures_statement_export_to_importers() {
    // The export table used to register only the first statement of each
    // ensures block, so consumers of SecondEmitted / AfterAssignEmitted drew
    // false unknownName warnings although the emissions are in the provider's
    // text. All emission statements must export.
    let dir = TempDir::new("ensures-export");
    dir.write("provider.allium", EMISSIONS_PROVIDER);
    dir.write("consumer.allium", EMISSIONS_CONSUMER);

    let (ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    let false_positives: Vec<_> = parse_diagnostics(&stdout)
        .into_iter()
        .filter(|d| {
            (d.code == "allium.reference.unknownName"
                || d.code == "allium.rule.unreachableTrigger")
                && ["SecondEmitted", "AfterAssignEmitted", "ValidationFailed"]
                    .iter()
                    .any(|n| d.message.contains(n))
        })
        .collect();
    assert!(
        false_positives.is_empty(),
        "every emission in an ensures block (and an otherwise: emission) must export.\nGot: {:?}",
        false_positives.iter().map(|d| &d.message).collect::<Vec<_>>()
    );
    assert!(ok, "check on the pair should exit 0.\n{stdout}");
}

#[test]
fn a_trigger_the_provider_never_emits_still_warns() {
    // Don't overcorrect: widening the export table must not admit names the
    // provider never mentions anywhere.
    let dir = TempDir::new("ensures-export-guard");
    dir.write("provider.allium", EMISSIONS_PROVIDER);
    dir.write(
        "consumer.allium",
        "-- allium: 3\nuse \"./provider.allium\" as p\n\n\
         rule ConsumesGhost {\n    when: p/NeverEmitted(value)\n\n    ensures: R(value: value)\n}\n",
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.reference.unknownName" && d.message.contains("NeverEmitted")),
        "a trigger the provider never mentions must still warn.\n{stdout}"
    );
}

// ===========================================================================
// #107: a field read through a lifecycle-trigger binding. An importer writes
// `when: ticket: base/Ticket.created` (or `.field becomes v`,
// `.status transitions_to s`, or a temporal `.field <= now`, bare or with
// an offset) and reads `ticket.priority` in the rule body. The qualified
// spelling `base/Ticket.priority` never appears, so the qualified pass
// credited nothing and the imported module reported a field its only reader
// reads.
//
// Same oracles as above: the merged single file is the control, the imported
// module alone keeps its warning, and crediting needs a real `use` edge.
// ===========================================================================

const TICKET_107: &str = r#"-- allium: 3

entity Ticket {
    reference: String
    priority: Integer
    severity: Integer
    due_at: Timestamp
    escalated: Boolean
    owner: String
    status: open | closed
}

rule RaiseTicket {
    when: TicketRaised(reference, severity, due_at)
    ensures: Ticket.created(reference: reference, severity: severity, due_at: due_at, escalated: false, status: open)
}

rule CloseTicket {
    when: TicketClosed(ticket)
    requires: ticket.status = open
    ensures: ticket.status = closed
}

surface TicketDesk {
    facing _: Actor
    provides:
        TicketRaised(reference, severity, due_at)
        TicketClosed(ticket)
}
"#;

/// The three lifecycle-trigger forms the issue names, plus the temporal form
/// the reverse channel already types a binding from, bare and with an offset.
/// Each reads `priority` only through the bound name.
const LIFECYCLE_TRIGGERS_107: [(&str, &str); 5] = [
    ("created", "ticket: base/Ticket.created"),
    ("becomes", "ticket: base/Ticket.severity becomes 5"),
    ("transitions", "ticket: base/Ticket.status transitions_to closed"),
    ("temporal", "ticket: base/Ticket.due_at <= now"),
    ("temporal-offset", "ticket: base/Ticket.due_at + 48.hours <= now"),
];

/// The consumer's rule, reading `priority` only through the trigger binding.
fn rule_107(trigger: &str) -> String {
    format!(
        "rule EscalateUrgentTicket {{\n    when: {trigger}\n    requires: ticket.priority > 3\n    ensures: ticket.escalated = true\n}}\n"
    )
}

fn consumer_107(trigger: &str) -> String {
    format!("-- allium: 3\n\nuse \"./base.allium\" as base\n\n{}", rule_107(trigger))
}

/// The equivalent single file: the consumer's rule with the alias dropped.
fn merged_107(trigger: &str) -> String {
    format!("{TICKET_107}\n{}", rule_107(&trigger.replace("base/", "")))
}

fn unused_field_messages(stdout: &str) -> Vec<String> {
    let mut out: Vec<String> = parse_diagnostics(stdout)
        .into_iter()
        .filter(|d| d.code == "allium.field.unused")
        .map(|d| d.message)
        .collect();
    out.sort();
    out
}

#[test]
fn lifecycle_trigger_binding_read_matches_the_merged_single_file_control() {
    for (label, trigger) in LIFECYCLE_TRIGGERS_107 {
        let pair = TempDir::new(&format!("lifecycle-bound-pair-{label}"));
        pair.write("base.allium", TICKET_107);
        pair.write("consumer.allium", &consumer_107(trigger));
        let (_ok, pair_out) = run("check", &[pair.path().to_str().unwrap()]);

        let one = TempDir::new(&format!("lifecycle-bound-merged-{label}"));
        one.write("merged.allium", &merged_107(trigger));
        let (_ok, one_out) = run("check", &[&one.file("merged.allium")]);

        let from_pair = unused_field_messages(&pair_out);
        let from_one = unused_field_messages(&one_out);
        assert!(
            !from_pair.iter().any(|m| m.contains("Ticket.priority")),
            "[{label}] `ticket.priority` is read off a binding typed by `{trigger}`.\n{pair_out}"
        );
        assert_eq!(
            from_pair, from_one,
            "[{label}] the pair must report exactly what the equivalent one-file spec reports"
        );
        // Precision: the oracle is not vacuous — `owner` is read by nobody and
        // stays reported on both sides.
        assert!(
            from_pair.iter().any(|m| m.contains("Ticket.owner")),
            "[{label}] `owner` is never read and must still be reported.\n{pair_out}"
        );
    }
}

#[test]
fn lifecycle_trigger_binding_imported_module_alone_keeps_its_warning() {
    let dir = TempDir::new("lifecycle-bound-alone");
    dir.write("base.allium", TICKET_107);

    let (_ok, stdout) = run("check", &[&dir.file("base.allium")]);
    assert!(
        unused_field_messages(&stdout).iter().any(|m| m.contains("Ticket.priority")),
        "checked alone, base.allium has no reader for `priority` and must still warn.\n{stdout}"
    );
}

#[test]
fn lifecycle_trigger_binding_without_import_edge_credits_nothing() {
    // The `gate_no_import_edge_means_no_credit` guard, for the bound read: the
    // co-supplied file names `Ticket` bare and has no `use` edge.
    for (label, trigger) in LIFECYCLE_TRIGGERS_107 {
        let dir = TempDir::new(&format!("lifecycle-bound-no-edge-{label}"));
        dir.write("base.allium", TICKET_107);
        dir.write(
            "unrelated.allium",
            &format!("-- allium: 3\n\n{}", rule_107(&trigger.replace("base/", ""))),
        );

        let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
        assert!(
            unused_field_messages(&stdout).iter().any(|m| m.contains("Ticket.priority")),
            "[{label}] without a `use` edge, a co-supplied file's bound read must not credit.\n{stdout}"
        );
    }
}

// ===========================================================================
// related-surface links resolve through an alias
// ===========================================================================

const RELATED_PROVIDER: &str = r#"-- allium: 3
entity User {
    name: String
}

surface MergeWizard {
    facing admin: User

    context source: User

    exposes:
        source.name
}
"#;

// The related: entry is the documented construct for linking to another
// surface, and qualified names are the documented cross-module reference
// form; the expression selects the instance the target's context binds to.
const RELATED_CONSUMER: &str = r#"-- allium: 3
use "./provider.allium" as merge

entity Refusal {
    sso_user: merge/User?
    label: String
}

surface RefusalQueue {
    facing admin: merge/User

    context refusal: Refusal

    exposes:
        refusal.label

    related:
        merge/MergeWizard(refusal.sso_user) when refusal.sso_user != null
}
"#;

#[test]
fn qualified_related_surface_link_resolves() {
    let dir = TempDir::new("related-surface");
    dir.write("provider.allium", RELATED_PROVIDER);
    dir.write("consumer.allium", RELATED_CONSUMER);

    let (ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    let false_positives: Vec<_> = parse_diagnostics(&stdout)
        .into_iter()
        .filter(|d| {
            d.code == "allium.reference.unknownName"
                || d.code == "allium.surface.relatedUndefined"
        })
        .collect();
    assert!(
        false_positives.is_empty(),
        "a related: link to a surface the imported module declares must resolve.\nGot: {:?}",
        false_positives.iter().map(|d| &d.message).collect::<Vec<_>>()
    );
    assert!(ok, "check on the pair should exit 0.\n{stdout}");
}

#[test]
fn merged_single_file_oracle_accepts_the_related_link() {
    // The merged one-file control: the pair above must produce exactly what
    // this produces (nothing).
    let dir = TempDir::new("related-surface-oracle");
    dir.write(
        "merged.allium",
        "-- allium: 3\nentity User {\n    name: String\n}\n\n\
         entity Refusal {\n    sso_user: User?\n    label: String\n}\n\n\
         surface MergeWizard {\n    facing admin: User\n\n    context source: User\n\n    exposes:\n        source.name\n}\n\n\
         surface RefusalQueue {\n    facing admin: User\n\n    context refusal: Refusal\n\n    exposes:\n        refusal.label\n\n    related:\n        MergeWizard(refusal.sso_user) when refusal.sso_user != null\n}\n",
    );

    let (ok, stdout) = run("check", &[&dir.file("merged.allium")]);
    assert!(
        !parse_diagnostics(&stdout).iter().any(|d| {
            d.code == "allium.surface.relatedUndefined"
                || d.code == "allium.reference.unknownName"
        }),
        "the one-file control must accept the same link.\n{stdout}"
    );
    assert!(ok, "check on the merged file should exit 0.\n{stdout}");
}

#[test]
fn a_related_link_to_a_surface_the_provider_never_declares_still_warns() {
    // Don't overcorrect: membership still fails for a surface name the
    // provider never mentions.
    let dir = TempDir::new("related-surface-guard");
    dir.write("provider.allium", RELATED_PROVIDER);
    dir.write(
        "consumer.allium",
        "-- allium: 3\nuse \"./provider.allium\" as merge\n\n\
         entity Refusal {\n    sso_user: merge/User?\n    label: String\n}\n\n\
         surface RefusalQueue {\n    facing admin: merge/User\n\n    context refusal: Refusal\n\n    exposes:\n        refusal.label\n\n    related:\n        merge/NoSuchSurface(refusal.sso_user) when refusal.sso_user != null\n}\n",
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.reference.unknownName" && d.message.contains("NoSuchSurface")),
        "a surface name the provider never declares must still warn.\n{stdout}"
    );
}

#[test]
fn unqualified_related_link_stays_local() {
    // The local check is untouched: an unqualified related: entry resolves
    // against this file's surfaces only, import or no import.
    let dir = TempDir::new("related-surface-local");
    dir.write("provider.allium", RELATED_PROVIDER);
    dir.write(
        "consumer.allium",
        "-- allium: 3\nuse \"./provider.allium\" as merge\n\n\
         entity Refusal {\n    sso_user: merge/User?\n    label: String\n}\n\n\
         surface RefusalQueue {\n    facing admin: merge/User\n\n    context refusal: Refusal\n\n    exposes:\n        refusal.label\n\n    related:\n        MergeWizard(refusal.sso_user) when refusal.sso_user != null\n}\n",
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.surface.relatedUndefined" && d.message.contains("MergeWizard")),
        "an unqualified related: entry must still resolve locally only.\n{stdout}"
    );
}

#[test]
fn a_qualified_surface_name_outside_related_is_disclosed_behaviour() {
    // Disclosed side effect of offering surfaces: membership is a
    // name-existence check, not a kind check, so a qualified reference to a
    // surface name draws no unknownName even where a surface makes no sense
    // (here a when: subscription). A future kind-aware refinement should
    // flip this pin consciously.
    let dir = TempDir::new("related-surface-kindless");
    dir.write("provider.allium", RELATED_PROVIDER);
    dir.write(
        "consumer.allium",
        "-- allium: 3\nuse \"./provider.allium\" as merge\n\n\
         rule ReactsToWizard {\n    when: merge/MergeWizard(user)\n\n    ensures: Logged(user: user)\n}\n",
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        !parse_diagnostics(&stdout)
            .iter()
            .any(|d| d.code == "allium.reference.unknownName" && d.message.contains("MergeWizard")),
        "surface names are offered by name-existence, not by kind.\n{stdout}"
    );
}

#[test]
fn a_default_typed_to_an_imported_surface_is_disclosed_behaviour() {
    // The other disclosed position: a default literal typed to an imported
    // surface loses its unknownName warning along with every other qualified
    // reference to the name, and nothing replaces it — surfaces carry no
    // field schema, so the literal's fields go unvalidated
    // (allium.default.unknownField fires only for entity-typed defaults).
    // Deferred-root-typed defaults already behave the same way. A future
    // kind-aware refinement should flip this pin consciously.
    let dir = TempDir::new("related-surface-default");
    dir.write("provider.allium", RELATED_PROVIDER);
    dir.write(
        "consumer.allium",
        "-- allium: 3\nuse \"./provider.allium\" as merge\n\n\
         default merge/MergeWizard fallback = { nam: \"typo\" }\n",
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        !parse_diagnostics(&stdout).iter().any(|d| {
            (d.code == "allium.reference.unknownName" && d.message.contains("MergeWizard"))
                || d.code == "allium.default.unknownField"
        }),
        "a surface-typed default resolves by name and gets no field validation.\n{stdout}"
    );
}

// ===========================================================================
// A field read across the boundary through a *bound* name. A surface writes
// `context shelf: shelves/Shelf` and reads `shelf.copies`; a rule subscribing
// to a trigger that surface provides reads the same relationship off its own
// trigger binding. The qualified spelling `shelves/Shelf.copies` appears at
// neither site, so the qualified pass credits nothing and the imported module
// reports a field unused that its only reader iterates. Found downstream in
// friend-mesh, where `Group.messages` is read exactly this way.
//
// Same oracles as everywhere above: the merged single file is the control, the
// imported module alone keeps its warning, and crediting needs a real `use`
// edge.
// ===========================================================================

fn unused_fields(stdout: &str) -> Vec<String> {
    parse_diagnostics(stdout)
        .into_iter()
        .filter(|d| d.code == "allium.field.unused")
        .map(|d| d.message)
        .collect()
}

const SHELF_BOUND: &str = r#"-- allium: 3

entity Shelf {
    name: String
    copies: Copy with shelf = this
    catalogue_key: String
}

entity Copy {
    title: String
    shelf: Shelf
}
"#;

const CONSOLE_BOUND: &str = r#"-- allium: 3

use "./shelf.allium" as shelves

surface ShelfView {
    context shelf: shelves/Shelf

    exposes:
        shelf.name
        shelf.copies
}
"#;

const MERGED_BOUND: &str = r#"-- allium: 3

entity Shelf {
    name: String
    copies: Copy with shelf = this
    catalogue_key: String
}

entity Copy {
    title: String
    shelf: Shelf
}

surface ShelfView {
    context shelf: Shelf

    exposes:
        shelf.name
        shelf.copies
}
"#;

#[test]
fn bound_context_read_credits_imported_field() {
    let dir = TempDir::new("bound-pair");
    dir.write("shelf.allium", SHELF_BOUND);
    dir.write("console.allium", CONSOLE_BOUND);

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        !unused_fields(&stdout).iter().any(|m| m.contains("Shelf.copies")),
        "`shelf.copies` is read off a context binding typed to the imported entity.\n{stdout}"
    );
}

#[test]
fn bound_read_leaves_an_unreferenced_field_reported() {
    // Precision: crediting `copies` must not credit the rest of the entity.
    let dir = TempDir::new("bound-precision");
    dir.write("shelf.allium", SHELF_BOUND);
    dir.write("console.allium", CONSOLE_BOUND);

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        unused_fields(&stdout).iter().any(|m| m.contains("Shelf.catalogue_key")),
        "`catalogue_key` is read by nobody and must still be reported.\n{stdout}"
    );
}

#[test]
fn bound_read_matches_the_merged_single_file_control() {
    let pair = TempDir::new("bound-pair-oracle");
    pair.write("shelf.allium", SHELF_BOUND);
    pair.write("console.allium", CONSOLE_BOUND);
    let (_ok, pair_out) = run("check", &[pair.path().to_str().unwrap()]);

    let one = TempDir::new("bound-merged");
    one.write("merged.allium", MERGED_BOUND);
    let (_ok, one_out) = run("check", &[&one.file("merged.allium")]);

    let mut from_pair = unused_fields(&pair_out);
    let mut from_one = unused_fields(&one_out);
    from_pair.sort();
    from_one.sort();
    assert_eq!(
        from_pair, from_one,
        "the pair must report exactly what the equivalent one-file spec reports"
    );
}

#[test]
fn bound_read_imported_module_alone_keeps_its_warning() {
    let dir = TempDir::new("bound-alone");
    dir.write("shelf.allium", SHELF_BOUND);

    let (_ok, stdout) = run("check", &[&dir.file("shelf.allium")]);
    assert!(
        unused_fields(&stdout).iter().any(|m| m.contains("Shelf.copies")),
        "checked alone, shelf.allium has no reader for `copies` and must still warn.\n{stdout}"
    );
}

#[test]
fn gate_no_import_edge_means_no_field_credit() {
    // The `gate_no_import_edge_means_no_credit` guard, for the bound read.
    let dir = TempDir::new("bound-no-edge");
    dir.write("shelf.allium", SHELF_BOUND);
    dir.write(
        "unrelated.allium",
        "-- allium: 3\n\nsurface Stray {\n    context shelf: Shelf\n\n    exposes:\n        shelf.copies\n}\n",
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        unused_fields(&stdout).iter().any(|m| m.contains("Shelf.copies")),
        "without a `use` edge, a co-supplied file's bound read must not credit.\n{stdout}"
    );
}

#[test]
fn rule_trigger_binding_read_credits_imported_field() {
    // The read is in a rule: `shelf` is bound by the trigger, which the
    // importer's own surface typed by passing its `context` binding as the
    // argument. This is friend-mesh's `Group.members` shape.
    let dir = TempDir::new("bound-rule");
    dir.write("shelf.allium", SHELF_BOUND);
    dir.write(
        "console.allium",
        r#"-- allium: 3

use "./shelf.allium" as shelves

surface Desk {
    context shelf: shelves/Shelf

    provides:
        Audit(shelf)
}

rule DoAudit {
    when: Audit(shelf)

    ensures:
        for c in shelf.copies:
            Noted(copy: c)
}
"#,
    );

    let (_ok, stdout) = run("check", &[dir.path().to_str().unwrap()]);
    assert!(
        !unused_fields(&stdout).iter().any(|m| m.contains("Shelf.copies")),
        "a rule binding typed by its trigger reads `shelf.copies`.\n{stdout}"
    );
}