1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461
//! The [`Transaction`] trait, for modifying game objects.
use alloc::string::String;
use alloc::sync::Arc;
use core::any::type_name;
use core::{fmt, mem};
use crate::universe::{Handle, HandleError, UTransactional, UniverseTransaction};
use crate::util::ErrorIfStd;
mod generic;
pub use generic::*;
#[cfg(test)]
mod tester;
#[cfg(test)]
pub use tester::*;
/// A `Transaction` is a description of a mutation to an object or collection thereof that
/// should occur in a logically atomic fashion (all or nothing), with a set of
/// preconditions for it to happen at all.
///
/// Transactions are used:
///
/// * to enable game objects to have effects on their containers in a way compatible
/// with Rust's ownership rules,
/// * to avoid “item duplication” type bugs by checking all preconditions before making
/// any changes, and
/// * to avoid update-order-dependent game mechanics by applying effects in batches.
///
/// A [`Transaction`] is not consumed by committing it; it may be used repeatedly. Future
/// work may include building on this to provide undo/redo functionality.
///
/// If a transaction implements [`Default`], then the default value should be a
/// transaction which has no effects and always succeeds, and is cheap to create.
#[must_use]
pub trait Transaction: Merge {
/// Type of the transaction’s target (what it can be used to mutate).
type Target;
/// Type of a value passed from [`Transaction::check`] to [`Transaction::commit`].
/// This may be used to pass precalculated values to speed up the commit phase,
/// or even lock guards or similar, but also makes it slightly harder to accidentally
/// call `commit` without `check`.
type CommitCheck: 'static;
/// The results of a [`Transaction::commit()`] or [`Transaction::execute()`].
/// Each commit may produce any number of these messages.
///
/// The [`Transaction`] trait imposes no requirements on this value, but it may be
/// a change-notification message which could be redistributed via the target's
/// owner's [`Notifier`](crate::listen::Notifier).
type Output;
/// Error type describing a precondition not met, returned by [`Self::check()`].
///
/// This type should be cheap to construct and drop (hopefully `Copy`) if at all
/// possible, because checks may be done very frequently during simulation; not every
/// such failure is an error of interest to the user.
///
/// Accordingly, it might not describe the _entire_ set of unmet preconditions,
/// but only one example from it, so as to avoid needing to allocate a
/// data structure of arbitrary size.
///
/// This type should implement [`std::error::Error`] when possible.
type Mismatch: fmt::Debug + fmt::Display + 'static;
/// Checks whether the target's current state meets the preconditions and returns
/// [`Err`] if it does not.
///
/// If the preconditions are met, returns [`Ok`] containing data to be passed to
/// [`Transaction::commit`].
fn check(&self, target: &Self::Target) -> Result<Self::CommitCheck, Self::Mismatch>;
/// Perform the mutations specified by this transaction. The `check` value should have
/// been created by a prior call to [`Transaction::check()`].
///
/// Returns [`Ok`] if the transaction completed normally, and [`Err`] if there was a
/// problem which was not detected as a precondition; in this case the transaction may
/// have been partially applied, since that problem was detected too late, by
/// definition. No [`Err`]s should be seen unless there is a bug.
///
/// The `outputs` callback function is called to produce information resulting from
/// the transaction; what that information is is up to the individual transaction type.
///
/// The target should not be mutated between the call to [`Transaction::check()`] and
/// [`Transaction::commit()`] (including via interior mutability, however that applies
/// to the particular `Target` type). The consequences of doing so may include mutating the
/// wrong components, signaling an error partway through the transaction, or merely
/// committing the transaction while its preconditions do not hold.
fn commit(
&self,
target: &mut Self::Target,
check: Self::CommitCheck,
outputs: &mut dyn FnMut(Self::Output),
) -> Result<(), CommitError>;
/// Convenience method to execute a transaction in one step. Implementations should not
/// need to override this. Equivalent to:
///
/// ```rust
/// # use all_is_cubes::transaction::{Transaction, ExecuteError, no_outputs};
/// # use all_is_cubes::universe::{Universe, UniverseTransaction};
/// # let transaction = UniverseTransaction::default();
/// # let target = &mut Universe::new();
/// # let outputs = &mut no_outputs;
/// let check = transaction.check(target).map_err(ExecuteError::Check)?;
/// transaction.commit(target, check, outputs).map_err(ExecuteError::Commit)?;
/// # Ok::<(), ExecuteError<UniverseTransaction>>(())
/// ```
///
/// See also: [`Transactional::transact()`], for building a transaction through mutations.
fn execute(
&self,
target: &mut Self::Target,
outputs: &mut dyn FnMut(Self::Output),
) -> Result<(), ExecuteError<Self>> {
let check = self.check(target).map_err(ExecuteError::Check)?;
self.commit(target, check, outputs)
.map_err(ExecuteError::Commit)
}
/// Specify the target of this transaction as a [`Handle`], and erase its type,
/// so that it can be combined with other transactions in the same universe.
///
/// This is a convenience wrapper around [`UTransactional::bind`].
fn bind(self, target: Handle<Self::Target>) -> UniverseTransaction
where
Self: Sized,
Self::Target: UTransactional<Transaction = Self>,
{
UTransactional::bind(target, self)
}
}
/// Merging two transactions (or, in principle, other values) to produce one result “with
/// the effect of both”. Merging is a commutative, fallible operation.
///
/// This is a separate trait from [`Transaction`] because some components of transactions
/// are mergeable but not executable in isolation.
///
/// TODO: Generalize to different RHS types for convenient combination?
pub trait Merge: Sized {
/// Type of a value passed from [`Merge::check_merge`] to [`Merge::commit_merge`].
/// This may be used to pass precalculated values to speed up the merge phase,
/// but also makes it difficult to accidentally merge without checking.
type MergeCheck: 'static;
/// Error type giving the reason why a merge was not possible.
///
/// This type should be cheap to construct and drop (hopefully `Copy`) if at all possible,
/// because merges may be attempted very frequently during simulation; not every such
/// failure is an error of interest to the user.
///
/// Accordingly, it might not describe the _entire_ area of the conflict
/// but only one example from it, so as to avoid needing to allocate a
/// data structure of arbitrary size.
///
/// This type should implement [`std::error::Error`] when possible.
type Conflict: fmt::Debug + fmt::Display + 'static;
/// Checks whether two transactions can be merged into a single transaction.
/// If so, returns [`Ok`] containing data which may be passed to [`Self::commit_merge()`].
///
/// Generally, “can be merged” means that the two transactions do not have mutually
/// exclusive preconditions and are not specify conflicting mutations. However, the
/// definition of conflict is type-specific; for example, merging two “add 1 to
/// velocity” transactions may produce an “add 2 to velocity” transaction.
///
/// This is not necessarily the same as either ordering of applying the two
/// transactions sequentially. See [`Self::commit_merge()`] for more details.
fn check_merge(&self, other: &Self) -> Result<Self::MergeCheck, Self::Conflict>;
/// Combines `other` into `self` so that it has both effects simultaneously.
/// This operation must be commutative and have [`Default::default()`] as the identity.
///
/// May panic if `check` is not the result of a previous call to
/// `self.check_merge(&other)` or if either transaction was mutated in the intervening
/// time.
fn commit_merge(&mut self, other: Self, check: Self::MergeCheck);
/// Combines two transactions into one which has both effects simultaneously, if possible.
///
/// This is a shortcut for calling [`Self::check_merge`] followed by [`Self::commit_merge`].
/// It should not be necessary to override the provided implementation.
fn merge(mut self, other: Self) -> Result<Self, Self::Conflict> {
self.merge_from(other)?;
Ok(self)
}
/// Combines two transactions into one which has both effects simultaneously, if possible.
///
/// If successful, then `self` now includes `other`. If unsuccessful, `self` is unchanged.
///
/// This is a shortcut for calling [`Self::check_merge`] followed by [`Self::commit_merge`].
/// It should not be necessary to override the provided implementation.
fn merge_from(&mut self, other: Self) -> Result<(), Self::Conflict> {
let check = self.check_merge(&other)?;
self.commit_merge(other, check);
Ok(())
}
}
/// Error type from [`Transaction::execute()`] and [`Transactional::transact()`].
#[allow(clippy::exhaustive_enums)]
pub enum ExecuteError<Txn: Transaction = UniverseTransaction> {
/// A conflict was discovered between parts that were to be assembled into the transaction.
///
/// This error cannot be produced by [`Transaction::execute()`], but only by
/// [`Transactional::transact()`].
Merge(<Txn as Merge>::Conflict),
/// The transaction's preconditions were not met; it does not apply to the current
/// state of the target. No change has been made.
Check(<Txn as Transaction>::Mismatch),
/// An unexpected error occurred while applying the transaction's effects.
/// See the documentation of [`Transaction::commit()`] for the unfortunate
/// implications of this.
Commit(CommitError),
/// Executing the transaction required accessing a [`Handle`] that was unavailable.
///
/// The [`HandleError`] will include the name of the problematic handle.
///
/// This error may be transient, and
/// unlike [`ExecuteError::Commit`], does not indicate data corruption,
/// but code which triggers it should generally be considered incorrect.
///
/// Note that this error is returned by [`Handle::execute()`], but transactions whose
/// `check` involves accessing handles will instead produce [`ExecuteError::Check`]s.
/// This may change in the future.
Handle(HandleError),
}
// Manual impl required to set proper associated type bounds.
impl<Txn> Clone for ExecuteError<Txn>
where
Txn: Transaction<Mismatch: Clone> + Merge<Conflict: Clone>,
{
fn clone(&self) -> Self {
match self {
Self::Merge(e) => Self::Merge(e.clone()),
Self::Check(e) => Self::Check(e.clone()),
Self::Commit(e) => Self::Commit(e.clone()),
Self::Handle(e) => Self::Handle(e.clone()),
}
}
}
crate::util::cfg_should_impl_error! {
impl<Txn> std::error::Error for ExecuteError<Txn>
where
Txn: Transaction<Mismatch: std::error::Error + 'static> + Merge<Conflict: std::error::Error + 'static>,
{
fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
match self {
ExecuteError::Merge(e) => e.source(),
ExecuteError::Check(e) => e.source(),
ExecuteError::Commit(e) => e.source(),
ExecuteError::Handle(e) => e.source(),
}
}
}
}
impl<Txn> fmt::Debug for ExecuteError<Txn>
where
Txn: Transaction<Mismatch: fmt::Debug> + Merge<Conflict: fmt::Debug>,
{
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
Self::Merge(e) => f.debug_tuple("Merge").field(e).finish(),
Self::Check(e) => f.debug_tuple("Check").field(e).finish(),
Self::Commit(e) => f.debug_tuple("Commit").field(e).finish(),
Self::Handle(e) => f.debug_tuple("Handle").field(e).finish(),
}
}
}
impl<Txn> fmt::Display for ExecuteError<Txn>
where
Txn: Transaction<Mismatch: fmt::Display> + Merge<Conflict: fmt::Display>,
{
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
ExecuteError::Merge(e) => e.fmt(f),
ExecuteError::Check(e) => e.fmt(f),
ExecuteError::Commit(e) => e.fmt(f),
ExecuteError::Handle(e) => e.fmt(f),
}
}
}
/// Note: [`ExecuteError::Commit`] never compares equal, because it contains
/// arbitrary errors which may not implement [`PartialEq`].
/// TODO: push this down to `impl PartialEq for CommitError` for more precision.
impl<Txn> PartialEq for ExecuteError<Txn>
where
Txn: Transaction<Mismatch: PartialEq> + Merge<Conflict: PartialEq>,
{
fn eq(&self, other: &Self) -> bool {
match (self, other) {
(Self::Merge(a), Self::Merge(b)) => a == b,
(Self::Check(a), Self::Check(b)) => a == b,
(Self::Commit(_), Self::Commit(_)) => false,
(Self::Handle(a), Self::Handle(b)) => a == b,
_ => false,
}
}
}
/// Type of “unexpected errors” from [`Transaction::commit()`].
//---
// Design note: `CommitError` doesn't need to be cheap because it should never happen
// during normal game operation; it exists because we want to do better than panicking
// if it does, and give a report that's detailed enough that someone might be able to
// fix the underlying bug.
#[derive(Clone, Debug, displaydoc::Display)]
#[displaydoc("Unexpected error while committing a transaction")]
pub struct CommitError(CommitErrorKind);
#[derive(Clone, Debug, displaydoc::Display)]
enum CommitErrorKind {
#[displaydoc("{transaction_type}::commit() failed")]
Leaf {
transaction_type: &'static str,
error: Arc<dyn ErrorIfStd + Send + Sync>,
},
#[displaydoc("{transaction_type}::commit() failed: {message}")]
LeafMessage {
transaction_type: &'static str,
message: String,
},
/// One of the component transactions in this transaction failed.
#[displaydoc("in transaction part '{component}'")]
Context {
component: String,
error: Arc<CommitError>, // must box recursion, might as well Arc
},
}
impl CommitError {
/// Wrap an arbitrary unexpected error as a [`CommitError`].
/// `T` should be the type of the transaction that caught it.
#[must_use]
pub fn catch<T, E: ErrorIfStd + Send + Sync + 'static>(error: E) -> Self {
CommitError(CommitErrorKind::Leaf {
transaction_type: type_name::<T>(),
error: Arc::new(error),
})
}
/// Construct a [`CommitError`] with a string description.
/// `T` should be the type of the transaction that detected the problem.
#[must_use]
pub fn message<T>(message: String) -> Self {
CommitError(CommitErrorKind::LeafMessage {
transaction_type: type_name::<T>(),
message,
})
}
/// Report an error propagating up from an inner transaction.
/// `component` should describe which part of the current transaction
/// returned the error from its `commit()`.
#[must_use]
pub fn context(self, component: String) -> Self {
CommitError(CommitErrorKind::Context {
component,
error: Arc::new(self),
})
}
}
crate::util::cfg_should_impl_error! {
impl std::error::Error for CommitError {
fn source(&self) -> Option<&(dyn std::error::Error + 'static)> {
match &self.0 {
CommitErrorKind::Leaf { error, .. } => Some(error),
CommitErrorKind::LeafMessage { .. } => None,
CommitErrorKind::Context { error, .. } => Some(error),
}
}
}
}
/// Specifies a canonical [`Transaction`] type for the implementing type.
///
/// For a given `T`, [`Transaction<Target = T>`] may be implemented by multiple types,
/// but there can be at most one `<T as Transactional>::Transaction`.
pub trait Transactional {
/// The type of transaction which should be used with `Self`.
type Transaction: Transaction<Target = Self>;
/// Convenience method for building and then applying a transaction to `self`,
/// equivalent to the following steps:
///
/// 1. Call [`default()`](Default::default()) to create the transaction.
/// 2. Mutate the transaction using the function `f`.
/// 3. Call [`Transaction::execute()`] with `self`.
///
/// `f` is given an empty transaction to write into,
/// and a reference to `self` in case it is needed.
/// It may return merge conflict errors, or a successful return value of any type.
///
/// The transaction must not have outputs.
///
/// # Design note
///
/// Ideally, we would have an `async` version of this function too, but that
/// is not possible, because the required borrowing pattern is not currently
/// expressible when writing the future-returning closure it would require.
fn transact<F, O>(&mut self, f: F) -> Result<O, ExecuteError<Self::Transaction>>
where
F: FnOnce(
&mut Self::Transaction,
&Self,
) -> Result<O, <Self::Transaction as Merge>::Conflict>,
Self::Transaction: Transaction<Target = Self, Output = NoOutput> + Default,
{
let mut transaction = Self::Transaction::default();
let output = f(&mut transaction, self).map_err(ExecuteError::Merge)?;
transaction.execute(self, &mut no_outputs)?;
Ok(output)
}
}
/// Type of `Output` for a [`Transaction`] that never produces any outputs.
pub type NoOutput = core::convert::Infallible; // TODO: use `!` never type if it stabilizes
/// Output callback function for committing a [`Transaction`] whose `Output` type is
/// [`NoOutput`] and therefore cannot produce any outputs.
pub fn no_outputs(_: NoOutput) {}
/// Implementation of committing a merge for two [`Option`]al fields.
///
/// `if_both` is called in the case where both Options have a value.
pub(crate) fn merge_option<T>(this: &mut Option<T>, other: Option<T>, if_both: fn(T, T) -> T) {
match (this, other) {
(None, None) => {}
(this @ None, other @ Some(_)) => *this = other,
(Some(_), None) => {}
(this @ Some(_), Some(other)) => *this = Some(if_both(mem::take(this).unwrap(), other)),
}
}
/// For use with `merge_option()`.
#[track_caller]
#[allow(clippy::needless_pass_by_value)]
pub(crate) fn panic_if_not_equal<T: fmt::Debug + PartialEq>(a: T, b: T) -> T {
if a == b {
a
} else {
panic!(
"transaction being merged contains conflicting elements:\n\
left: {a:#?}\n
right: {b:#?}",
);
}
}