use alint_core::{
Context, Error, FixSpec, Fixer, Level, PathsSpec, Result, Rule, RuleSpec, Scope, Violation,
};
use crate::fixers::FileRemoveFixer;
#[derive(Debug)]
pub struct FileAbsentRule {
id: String,
level: Level,
policy_url: Option<String>,
message: Option<String>,
scope: Scope,
patterns: Vec<String>,
git_tracked_only: bool,
fixer: Option<FileRemoveFixer>,
}
impl Rule for FileAbsentRule {
fn id(&self) -> &str {
&self.id
}
fn level(&self) -> Level {
self.level
}
fn policy_url(&self) -> Option<&str> {
self.policy_url.as_deref()
}
fn wants_git_tracked(&self) -> bool {
self.git_tracked_only
}
fn requires_full_index(&self) -> bool {
true
}
fn path_scope(&self) -> Option<&Scope> {
Some(&self.scope)
}
fn evaluate(&self, ctx: &Context<'_>) -> Result<Vec<Violation>> {
let mut violations = Vec::new();
for entry in ctx.index.files() {
if !self.scope.matches(&entry.path) {
continue;
}
if self.git_tracked_only && !ctx.is_git_tracked(&entry.path) {
continue;
}
let msg = self.message.clone().unwrap_or_else(|| {
let tracked = if self.git_tracked_only {
" and tracked in git"
} else {
""
};
format!(
"file is forbidden (matches [{}]{tracked}): {}",
self.patterns.join(", "),
entry.path.display()
)
});
violations.push(Violation::new(msg).with_path(entry.path.clone()));
}
Ok(violations)
}
fn fixer(&self) -> Option<&dyn Fixer> {
self.fixer.as_ref().map(|f| f as &dyn Fixer)
}
}
pub fn build(spec: &RuleSpec) -> Result<Box<dyn Rule>> {
alint_core::reject_scope_filter_on_cross_file(spec, "file_absent")?;
let Some(paths) = &spec.paths else {
return Err(Error::rule_config(
&spec.id,
"file_absent requires a `paths` field",
));
};
let fixer = match &spec.fix {
Some(FixSpec::FileRemove { .. }) => Some(FileRemoveFixer),
Some(other) => {
return Err(Error::rule_config(
&spec.id,
format!("fix.{} is not compatible with file_absent", other.op_name()),
));
}
None => None,
};
Ok(Box::new(FileAbsentRule {
id: spec.id.clone(),
level: spec.level,
policy_url: spec.policy_url.clone(),
message: spec.message.clone(),
scope: Scope::from_paths_spec(paths)?,
patterns: patterns_of(paths),
git_tracked_only: spec.git_tracked_only,
fixer,
}))
}
fn patterns_of(spec: &PathsSpec) -> Vec<String> {
match spec {
PathsSpec::Single(s) => vec![s.clone()],
PathsSpec::Many(v) => v.clone(),
PathsSpec::IncludeExclude { include, .. } => include.clone(),
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::test_support::{ctx, index, spec_yaml};
use std::path::Path;
#[test]
fn build_rejects_missing_paths_field() {
let spec = spec_yaml(
"id: t\n\
kind: file_absent\n\
level: error\n",
);
let err = build(&spec).unwrap_err().to_string();
assert!(err.contains("paths"), "unexpected: {err}");
}
#[test]
fn build_rejects_incompatible_fix_op() {
let spec = spec_yaml(
"id: t\n\
kind: file_absent\n\
paths: \"*.bak\"\n\
level: error\n\
fix:\n \
file_create:\n \
content: \"\"\n",
);
let err = build(&spec).unwrap_err().to_string();
assert!(err.contains("file_create"), "unexpected: {err}");
}
#[test]
fn build_accepts_file_remove_fix() {
let spec = spec_yaml(
"id: t\n\
kind: file_absent\n\
paths: \"*.bak\"\n\
level: error\n\
fix:\n \
file_remove: {}\n",
);
let rule = build(&spec).expect("valid file_remove fix");
assert!(rule.fixer().is_some(), "fixer should be present");
}
#[test]
fn evaluate_passes_when_no_match_present() {
let spec = spec_yaml(
"id: t\n\
kind: file_absent\n\
paths: \"*.bak\"\n\
level: error\n",
);
let rule = build(&spec).unwrap();
let idx = index(&["src/main.rs", "README.md"]);
let v = rule.evaluate(&ctx(Path::new("/fake"), &idx)).unwrap();
assert!(v.is_empty(), "unexpected: {v:?}");
}
#[test]
fn evaluate_fires_one_violation_per_match() {
let spec = spec_yaml(
"id: t\n\
kind: file_absent\n\
paths: \"**/*.bak\"\n\
level: error\n",
);
let rule = build(&spec).unwrap();
let idx = index(&["a.bak", "src/b.bak", "ok.txt"]);
let v = rule.evaluate(&ctx(Path::new("/fake"), &idx)).unwrap();
assert_eq!(v.len(), 2, "expected one violation per .bak: {v:?}");
}
#[test]
fn evaluate_silent_when_git_tracked_only_outside_repo() {
let spec = spec_yaml(
"id: t\n\
kind: file_absent\n\
paths: \"*.bak\"\n\
level: error\n\
git_tracked_only: true\n",
);
let rule = build(&spec).unwrap();
let idx = index(&["a.bak"]);
let v = rule.evaluate(&ctx(Path::new("/fake"), &idx)).unwrap();
assert!(
v.is_empty(),
"git_tracked_only without ctx.git_tracked must no-op: {v:?}",
);
}
#[test]
fn rule_advertises_full_index_requirement() {
let spec = spec_yaml(
"id: t\n\
kind: file_absent\n\
paths: \".env\"\n\
level: error\n",
);
let rule = build(&spec).unwrap();
assert!(rule.requires_full_index());
}
}