alien-bindings 3.3.27

Alien direct in-process resource bindings
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
use super::*;
use crate::remote::access::RemoteBindingSelector;

#[tokio::test]
async fn preissued_manager_access_loads_a_binding_without_platform_discovery() {
    let expires_at = Utc::now() + ChronoDuration::minutes(5);
    let response = Arc::new(StdRwLock::new((
        StatusCode::OK,
        json!({
            "service": "s3",
            "binding": { "bucketName": "customer-bucket" },
            "clientConfig": {
                "accountId": "123456789012",
                "region": "us-east-1",
                "credentials": {
                    "type": "sessionCredentials",
                    "accessKeyId": "AKIAEXAMPLE",
                    "secretAccessKey": "secret",
                    "sessionToken": "session",
                    "expiresAt": expires_at.to_rfc3339(),
                },
            },
            "expiresAt": expires_at.to_rfc3339(),
        }),
    )));
    let requests = Arc::new(StdMutex::new(Vec::new()));
    let manager_url = spawn_generated_contract_server(GeneratedContractState {
        response,
        requests: requests.clone(),
    })
    .await;

    let bindings = RemoteBindings::from_manager_access(
        DEPLOYMENT_ID,
        &manager_url,
        GENERATED_MANAGER_TOKEN,
        expires_at,
    )
    .expect("construct bindings from assigned Manager access");
    bindings
        .storage("files")
        .await
        .expect("resolve the binding directly through Manager");

    assert_eq!(
        requests
            .lock()
            .expect("generated contract requests lock")
            .as_slice(),
        &[RecordedRequest {
            method: "POST".to_string(),
            path: "/v1/bindings/resolve".to_string(),
            authorization: Some(format!("Bearer {GENERATED_MANAGER_TOKEN}")),
            body: Some(json!({
                "deploymentId": DEPLOYMENT_ID,
                "resourceId": "files",
            })),
        }]
    );
}

#[tokio::test]
async fn generated_manager_adapter_decodes_cloud_lease_and_structured_error() {
    let response = Arc::new(StdRwLock::new((
        StatusCode::OK,
        json!({
            "service": "s3",
            "binding": { "bucketName": "customer-bucket" },
            "clientConfig": {
                "accountId": "123456789012",
                "region": "us-east-1",
                "credentials": {
                    "type": "sessionCredentials",
                    "accessKeyId": "AKIAEXAMPLE",
                    "secretAccessKey": "secret",
                    "sessionToken": "session",
                    "expiresAt": at(3600).to_rfc3339(),
                },
            },
            "expiresAt": at(3600).to_rfc3339(),
        }),
    )));
    let requests = Arc::new(StdMutex::new(Vec::new()));
    let manager_url = spawn_generated_contract_server(GeneratedContractState {
        response: response.clone(),
        requests: requests.clone(),
    })
    .await;
    let adapter = GeneratedManagerBindingResolver;
    let manager_url = reqwest::Url::parse(&manager_url).expect("valid manager URL");
    let manager = DiscoveredManager {
        deployment_id: DEPLOYMENT_ID.to_string(),
        url: manager_url,
        http: authenticated_http_client(GENERATED_MANAGER_TOKEN, "generated manager fixture")
            .expect("build generated contract client"),
        refresh_at: at(300),
        generation: 0,
    };

    let lease = adapter
        .resolve(
            &manager,
            DEPLOYMENT_ID,
            RemoteBindingSelector::Resource("files"),
        )
        .await
        .expect("generated client should decode an S3 lease");
    let ResolvedRemoteBinding::S3 {
        binding,
        client_config,
        expires_at,
    } = lease
    else {
        panic!("generated client returned the wrong lease variant for S3");
    };
    assert_eq!(
        binding.bucket_name,
        alien_core::BindingValue::Value("customer-bucket".to_string())
    );
    assert_eq!(client_config.account_id, "123456789012");
    assert_eq!(client_config.region, "us-east-1");
    assert!(client_config.service_overrides.is_none());
    let alien_core::AwsCredentials::SessionCredentials {
        access_key_id,
        secret_access_key,
        session_token,
        expires_at: credential_expires_at,
    } = client_config.credentials
    else {
        panic!("generated client returned a non-session AWS credential");
    };
    assert_eq!(access_key_id, "AKIAEXAMPLE");
    assert_eq!(secret_access_key, "secret");
    assert_eq!(session_token, "session");
    assert_eq!(credential_expires_at, at(3600).to_rfc3339());
    assert_eq!(expires_at, at(3600));
    assert_eq!(
        requests
            .lock()
            .expect("generated contract requests lock")
            .as_slice(),
        &[RecordedRequest {
            method: "POST".to_string(),
            path: "/v1/bindings/resolve".to_string(),
            authorization: Some(format!("Bearer {GENERATED_MANAGER_TOKEN}")),
            body: Some(json!({
                "deploymentId": DEPLOYMENT_ID,
                "resourceId": "files",
            })),
        }]
    );

    *response.write().expect("generated contract response lock") = (
        StatusCode::OK,
        json!({
            "service": "blob",
            "binding": {
                "accountName": "customeraccount",
                "containerName": "customer-container",
            },
            "clientConfig": {
                "subscriptionId": "subscription-id",
                "tenantId": "tenant-id",
                "region": "eastus",
                "credentials": {
                    "type": "accessToken",
                    "token": "azure-storage-token",
                },
            },
            "expiresAt": at(3600).to_rfc3339(),
        }),
    );
    let lease = adapter
        .resolve(
            &manager,
            DEPLOYMENT_ID,
            RemoteBindingSelector::Resource("files"),
        )
        .await
        .expect("generated client should decode a Blob lease");
    let ResolvedRemoteBinding::Blob {
        binding,
        client_config,
        expires_at,
    } = lease
    else {
        panic!("generated client returned the wrong lease variant for Blob");
    };
    assert_eq!(
        binding.account_name,
        alien_core::BindingValue::Value("customeraccount".to_string())
    );
    assert_eq!(
        binding.container_name,
        alien_core::BindingValue::Value("customer-container".to_string())
    );
    assert_eq!(client_config.subscription_id, "subscription-id");
    assert_eq!(client_config.tenant_id, "tenant-id");
    assert_eq!(client_config.region.as_deref(), Some("eastus"));
    assert!(client_config.service_overrides.is_none());
    let alien_core::AzureCredentials::AccessToken { token } = client_config.credentials else {
        panic!("generated client returned the wrong Azure credential type");
    };
    assert_eq!(token, "azure-storage-token");
    assert_eq!(expires_at, at(3600));

    *response.write().expect("generated contract response lock") = (
        StatusCode::OK,
        json!({
            "service": "gcs",
            "binding": { "bucketName": "customer-bucket" },
            "clientConfig": {
                "projectId": "customer-project",
                "projectNumber": "123456789",
                "region": "us-central1",
                "credentials": {
                    "type": "accessToken",
                    "token": "gcp-access-token",
                },
            },
            "expiresAt": at(3600).to_rfc3339(),
        }),
    );
    let lease = adapter
        .resolve(
            &manager,
            DEPLOYMENT_ID,
            RemoteBindingSelector::Resource("files"),
        )
        .await
        .expect("generated client should decode a GCS lease");
    let ResolvedRemoteBinding::Gcs {
        binding,
        client_config,
        expires_at,
    } = lease
    else {
        panic!("generated client returned the wrong lease variant for GCS");
    };
    assert_eq!(
        binding.bucket_name,
        alien_core::BindingValue::Value("customer-bucket".to_string())
    );
    assert_eq!(client_config.project_id, "customer-project");
    assert_eq!(client_config.project_number.as_deref(), Some("123456789"));
    assert_eq!(client_config.region, "us-central1");
    assert!(client_config.service_overrides.is_none());
    let alien_core::GcpCredentials::AccessToken { token } = client_config.credentials else {
        panic!("generated client returned the wrong GCP credential type");
    };
    assert_eq!(token, "gcp-access-token");
    assert_eq!(expires_at, at(3600));

    *response.write().expect("generated contract response lock") = (
        StatusCode::OK,
        json!({
            "service": "s3",
            "binding": { "bucketName": "customer-bucket" },
            "clientConfig": {
                "accountId": "123456789012",
                "region": "us-east-1",
                "credentials": {
                    "type": "sessionCredentials",
                    "accessKeyId": "SENTINEL_ACCESS_KEY",
                    "secretAccessKey": "SENTINEL_SECRET_KEY",
                    "sessionToken": "SENTINEL_SESSION_TOKEN",
                    "expiresAt": at(3600).to_rfc3339(),
                },
            },
            "expiresAt": "not-a-timestamp",
        }),
    );
    let error = match adapter
        .resolve(
            &manager,
            DEPLOYMENT_ID,
            RemoteBindingSelector::Resource("files"),
        )
        .await
    {
        Ok(_) => panic!("an invalid lease expiry must fail typed conversion"),
        Err(error) => error,
    };
    let error_debug = format!("{error:?}");
    for secret in [
        "SENTINEL_ACCESS_KEY",
        "SENTINEL_SECRET_KEY",
        "SENTINEL_SESSION_TOKEN",
    ] {
        assert!(
            !error_debug.contains(secret),
            "typed conversion errors must not retain response credentials"
        );
    }

    *response.write().expect("generated contract response lock") = (
        StatusCode::FORBIDDEN,
        json!({
            "code": "FORBIDDEN",
            "message": "Remote access was revoked",
            "retryable": false,
            "internal": false,
            "httpStatusCode": 403,
        }),
    );
    let error = match adapter
        .resolve(
            &manager,
            DEPLOYMENT_ID,
            RemoteBindingSelector::Resource("files"),
        )
        .await
    {
        Ok(_) => panic!("generated client should preserve a structured manager error"),
        Err(error) => error,
    };
    assert_eq!(error.code, "FORBIDDEN");
    assert_eq!(error.message, "Remote access was revoked");
    assert!(!error.retryable);
    assert_eq!(error.http_status_code, Some(403));
}

#[tokio::test]
async fn remote_ai_returns_a_typed_redacted_bedrock_lease() {
    let expires_at = Utc::now() + ChronoDuration::minutes(5);
    let response = Arc::new(StdRwLock::new((
        StatusCode::OK,
        json!({
            "service": "bedrock",
            "resourceId": "models",
            "binding": { "region": "us-east-1" },
            "clientConfig": {
                "accountId": "123456789012",
                "region": "us-east-1",
                "credentials": {
                    "type": "sessionCredentials",
                    "accessKeyId": "SENTINEL_ACCESS_KEY",
                    "secretAccessKey": "SENTINEL_SECRET_KEY",
                    "sessionToken": "SENTINEL_SESSION_TOKEN",
                    "expiresAt": expires_at.to_rfc3339(),
                },
            },
            "expiresAt": expires_at.to_rfc3339(),
        }),
    )));
    let requests = Arc::new(StdMutex::new(Vec::new()));
    let manager_url = spawn_generated_contract_server(GeneratedContractState {
        response,
        requests: requests.clone(),
    })
    .await;
    let bindings = RemoteBindings::from_manager_access(
        DEPLOYMENT_ID,
        &manager_url,
        GENERATED_MANAGER_TOKEN,
        expires_at,
    )
    .expect("construct bindings from assigned Manager access");

    let lease = bindings.ai().await.expect("resolve Bedrock AI lease");
    assert_eq!(lease.resource_id, "models");
    assert_eq!(lease.binding, alien_core::AiBinding::bedrock("us-east-1"));
    assert_eq!(lease.client_config.platform(), alien_core::Platform::Aws);
    assert_eq!(
        requests
            .lock()
            .expect("generated contract requests lock")
            .as_slice(),
        &[RecordedRequest {
            method: "POST".to_string(),
            path: "/v1/bindings/resolve".to_string(),
            authorization: Some(format!("Bearer {GENERATED_MANAGER_TOKEN}")),
            body: Some(json!({
                "deploymentId": DEPLOYMENT_ID,
                "kind": "ai",
            })),
        }]
    );
    let debug = format!("{lease:?}");
    for secret in [
        "SENTINEL_ACCESS_KEY",
        "SENTINEL_SECRET_KEY",
        "SENTINEL_SESSION_TOKEN",
    ] {
        assert!(!debug.contains(secret));
    }
}

const SANDBOX_IMAGE_ARN: &str =
    "arn:aws:lambda:us-east-1:123456789012:microvm-image/alien-agent-image";

/// One `sandbox-aws` resolve response, with the two fields whose handling the refusal tests
/// vary left as parameters.
fn sandbox_lease_body(
    expires_at: DateTime<Utc>,
    preview_ports: serde_json::Value,
    allow_egress: bool,
) -> serde_json::Value {
    json!({
        "service": "sandbox-aws",
        "binding": {
            "imageArn": SANDBOX_IMAGE_ARN,
            "imageVersion": "7",
            "region": "us-east-1",
            "previewPorts": preview_ports,
            "idlePauseSeconds": 300,
            "maxLifetimeSeconds": 3600,
            "allowEgress": allow_egress,
        },
        "clientConfig": {
            "accountId": "123456789012",
            "region": "us-west-2",
            "credentials": {
                "type": "sessionCredentials",
                "accessKeyId": "SENTINEL_ACCESS_KEY",
                "secretAccessKey": "SENTINEL_SECRET_KEY",
                "sessionToken": "SENTINEL_SESSION_TOKEN",
                "expiresAt": expires_at.to_rfc3339(),
            },
        },
        "expiresAt": expires_at.to_rfc3339(),
    })
}

fn sandbox_resolve_request() -> RecordedRequest {
    RecordedRequest {
        method: "POST".to_string(),
        path: "/v1/bindings/resolve".to_string(),
        authorization: Some(format!("Bearer {GENERATED_MANAGER_TOKEN}")),
        body: Some(json!({
            "deploymentId": DEPLOYMENT_ID,
            "resourceId": "agent",
        })),
    }
}

#[tokio::test]
async fn remote_sandbox_decodes_every_declared_field_and_reaches_the_aws_provider() {
    let expires_at = Utc::now() + ChronoDuration::minutes(5);
    let response = Arc::new(StdRwLock::new((
        StatusCode::OK,
        sandbox_lease_body(expires_at, json!([8080, 3000]), true),
    )));
    let requests = Arc::new(StdMutex::new(Vec::new()));
    let manager_url = spawn_generated_contract_server(GeneratedContractState {
        response,
        requests: requests.clone(),
    })
    .await;

    let adapter = GeneratedManagerBindingResolver;
    let manager = DiscoveredManager {
        deployment_id: DEPLOYMENT_ID.to_string(),
        url: reqwest::Url::parse(&manager_url).expect("valid manager URL"),
        http: authenticated_http_client(GENERATED_MANAGER_TOKEN, "generated manager fixture")
            .expect("build generated contract client"),
        refresh_at: expires_at,
        generation: 0,
    };
    let lease = adapter
        .resolve(
            &manager,
            DEPLOYMENT_ID,
            RemoteBindingSelector::Resource("agent"),
        )
        .await
        .expect("generated client should decode a sandbox lease");
    let ResolvedRemoteBinding::SandboxAws {
        binding,
        client_config,
        expires_at: lease_expires_at,
    } = lease
    else {
        panic!("generated client returned the wrong lease variant for a sandbox");
    };
    let value = |raw: &str| alien_core::BindingValue::Value(raw.to_string());
    assert_eq!(binding.image_arn, value(SANDBOX_IMAGE_ARN));
    assert_eq!(binding.image_version, value("7"));
    assert_eq!(binding.region, value("us-east-1"));
    assert_eq!(binding.preview_ports, vec![8080, 3000]);
    assert_eq!(binding.idle_pause_seconds, Some(300));
    assert_eq!(binding.max_lifetime_seconds, Some(3600));
    assert!(binding.allow_egress);
    assert_eq!(binding.execution_role_arn, None);
    assert!(binding.egress_connector_arns.is_empty());
    assert_eq!(client_config.account_id, "123456789012");
    assert_eq!(client_config.region, "us-west-2");
    assert!(client_config.service_overrides.is_none());
    let alien_core::AwsCredentials::SessionCredentials {
        access_key_id,
        secret_access_key,
        session_token,
        expires_at: credential_expires_at,
    } = client_config.credentials
    else {
        panic!("generated client returned a non-session AWS credential for a sandbox");
    };
    assert_eq!(access_key_id, "SENTINEL_ACCESS_KEY");
    assert_eq!(secret_access_key, "SENTINEL_SECRET_KEY");
    assert_eq!(session_token, "SENTINEL_SESSION_TOKEN");
    assert_eq!(credential_expires_at, expires_at.to_rfc3339());
    assert_eq!(lease_expires_at.to_rfc3339(), expires_at.to_rfc3339());

    let bindings = RemoteBindings::from_manager_access(
        DEPLOYMENT_ID,
        &manager_url,
        GENERATED_MANAGER_TOKEN,
        expires_at,
    )
    .expect("construct bindings from assigned Manager access");
    let sandbox = bindings
        .sandbox("agent")
        .await
        .expect("resolve the sandbox binding through Manager");
    assert_eq!(
        sandbox.capabilities(),
        alien_core::SandboxCapabilities::for_platform(alien_core::Platform::Aws)
            .expect("AWS has a sandbox backend"),
        "a remote sandbox must expose the same surface as the in-cloud one"
    );
    let debug = format!("{sandbox:?}");
    assert!(
        debug.contains(SANDBOX_IMAGE_ARN) && debug.contains("8080"),
        "the resolved topology should reach the provider: {debug}"
    );
    for secret in [
        "SENTINEL_ACCESS_KEY",
        "SENTINEL_SECRET_KEY",
        "SENTINEL_SESSION_TOKEN",
    ] {
        assert!(
            !debug.contains(secret),
            "a sandbox handle must not render its credential lease"
        );
    }

    assert_eq!(
        requests
            .lock()
            .expect("generated contract requests lock")
            .as_slice(),
        &[sandbox_resolve_request(), sandbox_resolve_request()],
        "a sandbox resolve is resource-scoped, with no selector of its own"
    );
}

/// A ceiling under a name this binding does not know fails the whole lease rather than being
/// dropped from it. The generated binding denies unknown fields, and that is the difference
/// between a loud refusal and a sandbox running without the wall-clock ceiling its declaration
/// asked for. The two names below are what a manager built against an earlier contract sends.
#[tokio::test]
async fn a_sandbox_lease_naming_a_ceiling_the_binding_does_not_know_is_refused() {
    for (current, stale) in [
        ("idlePauseSeconds", "idleSuspendSeconds"),
        ("maxLifetimeSeconds", "sessionTtlSeconds"),
    ] {
        let expires_at = Utc::now() + ChronoDuration::minutes(5);
        let mut body = sandbox_lease_body(expires_at, json!([8080]), true);
        let binding = body["binding"]
            .as_object_mut()
            .expect("the sandbox lease carries a binding object");
        let seconds = binding
            .remove(current)
            .unwrap_or_else(|| panic!("the fixture declares {current}"));
        binding.insert(stale.to_string(), seconds);

        let manager_url = spawn_generated_contract_server(GeneratedContractState {
            response: Arc::new(StdRwLock::new((StatusCode::OK, body))),
            requests: Arc::new(StdMutex::new(Vec::new())),
        })
        .await;
        let bindings = RemoteBindings::from_manager_access(
            DEPLOYMENT_ID,
            &manager_url,
            GENERATED_MANAGER_TOKEN,
            expires_at,
        )
        .expect("construct bindings from assigned Manager access");

        let error = bindings
            .sandbox("agent")
            .await
            .expect_err("a ceiling under an unknown name must not resolve");
        assert_eq!(error.code, "INVALID_RESPONSE_PAYLOAD", "{stale}: {error}");
        let rendered = format!("{error}");
        assert!(
            rendered.contains(stale) && rendered.contains(current),
            "the refusal must name the field it did not expect and the one it wanted: {rendered}"
        );
    }
}

#[tokio::test]
async fn remote_sandbox_lease_is_refused_when_it_declares_restricted_egress() {
    let expires_at = Utc::now() + ChronoDuration::minutes(5);
    let response = Arc::new(StdRwLock::new((
        StatusCode::OK,
        sandbox_lease_body(expires_at, json!([8080]), false),
    )));
    let manager_url = spawn_generated_contract_server(GeneratedContractState {
        response,
        requests: Arc::new(StdMutex::new(Vec::new())),
    })
    .await;
    let bindings = RemoteBindings::from_manager_access(
        DEPLOYMENT_ID,
        &manager_url,
        GENERATED_MANAGER_TOKEN,
        expires_at,
    )
    .expect("construct bindings from assigned Manager access");

    // The remote contract carries no connectors, so `allowEgress: false` describes a sandbox
    // whose sandboxes would start unrouted and reach the internet.
    let error = bindings
        .sandbox("agent")
        .await
        .expect_err("a sandbox declaring restricted egress must not be handed to a caller");
    assert_eq!(error.code, "BINDING_CONFIG_INVALID");
    assert!(
        format!("{error}").contains("egressConnectorArns"),
        "the refusal should name the field it read: {error}"
    );
}

#[tokio::test]
async fn remote_sandbox_lease_is_refused_when_a_preview_port_does_not_fit() {
    let expires_at = Utc::now() + ChronoDuration::minutes(5);
    let response = Arc::new(StdRwLock::new((
        StatusCode::OK,
        sandbox_lease_body(expires_at, json!([70000]), true),
    )));
    let manager_url = spawn_generated_contract_server(GeneratedContractState {
        response,
        requests: Arc::new(StdMutex::new(Vec::new())),
    })
    .await;
    let bindings = RemoteBindings::from_manager_access(
        DEPLOYMENT_ID,
        &manager_url,
        GENERATED_MANAGER_TOKEN,
        expires_at,
    )
    .expect("construct bindings from assigned Manager access");

    // Narrowing 70000 into a port would mint ingress for 4464, which no declaration named.
    let error = bindings
        .sandbox("agent")
        .await
        .expect_err("an out-of-range preview port must refuse the whole lease");
    assert_eq!(error.code, "REMOTE_ACCESS_FAILED");
    let rendered = format!("{error}");
    assert!(
        rendered.contains("previewPorts") && rendered.contains("70000"),
        "the refusal should name the field and the value it read: {rendered}"
    );
}

fn azure_sandbox_lease_body(expires_at: DateTime<Utc>, allow_egress: bool) -> serde_json::Value {
    json!({
        "service": "sandbox-azure",
        "binding": {
            "sandboxGroup": "acme-agent",
            "dataPlaneEndpoint": "https://management.westus2.azuredevcompute.io",
            "region": "westus2",
            "resourceGroup": "acme-rg",
            "diskImage": "ubuntu",
            "allowEgress": allow_egress,
            "idlePauseSeconds": 300,
            "cpu": "1000m",
            "memory": "2048Mi",
            "disk": "20480Mi",
        },
        "clientConfig": {
            "subscriptionId": "00000000-0000-0000-0000-000000000000",
            "tenantId": "11111111-1111-1111-1111-111111111111",
            "region": "westus2",
            "credentials": { "type": "accessToken", "token": "SENTINEL_AZURE_TOKEN" },
        },
        "expiresAt": expires_at.to_rfc3339(),
    })
}

/// Decodes through the **generated** client, the only path a real deployment takes. This catches
/// a manager response variant added without regenerating the OpenAPI spec: hand-written types and
/// the crate's own tests would still pass, but the generated client would have no arm to decode into.
#[tokio::test]
async fn remote_sandbox_decodes_every_declared_field_and_reaches_the_azure_provider() {
    let expires_at = Utc::now() + ChronoDuration::minutes(5);
    let response = Arc::new(StdRwLock::new((
        StatusCode::OK,
        azure_sandbox_lease_body(expires_at, true),
    )));
    let requests = Arc::new(StdMutex::new(Vec::new()));
    let manager_url = spawn_generated_contract_server(GeneratedContractState {
        response,
        requests: requests.clone(),
    })
    .await;

    let manager = DiscoveredManager {
        deployment_id: DEPLOYMENT_ID.to_string(),
        url: reqwest::Url::parse(&manager_url).expect("valid manager URL"),
        http: authenticated_http_client(GENERATED_MANAGER_TOKEN, "generated manager fixture")
            .expect("build generated contract client"),
        refresh_at: expires_at,
        generation: 0,
    };
    let lease = GeneratedManagerBindingResolver
        .resolve(
            &manager,
            DEPLOYMENT_ID,
            RemoteBindingSelector::Resource("agent"),
        )
        .await
        .expect("generated client should decode an Azure sandbox lease");

    let ResolvedRemoteBinding::SandboxAzure {
        binding,
        client_config,
        expires_at: lease_expires_at,
    } = lease
    else {
        panic!("generated client returned the wrong lease variant for an Azure sandbox");
    };
    let value = |raw: &str| alien_core::BindingValue::Value(raw.to_string());
    assert_eq!(binding.sandbox_group, value("acme-agent"));
    assert_eq!(
        binding.data_plane_endpoint,
        value("https://management.westus2.azuredevcompute.io")
    );
    assert_eq!(binding.region, value("westus2"));
    assert_eq!(binding.resource_group, value("acme-rg"));
    assert_eq!(binding.disk_image, value("ubuntu"));
    assert_eq!(binding.egress, alien_core::SandboxEgress::Allow);
    assert_eq!(binding.idle_pause_seconds, Some(300));
    assert_eq!(binding.cpu, Some(value("1000m")));
    assert_eq!(binding.memory, Some(value("2048Mi")));
    assert_eq!(binding.disk, Some(value("20480Mi")));
    assert_eq!(client_config.region.as_deref(), Some("westus2"));
    assert!(client_config.service_overrides.is_none());
    let alien_core::AzureCredentials::AccessToken { token } = client_config.credentials else {
        panic!("an Azure sandbox lease carries an access token");
    };
    assert_eq!(token, "SENTINEL_AZURE_TOKEN");
    assert_eq!(lease_expires_at.timestamp(), expires_at.timestamp());
}

/// A lease claiming restricted egress is refused rather than quietly downgraded — the field is
/// read from the wire, not assumed, so a future change to the manager's rule still gets caught
/// here.
#[tokio::test]
async fn an_azure_sandbox_lease_without_open_egress_is_refused() {
    let expires_at = Utc::now() + ChronoDuration::minutes(5);
    let response = Arc::new(StdRwLock::new((
        StatusCode::OK,
        azure_sandbox_lease_body(expires_at, false),
    )));
    let manager_url = spawn_generated_contract_server(GeneratedContractState {
        response,
        requests: Arc::new(StdMutex::new(Vec::new())),
    })
    .await;

    let manager = DiscoveredManager {
        deployment_id: DEPLOYMENT_ID.to_string(),
        url: reqwest::Url::parse(&manager_url).expect("valid manager URL"),
        http: authenticated_http_client(GENERATED_MANAGER_TOKEN, "generated manager fixture")
            .expect("build generated contract client"),
        refresh_at: expires_at,
        generation: 0,
    };
    let Err(error) = GeneratedManagerBindingResolver
        .resolve(
            &manager,
            DEPLOYMENT_ID,
            RemoteBindingSelector::Resource("agent"),
        )
        .await
    else {
        panic!("a restricted-egress sandbox lease is not usable remotely")
    };
    assert_eq!(error.code, "REMOTE_ACCESS_FAILED", "{error}");
    assert!(
        format!("{error}").contains("egress"),
        "the code is shared with other refusals, so the reason has to be named: {error}"
    );
}

/// The GCP arm of the same contract, decoded through the **generated** client. Both names a
/// sandbox is addressed by — engine and template — must survive the trip: created without the
/// template, a sandbox runs an unpinned image with none of the declared limits or egress applied.
#[tokio::test]
async fn remote_sandbox_decodes_every_declared_field_and_reaches_the_gcp_provider() {
    // Absent is what a manager older than the field sends; it must still decode, as deny.
    for allow_egress in [Some(true), Some(false), None] {
        decode_gcp_sandbox_lease(allow_egress).await;
    }
}

async fn decode_gcp_sandbox_lease(allow_egress: Option<bool>) {
    let expires_at = Utc::now() + ChronoDuration::minutes(5);
    let engine = "projects/acme/locations/us-central1/reasoningEngines/4242";
    let mut binding_json = json!({
        "engine": engine,
        "template": format!("{engine}/sandboxEnvironmentTemplates/7"),
        "region": "us-central1",
        "maxLifetimeSeconds": 3600,
    });
    if let Some(allow) = allow_egress {
        binding_json["allowEgress"] = json!(allow);
    }
    let response = Arc::new(StdRwLock::new((
        StatusCode::OK,
        json!({
            "service": "sandbox-gcp-agent-platform",
            "binding": binding_json,
            "clientConfig": {
                "projectId": "acme",
                "region": "us-central1",
                "credentials": { "type": "accessToken", "token": "SENTINEL_GCP_TOKEN" },
            },
            "expiresAt": expires_at.to_rfc3339(),
        }),
    )));
    let manager_url = spawn_generated_contract_server(GeneratedContractState {
        response,
        requests: Arc::new(StdMutex::new(Vec::new())),
    })
    .await;

    let manager = DiscoveredManager {
        deployment_id: DEPLOYMENT_ID.to_string(),
        url: reqwest::Url::parse(&manager_url).expect("valid manager URL"),
        http: authenticated_http_client(GENERATED_MANAGER_TOKEN, "generated manager fixture")
            .expect("build generated contract client"),
        refresh_at: expires_at,
        generation: 0,
    };
    let lease = GeneratedManagerBindingResolver
        .resolve(
            &manager,
            DEPLOYMENT_ID,
            RemoteBindingSelector::Resource("agent"),
        )
        .await
        .expect("generated client should decode a GCP Agent Platform sandbox lease");

    let ResolvedRemoteBinding::SandboxGcpAgentPlatform {
        binding,
        client_config,
        expires_at: lease_expires_at,
    } = lease
    else {
        panic!("generated client returned the wrong lease variant for a GCP sandbox");
    };
    let value = |raw: &str| alien_core::BindingValue::Value(raw.to_string());
    assert_eq!(binding.engine, value(engine));
    assert_eq!(
        binding.template,
        value(&format!("{engine}/sandboxEnvironmentTemplates/7"))
    );
    assert_eq!(binding.region, value("us-central1"));
    assert_eq!(binding.max_lifetime_seconds, Some(3600));
    assert_eq!(binding.allow_egress, allow_egress.unwrap_or(false));
    assert_eq!(client_config.project_id, "acme");
    assert!(client_config.service_overrides.is_none());
    let alien_core::GcpCredentials::AccessToken { token } = client_config.credentials else {
        panic!("a GCP sandbox lease carries an access token");
    };
    assert_eq!(token, "SENTINEL_GCP_TOKEN");
    assert_eq!(lease_expires_at.timestamp(), expires_at.timestamp());
}