1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
//! Documentation-snippet rendering for the Python e2e backend.
//!
//! Split out of `mod.rs` so the snippet concern — which now consults the shared
//! [`crate::e2e::codegen::snippet_error_branch`] seam — has one file of its own rather than
//! growing an already over-cap module.
use anyhow::Result;
use crate::core::config::ResolvedCrateConfig;
use crate::e2e::config::E2eConfig;
use crate::e2e::fixture::Fixture;
use super::helpers;
use super::test_file::render_test_file;
pub(super) fn render_snippet_body(
fixture: &Fixture,
e2e_config: &E2eConfig,
config: &ResolvedCrateConfig,
type_defs: &[crate::core::ir::TypeDef],
enums: &[crate::core::ir::EnumDef],
errors: &[crate::core::ir::ErrorDef],
functions: &[crate::core::ir::FunctionDef],
) -> Result<String> {
let mut call_fixture = fixture.docs_call_fixture();
let expects_error = call_fixture
.assertions
.iter()
.any(|assertion| assertion.assertion_type == "error");
// Resolved before `assertions` is cleared below: a fixture with no hand-authored
// `docs.shows`/`docs.presentation` falls back to showing the fields its own
// `assertions` already name (see `presentation::default_operations_from_assertions`),
// and that fallback has nothing to read once this function empties the list. ~keep
let presentation =
crate::e2e::codegen::presentation::resolve(&call_fixture, e2e_config, "python", type_defs, functions);
call_fixture.assertions.clear();
call_fixture.mock_response = None;
// With `mock_response` cleared, `test_function`'s `client_factory` path falls through
// to its "declared env var" branch whenever `fixture.env.api_key_var` is set — which
// guards the read with `pytest.skip(...)` for the executable e2e suite's real-API-vs-mock
// dispatch. A docs snippet is not a pytest test function, so that guard renders as an
// undefined name. Clearing `env` here (the credential var name below still reads it from
// the *original* `fixture`) drops straight to the same bare `api_key="test-key"` shape the
// substitution just below already targets. ~keep
call_fixture.env = None;
let call = e2e_config.resolve_call_for_fixture(
call_fixture.call.as_deref(),
&call_fixture.id,
&call_fixture.resolved_category(),
&call_fixture.tags,
&call_fixture.input,
);
// Fixture assertions are cleared above because snippets do not render test
// assertions, so the usual assertion-driven binding heuristic cannot see that the
// reader-facing presentation consumes `result_var`. Bind every non-void successful
// call: the template either prints the result itself or presents fields from it. ~keep
let force_bind_result = !expects_error && !call.returns_void;
let test_file = render_test_file(
&fixture.resolved_category(),
&[&call_fixture],
e2e_config,
config,
type_defs,
enums,
&[],
force_bind_result,
);
let (imports, body, is_async) = extract_python_snippet(&test_file)?;
let api_key_var = crate::e2e::fixture::FixtureEnv::api_key_var_or_default(fixture.env.as_ref());
let body = body
.into_iter()
.map(|line| {
line.replace(
"api_key=\"test-key\"",
&format!("api_key=os.environ[\"{api_key_var}\"]"),
)
})
.collect::<Vec<_>>();
// A `configuration/custom-base-url`-style topic documents `docs.client.base_url` so the
// reader sees the setting the topic is about, mirroring the Java/Rust/Elixir generators'
// `docs_client` handling. The client-construction line always ends in exactly this
// single-argument shape immediately after the substitution above, so targeting it here
// (rather than threading `docs_client` through `render_test_file`/`test_function`, which
// also serves the executable e2e suite) keeps this docs-only concern out of the shared
// test-rendering path entirely. ~keep
let body = match fixture.docs_client().and_then(|client| client.base_url.as_deref()) {
Some(base_url) => {
let bare_call = format!("api_key=os.environ[\"{api_key_var}\"])");
let with_base_url = format!(
"api_key=os.environ[\"{api_key_var}\"], base_url=\"{}\")",
crate::e2e::escape::escape_python(base_url)
);
body.into_iter()
.map(|line| line.replace(&bare_call, &with_base_url))
.collect::<Vec<_>>()
}
None => body,
};
// `config.error_type_name()` names the *Rust-side* error type (`ResolvedCrateConfig::
// error_type`, used elsewhere for `error_constructor_expr`'s `Crate::Error::from(msg)`
// pattern) — a config surface nobody sets to name a Python class, and unrelated to what
// pyo3 actually exports. The pyo3 backend's own base-exception class name
// (`gen_pyo3_error_types` in `src/codegen/error_gen/pyo3.rs`) comes straight from the IR's
// `ErrorDef::name` — the real Rust error enum's name verbatim, with no config indirection
// and no crate-name prefixing. Asking the same `errors` slice this function already
// receives (for `typed_branch` just below) is what keeps this import in sync with the
// class pyo3 actually generates; falling back to the config-derived bare "Error" only when
// the IR has no error type at all preserves the pre-existing no-error-type behavior. ~keep
// `config.error_type_name()` names the *Rust-side* error type (`ResolvedCrateConfig::
// error_type`, used elsewhere for `error_constructor_expr`'s `Crate::Error::from(msg)`
// pattern) — a config surface nobody sets to name a Python class, and unrelated to what
// pyo3 actually exports. The pyo3 backend's own base-exception class name
// (`gen_pyo3_error_types` in `src/codegen/error_gen/pyo3.rs`) comes straight from the IR's
// `ErrorDef::name` — the real Rust error enum's name verbatim, with no config indirection
// and no crate-name prefixing. Asking the same `errors` slice this function already
// receives (for `typed_branch` just below) is what keeps this import in sync with the
// class pyo3 actually generates; falling back to the config-derived bare "Error" only when
// the IR has no error type at all preserves the pre-existing no-error-type behavior. ~keep
let error_type = errors
.first()
.map(|error| error.name.clone())
.unwrap_or_else(|| config.error_type_name());
let mut imports = imports.into_iter().map(str::to_string).collect::<Vec<_>>();
if body.iter().any(|line| line.contains("os.environ")) && !imports.iter().any(|line| line == "import os") {
imports.push("import os".to_string());
}
// ~keep A fixture that names the variant it provokes (`{"type": "error", "value":
// "Authentication"}`) documents a specific failure mode, and pyo3 already generates a
// distinct exception class for it. Catching that class *before* the flat base class is the
// difference between a snippet that teaches "handle a 401 by rotating the key" and one that
// teaches "print the class name". The decision is not made here: `snippet_error_branch`
// answers it once for every backend, so this branch and the e2e suite's type assertion can
// never claim different things about the same variant. `None` — no declared variant, or a
// message-style value — keeps the pre-existing single generic `except` unchanged.
let typed_branch = crate::e2e::codegen::snippet_error_branch::for_fixture("python", fixture, errors)
.filter(|branch| branch.host_type != error_type);
if expects_error {
let module = helpers::resolve_module(e2e_config);
// ~keep Sorted because a published snippet is linted in the consumer repo, where ruff's
// unsorted-imports rule fires on `from pkg import Error, AuthenticationError`.
let mut names = vec![error_type.clone()];
names.extend(typed_branch.as_ref().map(|branch| branch.host_type.clone()));
names.sort();
imports.push(format!("from {module} import {}", names.join(", ")));
}
Ok(crate::e2e::template_env::render(
"python/snippet_body.py.jinja",
minijinja::context! {
imports => imports, body => body, is_async => is_async, presentation => presentation,
expects_error => expects_error,
error_type => error_type,
typed_error_type => typed_branch.as_ref().map(|branch| branch.host_type.clone()),
result_var => call.effective_result_var(),
returns_void => call.returns_void,
},
))
}
fn extract_python_snippet(rendered: &str) -> Result<(Vec<&str>, Vec<&str>, bool)> {
let lines = rendered.lines().collect::<Vec<_>>();
let signature = lines
.iter()
.position(|line| line.starts_with("async def test_") || line.starts_with("def test_"))
.ok_or_else(|| anyhow::anyhow!("generated Python test did not contain a fixture function"))?;
let imports = lines[..signature]
.iter()
.copied()
.filter(|line| (line.starts_with("from ") || line.starts_with("import ")) && !line.contains("pytest"))
.collect();
let body = lines[signature + 1..]
.iter()
.copied()
.filter_map(|line| line.strip_prefix(" "))
.filter(|line| !line.trim_start().starts_with("\"\"\"") && !line.trim().is_empty())
.collect();
Ok((imports, body, lines[signature].starts_with("async def ")))
}
#[cfg(test)]
#[path = "snippet_iterate_empty_fields_tests.rs"]
mod snippet_iterate_empty_fields_tests;
#[cfg(test)]
mod tests {
use crate::core::config::{NewAlefConfig, ResolvedCrateConfig};
use crate::core::ir::{ErrorDef, ErrorVariant};
use crate::e2e::codegen::E2eCodegen;
use crate::e2e::codegen::python::PythonE2eCodegen;
use crate::e2e::config::E2eConfig;
use crate::e2e::fixture::Fixture;
const CONFIG: &str = r#"
[workspace]
languages = ["python"]
[[crates]]
name = "example-core"
sources = ["src/lib.rs"]
[crates.e2e]
fixtures = "fixtures"
[crates.e2e.call]
function = "chat"
module = "example_api"
args = [{ name = "prompt", field = "prompt", type = "string" }]
"#;
fn config() -> (E2eConfig, ResolvedCrateConfig) {
let cfg: NewAlefConfig = toml::from_str(CONFIG).expect("config parses");
let e2e = cfg.crates[0].e2e.clone().expect("e2e config");
let resolved = cfg.resolve().expect("config resolves").remove(0);
(e2e, resolved)
}
fn error_fixture(declared: &str) -> Fixture {
serde_json::from_value(serde_json::json!({
"id": "auth_401",
"description": "401 Unauthorized",
"input": {"prompt": "Hello"},
"assertions": [
{"type": "error"},
{"type": "error", "value": declared},
]
}))
.expect("fixture must parse")
}
fn errors_with(variant: &str) -> Vec<ErrorDef> {
vec![ErrorDef {
name: "ApiError".to_string(),
rust_path: "lib::ApiError".to_string(),
original_rust_path: String::new(),
variants: vec![ErrorVariant {
name: variant.to_string(),
is_unit: true,
..ErrorVariant::default()
}],
doc: String::new(),
methods: vec![],
binding_excluded: false,
binding_exclusion_reason: None,
version: Default::default(),
}]
}
/// The defect this module's `snippet_error_branch` wiring closes. A fixture that names the
/// variant it provokes used to render a single `except Error` catch-all printing
/// `type(error).__name__` — documentation that teaches "catch everything and print the class
/// name" while the binding it documents exports a distinct `AuthenticationError` class. The
/// typed branch must come FIRST: Python matches `except` clauses in order and the generated
/// per-variant classes subclass the flat base, so a leading catch-all makes every following
/// branch unreachable.
#[test]
fn a_fixture_naming_an_error_variant_catches_that_variants_exception_first() {
let (e2e, resolved) = config();
let rendered = PythonE2eCodegen
.render_snippet_body_with_functions(
&error_fixture("Authentication"),
&e2e,
&resolved,
&[],
&[],
&[],
&errors_with("Authentication"),
)
.expect("snippet renders");
let typed = rendered
.find("except AuthenticationError as error:")
.unwrap_or_else(|| panic!("no typed catch branch in:\n{rendered}"));
// The base class comes from `errors_with`'s real `ErrorDef` IR (named "ApiError"), not
// the config-derived bare "Error" fallback — the same seam the pyo3 backend's
// `gen_pyo3_error_types` uses to name the class it actually exports (see the
// cross-generator test below pinning the two together). ~keep
let generic = rendered
.find("except ApiError as error:")
.unwrap_or_else(|| panic!("no catch-all branch in:\n{rendered}"));
assert!(typed < generic, "typed branch must precede the catch-all:\n{rendered}");
assert!(
rendered.contains("from example_api import ApiError, AuthenticationError"),
"both exception classes must be imported:\n{rendered}"
);
}
/// The deliberate fallback, tested rather than incidental: with no IR error registry the
/// declared value cannot be resolved to a variant, so the snippet is byte-identical to what
/// it rendered before the typed branch existed.
#[test]
fn without_an_error_registry_the_snippet_keeps_its_single_generic_branch() {
let (e2e, resolved) = config();
let rendered = PythonE2eCodegen
.render_snippet_body(&error_fixture("Authentication"), &e2e, &resolved, &[], &[])
.expect("snippet renders");
assert!(rendered.contains("except Error as error:"), "{rendered}");
assert!(!rendered.contains("except AuthenticationError"), "{rendered}");
assert_eq!(rendered.matches("except ").count(), 1, "{rendered}");
}
/// A message-style declared value names no variant, so it must not invent a class name.
#[test]
fn a_message_style_declared_value_keeps_the_generic_branch() {
let (e2e, resolved) = config();
let rendered = PythonE2eCodegen
.render_snippet_body_with_functions(
&error_fixture("prompt must not be empty"),
&e2e,
&resolved,
&[],
&[],
&[],
&errors_with("Authentication"),
)
.expect("snippet renders");
assert_eq!(rendered.matches("except ").count(), 1, "{rendered}");
assert!(rendered.contains("except ApiError as error:"), "{rendered}");
}
/// Cross-generator guard: the pyo3 backend's own base-exception generator
/// (`gen_pyo3_error_types`) and this e2e snippet generator must name the SAME class for the
/// SAME `ErrorDef`, driven through both real production entry points on one shared fixture
/// — never a hand-copied re-derivation of one side. This is the exact defect shape a
/// consumer repo hit: `error_type_name()` (a config surface nobody sets to name a Python
/// class) defaulted to a fabricated bare `"Error"`, while pyo3 actually exports the base
/// class under the real Rust enum's name (`LiterLlmError`-shaped), so every generated
/// snippet's `from pkg import Error` failed pyright/ruff's `missing-module-attribute`
/// check — the class it imports has never existed. ~keep
#[test]
fn snippet_base_exception_name_agrees_with_the_pyo3_stub_generator() {
let errors = errors_with("Authentication");
let mut seen_exceptions = ahash::AHashSet::default();
let backend_output =
crate::codegen::error_gen::gen_pyo3_error_types(&errors[0], "example_api", &mut seen_exceptions);
assert!(
backend_output.contains("pyo3::create_exception!(example_api, ApiError, pyo3::exceptions::PyException);"),
"the backend must export the base exception under the real ErrorDef name:\n{backend_output}"
);
let (e2e, resolved) = config();
let rendered = PythonE2eCodegen
.render_snippet_body_with_functions(
&error_fixture("Authentication"),
&e2e,
&resolved,
&[],
&[],
&[],
&errors,
)
.expect("snippet renders");
assert!(
rendered.contains("except ApiError as error:"),
"the snippet must catch the exact class the backend exports, got:\n{rendered}"
);
assert!(
!rendered.contains("except Error as error:"),
"the snippet must not import a class the backend never generates:\n{rendered}"
);
}
}