alef 0.30.15

use super::external_types::merge_external_type_roots;
use super::filtering::{apply_filters, expand_include_list, is_type_excluded};
use super::sanitizer::{TypeSanitization, sanitize_type_ref, sanitize_unknown_types};
use super::validation::validate_extracted_api;
use crate::core::config::{ResolvedCrateConfig, SourceCrate};
use crate::core::ir::{ApiSurface, TypeRef};
use ahash::AHashSet;

/// sanitize_type_ref must resolve Map inner types (e.g. Named("str") → String)
/// without marking the Map as lossy. Lossy map inner changes are still reported
/// separately so validation can block them before codegen.
#[test]
fn sanitize_map_with_cow_key_preserves_map_structure_and_returns_lossless() {
    let known_types = AHashSet::default();
    let known_enums = AHashSet::default();
    // "str" is NOT in known_types — it represents the inner type of Cow<'static, str>.
    // The key starts as Named("str") which the type_resolver emits for Cow<'static, str>.

    let mut ty = TypeRef::Map(Box::new(TypeRef::Named("str".into())), Box::new(TypeRef::Json));

    let status = sanitize_type_ref(&mut ty, &known_types, &known_enums);

    // The Map must be preserved — NOT converted to String.
    assert!(
        matches!(&ty, TypeRef::Map(k, v)
                if matches!(k.as_ref(), TypeRef::String)
                && matches!(v.as_ref(), TypeRef::Json)),
        "expected Map(String, Json) but got {ty:?}"
    );

    assert_eq!(status, TypeSanitization::Lossless);

    // Verify the symmetric case: Map(String, Json) with already-resolved key
    // should also return false (key is already String, no unknown Named types).
    let _ = known_types;
    let mut ty2 = TypeRef::Map(Box::new(TypeRef::String), Box::new(TypeRef::Json));
    let sanitized2 = sanitize_type_ref(&mut ty2, &AHashSet::default(), &AHashSet::default());
    assert_eq!(sanitized2, TypeSanitization::Unchanged);
    assert!(
        matches!(&ty2, TypeRef::Map(k, v)
                if matches!(k.as_ref(), TypeRef::String)
                && matches!(v.as_ref(), TypeRef::Json)),
        "Map(String, Json) must not be mutated when already clean"
    );
}

#[test]
fn sanitize_map_with_bare_value_is_reported_as_sanitized() {
    let mut ty = TypeRef::Map(Box::new(TypeRef::String), Box::new(TypeRef::Named("Value".to_string())));

    let sanitized = sanitize_type_ref(&mut ty, &AHashSet::default(), &AHashSet::default());

    assert!(
        sanitized.is_lossy(),
        "ambiguous bare Value inside Map must not be silently accepted"
    );
    assert!(
        matches!(&ty, TypeRef::Map(_, value) if matches!(value.as_ref(), TypeRef::Named(name) if name == "Value")),
        "ambiguous bare Value must remain visible for validation, got {ty:?}"
    );
}

/// Map(String, String) — the old case that was already handled correctly downstream —
/// must also return sanitized=false after this fix. Backends must handle it via the
/// normal (non-sanitized) Map conversion path.
#[test]
fn sanitize_map_with_both_string_types_returns_not_sanitized() {
    let mut ty = TypeRef::Map(Box::new(TypeRef::String), Box::new(TypeRef::String));
    let sanitized = sanitize_type_ref(&mut ty, &AHashSet::default(), &AHashSet::default());
    assert_eq!(sanitized, TypeSanitization::Unchanged);
    assert!(matches!(
        &ty,
        TypeRef::Map(k, v)
            if matches!(k.as_ref(), TypeRef::String) && matches!(v.as_ref(), TypeRef::String)
    ));
}

#[test]
fn sanitize_map_with_unknown_value_type_returns_lossy() {
    let mut ty = TypeRef::Map(
        Box::new(TypeRef::String),
        Box::new(TypeRef::Named("ForeignPayload".into())),
    );

    let sanitized = sanitize_type_ref(&mut ty, &AHashSet::default(), &AHashSet::default());

    assert_eq!(sanitized, TypeSanitization::Lossy);
    assert!(
        matches!(&ty, TypeRef::Map(_, value) if matches!(value.as_ref(), TypeRef::String)),
        "unknown map value should be visibly sanitized for validation, got {ty:?}"
    );
}

/// Primitive field (not a Map) with unknown Named inner type still gets sanitized=true.
/// This ensures we didn't break non-Map sanitization.
#[test]
fn sanitize_named_unknown_type_returns_sanitized_true() {
    let mut ty = TypeRef::Named("UnknownForeignType".into());
    let sanitized = sanitize_type_ref(&mut ty, &AHashSet::default(), &AHashSet::default());
    assert!(sanitized.is_lossy());
    assert!(matches!(ty, TypeRef::String));
}

#[test]
fn sanitize_field_type_path_rejects_same_name_from_different_crate() {
    let mut api = ApiSurface {
        types: vec![
            crate::core::ir::TypeDef {
                name: "UrlConfig".to_string(),
                rust_path: "facade::UrlConfig".to_string(),
                fields: vec![crate::core::ir::FieldDef {
                    name: "crawl".to_string(),
                    ty: TypeRef::Named("CrawlConfig".to_string()),
                    type_rust_path: Some("external_core::CrawlConfig".to_string()),
                    ..crate::core::ir::FieldDef::default()
                }],
                ..crate::core::ir::TypeDef::default()
            },
            crate::core::ir::TypeDef {
                name: "CrawlConfig".to_string(),
                rust_path: "facade::CrawlConfig".to_string(),
                ..crate::core::ir::TypeDef::default()
            },
        ],
        ..ApiSurface::default()
    };

    sanitize_unknown_types(&mut api);

    let field = &api.types[0].fields[0];
    assert!(field.sanitized);
    assert!(matches!(field.ty, TypeRef::String));
}

#[test]
fn sanitize_field_type_path_accepts_same_crate_reexport_path() {
    let mut api = ApiSurface {
        types: vec![
            crate::core::ir::TypeDef {
                name: "Wrapper".to_string(),
                rust_path: "sample::Wrapper".to_string(),
                fields: vec![crate::core::ir::FieldDef {
                    name: "config".to_string(),
                    ty: TypeRef::Named("CrawlConfig".to_string()),
                    type_rust_path: Some("sample::CrawlConfig".to_string()),
                    ..crate::core::ir::FieldDef::default()
                }],
                ..crate::core::ir::TypeDef::default()
            },
            crate::core::ir::TypeDef {
                name: "CrawlConfig".to_string(),
                rust_path: "sample::types::config::CrawlConfig".to_string(),
                ..crate::core::ir::TypeDef::default()
            },
        ],
        ..ApiSurface::default()
    };

    sanitize_unknown_types(&mut api);

    let field = &api.types[0].fields[0];
    assert!(!field.sanitized);
    assert!(matches!(field.ty, TypeRef::Named(ref name) if name == "CrawlConfig"));
}

#[test]
fn sanitize_field_type_path_accepts_facade_reexport_path() {
    let mut api = ApiSurface {
        crate_name: "sample".to_string(),
        types: vec![
            crate::core::ir::TypeDef {
                name: "Wrapper".to_string(),
                rust_path: "sample::Wrapper".to_string(),
                fields: vec![crate::core::ir::FieldDef {
                    name: "config".to_string(),
                    ty: TypeRef::Named("CrawlConfig".to_string()),
                    type_rust_path: Some("sample::CrawlConfig".to_string()),
                    ..crate::core::ir::FieldDef::default()
                }],
                ..crate::core::ir::TypeDef::default()
            },
            crate::core::ir::TypeDef {
                name: "CrawlConfig".to_string(),
                rust_path: "external_core::types::config::CrawlConfig".to_string(),
                ..crate::core::ir::TypeDef::default()
            },
        ],
        ..ApiSurface::default()
    };

    sanitize_unknown_types(&mut api);

    let field = &api.types[0].fields[0];
    assert!(!field.sanitized);
    assert!(matches!(field.ty, TypeRef::Named(ref name) if name == "CrawlConfig"));
}

/// Vec<Named("unknown")> should still return sanitized=true (inner Named replaced with String).
#[test]
fn sanitize_vec_with_unknown_named_returns_sanitized_true() {
    let mut ty = TypeRef::Vec(Box::new(TypeRef::Named("MyForeignStruct".into())));
    let sanitized = sanitize_type_ref(&mut ty, &AHashSet::default(), &AHashSet::default());
    assert!(sanitized.is_lossy());
    assert!(matches!(
        &ty,
        TypeRef::Vec(inner) if matches!(inner.as_ref(), TypeRef::String)
    ));
}

#[test]
fn validate_extracted_api_does_not_suppress_critical_codes() {
    let api = ApiSurface {
        crate_name: "sample-lib".to_string(),
        functions: vec![crate::core::ir::FunctionDef {
            name: "render".to_string(),
            rust_path: "sample_lib::render".to_string(),
            original_rust_path: String::new(),
            params: vec![crate::core::ir::ParamDef {
                name: "payload".to_string(),
                ty: TypeRef::Named("MissingPayload".to_string()),
                ..crate::core::ir::ParamDef::default()
            }],
            return_type: TypeRef::String,
            error_type: None,
            doc: String::new(),
            is_async: false,
            sanitized: false,
            return_sanitized: false,
            returns_ref: false,
            returns_cow: false,
            return_newtype_wrapper: None,
            cfg: None,
            binding_excluded: false,
            binding_exclusion_reason: None,
            version: Default::default(),
        }],
        ..ApiSurface::default()
    };

    let config = ResolvedCrateConfig::default();
    let err = validate_extracted_api(&api, &config).expect_err("must stay fatal");

    assert!(
        err.to_string().contains("unknown_named_type"),
        "unexpected error: {err}"
    );
}

// ---------------------------------------------------------------------------
// is_type_excluded — fully-qualified path matching
// ---------------------------------------------------------------------------

/// Plain (no-`::`) entries match by short name only.
#[test]
fn is_type_excluded_plain_entry_matches_by_name() {
    let exclude = vec!["OutputFormat".to_string()];

    // Short name hit
    assert!(
        is_type_excluded("OutputFormat", "sample_crate::types::OutputFormat", &exclude),
        "plain entry must match when name matches"
    );

    // Different name — no match
    assert!(
        !is_type_excluded("SomethingElse", "sample_crate::types::SomethingElse", &exclude),
        "plain entry must not match when name differs"
    );
}

/// Fully-qualified entries match only the specific rust_path, not any type
/// that merely shares the same short name.
///
/// Regression: sample_core::core::config::formats::OutputFormat must be excluded
/// while sample_core::types::OutputFormat is retained.
#[test]
fn is_type_excluded_qualified_entry_matches_rust_path_not_name() {
    let exclude = vec!["sample_crate::core::config::formats::OutputFormat".to_string()];

    // The internal variant — must be excluded.
    assert!(
        is_type_excluded(
            "OutputFormat",
            "sample_crate::core::config::formats::OutputFormat",
            &exclude
        ),
        "qualified entry must match the exact rust_path"
    );

    // The public variant that shares the same short name — must NOT be excluded.
    assert!(
        !is_type_excluded("OutputFormat", "sample_crate::types::OutputFormat", &exclude),
        "qualified entry must NOT match a different rust_path with the same short name"
    );
}

/// Hyphens in rust_path are normalised to underscores before comparison, matching
/// the convention used throughout alef's path mapping layer.
#[test]
fn is_type_excluded_normalises_hyphens_in_rust_path() {
    let exclude = vec!["my_crate::some_module::Foo".to_string()];

    // rust_path with hyphen in crate name — normalised to underscore before compare.
    assert!(
        is_type_excluded("Foo", "my-crate::some_module::Foo", &exclude),
        "hyphens in rust_path should be normalised to underscores"
    );
}

// ---------------------------------------------------------------------------
// expand_include_list — function-signature seeding
// ---------------------------------------------------------------------------

fn make_typedef(name: &str) -> crate::core::ir::TypeDef {
    crate::core::ir::TypeDef {
        name: name.to_string(),
        rust_path: format!("my_crate::{name}"),
        original_rust_path: String::new(),
        fields: vec![],
        methods: vec![],
        is_opaque: false,
        is_clone: false,
        is_copy: false,
        is_trait: false,
        has_default: false,
        has_stripped_cfg_fields: false,
        is_return_type: false,
        doc: String::new(),
        cfg: None,
        serde_rename_all: None,
        has_serde: false,
        super_traits: vec![],
        binding_excluded: false,
        binding_exclusion_reason: None,
        is_variant_wrapper: false,
        has_lifetime_params: false,
        has_private_fields: false,
        version: Default::default(),
    }
}

fn make_funcdef(name: &str, return_type: TypeRef, param_types: Vec<TypeRef>) -> crate::core::ir::FunctionDef {
    crate::core::ir::FunctionDef {
        name: name.to_string(),
        rust_path: format!("my_crate::{name}"),
        original_rust_path: String::new(),
        params: param_types
            .into_iter()
            .enumerate()
            .map(|(i, ty)| crate::core::ir::ParamDef {
                name: format!("arg{i}"),
                ty,
                optional: false,
                default: None,
                sanitized: false,
                typed_default: None,
                is_ref: false,
                is_mut: false,
                newtype_wrapper: None,
                original_type: None,
                map_is_ahash: false,
                map_key_is_cow: false,
                vec_inner_is_ref: false,
                map_is_btree: false,
                core_wrapper: crate::core::ir::CoreWrapper::None,
            })
            .collect(),
        return_type,
        is_async: false,
        error_type: None,
        doc: String::new(),
        cfg: None,
        sanitized: false,
        return_sanitized: false,
        returns_ref: false,
        returns_cow: false,
        return_newtype_wrapper: None,
        binding_excluded: false,
        binding_exclusion_reason: None,
        version: Default::default(),
    }
}

fn surface_with(types: Vec<crate::core::ir::TypeDef>, functions: Vec<crate::core::ir::FunctionDef>) -> ApiSurface {
    ApiSurface {
        crate_name: "my_crate".into(),
        version: "0.1.0".into(),
        types,
        functions,
        enums: vec![],
        errors: vec![],
        excluded_type_paths: std::collections::HashMap::new(),
        excluded_trait_names: std::collections::HashSet::new(),
        services: vec![],
        handler_contracts: vec![],
        unsupported_public_items: Vec::new(),
    }
}

// ---------------------------------------------------------------------------
// external type roots
// ---------------------------------------------------------------------------

#[test]
fn merge_external_type_roots_imports_only_transitive_dtos() {
    let dir = tempfile::tempdir().unwrap();
    let source = dir.path().join("external.rs");
    std::fs::write(
        &source,
        r#"
pub struct ExternalConfig {
    pub nested: NestedConfig,
    #[cfg_attr(alef, alef(skip))]
    pub skipped: SkippedConfig,
}

impl ExternalConfig {
    pub fn method_only(&self) -> MethodOnlyConfig {
        unimplemented!()
    }
}

pub struct NestedConfig {
    pub mode: ExternalMode,
}

pub enum ExternalMode {
    Auto,
}

pub struct SkippedConfig {
    pub hidden: HiddenConfig,
}

pub struct HiddenConfig {
    pub value: String,
}

pub struct MethodOnlyConfig {
    pub value: String,
}

pub fn external_function() -> ExternalConfig {
    unimplemented!()
}
"#,
    )
    .unwrap();

    let mut surface = surface_with(vec![make_typedef("HostConfig")], vec![]);
    let config = ResolvedCrateConfig {
        source_crates: vec![SourceCrate {
            name: "external-core".to_string(),
            sources: vec![source],
            roots: vec!["ExternalConfig".to_string()],
            from_registry: false,
        }],
        ..Default::default()
    };

    merge_external_type_roots(&mut surface, &config).unwrap();

    let type_names: AHashSet<_> = surface.types.iter().map(|typ| typ.name.as_str()).collect();
    let enum_names: AHashSet<_> = surface.enums.iter().map(|enm| enm.name.as_str()).collect();

    assert!(type_names.contains("HostConfig"));
    assert!(type_names.contains("ExternalConfig"));
    assert!(type_names.contains("NestedConfig"));
    assert!(!type_names.contains("SkippedConfig"));
    assert!(!type_names.contains("HiddenConfig"));
    assert!(!type_names.contains("MethodOnlyConfig"));
    assert!(enum_names.contains("ExternalMode"));
    assert!(
        surface
            .types
            .iter()
            .find(|typ| typ.name == "ExternalConfig")
            .is_some_and(|typ| typ.methods.is_empty()),
        "external DTO methods must be stripped"
    );
    assert!(surface.functions.is_empty(), "external functions must not be merged");
}

#[test]
fn merge_external_type_roots_rejects_same_name_host_conflict() {
    let dir = tempfile::tempdir().unwrap();
    let source = dir.path().join("external.rs");
    std::fs::write(&source, "pub struct ExternalConfig { pub value: String }\n").unwrap();

    let mut surface = surface_with(vec![make_typedef("ExternalConfig")], vec![]);
    let config = ResolvedCrateConfig {
        source_crates: vec![SourceCrate {
            name: "external-core".to_string(),
            sources: vec![source],
            roots: vec!["ExternalConfig".to_string()],
            from_registry: false,
        }],
        ..Default::default()
    };

    let err = merge_external_type_roots(&mut surface, &config).unwrap_err();

    assert!(
        err.to_string().contains("conflicts with existing type path"),
        "expected type conflict error, got: {err:#}"
    );
}

#[test]
fn merge_external_type_roots_validates_qualified_roots_by_rust_path() {
    let dir = tempfile::tempdir().unwrap();
    let source = dir.path().join("external.rs");
    std::fs::write(&source, "pub struct ExternalConfig { pub value: String }\n").unwrap();

    let mut surface = surface_with(vec![], vec![]);
    let config = ResolvedCrateConfig {
        source_crates: vec![SourceCrate {
            name: "external-core".to_string(),
            sources: vec![source],
            roots: vec!["other_core::ExternalConfig".to_string()],
            from_registry: false,
        }],
        ..Default::default()
    };

    let err = merge_external_type_roots(&mut surface, &config).unwrap_err();

    assert!(
        err.to_string()
            .contains("external type root `other_core::ExternalConfig` was not found"),
        "expected qualified root mismatch error, got: {err:#}"
    );
}

#[test]
fn extract_with_external_type_roots_keeps_host_sources_and_field_type() {
    let dir = tempfile::tempdir().unwrap();
    let manifest = dir.path().join("Cargo.toml");
    let host = dir.path().join("host.rs");
    let external = dir.path().join("external.rs");
    std::fs::write(&manifest, "[package]\nname = \"host\"\nversion = \"0.1.0\"\n").unwrap();
    std::fs::write(
        &host,
        r#"
pub struct HostConfig {
    pub external: external_core::ExternalConfig,
}
"#,
    )
    .unwrap();
    std::fs::write(
        &external,
        r#"
pub struct ExternalConfig {
    pub nested: NestedConfig,
}

pub struct NestedConfig {
    pub enabled: bool,
}
"#,
    )
    .unwrap();

    let config = ResolvedCrateConfig {
        name: "host".to_string(),
        sources: vec![host],
        source_crates: vec![SourceCrate {
            name: "external-core".to_string(),
            sources: vec![external],
            roots: vec!["external_core::ExternalConfig".to_string()],
            from_registry: false,
        }],
        version_from: manifest.to_string_lossy().into_owned(),
        include: crate::core::config::IncludeConfig {
            types: vec!["HostConfig".to_string()],
            ..Default::default()
        },
        ..Default::default()
    };

    let api = super::extract(&config, &dir.path().join("alef.toml"), true).unwrap();

    let host_config = api
        .types
        .iter()
        .find(|typ| typ.name == "HostConfig")
        .expect("host type should survive extraction");
    let external_field = host_config
        .fields
        .iter()
        .find(|field| field.name == "external")
        .expect("host field should survive extraction");

    assert!(
        matches!(&external_field.ty, TypeRef::Named(name) if name == "ExternalConfig"),
        "external field should remain typed, got {:?}",
        external_field.ty
    );
    assert!(api.types.iter().any(|typ| typ.name == "ExternalConfig"));
    assert!(api.types.iter().any(|typ| typ.name == "NestedConfig"));
}

/// Regression for a batch-result include bug: a function listed in
/// `[crates.include].functions` returns a wrapper struct that is NOT in
/// `[crates.include].types`. Before the fix, the include filter dropped the
/// wrapper struct (it was unreachable from the included types), and the later
/// `sanitize_unknown_types` pass collapsed the function's `return_type` to
/// `String`, breaking every binding facade.
///
/// After the fix, `expand_include_list` seeds itself from included functions'
/// signatures so the wrapper is retained.
#[test]
fn expand_include_list_seeds_from_included_function_signatures() {
    let surface = surface_with(
        vec![
            make_typedef("BatchScrapeResult"),
            make_typedef("BatchScrapeResults"),
            make_typedef("UnusedType"),
        ],
        vec![make_funcdef(
            "batch_scrape",
            TypeRef::Named("BatchScrapeResults".into()),
            vec![TypeRef::Vec(Box::new(TypeRef::String))],
        )],
    );

    let include_types = vec!["BatchScrapeResult".to_string()];
    let include_functions = vec!["batch_scrape".to_string()];

    let expanded = expand_include_list(&surface, &include_types, &include_functions);

    assert!(
        expanded.contains("BatchScrapeResult"),
        "per-element type explicitly listed must be present; got: {expanded:?}"
    );
    assert!(
        expanded.contains("BatchScrapeResults"),
        "wrapper return type of included function must be auto-included; got: {expanded:?}"
    );
    assert!(
        !expanded.contains("UnusedType"),
        "unrelated type must not be pulled in; got: {expanded:?}"
    );
}

/// Function parameter types must also be retained — a function listed in
/// `include.functions` that accepts a custom config struct must keep that
/// struct in the surface even if the user forgot to list it under
/// `include.types`.
#[test]
fn expand_include_list_seeds_from_included_function_param_types() {
    let surface = surface_with(
        vec![make_typedef("CrawlConfig"), make_typedef("EngineHandle")],
        vec![make_funcdef(
            "create_engine",
            TypeRef::Named("EngineHandle".into()),
            vec![TypeRef::Optional(Box::new(TypeRef::Named("CrawlConfig".into())))],
        )],
    );

    let include_types = vec!["EngineHandle".to_string()];
    let include_functions = vec!["create_engine".to_string()];

    let expanded = expand_include_list(&surface, &include_types, &include_functions);

    assert!(
        expanded.contains("CrawlConfig"),
        "param type referenced through Optional must be retained; got: {expanded:?}"
    );
}

/// When no functions are in the include list, behaviour is unchanged —
/// expansion stays anchored to `include_types` only.
#[test]
fn expand_include_list_with_empty_functions_matches_legacy_behaviour() {
    let surface = surface_with(
        vec![make_typedef("Kept"), make_typedef("Dropped")],
        vec![make_funcdef("do_thing", TypeRef::Named("Dropped".into()), vec![])],
    );

    let include_types = vec!["Kept".to_string()];
    let include_functions: Vec<String> = vec![];

    let expanded = expand_include_list(&surface, &include_types, &include_functions);
    assert!(expanded.contains("Kept"));
    assert!(
        !expanded.contains("Dropped"),
        "function not in include.functions must not pull in its return type; got: {expanded:?}"
    );
}

#[test]
fn expand_include_list_does_not_follow_binding_excluded_fields() {
    let surface = surface_with(
        vec![
            crate::core::ir::TypeDef {
                name: "CrawlConfig".to_string(),
                rust_path: "external_core::CrawlConfig".to_string(),
                fields: vec![
                    crate::core::ir::FieldDef {
                        name: "content".to_string(),
                        ty: TypeRef::Named("ContentConfig".to_string()),
                        ..crate::core::ir::FieldDef::default()
                    },
                    crate::core::ir::FieldDef {
                        name: "dispatch".to_string(),
                        ty: TypeRef::Optional(Box::new(TypeRef::Named("DispatchProfile".to_string()))),
                        binding_excluded: true,
                        ..crate::core::ir::FieldDef::default()
                    },
                ],
                ..make_typedef("CrawlConfig")
            },
            make_typedef("ContentConfig"),
            crate::core::ir::TypeDef {
                name: "DispatchProfile".to_string(),
                rust_path: "external_core::DispatchProfile".to_string(),
                fields: vec![crate::core::ir::FieldDef {
                    name: "bypass".to_string(),
                    ty: TypeRef::Optional(Box::new(TypeRef::Named("DynBypassProvider".to_string()))),
                    ..crate::core::ir::FieldDef::default()
                }],
                ..make_typedef("DispatchProfile")
            },
            make_typedef("DynBypassProvider"),
        ],
        vec![],
    );

    let expanded = expand_include_list(&surface, &["CrawlConfig".to_string()], &[]);

    assert!(expanded.contains("CrawlConfig"));
    assert!(expanded.contains("ContentConfig"));
    assert!(
        !expanded.contains("DispatchProfile"),
        "binding-excluded fields must not pull skipped internals into the public graph: {expanded:?}"
    );
    assert!(
        !expanded.contains("DynBypassProvider"),
        "nested internals behind binding-excluded fields must stay out: {expanded:?}"
    );
}

#[test]
fn normalize_field_type_paths_preserves_explicit_reexport_path() {
    let mut surface = surface_with(
        vec![
            crate::core::ir::TypeDef {
                name: "UrlConfig".to_string(),
                rust_path: "facade::UrlConfig".to_string(),
                fields: vec![crate::core::ir::FieldDef {
                    name: "crawl".to_string(),
                    ty: TypeRef::Named("CrawlConfig".to_string()),
                    type_rust_path: Some("external_core::CrawlConfig".to_string()),
                    ..crate::core::ir::FieldDef::default()
                }],
                ..make_typedef("UrlConfig")
            },
            crate::core::ir::TypeDef {
                name: "CrawlConfig".to_string(),
                rust_path: "external_core::types::config::CrawlConfig".to_string(),
                ..make_typedef("CrawlConfig")
            },
        ],
        vec![],
    );

    super::type_helpers::normalize_field_type_paths(&mut surface);

    let field = &surface.types[0].fields[0];
    assert_eq!(field.type_rust_path.as_deref(), Some("external_core::CrawlConfig"));
}

// ---------------------------------------------------------------------------
// apply_filters — exclude.methods suppresses unsupported_public_items
// ---------------------------------------------------------------------------

fn make_unsupported_method(type_name: &str, method_name: &str) -> crate::core::ir::UnsupportedPublicItem {
    crate::core::ir::UnsupportedPublicItem {
        item_kind: "method".to_string(),
        item_path: format!("my_crate::module::{type_name}.{method_name}"),
        reason: "public generic trait methods cannot be represented without explicit monomorphization metadata"
            .to_string(),
        suggested_fix: "exclude the method".to_string(),
    }
}

fn make_unsupported_function(fn_name: &str) -> crate::core::ir::UnsupportedPublicItem {
    crate::core::ir::UnsupportedPublicItem {
        item_kind: "function".to_string(),
        item_path: format!("my_crate::{fn_name}"),
        reason: "generic function".to_string(),
        suggested_fix: "exclude the function".to_string(),
    }
}

/// A method item whose `TypeName.method_name` tail appears in `exclude.methods`
/// must be removed from `unsupported_public_items`.
#[test]
fn apply_filters_removes_unsupported_method_when_excluded_by_methods_list() {
    let mut surface = surface_with(vec![], vec![]);
    surface
        .unsupported_public_items
        .push(make_unsupported_method("NodeContext", "serialize"));

    let mut config = ResolvedCrateConfig::default();
    config.exclude.methods = vec!["NodeContext.serialize".to_string()];

    let result = apply_filters(surface, &config);

    assert!(
        result.unsupported_public_items.is_empty(),
        "method listed in exclude.methods must be removed from unsupported_public_items; \
             remaining: {:?}",
        result.unsupported_public_items
    );
}

/// A method item whose tail is NOT in `exclude.methods` must be retained so the
/// diagnostic still surfaces as a fatal error.
#[test]
fn apply_filters_retains_unsupported_method_when_not_in_exclude_list() {
    let mut surface = surface_with(vec![], vec![]);
    surface
        .unsupported_public_items
        .push(make_unsupported_method("NodeContext", "serialize"));

    let mut config = ResolvedCrateConfig::default();
    config.exclude.methods = vec!["NodeContext.other_method".to_string()];

    let result = apply_filters(surface, &config);

    assert_eq!(
        result.unsupported_public_items.len(),
        1,
        "method NOT in exclude.methods must remain in unsupported_public_items"
    );
}

/// Non-method items (kind == "function") must be unaffected by `exclude.methods` —
/// they are only suppressed by `exclude.functions`.
#[test]
fn apply_filters_exclude_methods_does_not_affect_unsupported_function_items() {
    let mut surface = surface_with(vec![], vec![]);
    surface
        .unsupported_public_items
        .push(make_unsupported_function("generic_helper"));

    // Deliberately add the function path tail to exclude.methods — must have no effect.
    let mut config = ResolvedCrateConfig::default();
    config.exclude.methods = vec!["generic_helper".to_string()];

    let result = apply_filters(surface, &config);

    assert_eq!(
        result.unsupported_public_items.len(),
        1,
        "exclude.methods must not suppress items with item_kind == 'function'"
    );
}

#[test]
fn apply_filters_retains_unsupported_function_when_included_by_function_list() {
    let mut surface = surface_with(vec![], vec![]);
    surface
        .unsupported_public_items
        .push(make_unsupported_function("generic_helper"));
    surface
        .unsupported_public_items
        .push(make_unsupported_function("unused_generic"));

    let mut config = ResolvedCrateConfig::default();
    config.include.functions = vec!["generic_helper".to_string()];

    let result = apply_filters(surface, &config);

    assert_eq!(
        result
            .unsupported_public_items
            .iter()
            .map(|item| item.item_path.as_str())
            .collect::<Vec<_>>(),
        vec!["my_crate::generic_helper"],
        "include.functions must retain diagnostics only for included generic functions"
    );
}

#[test]
fn apply_filters_retains_unsupported_method_when_parent_type_is_included() {
    let mut surface = surface_with(vec![make_typedef("NodeContext"), make_typedef("OtherType")], vec![]);
    surface
        .unsupported_public_items
        .push(make_unsupported_method("NodeContext", "serialize"));
    surface
        .unsupported_public_items
        .push(make_unsupported_method("OtherType", "serialize"));

    let mut config = ResolvedCrateConfig::default();
    config.include.types = vec!["NodeContext".to_string()];

    let result = apply_filters(surface, &config);

    assert_eq!(
        result
            .unsupported_public_items
            .iter()
            .map(|item| item.item_path.as_str())
            .collect::<Vec<_>>(),
        vec!["my_crate::module::NodeContext.serialize"],
        "include.types must retain diagnostics only for methods owned by included public types"
    );
}

// ---------------------------------------------------------------------------
// Regression: configurator methods survive the exclude-methods post-service pass
// ---------------------------------------------------------------------------

/// A method declared in `[[crates.services]].configurators` must remain in
/// `service.configurators` even when the same `OwnerType.method_name` key also
/// appears in `[crates.exclude].methods`.
///
/// Background: the exclude list is intended to suppress the *generic struct-level*
/// method emission (preventing non-delegatable stubs in binding codegen). It must
/// not remove the method from the *service IR*, where its presence drives dedicated
/// C/host-language configurator entrypoints. Both intents are independent.
///
/// The fixture uses a purely synthetic owner type so no consumer-library names
/// appear in the test.
#[test]
fn configurator_survives_exclude_methods_post_service_pass() {
    use crate::core::config::service::{EntrypointSpec, ServiceConfig};
    use crate::core::ir::{MethodDef, ReceiverKind, ServiceDef, TypeRef};

    // Build a minimal service with one configurator (`setup`) already populated.
    let configurator_method = MethodDef {
        name: "setup".to_string(),
        params: vec![],
        return_type: TypeRef::Named("Foo".to_string()),
        is_async: false,
        is_static: false,
        error_type: None,
        doc: String::new(),
        receiver: Some(ReceiverKind::Owned),
        sanitized: false,
        trait_source: None,
        returns_ref: false,
        returns_cow: false,
        return_newtype_wrapper: None,
        has_default_impl: false,
        binding_excluded: false,
        binding_exclusion_reason: None,
        version: Default::default(),
    };
    let constructor_method = MethodDef {
        name: "new".to_string(),
        params: vec![],
        return_type: TypeRef::Named("Foo".to_string()),
        is_async: false,
        is_static: true,
        error_type: None,
        doc: String::new(),
        receiver: None,
        sanitized: false,
        trait_source: None,
        returns_ref: false,
        returns_cow: false,
        return_newtype_wrapper: None,
        has_default_impl: false,
        binding_excluded: false,
        binding_exclusion_reason: None,
        version: Default::default(),
    };
    let service = ServiceDef {
        name: "Foo".to_string(),
        rust_path: "test_crate::Foo".to_string(),
        constructor: constructor_method,
        configurators: vec![configurator_method],
        registrations: vec![],
        entrypoints: vec![],
        doc: String::new(),
        cfg: None,
    };

    // Wire up a ResolvedCrateConfig that:
    // - declares `setup` as a configurator via services[].configurators
    // - also lists `Foo.setup` in exclude.methods (the scenario that previously cleared it)
    let mut config = ResolvedCrateConfig {
        name: "test_crate".to_string(),
        services: vec![ServiceConfig {
            owner_type: "Foo".to_string(),
            constructor: Some("new".to_string()),
            configurators: vec!["setup".to_string()],
            registrations: vec![],
            entrypoints: vec![EntrypointSpec {
                method: "run".to_string(),
                kind: "run".to_string(),
            }],
            skip_languages: vec![],
            host_app_inner_accessor: None,
        }],
        ..Default::default()
    };
    config.exclude.methods = vec!["Foo.setup".to_string()];

    // Simulate the pipeline state just after extract_services has populated services.
    let mut api = ApiSurface {
        crate_name: "test_crate".to_string(),
        services: vec![service],
        ..ApiSurface::default()
    };

    // Apply the post-extract_services exclude pass (the fix under test).
    if !config.exclude.methods.is_empty() {
        for typ in &mut api.types {
            typ.methods.retain(|m| {
                let key = format!("{}.{}", typ.name, m.name);
                !config.exclude.methods.contains(&key)
            });
        }
    }

    // The configurator must still be present: the exclude list controls struct-level
    // method emission, NOT the service IR configurator list.
    assert_eq!(api.services.len(), 1, "service must be present after the exclude pass");
    assert_eq!(
        api.services[0].configurators.len(),
        1,
        "configurator `setup` must survive the exclude-methods post-service pass; got {:?}",
        api.services[0]
            .configurators
            .iter()
            .map(|m| m.name.as_str())
            .collect::<Vec<_>>()
    );
    assert_eq!(
        api.services[0].configurators[0].name, "setup",
        "configurator name must be `setup`"
    );
}

/// Regression: the function-dedup pass in `dedup_api_surface` must key on
/// `(name, cfg)`, not `name` alone. The pub-use-clears-skip extractor pass
/// synthesises a paired entry under a disjoint cfg for `#[cfg(X)] pub use mod::fn`
/// patterns whose source is generic/skipped (e.g. `embed_texts_async`: a real
/// `#[cfg(feature="embeddings")]` clone plus a `#[cfg(not(feature="embeddings"))]`
/// stub). Both must survive dedup because exactly one compiles under any feature
/// combination; collapsing by name alone dropped one and made the symbol vanish
/// from every binding whenever the surviving entry's cfg was inactive.
#[test]
fn dedup_keeps_same_named_functions_with_disjoint_cfgs() {
    let mut real = make_funcdef(
        "embed_texts_async",
        TypeRef::Primitive(crate::core::ir::PrimitiveType::Bool),
        vec![],
    );
    real.cfg = Some("all (feature = \"embeddings\" , feature = \"tokio-runtime\")".to_string());
    let mut stub = make_funcdef(
        "embed_texts_async",
        TypeRef::Primitive(crate::core::ir::PrimitiveType::Bool),
        vec![],
    );
    stub.cfg = Some(
        "all (feature = \"embedding-presets\" , not (feature = \"embeddings\") , feature = \"tokio-runtime\")"
            .to_string(),
    );

    let mut surface = surface_with(vec![], vec![real, stub]);
    super::type_helpers::dedup_api_surface(&mut surface);

    let entries: Vec<_> = surface
        .functions
        .iter()
        .filter(|f| f.name == "embed_texts_async")
        .collect();
    assert_eq!(
        entries.len(),
        2,
        "both cfg-gated alternatives must survive dedup; got {entries:?}"
    );
    let cfgs: Vec<&str> = entries.iter().filter_map(|f| f.cfg.as_deref()).collect();
    assert!(cfgs.iter().any(|c| c.contains("\"embeddings\"") && !c.contains("not")));
    assert!(cfgs.iter().any(|c| c.contains("not") && c.contains("\"embeddings\"")));
}

/// Regression: when a name resolves to a real re-export and a crate-root stub under
/// disjoint cfgs (e.g. `LlmBackend`: real `pub use` gated `all(feature="ner-llm",
/// not(android-x86_64))` plus a crate-root stub gated `any(not(feature="ner-llm"),
/// android-x86_64)`), the surviving type entry must carry the OR-merge of both cfgs.
/// Otherwise the emitted dart wrapper struct is gated out on android-x86_64 while
/// flutter_rust_bridge's `frb_generated.rs` references `crate::LlmBackend`
/// unconditionally → `cannot find type LlmBackend in crate`.
#[test]
fn dedup_or_merges_cfgs_for_same_named_type_with_disjoint_cfgs() {
    let mut real = make_typedef("LlmBackend");
    real.is_opaque = true;
    real.cfg = Some(
        "all (feature = \"ner-llm\" , not (target_arch = \"wasm32\") , not (all (target_os = \"android\" , target_arch = \"x86_64\")))"
            .to_string(),
    );
    let mut stub = make_typedef("LlmBackend");
    stub.is_opaque = true;
    stub.cfg = Some(
        "any (not (feature = \"ner-llm\") , all (target_os = \"android\" , target_arch = \"x86_64\"))".to_string(),
    );

    let mut surface = surface_with(vec![real, stub], vec![]);
    super::type_helpers::dedup_api_surface(&mut surface);

    let entries: Vec<_> = surface.types.iter().filter(|t| t.name == "LlmBackend").collect();
    assert_eq!(entries.len(), 1, "same-named type collision must collapse to one entry");
    let cfg = entries[0].cfg.as_deref().expect("merged cfg must be present");
    assert!(
        cfg.starts_with("any("),
        "disjoint cfgs must be OR-merged into an any(...) gate; got `{cfg}`"
    );
    assert!(
        cfg.contains("not (all (target_os = \"android\""),
        "the real re-export's cfg must remain in the merge; got `{cfg}`"
    );
    assert!(
        cfg.contains("all (target_os = \"android\" , target_arch = \"x86_64\")"),
        "the android-x86_64 stub cfg must be included so the wrapper survives there; got `{cfg}`"
    );
}

/// A same-named type collision where every member carries the SAME (single) cfg is a
/// genuine duplicate (e.g. one feature, two module paths) — dedup must collapse to the
/// shortest rust_path without wrapping the cfg in a spurious `any(...)`.
#[test]
fn dedup_collapses_same_named_type_with_identical_cfg() {
    let mut near = make_typedef("Table");
    near.rust_path = "my_crate::Table".to_string();
    near.cfg = Some("feature = \"office\"".to_string());
    let mut far = make_typedef("Table");
    far.rust_path = "my_crate::extraction::docx::Table".to_string();
    far.cfg = Some("feature = \"office\"".to_string());

    let mut surface = surface_with(vec![far, near], vec![]);
    super::type_helpers::dedup_api_surface(&mut surface);

    let entries: Vec<_> = surface.types.iter().filter(|t| t.name == "Table").collect();
    assert_eq!(entries.len(), 1, "identical-cfg duplicates must collapse to one");
    assert_eq!(entries[0].rust_path, "my_crate::Table", "shortest rust_path wins");
    assert_eq!(
        entries[0].cfg.as_deref(),
        Some("feature = \"office\""),
        "identical cfg must pass through unchanged, not be wrapped in any(...)"
    );
}

/// Same-named functions sharing an identical cfg (or both `None`) at different
/// rust_paths are genuine duplicates — dedup must still collapse them to the
/// entry with the shortest rust_path (closest to crate root).
#[test]
fn dedup_collapses_same_named_functions_with_identical_cfg() {
    let mut near = make_funcdef(
        "clean_text",
        TypeRef::Primitive(crate::core::ir::PrimitiveType::Bool),
        vec![],
    );
    near.rust_path = "my_crate::clean_text".to_string();
    let mut far = make_funcdef(
        "clean_text",
        TypeRef::Primitive(crate::core::ir::PrimitiveType::Bool),
        vec![],
    );
    far.rust_path = "my_crate::text::quality::clean_text".to_string();

    let mut surface = surface_with(vec![], vec![far, near]);
    super::type_helpers::dedup_api_surface(&mut surface);

    let entries: Vec<_> = surface.functions.iter().filter(|f| f.name == "clean_text").collect();
    assert_eq!(entries.len(), 1, "identical-cfg duplicates must collapse to one");
    assert_eq!(entries[0].rust_path, "my_crate::clean_text", "shortest rust_path wins");
}