1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
//! PHP (ext-php-rs) specific trait bridge code generation.
//!
//! Generates Rust wrapper structs that implement Rust traits by delegating
//! to PHP objects via ext-php-rs Zval method calls.
use minijinja::context;
use crate::codegen::generators::trait_bridge::{BridgeOutput, TraitBridgeGenerator, TraitBridgeSpec, gen_bridge_all};
use crate::core::config::TraitBridgeConfig;
use crate::core::ir::{ApiSurface, MethodDef, TypeDef, TypeRef};
use std::collections::HashMap;
use super::visitor::gen_visitor_bridge;
/// PHP-specific trait bridge generator.
/// Implements code generation for bridging PHP objects to Rust traits.
pub struct PhpBridgeGenerator {
/// Core crate import path (e.g., `"sample_core"`).
pub core_import: String,
/// Map of type name → fully-qualified Rust path for type references.
pub type_paths: HashMap<String, String>,
/// Error type name (e.g., `"SampleCrateError"`).
pub error_type: String,
/// Callback-param type names that get NATIVE-object marshalling — known serde structs per
/// the shared [`crate::codegen::generators::trait_bridge::is_native_marshalled_struct`] rule.
/// For such a param the bridge constructs the binding's native PHP object (the `#[php_class]`
/// wrapper, via the same `From<core::T>` conversion used for return values) and hands THAT to
/// the PHP method as a `Zval`, instead of serializing the param to a JSON string. Enums,
/// opaque/handle types, and excluded/unknown `Named` params are absent and keep their prior
/// JSON-string representation.
pub struct_param_types: std::collections::HashSet<String>,
/// Callback-RETURN type names that get NATIVE-object marshalling — known serde structs returned
/// directly by a method, gated to those with a generated `From<Binding> for core` conversion.
/// For such a return the bridge first extracts the host's native `#[php_class]` object via
/// `FromZval` and converts via `From<Binding>`, falling back to the `val.string()` + serde path.
pub struct_return_types: std::collections::HashSet<String>,
}
impl PhpBridgeGenerator {
/// Binding `#[php_class]` name to extract for a native-object return, when the return is a bare
/// `Named` struct on the (conversion-gated) native-marshalled return allowlist. The bridge tries
/// `FromZval` (which yields `Some` only for the host's native object) and converts via
/// `From<Binding>` for core. `None` keeps the `val.string()` + serde path.
fn native_struct_return<'a>(&self, ty: &'a TypeRef) -> Option<&'a str> {
match ty {
TypeRef::Named(n) if self.struct_return_types.contains(n) => Some(n.as_str()),
_ => None,
}
}
/// Build the `Zval` argument expression for one callback parameter.
///
/// Known serde structs (per the shared allowlist) are handed to PHP as the binding's native
/// `#[php_class]` object — constructed from the core value through the same `From<core::T>`
/// conversion the binding uses for function return values (`{Class}::from((*name).clone())`),
/// then boxed into a `ZendClassObject` and converted to a Zval via `IntoZval` — the bare
/// `#[php_class]` struct is not itself `IntoZval`, only `ZBox<ZendClassObject<T>>` is. All
/// other params keep their prior representation (JSON string for other `Named` types, etc.).
fn arg_zval_expr(&self, p: &crate::core::ir::ParamDef) -> String {
match &p.ty {
TypeRef::String => format!("ext_php_rs::types::Zval::try_from({}).unwrap_or_default()", p.name),
TypeRef::Path => format!(
"ext_php_rs::types::Zval::try_from({}.to_string_lossy().to_string()).unwrap_or_default()",
p.name
),
TypeRef::Bytes => format!(
"ext_php_rs::types::Zval::try_from(format!(\"{{:?}}\", {})).unwrap_or_default()",
p.name
),
// Known serde struct: hand PHP the binding's native object, not a JSON string. The
// bare `#[php_class]` struct is not `IntoZval`; box it in a `ZendClassObject` (which
// is) so the host receives a real class instance rather than a serialized string.
TypeRef::Named(n) if self.struct_param_types.contains(n.as_str()) => format!(
"ext_php_rs::convert::IntoZval::into_zval(ext_php_rs::types::ZendClassObject::new({n}::from((*{}).clone())), false).unwrap_or_default()",
p.name
),
// Other Named params (enums, opaque/handle, excluded/unknown) keep the JSON string.
TypeRef::Named(_) => format!(
"ext_php_rs::types::Zval::try_from(serde_json::to_string(&{}).unwrap_or_default()).unwrap_or_default()",
p.name
),
TypeRef::Primitive(_) => {
format!("ext_php_rs::types::Zval::try_from({}).unwrap_or_default()", p.name)
}
_ => format!(
"ext_php_rs::types::Zval::try_from(format!(\"{{:?}}\", {})).unwrap_or_default()",
p.name
),
}
}
/// Render the `Vec<&dyn IntoZvalDyn>` args expression passed to `try_call_method`,
/// or `vec![]` when the method takes no params.
fn args_expr(&self, method: &MethodDef) -> String {
if method.params.is_empty() {
return "vec![]".to_string();
}
let args_parts: Vec<String> = method.params.iter().map(|p| self.arg_zval_expr(p)).collect();
format!(
"[{}].iter().map(|z| z as &dyn ext_php_rs::convert::IntoZvalDyn).collect()",
args_parts.join(", ")
)
}
}
impl TraitBridgeGenerator for PhpBridgeGenerator {
fn foreign_object_type(&self) -> &str {
"*mut ext_php_rs::types::ZendObject"
}
fn bridge_imports(&self) -> Vec<String> {
vec!["std::sync::Arc".to_string(), "ext_php_rs::rc::PhpRc".to_string()]
}
fn gen_sync_method_body(&self, method: &MethodDef, spec: &TraitBridgeSpec) -> String {
let name = &method.name;
let args_expr = self.args_expr(method);
let is_result_type = method.error_type.is_some();
let is_unit_return = matches!(method.return_type, TypeRef::Unit);
let is_primitive_return = matches!(&method.return_type, TypeRef::Primitive(_));
let return_type = match &method.return_type {
TypeRef::Named(n) => self
.type_paths
.get(n.as_str())
.map(|p| p.replace('-', "_"))
.unwrap_or_else(|| n.clone()),
other => crate::codegen::generators::trait_bridge::format_type_ref(other, &self.type_paths),
};
let deserialize_error_expr = spec.make_error("format!(\"Deserialize error: {}\", e)");
let call_error_expr = spec.make_error("e.to_string()");
crate::backends::php::template_env::render(
"sync_method_body.jinja",
context! {
method_name => name,
args_expr => args_expr,
is_result_type => is_result_type,
is_unit_return => is_unit_return,
is_primitive_return => is_primitive_return,
return_type => return_type,
native_return_binding => self.native_struct_return(&method.return_type),
deserialize_error_expr => deserialize_error_expr,
call_error_expr => call_error_expr,
},
)
}
fn gen_async_method_body(&self, method: &MethodDef, spec: &TraitBridgeSpec) -> String {
let name = &method.name;
let string_params: Vec<String> = method
.params
.iter()
.filter(|p| matches!(&p.ty, TypeRef::String))
.map(|p| p.name.clone())
.collect();
let args_expr = self.args_expr(method);
let is_result_type = method.error_type.is_some();
let deserialize_error_expr = spec.make_error("format!(\"Deserialize error: {}\", e)");
let call_error_expr = spec.make_error(&format!(
"format!(\"Plugin '{{}}' method '{name}' failed: {{}}\", cached_name, e)"
));
crate::backends::php::template_env::render(
"async_method_body.jinja",
context! {
method_name => name,
args_expr => args_expr,
string_params => string_params,
is_result_type => is_result_type,
native_return_binding => self.native_struct_return(&method.return_type),
deserialize_error_expr => deserialize_error_expr,
call_error_expr => call_error_expr,
},
)
}
fn gen_constructor(&self, spec: &TraitBridgeSpec) -> String {
let wrapper = spec.wrapper_name();
crate::backends::php::template_env::render(
"bridge_constructor.jinja",
context! {
wrapper => &wrapper,
},
)
}
fn gen_unregistration_fn(&self, spec: &TraitBridgeSpec) -> String {
let Some(unregister_fn) = spec.bridge_config.unregister_fn.as_deref() else {
return String::new();
};
let host_path = crate::codegen::generators::trait_bridge::host_function_path(spec, unregister_fn);
crate::backends::php::template_env::render(
"bridge_unregister_fn.jinja",
context! {
unregister_fn => unregister_fn,
host_path => &host_path,
},
)
}
fn gen_clear_fn(&self, spec: &TraitBridgeSpec) -> String {
let Some(clear_fn) = spec.bridge_config.clear_fn.as_deref() else {
return String::new();
};
let host_path = crate::codegen::generators::trait_bridge::host_function_path(spec, clear_fn);
crate::backends::php::template_env::render(
"bridge_clear_fn.jinja",
context! {
clear_fn => clear_fn,
host_path => &host_path,
},
)
}
fn gen_registration_fn(&self, spec: &TraitBridgeSpec) -> String {
let Some(register_fn) = spec.bridge_config.register_fn.as_deref() else {
return String::new();
};
let Some(registry_getter) = spec.bridge_config.registry_getter.as_deref() else {
return String::new();
};
let wrapper = spec.wrapper_name();
let trait_path = spec.trait_path();
let req_methods: Vec<&MethodDef> = spec.required_methods();
let required_methods: Vec<minijinja::Value> = req_methods
.iter()
.map(|m| {
minijinja::context! {
name => m.name.as_str(),
}
})
.collect();
let extra_args = spec
.bridge_config
.register_extra_args
.as_deref()
.map(|a| format!(", {a}"))
.unwrap_or_default();
crate::backends::php::template_env::render(
"bridge_registration_fn.jinja",
context! {
register_fn => register_fn,
required_methods => required_methods,
wrapper => &wrapper,
trait_path => &trait_path,
registry_getter => registry_getter,
extra_args => &extra_args,
},
)
}
}
/// Generate all trait bridge code for a given trait type and bridge config.
pub fn gen_trait_bridge(
trait_type: &TypeDef,
bridge_cfg: &TraitBridgeConfig,
core_import: &str,
error_type: &str,
error_constructor: &str,
api: &ApiSurface,
) -> BridgeOutput {
// Build type name → rust_path lookup as owned HashMap
let type_paths: HashMap<String, String> = api
.types
.iter()
.map(|t| (t.name.clone(), t.rust_path.replace('-', "_")))
.chain(
api.enums
.iter()
.map(|e| (e.name.clone(), e.rust_path.replace('-', "_"))),
)
// Include excluded types so trait methods referencing them (e.g. `&InternalDocument`)
// are qualified with the full Rust path rather than emitting the bare type name.
.chain(
api.excluded_type_paths
.iter()
.map(|(name, path)| (name.clone(), path.replace('-', "_"))),
)
.collect();
// Visitor-style bridge: all methods have defaults, no registry, no super-trait.
let is_visitor_bridge = bridge_cfg.type_alias.is_some()
&& bridge_cfg.register_fn.is_none()
&& bridge_cfg.super_trait.is_none()
&& bridge_cfg.context_type.is_some()
&& bridge_cfg.result_type.is_some()
&& trait_type.methods.iter().all(|m| m.has_default_impl);
if is_visitor_bridge {
let struct_name = format!("Php{}Bridge", bridge_cfg.trait_name);
let trait_path = trait_type.rust_path.replace('-', "_");
let code = gen_visitor_bridge(trait_type, bridge_cfg, &struct_name, &trait_path, &type_paths, api);
// Note: PHP interface file generation is handled separately by the PHP backend
// in generate_bindings() to emit it as a standalone PHP file, not inline Rust code.
//
// The visitor-bridge struct uses `inc_count()`/`dec_count()` from the `PhpRc`
// trait in its Clone/Drop/new impls (see `visitor_bridge_struct.jinja` and
// `bridge_constructor.jinja`) — the trait must be in scope at the binding-crate
// root or those calls fail with E0599 "no method named inc_count for _zend_object".
BridgeOutput {
imports: vec!["ext_php_rs::rc::PhpRc".to_string()],
code,
}
} else {
// Use the IR-driven TraitBridgeGenerator infrastructure.
//
// Classify which callback params get native-object marshalling using the SHARED rule
// (`native_marshalled_struct_params`) so the allowlist is identical to what other
// backends consult. For such params the bridge hands PHP the binding's native `#[php_class]`
// object (built via the same `From<core::T>` conversion used for return values) instead of
// a JSON string.
let struct_param_types =
crate::codegen::generators::trait_bridge::native_marshalled_struct_params(trait_type, api);
// Return-side counterpart, gated on the binding->core conversion actually being generated
// (`convertible_types`); for a type that does not qualify, keep the proven serde path.
let binding_to_core = crate::codegen::conversions::convertible_types(api);
let struct_return_types: std::collections::HashSet<String> =
crate::codegen::generators::trait_bridge::native_marshalled_struct_returns(trait_type, api)
.into_iter()
.filter(|name| binding_to_core.contains(name.as_str()))
.collect();
let generator = PhpBridgeGenerator {
core_import: core_import.to_string(),
type_paths: type_paths.clone(),
error_type: error_type.to_string(),
struct_param_types,
struct_return_types,
};
let lifetime_type_names: std::collections::HashSet<String> = api
.types
.iter()
.filter(|t| t.has_lifetime_params)
.map(|t| t.name.clone())
.collect();
let spec = TraitBridgeSpec {
trait_def: trait_type,
bridge_config: bridge_cfg,
core_import,
wrapper_prefix: "Php",
type_paths,
lifetime_type_names,
error_type: error_type.to_string(),
error_constructor: error_constructor.to_string(),
};
gen_bridge_all(&spec, &generator)
}
}