1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
use crate::core::ir::{CoreWrapper, ParamDef, TypeRef};
use ahash::AHashSet;
/// Split a comma-joined call-argument list on top-level commas only, ignoring commas nested inside
/// angle brackets (`<...>`), parentheses or square brackets. A naive `split(',')` would break an
/// argument such as `x.into_iter().collect::<BTreeMap<_, _>>()` into pieces at the inner comma.
fn split_top_level_commas(args: &str) -> Vec<&str> {
let mut out = Vec::new();
let mut depth: i32 = 0;
let mut start = 0usize;
for (idx, ch) in args.char_indices() {
match ch {
'<' | '(' | '[' => depth += 1,
'>' | ')' | ']' => depth -= 1,
',' if depth == 0 => {
out.push(args[start..idx].trim());
start = idx + 1;
}
_ => {}
}
}
let tail = args[start..].trim();
if !tail.is_empty() || !out.is_empty() {
out.push(tail);
}
out
}
pub(in crate::backends::napi::gen_bindings) fn napi_apply_primitive_casts_to_call_args(
generic_args: &str,
params: &[ParamDef],
) -> String {
// Split args on top-level commas only and match with params to apply casting.
let args_list: Vec<&str> = split_top_level_commas(generic_args);
args_list
.iter()
.zip(params.iter())
.map(|(arg, p)| {
// Special case: Vec<f32> param with is_ref uses the converted variable
if needs_vec_f32_conversion(&p.ty) && p.is_ref {
return format!("&{}_f32", p.name);
}
// Only re-apply NAPI's source→core conversions when the generic let-binding generator
// passed the argument through verbatim (still the bare parameter name). If it already
// produced a `.into()`/`.map(...)`/`_core` temporary/borrow, leave it untouched.
let arg_is_bare_name = *arg == p.name;
match &p.ty {
TypeRef::Primitive(prim) if needs_napi_cast(prim) => {
let core_ty = core_prim_str(prim);
if p.optional {
// Optional: arg might be like "param.map(...)" so re-apply map
if arg.contains(".map(") || arg.contains(".as_") {
// Already handled, keep as is
arg.to_string()
} else {
format!("{}.map(|v| v as {})", arg, core_ty)
}
} else {
// Non-optional: simple cast
format!("{} as {}", arg, core_ty)
}
}
// String/char params whose core type is `Cow<str>`: the NAPI binding receives an
// owned `String`, which the generic let-binding path passes through unchanged. Mirror
// `napi_gen_call_args` so the value is converted into the core's `Cow`.
TypeRef::String | TypeRef::Char
if arg_is_bare_name && !p.is_ref && p.core_wrapper == CoreWrapper::Cow =>
{
if p.optional {
format!("{}.map(std::borrow::Cow::Owned)", arg)
} else {
format!("{}.into()", arg)
}
}
_ => arg.to_string(),
}
})
.collect::<Vec<_>>()
.join(", ")
}
/// Generate let bindings for Vec<f32> parameters that need f64→f32 conversion.
pub(in crate::backends::napi::gen_bindings) fn napi_gen_call_args(
params: &[ParamDef],
opaque_types: &AHashSet<String>,
) -> String {
params
.iter()
.map(|p| {
// Special case: Vec<f32> param with is_ref uses the converted variable
if needs_vec_f32_conversion(&p.ty) && p.is_ref {
return format!("&{}_f32", p.name);
}
match &p.ty {
TypeRef::Primitive(prim) if needs_napi_cast(prim) => {
let core_ty = core_prim_str(prim);
if p.optional {
format!("{}.map(|v| v as {})", p.name, core_ty)
} else {
format!("{} as {}", p.name, core_ty)
}
}
TypeRef::Duration => {
if p.optional {
format!("{}.map(|v| std::time::Duration::from_millis(v.max(0) as u64))", p.name)
} else {
format!("std::time::Duration::from_millis({}.max(0) as u64)", p.name)
}
}
TypeRef::Named(name) if opaque_types.contains(name.as_str()) => {
// When an opaque type param is required by a builder/owned-receiver method,
// clone the inner value (Arc dereference) to get an owned copy.
// When used as a reference param, borrow `&v.inner` instead.
if p.is_ref {
if p.optional {
format!("{}.as_ref().map(|v| v.inner.as_ref())", p.name)
} else {
format!("{}.inner.as_ref()", p.name)
}
} else if p.optional {
format!("{}.as_ref().map(|v| (*v.inner).clone())", p.name)
} else {
format!("(*{}.inner).clone()", p.name)
}
}
TypeRef::Named(_) => {
if p.optional {
if p.is_ref {
format!("{}.as_ref()", p.name)
} else {
format!("{}.map(Into::into)", p.name)
}
} else {
format!("{}.into()", p.name)
}
}
TypeRef::String | TypeRef::Char => {
if p.optional {
if p.is_ref {
format!("{}.as_deref()", p.name)
} else if p.core_wrapper == CoreWrapper::Cow {
// Core takes Option<Cow<str>>: convert via .map(Cow::Owned).
format!("{}.map(std::borrow::Cow::Owned)", p.name)
} else {
p.name.clone()
}
} else if p.is_ref {
format!("&{}", p.name)
} else if p.core_wrapper == CoreWrapper::Cow {
// Core takes Cow<str>: String implements Into<Cow<str>>.
format!("{}.into()", p.name)
} else {
p.name.clone()
}
}
TypeRef::Path => {
if p.optional {
if p.is_ref {
format!("{}.as_deref().map(std::path::Path::new)", p.name)
} else {
format!("{}.map(std::path::PathBuf::from)", p.name)
}
} else if p.is_ref {
format!("std::path::Path::new(&{})", p.name)
} else {
format!("std::path::PathBuf::from({})", p.name)
}
}
TypeRef::Bytes => {
// In NAPI, Bytes becomes napi::Buffer, which needs conversion to Vec<u8>
// The conversion happens in let bindings, so we use the parameter name as-is
if p.optional {
if p.is_ref {
format!("{}.as_deref()", p.name)
} else {
p.name.clone()
}
} else if p.is_ref {
format!("&{}", p.name)
} else {
p.name.clone()
}
}
TypeRef::Vec(inner) => {
if p.optional {
if p.is_ref {
format!("{}.as_deref()", p.name)
} else {
p.name.clone()
}
} else if p.is_ref
&& p.vec_inner_is_ref
&& matches!(inner.as_ref(), TypeRef::String | TypeRef::Char)
{
// Core expects &[&str]: use the pre-built _refs binding.
format!("&{}_refs", p.name)
} else if p.is_ref {
format!("&{}", p.name)
} else {
p.name.clone()
}
}
TypeRef::Map(_, _) => {
// When map_is_btree=true, the core expects BTreeMap but the NAPI binding
// receives HashMap. Convert inline — the temporary BTreeMap lives for
// the duration of the function call statement (Rust temp extension).
if p.optional {
if p.is_ref {
format!("{}.as_ref()", p.name)
} else if p.map_is_btree {
format!(
"{}.map(|m| m.into_iter().collect::<std::collections::BTreeMap<_, _>>())",
p.name
)
} else {
p.name.clone()
}
} else if p.is_ref && p.map_is_btree {
format!("&{}.into_iter().collect::<std::collections::BTreeMap<_, _>>()", p.name)
} else if p.is_ref {
format!("&{}", p.name)
} else if p.map_is_btree {
format!("{}.into_iter().collect::<std::collections::BTreeMap<_, _>>()", p.name)
} else {
p.name.clone()
}
}
_ => p.name.clone(),
}
})
.collect::<Vec<_>>()
.join(", ")
}
pub(super) fn needs_vec_f32_conversion(ty: &TypeRef) -> bool {
matches!(ty, TypeRef::Vec(inner) if matches!(inner.as_ref(), TypeRef::Primitive(crate::core::ir::PrimitiveType::F32)))
}
pub(in crate::backends::napi::gen_bindings) fn needs_napi_cast(p: &crate::core::ir::PrimitiveType) -> bool {
// U32 maps to u32 in both NAPI and core, so no cast needed.
// U64/Usize/Isize map to i64 in NAPI but u64/usize/isize in core.
// F32 maps to f64 in NAPI but f32 in core.
matches!(
p,
crate::core::ir::PrimitiveType::U64
| crate::core::ir::PrimitiveType::Usize
| crate::core::ir::PrimitiveType::Isize
| crate::core::ir::PrimitiveType::F32
)
}
pub(in crate::backends::napi::gen_bindings) fn core_prim_str(p: &crate::core::ir::PrimitiveType) -> &'static str {
match p {
crate::core::ir::PrimitiveType::U64 => "u64",
crate::core::ir::PrimitiveType::Usize => "usize",
crate::core::ir::PrimitiveType::Isize => "isize",
crate::core::ir::PrimitiveType::F32 => "f32",
_ => unreachable!(),
}
}
/// Check if a type is Vec<u8> or Bytes (which becomes napi::Buffer).
pub(super) fn is_bytes_param(ty: &TypeRef) -> bool {
matches!(ty, TypeRef::Bytes)
|| matches!(ty, TypeRef::Vec(inner) if matches!(inner.as_ref(), TypeRef::Primitive(crate::core::ir::PrimitiveType::U8)))
}
#[cfg(test)]
mod tests {
use super::split_top_level_commas;
#[test]
fn split_ignores_commas_nested_in_angle_brackets() {
let args = "&preset_core, custom_schema, &context.into_iter().collect::<std::collections::BTreeMap<_, _>>()";
assert_eq!(
split_top_level_commas(args),
vec![
"&preset_core",
"custom_schema",
"&context.into_iter().collect::<std::collections::BTreeMap<_, _>>()",
],
);
}
#[test]
fn split_handles_simple_and_empty_arglists() {
assert_eq!(split_top_level_commas("a, b, c"), vec!["a", "b", "c"]);
assert!(split_top_level_commas("").is_empty());
}
}