akar-storage 0.2.1

Storage engine for the Akar embedded graph database
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
//! Vector index table — wraps `HnswIndex` with BufferManager-backed persistence.
//!
//! Follows the `OnDiskHashIndex` persistence pattern:
//! - Header page (metric, dims, num_vectors, entry_point, max_level)
//! - Data pages (serialized HNSW nodes + connections)
//!
//! Page layout:
//! - Page 0: Header
//! - Pages 1..=data_page_count: Node data (serialized vectors + connections)

use crate::buffer_manager::BufferManager;
use akar_common::error::StorageError;
use akar_common::types::Value;
use akar_vector::hnsw::{DistanceMetric, HnswIndex};

/// Default page size for vector index storage.
/// Header page layout (page 0):
/// - bytes 0..7:   magic number (0x484E5357 = "HNSW")
/// - bytes 8..15:  num_vectors (u64 LE)
/// - bytes 16..23: entry_point (i64 LE, -1 for none)
/// - bytes 24..27: max_level (u32 LE)
/// - bytes 28..31: dimensions (u32 LE)
/// - byte  32:     metric (0=Cosine, 1=Euclidean, 2=L1, 3=L2Squared, 4=DotProduct)
/// - bytes 33..47: reserved
const HEADER_SIZE: usize = 48;

fn serialize_header(
    num_vectors: u64,
    entry_point: Option<usize>,
    max_level: usize,
    dimensions: u32,
    metric: &DistanceMetric,
) -> Vec<u8> {
    let mut buf = vec![0u8; HEADER_SIZE];
    buf[0..8].copy_from_slice(&0x484E5357u64.to_le_bytes()); // magic
    buf[8..16].copy_from_slice(&num_vectors.to_le_bytes());
    let ep = entry_point.map(|v| v as i64).unwrap_or(-1);
    buf[16..24].copy_from_slice(&ep.to_le_bytes());
    buf[24..28].copy_from_slice(&(max_level as u32).to_le_bytes());
    buf[28..32].copy_from_slice(&dimensions.to_le_bytes());
    let metric_byte = match metric {
        DistanceMetric::Cosine => 0u8,
        DistanceMetric::Euclidean => 1,
        DistanceMetric::L1 => 2,
        DistanceMetric::L2Squared => 3,
        DistanceMetric::DotProduct => 4,
    };
    buf[32] = metric_byte;
    buf
}

fn deserialize_header(buf: &[u8]) -> Option<(u64, Option<usize>, usize, u32, DistanceMetric)> {
    if buf.len() < HEADER_SIZE {
        return None;
    }
    let magic = u64::from_le_bytes(buf[0..8].try_into().ok()?);
    if magic != 0x484E5357 {
        return None;
    }
    let num_vectors = u64::from_le_bytes(buf[8..16].try_into().ok()?);
    let ep_raw = i64::from_le_bytes(buf[16..24].try_into().ok()?);
    let entry_point = if ep_raw < 0 { None } else { Some(ep_raw as usize) };
    let max_level = u32::from_le_bytes(buf[24..28].try_into().ok()?) as usize;
    let dimensions = u32::from_le_bytes(buf[28..32].try_into().ok()?);
    let metric = match buf[32] {
        0 => DistanceMetric::Cosine,
        1 => DistanceMetric::Euclidean,
        2 => DistanceMetric::L1,
        3 => DistanceMetric::L2Squared,
        4 => DistanceMetric::DotProduct,
        _ => return None,
    };
    Some((num_vectors, entry_point, max_level, dimensions, metric))
}

/// A persisted vector index that wraps `HnswIndex` with BufferManager-backed storage.
///
/// # Persistence
///
/// - `save()` serializes the in-memory HNSW index to disk pages
/// - `load()` reads disk pages back into memory
/// - `flush()` writes dirty pages back to the BufferManager
#[derive(Debug, Clone)]
pub struct VectorIndexTable {
    pub index_id: u64,
    pub name: String,
    pub table_name: String,
    pub column_name: String,
    pub dimensions: u32,
    pub hnsw: HnswIndex,
    /// Number of pages allocated for this index.
    page_count: u64,
    /// BufferManager file name (used for register_file / pin / unpin).
    file_name: String,
    /// Whether in-memory state has changed since last save.
    dirty: bool,
}

impl VectorIndexTable {
    /// Create a new vector index table with the given parameters.
    pub fn new(
        index_id: u64,
        name: String,
        table_name: String,
        column_name: String,
        metric: DistanceMetric,
        dimensions: u32,
    ) -> Self {
        Self {
            index_id,
            name,
            table_name,
            column_name,
            dimensions,
            hnsw: HnswIndex::new(metric),
            page_count: 1, // header page always exists
            file_name: format!("vi_{index_id}"),
            dirty: false,
        }
    }

    /// Get a reference to the underlying HNSW index.
    pub fn hnsw(&self) -> &HnswIndex {
        &self.hnsw
    }

    /// Get a mutable reference to the underlying HNSW index.
    pub fn hnsw_mut(&mut self) -> &mut HnswIndex {
        self.dirty = true;
        &mut self.hnsw
    }

    /// Get the distance metric.
    pub fn metric(&self) -> DistanceMetric {
        self.hnsw.metric()
    }

    /// Save the in-memory HNSW index to BufferManager-backed pages.
    ///
    /// Writes the header page (page 0) and all data pages. Every vector is
    /// stored whole on a single page; a vector that does not fit in one page
    /// is an error rather than a silent drop (P52.17).
    pub fn save(&mut self, bm: &mut BufferManager) -> Result<(), StorageError> {
        if !bm.is_file_registered(&self.file_name) {
            return Err(StorageError::Index(format!(
                "Vector index file '{}' not registered with BufferManager",
                self.file_name
            )));
        }

        let nodes = self.hnsw.nodes();
        let num_vectors = nodes.len() as u64;
        let entry_point = self.hnsw.entry_point();
        let max_level = self.hnsw.max_level();

        // Serialize header
        let header = serialize_header(
            num_vectors,
            entry_point,
            max_level,
            self.dimensions,
            &self.hnsw.metric(),
        );

        // Write header page
        let frame = bm
            .pin_mut(&self.file_name, 0)
            .map_err(|e| StorageError::Index(format!("Failed to pin header page: {e}")))?;
        let data = &mut frame.data;
        let write_len = header.len().min(data.len());
        data[..write_len].copy_from_slice(&header[..write_len]);
        frame.is_dirty = true;
        bm.unpin(&self.file_name, 0);

        // Serialize and write vector data pages
        let data_page_start = 1;
        let mut page_idx = data_page_start;
        let mut offset = 0usize;

        while offset < num_vectors as usize {
            let frame = bm
                .pin_mut(&self.file_name, page_idx)
                .map_err(|e| StorageError::Index(format!("Failed to pin data page {page_idx}: {e}")))?;
            let page_data = &mut frame.data;
            let capacity = page_data.len();
            page_data.fill(0u8);
            let mut pos = 0usize;
            let mut written_this_page = 0usize;

            while offset < num_vectors as usize {
                let (id, vec_data) = nodes[offset];
                let vec_len = vec_data.len().saturating_mul(8);
                let entry_len = 8 + 4 + vec_len;
                if pos + entry_len > capacity {
                    // Doesn't fit on this page. If the page is still empty the
                    // vector is too large to persist at all — fail loudly
                    // instead of silently dropping it (P52.17).
                    if written_this_page == 0 {
                        bm.unpin(&self.file_name, page_idx);
                        return Err(StorageError::Index(format!(
                            "Vector at id {id} ({vec_len} bytes) does not fit in a {} byte page",
                            capacity
                        )));
                    }
                    break; // Continue on the next page
                }
                // Write vector ID
                page_data[pos..pos + 8].copy_from_slice(&(id as u64).to_le_bytes());
                pos += 8;
                // Write vector data length
                page_data[pos..pos + 4].copy_from_slice(&(vec_len as u32).to_le_bytes());
                pos += 4;
                // Write vector data
                let mut vec_bytes = Vec::with_capacity(vec_len);
                for &f in vec_data {
                    vec_bytes.extend_from_slice(&f.to_le_bytes());
                }
                page_data[pos..pos + vec_len].copy_from_slice(&vec_bytes);
                pos += vec_len;
                written_this_page += 1;
                offset += 1;
            }

            frame.is_dirty = true;
            bm.unpin(&self.file_name, page_idx);
            page_idx += 1;
        }

        self.page_count = page_idx;
        self.dirty = false;
        Ok(())
    }

    /// Load the HNSW index from BufferManager-backed pages.
    ///
    /// Reads the header page and exactly `num_vectors` entries from the data
    /// pages, rebuilding the in-memory index. Zeroed page tails (which the
    /// page padding leaves behind) are ignored instead of being reconstructed
    /// as phantom empty vectors (P52.17). After loading, the index is fully
    /// searchable.
    pub fn load(&mut self, bm: &mut BufferManager) -> Result<(), StorageError> {
        if !bm.is_file_registered(&self.file_name) {
            return Err(StorageError::Index(format!(
                "Vector index file '{}' not registered with BufferManager",
                self.file_name
            )));
        }

        // Read header page
        let frame = bm
            .pin(&self.file_name, 0)
            .map_err(|e| StorageError::Index(format!("Failed to pin header page: {e}")))?;
        let header_data = &frame.data;
        let (num_vectors, _entry_point, _max_level, dimensions, metric) =
            deserialize_header(header_data).ok_or(StorageError::Index("Invalid vector index header".into()))?;
        self.dimensions = dimensions;
        bm.unpin(&self.file_name, 0);

        // Rebuild the HNSW index
        let mut new_hnsw = HnswIndex::new(metric);

        // Read data pages from page 1 onward until all vectors are loaded.
        let data_page_start = 1u64;
        let mut page_idx = data_page_start;
        let mut loaded = 0usize;

        while (loaded as u64) < num_vectors {
            let frame_result = bm.pin(&self.file_name, page_idx);
            let frame = match frame_result {
                Ok(f) => f,
                Err(_) => break, // No more pages
            };
            let page_data = &frame.data;
            let capacity = page_data.len();
            let mut pos = 0usize;
            let remaining = num_vectors - loaded as u64;
            let mut loaded_this_page = 0u64;

            while loaded_this_page < remaining && pos + 8 <= capacity {
                let id = u64::from_le_bytes(page_data[pos..pos + 8].try_into().unwrap()) as usize;
                pos += 8;

                if pos + 4 > capacity {
                    break;
                }
                let vec_len = u32::from_le_bytes(page_data[pos..pos + 4].try_into().unwrap()) as usize;
                pos += 4;

                if pos + vec_len > capacity {
                    break;
                }
                if vec_len == 0 {
                    // Zeroed page tail (padding from save) — no more real data.
                    break;
                }

                let dims = vec_len / 8;
                let mut vec_data = Vec::with_capacity(dims);
                for i in 0..dims {
                    let f = f64::from_le_bytes(page_data[pos + i * 8..pos + (i + 1) * 8].try_into().unwrap());
                    vec_data.push(f);
                }
                pos += vec_len;

                new_hnsw.insert(vec_data, id);
                loaded_this_page += 1;
            }

            bm.unpin(&self.file_name, page_idx);
            page_idx += 1;
            loaded += loaded_this_page as usize;

            if loaded_this_page == 0 {
                // Empty/zeroed page — nothing more to read.
                break;
            }
            // Safety: prevent infinite loop if pages keep reading
            if page_idx > 1024 * 1024 {
                break;
            }
        }

        self.hnsw = new_hnsw;
        self.dirty = false;
        Ok(())
    }

    /// Flush dirty pages to disk via the BufferManager.
    pub fn flush(&mut self, bm: &mut BufferManager) -> Result<(), StorageError> {
        if self.dirty {
            self.save(bm)?;
        }
        bm.flush_all()
            .map_err(|e| StorageError::Index(format!("Failed to flush vector index: {e}")))
    }

    /// Register the vector index file with the BufferManager.
    pub fn register_file(&self, bm: &mut BufferManager, db_path: &std::path::Path) {
        let file_path = db_path.join(format!("{}.idx", self.file_name));
        bm.register_file(&self.file_name, file_path);
    }

    /// Check whether the in-memory state differs from disk.
    pub fn is_dirty(&self) -> bool {
        self.dirty
    }
}

/// Helper: extract a `Vec<f64>` from a `Value` (expects `Value::List` of numbers).
pub fn extract_f64_list_from_value(val: &Value) -> Result<Vec<f64>, StorageError> {
    akar_common::types::extract_f64_list(val).map_err(|e| StorageError::TypeMismatch {
        expected: "numeric vector".into(),
        actual: e,
    })
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::buffer_manager::BufferManagerConfig;
    use crate::page::DEFAULT_PAGE_SIZE;
    use akar_common::memory::MemoryManager;
    use std::sync::Arc;

    fn setup_bm(db_path: &std::path::Path) -> BufferManager {
        let mm = Arc::new(MemoryManager::new(64 * 1024 * 1024));
        BufferManager::new(db_path.to_path_buf(), mm, BufferManagerConfig::default())
    }

    #[test]
    fn test_vector_index_save_load_roundtrip() {
        let dir = tempfile::tempdir().unwrap();
        let mut bm = setup_bm(dir.path());

        let mut idx = VectorIndexTable::new(
            1,
            "vec_idx".into(),
            "items".into(),
            "embedding".into(),
            DistanceMetric::Cosine,
            3,
        );
        idx.register_file(&mut bm, dir.path());
        idx.hnsw_mut().insert(vec![1.0, 2.0, 3.0], 0);
        idx.hnsw_mut().insert(vec![4.0, 5.0, 6.0], 1);
        idx.hnsw_mut().insert(vec![7.0, 8.0, 9.0], 2);
        assert_eq!(idx.hnsw.len(), 3);
        idx.save(&mut bm).unwrap();

        // Reload into a fresh instance.
        let mut loaded = VectorIndexTable::new(
            1,
            "vec_idx".into(),
            "items".into(),
            "embedding".into(),
            DistanceMetric::Cosine,
            0,
        );
        loaded.register_file(&mut bm, dir.path());
        loaded.load(&mut bm).unwrap();

        // Exactly the persisted vectors are rebuilt — no phantom empties (P52.17).
        assert_eq!(loaded.hnsw.len(), 3);
        assert_eq!(loaded.dimensions, 3);
        let hits = loaded.hnsw.search(&[1.0, 2.0, 3.0], 3);
        assert_eq!(hits.len(), 3);
        assert_eq!(hits[0].1, 0, "nearest vector to [1,2,3] must be the first inserted");
        // All persisted vectors must be present in the result set.
        let mut ids: Vec<usize> = hits.iter().map(|&(_, id)| id).collect();
        ids.sort_unstable();
        assert_eq!(ids, vec![0, 1, 2]);
    }

    #[test]
    fn test_vector_index_roundtrip_preserves_ids() {
        // P51.17: node ids (row offsets) must survive persist/load, even when
        // sparse (rows with a NULL vector are skipped during populate).
        let dir = tempfile::tempdir().unwrap();
        let mut bm = setup_bm(dir.path());

        let mut idx = VectorIndexTable::new(
            2,
            "sparse_idx".into(),
            "items".into(),
            "embedding".into(),
            DistanceMetric::Euclidean,
            2,
        );
        idx.register_file(&mut bm, dir.path());
        idx.hnsw_mut().insert(vec![0.0, 0.0], 0);
        idx.hnsw_mut().insert(vec![1.0, 1.0], 2); // row 1 skipped
        idx.hnsw_mut().insert(vec![2.0, 2.0], 5);
        idx.save(&mut bm).unwrap();

        let mut loaded = VectorIndexTable::new(
            2,
            "sparse_idx".into(),
            "items".into(),
            "embedding".into(),
            DistanceMetric::Euclidean,
            0,
        );
        loaded.register_file(&mut bm, dir.path());
        loaded.load(&mut bm).unwrap();

        assert_eq!(loaded.hnsw.len(), 3);
        assert!(loaded.hnsw().get_vector(5).is_some(), "id 5 must be restored");
        assert!(loaded.hnsw().get_vector(1).is_none());
        let hits = loaded.hnsw().search(&[2.0, 2.0], 3);
        assert_eq!(hits[0].1, 5, "nearest vector must still address row 5");
    }

    #[test]
    fn test_vector_index_save_errors_when_vector_too_large() {
        let dir = tempfile::tempdir().unwrap();
        let mut bm = setup_bm(dir.path());

        let mut idx = VectorIndexTable::new(
            1,
            "vec_idx".into(),
            "items".into(),
            "embedding".into(),
            DistanceMetric::Cosine,
            1,
        );
        idx.register_file(&mut bm, dir.path());
        // A vector that cannot fit in one page must fail loudly, not silently
        // drop data (P52.17).
        let huge = vec![1.0f64; DEFAULT_PAGE_SIZE];
        idx.hnsw_mut().insert(huge, 0);
        assert!(idx.save(&mut bm).is_err());
    }
}