1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
//! Auto-extracted from physical_operator.rs
use crate::physical::types::{OperatorResult, PhysicalOperatorExec};
use akar_common::types::{PhysicalTypeID, Value};
use akar_common::vector::{DataChunk, ValueVector};
use akar_parser::ast::Constant;
use akar_storage::table::TableCatalog;
use akar_storage::wal::{WalSink, log_delete_record};
use akar_transaction::UndoRecord;
use std::sync::{Arc, Mutex};
// ==================== Delete ====================
/// Physical operator for DELETE — removes rows from a node or rel table.
pub struct PhysicalDelete {
pub table_name: String,
pub table_id: u64,
pub primary_key_column: String,
pub is_node: bool,
pub detach: bool,
/// Row indices to delete (found by the scan/filter pipeline).
pub row_indices: Vec<u64>,
pub table_catalog: Arc<TableCatalog>,
/// Active transaction id — deletes are recorded in `VersionInfo` for MVCC (P52.18).
pub txn_id: Option<u64>,
/// Undo sink for rollback records (P52.18).
pub undo_sink: Option<Arc<Mutex<Vec<UndoRecord>>>>,
/// Typed WAL sink so deletions survive restarts via WAL replay (P60.2).
pub wal_sink: Option<WalSink>,
}
impl PhysicalOperatorExec for PhysicalDelete {
fn operator_type(&self) -> &str {
"delete"
}
fn execute(&self, input: Vec<DataChunk>) -> OperatorResult {
// Collect row indices from input chunks
let mut rows_to_delete: Vec<u64> = self.row_indices.clone();
// If input has data, extract row indices from it.
// The scan emits the physical row index as the `<alias>._id` column
// (last column); reading column 0 would treat the first *property*
// value as a row index (wrong row or an out-of-range no-op).
for chunk in &input {
let row_id_col = row_id_column_index(chunk);
for row in 0..chunk.size {
if !chunk.fields.is_empty() {
if let Some(akar_common::types::Value::Int64(val)) = chunk.get_value(row_id_col.unwrap_or(0), row) {
rows_to_delete.push(val as u64);
}
}
}
}
if rows_to_delete.is_empty() {
// No rows to delete — emit zero-row chunks so a following
// `RETURN count(*)` reports 0 (the old 1-row count chunk made it
// report 1 regardless; CREATE/SET already follow the per-row
// convention, P53.25/P53.30).
let mut out = Vec::with_capacity(input.len());
for mut chunk in input {
chunk.resize(0);
chunk.sel_vector = None;
out.push(chunk);
}
return Ok(out);
}
// Delete rows from the table
let mut deleted = 0u64;
if self.is_node {
for &row_idx in &rows_to_delete {
if !self.detach && self.table_catalog.has_incident_edges(self.table_id, row_idx) {
return Err(format!(
"Cannot delete node {} because it has incident edges (use DETACH DELETE)",
row_idx
)
.into());
}
}
if self.detach {
// Log the incident edges BEFORE detaching so replay removes
// them too — `delete_edge` tombstones by stable index, and
// replay applies records in log order, matching live
// execution (P60.2).
for rel in self.table_catalog.all_rel_tables() {
if rel.src_table_id != self.table_id && rel.dst_table_id != self.table_id {
continue;
}
let rel_id = *rel.key();
for &row_idx in &rows_to_delete {
if rel.src_table_id == self.table_id
&& let Some(edges) = rel.fwd_adj.get(&row_idx)
{
for &(_, edge_idx) in edges.iter() {
log_delete_record(&self.wal_sink, rel_id, edge_idx as u64);
}
}
if rel.dst_table_id == self.table_id
&& let Some(edges) = rel.rev_adj.get(&row_idx)
{
for &(_, edge_idx) in edges.iter() {
log_delete_record(&self.wal_sink, rel_id, edge_idx as u64);
}
}
}
}
for &row_idx in &rows_to_delete {
self.table_catalog.detach_node(self.table_id, row_idx);
}
}
if let Some(mut table) = self.table_catalog.get_node_table_by_name_mut(&self.table_name) {
for &row_idx in &rows_to_delete {
// Capture pre-delete row data for rollback (P52.18) and
// record the delete in VersionInfo for MVCC isolation.
if let Some(sink) = self.undo_sink.as_ref()
&& let Ok(mut u) = sink.lock()
{
let old_data = table.row_undo_bytes(row_idx);
u.push(UndoRecord::delete(self.table_id, row_idx, old_data));
}
if table.delete_row_with_txn(row_idx, self.txn_id).is_ok() {
deleted += 1;
log_delete_record(&self.wal_sink, self.table_id, row_idx);
}
}
} else {
return Err(format!("Node table '{}' not found for DELETE", self.table_name).into());
}
} else {
if let Some(mut table) = self.table_catalog.get_rel_table_by_name_mut(&self.table_name) {
for &edge_idx in &rows_to_delete {
if let Some(sink) = self.undo_sink.as_ref()
&& let Ok(mut u) = sink.lock()
{
let old_data = table.edge_undo_bytes(edge_idx as usize);
u.push(UndoRecord::delete(self.table_id, edge_idx, old_data));
}
if table.delete_edge(edge_idx as usize).is_ok() {
deleted += 1;
log_delete_record(&self.wal_sink, self.table_id, edge_idx);
}
}
} else {
return Err(format!("Rel table '{}' not found for DELETE", self.table_name).into());
}
}
tracing::info!("DELETE: removed {deleted} rows from '{}'", self.table_name);
// Emit one row per deleted row so a following `RETURN count(*)` reports
// the actual deleted count (P53.37c). Column 0 carries the deleted count
// in every row, preserving the count-chunk contract for consumers that
// read `get_i64(0, 0)`. An all-failed delete emits zero rows.
let n = deleted as usize;
let mut v = ValueVector::new(PhysicalTypeID::Int64, n);
v.resize(n);
for i in 0..n {
v.set_i64(i, deleted as i64);
}
let arr = akar_common::arrow_vector::ArrowVector::from_legacy(&v).array;
Ok(vec![DataChunk::new(vec![arr], vec![PhysicalTypeID::Int64])])
}
}
/// Convert an AST Constant to a Value.
pub fn ast_constant_to_value(c: &Constant) -> Value {
match c {
Constant::Null => Value::Null,
Constant::Bool(b) => Value::Bool(*b),
Constant::Integer(i) => Value::Int64(*i),
Constant::Float(f) => Value::Double(*f),
Constant::String(s) => Value::String(s.clone()),
}
}
/// Locate the physical row index column in a scan-produced chunk.
///
/// Node scans append an internal node id column (`<alias>._id` = row offset)
/// as the last column of each chunk (see `resolve_scan_arrow_data` and
/// `resolve_scan_data`). Write operators (DELETE/SET) must read row indices
/// from that column; reading column 0 would use the first *property* value
/// as a row index. Falls back to `None` when the chunk carries no `_id`
/// column (e.g. rel table scans), letting callers keep the legacy behaviour.
pub fn row_id_column_index(chunk: &DataChunk) -> Option<usize> {
chunk.field_names.iter().position(|n| n == "_id" || n.ends_with("._id"))
}