aivcs-core 0.2.0

Core library for AIVCS domain logic and orchestration
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
//! Adapter bridging oxidizedgraph's `EventBus` lifecycle events into the
//! AIVCS `RunLedger` persistence layer.
//!
//! The [`LedgerHandler`] implements oxidizedgraph's [`EventHandler`] trait,
//! mapping each [`Event`] to a [`RunEvent`] and persisting it via
//! [`RunLedger::append_event`].
//!
//! # Usage
//!
//! ```rust,ignore
//! use aivcs_core::event_adapter::subscribe_ledger_to_bus;
//!
//! let bus = Arc::new(EventBus::new());
//! let ledger = Arc::new(MemoryRunLedger::new());
//! let handler = subscribe_ledger_to_bus(
//!     &bus,
//!     ledger,
//!     spec_digest,
//!     metadata,
//! ).await;
//! ```

use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
use std::sync::Arc;

use async_trait::async_trait;
use serde_json::json;
use tokio::sync::RwLock;
use tracing::{instrument, warn};

use crate::metrics::METRICS;

use oxidizedgraph::events::{
    spawn_handler, CheckpointEvent, Event, EventBus, EventHandler, EventKind, GraphEvent,
    NodeEvent, StateEvent,
};

use oxidized_state::storage_traits::{
    ContentDigest, RunEvent, RunId, RunLedger, RunMetadata, RunSummary,
};

/// Implements oxidizedgraph's `EventHandler` to persist graph lifecycle
/// events into an AIVCS `RunLedger`.
///
/// The handler:
/// - Creates a run on `on_start()`
/// - Maps each `Event` to a `RunEvent` and appends it on `handle()`
/// - Completes or fails the run on `on_stop()` based on whether errors occurred
pub struct LedgerHandler<L: RunLedger> {
    ledger: Arc<L>,
    run_id: RwLock<Option<RunId>>,
    seq: AtomicU64,
    spec_digest: ContentDigest,
    metadata: RunMetadata,
    saw_error: AtomicBool,
    start_time: RwLock<Option<std::time::Instant>>,
}

impl<L: RunLedger> LedgerHandler<L> {
    /// Create a new handler that will persist events to the given ledger.
    pub fn new(ledger: Arc<L>, spec_digest: ContentDigest, metadata: RunMetadata) -> Self {
        Self {
            ledger,
            run_id: RwLock::new(None),
            seq: AtomicU64::new(0),
            spec_digest,
            metadata,
            saw_error: AtomicBool::new(false),
            start_time: RwLock::new(None),
        }
    }

    /// Get the run ID (available after `on_start` is called).
    pub async fn run_id(&self) -> Option<RunId> {
        self.run_id.read().await.clone()
    }

    /// Whether any error events have been observed.
    pub fn saw_error(&self) -> bool {
        self.saw_error.load(Ordering::SeqCst)
    }

    /// Current sequence number.
    pub fn seq(&self) -> u64 {
        self.seq.load(Ordering::SeqCst)
    }

    /// Bump the sequence counter and return the new value.
    fn next_seq(&self) -> u64 {
        self.seq.fetch_add(1, Ordering::SeqCst)
    }
}

/// Map an oxidizedgraph `Event` into a `(kind, payload)` pair for `RunEvent`.
fn map_event(event: &Event) -> (String, serde_json::Value) {
    match &event.kind {
        EventKind::Graph(g) => match g {
            GraphEvent::Started {
                graph_name,
                entry_point,
            } => (
                "GraphStarted".into(),
                json!({ "graph_name": graph_name, "entry_point": entry_point }),
            ),
            GraphEvent::Completed {
                iterations,
                duration_ms,
            } => (
                "GraphCompleted".into(),
                json!({ "iterations": iterations, "duration_ms": duration_ms }),
            ),
            GraphEvent::Error { error } => ("GraphFailed".into(), json!({ "error": error })),
            GraphEvent::Interrupted { reason, node_id } => (
                "GraphInterrupted".into(),
                json!({ "reason": reason, "node_id": node_id }),
            ),
        },
        EventKind::Node(n) => match n {
            NodeEvent::Entered { node_id, iteration } => (
                "NodeEntered".into(),
                json!({ "node_id": node_id, "iteration": iteration }),
            ),
            NodeEvent::Exited {
                node_id,
                next_node,
                duration_ms,
            } => (
                "NodeExited".into(),
                json!({ "node_id": node_id, "next_node": next_node, "duration_ms": duration_ms }),
            ),
            NodeEvent::Error { node_id, error } => (
                "NodeFailed".into(),
                json!({ "node_id": node_id, "error": error }),
            ),
            NodeEvent::Retrying {
                node_id,
                attempt,
                delay_ms,
            } => (
                "NodeRetrying".into(),
                json!({ "node_id": node_id, "attempt": attempt, "delay_ms": delay_ms }),
            ),
        },
        EventKind::Checkpoint(c) => match c {
            CheckpointEvent::Saved {
                checkpoint_id,
                node_id,
            } => (
                "CheckpointSaved".into(),
                json!({ "checkpoint_id": checkpoint_id, "node_id": node_id }),
            ),
            CheckpointEvent::Restored {
                checkpoint_id,
                node_id,
            } => (
                "CheckpointRestored".into(),
                json!({ "checkpoint_id": checkpoint_id, "node_id": node_id }),
            ),
            CheckpointEvent::Deleted { checkpoint_id } => (
                "CheckpointDeleted".into(),
                json!({ "checkpoint_id": checkpoint_id }),
            ),
        },
        EventKind::State(s) => match s {
            StateEvent::Updated {
                node_id,
                keys_changed,
            } => (
                "StateUpdated".into(),
                json!({ "node_id": node_id, "keys_changed": keys_changed }),
            ),
            StateEvent::MessageAdded {
                role,
                content_length,
            } => (
                "MessageAdded".into(),
                json!({ "role": role, "content_length": content_length }),
            ),
        },
        EventKind::Custom { name, payload } => (format!("Custom:{name}"), payload.clone()),
    }
}

#[async_trait]
impl<L: RunLedger + 'static> EventHandler for LedgerHandler<L> {
    #[instrument(skip(self), name = "ledger_handler_on_start")]
    async fn on_start(&self) {
        *self.start_time.write().await = Some(std::time::Instant::now());

        match self
            .ledger
            .create_run(&self.spec_digest, self.metadata.clone())
            .await
        {
            Ok(id) => {
                *self.run_id.write().await = Some(id);
            }
            Err(e) => {
                warn!(error = %e, "LedgerHandler: failed to create run");
            }
        }
    }

    #[instrument(skip(self, event), name = "ledger_handler_handle", level = "debug")]
    async fn handle(&self, event: &Event) {
        let run_id = {
            let guard = self.run_id.read().await;
            match guard.as_ref() {
                Some(id) => id.clone(),
                None => return,
            }
        };

        METRICS.inc_events_processed();

        let (kind, payload) = map_event(event);

        // Track errors
        if matches!(
            &event.kind,
            EventKind::Graph(GraphEvent::Error { .. }) | EventKind::Node(NodeEvent::Error { .. })
        ) {
            self.saw_error.store(true, Ordering::SeqCst);
        }

        let run_event = RunEvent {
            seq: self.next_seq(),
            kind,
            payload,
            timestamp: event.timestamp,
        };

        if let Err(e) = self.ledger.append_event(&run_id, run_event).await {
            warn!(error = %e, run_id = %run_id, "LedgerHandler: failed to append event");
        }
    }

    #[instrument(skip(self), name = "ledger_handler_on_stop")]
    async fn on_stop(&self) {
        let run_id = {
            let guard = self.run_id.read().await;
            match guard.as_ref() {
                Some(id) => id.clone(),
                None => return,
            }
        };

        let total_events = self.seq.load(Ordering::SeqCst);
        let duration_ms = self
            .start_time
            .read()
            .await
            .map(|t| t.elapsed().as_millis() as u64)
            .unwrap_or(0);
        let success = !self.saw_error.load(Ordering::SeqCst);

        let summary = RunSummary {
            total_events,
            final_state_digest: None,
            duration_ms,
            success,
        };

        let result = if success {
            self.ledger.complete_run(&run_id, summary).await
        } else {
            self.ledger.fail_run(&run_id, summary).await
        };

        if let Err(e) = result {
            warn!(error = %e, run_id = %run_id, "LedgerHandler: failed to finalize run");
        }
    }
}

/// Subscribe a [`LedgerHandler`] to an [`EventBus`], spawning it as a
/// background task via [`spawn_handler`].
///
/// Returns the handler so callers can inspect `run_id()`, `seq()`, etc.
/// The background task runs until the `EventBus` sender is dropped.
pub fn subscribe_ledger_to_bus<L: RunLedger + 'static>(
    bus: &EventBus,
    ledger: Arc<L>,
    spec_digest: ContentDigest,
    metadata: RunMetadata,
) -> Arc<LedgerHandler<L>> {
    let handler = Arc::new(LedgerHandler::new(ledger, spec_digest, metadata));
    let receiver = bus.subscribe();
    spawn_handler(handler.clone(), receiver);
    handler
}

#[cfg(test)]
mod tests {
    use super::*;
    use oxidized_state::fakes::MemoryRunLedger;
    use oxidized_state::storage_traits::RunStatus;
    use std::time::Duration;

    fn test_digest() -> ContentDigest {
        ContentDigest::from_bytes(b"test-spec")
    }

    fn test_metadata() -> RunMetadata {
        RunMetadata {
            git_sha: None,
            agent_name: "test-agent".into(),
            tags: json!({}),
        }
    }

    #[tokio::test]
    async fn map_event_covers_all_variants() {
        let cases = vec![
            (
                Event::graph_started("t", Some("g".into()), "entry".into()),
                "GraphStarted",
            ),
            (
                Event::graph_completed("t", 5, Duration::from_millis(100)),
                "GraphCompleted",
            ),
            (Event::graph_error("t", "boom".into()), "GraphFailed"),
            (Event::node_entered("t", "n".into(), 1), "NodeEntered"),
            (
                Event::node_exited("t", "n".into(), Some("m".into()), Duration::from_millis(50)),
                "NodeExited",
            ),
            (
                Event::node_error("t", "n".into(), "fail".into()),
                "NodeFailed",
            ),
            (
                Event::checkpoint_saved("t", "cp1".into(), "n".into()),
                "CheckpointSaved",
            ),
            (
                Event::checkpoint_restored("t", "cp1".into(), "n".into()),
                "CheckpointRestored",
            ),
            (
                Event::state_updated("t", "n".into(), vec!["key".into()]),
                "StateUpdated",
            ),
        ];

        for (event, expected_kind) in cases {
            let (kind, _) = map_event(&event);
            assert_eq!(kind, expected_kind, "wrong kind for {expected_kind}");
        }
    }

    #[tokio::test]
    async fn handler_creates_and_completes_run() {
        let ledger = Arc::new(MemoryRunLedger::new());
        let handler = LedgerHandler::new(ledger.clone(), test_digest(), test_metadata());

        handler.on_start().await;
        let run_id = handler.run_id().await.expect("run_id should be set");

        // Feed an event
        let event = Event::graph_started("t", Some("g".into()), "entry".into());
        handler.handle(&event).await;
        assert_eq!(handler.seq(), 1);

        handler.on_stop().await;

        let record = ledger.get_run(&run_id).await.unwrap();
        assert_eq!(record.status, RunStatus::Completed);
        assert!(record.summary.as_ref().unwrap().success);
    }

    #[tokio::test]
    async fn handler_marks_run_failed_on_error_event() {
        let ledger = Arc::new(MemoryRunLedger::new());
        let handler = LedgerHandler::new(ledger.clone(), test_digest(), test_metadata());

        handler.on_start().await;
        let run_id = handler.run_id().await.unwrap();

        let event = Event::graph_error("t", "kaboom".into());
        handler.handle(&event).await;

        handler.on_stop().await;

        let record = ledger.get_run(&run_id).await.unwrap();
        assert_eq!(record.status, RunStatus::Failed);
        assert!(!record.summary.as_ref().unwrap().success);
    }

    #[tokio::test]
    async fn custom_event_mapping() {
        let event = Event::new(
            "t",
            EventKind::Custom {
                name: "MyCustom".into(),
                payload: json!({"foo": "bar"}),
            },
        );
        let (kind, payload) = map_event(&event);
        assert_eq!(kind, "Custom:MyCustom");
        assert_eq!(payload, json!({"foo": "bar"}));
    }
}