aisimulate-core 0.1.0-dev.2

Engine-neutral inference simulation, deterministic replay, and performance modeling
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
// SPDX-FileCopyrightText: Copyright (c) 2025-2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

use std::collections::BTreeSet;
use std::marker::PhantomData;

use crate::engine::generalized::{PassId, SameTimestampRetry, SchedulerCommand};
use crate::engine::{
    Command, CommandResult, Engine, ForwardPassMetrics, PassCompletionEffects, Request,
};
use anyhow::{Context, Result, bail};
use uuid::Uuid;

use super::super::core::{EngineEventBatch, EngineProgress, NoEngineEvents, WorkerTopology};
use super::super::events::{EnginePassCompletion, SimulationWorkerStage, WorkerCompletionPayload};
use super::{EngineEffects, EnginePassMode, ObservedCommandEffects, ReplayEngineObservation};
use crate::replay::TraceCollector;
use crate::replay::engine::ReplayRoleFactory;
use crate::replay::protocol::{DirectRequest, ForwardPassSnapshot, OutputSignal};

// SGLang admission may require hundreds of effect-free passes while its
// output-reservation ratio converges. Keep this above the native default of
// 600 decay steps while still bounding a broken scheduler's same-time retry.
const MAX_CONSECUTIVE_SAME_TIMESTAMP_RETRIES: usize = 1024;

#[derive(Clone, Copy)]
struct PendingPass {
    pass_id: PassId,
    started_at_ms: f64,
    end_ms: f64,
}

struct LogicalWorker {
    engine: Engine,
    scheduler_ids: Vec<usize>,
    /// Request IDs whose ownership is still counted by Replay for each rank.
    ///
    /// A handoff prefill can emit a terminal source signal before the later
    /// `ReleaseSource` command retires the engine-side hold. Tracking IDs, not
    /// only a counter, makes the second retirement idempotent while still
    /// accounting for cancellation before prefill completion.
    in_flight_by_rank: Vec<BTreeSet<Uuid>>,
    pending_pass: Option<PendingPass>,
    consecutive_same_timestamp_retries: usize,
    #[cfg(test)]
    same_timestamp_retries_total: usize,
}

impl LogicalWorker {
    fn total_in_flight(&self) -> usize {
        self.in_flight_by_rank.iter().map(BTreeSet::len).sum()
    }
}

#[derive(Clone, Copy)]
struct SchedulerOwner {
    worker_id: usize,
    dp_rank: u32,
}

/// Fleet/lifecycle adapter around the authoritative generalized mock engine.
///
/// This type owns stable scheduler IDs, startup/draining state, and replay
/// accounting. Attention-DP readiness, pass barriers, and group completion
/// time are owned exclusively by [`Engine`].
pub(crate) struct EngineComponent<Observation = NoEngineEvents>
where
    Observation: ReplayEngineObservation,
{
    stage: SimulationWorkerStage,
    _pass_mode: EnginePassMode,
    workers: Vec<Option<LogicalWorker>>,
    scheduler_owners: Vec<Option<SchedulerOwner>>,
    live_worker_count: usize,
    total_in_flight: usize,
    ready_workers: BTreeSet<usize>,
    /// Ready workers whose prior pass changed no externally visible state.
    ///
    /// Keep them out of the current drive scan so a lower worker ID cannot
    /// starve later workers. They are reconsidered on the next coordinator
    /// drive at the same or a later virtual timestamp.
    deferred_ready_workers: BTreeSet<usize>,
    pending_removal: BTreeSet<usize>,
    pending_startup: BTreeSet<usize>,
    factory: ReplayRoleFactory,
    startup_time_ms: Option<f64>,
    capture_artifact_kv_events: bool,
    observation: PhantomData<Observation>,
}

impl<Observation> EngineComponent<Observation>
where
    Observation: ReplayEngineObservation,
{
    pub(crate) fn new_with_factory(
        stage: SimulationWorkerStage,
        pass_mode: EnginePassMode,
        factory: ReplayRoleFactory,
        num_workers: usize,
        startup_time_ms: Option<f64>,
    ) -> Result<Self> {
        let mut component = Self {
            stage,
            _pass_mode: pass_mode,
            workers: Vec::with_capacity(num_workers),
            scheduler_owners: Vec::with_capacity(
                num_workers.saturating_mul(factory.dp_size() as usize),
            ),
            live_worker_count: 0,
            total_in_flight: 0,
            ready_workers: BTreeSet::new(),
            deferred_ready_workers: BTreeSet::new(),
            pending_removal: BTreeSet::new(),
            pending_startup: BTreeSet::new(),
            factory,
            startup_time_ms,
            capture_artifact_kv_events: false,
            observation: PhantomData,
        };
        for _ in 0..num_workers {
            component.add_worker()?;
        }
        component.refresh_all_workers();
        Ok(component)
    }

    /// Retain raw pass-boundary KV events for a Replay-owned artifact sink.
    /// Normal engine and Router runs leave this disabled and avoid the clone.
    pub(crate) fn set_artifact_kv_capture(&mut self, capture: bool) {
        self.capture_artifact_kv_events = capture;
    }

    fn required_worker(&self, worker_id: usize) -> Result<&LogicalWorker> {
        self.workers
            .get(worker_id)
            .and_then(Option::as_ref)
            .with_context(|| format!("offline replay selected unknown worker {worker_id}"))
    }

    fn required_worker_mut(&mut self, worker_id: usize) -> Result<&mut LogicalWorker> {
        self.workers
            .get_mut(worker_id)
            .and_then(Option::as_mut)
            .with_context(|| format!("offline replay selected unknown worker {worker_id}"))
    }

    fn scheduler_owner(&self, scheduler_id: usize) -> Result<SchedulerOwner> {
        self.scheduler_owners
            .get(scheduler_id)
            .and_then(|owner| *owner)
            .with_context(|| format!("offline replay selected unknown rank {scheduler_id}"))
    }

    fn refresh_worker(&mut self, worker_id: usize) {
        let ready = self
            .workers
            .get(worker_id)
            .and_then(Option::as_ref)
            .is_some_and(|worker| {
                worker.pending_pass.is_none()
                    && worker.engine.is_ready()
                    && !worker.engine.waiting_for_external_command()
            });
        if ready {
            self.ready_workers.insert(worker_id);
        } else {
            self.ready_workers.remove(&worker_id);
        }
    }

    fn refresh_all_workers(&mut self) {
        for worker_id in 0..self.workers.len() {
            self.refresh_worker(worker_id);
        }
    }

    pub(crate) fn add_worker(&mut self) -> Result<usize> {
        let worker_id = self.workers.len();
        let next_live_worker_count = self
            .live_worker_count
            .checked_add(1)
            .context("live worker count overflow")?;
        let engine = self.factory.build(worker_id)?;
        let dp_size = usize::try_from(self.factory.dp_size())
            .context("native engine dp_size does not fit usize")?;
        let mut scheduler_ids = Vec::with_capacity(dp_size);
        for dp_rank in 0..self.factory.dp_size() {
            let scheduler_id = self.scheduler_owners.len();
            self.scheduler_owners
                .push(Some(SchedulerOwner { worker_id, dp_rank }));
            scheduler_ids.push(scheduler_id);
        }
        self.workers.push(Some(LogicalWorker {
            engine,
            scheduler_ids,
            in_flight_by_rank: vec![BTreeSet::new(); dp_size],
            pending_pass: None,
            consecutive_same_timestamp_retries: 0,
            #[cfg(test)]
            same_timestamp_retries_total: 0,
        }));
        self.live_worker_count = next_live_worker_count;
        self.refresh_worker(worker_id);
        Ok(worker_id)
    }

    fn tombstone_worker(&mut self, worker_id: usize) -> Result<bool> {
        let Some(worker) = self.workers.get(worker_id).and_then(Option::as_ref) else {
            return Ok(false);
        };
        if !worker.engine.is_drained() || worker.pending_pass.is_some() {
            bail!("cannot remove non-drained generalized engine {worker_id}");
        }
        let worker_in_flight = worker.total_in_flight();
        let scheduler_ids = worker.scheduler_ids.clone();
        let next_total_in_flight = self
            .total_in_flight
            .checked_sub(worker_in_flight)
            .context("worker in-flight accounting underflow during removal")?;
        let next_live_worker_count = self
            .live_worker_count
            .checked_sub(1)
            .context("live worker count underflow")?;
        for scheduler_id in &scheduler_ids {
            self.scheduler_owners
                .get(*scheduler_id)
                .context("worker owned an out-of-range scheduler during removal")?;
        }

        // Validate every fallible invariant before mutating the fleet. If a
        // planner-triggered removal fails, Replay can now return the error
        // without leaving a half-tombstoned worker behind.
        self.ready_workers.remove(&worker_id);
        self.deferred_ready_workers.remove(&worker_id);
        self.workers
            .get_mut(worker_id)
            .context("worker disappeared during removal")?
            .take()
            .context("worker disappeared during removal")?;
        self.total_in_flight = next_total_in_flight;
        self.live_worker_count = next_live_worker_count;
        for scheduler_id in scheduler_ids {
            *self
                .scheduler_owners
                .get_mut(scheduler_id)
                .context("worker owned an out-of-range scheduler during removal")? = None;
        }
        Ok(true)
    }

    pub(crate) fn mark_for_removal(&mut self, worker_id: usize) {
        self.pending_removal.insert(worker_id);
    }

    pub(crate) fn try_remove_drained(&mut self) -> Result<Vec<usize>> {
        let removable = self
            .pending_removal
            .iter()
            .copied()
            .filter(|worker_id| {
                self.workers
                    .get(*worker_id)
                    .and_then(Option::as_ref)
                    .is_none_or(|worker| {
                        worker.pending_pass.is_none()
                            && worker.total_in_flight() == 0
                            && worker.engine.is_drained()
                    })
            })
            .collect::<Vec<_>>();
        let mut removed = Vec::with_capacity(removable.len());
        for worker_id in removable {
            if self
                .tombstone_worker(worker_id)
                .with_context(|| format!("failed to remove drained worker {worker_id}"))?
            {
                removed.push(worker_id);
            }
            self.pending_removal.remove(&worker_id);
        }
        Ok(removed)
    }

    pub(crate) fn apply_target_count(
        &mut self,
        target: usize,
    ) -> Result<(Vec<usize>, Vec<usize>, Vec<usize>)> {
        let active_ids = self.active_group_ids();
        let effective = active_ids
            .len()
            .checked_add(self.pending_startup.len())
            .context("non-draining worker count overflow")?;
        let mut added = Vec::new();
        let mut newly_marked = Vec::new();

        if target > effective {
            for _ in 0..(target - effective) {
                let id = self.add_worker().with_context(|| {
                    format!("failed to add worker while scaling from {effective} to {target}")
                })?;
                if self.startup_time_ms.is_some() {
                    self.pending_startup.insert(id);
                    self.ready_workers.remove(&id);
                }
                added.push(id);
            }
        } else if target < effective {
            let excess = effective - target;
            let to_cancel = self
                .pending_startup
                .iter()
                .copied()
                .rev()
                .take(excess)
                .collect::<Vec<_>>();
            for id in &to_cancel {
                self.tombstone_worker(*id)
                    .with_context(|| format!("failed to cancel starting worker {id}"))?;
                self.pending_startup.remove(id);
            }
            for id in active_ids.iter().rev().take(excess - to_cancel.len()) {
                self.mark_for_removal(*id);
                newly_marked.push(*id);
            }
        }

        let removed = self.try_remove_drained()?;
        Ok((added, newly_marked, removed))
    }

    pub(crate) fn active_group_ids(&self) -> Vec<usize> {
        self.workers
            .iter()
            .enumerate()
            .filter(|(worker_id, worker)| {
                worker.is_some()
                    && !self.pending_removal.contains(worker_id)
                    && !self.pending_startup.contains(worker_id)
            })
            .map(|(worker_id, _)| worker_id)
            .collect()
    }

    pub(crate) fn starting_group_ids(&self) -> Vec<usize> {
        self.pending_startup.iter().copied().collect()
    }

    pub(crate) fn draining_group_ids(&self) -> Vec<usize> {
        self.pending_removal.iter().copied().collect()
    }

    pub(crate) fn non_draining_group_count(&self) -> usize {
        self.active_group_ids().len() + self.pending_startup.len()
    }

    pub(crate) fn worker_topology(&self, worker_id: usize) -> Option<WorkerTopology> {
        Some(WorkerTopology {
            worker_id,
            scheduler_ids: self.workers.get(worker_id)?.as_ref()?.scheduler_ids.clone(),
        })
    }

    pub(crate) fn active_topology(&self) -> Vec<WorkerTopology> {
        self.active_group_ids()
            .into_iter()
            .filter_map(|worker_id| self.worker_topology(worker_id))
            .collect()
    }

    pub(crate) fn dp_size(&self) -> u32 {
        self.factory.dp_size()
    }

    pub(crate) fn rank_identity(&self, scheduler_id: usize) -> Option<(usize, u32)> {
        let owner = self
            .scheduler_owners
            .get(scheduler_id)
            .and_then(|owner| *owner)?;
        Some((owner.worker_id, owner.dp_rank))
    }

    pub(crate) fn has_active_workers(&self) -> bool {
        !self.active_group_ids().is_empty()
    }

    pub(crate) fn startup_time_ms(&self) -> Option<f64> {
        self.startup_time_ms
    }

    pub(crate) fn mark_worker_ready(&mut self, worker_id: usize) -> bool {
        let ready = self.pending_startup.remove(&worker_id)
            && self.workers.get(worker_id).is_some_and(Option::is_some);
        if ready {
            self.refresh_worker(worker_id);
        }
        ready
    }

    pub(crate) fn dispatch(
        &mut self,
        scheduler_id: usize,
        request: DirectRequest,
        now_ms: f64,
    ) -> Result<()> {
        let expected = request
            .uuid
            .context("offline replay request must have a UUID before dispatch")?;
        let effects = self.apply_command(
            scheduler_id,
            Command::Submit(native_request(request)?),
            now_ms,
        )?;
        if !matches!(effects.result, CommandResult::Submitted(id) if id == expected) {
            bail!("native engine returned an unexpected submit result");
        }
        Ok(())
    }

    pub(crate) fn apply_command(
        &mut self,
        scheduler_id: usize,
        command: Command,
        now_ms: f64,
    ) -> Result<ObservedCommandEffects<Observation::Batch>> {
        let owner = self.scheduler_owner(scheduler_id)?;
        let effects = self
            .required_worker_mut(owner.worker_id)?
            .engine
            .apply_command_effects(SchedulerCommand::new(owner.dp_rank, command), now_ms)
            .map_err(crate::replay::error::engine_boundary)?
            .into_by_rank()
            .into_iter()
            .next()
            .context("addressed native command produced no rank effects")?
            .effects;

        let acquired = match effects.result {
            CommandResult::Submitted(request_id)
            | CommandResult::DestinationAccepted { request_id } => Some(request_id),
            CommandResult::Applied | CommandResult::Noop => None,
        };
        self.apply_request_accounting(owner, acquired, &effects.retired_requests)?;
        let engine_events = Observation::observe_engine_events(
            self.stage.into(),
            owner.worker_id,
            owner.dp_rank,
            effects.kv_events,
        );
        self.refresh_worker(owner.worker_id);
        Ok(ObservedCommandEffects {
            result: effects.result,
            lifecycle_events: effects.lifecycle_events,
            engine_events,
        })
    }

    fn apply_request_accounting(
        &mut self,
        owner: SchedulerOwner,
        acquired: Option<Uuid>,
        retired: &[Uuid],
    ) -> Result<()> {
        let (before, after) = {
            let worker = self.required_worker_mut(owner.worker_id)?;
            let rank = worker
                .in_flight_by_rank
                .get_mut(owner.dp_rank as usize)
                .context("native command returned an out-of-range DP rank")?;
            let before = rank.len();
            if let Some(request_id) = acquired {
                rank.insert(request_id);
            }
            for request_id in retired {
                rank.remove(request_id);
            }
            (before, rank.len())
        };
        if after >= before {
            self.total_in_flight = self
                .total_in_flight
                .checked_add(after - before)
                .context("offline engine in-flight request count overflow")?;
        } else {
            self.total_in_flight = self
                .total_in_flight
                .checked_sub(before - after)
                .context("offline engine retired more requests than replay tracked")?;
        }
        Ok(())
    }

    pub(crate) fn worker_is_busy(&self, scheduler_id: usize) -> Result<bool> {
        let owner = self.scheduler_owner(scheduler_id)?;
        Ok(self
            .required_worker(owner.worker_id)?
            .pending_pass
            .is_some())
    }

    pub(crate) fn drive_ready(
        &mut self,
        now_ms: f64,
        _collector: Option<&mut TraceCollector>,
    ) -> Result<EngineEffects<Observation::Batch>> {
        // A serial coordinator may make a previously effect-free worker
        // observable without advancing virtual time. Retry those workers on
        // the next coordinator drive, while allowing every other ready worker
        // a turn in this scan.
        let deferred = std::mem::take(&mut self.deferred_ready_workers);
        for worker_id in deferred {
            self.refresh_worker(worker_id);
        }
        while let Some(worker_id) = self.ready_workers.pop_first() {
            let started = {
                let worker = self.required_worker_mut(worker_id)?;
                if worker.pending_pass.is_some()
                    || !worker.engine.is_ready()
                    || worker.engine.waiting_for_external_command()
                {
                    continue;
                }
                worker
                    .engine
                    .execute_pass(now_ms)
                    .map_err(crate::replay::error::engine_boundary)?
            };
            let Some(started) = started else {
                self.refresh_worker(worker_id);
                continue;
            };

            let same_timestamp_retry = started.same_timestamp_retry;
            let pending = PendingPass {
                pass_id: started.pass_id,
                started_at_ms: started.started_at_ms,
                end_ms: started.end_ms,
            };

            let mut effects: EngineEffects<Observation::Batch> = EngineEffects::default();
            for rank in started.by_rank {
                effects
                    .admissions
                    .extend(rank.effects.admissions.into_iter().map(|admission| {
                        super::AdmissionEvent {
                            uuid: admission.request_id,
                            reused_input_tokens: admission.reused_input_tokens,
                        }
                    }));
                effects
                    .pressure_events
                    .extend(rank.effects.pressure_events.into_iter().map(|event| {
                        super::PressureEvent {
                            worker_id: worker_id as u64,
                            dp_rank: rank.dp_rank,
                            event,
                        }
                    }));
                if !rank.effects.kv_events.is_empty() {
                    bail!(
                        "generalized engine exposed KV observations before pass completion for worker {worker_id} rank {}",
                        rank.dp_rank
                    );
                }
            }
            self.required_worker_mut(worker_id)?.pending_pass = Some(pending);

            if started.end_ms > now_ms {
                effects.schedule_completion(
                    started.end_ms,
                    EnginePassCompletion::new(self.stage, worker_id, started.pass_id),
                );
            } else {
                // Completing the pass mutates the authoritative scheduler even
                // when it exposes no effects. Do not surface an empty
                // zero-duration completion as progress: doing so immediately
                // re-arms the still-ready worker and lets the virtual-time
                // driver spin forever at the same timestamp. A pass that already
                // exposed start effects is the exception: its matching completion
                // hook remains observable even when the completion payload is empty.
                let completions = self.complete_pass(
                    EnginePassCompletion::new(self.stage, worker_id, started.pass_id),
                    now_ms,
                )?;
                effects.immediate_completions = completions
                    .into_iter()
                    .filter(|payload| effects.should_retain_immediate_completion(payload.progress))
                    .collect();
            }
            effects.progress.made_progress = !effects.admissions.is_empty()
                || !effects.pressure_events.is_empty()
                || !effects.pass_start_events.is_empty()
                || effects.artifact_pass_start.is_some()
                || !effects.immediate_completions.is_empty()
                || effects.scheduled_completion.is_some();

            let same_timestamp_candidate = started.end_ms == now_ms
                && effects.is_empty()
                && self.ready_workers.contains(&worker_id);
            if same_timestamp_candidate {
                match same_timestamp_retry {
                    SameTimestampRetry::Retry => {
                        let worker = self.required_worker_mut(worker_id)?;
                        worker.consecutive_same_timestamp_retries += 1;
                        #[cfg(test)]
                        {
                            worker.same_timestamp_retries_total += 1;
                        }
                        if worker.consecutive_same_timestamp_retries
                            >= MAX_CONSECUTIVE_SAME_TIMESTAMP_RETRIES
                        {
                            let in_flight = worker.total_in_flight();
                            bail!(
                                "offline replay detected an effect-free zero-duration pass with {in_flight} in-flight requests remaining"
                            );
                        }
                        continue;
                    }
                    SameTimestampRetry::Exhausted => {
                        let in_flight = self.required_worker(worker_id)?.total_in_flight();
                        // Aggregated workers have no external handoff command
                        // that can release rank-local capacity. Disaggregated
                        // roles may still be woken by a future source release
                        // or destination activation, so their runtime owns the
                        // final deadlock decision.
                        if self.stage == SimulationWorkerStage::Aggregated && in_flight > 0 {
                            bail!(
                                "offline replay detected an effect-free zero-duration pass with {in_flight} in-flight requests remaining"
                            );
                        }
                    }
                    SameTimestampRetry::NotApplicable => {}
                }
            }
            self.required_worker_mut(worker_id)?
                .consecutive_same_timestamp_retries = 0;
            if effects.is_empty() {
                if self.ready_workers.remove(&worker_id) {
                    self.deferred_ready_workers.insert(worker_id);
                }
                continue;
            }
            return Ok(effects);
        }
        Ok(EngineEffects::default())
    }

    pub(crate) fn on_scheduled_completion(
        &mut self,
        completion: EnginePassCompletion<Observation::Batch>,
        now_ms: f64,
    ) -> Result<Vec<WorkerCompletionPayload<Observation::Batch>>> {
        self.complete_pass(completion, now_ms)
    }

    fn complete_pass(
        &mut self,
        completion: EnginePassCompletion<Observation::Batch>,
        now_ms: f64,
    ) -> Result<Vec<WorkerCompletionPayload<Observation::Batch>>> {
        if completion.stage != self.stage {
            bail!(
                "offline replay completion stage mismatch: expected {:?}, got {:?}",
                self.stage,
                completion.stage
            );
        }
        let pending = self
            .required_worker_mut(completion.worker_id)?
            .pending_pass
            .take()
            .context("offline replay completed a worker with no pass in flight")?;
        if pending.pass_id != completion.pass_id {
            bail!("offline replay generalized-engine pass ID mismatch");
        }
        let completed = self
            .required_worker_mut(completion.worker_id)?
            .engine
            .complete_pass(completion.pass_id, now_ms)
            .map_err(crate::replay::error::engine_boundary)?;
        let mut payloads = Vec::with_capacity(completed.effects.by_rank.len());
        for rank in completed.effects.into_by_rank() {
            let scheduler_id = self
                .required_worker(completion.worker_id)?
                .scheduler_ids
                .get(rank.dp_rank as usize)
                .copied()
                .context("native completion returned an out-of-range DP rank")?;
            let completed_request_ids = rank
                .effects
                .outputs
                .iter()
                .filter_map(|output| output.completed.then_some(output.request_id))
                .collect::<Vec<_>>();
            self.apply_request_accounting(
                SchedulerOwner {
                    worker_id: completion.worker_id,
                    dp_rank: rank.dp_rank,
                },
                None,
                &completed_request_ids,
            )?;
            payloads.push(lower_completion::<Observation>(
                self.stage,
                completion.worker_id,
                scheduler_id,
                rank.dp_rank,
                &pending,
                self.capture_artifact_kv_events,
                rank.effects,
            ));
        }
        self.refresh_worker(completion.worker_id);
        Ok(payloads)
    }

    pub(crate) fn in_flight(&self) -> usize {
        self.total_in_flight
    }

    pub(crate) fn is_drained(&self) -> bool {
        self.total_in_flight == 0
            && self
                .workers
                .iter()
                .filter_map(Option::as_ref)
                .all(|worker| worker.pending_pass.is_none() && worker.engine.is_drained())
    }

    /// Whether a worker can currently execute a pass that is not waiting on
    /// an external handoff command.
    ///
    /// The replay driver uses this only to distinguish a genuine scheduler
    /// livelock from a legitimate externally blocked handoff when no future
    /// virtual-time event exists.
    pub(crate) fn has_runnable_worker(&self) -> bool {
        !self.ready_workers.is_empty() || !self.deferred_ready_workers.is_empty()
    }

    /// Whether Replay still owns requests that the scheduler silently dropped
    /// without terminal effects.
    ///
    /// This is the terminal shape of an effect-free, zero-duration pass (for
    /// example an impossible SGLang admission): no pass or external command
    /// can wake the drained engine, but Replay must still diagnose the lost
    /// terminal signal instead of reporting generic quiescence.
    pub(crate) fn has_orphaned_in_flight(&self) -> bool {
        self.total_in_flight > 0
            && self
                .workers
                .iter()
                .filter_map(Option::as_ref)
                .all(|worker| worker.pending_pass.is_none() && worker.engine.is_drained())
    }

    pub(crate) fn worker_count(&self) -> usize {
        self.live_worker_count
    }
}

fn native_request(request: DirectRequest) -> Result<Request> {
    Ok(Request {
        request_id: request
            .uuid
            .context("offline replay request must have a UUID before dispatch")?,
        tokens: request.tokens,
        max_output_tokens: request.max_output_tokens,
        output_token_ids: request.output_token_ids,
    })
}

fn lower_completion<Observation: ReplayEngineObservation>(
    stage: SimulationWorkerStage,
    worker_id: usize,
    scheduler_id: usize,
    dp_rank: u32,
    pass: &PendingPass,
    capture_artifact_kv_events: bool,
    effects: PassCompletionEffects,
) -> WorkerCompletionPayload<Observation::Batch> {
    let wall_time_secs = (pass.end_ms - pass.started_at_ms).max(0.0) / 1_000.0;
    let completed_requests = effects
        .outputs
        .iter()
        .filter(|output| output.completed)
        .count();
    let accept_length_output_tokens = effects
        .outputs
        .iter()
        .filter(|output| output.token_id.is_some())
        .count();
    let accept_length_decode_forwards = effects.forward_pass_metrics.num_decode_requests as usize;
    let made_progress = completed_requests > 0
        || !effects.outputs.is_empty()
        || !effects.lifecycle_events.is_empty()
        || !effects.kv_events.is_empty()
        || effects.forward_pass_metrics.num_prefill_requests > 0
        || effects.forward_pass_metrics.num_decode_requests > 0;
    let had_raw_observations = !effects.kv_events.is_empty();
    let artifact_pass_end_kv_events =
        capture_artifact_kv_events.then(|| effects.kv_events.clone().into_boxed_slice());
    let engine_events =
        Observation::observe_engine_events(stage.into(), worker_id, dp_rank, effects.kv_events);
    WorkerCompletionPayload {
        stage,
        worker_idx: scheduler_id,
        completed_requests,
        output_signals: effects
            .outputs
            .into_iter()
            .map(|output| OutputSignal {
                uuid: output.request_id,
                token_id: output.token_id,
                completed: output.completed,
                rejected: output.rejected,
                handoff_delay_ms: None,
                cached_tokens: output.cached_tokens,
            })
            .collect(),
        lifecycle_events: effects.lifecycle_events,
        engine_events,
        pass_started_at_ms: pass.started_at_ms,
        artifact_pass_end_kv_events,
        progress: EngineProgress {
            made_progress,
            had_raw_observations,
        },
        fpm: Some(native_fpm(
            dp_rank,
            wall_time_secs,
            effects.forward_pass_metrics,
        )),
        accept_length_output_tokens,
        accept_length_decode_forwards,
    }
}

fn native_fpm(dp_rank: u32, wall_time_secs: f64, fpm: ForwardPassMetrics) -> ForwardPassSnapshot {
    ForwardPassSnapshot {
        version: 0,
        worker_id: String::new(),
        dp_rank,
        counter_id: 0,
        num_prefill_requests: fpm.num_prefill_requests,
        sum_prefill_tokens: fpm.sum_prefill_tokens,
        var_prefill_length: fpm.var_prefill_length,
        sum_prefill_kv_tokens: fpm.sum_prefill_kv_tokens,
        num_decode_requests: fpm.num_decode_requests,
        sum_decode_kv_tokens: fpm.sum_decode_kv_tokens,
        var_decode_kv_tokens: fpm.var_decode_kv_tokens,
        num_queued_prefill: fpm.num_queued_prefill,
        sum_queued_prefill_tokens: fpm.sum_queued_prefill_tokens,
        var_queued_prefill_length: fpm.var_queued_prefill_length,
        num_queued_decode: fpm.num_queued_decode,
        sum_queued_decode_kv_tokens: fpm.sum_queued_decode_kv_tokens,
        var_queued_decode_kv_tokens: fpm.var_queued_decode_kv_tokens,
        wall_time_secs,
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::engine::{Backend, EngineConfig, KvEvent, SglangConfig, TimingModelConfig};
    use crate::replay::components::AdmissionEvent;
    use crate::replay::{ReplayEngineConfig, ReplayEngineFactory, WorkerStage};

    #[derive(Debug, Default)]
    struct KvEventBatch(Vec<KvEvent>);

    impl EngineEventBatch for KvEventBatch {
        fn is_empty(&self) -> bool {
            self.0.is_empty()
        }

        fn append(&mut self, mut other: Self) {
            self.0.append(&mut other.0);
        }
    }

    #[derive(Debug, Default)]
    struct KvEventObservation;

    impl ReplayEngineObservation for KvEventObservation {
        type Batch = KvEventBatch;

        const CAPTURE_ENGINE_KV_EVENTS: bool = true;

        fn observe_engine_events(
            _stage: WorkerStage,
            _worker_id: usize,
            _dp_rank: u32,
            events: Vec<KvEvent>,
        ) -> Self::Batch {
            KvEventBatch(events)
        }
    }

    fn component(num_workers: usize, startup_time_ms: Option<f64>) -> EngineComponent {
        let factory = ReplayEngineFactory::new()
            .role_factory(
                &ReplayEngineConfig::default(),
                WorkerStage::Aggregated,
                false,
            )
            .unwrap();
        EngineComponent::new_with_factory(
            SimulationWorkerStage::Aggregated,
            EnginePassMode::Visible,
            factory,
            num_workers,
            startup_time_ms,
        )
        .unwrap()
    }

    fn decode_component(num_workers: usize) -> EngineComponent {
        let config = ReplayEngineConfig {
            rank: EngineConfig {
                backend: Backend::Vllm,
                num_gpu_blocks: 16,
                block_size: 4,
                max_num_batched_tokens: 4,
                max_num_seqs: 1,
                enable_chunked_prefill: false,
                ..EngineConfig::for_backend(Backend::Vllm)
            },
            ..ReplayEngineConfig::default()
        };
        let factory = ReplayEngineFactory::new()
            .role_factory(&config, WorkerStage::Decode, false)
            .unwrap();
        EngineComponent::new_with_factory(
            SimulationWorkerStage::Decode,
            EnginePassMode::Visible,
            factory,
            num_workers,
            None,
        )
        .unwrap()
    }

    #[test]
    fn canceling_busy_startup_worker_returns_error_without_losing_worker() {
        let mut component = component(1, Some(10.0));
        let (added, _, _) = component.apply_target_count(2).unwrap();
        let starting_worker = added[0];
        let scheduler_id = component
            .worker_topology(starting_worker)
            .unwrap()
            .scheduler_ids[0];
        component
            .dispatch(
                scheduler_id,
                DirectRequest {
                    tokens: vec![1],
                    max_output_tokens: 1,
                    uuid: Some(Uuid::from_u128(1)),
                    ..Default::default()
                },
                0.0,
            )
            .unwrap();

        let error = component.apply_target_count(1).unwrap_err();

        assert!(
            error
                .to_string()
                .contains("failed to cancel starting worker")
        );
        assert_eq!(component.starting_group_ids(), vec![starting_worker]);
        assert!(component.worker_topology(starting_worker).is_some());
        assert_eq!(component.worker_count(), 2);
    }

    #[test]
    fn drained_removal_error_preserves_pending_worker() {
        let mut component = component(1, None);
        component.mark_for_removal(0);
        component.live_worker_count = 0;

        let error = component.try_remove_drained().unwrap_err();

        assert!(
            error
                .to_string()
                .contains("failed to remove drained worker 0")
        );
        assert_eq!(component.draining_group_ids(), vec![0]);
        assert!(component.worker_topology(0).is_some());
    }

    #[test]
    fn effect_free_worker_does_not_starve_later_ready_worker() {
        let mut component = decode_component(2);
        component
            .dispatch(
                0,
                DirectRequest {
                    tokens: vec![1; 8],
                    max_output_tokens: 1,
                    uuid: Some(Uuid::from_u128(20)),
                    ..Default::default()
                },
                0.0,
            )
            .unwrap();
        component
            .dispatch(
                1,
                DirectRequest {
                    tokens: vec![2; 4],
                    max_output_tokens: 1,
                    uuid: Some(Uuid::from_u128(21)),
                    ..Default::default()
                },
                0.0,
            )
            .unwrap();

        let effects = component.drive_ready(0.0, None).unwrap();

        assert!(!effects.is_empty());
        assert_eq!(component.deferred_ready_workers, BTreeSet::from([0]));
        assert!(
            effects
                .admissions
                .iter()
                .any(|admission| admission.uuid == Uuid::from_u128(21)),
            "the later ready worker must run after the lower ID produces no effects"
        );
    }

    #[test]
    fn effect_free_worker_is_retried_on_the_next_coordinator_drive() {
        let mut component = decode_component(1);
        component
            .dispatch(
                0,
                DirectRequest {
                    tokens: vec![1; 8],
                    max_output_tokens: 1,
                    uuid: Some(Uuid::from_u128(22)),
                    ..Default::default()
                },
                0.0,
            )
            .unwrap();

        assert!(component.drive_ready(0.0, None).unwrap().is_empty());
        assert!(component.ready_workers.is_empty());
        assert_eq!(component.deferred_ready_workers, BTreeSet::from([0]));
        assert!(component.has_runnable_worker());

        assert!(component.drive_ready(0.0, None).unwrap().is_empty());
        assert_eq!(component.deferred_ready_workers, BTreeSet::from([0]));
    }

    #[test]
    fn kv_observations_are_visible_only_at_pass_completion_for_all_backends() {
        for (backend, uuid) in [
            (Backend::Vllm, Uuid::from_u128(10)),
            (Backend::Trtllm, Uuid::from_u128(11)),
            (Backend::Sglang, Uuid::from_u128(12)),
        ] {
            let config = ReplayEngineConfig {
                rank: EngineConfig {
                    backend,
                    num_gpu_blocks: 8,
                    block_size: 4,
                    timing_model: TimingModelConfig::Fixed {
                        prefill_ms: 1.0,
                        decode_ms: 1.0,
                    },
                    ..EngineConfig::for_backend(backend)
                },
                ..ReplayEngineConfig::default()
            };
            let factory = ReplayEngineFactory::new()
                .role_factory(&config, WorkerStage::Aggregated, true)
                .unwrap();
            let mut component: EngineComponent<KvEventObservation> =
                EngineComponent::new_with_factory(
                    SimulationWorkerStage::Aggregated,
                    EnginePassMode::Visible,
                    factory,
                    1,
                    None,
                )
                .unwrap();
            component
                .dispatch(
                    0,
                    DirectRequest {
                        tokens: vec![1; 4],
                        max_output_tokens: 1,
                        uuid: Some(uuid),
                        ..Default::default()
                    },
                    0.0,
                )
                .unwrap();

            let mut pass_start = component.drive_ready(0.0, None).unwrap();
            assert!(
                pass_start.pass_start_events.0.is_empty(),
                "{backend:?} exposed KV observations at pass start"
            );
            let scheduled = pass_start
                .scheduled_completion
                .take()
                .expect("fixed timing must schedule a completion");
            let completed = component
                .on_scheduled_completion(scheduled.completion, scheduled.at_ms)
                .unwrap();
            assert!(
                completed
                    .iter()
                    .any(|payload| !payload.engine_events.0.is_empty()),
                "{backend:?} did not expose KV observations at pass completion"
            );
        }
    }

    #[test]
    fn sglang_component_consumes_retries_until_internal_state_converges() {
        let config = ReplayEngineConfig {
            rank: EngineConfig {
                backend: Backend::Sglang,
                num_gpu_blocks: 1,
                block_size: 4,
                sglang: SglangConfig {
                    chunked_prefill_size: 8,
                    ..SglangConfig::default()
                },
                timing_model: TimingModelConfig::Fixed {
                    prefill_ms: 1.0,
                    decode_ms: 1.0,
                },
                ..EngineConfig::for_backend(Backend::Sglang)
            },
            ..ReplayEngineConfig::default()
        };
        let factory = ReplayEngineFactory::new()
            .role_factory(&config, WorkerStage::Aggregated, false)
            .unwrap();
        let mut component: EngineComponent = EngineComponent::new_with_factory(
            SimulationWorkerStage::Aggregated,
            EnginePassMode::Visible,
            factory,
            1,
            None,
        )
        .unwrap();
        component
            .dispatch(
                0,
                DirectRequest {
                    tokens: vec![1; 8],
                    max_output_tokens: 2,
                    uuid: Some(Uuid::from_u128(2)),
                    ..Default::default()
                },
                37.0,
            )
            .unwrap();

        let error = component.drive_ready(37.0, None).unwrap_err();
        let retries = component.workers[0]
            .as_ref()
            .unwrap()
            .same_timestamp_retries_total;

        assert!(
            retries > 1,
            "the component must not stop after the first pass"
        );
        assert!(retries < MAX_CONSECUTIVE_SAME_TIMESTAMP_RETRIES);
        assert!(
            error.to_string().contains("effect-free zero-duration pass"),
            "{error}"
        );
    }

    #[test]
    fn pass_start_admission_retains_effect_free_immediate_completion() {
        let mut effects: EngineEffects = EngineEffects::default();
        effects.admissions.push(AdmissionEvent {
            uuid: Uuid::from_u128(3),
            reused_input_tokens: 0,
        });

        assert!(effects.should_retain_immediate_completion(EngineProgress::default()));
        assert!(
            !EngineEffects::<()>::default()
                .should_retain_immediate_completion(EngineProgress::default())
        );
    }
}