1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
//! Mailbox delivery surface of [`RuntimeHandle`]: wake markers, two-phase
//! activity completion retention, and the retry-tolerant enqueue path.
//!
//! Markers are pure wakes — durable state lives in recorded history or the
//! retained completion maps, never in the marker itself.
use aion_core::{ActivityError, ActivityErrorKind, ContentType, Payload};
use beamr::atom::Atom;
use beamr::process::ExitReason;
use crate::error::EngineError;
use super::{Pid, RuntimeHandle, runtime_error};
use crate::runtime::payload::term_to_payload;
impl RuntimeHandle {
/// Block until an activity exits, then surface its success or failure to the parent.
///
/// Normal returns become typed payload results queued for the workflow and
/// abnormal exits become typed activity errors that can be read alongside the
/// trapped EXIT message delivered by the runtime link.
///
/// # Errors
///
/// Returns [`EngineError::Runtime`] when the parent is not live, the result
/// term cannot be converted to a payload, or mailbox delivery fails.
pub fn propagate_activity_outcome(
&self,
parent_pid: Pid,
activity_pid: Pid,
) -> Result<(), EngineError> {
self.ensure_live_pid(parent_pid)?;
let (reason, owned_result) = self.scheduler.run_until_exit(activity_pid);
self.release_spawn_heaps(activity_pid);
if reason == ExitReason::Normal {
let payload = term_to_payload(owned_result.root(), &self.atom_table)?;
self.deliver_activity_result(parent_pid, activity_pid, payload)
} else {
let error = self
.activity_errors
.get(&(parent_pid, activity_pid))
.map_or_else(
|| ActivityError {
kind: ActivityErrorKind::Terminal,
message: format!("activity process {activity_pid} exited: {reason:?}"),
details: None,
},
|entry| entry.clone(),
);
self.deliver_activity_error(parent_pid, activity_pid, error)
}
}
/// Deliver a recorded signal wake marker to the workflow mailbox surface.
///
/// The marker is a pure wake: the signal payload was already durably
/// recorded by the signal router before delivery, and the awaiting NIF
/// resolves it from recorded history. Nothing is retained here.
///
/// # Errors
///
/// Returns [`EngineError::Runtime`] when the workflow is not live or the
/// mailbox marker cannot be queued.
pub fn deliver_signal_received(&self, workflow_pid: Pid) -> Result<(), EngineError> {
self.ensure_live_pid(workflow_pid)?;
self.wait_for_process_ready(workflow_pid)?;
let marker = self.atom_table.intern("aion_signal_received");
self.enqueue_signal_marker_with_retry(workflow_pid, marker)
}
/// Deliver a pending-query wake marker to the workflow mailbox surface.
///
/// The marker is a pure wake: the pending query (id and name) was already
/// queued in the engine NIF state by the query mailbox engine, and the
/// woken suspending await drains it through the query-pump entry check.
/// Nothing is retained here and nothing is recorded.
///
/// # Errors
///
/// Returns [`EngineError::Runtime`] when the workflow is not live or the
/// mailbox marker cannot be queued.
pub(crate) fn deliver_query_request(&self, workflow_pid: Pid) -> Result<(), EngineError> {
self.ensure_live_pid(workflow_pid)?;
self.wait_for_process_ready(workflow_pid)?;
let marker = self.atom_table.intern("aion_query");
self.enqueue_signal_marker_with_retry(workflow_pid, marker)
}
/// Deliver a recorded child-terminal wake marker to the parent workflow
/// mailbox surface.
///
/// The marker is a pure wake: the child's terminal outcome was already
/// durably recorded into the parent's history (as
/// `ChildWorkflowCompleted`/`ChildWorkflowFailed`) by the child-terminal
/// watcher before delivery, and the awaiting NIF resolves it from
/// recorded history. Nothing is retained here.
///
/// # Errors
///
/// Returns [`EngineError::Runtime`] when the workflow is not live or the
/// mailbox marker cannot be queued.
pub(crate) fn deliver_child_terminal(&self, workflow_pid: Pid) -> Result<(), EngineError> {
self.ensure_live_pid(workflow_pid)?;
self.wait_for_process_ready(workflow_pid)?;
let marker = self.atom_table.intern("aion_child_terminal");
self.enqueue_signal_marker_with_retry(workflow_pid, marker)
}
/// Deliver a two-phase activity completion marker to the workflow mailbox.
///
/// The structured `{activity_complete, CorrelationId, Result}` payload is
/// retained in the runtime boundary, and an atom marker wakes any suspended
/// selective receive. The await NIF resolves the retained payload by
/// correlation id after consuming the marker.
///
/// # Errors
///
/// Returns [`EngineError::Runtime`] when the workflow is not live or the
/// marker cannot be queued.
pub(crate) fn deliver_activity_completion_message(
&self,
workflow_pid: Pid,
correlation_id: &str,
result: String,
) -> Result<(), EngineError> {
self.ensure_live_pid(workflow_pid)?;
let activity_id = correlation_to_activity_pid(correlation_id)?;
self.activity_results.insert(
(workflow_pid, activity_id),
Payload::new(ContentType::Json, result.into_bytes()),
);
let marker = self.atom_table.intern("activity_complete");
self.enqueue_activity_marker(workflow_pid, marker, correlation_id)
}
/// Deliver a two-phase activity failure marker to the workflow mailbox.
///
/// # Errors
///
/// Returns [`EngineError::Runtime`] when the workflow is not live or the
/// marker cannot be queued.
pub(crate) fn deliver_activity_failure_message(
&self,
workflow_pid: Pid,
correlation_id: &str,
reason: String,
) -> Result<(), EngineError> {
self.ensure_live_pid(workflow_pid)?;
let activity_id = correlation_to_activity_pid(correlation_id)?;
self.activity_errors
.insert((workflow_pid, activity_id), activity_failure(reason));
let marker = self.atom_table.intern("activity_failed");
self.enqueue_activity_marker(workflow_pid, marker, correlation_id)
}
/// Deliver a successful activity result payload to the workflow mailbox surface.
///
/// # Errors
///
/// Returns [`EngineError::Runtime`] when the workflow is not live or the
/// mailbox marker cannot be queued.
pub fn deliver_activity_result(
&self,
parent_pid: Pid,
activity_pid: Pid,
payload: Payload,
) -> Result<(), EngineError> {
self.ensure_live_pid(parent_pid)?;
self.activity_results
.insert((parent_pid, activity_pid), payload);
let marker = self.atom_table.intern("aion_activity_result");
if self.scheduler.enqueue_atom_message(parent_pid, marker) {
self.confirm_marker_wake(parent_pid);
Ok(())
} else {
Err(runtime_error(format!(
"failed to deliver activity result from {activity_pid} to {parent_pid}"
)))
}
}
/// Wake a suspended workflow process so blocking awaits re-run their
/// two-phase resolution (a fired timer, an expired `with_timeout`
/// deadline, or any other recorded arrival).
///
/// # Errors
///
/// Returns [`EngineError::Runtime`] when the workflow process is not
/// live or the wake marker cannot be queued.
pub(crate) fn wake_workflow(&self, workflow_pid: Pid) -> Result<(), EngineError> {
self.ensure_live_pid(workflow_pid)?;
let marker = self.atom_table.intern("aion_timer_fired");
// Retry covers the transient just-spawned/executing windows where
// beamr's enqueue declines; a recovery-re-armed timer can fire
// before the recovered process slot is fully materialized.
self.enqueue_signal_marker_with_retry(workflow_pid, marker)
}
fn enqueue_activity_marker(
&self,
workflow_pid: Pid,
marker: Atom,
correlation_id: &str,
) -> Result<(), EngineError> {
if self.scheduler.enqueue_atom_message(workflow_pid, marker) {
self.confirm_marker_wake(workflow_pid);
tracing::debug!(
workflow_pid,
correlation_id,
"delivered activity completion marker to workflow mailbox via scheduler queue"
);
Ok(())
} else {
Err(runtime_error(format!(
"failed to deliver activity completion marker {correlation_id} to {workflow_pid}"
)))
}
}
/// Store a typed activity error for a trapped activity EXIT signal.
///
/// # Errors
///
/// Returns [`EngineError::Runtime`] when the workflow process is not live.
pub fn deliver_activity_error(
&self,
parent_pid: Pid,
activity_pid: Pid,
error: ActivityError,
) -> Result<(), EngineError> {
self.ensure_live_pid(parent_pid)?;
self.activity_errors
.insert((parent_pid, activity_pid), error);
Ok(())
}
/// Read a previously delivered activity result payload.
#[must_use]
pub fn activity_result(&self, parent_pid: Pid, activity_pid: Pid) -> Option<Payload> {
self.activity_results
.get(&(parent_pid, activity_pid))
.map(|entry| entry.clone())
}
/// Read a previously delivered activity error associated with a trapped exit.
#[must_use]
pub fn activity_error(&self, parent_pid: Pid, activity_pid: Pid) -> Option<ActivityError> {
self.activity_errors
.get(&(parent_pid, activity_pid))
.map(|entry| entry.clone())
}
pub(crate) fn take_activity_result(
&self,
parent_pid: Pid,
activity_sequence: Pid,
) -> Option<Payload> {
self.activity_results
.remove(&(parent_pid, activity_sequence))
.map(|(_, payload)| payload)
}
pub(crate) fn take_activity_error(
&self,
parent_pid: Pid,
activity_sequence: Pid,
) -> Option<ActivityError> {
self.activity_errors
.remove(&(parent_pid, activity_sequence))
.map(|(_, error)| error)
}
/// Drop every retained activity completion and failure for a workflow pid.
///
/// Called from the workflow process monitor when the process exits: a
/// completion delivered after the workflow stopped awaiting it — a race
/// loser's late settle, or any delivery after exit — is never `take`n by
/// an await and would otherwise be retained forever (D5).
pub(crate) fn drain_activity_completions(&self, workflow_pid: Pid) {
self.activity_results
.retain(|(parent, _), _| *parent != workflow_pid);
self.activity_errors
.retain(|(parent, _), _| *parent != workflow_pid);
}
/// Number of retained two-phase activity completion entries (results
/// plus failures) across every workflow process.
///
/// Diagnostic surface: after a workflow exits, the monitor drain must
/// leave nothing behind for its pid, so an engine with no live awaits
/// should report zero.
#[must_use]
pub fn retained_activity_completions(&self) -> usize {
self.activity_results.len() + self.activity_errors.len()
}
pub(crate) fn activity_complete_atom(&self) -> Atom {
self.atom_table.intern("activity_complete")
}
pub(crate) fn activity_failed_atom(&self) -> Atom {
self.atom_table.intern("activity_failed")
}
pub(crate) fn activity_result_atom(&self) -> Atom {
self.atom_table.intern("aion_activity_result")
}
pub(crate) fn signal_received_atom(&self) -> Atom {
self.atom_table.intern("aion_signal_received")
}
pub(crate) fn timer_fired_atom(&self) -> Atom {
self.atom_table.intern("aion_timer_fired")
}
pub(crate) fn query_marker_atom(&self) -> Atom {
self.atom_table.intern("aion_query")
}
pub(crate) fn child_terminal_atom(&self) -> Atom {
self.atom_table.intern("aion_child_terminal")
}
pub(crate) fn wait_for_process_ready(&self, pid: Pid) -> Result<(), EngineError> {
let deadline = std::time::Instant::now() + self.signal_delivery.ready_timeout;
while std::time::Instant::now() < deadline {
if self.scheduler.trap_exit(pid).is_some() {
return Ok(());
}
sleep_signal_delivery_backoff(self.signal_delivery.initial_backoff);
}
self.scheduler
.trap_exit(pid)
.map(|_| ())
.ok_or_else(|| runtime_error(format!("process {pid} is not ready")))
}
fn enqueue_signal_marker_with_retry(
&self,
workflow_pid: Pid,
marker: Atom,
) -> Result<(), EngineError> {
let attempts = self.signal_delivery.max_enqueue_attempts.max(1);
let mut backoff = self.signal_delivery.initial_backoff;
for attempt in 1..=attempts {
if self.scheduler.enqueue_atom_message(workflow_pid, marker) {
self.confirm_marker_wake(workflow_pid);
return Ok(());
}
if self.scheduler.process_table().get(workflow_pid).is_none() {
return Err(runtime_error(format!(
"failed to deliver signal to workflow process {workflow_pid}: process is not live"
)));
}
if attempt < attempts {
// beamr 0.3.15 normal spawn publishes the PID before a scheduler
// worker materializes the process body from its SpawnRequest. It
// also exposes an Executing slot while the process is running.
// enqueue_atom_message only accepts a Present slot, so an alive
// just-spawned or currently executing process can transiently
// return false even after the liveness/ready gate above.
sleep_signal_delivery_backoff(backoff);
backoff = next_signal_delivery_backoff(backoff, self.signal_delivery.max_backoff);
}
}
Err(runtime_error(format!(
"failed to deliver signal to workflow process {workflow_pid} after {attempts} attempts"
)))
}
/// Arm the consumption-gated wake ladder for a delivered marker.
///
/// `enqueue_atom_message` stores the message and wakes the pid, but
/// beamr 0.4.9's `Wait`-arm gap can swallow that wake (the message is
/// stored after the parked process's mailbox re-check and the wake runs
/// before its wait-set insert), parking the process forever on a
/// one-shot delivery. Follow-up wakes land after the insert and drain
/// the already-stored message; the ladder stops once the target's
/// wake-observation epoch moves — a suspending-native entry or process
/// exit after this delivery — so it survives arbitrarily stretched gaps
/// (OS preemption) without waking healthy processes forever.
fn confirm_marker_wake(&self, workflow_pid: Pid) {
let state = std::sync::Arc::clone(self.nif_state());
let snapshot = state.wake_observation_epoch(workflow_pid);
self.wake_confirmer
.confirm(self.scheduler.wake_notifier(workflow_pid), move || {
state.wake_ladder_done(workflow_pid, snapshot)
});
}
}
fn activity_failure(message: String) -> ActivityError {
ActivityError {
kind: ActivityErrorKind::Terminal,
message,
details: None,
}
}
fn correlation_to_activity_pid(correlation_id: &str) -> Result<Pid, EngineError> {
let Some(raw) = correlation_id.strip_prefix("activity:") else {
return Err(runtime_error(format!(
"invalid activity correlation id {correlation_id}"
)));
};
raw.parse::<Pid>().map_err(|error| {
runtime_error(format!(
"invalid activity correlation sequence {correlation_id}: {error}"
))
})
}
fn next_signal_delivery_backoff(
current: std::time::Duration,
max: std::time::Duration,
) -> std::time::Duration {
let doubled = current.saturating_mul(2);
if doubled > max { max } else { doubled }
}
fn sleep_signal_delivery_backoff(duration: std::time::Duration) {
if duration.is_zero() {
std::thread::yield_now();
} else {
std::thread::sleep(duration);
}
}