aioduct 0.2.0

Async-native HTTP client built directly on hyper 1.x — no hyper-util, no legacy
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
#![cfg(feature = "tokio")]

use super::super::*;
#[cfg(feature = "rustls")]
use super::builder_tests::install_crypto;
use crate::runtime::tokio_rt::{TcpConnector, TokioRuntime};
#[cfg(all(feature = "http3", feature = "rustls", feature = "tokio"))]
#[tokio::test]
async fn builder_http3_enable_then_disable() {
    install_crypto();
    let client = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .tls(crate::tls::RustlsConnector::with_webpki_roots())
        .http3(true)
        .unwrap()
        .http3(false)
        .unwrap()
        .build()
        .unwrap();
    assert!(!client.core.prefer_h3);
}

#[cfg(all(feature = "http3", feature = "rustls", feature = "tokio"))]
#[tokio::test]
async fn builder_alt_svc_h3_enable_creates_endpoint() {
    install_crypto();
    let client = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .tls(crate::tls::RustlsConnector::with_webpki_roots())
        .alt_svc_h3(true)
        .unwrap()
        .build()
        .unwrap();
    assert!(
        !client.core.prefer_h3,
        "alt_svc_h3 alone should not set prefer_h3"
    );
    assert!(
        client.core.h3_endpoint.is_some(),
        "alt_svc_h3(true) should create an h3 endpoint for opportunistic upgrade"
    );
}

#[cfg(all(feature = "http3", feature = "rustls", feature = "tokio"))]
#[tokio::test]
async fn builder_alt_svc_h3_disable_clears_endpoint_without_prefer() {
    install_crypto();
    let client = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .tls(crate::tls::RustlsConnector::with_webpki_roots())
        .alt_svc_h3(true)
        .unwrap()
        .alt_svc_h3(false)
        .unwrap()
        .build()
        .unwrap();
    assert!(
        client.core.h3_endpoint.is_none(),
        "alt_svc_h3(false) without prefer_h3 should remove the endpoint"
    );
}

#[cfg(all(feature = "http3", feature = "rustls", feature = "tokio"))]
#[tokio::test]
async fn builder_http3_enable_sets_prefer_and_endpoint() {
    install_crypto();
    let client = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .tls(crate::tls::RustlsConnector::with_webpki_roots())
        .http3(true)
        .unwrap()
        .build()
        .unwrap();
    assert!(client.core.prefer_h3);
    assert!(client.core.h3_endpoint.is_some());
}

#[cfg(all(feature = "http3", feature = "rustls", feature = "tokio"))]
#[tokio::test]
async fn builder_http3_0rtt_sets_flag() {
    install_crypto();
    let client = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .tls(crate::tls::RustlsConnector::with_webpki_roots())
        .http3(true)
        .unwrap()
        .h3_zero_rtt(true)
        .build()
        .unwrap();
    assert!(client.core.h3_zero_rtt);
}

#[cfg(all(feature = "http3", feature = "rustls", feature = "tokio"))]
#[tokio::test]
async fn builder_alt_svc_h3_disable_keeps_endpoint_when_prefer_h3() {
    install_crypto();
    let client = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .tls(crate::tls::RustlsConnector::with_webpki_roots())
        .http3(true)
        .unwrap()
        .alt_svc_h3(false)
        .unwrap()
        .build()
        .unwrap();
    assert!(
        client.core.prefer_h3,
        "prefer_h3 from http3(true) should persist"
    );
    assert!(
        client.core.h3_endpoint.is_some(),
        "alt_svc_h3(false) should keep endpoint when prefer_h3 is set"
    );
}

#[cfg(all(feature = "http3", feature = "rustls", feature = "tokio"))]
#[tokio::test]
async fn builder_http3_without_tls_returns_error() {
    install_crypto();
    // http3(true) without calling .tls() first should fail
    let result = HttpEngineSend::<TokioRuntime, TcpConnector>::builder().http3(true);
    assert!(result.is_err(), "http3(true) without TLS should return Err");
    let err = result.unwrap_err();
    match err {
        crate::error::Error::Other(msg) => {
            let msg_str = msg.to_string();
            assert!(
                msg_str.contains("TLS"),
                "error message should mention TLS, got: {msg_str}"
            );
        }
        other => panic!("expected Error::Other mentioning TLS, got {other:?}"),
    }
}

#[cfg(all(feature = "http3", feature = "rustls", feature = "tokio"))]
#[tokio::test]
async fn builder_h3_zero_rtt_default_false() {
    install_crypto();
    let client = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .tls(crate::tls::RustlsConnector::with_webpki_roots())
        .http3(true)
        .unwrap()
        .build()
        .unwrap();
    assert!(
        !client.core.h3_zero_rtt,
        "h3_zero_rtt should default to false"
    );
}

// ── process_redirect tests ──────────────────────────────────────────

fn make_redirect_response(status: StatusCode, location: &str) -> crate::response::Response {
    use http_body_util::BodyExt;
    let http_resp = http::Response::builder()
        .status(status)
        .header(http::header::LOCATION, location)
        .body(
            http_body_util::Full::new(bytes::Bytes::new())
                .map_err(|never| match never {})
                .boxed_unsync(),
        )
        .unwrap();
    crate::response::Response::from_boxed(http_resp, "http://origin.com/".parse().unwrap())
}

fn make_test_core() -> HttpEngineCore<crate::body::RequestBodySend> {
    let client = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .build()
        .unwrap();
    client.core
}

#[test]
fn process_redirect_301_changes_method_to_get() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::MOVED_PERMANENTLY, "http://origin.com/new");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let result = core
        .process_redirect(&resp, &uri, Method::POST, None, &mut headers, None)
        .unwrap();
    let (next_uri, next_method, next_body, _frag) = result.unwrap();
    assert_eq!(next_uri.path(), "/new");
    assert_eq!(next_method, Method::GET);
    assert!(next_body.is_none());
}

#[test]
fn process_redirect_302_changes_method_to_get() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::FOUND, "http://origin.com/found");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let result = core
        .process_redirect(&resp, &uri, Method::PUT, None, &mut headers, None)
        .unwrap();
    let (next_uri, next_method, _, _frag) = result.unwrap();
    assert_eq!(next_uri.path(), "/found");
    assert_eq!(next_method, Method::GET);
}

#[test]
fn process_redirect_303_changes_method_to_get() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::SEE_OTHER, "http://origin.com/see");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let result = core
        .process_redirect(&resp, &uri, Method::POST, None, &mut headers, None)
        .unwrap();
    let (_, next_method, _, _frag) = result.unwrap();
    assert_eq!(next_method, Method::GET);
}

#[test]
fn process_redirect_307_preserves_method_and_body() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::TEMPORARY_REDIRECT, "http://origin.com/temp");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();
    let body = crate::body::RequestBody::Buffered(bytes::Bytes::from("hello"));

    let result = core
        .process_redirect(&resp, &uri, Method::POST, Some(body), &mut headers, None)
        .unwrap();
    let (next_uri, next_method, next_body, _frag) = result.unwrap();
    assert_eq!(next_uri.path(), "/temp");
    assert_eq!(next_method, Method::POST);
    assert!(next_body.is_some(), "body should be replayed on 307");
}

#[test]
fn process_redirect_308_preserves_method_and_body() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::PERMANENT_REDIRECT, "http://origin.com/perm");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();
    let body = crate::body::RequestBody::Buffered(bytes::Bytes::from("data"));

    let result = core
        .process_redirect(&resp, &uri, Method::PUT, Some(body), &mut headers, None)
        .unwrap();
    let (_, next_method, next_body, _frag) = result.unwrap();
    assert_eq!(next_method, Method::PUT);
    assert!(next_body.is_some());
}

#[test]
fn process_redirect_307_get_without_body_succeeds() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::TEMPORARY_REDIRECT, "http://origin.com/next");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    // GET without body on 307 should succeed (no body needed)
    let result = core
        .process_redirect(&resp, &uri, Method::GET, None, &mut headers, None)
        .unwrap();
    let (_, next_method, next_body, _frag) = result.unwrap();
    assert_eq!(next_method, Method::GET);
    assert!(next_body.is_none());
}

#[test]
fn process_redirect_307_head_without_body_succeeds() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::TEMPORARY_REDIRECT, "http://origin.com/next");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let result = core
        .process_redirect(&resp, &uri, Method::HEAD, None, &mut headers, None)
        .unwrap();
    let (_, next_method, _, _frag) = result.unwrap();
    assert_eq!(next_method, Method::HEAD);
}

#[test]
fn process_redirect_307_post_without_body_fails() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::TEMPORARY_REDIRECT, "http://origin.com/next");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    // POST without body on 307 - cannot replay streaming body
    let result = core.process_redirect(&resp, &uri, Method::POST, None, &mut headers, None);
    let err = result.unwrap_err();
    match err {
        crate::error::Error::Redirect(msg) => {
            assert!(
                msg.contains("cannot replay"),
                "expected 'cannot replay' error, got: {msg}"
            );
        }
        other => panic!("expected Redirect error, got {other:?}"),
    }
}

#[test]
fn process_redirect_unexpected_status_returns_error() {
    use http_body_util::BodyExt;
    let core = make_test_core();
    // Use a status that is not a redirect (e.g., 299 or 305)
    let http_resp = http::Response::builder()
        .status(StatusCode::from_u16(305).unwrap())
        .header(http::header::LOCATION, "http://origin.com/proxy")
        .body(
            http_body_util::Full::new(bytes::Bytes::new())
                .map_err(|never| match never {})
                .boxed_unsync(),
        )
        .unwrap();
    let resp =
        crate::response::Response::from_boxed(http_resp, "http://origin.com/".parse().unwrap());
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let result = core.process_redirect(&resp, &uri, Method::GET, None, &mut headers, None);
    let err = result.unwrap_err();
    match err {
        crate::error::Error::Redirect(msg) => {
            assert!(
                msg.contains("unexpected redirect status"),
                "expected 'unexpected redirect status', got: {msg}"
            );
        }
        other => panic!("expected Redirect error, got {other:?}"),
    }
}

#[test]
fn process_redirect_cross_origin_strips_sensitive_headers() {
    let core = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .sensitive_header(http::header::HeaderName::from_static("x-api-key"))
        .build()
        .unwrap()
        .core;
    let resp = make_redirect_response(StatusCode::FOUND, "http://other.com/new");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();
    headers.insert(http::header::AUTHORIZATION, "Bearer token".parse().unwrap());
    headers.insert(http::header::COOKIE, "session=abc".parse().unwrap());
    headers.insert(
        http::header::HeaderName::from_static("x-api-key"),
        "secret".parse().unwrap(),
    );

    let result = core
        .process_redirect(&resp, &uri, Method::GET, None, &mut headers, None)
        .unwrap();
    assert!(result.is_some());
    // Sensitive headers should be stripped on cross-origin redirect
    assert!(
        headers.get(http::header::AUTHORIZATION).is_none(),
        "Authorization should be stripped"
    );
    assert!(
        headers.get(http::header::COOKIE).is_none(),
        "Cookie should be stripped"
    );
    assert!(
        headers
            .get(http::header::HeaderName::from_static("x-api-key"))
            .is_none(),
        "custom sensitive header should be stripped"
    );
}

#[test]
fn process_redirect_same_origin_preserves_sensitive_headers() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::FOUND, "http://origin.com/new");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();
    headers.insert(http::header::AUTHORIZATION, "Bearer token".parse().unwrap());

    let result = core
        .process_redirect(&resp, &uri, Method::GET, None, &mut headers, None)
        .unwrap();
    assert!(result.is_some());
    // Same-origin redirect should keep Authorization
    assert!(
        headers.get(http::header::AUTHORIZATION).is_some(),
        "Authorization should be preserved on same-origin redirect"
    );
}

#[test]
fn process_redirect_sets_host_header() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::FOUND, "http://newhost.com/path");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let result = core
        .process_redirect(&resp, &uri, Method::GET, None, &mut headers, None)
        .unwrap();
    let (next_uri, _, _, _frag) = result.unwrap();
    assert_eq!(next_uri.host(), Some("newhost.com"));
    // Host header should be set to new authority
    assert_eq!(headers.get(http::header::HOST).unwrap(), "newhost.com");
}

#[test]
fn process_redirect_with_referer_enabled() {
    let core = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .referer(true)
        .build()
        .unwrap()
        .core;
    let resp = make_redirect_response(StatusCode::FOUND, "http://origin.com/new");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let _ = core
        .process_redirect(&resp, &uri, Method::GET, None, &mut headers, None)
        .unwrap();
    // Referer should be set to the current URI
    let referer = headers
        .get(http::header::REFERER)
        .unwrap()
        .to_str()
        .unwrap();
    assert!(
        referer.contains("origin.com/old"),
        "Referer should contain the previous URI, got: {referer}"
    );
}

#[test]
fn process_redirect_missing_location_returns_error() {
    use http_body_util::BodyExt;
    let core = make_test_core();
    // Response without Location header
    let http_resp = http::Response::builder()
        .status(StatusCode::FOUND)
        .body(
            http_body_util::Full::new(bytes::Bytes::new())
                .map_err(|never| match never {})
                .boxed_unsync(),
        )
        .unwrap();
    let resp =
        crate::response::Response::from_boxed(http_resp, "http://origin.com/".parse().unwrap());
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let result = core.process_redirect(&resp, &uri, Method::GET, None, &mut headers, None);
    let err = result.unwrap_err();
    match err {
        crate::error::Error::Redirect(msg) => {
            assert!(msg.contains("Location"), "got: {msg}");
        }
        other => panic!("expected Redirect error, got {other:?}"),
    }
}

#[test]
fn process_redirect_middleware_notified() {
    use std::sync::Arc;
    use std::sync::atomic::{AtomicBool, Ordering};

    struct TrackingMiddleware {
        called: Arc<AtomicBool>,
    }
    impl crate::middleware::Middleware for TrackingMiddleware {
        fn on_redirect(&self, _status: StatusCode, _from: &Uri, _to: &Uri) {
            self.called.store(true, Ordering::SeqCst);
        }
    }

    let called = Arc::new(AtomicBool::new(false));
    let core = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .middleware(TrackingMiddleware {
            called: called.clone(),
        })
        .build()
        .unwrap()
        .core;

    let resp = make_redirect_response(StatusCode::FOUND, "http://origin.com/new");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let _ = core
        .process_redirect(&resp, &uri, Method::GET, None, &mut headers, None)
        .unwrap();
    assert!(
        called.load(Ordering::SeqCst),
        "middleware on_redirect should be called"
    );
}

// ── prepare_request_headers tests ───────────────────────────────────

#[test]
fn prepare_request_headers_applies_cookies() {
    let jar = crate::cookie::CookieJar::new();
    let mut cookie_headers = http::HeaderMap::new();
    cookie_headers.insert(
        http::header::SET_COOKIE,
        "session=abc123; Path=/".parse().unwrap(),
    );
    jar.store_from_response("example.com", "/", &cookie_headers);

    let core = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .cookie_jar(jar)
        .build()
        .unwrap()
        .core;

    let uri: Uri = "http://example.com/page".parse().unwrap();
    let mut headers = HeaderMap::new();
    core.prepare_request_headers(&uri, None, &mut headers);

    let cookie_header = headers.get(http::header::COOKIE).unwrap().to_str().unwrap();
    assert!(
        cookie_header.contains("session=abc123"),
        "expected cookie in header, got: {cookie_header}"
    );
}

#[test]
fn prepare_request_headers_sets_host_when_missing() {
    let core = make_test_core();
    let uri: Uri = "http://example.com:8080/path".parse().unwrap();
    let mut headers = HeaderMap::new();

    core.prepare_request_headers(&uri, None, &mut headers);

    assert_eq!(headers.get(http::header::HOST).unwrap(), "example.com:8080");
}

#[test]
fn prepare_request_headers_does_not_overwrite_existing_host() {
    let core = make_test_core();
    let uri: Uri = "http://example.com/path".parse().unwrap();
    let mut headers = HeaderMap::new();
    headers.insert(http::header::HOST, "custom-host.com".parse().unwrap());

    core.prepare_request_headers(&uri, None, &mut headers);

    assert_eq!(headers.get(http::header::HOST).unwrap(), "custom-host.com");
}

#[test]
fn prepare_request_headers_no_cookie_jar_is_noop() {
    let core = make_test_core();
    let uri: Uri = "http://example.com/path".parse().unwrap();
    let mut headers = HeaderMap::new();
    headers.insert(http::header::HOST, "already-set".parse().unwrap());

    core.prepare_request_headers(&uri, None, &mut headers);

    assert!(headers.get(http::header::COOKIE).is_none());
    assert_eq!(headers.get(http::header::HOST).unwrap(), "already-set");
}

// ── post_execute tests ──────────────────────────────────────────────

#[test]
fn post_execute_done_on_non_redirect() {
    use http_body_util::BodyExt;
    let core = make_test_core();
    let http_resp = http::Response::builder()
        .status(StatusCode::OK)
        .body(
            http_body_util::Full::new(bytes::Bytes::new())
                .map_err(|never| match never {})
                .boxed_unsync(),
        )
        .unwrap();
    let resp =
        crate::response::Response::from_boxed(http_resp, "http://example.com/".parse().unwrap());
    let uri: Uri = "http://example.com/page".parse().unwrap();
    let mut headers = HeaderMap::new();

    let action = core
        .post_execute(&resp, &Method::GET, &uri, &mut headers, None, None)
        .unwrap();
    assert!(matches!(
        action,
        super::request_flow::PostExecuteAction::Done
    ));
}

#[test]
fn post_execute_done_on_not_modified() {
    use http_body_util::BodyExt;
    let http_resp = http::Response::builder()
        .status(StatusCode::NOT_MODIFIED)
        .body(
            http_body_util::Full::new(bytes::Bytes::new())
                .map_err(|never| match never {})
                .boxed_unsync(),
        )
        .unwrap();
    let resp =
        crate::response::Response::from_boxed(http_resp, "http://example.com/".parse().unwrap());
    let core = make_test_core();
    let uri: Uri = "http://example.com/page".parse().unwrap();
    let mut headers = HeaderMap::new();

    let action = core
        .post_execute(&resp, &Method::GET, &uri, &mut headers, None, None)
        .unwrap();
    assert!(matches!(
        action,
        super::request_flow::PostExecuteAction::Done
    ));
}

#[test]
fn post_execute_redirect_on_302() {
    let core = make_test_core();
    let resp = make_redirect_response(StatusCode::FOUND, "http://example.com/new");
    let uri: Uri = "http://example.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let action = core
        .post_execute(&resp, &Method::GET, &uri, &mut headers, None, None)
        .unwrap();
    match action {
        super::request_flow::PostExecuteAction::Redirect {
            uri,
            method,
            body,
            fragment: _,
        } => {
            assert_eq!(uri.path(), "/new");
            assert_eq!(method, Method::GET);
            assert!(body.is_none());
        }
        super::request_flow::PostExecuteAction::Done => {
            panic!("expected Redirect action");
        }
    }
}

#[test]
fn post_execute_stores_cookies_and_learns_hsts() {
    let jar = crate::cookie::CookieJar::new();
    let store = crate::hsts::HstsStore::new();

    let core = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .cookie_jar(jar.clone())
        .hsts(store.clone())
        .build()
        .unwrap()
        .core;

    use http_body_util::BodyExt;
    let http_resp = http::Response::builder()
        .status(StatusCode::OK)
        .header(http::header::SET_COOKIE, "token=xyz; Path=/")
        .header("strict-transport-security", "max-age=31536000")
        .body(
            http_body_util::Full::new(bytes::Bytes::new())
                .map_err(|never| match never {})
                .boxed_unsync(),
        )
        .unwrap();
    let resp = crate::response::Response::from_boxed(
        http_resp,
        "https://secure.example.com/api".parse().unwrap(),
    );

    let uri: Uri = "https://secure.example.com/api".parse().unwrap();
    let mut headers = HeaderMap::new();

    let action = core
        .post_execute(&resp, &Method::GET, &uri, &mut headers, None, None)
        .unwrap();
    assert!(matches!(
        action,
        super::request_flow::PostExecuteAction::Done
    ));

    assert!(
        store.should_upgrade("secure.example.com"),
        "HSTS should be learned from response"
    );

    let mut cookie_headers = HeaderMap::new();
    jar.apply_to_request("secure.example.com", true, "/", None, &mut cookie_headers);
    let cookie_val = cookie_headers
        .get(http::header::COOKIE)
        .unwrap()
        .to_str()
        .unwrap();
    assert!(
        cookie_val.contains("token=xyz"),
        "cookie should be stored from response, got: {cookie_val}"
    );
}

#[test]
fn post_execute_invalidates_cache_on_non_safe_method() {
    let cache = crate::cache::HttpCache::new();

    let status = StatusCode::OK;
    let mut resp_headers = http::HeaderMap::new();
    resp_headers.insert(http::header::CACHE_CONTROL, "max-age=3600".parse().unwrap());
    cache.store(
        &Method::GET,
        &"http://example.com/data".parse().unwrap(),
        status,
        &resp_headers,
        &bytes::Bytes::from("cached"),
        &HeaderMap::new(),
    );

    let core = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .cache(cache.clone())
        .build()
        .unwrap()
        .core;

    use http_body_util::BodyExt;
    let http_resp = http::Response::builder()
        .status(StatusCode::OK)
        .body(
            http_body_util::Full::new(bytes::Bytes::new())
                .map_err(|never| match never {})
                .boxed_unsync(),
        )
        .unwrap();
    let resp = crate::response::Response::from_boxed(
        http_resp,
        "http://example.com/data".parse().unwrap(),
    );
    let uri: Uri = "http://example.com/data".parse().unwrap();
    let mut headers = HeaderMap::new();

    let _ = core
        .post_execute(&resp, &Method::POST, &uri, &mut headers, None, None)
        .unwrap();

    let lookup_headers = HeaderMap::new();
    let result = cache.lookup(&Method::GET, &uri, &lookup_headers);
    assert!(
        matches!(result, crate::cache::CacheLookup::Miss),
        "cache should be invalidated after POST"
    );
}

#[test]
fn post_execute_redirect_applies_hsts_upgrade() {
    let store = crate::hsts::HstsStore::new();
    let mut sts_headers = http::HeaderMap::new();
    sts_headers.insert(
        http::header::HeaderName::from_static("strict-transport-security"),
        "max-age=31536000".parse().unwrap(),
    );
    store.store_from_response("target.example.com", &sts_headers);

    let core = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .hsts(store)
        .build()
        .unwrap()
        .core;

    let resp = make_redirect_response(StatusCode::FOUND, "http://target.example.com/redirected");
    let uri: Uri = "http://origin.example.com/start".parse().unwrap();
    let mut headers = HeaderMap::new();

    let action = core
        .post_execute(&resp, &Method::GET, &uri, &mut headers, None, None)
        .unwrap();
    match action {
        super::request_flow::PostExecuteAction::Redirect { uri, .. } => {
            assert_eq!(
                uri.scheme_str(),
                Some("https"),
                "redirect target should be HSTS-upgraded to https"
            );
            assert_eq!(uri.host(), Some("target.example.com"));
        }
        _ => panic!("expected Redirect action"),
    }
}

#[test]
fn post_execute_redirect_https_only_rejects_http_target() {
    let core = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .https_only(true)
        .build()
        .unwrap()
        .core;

    let resp = make_redirect_response(StatusCode::FOUND, "http://insecure.com/page");
    let uri: Uri = "https://origin.com/start".parse().unwrap();
    let mut headers = HeaderMap::new();

    let result = core.post_execute(&resp, &Method::GET, &uri, &mut headers, None, None);
    let err = result.unwrap_err();
    assert!(
        matches!(err, crate::error::Error::HttpsOnly(_)),
        "expected HttpsOnly error, got: {err:?}"
    );
}

#[test]
fn post_execute_done_when_redirect_policy_none() {
    let core = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .redirect_policy(crate::redirect::RedirectPolicy::None)
        .build()
        .unwrap()
        .core;

    let resp = make_redirect_response(StatusCode::FOUND, "http://origin.com/new");
    let uri: Uri = "http://origin.com/old".parse().unwrap();
    let mut headers = HeaderMap::new();

    let action = core
        .post_execute(&resp, &Method::GET, &uri, &mut headers, None, None)
        .unwrap();
    assert!(
        matches!(action, super::request_flow::PostExecuteAction::Done),
        "should return Done when redirect policy is None"
    );
}

#[cfg(feature = "rustls")]
#[tokio::test]
async fn hsts_include_subdomains_end_to_end() {
    use bytes::Bytes;
    use http_body_util::Full;
    use std::convert::Infallible;
    use std::sync::Arc;
    use std::sync::atomic::{AtomicBool, Ordering};

    install_crypto();

    let sub_requested = Arc::new(AtomicBool::new(false));
    let sub_requested_clone = sub_requested.clone();

    let (addr, cert_der, _counter) =
        aioduct_test_server::tls::tls_server_with(&[b"http/1.1"], move |req| {
            let sub = sub_requested_clone.clone();
            async move {
                let host = req
                    .headers()
                    .get("host")
                    .and_then(|v| v.to_str().ok())
                    .unwrap_or("");
                if host.starts_with("sub.") {
                    sub.store(true, Ordering::SeqCst);
                }
                let response = http::Response::builder()
                    .status(200)
                    .header(
                        "strict-transport-security",
                        "max-age=3600; includeSubDomains",
                    )
                    .body(Full::new(Bytes::from("ok")))
                    .unwrap();
                Ok::<_, Infallible>(response)
            }
        })
        .await;

    let cert = crate::tls::Certificate::from_der(cert_der.to_vec());
    let store = crate::hsts::HstsStore::new();

    // Use localhost hostname to match the TLS cert from generate_self_signed
    let client = HttpEngineSend::<TokioRuntime, TcpConnector>::builder()
        .hsts(store.clone())
        .add_root_certificates(&[cert])
        .danger_accept_invalid_hostnames(true)
        .timeout(std::time::Duration::from_secs(5))
        .resolver({
            move |_host: &str, _port: u16| {
                Box::pin(async move { Ok(addr) })
                    as std::pin::Pin<
                        Box<
                            dyn std::future::Future<Output = std::io::Result<std::net::SocketAddr>>
                                + Send,
                        >,
                    >
            }
        })
        .build()
        .unwrap();

    // First request: HTTPS — server returns HSTS header with includeSubDomains
    let resp = client
        .get(&format!("https://localhost:{}/", addr.port()))
        .unwrap()
        .send()
        .await
        .unwrap();
    assert_eq!(resp.status(), 200);
    assert_eq!(resp.text().await.unwrap(), "ok");
    assert!(
        store.should_upgrade("localhost"),
        "HSTS should be stored for localhost"
    );
    assert!(
        store.should_upgrade("sub.localhost"),
        "includeSubDomains should cover sub.localhost"
    );

    // Second request: http://sub.localhost should be upgraded to https://
    let resp = client
        .get(&format!("http://sub.localhost:{}/", addr.port()))
        .unwrap()
        .send()
        .await
        .unwrap();
    assert_eq!(resp.status(), 200);
    assert_eq!(resp.text().await.unwrap(), "ok");
    assert!(
        sub_requested.load(Ordering::SeqCst),
        "sub.localhost should have been requested (via HTTPS upgrade)"
    );
}