aingle_raft 0.7.1

Raft consensus for AIngle clustering
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
// Copyright 2019-2026 Apilium Technologies OÜ. All rights reserved.
// SPDX-License-Identifier: Apache-2.0 OR Commercial

//! Raft log storage backed by WAL segments.
//!
//! Implements `RaftLogReader` and `RaftLogStorage` from openraft,
//! persisting entries as `WalEntryKind::RaftEntry` variants and
//! vote/committed state as JSON files alongside the WAL directory.

use crate::types::CortexTypeConfig;
use aingle_wal::{WalEntryKind, WalWriter};
use openraft::alias::{EntryOf, LogIdOf, VoteOf};
use openraft::storage::{IOFlushed, LogState, RaftLogStorage};
use openraft::RaftLogReader;
use std::collections::BTreeMap;
use std::fmt::Debug;
use std::io::{self, Write};
use std::ops::RangeBounds;
use std::path::{Path, PathBuf};
use std::sync::Arc;
use tokio::sync::RwLock;

type C = CortexTypeConfig;
type Vote = VoteOf<C>;
type LogId = LogIdOf<C>;
type Entry = EntryOf<C>;

/// Durable Raft log store backed by the AIngle WAL.
///
/// In-memory BTreeMap serves reads; WAL provides persistence.
/// Vote and committed state are persisted as JSON files.
pub struct CortexLogStore {
    vote: RwLock<Option<Vote>>,
    committed: RwLock<Option<LogId>>,
    log: RwLock<BTreeMap<u64, Entry>>,
    purged_log_id: RwLock<Option<LogId>>,
    /// Truncation boundary — entries with index > this are invalid.
    truncated_after: RwLock<Option<LogId>>,
    /// WAL writer for durable persistence.
    wal: Arc<WalWriter>,
    /// Directory for vote/committed JSON files.
    wal_dir: PathBuf,
}

impl CortexLogStore {
    /// Open or create a log store backed by the WAL at `wal_dir`.
    ///
    /// On recovery, reads WAL segments, filters `RaftEntry` variants,
    /// rebuilds the in-memory BTreeMap, then applies persisted
    /// truncation/purge boundaries to discard stale entries.
    pub fn open(wal_dir: &Path) -> io::Result<Self> {
        let wal = Arc::new(WalWriter::open(wal_dir)?);

        // Recover vote from disk
        let vote = Self::load_vote(wal_dir)?;

        // Recover committed from disk
        let committed = Self::load_committed(wal_dir)?;

        // Recover purged boundary from disk
        let purged_log_id = Self::load_purged(wal_dir)?;

        // Recover truncation boundary from disk
        let truncated_after = Self::load_truncated_after(wal_dir)?;

        // Rebuild log from WAL
        let reader = aingle_wal::WalReader::open(wal_dir)?;
        let wal_entries = reader.read_from(0)?;
        let mut log = BTreeMap::new();

        for wal_entry in &wal_entries {
            if let WalEntryKind::RaftEntry {
                index,
                term: _,
                data,
            } = &wal_entry.kind
            {
                match serde_json::from_slice::<Entry>(data) {
                    Ok(entry) => {
                        log.insert(*index, entry);
                    }
                    Err(e) => {
                        tracing::warn!(
                            index = index,
                            "Failed to deserialize RaftEntry from WAL: {}",
                            e
                        );
                    }
                }
            }
        }

        // Apply persisted boundaries: remove entries outside the valid range
        if let Some(ref purged) = purged_log_id {
            log.retain(|idx, _| *idx > purged.index);
        }
        if let Some(ref trunc) = truncated_after {
            log.retain(|idx, _| *idx <= trunc.index);
        }

        tracing::info!(
            entries = log.len(),
            vote = ?vote,
            committed = ?committed,
            purged = ?purged_log_id,
            truncated_after = ?truncated_after,
            "CortexLogStore recovered from WAL"
        );

        Ok(Self {
            vote: RwLock::new(vote),
            committed: RwLock::new(committed),
            log: RwLock::new(log),
            purged_log_id: RwLock::new(purged_log_id),
            truncated_after: RwLock::new(truncated_after),
            wal,
            wal_dir: wal_dir.to_path_buf(),
        })
    }

    /// Get the WAL writer reference.
    pub fn wal(&self) -> &Arc<WalWriter> {
        &self.wal
    }

    // --- Atomic file write ---

    /// Atomically write data to a file: write to .tmp, fsync, rename.
    fn atomic_write(target: &Path, data: &[u8]) -> io::Result<()> {
        let tmp = target.with_extension("tmp");
        {
            let mut f = std::fs::File::create(&tmp)?;
            f.write_all(data)?;
            f.sync_all()?;
        }
        std::fs::rename(&tmp, target)?;
        // fsync the parent directory to ensure the rename is durable
        if let Some(parent) = target.parent() {
            if let Ok(dir) = std::fs::File::open(parent) {
                let _ = dir.sync_all();
            }
        }
        Ok(())
    }

    // --- Persistence helpers ---

    fn vote_path(dir: &Path) -> PathBuf {
        dir.join("raft_vote.json")
    }

    fn committed_path(dir: &Path) -> PathBuf {
        dir.join("raft_committed.json")
    }

    fn purged_path(dir: &Path) -> PathBuf {
        dir.join("raft_purged.json")
    }

    fn truncated_after_path(dir: &Path) -> PathBuf {
        dir.join("raft_truncated_after.json")
    }

    fn persist_vote(dir: &Path, vote: &Vote) -> io::Result<()> {
        let data = serde_json::to_vec_pretty(vote)
            .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
        Self::atomic_write(&Self::vote_path(dir), &data)
    }

    fn load_vote(dir: &Path) -> io::Result<Option<Vote>> {
        let path = Self::vote_path(dir);
        if !path.exists() {
            return Ok(None);
        }
        let data = std::fs::read(&path)?;
        let vote: Vote = serde_json::from_slice(&data)
            .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
        Ok(Some(vote))
    }

    fn persist_committed(dir: &Path, committed: &Option<LogId>) -> io::Result<()> {
        let data = serde_json::to_vec_pretty(committed)
            .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
        Self::atomic_write(&Self::committed_path(dir), &data)
    }

    fn load_committed(dir: &Path) -> io::Result<Option<LogId>> {
        let path = Self::committed_path(dir);
        if !path.exists() {
            return Ok(None);
        }
        let data = std::fs::read(&path)?;
        let committed: Option<LogId> = serde_json::from_slice(&data)
            .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
        Ok(committed)
    }

    fn persist_purged(dir: &Path, purged: &LogId) -> io::Result<()> {
        let data = serde_json::to_vec_pretty(purged)
            .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
        Self::atomic_write(&Self::purged_path(dir), &data)
    }

    fn load_purged(dir: &Path) -> io::Result<Option<LogId>> {
        let path = Self::purged_path(dir);
        if !path.exists() {
            return Ok(None);
        }
        let data = std::fs::read(&path)?;
        let purged: LogId = serde_json::from_slice(&data)
            .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
        Ok(Some(purged))
    }

    fn persist_truncated_after(dir: &Path, lid: &Option<LogId>) -> io::Result<()> {
        let data = serde_json::to_vec_pretty(lid)
            .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
        Self::atomic_write(&Self::truncated_after_path(dir), &data)
    }

    fn load_truncated_after(dir: &Path) -> io::Result<Option<LogId>> {
        let path = Self::truncated_after_path(dir);
        if !path.exists() {
            return Ok(None);
        }
        let data = std::fs::read(&path)?;
        let lid: Option<LogId> = serde_json::from_slice(&data)
            .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
        Ok(lid)
    }

    // --- Internal append (for IOFlushed callback pattern) ---

    async fn append_inner<I>(&self, entries: I) -> Result<(), io::Error>
    where
        I: IntoIterator<Item = Entry> + Send,
        I::IntoIter: Send,
    {
        // Collect all entries and serialize them first, then write ALL to
        // WAL before touching the BTreeMap. This prevents a partial batch
        // leaving the in-memory map inconsistent with WAL on failure (#11).
        let batch: Vec<(u64, u64, Vec<u8>, Entry)> = entries
            .into_iter()
            .map(|entry| {
                let index = entry.log_id.index;
                let term = entry.log_id.leader_id.term;
                let data = serde_json::to_vec(&entry)
                    .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;
                Ok((index, term, data, entry))
            })
            .collect::<Result<Vec<_>, io::Error>>()?;

        // Write ALL to WAL first
        for (index, term, ref data, _) in &batch {
            self.wal
                .append(WalEntryKind::RaftEntry {
                    index: *index,
                    term: *term,
                    data: data.clone(),
                })
                .map_err(|e| io::Error::new(io::ErrorKind::Other, e))?;
        }

        // Only update BTreeMap after all WAL writes succeed
        let mut log = self.log.write().await;
        for (index, _, _, entry) in batch {
            log.insert(index, entry);
        }

        Ok(())
    }

    // --- Legacy convenience methods ---

    pub async fn log_length(&self) -> u64 {
        let log = self.log.read().await;
        log.len() as u64
    }

    pub async fn last_log_id(&self) -> Option<LogId> {
        let log = self.log.read().await;
        log.values().last().map(|e| e.log_id.clone())
    }
}

// ============================================================================
// RaftLogReader implementation
// ============================================================================

impl RaftLogReader<C> for Arc<CortexLogStore> {
    async fn try_get_log_entries<RB: RangeBounds<u64> + Clone + Debug + Send>(
        &mut self,
        range: RB,
    ) -> Result<Vec<Entry>, io::Error> {
        let log = self.log.read().await;
        let entries: Vec<Entry> = log.range(range).map(|(_, e)| e.clone()).collect();
        Ok(entries)
    }

    async fn read_vote(&mut self) -> Result<Option<Vote>, io::Error> {
        let v = self.vote.read().await;
        Ok(v.clone())
    }
}

// ============================================================================
// RaftLogStorage implementation
// ============================================================================

impl RaftLogStorage<C> for Arc<CortexLogStore> {
    type LogReader = Arc<CortexLogStore>;

    async fn get_log_state(&mut self) -> Result<LogState<C>, io::Error> {
        // Hold both locks simultaneously to avoid TOCTOU race
        let log = self.log.read().await;
        let purged = self.purged_log_id.read().await;

        let last_log_id = log
            .values()
            .last()
            .map(|e| e.log_id.clone())
            .or_else(|| purged.clone());

        Ok(LogState {
            last_purged_log_id: purged.clone(),
            last_log_id,
        })
    }

    async fn get_log_reader(&mut self) -> Self::LogReader {
        Arc::clone(self)
    }

    async fn save_vote(&mut self, vote: &Vote) -> Result<(), io::Error> {
        CortexLogStore::persist_vote(&self.wal_dir, vote)?;
        let mut v = self.vote.write().await;
        *v = Some(vote.clone());
        Ok(())
    }

    async fn save_committed(&mut self, committed: Option<LogId>) -> Result<(), io::Error> {
        CortexLogStore::persist_committed(&self.wal_dir, &committed)?;
        let mut c = self.committed.write().await;
        *c = committed;
        Ok(())
    }

    async fn read_committed(&mut self) -> Result<Option<LogId>, io::Error> {
        let c = self.committed.read().await;
        Ok(c.clone())
    }

    async fn append<I>(&mut self, entries: I, callback: IOFlushed<C>) -> Result<(), io::Error>
    where
        I: IntoIterator<Item = Entry> + Send,
        I::IntoIter: Send,
    {
        // Always invoke the callback, even on error, to prevent openraft hangs.
        let result = self.append_inner(entries).await;
        callback.io_completed(
            result
                .as_ref()
                .map(|_| ())
                .map_err(|e| io::Error::new(e.kind(), e.to_string())),
        );
        result
    }

    async fn truncate_after(&mut self, last_log_id: Option<LogId>) -> Result<(), io::Error> {
        let mut log = self.log.write().await;

        match last_log_id {
            Some(ref lid) => {
                let keys_to_remove: Vec<u64> =
                    log.range((lid.index + 1)..).map(|(k, _)| *k).collect();
                for k in keys_to_remove {
                    log.remove(&k);
                }
            }
            None => {
                log.clear();
            }
        }

        // Persist truncation boundary so recovery filters out stale entries
        let mut trunc = self.truncated_after.write().await;
        *trunc = last_log_id.clone();
        CortexLogStore::persist_truncated_after(&self.wal_dir, &last_log_id)?;

        Ok(())
    }

    async fn purge(&mut self, log_id: LogId) -> Result<(), io::Error> {
        let mut log = self.log.write().await;

        let keys_to_remove: Vec<u64> = log.range(..=log_id.index).map(|(k, _)| *k).collect();
        for k in keys_to_remove {
            log.remove(&k);
        }

        // Persist purge boundary
        let mut purged = self.purged_log_id.write().await;
        *purged = Some(log_id.clone());
        CortexLogStore::persist_purged(&self.wal_dir, &log_id)?;

        // Clean up old WAL segments that are entirely below the purge point
        let _ = self.wal.truncate_before(log_id.index);

        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use openraft::entry::RaftEntry;
    use openraft::vote::leader_id_adv::CommittedLeaderId;
    use openraft::vote::RaftLeaderId;

    fn make_entry(index: u64, term: u64) -> Entry {
        Entry::new_blank(openraft::LogId::new(CommittedLeaderId::new(term, 0), index))
    }

    #[tokio::test]
    async fn test_log_store_open_empty() {
        let dir = tempfile::tempdir().unwrap();
        let store = CortexLogStore::open(dir.path()).unwrap();
        let store = Arc::new(store);

        let mut reader = store.clone();
        assert!(reader.read_vote().await.unwrap().is_none());
        assert_eq!(store.log_length().await, 0);
    }

    #[tokio::test]
    async fn test_append_and_read() {
        let dir = tempfile::tempdir().unwrap();
        let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
        let mut store_mut = store.clone();

        let entries = vec![make_entry(1, 1), make_entry(2, 1), make_entry(3, 1)];

        store_mut.append(entries, IOFlushed::noop()).await.unwrap();

        let mut reader = store.clone();
        let result = reader.try_get_log_entries(1..4).await.unwrap();
        assert_eq!(result.len(), 3);
        assert_eq!(result[0].log_id.index, 1);
        assert_eq!(result[2].log_id.index, 3);
    }

    #[tokio::test]
    async fn test_vote_persistence() {
        let dir = tempfile::tempdir().unwrap();

        // Write vote
        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut store_mut = store.clone();
            let vote = openraft::Vote::new(1, 0);
            store_mut.save_vote(&vote).await.unwrap();
        }

        // Reopen and verify
        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut reader = store.clone();
            let vote = reader.read_vote().await.unwrap();
            assert!(vote.is_some());
            assert_eq!(vote.unwrap().leader_id().term, 1);
        }
    }

    #[tokio::test]
    async fn test_truncate_after() {
        let dir = tempfile::tempdir().unwrap();
        let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
        let mut store_mut = store.clone();

        let entries = vec![
            make_entry(1, 1),
            make_entry(2, 1),
            make_entry(3, 1),
            make_entry(4, 1),
        ];
        store_mut.append(entries, IOFlushed::noop()).await.unwrap();

        // Truncate after index 2
        let lid = openraft::LogId::new(CommittedLeaderId::new(1, 0), 2);
        store_mut.truncate_after(Some(lid)).await.unwrap();

        let mut reader = store.clone();
        let result = reader.try_get_log_entries(1..5).await.unwrap();
        assert_eq!(result.len(), 2);
    }

    #[tokio::test]
    async fn test_truncate_survives_restart() {
        let dir = tempfile::tempdir().unwrap();

        // Write entries and truncate
        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut store_mut = store.clone();

            let entries = vec![
                make_entry(1, 1),
                make_entry(2, 1),
                make_entry(3, 1),
                make_entry(4, 1),
            ];
            store_mut.append(entries, IOFlushed::noop()).await.unwrap();

            let lid = openraft::LogId::new(CommittedLeaderId::new(1, 0), 2);
            store_mut.truncate_after(Some(lid)).await.unwrap();
        }

        // Reopen — truncated entries must NOT reappear
        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut reader = store.clone();
            let result = reader.try_get_log_entries(1..5).await.unwrap();
            assert_eq!(
                result.len(),
                2,
                "truncated entries must not survive restart"
            );
        }
    }

    #[tokio::test]
    async fn test_purge() {
        let dir = tempfile::tempdir().unwrap();
        let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
        let mut store_mut = store.clone();

        let entries = vec![make_entry(1, 1), make_entry(2, 1), make_entry(3, 1)];
        store_mut.append(entries, IOFlushed::noop()).await.unwrap();

        let purge_id = openraft::LogId::new(CommittedLeaderId::new(1, 0), 2);
        store_mut.purge(purge_id).await.unwrap();

        let mut reader = store.clone();
        let result = reader.try_get_log_entries(1..4).await.unwrap();
        assert_eq!(result.len(), 1);
        assert_eq!(result[0].log_id.index, 3);
    }

    #[tokio::test]
    async fn test_purge_survives_restart() {
        let dir = tempfile::tempdir().unwrap();

        // Write entries and purge
        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut store_mut = store.clone();

            let entries = vec![make_entry(1, 1), make_entry(2, 1), make_entry(3, 1)];
            store_mut.append(entries, IOFlushed::noop()).await.unwrap();

            let purge_id = openraft::LogId::new(CommittedLeaderId::new(1, 0), 2);
            store_mut.purge(purge_id).await.unwrap();
        }

        // Reopen — purged entries must NOT reappear
        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut reader = store.clone();
            let result = reader.try_get_log_entries(1..4).await.unwrap();
            assert_eq!(result.len(), 1, "purged entries must not survive restart");
            assert_eq!(result[0].log_id.index, 3);

            // purged_log_id should also be restored
            let mut store_mut = store.clone();
            let state = store_mut.get_log_state().await.unwrap();
            assert!(state.last_purged_log_id.is_some());
            assert_eq!(state.last_purged_log_id.unwrap().index, 2);
        }
    }

    #[tokio::test]
    async fn test_reopen_recovery() {
        let dir = tempfile::tempdir().unwrap();

        // Write entries
        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut store_mut = store.clone();

            let entries = vec![make_entry(1, 1), make_entry(2, 1)];
            store_mut.append(entries, IOFlushed::noop()).await.unwrap();
        }

        // Reopen and verify entries are recovered
        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut reader = store.clone();
            let result = reader.try_get_log_entries(1..3).await.unwrap();
            assert_eq!(result.len(), 2);
            assert_eq!(result[0].log_id.index, 1);
        }
    }

    #[tokio::test]
    async fn test_committed_persistence() {
        let dir = tempfile::tempdir().unwrap();

        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut store_mut = store.clone();
            let lid = openraft::LogId::new(CommittedLeaderId::new(1, 0), 5);
            store_mut.save_committed(Some(lid)).await.unwrap();
        }

        {
            let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
            let mut store_mut = store.clone();
            let committed = store_mut.read_committed().await.unwrap();
            assert!(committed.is_some());
            assert_eq!(committed.unwrap().index, 5);
        }
    }

    #[tokio::test]
    async fn test_get_log_state() {
        let dir = tempfile::tempdir().unwrap();
        let store = Arc::new(CortexLogStore::open(dir.path()).unwrap());
        let mut store_mut = store.clone();

        let entries = vec![make_entry(1, 1), make_entry(2, 1)];
        store_mut.append(entries, IOFlushed::noop()).await.unwrap();

        let state = store_mut.get_log_state().await.unwrap();
        assert!(state.last_purged_log_id.is_none());
        assert_eq!(state.last_log_id.unwrap().index, 2);
    }

    #[tokio::test]
    async fn test_atomic_write_persists() {
        let dir = tempfile::tempdir().unwrap();
        let target = dir.path().join("test_atomic.json");
        CortexLogStore::atomic_write(&target, b"hello world").unwrap();
        let data = std::fs::read(&target).unwrap();
        assert_eq!(data, b"hello world");
        // tmp file should not exist
        assert!(!target.with_extension("tmp").exists());
    }
}