aicx-retrieve 0.9.2

Retrieval trait surface, Tantivy adapter, and manifest contract for aicx hybrid indexes.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
// Vibecrafted with AI Agents by VetCoders (c)2024-2026 LibraxisAI
use std::borrow::Cow;
use std::fs;
use std::hash::{Hash, Hasher};
use std::path::{Path, PathBuf};

use anyhow::{Context, Result, anyhow};
use tantivy::collector::{FilterCollector, TopDocs};
use tantivy::query::{AllQuery, Query, QueryParser};
use tantivy::schema::{
    FAST, Field, INDEXED, IndexRecordOption, STORED, STRING, Schema, TantivyDocument,
    TextFieldIndexing, TextOptions, Value,
};
use tantivy::tokenizer::{
    LowerCaser, RemoveLongFilter, SimpleTokenizer, TextAnalyzer, Token, TokenFilter, TokenStream,
    Tokenizer,
};
use tantivy::{DocAddress, Index, IndexWriter, Score, Searcher, doc};
use tantivy_stemmers::algorithms;

use crate::{ChunkRef, FilterSet, Hit, LexicalCommitId, LexicalIndex, LexicalQuery};

pub const TANTIVY_KIND: &str = "tantivy_lexical";
pub const TANTIVY_SCHEMA_VERSION: &str = "tantivy_lexical_v1";
pub const TANTIVY_INDEX_DIR: &str = "tantivy_lex";

const BODY_TOKENIZER: &str = "aicx_body_pl_en";
const WRITER_HEAP_BYTES: usize = 50_000_000;

/// Tantivy-backed BM25 implementation of [`LexicalIndex`].
pub struct TantivyAdapter {
    pub index: Index,
    pub schema: Schema,
    pub writer: Option<IndexWriter>,
    pub commit_id: LexicalCommitId,
    pub doc_count: usize,
    pub dir: PathBuf,
    fields: TantivyFields,
}

#[derive(Clone)]
struct TantivyFields {
    id: Field,
    source_path: Field,
    body: Field,
    agent: Field,
    date: Field,
    project: Field,
    metadata_json: Field,
    agent_filter: Field,
    date_filter: Field,
    project_filter: Field,
}

impl TantivyAdapter {
    pub fn new(base_dir: PathBuf) -> Result<Self> {
        let dir = base_dir.join(TANTIVY_INDEX_DIR);
        fs::create_dir_all(&dir)
            .with_context(|| format!("create tantivy dir {}", dir.display()))?;

        let (schema, _) = build_schema();
        let index = if dir.join("meta.json").exists() {
            Index::open_in_dir(&dir)
                .with_context(|| format!("open tantivy index {}", dir.display()))?
        } else {
            Index::create_in_dir(&dir, schema.clone())
                .with_context(|| format!("create tantivy index {}", dir.display()))?
        };
        register_tokenizers(&index);

        let schema = index.schema();
        let fields = TantivyFields::from_schema(&schema)?;
        let commit_id = read_commit_id(&index)?;
        let doc_count = read_doc_count(&index)?;

        Ok(Self {
            index,
            schema,
            writer: None,
            commit_id,
            doc_count,
            dir,
            fields,
        })
    }

    pub fn index_dir(&self) -> &Path {
        &self.dir
    }

    fn refresh_stats(&mut self) -> Result<LexicalCommitId> {
        self.commit_id = read_commit_id(&self.index)?;
        self.doc_count = read_doc_count(&self.index)?;
        Ok(self.commit_id.clone())
    }

    fn writer_mut(&mut self) -> Result<&mut IndexWriter> {
        if self.writer.is_none() {
            self.writer = Some(
                self.index
                    .writer_with_num_threads(1, WRITER_HEAP_BYTES)
                    .context("create tantivy index writer")?,
            );
        }
        self.writer
            .as_mut()
            .ok_or_else(|| anyhow!("tantivy writer was not initialized"))
    }

    fn add_chunk_to_writer(
        fields: &TantivyFields,
        writer: &mut IndexWriter,
        chunk: &ChunkRef,
    ) -> Result<()> {
        let metadata_json =
            serde_json::to_string(&chunk.metadata).context("serialize chunk metadata")?;
        let agent = metadata_string(&chunk.metadata, "agent");
        let date = metadata_string(&chunk.metadata, "date");
        let project = metadata_string(&chunk.metadata, "project");

        writer.add_document(doc!(
            fields.id => chunk.id.as_str(),
            fields.source_path => chunk.source_path.as_str(),
            fields.body => chunk.text.as_str(),
            fields.agent => agent.as_str(),
            fields.date => date.as_str(),
            fields.project => project.as_str(),
            fields.metadata_json => metadata_json.as_str(),
            fields.agent_filter => stable_filter_key(&agent),
            fields.date_filter => stable_filter_key(&date),
            fields.project_filter => stable_filter_key(&project),
        ))?;
        Ok(())
    }

    fn parse_query(&self, text: &str) -> Result<Box<dyn Query>> {
        if text.trim().is_empty() {
            return Ok(Box::new(AllQuery));
        }
        let parser = QueryParser::for_index(&self.index, vec![self.fields.body, self.fields.id]);
        parser
            .parse_query(text)
            .with_context(|| format!("parse lexical query {text:?}"))
    }

    fn search_top_docs(
        &self,
        searcher: &Searcher,
        query: &dyn Query,
        limit: usize,
        filters: &FilterSet,
    ) -> Result<Vec<(Score, DocAddress)>> {
        let collector = TopDocs::with_limit(limit).order_by_score();

        let docs = match primary_filter(filters) {
            Some((filter_field, filter_value)) => {
                let field = match filter_field {
                    "agent" => "agent_filter",
                    "date" => "date_filter",
                    "project" => "project_filter",
                    _ => {
                        return searcher
                            .search(query, &collector)
                            .context("run tantivy query");
                    }
                };
                let expected = stable_filter_key(&filter_value);
                let filtered: FilterCollector<_, _, u64> = FilterCollector::new(
                    field.to_string(),
                    move |value| value == expected,
                    collector,
                );
                searcher
                    .search(query, &filtered)
                    .with_context(|| format!("run tantivy query with {filter_field} pre-filter"))?
            }
            None => searcher
                .search(query, &collector)
                .context("run tantivy query")?,
        };

        Ok(docs)
    }

    fn hit_from_doc(
        &self,
        searcher: &Searcher,
        score: Score,
        rank: usize,
        address: DocAddress,
    ) -> Result<Hit> {
        let document: TantivyDocument =
            searcher.doc(address).context("load tantivy hit document")?;

        let chunk_id = required_text(&document, self.fields.id, "id")?;
        let source_path = required_text(&document, self.fields.source_path, "source_path")?;
        let agent = text_or_empty(&document, self.fields.agent);
        let date = text_or_empty(&document, self.fields.date);
        let project = text_or_empty(&document, self.fields.project);
        let metadata_json = text_or_empty(&document, self.fields.metadata_json);
        let mut metadata = serde_json::from_str(&metadata_json)
            .unwrap_or_else(|_| serde_json::Value::Object(Default::default()));
        ensure_metadata_field(&mut metadata, "source_path", source_path);
        ensure_metadata_field(&mut metadata, "agent", agent);
        ensure_metadata_field(&mut metadata, "date", date);
        ensure_metadata_field(&mut metadata, "project", project);

        Ok(Hit {
            chunk_id,
            score,
            rank,
            source: TANTIVY_KIND.to_string(),
            metadata,
        })
    }
}

impl LexicalIndex for TantivyAdapter {
    fn schema_version(&self) -> &str {
        TANTIVY_SCHEMA_VERSION
    }

    fn build(&mut self, chunks: &[ChunkRef]) -> Result<LexicalCommitId> {
        // Bug B: build into a sibling staging dir and atomically swap it in,
        // instead of `remove_dir_all`-ing the live index up front. The old
        // index stays queryable until the swap, so search never hits an empty
        // directory mid-rebuild.

        // Drop the writer first so its lock on `self.dir` is released before we
        // rename directories underneath it.
        self.writer = None;

        let staging = {
            let name = self
                .dir
                .file_name()
                .map(|n| n.to_string_lossy().into_owned())
                .unwrap_or_else(|| TANTIVY_INDEX_DIR.to_string());
            let mut p = self.dir.clone();
            p.set_file_name(format!("{name}.building"));
            p
        };
        if staging.exists() {
            fs::remove_dir_all(&staging)
                .with_context(|| format!("clear stale staging dir {}", staging.display()))?;
        }
        fs::create_dir_all(&staging)
            .with_context(|| format!("create staging tantivy dir {}", staging.display()))?;

        let (schema, fields) = build_schema();
        {
            let index = Index::create_in_dir(&staging, schema.clone())
                .with_context(|| format!("create staging tantivy index {}", staging.display()))?;
            register_tokenizers(&index);
            let mut writer = index
                .writer_with_num_threads(1, WRITER_HEAP_BYTES)
                .context("create tantivy index writer")?;

            for chunk in chunks {
                Self::add_chunk_to_writer(&fields, &mut writer, chunk)?;
            }
            writer.commit().context("commit tantivy build")?;
            // writer + index dropped here → all handles on `staging` released
            // before the rename swap below.
        }

        // Promote staging -> live, preserving the previous index until the
        // final rename (last-good stays available throughout the build).
        atomic_swap_dir(&staging, &self.dir)?;

        // Reopen handles from the promoted final location.
        let index = Index::open_in_dir(&self.dir)
            .with_context(|| format!("open promoted tantivy index {}", self.dir.display()))?;
        register_tokenizers(&index);
        let writer = index
            .writer_with_num_threads(1, WRITER_HEAP_BYTES)
            .context("reopen tantivy index writer after swap")?;

        self.index = index;
        self.schema = schema;
        self.fields = fields;
        self.writer = Some(writer);
        self.refresh_stats()
    }

    fn insert(&mut self, chunk: &ChunkRef) -> Result<()> {
        let fields = self.fields.clone();
        {
            let writer = self.writer_mut()?;
            Self::add_chunk_to_writer(&fields, writer, chunk)?;
            writer.commit().context("commit tantivy insert")?;
        }
        self.refresh_stats()?;
        Ok(())
    }

    fn query(&self, q: &LexicalQuery) -> Result<Vec<Hit>> {
        if q.limit == 0 {
            return Ok(Vec::new());
        }

        let query = self.parse_query(&q.text)?;
        let reader = self.index.reader().context("open tantivy reader")?;
        let searcher = reader.searcher();
        let search_limit = if q.filters.values.is_empty() {
            q.limit
        } else {
            self.doc_count.max(q.limit)
        };
        let top_docs = self.search_top_docs(&searcher, query.as_ref(), search_limit, &q.filters)?;

        let mut hits = Vec::new();
        for (score, address) in top_docs {
            let hit = self.hit_from_doc(&searcher, score, hits.len(), address)?;
            if filter_matches(&hit.metadata, &q.filters) {
                hits.push(hit);
            }
            if hits.len() == q.limit {
                break;
            }
        }
        for (rank, hit) in hits.iter_mut().enumerate() {
            hit.rank = rank;
        }
        Ok(hits)
    }

    fn commit_id(&self) -> &LexicalCommitId {
        &self.commit_id
    }

    fn doc_count(&self) -> usize {
        self.doc_count
    }
}

impl TantivyFields {
    fn from_schema(schema: &Schema) -> Result<Self> {
        Ok(Self {
            id: schema.get_field("id")?,
            source_path: schema.get_field("source_path")?,
            body: schema.get_field("body")?,
            agent: schema.get_field("agent")?,
            date: schema.get_field("date")?,
            project: schema.get_field("project")?,
            metadata_json: schema.get_field("metadata_json")?,
            agent_filter: schema.get_field("agent_filter")?,
            date_filter: schema.get_field("date_filter")?,
            project_filter: schema.get_field("project_filter")?,
        })
    }
}

fn build_schema() -> (Schema, TantivyFields) {
    let raw_fast = (STRING | STORED).set_fast(None);
    let body_text = TextOptions::default()
        .set_indexing_options(
            TextFieldIndexing::default()
                .set_tokenizer(BODY_TOKENIZER)
                .set_index_option(IndexRecordOption::WithFreqsAndPositions),
        )
        .set_stored();
    let stored_only = TextOptions::default().set_stored();

    let mut builder = Schema::builder();
    let id = builder.add_text_field("id", STRING | STORED);
    let source_path = builder.add_text_field("source_path", STRING | STORED);
    let body = builder.add_text_field("body", body_text);
    let agent = builder.add_text_field("agent", raw_fast.clone());
    let date = builder.add_text_field("date", raw_fast.clone());
    let project = builder.add_text_field("project", raw_fast);
    let metadata_json = builder.add_text_field("metadata_json", stored_only);
    let agent_filter = builder.add_u64_field("agent_filter", FAST | INDEXED);
    let date_filter = builder.add_u64_field("date_filter", FAST | INDEXED);
    let project_filter = builder.add_u64_field("project_filter", FAST | INDEXED);
    let schema = builder.build();
    let fields = TantivyFields {
        id,
        source_path,
        body,
        agent,
        date,
        project,
        metadata_json,
        agent_filter,
        date_filter,
        project_filter,
    };
    (schema, fields)
}

fn register_tokenizers(index: &Index) {
    let tokenizer = TextAnalyzer::builder(SimpleTokenizer::default())
        .filter(RemoveLongFilter::limit(40))
        .filter(LowerCaser)
        .filter(TantivyStemmersFilter::new(
            algorithms::polish_yarovoy_unaccented,
        ))
        .filter(PolishParticipleTrim)
        .filter(TantivyStemmersFilter::new(algorithms::english_porter_2))
        .build();
    index.tokenizers().register(BODY_TOKENIZER, tokenizer);
}

fn read_commit_id(index: &Index) -> Result<LexicalCommitId> {
    let id = index
        .searchable_segment_ids()
        .context("read tantivy searchable segments")?
        .first()
        .map(|segment| segment.uuid_string())
        .unwrap_or_else(|| "empty".to_string());
    Ok(LexicalCommitId(id))
}

fn read_doc_count(index: &Index) -> Result<usize> {
    let reader = index.reader().context("open tantivy reader")?;
    Ok(reader.searcher().num_docs() as usize)
}

fn metadata_string(metadata: &serde_json::Value, key: &str) -> String {
    metadata
        .get(key)
        .and_then(json_filter_value)
        .unwrap_or_default()
}

fn json_filter_value(value: &serde_json::Value) -> Option<String> {
    match value {
        serde_json::Value::String(value) => Some(value.clone()),
        serde_json::Value::Number(value) => Some(value.to_string()),
        serde_json::Value::Bool(value) => Some(value.to_string()),
        _ => None,
    }
}

fn primary_filter(filters: &FilterSet) -> Option<(&str, String)> {
    for key in ["agent", "date", "project"] {
        if let Some(value) = filters.values.get(key).and_then(json_filter_value) {
            return Some((key, value));
        }
    }
    None
}

fn filter_matches(metadata: &serde_json::Value, filters: &FilterSet) -> bool {
    for (key, expected) in &filters.values {
        match metadata.get(key) {
            Some(actual) if actual == expected => continue,
            _ => return false,
        }
    }
    true
}

fn stable_filter_key(value: &str) -> u64 {
    let mut hasher = StableHasher::default();
    value.hash(&mut hasher);
    hasher.finish()
}

#[derive(Default)]
struct StableHasher(u64);

impl Hasher for StableHasher {
    fn finish(&self) -> u64 {
        self.0
    }

    fn write(&mut self, bytes: &[u8]) {
        let mut hash = if self.0 == 0 {
            0xcbf2_9ce4_8422_2325
        } else {
            self.0
        };
        for byte in bytes {
            hash ^= u64::from(*byte);
            hash = hash.wrapping_mul(0x0000_0100_0000_01b3);
        }
        self.0 = hash;
    }
}

fn required_text(document: &TantivyDocument, field: Field, name: &str) -> Result<String> {
    document
        .get_first(field)
        .and_then(|value| value.as_str().map(ToOwned::to_owned))
        .ok_or_else(|| anyhow!("tantivy hit missing stored field {name}"))
}

fn text_or_empty(document: &TantivyDocument, field: Field) -> String {
    document
        .get_first(field)
        .and_then(|value| value.as_str().map(ToOwned::to_owned))
        .unwrap_or_default()
}

fn ensure_metadata_field(metadata: &mut serde_json::Value, key: &str, value: String) {
    if value.is_empty() {
        return;
    }
    let Some(object) = metadata.as_object_mut() else {
        return;
    };
    object
        .entry(key.to_string())
        .or_insert_with(|| serde_json::Value::String(value));
}

#[derive(Clone)]
struct TantivyStemmersFilter {
    algorithm: algorithms::Algorithm,
}

impl TantivyStemmersFilter {
    fn new(algorithm: algorithms::Algorithm) -> Self {
        Self { algorithm }
    }
}

impl TokenFilter for TantivyStemmersFilter {
    type Tokenizer<T: Tokenizer> = TantivyStemmersFilterWrapper<T>;

    fn transform<T: Tokenizer>(self, tokenizer: T) -> Self::Tokenizer<T> {
        TantivyStemmersFilterWrapper {
            tokenizer,
            algorithm: self.algorithm,
        }
    }
}

#[derive(Clone)]
struct TantivyStemmersFilterWrapper<T> {
    tokenizer: T,
    algorithm: algorithms::Algorithm,
}

impl<T: Tokenizer> Tokenizer for TantivyStemmersFilterWrapper<T> {
    type TokenStream<'a> = TantivyStemmersTokenStream<T::TokenStream<'a>>;

    fn token_stream<'a>(&'a mut self, text: &'a str) -> Self::TokenStream<'a> {
        TantivyStemmersTokenStream {
            tail: self.tokenizer.token_stream(text),
            algorithm: self.algorithm,
            buffer: String::new(),
        }
    }
}

struct TantivyStemmersTokenStream<T> {
    tail: T,
    algorithm: algorithms::Algorithm,
    buffer: String,
}

impl<T: TokenStream> TokenStream for TantivyStemmersTokenStream<T> {
    fn advance(&mut self) -> bool {
        if !self.tail.advance() {
            return false;
        }
        let token = self.tail.token_mut();
        match (self.algorithm)(&token.text) {
            Cow::Owned(stemmed) => token.text = stemmed,
            Cow::Borrowed(stemmed) => {
                self.buffer.clear();
                self.buffer.push_str(stemmed);
                std::mem::swap(&mut token.text, &mut self.buffer);
            }
        }
        true
    }

    fn token(&self) -> &Token {
        self.tail.token()
    }

    fn token_mut(&mut self) -> &mut Token {
        self.tail.token_mut()
    }
}

#[derive(Clone)]
struct PolishParticipleTrim;

impl TokenFilter for PolishParticipleTrim {
    type Tokenizer<T: Tokenizer> = PolishParticipleTrimWrapper<T>;

    fn transform<T: Tokenizer>(self, tokenizer: T) -> Self::Tokenizer<T> {
        PolishParticipleTrimWrapper { tokenizer }
    }
}

#[derive(Clone)]
struct PolishParticipleTrimWrapper<T> {
    tokenizer: T,
}

impl<T: Tokenizer> Tokenizer for PolishParticipleTrimWrapper<T> {
    type TokenStream<'a> = PolishParticipleTrimTokenStream<T::TokenStream<'a>>;

    fn token_stream<'a>(&'a mut self, text: &'a str) -> Self::TokenStream<'a> {
        PolishParticipleTrimTokenStream {
            tail: self.tokenizer.token_stream(text),
        }
    }
}

struct PolishParticipleTrimTokenStream<T> {
    tail: T,
}

impl<T: TokenStream> TokenStream for PolishParticipleTrimTokenStream<T> {
    fn advance(&mut self) -> bool {
        if !self.tail.advance() {
            return false;
        }
        let token = self.tail.token_mut();
        if token.text.len() > 6 && token.text.ends_with("ion") {
            token.text.truncate(token.text.len() - 3);
        }
        true
    }

    fn token(&self) -> &Token {
        self.tail.token()
    }

    fn token_mut(&mut self) -> &mut Token {
        self.tail.token_mut()
    }
}

/// Atomically replace the `target` index directory with a fully-built
/// `staging` directory on the same filesystem (Bug B).
///
/// `target` stays intact and queryable until the final rename, so a concurrent
/// reader never sees a half-built index — only the sub-millisecond gap between
/// two `rename(2)` calls (vs the multi-minute window left by the old
/// `remove_dir_all` + rebuild-in-place). The previous index is moved to a
/// `<name>.old` sibling and removed best-effort after promotion; a leftover
/// backup is non-fatal because the new index is already live.
///
/// Caller MUST drop all open tantivy handles (writer + index) on both `target`
/// and `staging` before calling this — an open handle blocks directory rename
/// on Windows and risks stale inodes elsewhere.
fn atomic_swap_dir(staging: &Path, target: &Path) -> Result<()> {
    let file_name = target
        .file_name()
        .ok_or_else(|| anyhow!("swap target has no file name: {}", target.display()))?
        .to_string_lossy()
        .into_owned();
    let mut backup = target.to_path_buf();
    backup.set_file_name(format!("{file_name}.old"));

    if backup.exists() {
        fs::remove_dir_all(&backup)
            .with_context(|| format!("clear stale backup {}", backup.display()))?;
    }
    if target.exists() {
        fs::rename(target, &backup)
            .with_context(|| format!("back up {} -> {}", target.display(), backup.display()))?;
    }
    if let Err(err) = fs::rename(staging, target) {
        // Promotion failed AFTER the live index was moved to backup — roll the
        // backup back so the last-good index stays queryable, instead of
        // leaving an empty path at `target`.
        if backup.exists() && !target.exists() {
            let _ = fs::rename(&backup, target);
        }
        return Err(err)
            .with_context(|| format!("promote {} -> {}", staging.display(), target.display()));
    }
    if backup.exists() {
        // New index is live; a leftover backup is not fatal.
        let _ = fs::remove_dir_all(&backup);
    }
    Ok(())
}

#[cfg(test)]
mod swap_tests {
    use super::*;
    use std::fs;
    use tempfile::TempDir;

    #[test]
    fn atomic_swap_replaces_target_with_staging() {
        let tmp = TempDir::new().unwrap();
        let target = tmp.path().join("idx");
        let staging = tmp.path().join("idx.building");
        fs::create_dir_all(&target).unwrap();
        fs::write(target.join("marker"), "OLD").unwrap();
        fs::create_dir_all(&staging).unwrap();
        fs::write(staging.join("marker"), "NEW").unwrap();

        atomic_swap_dir(&staging, &target).unwrap();

        assert_eq!(fs::read_to_string(target.join("marker")).unwrap(), "NEW");
        assert!(!staging.exists(), "staging must be consumed by the rename");
        assert!(
            !tmp.path().join("idx.old").exists(),
            "backup must be cleaned up after a successful swap"
        );
    }

    #[test]
    fn atomic_swap_when_target_absent() {
        let tmp = TempDir::new().unwrap();
        let target = tmp.path().join("idx");
        let staging = tmp.path().join("idx.building");
        fs::create_dir_all(&staging).unwrap();
        fs::write(staging.join("marker"), "NEW").unwrap();

        atomic_swap_dir(&staging, &target).unwrap();

        assert_eq!(fs::read_to_string(target.join("marker")).unwrap(), "NEW");
        assert!(!staging.exists());
    }
}