1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
// Copyright 2026 AlphaOne LLC
// SPDX-License-Identifier: Apache-2.0
//! MCP `memory_verify` handler.
use crate::mcp::param_names;
use crate::mcp::registry::McpTool;
use crate::models::field_names;
use crate::{db, validate};
use schemars::JsonSchema;
use serde::Deserialize;
use serde_json::{Value, json};
// --- D1.4 (#985): per-tool McpTool impl for `memory_verify` (graph family) ---
/// v0.7.0 #972 D1.4 (#985) — request body for `memory_verify`.
#[derive(Debug, Clone, Default, Deserialize, JsonSchema)]
#[allow(dead_code)]
pub struct VerifyRequest {
/// Composite id 'source_id--relation-->target_id'.
#[serde(default)]
pub link_id: Option<String>,
/// Required when link_id omitted.
#[serde(default)]
pub source_id: Option<String>,
/// Required when link_id omitted.
#[serde(default)]
pub target_id: Option<String>,
/// Default related_to.
#[serde(default)]
pub relation: Option<String>,
}
/// v0.7.0 #972 D1.4 (#985) — `McpTool` impl for `memory_verify`.
#[allow(dead_code)]
pub struct VerifyTool;
impl McpTool for VerifyTool {
fn name() -> &'static str {
crate::mcp::registry::tool_names::MEMORY_VERIFY
}
fn description() -> &'static str {
"Re-verify a stored memory_links row's Ed25519 signature on demand."
}
fn docs() -> &'static str {
"H4: re-verify link signature. Returns {signature_verified, attest_level, signed_by, signed_at}. Pass link_id composite ('source--relation-->target') or explicit triple."
}
fn input_schema() -> Value {
crate::mcp::registry::input_schema_for::<VerifyRequest>()
}
fn family() -> &'static str {
crate::profile::Family::Graph.name()
}
}
/// v0.7 H4 — `memory_verify` MCP tool handler.
///
/// Looks up the named link by composite PK, re-derives the canonical
/// CBOR payload via [`crate::identity::sign::canonical_cbor`], looks up
/// the `observed_by` public key via
/// [`crate::identity::verify::lookup_peer_public_key`], and re-checks
/// the stored signature with [`crate::identity::verify::verify`].
///
/// Wire shape (always returned, even on the unsigned path):
///
/// ```json
/// {
/// "signature_verified": bool,
/// "attest_level": "unsigned" | "self_signed" | "peer_attested",
/// "signed_by": <observed_by string or null>,
/// "signed_at": <valid_from string or null>
/// }
/// ```
///
/// `signed_by` and `signed_at` are sourced from the `observed_by` and
/// `valid_from` columns respectively — the same columns the H2/H3
/// signature commits to. They are returned `null` on the unsigned path
/// so callers can drop them without a None-check.
///
/// `pub` so the H4 integration test in `tests/memory_verify.rs` can
/// drive the handler directly without standing up the JSON-RPC
/// envelope or spawning the daemon binary. Other handlers in this
/// module stay private because the dispatcher is their sole caller.
///
/// # Errors
///
/// Returned as JSON-RPC error strings (the dispatcher wraps them as
/// `-32602` invalid params). Specifically:
/// - missing required arguments (no `link_id` and no
/// `source_id`+`target_id`)
/// - `link_id` shape doesn't match the composite form
/// - link tuple does not exist in `memory_links`
pub fn handle_verify(conn: &rusqlite::Connection, params: &Value) -> Result<Value, String> {
// Two callable shapes:
// 1. link_id="<src>--<rel>-->\<dst>"
// 2. source_id=… target_id=… [relation="related_to"]
let (source_id, target_id, relation): (String, String, String) =
if let Some(lid) = params.get(param_names::LINK_ID).and_then(Value::as_str) {
super::link::parse_link_id(lid).ok_or_else(|| {
format!(
"link_id '{lid}' is not in the expected form \
'source_id--relation-->target_id'"
)
})?
} else {
let src = params
.get(param_names::SOURCE_ID)
.and_then(Value::as_str)
.ok_or("link_id or source_id+target_id is required")?;
let dst = params
.get(param_names::TARGET_ID)
.and_then(Value::as_str)
.ok_or("link_id or source_id+target_id is required")?;
let rel = params
.get(param_names::RELATION)
.and_then(Value::as_str)
.unwrap_or(crate::models::MemoryLinkRelation::RelatedTo.as_str());
(src.to_string(), dst.to_string(), rel.to_string())
};
// Validate the IDs / relation through the same gate `memory_link`
// uses on the write path — keeps the verify surface from being a
// back-door past the validator.
validate::RequestValidator::validate_link_triple(&source_id, &target_id, &relation)
.map_err(|e| e.to_string())?;
let record = db::get_link_for_verify(conn, &source_id, &target_id, &relation)
.map_err(|e| e.to_string())?
.ok_or_else(|| format!("link not found: ({source_id}, {relation}, {target_id})"))?;
// Decision matrix mirrors `decide_attest_level` from the H3 tests:
// - signature is None → unsigned, signature_verified=false
// - signature is Some + observed_by is None → unsigned (no claim
// to verify against)
// - signature is Some + observed_by is Some + no enrolled
// pubkey on this host → return the column's stored attest_level
// (which the inbound path already wrote as either "unsigned" on
// enrolled-but-tampered, or whatever it landed as) but report
// `signature_verified = false` because *we* cannot verify
// without the public key.
// - signature is Some + observed_by is Some + pubkey enrolled →
// verify and report the actual outcome. We deliberately recheck
// here even when the column already says "self_signed" or
// "peer_attested": the whole point of `memory_verify` is on-
// demand re-validation, not a stored-flag readback.
let stored_attest = record
.attest_level
.as_deref()
.and_then(crate::models::AttestLevel::from_str)
.unwrap_or(crate::models::AttestLevel::Unsigned);
let (verified, attest_out): (bool, crate::models::AttestLevel) =
match (record.signature.as_deref(), record.observed_by.as_deref()) {
(None, _) | (_, None) => (false, crate::models::AttestLevel::Unsigned),
(Some(sig_bytes), Some(observed_by)) => {
let signable = crate::identity::sign::SignableLink {
src_id: &record.source_id,
dst_id: &record.target_id,
relation: &record.relation,
observed_by: Some(observed_by),
valid_from: record.valid_from.as_deref(),
valid_until: record.valid_until.as_deref(),
};
match crate::identity::verify::lookup_peer_public_key(observed_by) {
Some(pubkey) => {
let ok =
crate::identity::verify::verify(&pubkey, &signable, sig_bytes).is_ok();
if ok {
// On a successful re-verify, prefer the stored
// attest_level — it distinguishes self_signed
// (this host wrote+signed) from peer_attested
// (a peer signed and we accepted on inbound).
// If the column drifted to None on a very old
// row, fall back to PeerAttested (the only
// attestation we can re-derive without
// knowing whether the signing key is our own).
let level = match stored_attest {
crate::models::AttestLevel::Unsigned => {
crate::models::AttestLevel::PeerAttested
}
other => other,
};
(true, level)
} else {
(false, crate::models::AttestLevel::Unsigned)
}
}
None => {
// Signature is present but we can't look up the
// pubkey on this host — surface as not-verified.
// Keep the stored attest_level so callers can see
// what the inbound path originally decided.
(false, stored_attest)
}
}
}
};
let signed_by: Value = if verified {
record
.observed_by
.as_deref()
.map_or(Value::Null, |s| Value::String(s.to_string()))
} else {
Value::Null
};
let signed_at: Value = if verified {
record
.valid_from
.as_deref()
.map_or(Value::Null, |s| Value::String(s.to_string()))
} else {
Value::Null
};
Ok(json!({
"signature_verified": verified,
(field_names::ATTEST_LEVEL): attest_out.as_str(),
"signed_by": signed_by,
"signed_at": signed_at,
}))
}
#[cfg(test)]
mod d1_4_985_tests {
//! D1.4 (#985) — schema-parity for `memory_verify`.
use super::*;
use crate::mcp::d1_4_985_helpers::{
assert_descriptions_match, assert_property_set_parity, derived_props_for,
};
#[test]
fn memory_verify_parity_985() {
let derived = derived_props_for::<VerifyRequest>();
assert_property_set_parity("memory_verify", &derived);
assert_descriptions_match("memory_verify", &derived);
}
#[test]
fn memory_verify_tool_metadata_985() {
assert_eq!(VerifyTool::name(), "memory_verify");
assert_eq!(VerifyTool::family(), "graph");
}
}