use super::{
apply_completion_event, exceeds_cost_ceiling, loop_kill_detail, parse_milestone_event, LoopDetector,
SyntheticMilestoneTracker,
};
use crate::paths;
use crate::types::{CompletionInfo, EventKind, TaskEvent, TaskId, TaskStatus};
use chrono::Local;
use serde_json::json;
use tempfile::tempdir;
#[test]
fn completion_metadata_updates_summary_fields() {
let mut info = CompletionInfo {
tokens: None,
status: TaskStatus::Done,
model: None,
cost_usd: None,
exit_code: None,
};
let event = TaskEvent {
task_id: TaskId("t-usage".to_string()),
timestamp: Local::now(),
event_kind: EventKind::Completion,
detail: "completed".to_string(),
metadata: Some(json!({
"tokens": 12345,
"model": "gpt-4.1",
"cost_usd": 0.12
})),
};
apply_completion_event(&mut info, &event);
assert_eq!(info.tokens, Some(12345));
assert_eq!(info.model.as_deref(), Some("gpt-4.1"));
assert_eq!(info.cost_usd, Some(0.12));
}
#[test]
fn non_completion_events_do_not_change_summary_fields() {
let mut info = CompletionInfo {
tokens: Some(10),
status: TaskStatus::Done,
model: Some("gpt-4.1".to_string()),
cost_usd: Some(0.01),
exit_code: None,
};
let event = TaskEvent {
task_id: TaskId("t-ignore".to_string()),
timestamp: Local::now(),
event_kind: EventKind::Reasoning,
detail: "thinking".to_string(),
metadata: Some(json!({ "tokens": 999 })),
};
apply_completion_event(&mut info, &event);
assert_eq!(info.tokens, Some(10));
assert_eq!(info.model.as_deref(), Some("gpt-4.1"));
assert_eq!(info.cost_usd, Some(0.01));
}
#[test]
fn cost_ceiling_only_triggers_above_limit() {
assert!(!exceeds_cost_ceiling(Some(1.0), Some(1.0)));
assert!(exceeds_cost_ceiling(Some(1.01), Some(1.0)));
assert!(!exceeds_cost_ceiling(None, Some(1.0)));
assert!(!exceeds_cost_ceiling(Some(1.0), None));
}
#[test]
fn milestone_event_parses_plain_text_lines() {
let event = parse_milestone_event(
&TaskId("t-m1".to_string()),
"[MILESTONE] types defined",
)
.unwrap();
assert_eq!(event.event_kind, EventKind::Milestone);
assert_eq!(event.detail, "types defined");
}
#[test]
fn milestone_event_parses_json_lines() {
let line = r#"{"type":"item.completed","item":{"type":"agent_message","text":"[MILESTONE] tests passing\nnext"}} "#;
let event = parse_milestone_event(&TaskId("t-m2".to_string()), line).unwrap();
assert_eq!(event.event_kind, EventKind::Milestone);
assert_eq!(event.detail, "tests passing");
}
#[test]
fn finding_event_parses_plain_text_lines() {
let detail = super::extract_finding_detail("[FINDING] gamma can be zero in tricrypto");
assert_eq!(detail.as_deref(), Some("gamma can be zero in tricrypto"));
}
#[test]
fn milestone_inside_string_literal_is_rejected() {
let line = r#"println!("[MILESTONE] tests passing");"#;
assert!(super::extract_milestone_detail(line).is_none());
}
#[test]
fn milestone_inside_json_string_value_is_rejected() {
let line = r#"{"text": "assert_eq!(detail, "[MILESTONE] done")"}"#;
assert!(super::extract_milestone_detail(line).is_none());
}
#[test]
fn finding_inside_string_literal_is_rejected() {
let line = r#"let s = "[FINDING] gamma can be zero";"#;
assert!(super::extract_finding_detail(line).is_none());
}
#[test]
fn real_milestone_still_extracted() {
let detail = super::extract_milestone_detail("[MILESTONE] implementation complete");
assert_eq!(detail.as_deref(), Some("implementation complete"));
}
#[test]
fn real_finding_still_extracted() {
let detail = super::extract_finding_detail("[FINDING] pool has degenerate state");
assert_eq!(detail.as_deref(), Some("pool has degenerate state"));
}
#[test]
fn milestone_lines_stripped_from_output() {
let input = "line1\n[MILESTONE] types defined\nline2\n";
let filtered: String = input
.lines()
.filter(|line| super::extract_milestone_detail(line).is_none())
.collect::<Vec<_>>()
.join("\n");
assert_eq!(filtered, "line1\nline2");
}
fn tracker_event(kind: EventKind, detail: &str) -> TaskEvent {
TaskEvent {
task_id: TaskId("t-synth".to_string()),
timestamp: Local::now(),
event_kind: kind,
detail: detail.to_string(),
metadata: None,
}
}
#[test]
fn synthetic_tracker_emits_milestone_after_three_reads() {
let task_id = TaskId("t-read".to_string());
let mut tracker = SyntheticMilestoneTracker::new();
let mut milestone = None;
for detail in ["Read", "Glob", "Read"] {
let event = tracker_event(EventKind::ToolCall, detail);
tracker.observe(&event);
milestone = tracker.synthetic_event(&task_id, &event);
}
let milestone = milestone.expect("expected synthetic milestone");
assert_eq!(milestone.event_kind, EventKind::Milestone);
assert_eq!(milestone.detail, "[exploring] read 3 files");
}
#[test]
fn synthetic_tracker_emits_first_edit_after_reads() {
let task_id = TaskId("t-edit".to_string());
let mut tracker = SyntheticMilestoneTracker::new();
for detail in ["Read", "Read", "Glob"] {
let event = tracker_event(EventKind::ToolCall, detail);
tracker.observe(&event);
let _ = tracker.synthetic_event(&task_id, &event);
}
let edit = tracker_event(EventKind::ToolCall, "Edit");
tracker.observe(&edit);
let milestone = tracker.synthetic_event(&task_id, &edit).expect("expected first edit");
assert_eq!(milestone.detail, "[implementing] first edit");
}
#[test]
fn synthetic_tracker_stays_disabled_when_reasoning_exists() {
let task_id = TaskId("t-reason".to_string());
let mut tracker = SyntheticMilestoneTracker::new();
let reasoning = tracker_event(EventKind::Reasoning, "thinking");
tracker.observe(&reasoning);
let tool = tracker_event(EventKind::ToolCall, "Read");
tracker.observe(&tool);
assert!(tracker.synthetic_event(&task_id, &tool).is_none());
}
fn loop_detector_case<I, S>(expected: bool, events: I)
where
I: IntoIterator<Item = S>,
S: AsRef<str>,
{
let mut detector = LoopDetector::new();
events
.into_iter()
.for_each(|detail| detector.push(detail.as_ref(), EventKind::Reasoning, None));
assert_eq!(detector.is_looping(), expected);
}
#[test]
fn loop_detector_patterns() {
loop_detector_case(false, ["a", "b", "c", "d", "e", "f", "g", "h", "i", "j"]);
loop_detector_case(true, std::iter::repeat_n("repeat", 10));
loop_detector_case(
false,
std::iter::repeat_n("dup", 7).chain(["unique-1", "unique-2", "unique-3"]),
);
loop_detector_case(
true,
std::iter::repeat_n("dup", 8).chain(["unique-1", "unique-2"]),
);
}
#[test]
fn loop_detector_ignores_empty_details() {
loop_detector_case(false, std::iter::repeat_n("", 20));
loop_detector_case(false, std::iter::repeat_n(" ", 20));
loop_detector_case(false, std::iter::repeat_n("\t", 20));
let mut events: Vec<&str> = Vec::new();
for _ in 0..5 {
events.push("");
events.push("working");
events.push(" ");
}
loop_detector_case(false, events);
}
#[test]
fn loop_detector_distinguishes_long_details() {
let shared_prefix = "Read(".to_string() + &"a".repeat(110);
let first = format!("{shared_prefix}file1.rs)");
let second = format!("{shared_prefix}file2.rs)");
let events = std::iter::repeat_n(first.as_str(), 5)
.chain(std::iter::repeat_n(second.as_str(), 5));
loop_detector_case(false, events);
}
#[test]
fn loop_detector_uses_file_write_raw_path_with_higher_threshold() {
let mut detector = LoopDetector::new();
for index in 0..20 {
let raw_key = format!("/tmp/worktree/evaluator-different-{index}.rs");
detector.push(".../evaluator-d...", EventKind::FileWrite, Some(&raw_key));
}
assert!(!detector.is_looping());
let mut detector = LoopDetector::new();
for _ in 0..14 {
detector.push(".../evaluator-d...", EventKind::FileWrite, Some("/tmp/worktree/evaluator.rs"));
}
assert!(!detector.is_looping());
detector.push(".../evaluator-d...", EventKind::FileWrite, Some("/tmp/worktree/evaluator.rs"));
assert!(detector.is_looping());
}
#[test]
fn loop_detector_resets_file_write_counter_on_non_file_event() {
let mut detector = LoopDetector::new();
for _ in 0..14 {
detector.push("file.rs", EventKind::FileWrite, Some("/tmp/file.rs"));
}
detector.push("thinking", EventKind::Reasoning, None);
detector.push("file.rs", EventKind::FileWrite, Some("/tmp/file.rs"));
assert!(!detector.is_looping());
}
#[test]
fn loop_kill_detail_appends_apply_patch_stderr_line() {
let temp = tempdir().unwrap();
let _aid_home = paths::AidHomeGuard::set(temp.path());
let task_id = TaskId("t-stderr".to_string());
std::fs::create_dir_all(paths::logs_dir()).unwrap();
std::fs::write(
paths::stderr_path(task_id.as_str()),
"note\napply_patch verification failed: Failed to find expected lines in evaluator.rs\n",
)
.unwrap();
let detail = loop_kill_detail(&task_id);
assert!(detail.contains("Agent appears stuck in a loop"));
assert!(detail.contains("apply_patch verification failed"));
}