ahx-rs 0.1.0

Safe, allocation-free CRI AHX audio decoding with no_std support
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
//! Public storage, parsing, ownership and error contracts.

use ahx_rs::{
    DecoderState, Error, InvalidData, Metadata, PacketDecoder, SliceDecoder, UnsupportedData,
    MAX_FRAME_BYTES, SAMPLES_PER_FRAME,
};

const INPUT: &[u8] = include_bytes!("fixtures/continuity.ahx");
const GOLDEN: &[u8] = include_bytes!("fixtures/continuity.pcm");

fn expected() -> Vec<i16> {
    GOLDEN
        .as_chunks::<2>()
        .0
        .iter()
        .copied()
        .map(i16::from_le_bytes)
        .collect()
}

#[test]
fn header_preflight_and_full_validation_are_distinct() {
    let metadata = Metadata::parse(INPUT).unwrap();
    assert_eq!(Metadata::required_header_len(&INPUT[..20]).unwrap(), 32);
    assert_eq!(metadata.header_len(), 32);
    assert_eq!(metadata.channels(), 1);
    assert_eq!(metadata.samples(), 2304);
    assert_eq!(metadata.sample_rate(), 32000);
    for end in 0..metadata.header_len() {
        assert!(matches!(
            Metadata::parse(&INPUT[..end]),
            Err(Error::Truncated)
        ));
    }
    assert_eq!(Metadata::parse(&INPUT[..32]).unwrap(), metadata);
    let mut corrupt = INPUT.to_vec();
    corrupt[31] = 0;
    assert_eq!(Metadata::required_header_len(&corrupt).unwrap(), 32);
    assert!(matches!(Metadata::parse(&corrupt), Err(Error::Invalid(_))));
    corrupt[4] = 0x11;
    assert!(matches!(
        Metadata::parse(&corrupt),
        Err(Error::Unsupported(_))
    ));
}

#[test]
fn longest_header_is_bounded_and_preserves_payload() {
    let mut input = INPUT[..20].to_vec();
    input[2..4].copy_from_slice(&u16::MAX.to_be_bytes());
    input.resize(65539 - 6, 0);
    input.extend_from_slice(b"(c)CRI");
    input.extend_from_slice(&INPUT[32..]);
    let mut d = SliceDecoder::new(&input).unwrap();
    assert_eq!(d.metadata().header_len(), 65539);
    let mut pcm = Vec::new();
    while let Some(block) = d.next_block().unwrap() {
        pcm.extend_from_slice(block);
    }
    assert_eq!(pcm, expected());
}

#[test]
fn exact_storage_and_default_storage_produce_identical_pcm() {
    let mut pcm = [0x1234; SAMPLES_PER_FRAME + 7];
    let mut small = [0x2345; SAMPLES_PER_FRAME - 1];
    let error = SliceDecoder::with_buffer(INPUT, &mut small[..]).unwrap_err();
    assert!(matches!(
        error,
        Error::BufferTooSmall { required: SAMPLES_PER_FRAME, provided }
            if provided == SAMPLES_PER_FRAME - 1
    ));
    assert!(small.iter().all(|&s| s == 0x2345));
    let mut input = INPUT.to_vec();
    input.extend_from_slice(b"trailing");
    let mut borrowed = SliceDecoder::with_buffer(&input, &mut pcm[..]).unwrap();
    let mut owned = SliceDecoder::new(INPUT).unwrap();
    while let Some(block) = owned.next_block().unwrap() {
        assert_eq!(borrowed.next_block().unwrap().unwrap(), block);
    }
    assert!(borrowed.next_block().unwrap().is_none());
    assert!(borrowed.next_block().unwrap().is_none());
    let (rest, storage) = borrowed.into_inner();
    assert_eq!(rest, b"trailing");
    assert_eq!(&storage[SAMPLES_PER_FRAME..], &[0x1234; 7]);
}

#[test]
fn packets_report_exact_consumption_and_preserve_history() {
    let mut d = PacketDecoder::new();
    let mut pcm = [0; SAMPLES_PER_FRAME];
    let mut rest = &INPUT[Metadata::parse(INPUT).unwrap().header_len()..];
    let mut output = Vec::new();
    for _ in 0..2 {
        let packet = d.decode_into(rest, &mut pcm).unwrap();
        let _: &[i16; SAMPLES_PER_FRAME] = packet.pcm();
        assert!(packet.consumed_bytes() <= MAX_FRAME_BYTES);
        output.extend_from_slice(packet.pcm());
        rest = &rest[packet.consumed_bytes()..];
    }
    assert_eq!(output, expected());
    assert_eq!(rest, b"\0\x80\x01\0\x0cAHXE(c)CRI\0\0");
}

#[test]
fn every_truncated_packet_and_short_output_can_be_retried() {
    let data = &INPUT[32..];
    let mut pcm = [0; SAMPLES_PER_FRAME];
    let first = PacketDecoder::new()
        .decode_into(data, &mut pcm)
        .unwrap()
        .consumed_bytes();
    let first_expected = pcm;
    for end in 0..first {
        let mut decoder = PacketDecoder::new();
        let mut output = [0x3456; SAMPLES_PER_FRAME + 1];
        assert!(
            matches!(
                decoder.decode_into(&data[..end], &mut output),
                Err(Error::Truncated)
            ),
            "prefix {end}"
        );
        assert!(output.iter().all(|&v| v == 0x3456));
        assert_eq!(
            decoder.decode_into(data, &mut output).unwrap().pcm(),
            &first_expected
        );
        assert_eq!(output[SAMPLES_PER_FRAME], 0x3456);
        let before = output;
        assert!(matches!(
            decoder.decode_into(&data[first..], &mut output[..SAMPLES_PER_FRAME - 1]),
            Err(Error::BufferTooSmall { .. })
        ));
        assert_eq!(output, before);
        assert_eq!(
            decoder
                .decode_into(&data[first..], &mut output)
                .unwrap()
                .pcm(),
            &expected()[SAMPLES_PER_FRAME..]
        );
    }
}

#[test]
fn invalid_quantizers_preserve_synthesis_and_output() {
    let mut decoder = PacketDecoder::new();
    let mut pcm = [0; SAMPLES_PER_FRAME];
    let first = decoder
        .decode_into(&INPUT[32..], &mut pcm)
        .unwrap()
        .consumed_bytes();
    // Allocation 1 in subband 0 (5-bit grouped radix-3), SCFSI 2 and scale 0.
    // The first quantizer is 31, outside the 27 valid grouped values.
    let mut bad = [0u8; MAX_FRAME_BYTES];
    bad[..4].copy_from_slice(&[0xff, 0xf5, 0xe0, 0xc0]);
    bad[4] = 0x10;
    fn set(bits: &mut [u8], start: usize, width: usize, value: u32) {
        for i in 0..width {
            bits[(start + i) / 8] |=
                (((value >> (width - 1 - i)) & 1) as u8) << (7 - (start + i) % 8);
        }
    }
    let allocation_end = 32 + 4 * 4 + 7 * 3 + 19 * 2;
    set(&mut bad, allocation_end, 2, 2);
    set(&mut bad, allocation_end + 2 + 6, 5, 31);
    let before = pcm;
    assert!(matches!(
        decoder.decode_into(&bad, &mut pcm),
        Err(Error::Invalid(InvalidData::GroupedQuantizer))
    ));
    assert_eq!(pcm, before);
    assert_eq!(
        decoder
            .decode_into(&INPUT[32 + first..], &mut pcm)
            .unwrap()
            .pcm(),
        &expected()[SAMPLES_PER_FRAME..]
    );
}

#[test]
fn footer_errors_are_reported_before_the_final_block_and_poison_the_reader() {
    let mut input = INPUT.to_vec();
    *input.last_mut().unwrap() = 1;
    let mut decoder = SliceDecoder::new(&input).unwrap();
    assert_eq!(
        decoder.next_block().unwrap().unwrap().len(),
        SAMPLES_PER_FRAME
    );
    assert!(matches!(
        decoder.next_block(),
        Err(Error::Invalid(InvalidData::EndMarker))
    ));
    assert!(matches!(decoder.next_block(), Err(Error::Failed)));
    assert_eq!(decoder.state(), DecoderState::Failed);
    let mut short = INPUT.to_vec();
    short[12..16].copy_from_slice(&1152u32.to_be_bytes());
    assert!(SliceDecoder::new(&short).unwrap().next_block().is_err());
}

#[test]
fn changing_storage_views_return_an_error_without_panicking() {
    struct Shrinking {
        pcm: [i16; SAMPLES_PER_FRAME],
        calls: usize,
    }
    impl AsMut<[i16]> for Shrinking {
        fn as_mut(&mut self) -> &mut [i16] {
            self.calls += 1;
            if self.calls == 1 {
                &mut self.pcm
            } else {
                &mut self.pcm[..0]
            }
        }
    }
    let mut decoder = SliceDecoder::with_buffer(
        INPUT,
        Shrinking {
            pcm: [0; SAMPLES_PER_FRAME],
            calls: 0,
        },
    )
    .unwrap();
    assert!(matches!(
        decoder.next_block(),
        Err(Error::BufferTooSmall { provided: 0, .. })
    ));
    assert!(matches!(decoder.next_block(), Err(Error::Failed)));
}

#[test]
fn state_fits_in_fixed_storage() {
    assert!(core::mem::size_of::<SliceDecoder<'_>>() < 10 * 1024);
    assert!(core::mem::size_of::<PacketDecoder>() < 7 * 1024);
}

#[test]
fn progress_reaches_finished_only_after_the_trimmed_final_block_and_footer() {
    use core::num::NonZeroU32;

    let mut input = INPUT.to_vec();
    input[12..16].copy_from_slice(&1201u32.to_be_bytes());
    let mut decoder = SliceDecoder::new(&input).unwrap();
    assert_eq!(
        decoder.state(),
        DecoderState::Decoding {
            remaining_samples: NonZeroU32::new(1201).unwrap(),
        }
    );
    assert_eq!(decoder.next_block().unwrap().unwrap().len(), 1152);
    assert_eq!(
        decoder.state(),
        DecoderState::Decoding {
            remaining_samples: NonZeroU32::new(49).unwrap(),
        }
    );
    assert_eq!(decoder.next_block().unwrap().unwrap().len(), 49);
    assert_eq!(decoder.state(), DecoderState::Finished);
    assert!(decoder.next_block().unwrap().is_none());
    assert_eq!(decoder.state(), DecoderState::Finished);
}

#[test]
fn typed_header_errors_retain_invalid_values() {
    let mut input = INPUT.to_vec();
    for rate in [0u32, 8000, u32::MAX] {
        input[8..12].copy_from_slice(&rate.to_be_bytes());
        assert!(matches!(
            Metadata::parse(&input),
            Err(Error::Unsupported(UnsupportedData::SampleRate(actual))) if actual == rate
        ));
    }
    input[8..12].copy_from_slice(&32000u32.to_be_bytes());
    for count in [0u32, i32::MAX as u32 + 1, u32::MAX] {
        input[12..16].copy_from_slice(&count.to_be_bytes());
        assert!(matches!(
            Metadata::parse(&input),
            Err(Error::Invalid(InvalidData::SampleCount(actual))) if actual == count
        ));
    }
}

#[test]
fn terminal_states_never_access_caller_storage_again() {
    struct Counted {
        pcm: [i16; SAMPLES_PER_FRAME],
        calls: usize,
    }
    impl AsMut<[i16]> for Counted {
        fn as_mut(&mut self) -> &mut [i16] {
            self.calls += 1;
            &mut self.pcm
        }
    }
    for valid in [false, true] {
        let mut input = INPUT.to_vec();
        if !valid {
            *input.last_mut().unwrap() = 1;
        }
        let mut decoder = SliceDecoder::with_buffer(
            &input,
            Counted {
                pcm: [0; SAMPLES_PER_FRAME],
                calls: 0,
            },
        )
        .unwrap();
        decoder.next_block().unwrap();
        assert_eq!(decoder.next_block().is_ok(), valid);
        for _ in 0..3 {
            if valid {
                assert!(decoder.next_block().unwrap().is_none());
            } else {
                assert!(matches!(decoder.next_block(), Err(Error::Failed)));
            }
        }
        assert_eq!(decoder.into_inner().1.calls, 3);
    }
}

#[test]
fn caught_storage_panics_leave_the_decoder_failed() {
    struct Panicking {
        pcm: [i16; SAMPLES_PER_FRAME],
        accessed: bool,
    }
    impl AsMut<[i16]> for Panicking {
        fn as_mut(&mut self) -> &mut [i16] {
            // Constructor sizing succeeds. Access at the first block panics.
            if core::mem::replace(&mut self.accessed, true) {
                panic!("storage panic");
            }
            &mut self.pcm
        }
    }
    let mut decoder = SliceDecoder::with_buffer(
        INPUT,
        Panicking {
            pcm: [0; SAMPLES_PER_FRAME],
            accessed: false,
        },
    )
    .unwrap();
    assert!(std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
        let _ = decoder.next_block();
    }))
    .is_err());
    assert_eq!(decoder.state(), DecoderState::Failed);
    assert!(matches!(decoder.next_block(), Err(Error::Failed)));
}

#[cfg(feature = "std")]
#[test]
fn caught_io_panics_leave_the_decoder_failed() {
    use std::io::{self, Read};

    struct Panicking<'a>(&'a [u8]);
    impl Read for Panicking<'_> {
        fn read(&mut self, out: &mut [u8]) -> io::Result<usize> {
            if self.0.len() <= INPUT.len() - 32 {
                panic!("reader panic");
            }
            self.0.read(out)
        }
    }
    let mut decoder = ahx_rs::Decoder::new(Panicking(INPUT)).unwrap();
    assert!(std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| {
        let _ = decoder.next_block();
    }))
    .is_err());
    assert_eq!(decoder.state(), DecoderState::Failed);
    assert!(matches!(decoder.next_block(), Err(Error::Failed)));
}

#[cfg(feature = "std")]
#[test]
fn standard_io_fragmentation_errors_and_position_match_the_slice_api() {
    use std::io::{self, Read};
    struct Fragmented<'a>(&'a [u8], bool);
    impl Read for Fragmented<'_> {
        fn read(&mut self, out: &mut [u8]) -> io::Result<usize> {
            self.1 = !self.1;
            if self.1 {
                return Err(io::ErrorKind::Interrupted.into());
            }
            let len = out.len().min(3);
            self.0.read(&mut out[..len])
        }
    }
    let mut input = INPUT.to_vec();
    input.extend_from_slice(b"trailing");
    let mut decoder = ahx_rs::Decoder::new(Fragmented(&input, false)).unwrap();
    let mut output = Vec::new();
    while let Some(pcm) = decoder.next_block().unwrap() {
        output.extend_from_slice(pcm);
    }
    assert_eq!(output, expected());
    assert_eq!(decoder.state(), DecoderState::Finished);
    assert!(decoder.next_block().unwrap().is_none());
    assert_eq!(decoder.into_inner().0, b"trailing");
    let mut cursor = io::Cursor::new(INPUT);
    let info = Metadata::read(&mut cursor).unwrap();
    assert_eq!(cursor.position(), info.header_len() as u64);
    struct Broken;
    impl Read for Broken {
        fn read(&mut self, _: &mut [u8]) -> io::Result<usize> {
            Err(io::ErrorKind::PermissionDenied.into())
        }
    }
    let error = Metadata::read(&mut Broken).unwrap_err();
    assert!(matches!(&error, Error::Io(e) if e.kind() == io::ErrorKind::PermissionDenied));
    assert!(std::error::Error::source(&error).is_some());
    assert!(matches!(
        Metadata::read(&mut &INPUT[..4]),
        Err(Error::Truncated)
    ));
}