agpm-cli 0.4.14

AGent Package Manager - A Git-based package manager for coding agents
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
use crate::mcp::models::{AgpmMetadata, ClaudeSettings, McpServerConfig};
use anyhow::Result;
use std::collections::HashMap;
use std::fs;
use tempfile::tempdir;

use super::setup_project_root;

#[test]
fn test_claude_settings_load_save() -> Result<()> {
    let temp = tempdir()?;
    let settings_path = temp.path().join("settings.local.json");

    let mut settings = ClaudeSettings::default();
    let mut servers = HashMap::new();
    servers.insert(
        "test-server".to_string(),
        McpServerConfig {
            command: Some("node".to_string()),
            args: vec!["server.js".to_string()],
            env: None,
            r#type: None,
            url: None,
            headers: None,
            agpm_metadata: None,
        },
    );
    settings.mcp_servers = Some(servers);

    settings.save(&settings_path)?;

    let loaded = ClaudeSettings::load_or_default(&settings_path)?;
    assert!(loaded.mcp_servers.is_some());
    let servers =
        loaded.mcp_servers.ok_or_else(|| anyhow::anyhow!("Expected mcp_servers to be present"))?;
    assert_eq!(servers.len(), 1);
    assert!(servers.contains_key("test-server"));
    Ok(())
}

#[test]
fn test_claude_settings_load_nonexistent_file() -> Result<()> {
    let temp = tempdir()?;
    let settings_path = temp.path().join("nonexistent.json");

    let settings = ClaudeSettings::load_or_default(&settings_path)?;
    assert!(settings.mcp_servers.is_none());
    assert!(settings.permissions.is_none());
    assert!(settings.other.is_empty());
    Ok(())
}

#[test]
fn test_claude_settings_load_invalid_json() -> Result<()> {
    let temp = tempdir()?;
    let settings_path = temp.path().join("invalid.json");
    fs::write(&settings_path, "invalid json {")?;

    let result = ClaudeSettings::load_or_default(&settings_path);
    assert!(result.is_err());
    assert!(result.unwrap_err().to_string().contains("Failed to parse"));
    Ok(())
}

#[test]
fn test_claude_settings_save_creates_backup() -> Result<()> {
    let temp = tempdir()?;
    setup_project_root(temp.path())?;

    let settings_path = temp.path().join("settings.local.json");
    let backup_path =
        temp.path().join(".agpm").join("backups").join("claude-code").join("settings.local.json");

    // Create initial file
    fs::write(&settings_path, r#"{"test": "value"}"#)?;

    let settings = ClaudeSettings::default();
    settings.save(&settings_path)?;

    // Backup should be created in .agpm/backups/claude-code directory
    assert!(backup_path.exists());
    let backup_content = fs::read_to_string(backup_path)?;
    assert_eq!(backup_content, r#"{"test": "value"}"#);
    Ok(())
}

#[test]
fn test_claude_settings_update_mcp_servers_empty_dir() -> Result<()> {
    let temp = tempdir()?;
    let nonexistent_dir = temp.path().join("nonexistent");

    let mut settings = ClaudeSettings::default();
    // Should not error on nonexistent directory
    settings.update_mcp_servers(&nonexistent_dir)?;
    Ok(())
}

#[test]
fn test_update_mcp_servers_from_directory() -> Result<()> {
    let temp = tempdir()?;
    let mcp_servers_dir = temp.path().join("mcp-servers");
    std::fs::create_dir(&mcp_servers_dir)?;

    // Create a server config file
    let server_config = McpServerConfig {
        command: Some("managed".to_string()),
        args: vec![],
        env: None,
        r#type: None,
        url: None,
        headers: None,
        agpm_metadata: Some(AgpmMetadata {
            managed: true,
            source: Some("test".to_string()),
            version: Some("v1.0.0".to_string()),
            installed_at: "2024-01-01T00:00:00Z".to_string(),
            dependency_name: Some("agpm-server".to_string()),
        }),
    };
    let config_path = mcp_servers_dir.join("agpm-server.json");
    let json = serde_json::to_string_pretty(&server_config)?;
    std::fs::write(&config_path, json)?;

    // Add a user-managed server to settings
    let mut settings = ClaudeSettings::default();
    let mut servers = HashMap::new();
    servers.insert(
        "user-server".to_string(),
        McpServerConfig {
            command: Some("custom".to_string()),
            args: vec![],
            env: None,
            r#type: None,
            url: None,
            headers: None,
            agpm_metadata: None,
        },
    );
    settings.mcp_servers = Some(servers);

    // Update from directory
    settings.update_mcp_servers(&mcp_servers_dir)?;

    // Both servers should be present
    assert!(settings.mcp_servers.is_some());
    let servers = settings
        .mcp_servers
        .as_ref()
        .ok_or_else(|| anyhow::anyhow!("Expected mcp_servers to be present"))?;
    assert!(servers.contains_key("user-server"));
    assert!(servers.contains_key("agpm-server"));
    assert_eq!(servers.len(), 2);
    Ok(())
}

#[test]
fn test_update_mcp_servers_replaces_old_managed() -> Result<()> {
    let temp = tempdir()?;
    let mcp_servers_dir = temp.path().join("mcp-servers");
    std::fs::create_dir(&mcp_servers_dir)?;

    // Start with existing managed and user servers
    let mut settings = ClaudeSettings::default();
    let mut servers = HashMap::new();

    // User-managed server (should be preserved)
    servers.insert(
        "user-server".to_string(),
        McpServerConfig {
            command: Some("user-command".to_string()),
            args: vec![],
            env: None,
            r#type: None,
            url: None,
            headers: None,
            agpm_metadata: None,
        },
    );

    // Old AGPM-managed server (should be removed)
    servers.insert(
        "old-managed".to_string(),
        McpServerConfig {
            command: Some("old-command".to_string()),
            args: vec![],
            env: None,
            r#type: None,
            url: None,
            headers: None,
            agpm_metadata: Some(AgpmMetadata {
                managed: true,
                source: Some("old-source".to_string()),
                version: Some("v0.1.0".to_string()),
                installed_at: "2023-01-01T00:00:00Z".to_string(),
                dependency_name: Some("old-managed".to_string()),
            }),
        },
    );

    settings.mcp_servers = Some(servers);

    // Create new managed server config file
    let server_config = McpServerConfig {
        command: Some("new-managed".to_string()),
        args: vec![],
        env: None,
        r#type: None,
        url: None,
        headers: None,
        agpm_metadata: Some(AgpmMetadata {
            managed: true,
            source: Some("new-source".to_string()),
            version: Some("v1.0.0".to_string()),
            installed_at: "2024-01-01T00:00:00Z".to_string(),
            dependency_name: Some("new-managed".to_string()),
        }),
    };
    let config_path = mcp_servers_dir.join("new-managed.json");
    let json = serde_json::to_string_pretty(&server_config)?;
    std::fs::write(&config_path, json)?;

    // Update from directory
    settings.update_mcp_servers(&mcp_servers_dir)?;

    let servers = settings
        .mcp_servers
        .as_ref()
        .ok_or_else(|| anyhow::anyhow!("Expected mcp_servers to be present"))?;
    assert!(servers.contains_key("user-server")); // User server preserved
    assert!(servers.contains_key("new-managed")); // New managed server added
    assert!(!servers.contains_key("old-managed")); // Old managed server removed
    assert_eq!(servers.len(), 2);
    Ok(())
}

#[test]
fn test_update_mcp_servers_invalid_json_file() -> Result<()> {
    let temp = tempdir()?;
    let mcp_servers_dir = temp.path().join("mcp-servers");
    std::fs::create_dir(&mcp_servers_dir)?;

    // Create invalid JSON file
    let invalid_path = mcp_servers_dir.join("invalid.json");
    std::fs::write(&invalid_path, "invalid json {")?;

    let mut settings = ClaudeSettings::default();
    let result = settings.update_mcp_servers(&mcp_servers_dir);
    assert!(result.is_err());
    assert!(result.unwrap_err().to_string().contains("Failed to parse"));
    Ok(())
}

#[test]
fn test_update_mcp_servers_ignores_non_json_files() -> Result<()> {
    let temp = tempdir()?;
    let mcp_servers_dir = temp.path().join("mcp-servers");
    std::fs::create_dir(&mcp_servers_dir)?;

    // Create non-JSON file
    let txt_path = mcp_servers_dir.join("readme.txt");
    std::fs::write(&txt_path, "This is not a JSON file")?;

    // Create valid JSON file
    let server_config = McpServerConfig {
        command: Some("test".to_string()),
        args: vec![],
        env: None,
        r#type: None,
        url: None,
        headers: None,
        agpm_metadata: None,
    };
    let json_path = mcp_servers_dir.join("valid.json");
    let json = serde_json::to_string_pretty(&server_config)?;
    std::fs::write(&json_path, json)?;

    let mut settings = ClaudeSettings::default();
    settings.update_mcp_servers(&mcp_servers_dir)?;

    let servers = settings
        .mcp_servers
        .as_ref()
        .ok_or_else(|| anyhow::anyhow!("Expected mcp_servers to be present"))?;
    assert!(servers.contains_key("valid"));
    assert_eq!(servers.len(), 1);
    Ok(())
}

#[test]
fn test_settings_preserves_other_fields() -> Result<()> {
    let temp = tempdir()?;
    setup_project_root(temp.path())?;

    let settings_path = temp.path().join("settings.local.json");

    // Create a settings file with various fields
    let json = r#"{
        "permissions": {
            "allow": ["Bash(ls)"],
            "deny": []
        },
        "customField": "value",
        "mcpServers": {
            "test": {
                "command": "node",
                "args": []
            }
        }
    }"#;
    std::fs::write(&settings_path, json)?;

    // Load and save
    let settings = ClaudeSettings::load_or_default(&settings_path)?;
    assert!(settings.permissions.is_some());
    assert!(settings.mcp_servers.is_some());
    assert!(settings.other.contains_key("customField"));

    settings.save(&settings_path)?;

    // Reload and verify all fields preserved
    let reloaded = ClaudeSettings::load_or_default(&settings_path)?;
    assert!(reloaded.permissions.is_some());
    assert!(reloaded.mcp_servers.is_some());
    assert!(reloaded.other.contains_key("customField"));
    Ok(())
}

#[test]
fn test_claude_settings_save_backup() -> Result<()> {
    let temp = tempdir()?;
    setup_project_root(temp.path())?;

    let settings_path = temp.path().join("settings.local.json");
    let backup_path =
        temp.path().join(".agpm").join("backups").join("claude-code").join("settings.local.json");

    // Create initial settings
    let settings1 = ClaudeSettings::default();
    settings1.save(&settings_path)?;
    assert!(settings_path.exists());
    assert!(!backup_path.exists());

    // Save again to trigger backup
    let settings2 = ClaudeSettings {
        hooks: Some(serde_json::json!({"test": "hook"})),
        ..Default::default()
    };
    settings2.save(&settings_path)?;

    // Verify backup was created in agpm directory
    assert!(backup_path.exists());

    // Verify backup contains original content
    let backup_content: ClaudeSettings = crate::utils::read_json_file(&backup_path)?;
    assert!(backup_content.hooks.is_none());

    // Verify main file has new content
    let main_content: ClaudeSettings = crate::utils::read_json_file(&settings_path)?;
    assert!(main_content.hooks.is_some());
    Ok(())
}

#[test]
fn test_backup_fails_without_project_root() -> Result<()> {
    // Test that backup creation fails gracefully when no agpm.toml exists
    let temp = tempdir()?;
    // Deliberately NOT calling setup_project_root here

    let settings_path = temp.path().join("settings.local.json");

    // Create initial file
    fs::write(&settings_path, r#"{"test": "value"}"#)?;

    let settings = ClaudeSettings::default();
    let result = settings.save(&settings_path);

    // Should fail with helpful error message about missing project root
    assert!(result.is_err());
    let error_msg = result.unwrap_err().to_string();
    assert!(error_msg.contains("Failed to find project root") || error_msg.contains("agpm.toml"));
    Ok(())
}

#[test]
fn test_update_mcp_servers_preserves_user_servers() -> Result<()> {
    let temp = tempdir()?;
    let agpm_dir = temp.path().join(".claude").join("agpm");
    let mcp_servers_dir = agpm_dir.join("mcp-servers");
    std::fs::create_dir_all(&mcp_servers_dir)?;

    // Create server config files
    let server1 = McpServerConfig {
        command: Some("server1".to_string()),
        args: vec!["arg1".to_string()],
        env: None,
        r#type: None,
        url: None,
        headers: None,
        agpm_metadata: Some(AgpmMetadata {
            managed: true,
            source: Some("source1".to_string()),
            version: Some("v1.0.0".to_string()),
            installed_at: "2024-01-01T00:00:00Z".to_string(),
            dependency_name: None,
        }),
    };
    crate::utils::write_json_file(&mcp_servers_dir.join("server1.json"), &server1, true)?;

    // Create settings with existing user server
    let mut settings = ClaudeSettings::default();
    let mut servers = HashMap::new();
    servers.insert(
        "user-server".to_string(),
        McpServerConfig {
            command: Some("user".to_string()),
            args: vec![],
            env: None,
            r#type: None,
            url: None,
            headers: None,
            agpm_metadata: None,
        },
    );
    settings.mcp_servers = Some(servers);

    // Update from directory
    settings.update_mcp_servers(&mcp_servers_dir)?;

    // Verify both servers are present
    let servers = settings
        .mcp_servers
        .as_ref()
        .ok_or_else(|| anyhow::anyhow!("Expected mcp_servers to be present"))?;
    assert_eq!(servers.len(), 2);
    assert!(servers.contains_key("user-server"));
    assert!(servers.contains_key("server1"));

    // Verify server1 config matches
    let server1_config = servers
        .get("server1")
        .ok_or_else(|| anyhow::anyhow!("Expected server1 config to be present"))?;
    assert_eq!(server1_config.command, Some("server1".to_string()));
    assert_eq!(server1_config.args, vec!["arg1"]);
    Ok(())
}

#[test]
fn test_update_mcp_servers_nonexistent_dir() -> Result<()> {
    let temp = tempdir()?;
    let nonexistent_dir = temp.path().join("nonexistent");

    let mut settings = ClaudeSettings::default();
    settings.update_mcp_servers(&nonexistent_dir)?;
    Ok(())
}