agentty 0.14.7

Agentty is an ADE (Agentic Development Environment) for structured, controllable AI-assisted software development.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
//! Session refresh scheduling and post-reload view state restoration.

use std::collections::{HashMap, HashSet};
use std::time::Instant;

use ag_forge as forge;

use super::SESSION_REFRESH_INTERVAL;
use super::load::SessionLoadInput;
use crate::app::session::SessionError;
use crate::app::{AppServices, ProjectManager, SessionManager};
use crate::domain::session::{ForgeKind, ReviewRequest, SessionId};
use crate::presentation::app_mode::{AppMode, ConfirmationViewMode, HelpContext};

impl SessionManager {
    /// Reloads session rows when the metadata cache indicates a change.
    ///
    /// This is a low-frequency fallback safety poll; primary refreshes should
    /// come from explicit `RefreshSessions` events. Returns `true` when the
    /// poll detected persisted changes and refreshed the in-memory snapshots.
    pub async fn refresh_sessions_if_needed(
        &mut self,
        mode: &mut AppMode,
        projects: &ProjectManager,
        services: &AppServices,
    ) -> bool {
        if !self.is_session_refresh_due() {
            return false;
        }

        self.state.refresh_deadline = self.next_refresh_deadline();

        let Ok(sessions_metadata) = services.db().sessions().load_sessions_metadata().await else {
            return false;
        };
        let (sessions_row_count, sessions_updated_at_max) = sessions_metadata;
        if sessions_row_count == self.state.row_count
            && sessions_updated_at_max == self.state.updated_at_max
        {
            return false;
        }

        self.reload_sessions(mode, projects, services, Some(sessions_metadata))
            .await;

        true
    }

    /// Reloads sessions immediately, bypassing refresh deadline checks.
    pub(crate) async fn refresh_sessions_now(
        &mut self,
        mode: &mut AppMode,
        projects: &ProjectManager,
        services: &AppServices,
    ) {
        let sessions_metadata = services.db().sessions().load_sessions_metadata().await.ok();
        self.reload_sessions(mode, projects, services, sessions_metadata)
            .await;
        self.state.refresh_deadline = self.next_refresh_deadline();
    }

    /// Refreshes one linked review request and persists the latest normalized
    /// remote state.
    ///
    /// Linked review requests remain available for `Done` and `Canceled`
    /// sessions. When merge or cancel cleanup has removed the session
    /// worktree, this reconstructs the forge remote from the stored review
    /// request URL so refresh can continue without reviving legacy worktree
    /// behavior.
    ///
    /// # Errors
    /// Returns an error if the session is missing, has no linked review
    /// request, the forge remote cannot be resolved, the provider refresh
    /// fails, or persistence fails.
    pub async fn refresh_review_request(
        &mut self,
        services: &AppServices,
        session_id: &str,
    ) -> Result<ReviewRequest, SessionError> {
        let session_index = self.session_index_or_err(session_id)?;
        let Some(session) = self.state.sessions.get(session_index) else {
            return Err(SessionError::NotFound);
        };
        let linked_review_request = session.review_request.clone().ok_or_else(|| {
            SessionError::Workflow("Session has no linked review request".to_string())
        })?;
        let remote = self
            .review_request_remote(services, session, Some(&linked_review_request))
            .await?;
        let refreshed_summary = services
            .review_request_client()
            .refresh_review_request(remote, linked_review_request.summary.display_id.clone())
            .await
            .map_err(|error| SessionError::Workflow(error.detail_message()))?;
        self.store_review_request_summary(services, session_id, refreshed_summary)
            .await
    }

    /// Reloads sessions and derived statistics, then restores UI state.
    async fn reload_sessions(
        &mut self,
        mode: &mut AppMode,
        projects: &ProjectManager,
        services: &AppServices,
        sessions_metadata: Option<(i64, i64)>,
    ) {
        let selected_index = self.state.table_state.selected();
        let selected_session_id = selected_index
            .and_then(|index| self.state.sessions.get(index))
            .map(|session| session.id.clone());
        let detail_session_id = Self::mode_session_id(mode)
            .cloned()
            .or_else(|| selected_session_id.clone());
        let live_orchestration_progress = self
            .state
            .sessions
            .iter()
            .filter_map(|session| {
                session
                    .orchestration_progress
                    .as_deref()
                    .filter(|progress| progress.starts_with("Phase:"))
                    .map(|progress| (session.id.clone(), progress.to_string()))
            })
            .collect::<HashMap<_, _>>();

        let clock = services.clock();
        let fs_client = services.fs_client();
        let (mut sessions, stats_activity, session_worktree_availability) =
            Self::load_sessions_with_fs_client(
                SessionLoadInput {
                    active_project_id: projects.active_project_id(),
                    active_session_id: detail_session_id.as_deref(),
                    base: services.base_path(),
                    clock: clock.as_ref(),
                    db: services.db(),
                    fs_client: fs_client.as_ref(),
                    working_dir: projects.working_dir(),
                },
                self.state.handles_mut(),
            )
            .await;
        Self::preserve_live_orchestration_progress(&mut sessions, &live_orchestration_progress);
        self.state.replace_sessions(sessions);
        self.state
            .replace_session_worktree_availability(session_worktree_availability);
        self.refresh_session_branch_names().await;
        self.stats_activity = stats_activity;
        self.restore_table_selection(selected_session_id.as_deref(), selected_index);
        self.ensure_mode_session_exists(mode);

        let active_session_ids: HashSet<SessionId> = self
            .sessions()
            .iter()
            .map(|session| session.id.clone())
            .collect();
        self.state
            .retain_follow_up_task_positions(&active_session_ids);
        self.state.retain_session_branch_names(&active_session_ids);
        self.state.retain_session_git_statuses(&active_session_ids);
        self.worker_service_mut()
            .retain_active_workers(&active_session_ids);

        if let Some((sessions_row_count, sessions_updated_at_max)) = sessions_metadata {
            self.state.row_count = sessions_row_count;
            self.state.updated_at_max = sessions_updated_at_max;
        } else {
            self.update_sessions_metadata_cache(services).await;
        }
    }

    /// Returns the session whose detail is visible or being edited in the
    /// current application mode.
    fn mode_session_id(mode: &AppMode) -> Option<&SessionId> {
        match mode {
            AppMode::Confirmation {
                session_id: Some(session_id),
                ..
            }
            | AppMode::Prompt { session_id, .. }
            | AppMode::Question { session_id, .. }
            | AppMode::View { session_id, .. }
            | AppMode::Diff { session_id, .. }
            | AppMode::Help {
                context: HelpContext::View { session_id, .. } | HelpContext::Diff { session_id, .. },
                ..
            }
            | AppMode::ViewInfoPopup {
                restore_view: ConfirmationViewMode { session_id, .. },
                ..
            }
            | AppMode::LaunchConfigurationSelector {
                restore_view: ConfirmationViewMode { session_id, .. },
                ..
            }
            | AppMode::PublishBranchInput {
                restore_view: ConfirmationViewMode { session_id, .. },
                ..
            } => Some(session_id),
            _ => None,
        }
    }

    /// Keeps a coordinator-emitted task snapshot across metadata reloads while
    /// the persisted campaign remains active.
    fn preserve_live_orchestration_progress(
        sessions: &mut [crate::domain::session::Session],
        live_progress: &HashMap<SessionId, String>,
    ) {
        for session in sessions {
            if session.orchestration_progress.is_some()
                && let Some(progress) = live_progress.get(&session.id)
            {
                session.orchestration_progress = Some(progress.clone());
            }
        }
    }

    /// Returns `true` when periodic session refresh should run.
    fn is_session_refresh_due(&self) -> bool {
        self.state.clock.now_instant() >= self.state.refresh_deadline
    }

    /// Computes the next refresh deadline from the injected clock.
    fn next_refresh_deadline(&self) -> Instant {
        self.state.clock.now_instant() + SESSION_REFRESH_INTERVAL
    }

    /// Resolves forge remote metadata for one persisted review-request link.
    ///
    /// Active sessions prefer the live worktree remote. Terminal sessions can
    /// fall back to the stored review-request URL after worktree cleanup has
    /// removed the local checkout.
    pub(super) async fn review_request_remote(
        &self,
        services: &AppServices,
        session: &crate::domain::session::Session,
        review_request: Option<&ReviewRequest>,
    ) -> Result<forge::ForgeRemote, SessionError> {
        if let Ok(repo_url) = services.git_client().repo_url(session.folder.clone()).await {
            return services
                .review_request_client()
                .detect_remote(repo_url)
                .map(|remote| remote.with_command_working_directory(session.folder.clone()))
                .map_err(|error| SessionError::Workflow(error.detail_message()));
        }

        let repo_url = review_request
            .and_then(Self::review_request_repo_url)
            .ok_or_else(|| {
                SessionError::Workflow(
                    "Failed to resolve repository remote for linked review request".to_string(),
                )
            })?;

        services
            .review_request_client()
            .detect_remote(repo_url)
            .map_err(|error| SessionError::Workflow(error.detail_message()))
    }

    /// Derives a repository URL from one persisted review-request web URL.
    pub(crate) fn review_request_repo_url(review_request: &ReviewRequest) -> Option<String> {
        let web_url = review_request.summary.web_url.trim_end_matches('/');

        match review_request.summary.forge_kind {
            ForgeKind::GitHub => web_url
                .split_once("/pull/")
                .map(|(repo_url, _)| repo_url.to_string()),
            ForgeKind::GitLab => web_url
                .split_once("/-/merge_requests/")
                .or_else(|| web_url.split_once("/merge_requests/"))
                .map(|(repo_url, _)| repo_url.to_string()),
        }
    }

    /// Restores table selection after session list reload.
    fn restore_table_selection(
        &mut self,
        selected_session_id: Option<&str>,
        selected_index: Option<usize>,
    ) {
        if self.state.sessions.is_empty() {
            self.state.table_state.select(None);

            return;
        }

        if let Some(session_id) = selected_session_id
            && let Some(index) = self
                .sessions()
                .iter()
                .position(|session| session.id == session_id)
        {
            self.state.table_state.select(Some(index));

            return;
        }

        let restored_index = selected_index.map(|index| index.min(self.state.sessions.len() - 1));
        self.state.table_state.select(restored_index);
    }

    /// Switches back to list mode if the currently viewed session is missing.
    fn ensure_mode_session_exists(&self, mode: &mut AppMode) {
        let mode_session_id = Self::mode_session_id(mode);
        let Some(session_id) = mode_session_id else {
            return;
        };
        if self.session_index_for_id(session_id).is_none() {
            *mode = AppMode::List;
        }
    }

    /// Refreshes cached session metadata used by incremental list reloads.
    pub(crate) async fn update_sessions_metadata_cache(&mut self, services: &AppServices) {
        if let Ok((sessions_row_count, sessions_updated_at_max)) =
            services.db().sessions().load_sessions_metadata().await
        {
            self.state.row_count = sessions_row_count;
            self.state.updated_at_max = sessions_updated_at_max;
        }
    }
}

/// Outcome from syncing one session's review request state with the forge.
#[derive(Clone, Debug, Eq, PartialEq)]
pub(crate) enum SyncReviewRequestOutcome {
    /// The linked review request is still open.
    Open {
        /// Short display identifier (for example `#42`).
        display_id: String,
        /// Optional provider-specific status detail.
        status_summary: Option<String>,
    },
    /// The linked review request was merged upstream.
    Merged {
        /// Short display identifier (for example `#42`).
        display_id: String,
        /// Optional session branch `HEAD` hash observed during sync for
        /// continuation context.
        session_head_hash: Option<String>,
    },
    /// The linked review request was closed without merge.
    Closed {
        /// Short display identifier (for example `#42`).
        display_id: String,
    },
    /// No review request was found for the session branch.
    NoReviewRequest,
}

#[cfg(test)]
mod tests {
    use std::collections::HashMap;
    use std::path::PathBuf;
    use std::sync::{Arc, Mutex};
    use std::time::{Duration, Instant, SystemTime};

    use ag_forge as forge;
    use ag_git as git;
    use tempfile::tempdir;
    use tokio::sync::mpsc;

    use super::*;
    use crate::app::session::{Clock, SessionDefaults};
    use crate::app::{AppServices, SessionState};
    use crate::domain::agent::AgentKind;
    use crate::domain::input::InputState;
    use crate::domain::selection::SelectionState;
    use crate::domain::session::{
        ForgeKind, PublishBranchAction, ReviewRequest, ReviewRequestState, ReviewRequestSummary,
        Session, SessionHandles, Status,
    };
    use crate::infra::db::AppRepositories;
    use crate::infra::fs;
    use crate::presentation::app_mode::DiffPreview;
    use crate::presentation::help_action::ViewSessionState;

    /// Builds a filesystem mock that delegates directory checks to local disk.
    fn create_passthrough_mock_fs_client() -> fs::MockFsClient {
        let mut mock_fs_client = fs::MockFsClient::new();
        mock_fs_client
            .expect_create_dir_all()
            .times(0..)
            .returning(|_| Box::pin(async { Ok(()) }));
        mock_fs_client
            .expect_remove_dir_all()
            .times(0..)
            .returning(|_| Box::pin(async { Ok(()) }));
        mock_fs_client
            .expect_read_file()
            .times(0..)
            .returning(|path| {
                Box::pin(async move { tokio::fs::read(path).await.map_err(fs::FsError::from) })
            });
        mock_fs_client
            .expect_remove_file()
            .times(0..)
            .returning(|_| Box::pin(async { Ok(()) }));
        mock_fs_client
            .expect_is_dir()
            .times(0..)
            .returning(|path| path.is_dir());

        mock_fs_client
    }

    /// Persists one session row that matches the in-memory fixture.
    async fn database_with_session(session: &Session) -> AppRepositories {
        let database = AppRepositories::in_memory().await.expect("db should open");
        let project_id = database
            .projects()
            .upsert_project("/tmp/project", Some("main".to_string()))
            .await
            .expect("failed to upsert project");
        database
            .sessions()
            .insert_session(
                &session.id,
                session.agent.model().as_str(),
                &session.base_branch,
                &session.status.to_string(),
                project_id,
            )
            .await
            .expect("failed to insert session");
        if let Some(review_request) = &session.review_request {
            database
                .reviews()
                .update_session_review_request(&session.id, Some(review_request.clone()))
                .await
                .expect("failed to persist session review request");
        }

        database
    }

    /// Builds app services with caller-provided git and forge boundaries.
    fn test_services(
        database: &AppRepositories,
        git_client: Arc<dyn git::GitClient>,
        review_request_client: Arc<dyn forge::ReviewRequestClient>,
    ) -> AppServices {
        let (event_tx, _event_rx) = mpsc::unbounded_channel();

        AppServices::new_with_agent_clis(
            PathBuf::from("/tmp/agentty-tests"),
            Arc::new(crate::infra::clock::RealClock),
            event_tx,
            crate::app::service::AppServiceDeps {
                app_server_client_override: Some(crate::test_support::mock_app_server()),
                available_agent_kinds: crate::domain::agent::AgentKind::ALL.to_vec(),
                clipboard_image_client_override: None,
                fs_client: Arc::new(create_passthrough_mock_fs_client()),
                git_client,
                one_shot_client_override: None,
                personality_catalog_client_override: None,
                repositories: database.clone(),
                review_request_client,
            },
            crate::domain::agent::AgentCliInfo::from_kinds(crate::domain::agent::AgentKind::ALL),
        )
    }

    /// Builds one session manager with deterministic time and one session.
    fn session_manager_with_session(clock: Arc<dyn Clock>, session: Session) -> SessionManager {
        let mut handles = HashMap::new();
        handles.insert(
            session.id.clone(),
            SessionHandles::new_with_transcript(
                session.status,
                session.transcript.clone().unwrap_or_default(),
            ),
        );

        SessionManager::new(
            SessionDefaults {
                model: AgentKind::Antigravity.default_model(),
            },
            Arc::new(git::MockGitClient::new()),
            SessionState::new(
                handles,
                vec![session],
                SelectionState::default(),
                clock,
                1,
                0,
            ),
            Vec::new(),
        )
    }

    /// Builds one session fixture with optional linked review-request data.
    fn test_session(
        folder: PathBuf,
        review_request: Option<ReviewRequest>,
        status: Status,
    ) -> Session {
        crate::test_support::SessionFixtureBuilder::new()
            .folder(folder)
            .prompt("Implement forge review support")
            .review_request(review_request)
            .status(status)
            .title(Some("Add forge review support".to_string()))
            .build()
    }

    /// Builds one normalized GitHub review-request summary.
    fn review_request_summary(display_id: &str, state: ReviewRequestState) -> ReviewRequestSummary {
        ReviewRequestSummary {
            display_id: display_id.to_string(),
            forge_kind: ForgeKind::GitHub,
            source_branch: "wt/session-".to_string(),
            state,
            status_summary: Some("Checks pending".to_string()),
            target_branch: "main".to_string(),
            title: "Add forge review support".to_string(),
            web_url: format!(
                "https://github.com/agentty-xyz/agentty/pull/{}",
                &display_id[1..]
            ),
        }
    }

    #[tokio::test]
    async fn review_request_remote_uses_live_worktree_for_detected_remote() {
        // Arrange
        let session_folder = PathBuf::from("/tmp/session");
        let session = test_session(session_folder.clone(), None, Status::Review);
        let database = database_with_session(&session).await;
        let now = Instant::now();
        let fake_clock = Arc::new(FakeClock::new(now, SystemTime::UNIX_EPOCH));
        let clock: Arc<dyn Clock> = fake_clock;
        let session_manager = session_manager_with_session(clock, session);
        let mut mock_git_client = git::MockGitClient::new();
        mock_git_client
            .expect_repo_url()
            .once()
            .withf({
                let session_folder = session_folder.clone();
                move |candidate_folder| candidate_folder == &session_folder
            })
            .returning(|_| {
                Box::pin(async { Ok("https://github.com/agentty-xyz/agentty".to_string()) })
            });
        let mut mock_review_request_client = forge::MockReviewRequestClient::new();
        mock_review_request_client
            .expect_detect_remote()
            .once()
            .withf(|repo_url| repo_url == "https://github.com/agentty-xyz/agentty")
            .returning(|_| {
                Ok(forge::ForgeRemote {
                    command_working_directory: None,
                    forge_kind: ForgeKind::GitHub,
                    host: "github.com".to_string(),
                    namespace: "agentty-xyz".to_string(),
                    project: "agentty".to_string(),
                    repo_url: "https://github.com/agentty-xyz/agentty".to_string(),
                    web_url: "https://github.com/agentty-xyz/agentty".to_string(),
                })
            });
        let services = test_services(
            &database,
            Arc::new(mock_git_client),
            Arc::new(mock_review_request_client),
        );

        // Act
        let remote = session_manager
            .review_request_remote(&services, &session_manager.state.sessions[0], None)
            .await
            .expect("remote should resolve");

        // Assert
        assert_eq!(remote.command_working_directory, Some(session_folder));
        assert_eq!(remote.forge_kind, ForgeKind::GitHub);
    }

    #[test]
    fn review_request_repo_url_derives_gitlab_project_url() {
        // Arrange
        let review_request = ReviewRequest {
            last_refreshed_at: 10,
            summary: ReviewRequestSummary {
                display_id: "!42".to_string(),
                forge_kind: ForgeKind::GitLab,
                source_branch: "wt/session-".to_string(),
                state: ReviewRequestState::Open,
                status_summary: Some("Draft".to_string()),
                target_branch: "main".to_string(),
                title: "Add forge review support".to_string(),
                web_url: "https://gitlab.com/agentty-xyz/agentty/-/merge_requests/42".to_string(),
            },
        };

        // Act
        let repo_url = SessionManager::review_request_repo_url(&review_request);

        // Assert
        assert_eq!(
            repo_url.as_deref(),
            Some("https://gitlab.com/agentty-xyz/agentty")
        );
    }

    #[tokio::test]
    async fn test_refresh_review_request_updates_done_session_from_stored_link_when_worktree_is_missing()
     {
        // Arrange
        let MissingWorktreeReviewRefreshFixture {
            database,
            services,
            mut session_manager,
        } = missing_worktree_review_refresh_fixture().await;

        // Act
        let review_request = session_manager
            .refresh_review_request(&services, "session-id")
            .await
            .expect("linked review request should refresh");
        let persisted_row = database
            .sessions()
            .load_sessions()
            .await
            .expect("failed to load session rows")
            .into_iter()
            .find(|row| row.id == "session-id")
            .expect("session row should exist");

        // Assert
        assert_eq!(review_request.last_refreshed_at, 77);
        assert_eq!(review_request.summary.state, ReviewRequestState::Merged);
        assert_eq!(
            session_manager.state.sessions[0]
                .review_request
                .as_ref()
                .map(|review_request| review_request.summary.state),
            Some(ReviewRequestState::Merged)
        );
        assert_eq!(
            persisted_row
                .review_request
                .as_ref()
                .map(|row| row.state.as_str()),
            Some("Merged")
        );
    }

    /// Test fixture for refreshing a stored review request after its worktree
    /// has been deleted.
    struct MissingWorktreeReviewRefreshFixture {
        /// Repository bundle containing the linked review request session.
        database: AppRepositories,
        /// App services wired with git and forge mocks.
        services: AppServices,
        /// Session manager seeded with the linked session.
        session_manager: SessionManager,
    }

    /// Builds the missing-worktree review refresh fixture.
    async fn missing_worktree_review_refresh_fixture() -> MissingWorktreeReviewRefreshFixture {
        let temp_dir = tempdir().expect("failed to create temp dir");
        let missing_folder = temp_dir.path().join("missing-session-folder");
        let linked_review_request = ReviewRequest {
            last_refreshed_at: 12,
            summary: review_request_summary("#42", ReviewRequestState::Open),
        };
        let session = test_session(
            missing_folder.clone(),
            Some(linked_review_request),
            Status::Done,
        );
        let database = database_with_session(&session).await;
        let now = Instant::now();
        let fake_clock = Arc::new(FakeClock::new(
            now,
            SystemTime::UNIX_EPOCH + Duration::from_secs(77),
        ));
        let clock: Arc<dyn Clock> = fake_clock;
        let session_manager = session_manager_with_session(clock, session);
        let remote = forge::ForgeRemote {
            command_working_directory: None,
            forge_kind: ForgeKind::GitHub,
            host: "github.com".to_string(),
            namespace: "agentty-xyz".to_string(),
            project: "agentty".to_string(),
            repo_url: "https://github.com/agentty-xyz/agentty".to_string(),
            web_url: "https://github.com/agentty-xyz/agentty".to_string(),
        };
        let refreshed_summary = ReviewRequestSummary {
            display_id: "#42".to_string(),
            forge_kind: ForgeKind::GitHub,
            source_branch: "wt/session-".to_string(),
            state: ReviewRequestState::Merged,
            status_summary: Some("Approved and merged".to_string()),
            target_branch: "main".to_string(),
            title: "Add forge review support".to_string(),
            web_url: "https://github.com/agentty-xyz/agentty/pull/42".to_string(),
        };
        let mut mock_git_client = git::MockGitClient::new();
        mock_git_client
            .expect_repo_url()
            .times(1)
            .withf({
                let missing_folder = missing_folder.clone();
                move |candidate_folder| candidate_folder == &missing_folder
            })
            .returning(|_| {
                Box::pin(async {
                    Err(ag_git::GitError::Io(std::io::Error::new(
                        std::io::ErrorKind::NotFound,
                        "missing worktree",
                    )))
                })
            });
        let mut mock_review_request_client = forge::MockReviewRequestClient::new();
        mock_review_request_client
            .expect_detect_remote()
            .times(1)
            .withf(|repo_url| repo_url == "https://github.com/agentty-xyz/agentty")
            .returning({
                let remote = remote.clone();
                move |_| Ok(remote.clone())
            });
        mock_review_request_client
            .expect_refresh_review_request()
            .times(1)
            .withf(move |candidate_remote, display_id| {
                candidate_remote == &remote && display_id == "#42"
            })
            .returning(move |_, _| {
                let refreshed_summary = refreshed_summary.clone();

                Box::pin(async move { Ok(refreshed_summary) })
            });
        let services = test_services(
            &database,
            Arc::new(mock_git_client),
            Arc::new(mock_review_request_client),
        );

        MissingWorktreeReviewRefreshFixture {
            database,
            services,
            session_manager,
        }
    }

    #[test]
    fn test_is_session_refresh_due_returns_false_before_deadline() {
        // Arrange
        let now = Instant::now();
        let fake_clock = Arc::new(FakeClock::new(now, SystemTime::UNIX_EPOCH));
        let clock: Arc<dyn Clock> = fake_clock;
        let session_manager = session_manager_fixture(clock);

        // Act
        let refresh_due = session_manager.is_session_refresh_due();
        let wall_clock = session_manager.state().clock.now_system_time();

        // Assert
        assert!(!refresh_due);
        assert_eq!(wall_clock, SystemTime::UNIX_EPOCH);
    }

    #[test]
    fn preserve_live_orchestration_progress_keeps_active_board_and_respects_terminal_clear() {
        // Arrange
        let mut session = test_session(PathBuf::from("/tmp/session"), None, Status::Review);
        session.orchestration_progress = Some("2 running, 0 waiting on you".to_string());
        let live_progress = HashMap::from([(
            session.id.clone(),
            "Phase: Running\n- protocol [protocol]: running".to_string(),
        )]);

        // Act
        SessionManager::preserve_live_orchestration_progress(
            std::slice::from_mut(&mut session),
            &live_progress,
        );
        let active_progress = session.orchestration_progress.clone();
        session.orchestration_progress = None;
        SessionManager::preserve_live_orchestration_progress(
            std::slice::from_mut(&mut session),
            &live_progress,
        );

        // Assert
        assert_eq!(
            active_progress.as_deref(),
            Some("Phase: Running\n- protocol [protocol]: running")
        );
        assert!(session.orchestration_progress.is_none());
    }

    #[test]
    fn test_is_session_refresh_due_returns_true_at_deadline() {
        // Arrange
        let now = Instant::now();
        let fake_clock = Arc::new(FakeClock::new(now, SystemTime::UNIX_EPOCH));
        let clock: Arc<dyn Clock> = fake_clock.clone();
        let session_manager = session_manager_fixture(clock);
        fake_clock.set_now_instant(now + SESSION_REFRESH_INTERVAL);

        // Act
        let refresh_due = session_manager.is_session_refresh_due();

        // Assert
        assert!(refresh_due);
    }

    #[test]
    fn mode_session_id_uses_view_info_popup_restore_view() {
        // Arrange
        let mode = AppMode::ViewInfoPopup {
            is_loading: false,
            loading_label: "Refreshing review request...".to_string(),
            message: "Review request refreshed.".to_string(),
            restore_view: ConfirmationViewMode {
                scroll_offset: Some(2),
                session_id: "popup-session".into(),
            },
            title: "Review request refreshed".to_string(),
        };

        // Act
        let session_id = SessionManager::mode_session_id(&mode);

        // Assert
        assert_eq!(session_id.map(SessionId::as_str), Some("popup-session"));
    }

    #[test]
    fn mode_session_id_uses_view_help_context() {
        // Arrange
        let mode = AppMode::Help {
            context: HelpContext::View {
                can_fork_session: false,
                can_merge_session_branch: false,
                can_mutate_session_branch: false,
                can_open_worktree: false,
                can_rebase_session_branch: false,
                can_reply_to_session: false,
                can_start_staged_session: false,
                can_view_review_comments: false,
                publish_pull_request_action: None,
                scroll_offset: Some(2),
                session_id: "help-session".into(),
                session_state: ViewSessionState::Review,
            },
            scroll_offset: 0,
        };

        // Act
        let session_id = SessionManager::mode_session_id(&mode);

        // Assert
        assert_eq!(session_id.map(SessionId::as_str), Some("help-session"));
    }

    #[test]
    fn mode_session_id_uses_diff_and_session_overlay_contexts() {
        // Arrange
        let modes = [
            AppMode::Diff {
                diff: String::new(),
                file_explorer_selected_index: 0,
                preview: DiffPreview::default(),
                review_comments: None,
                restore: None,
                scroll_cache: None,
                scroll_offset: 0,
                session_id: "diff-session".into(),
            },
            AppMode::LaunchConfigurationSelector {
                commands: vec!["cargo test".to_string()],
                restore_view: ConfirmationViewMode {
                    scroll_offset: None,
                    session_id: "launch-session".into(),
                },
                selected_command_index: 0,
            },
            AppMode::PublishBranchInput {
                default_branch_name: "wt/session".to_string(),
                input: InputState::default(),
                locked_upstream_ref: None,
                publish_branch_action: PublishBranchAction::Push,
                restore_view: ConfirmationViewMode {
                    scroll_offset: None,
                    session_id: "publish-session".into(),
                },
            },
        ];

        // Act
        let session_ids = modes
            .iter()
            .map(SessionManager::mode_session_id)
            .map(|session_id| session_id.map(SessionId::as_str))
            .collect::<Vec<_>>();

        // Assert
        assert_eq!(
            session_ids,
            [
                Some("diff-session"),
                Some("launch-session"),
                Some("publish-session"),
            ]
        );
    }

    #[test]
    fn test_ensure_mode_session_exists_closes_missing_diff_comments() {
        // Arrange
        let now = Instant::now();
        let clock: Arc<dyn Clock> = Arc::new(FakeClock::new(now, SystemTime::UNIX_EPOCH));
        let session_manager = session_manager_fixture(clock);
        let mut mode = AppMode::Diff {
            diff: String::new(),
            file_explorer_selected_index: 0,
            preview: DiffPreview::default(),
            review_comments: Some(crate::presentation::app_mode::DiffReviewComments::loading(
                1,
            )),
            restore: None,
            scroll_cache: None,
            session_id: "missing-session".into(),
            scroll_offset: 0,
        };

        // Act
        session_manager.ensure_mode_session_exists(&mut mode);

        // Assert
        assert!(matches!(mode, AppMode::List));
    }

    /// Builds a session manager with deterministic time and empty state.
    fn session_manager_fixture(clock: Arc<dyn Clock>) -> SessionManager {
        let git_client: Arc<dyn git::GitClient> = Arc::new(git::MockGitClient::new());

        SessionManager::new(
            SessionDefaults {
                model: AgentKind::Antigravity.default_model(),
            },
            git_client,
            SessionState::new(
                HashMap::new(),
                Vec::new(),
                SelectionState::default(),
                clock,
                0,
                0,
            ),
            Vec::new(),
        )
    }

    /// Builds an empty project manager rooted at a temporary working directory.
    fn empty_project_manager(working_dir: PathBuf) -> ProjectManager {
        ProjectManager::new(
            1,
            "project".to_string(),
            Some("main".to_string()),
            None,
            Vec::new(),
            working_dir,
        )
    }

    #[tokio::test]
    async fn refresh_sessions_if_needed_skips_db_call_before_deadline_and_preserves_deadline() {
        // Arrange
        let database = AppRepositories::in_memory().await.expect("db should open");
        let now = Instant::now();
        let fake_clock = Arc::new(FakeClock::new(now, SystemTime::UNIX_EPOCH));
        let clock: Arc<dyn Clock> = fake_clock;
        let mut session_manager = session_manager_fixture(clock);
        let original_deadline = session_manager.state.refresh_deadline;
        let services = test_services(
            &database,
            Arc::new(git::MockGitClient::new()),
            Arc::new(forge::MockReviewRequestClient::new()),
        );
        let temp_dir = tempdir().expect("temp dir should be created");
        let projects = empty_project_manager(temp_dir.path().to_path_buf());
        let mut mode = AppMode::List;

        // Act
        session_manager
            .refresh_sessions_if_needed(&mut mode, &projects, &services)
            .await;

        // Assert
        assert_eq!(session_manager.state.refresh_deadline, original_deadline);
        assert_eq!(session_manager.state.row_count, 0);
        assert_eq!(session_manager.state.updated_at_max, 0);
    }

    #[tokio::test]
    async fn refresh_sessions_if_needed_advances_deadline_and_skips_reload_when_metadata_unchanged()
    {
        // Arrange
        let database = AppRepositories::in_memory().await.expect("db should open");
        let now = Instant::now();
        let fake_clock = Arc::new(FakeClock::new(now, SystemTime::UNIX_EPOCH));
        let clock: Arc<dyn Clock> = fake_clock.clone();
        let mut session_manager = session_manager_fixture(clock);
        let services = test_services(
            &database,
            Arc::new(git::MockGitClient::new()),
            Arc::new(forge::MockReviewRequestClient::new()),
        );
        let temp_dir = tempdir().expect("temp dir should be created");
        let projects = empty_project_manager(temp_dir.path().to_path_buf());
        let mut mode = AppMode::List;
        let original_deadline = session_manager.state.refresh_deadline;
        fake_clock.set_now_instant(now + SESSION_REFRESH_INTERVAL);

        // Act
        session_manager
            .refresh_sessions_if_needed(&mut mode, &projects, &services)
            .await;

        // Assert
        assert!(session_manager.state.refresh_deadline > original_deadline);
        assert_eq!(session_manager.state.row_count, 0);
        assert_eq!(session_manager.state.updated_at_max, 0);
    }

    #[tokio::test]
    async fn refresh_sessions_if_needed_reloads_sessions_when_metadata_row_count_changed() {
        // Arrange
        let session = test_session(PathBuf::from("/tmp/session"), None, Status::Done);
        let database = database_with_session(&session).await;
        let now = Instant::now();
        let fake_clock = Arc::new(FakeClock::new(now, SystemTime::UNIX_EPOCH));
        let clock: Arc<dyn Clock> = fake_clock.clone();
        let mut session_manager = session_manager_fixture(clock);
        let services = test_services(
            &database,
            Arc::new(git::MockGitClient::new()),
            Arc::new(forge::MockReviewRequestClient::new()),
        );
        let temp_dir = tempdir().expect("temp dir should be created");
        let projects = empty_project_manager(temp_dir.path().to_path_buf());
        let mut mode = AppMode::List;
        fake_clock.set_now_instant(now + SESSION_REFRESH_INTERVAL);

        // Act
        session_manager
            .refresh_sessions_if_needed(&mut mode, &projects, &services)
            .await;

        // Assert
        assert_eq!(session_manager.state.row_count, 1);
        assert_eq!(session_manager.state.sessions.len(), 1);
        assert_eq!(session_manager.state.sessions[0].id, "session-id");
    }

    /// Test clock implementation with mutable `Instant` and `SystemTime`.
    struct FakeClock {
        instant: Mutex<Instant>,
        system_time: Mutex<SystemTime>,
    }

    impl FakeClock {
        /// Creates a fake clock seeded with deterministic wall-clock values.
        fn new(instant: Instant, system_time: SystemTime) -> Self {
            Self {
                instant: Mutex::new(instant),
                system_time: Mutex::new(system_time),
            }
        }

        /// Overrides the fake monotonic instant used by refresh checks.
        fn set_now_instant(&self, instant: Instant) {
            let mut current_instant = self
                .instant
                .lock()
                .expect("fake clock instant lock should not be poisoned");
            *current_instant = instant;
        }
    }

    impl Clock for FakeClock {
        fn now_instant(&self) -> Instant {
            *self
                .instant
                .lock()
                .expect("fake clock instant lock should not be poisoned")
        }

        fn now_system_time(&self) -> SystemTime {
            *self
                .system_time
                .lock()
                .expect("fake clock system-time lock should not be poisoned")
        }
    }
}