agentd-core 1.3.4

// SPDX-License-Identifier: AGPL-3.0-only
//! **Principals, roles and authorization**: every A2A caller is resolved to a
//! principal (identity from mTLS SAN / bearer subject / AAuth agent id) with a
//! role (`operator | user | agent | anonymous`), a set of granted tool
//! patterns, and optional per-principal quotas. The authorization matrix —
//! which methods and commands a role may call — is decided here; the served
//! surface calls [`Resolver::resolve`] then [`Principal::may`]. Anything that
//! does not match a rule lands on the anonymous principal, which may call
//! nothing, so a caller agentd cannot identify gets no surface at all.

use crate::config::v2::{self, Role};
use crate::sec::secret;
use serde_json::{Value, json};

/// A resolved caller.
#[derive(Debug, Clone, PartialEq)]
pub struct Principal {
    /// A stable id for logs/audit/context (`operator`, `user:<sub>`, `agent:<id>`).
    pub id: String,
    pub role: Role,
    /// Explicit tool-name grants (patterns) beyond the role defaults.
    pub grants: Vec<String>,
    /// The rate quota (`"<burst>/<per>s"`) and budget scope key, if any.
    pub rate: Option<String>,
    pub budget: Option<v2::Budget>,
    /// Operator-declared attributes that travel with everything this
    /// principal causes (the run, the MCP `_meta`, the audit line).
    pub labels: std::collections::BTreeMap<String, String>,
}

impl Principal {
    pub fn anonymous() -> Principal {
        Principal {
            id: "anonymous".into(),
            role: Role::Anonymous,
            grants: Vec::new(),
            rate: None,
            budget: None,
            labels: Default::default(),
        }
    }

    pub fn is_operator(&self) -> bool {
        self.role == Role::Operator
    }
    pub fn is_anonymous(&self) -> bool {
        self.role == Role::Anonymous
    }

    /// May this principal invoke A2A method `method`?
    /// `op` is the command tool name for a command DataPart (else `None`).
    ///
    /// The matrix is deny-by-default: anonymous callers get nothing, operators
    /// get everything, and every other role is limited to the named read/task
    /// methods below — an unrecognised method falls through to `false`.
    pub fn may(&self, method: &str, op: Option<&str>) -> bool {
        match self.role {
            Role::Anonymous => false,
            Role::Operator => true,
            _ => match method {
                // The read/task methods every non-anonymous role may use on its
                // own conversations/tasks (ownership is enforced at the object).
                // `SubscribeToEvents` is principal-scoped at the feed itself,
                // so any non-anonymous role may attach and will only see the
                // frames belonging to it.
                "SendMessage"
                | "SendStreamingMessage"
                | "GetTask"
                | "CancelTask"
                | "ListTasks"
                | "SubscribeToTask"
                | "SubscribeToEvents"
                // The push-notification family is scoped to the caller's own
                // tasks the same way `GetTask` is — ownership is enforced at
                // the task, so any named caller may manage webhooks on what it
                // started.
                | "CreateTaskPushNotificationConfig"
                | "GetTaskPushNotificationConfig"
                | "ListTaskPushNotificationConfigs"
                | "DeleteTaskPushNotificationConfig"
                // The extended card is the *authenticated* card: any named
                // caller may read it, and it is scoped to what they may run.
                | "GetExtendedAgentCard" => match op {
                    None => true, // natural language / streaming
                    Some(tool) => self.may_command(tool),
                },
                // Operator admin family is operator-only (handled by role above).
                m if m.starts_with("a2a.") && is_admin(m) => false,
                _ => false,
            },
        }
    }

    /// May this principal run command tool `tool`?
    pub fn may_command(&self, tool: &str) -> bool {
        if self.role == Role::Anonymous {
            return false;
        }
        if tool == "status" || tool == "interface.info" {
            // Liveness and capability discovery: a named caller must be able to
            // learn whether agentd is up and what interface it offers before it
            // can ask for anything else, so these need no grant. Neither leaks
            // work product, and the interface gate still applies at the op.
            return true;
        }
        if self
            .grants
            .iter()
            .any(|p| crate::registry::pattern_matches(p, tool))
        {
            return true;
        }
        // Role defaults for command ops. The debug reads
        // (`conversation.get`/`run.get`) are owner-scoped at the object; the
        // log ring (`debug.events`) stays operator-only, because it spans every
        // principal's activity and cannot be scoped to the caller.
        match self.role {
            Role::Operator => true,
            Role::User => matches!(
                tool,
                "workflow.run"
                    | "workflow.status"
                    | "workflow.cancel"
                    | "subagent.send"
                    | "subagent.status"
                    | "plan.get"
                    | "ask_human"
                    | "conversation.get"
                    | "run.get"
            ),
            Role::Agent => matches!(tool, "workflow.run" | "workflow.status"),
            Role::Anonymous => false,
        }
    }

    /// The governor scope this principal's spend is charged to.
    pub fn scope_key(&self) -> String {
        scope_key_for(&self.id)
    }
}

/// **Who must answer a gate.** An `ask_human`/`human` `to:` declaration.
///
/// An addressee is what makes a gate's record TRUE: "the finance lead
/// approved this refund" is only worth writing down if someone else could not
/// have satisfied it. Every declared condition must hold, so adding one always
/// narrows — the same direction as `security.policies` matching, and for the
/// same reason: an operator tightening a gate should never widen it by
/// accident.
///
/// Declared either as a bare principal-id glob:
///
/// ```yaml
/// to: "*@finance.acme.example"
/// ```
///
/// or structurally, when identity is better described than enumerated:
///
/// ```yaml
/// to: {role: user, labels: {team: finance}}
/// ```
///
/// Labels are the durable form — people change, teams do not — and they come
/// from `a2a.principals[].labels`, which is operator-declared and closed.
#[derive(Debug, Clone, Default, PartialEq)]
pub struct Addressee {
    /// Principal-id glob (`*` suffix, or exact).
    pub id: Option<String>,
    pub role: Option<Role>,
    /// Every pair must be present on the principal with that value.
    pub labels: std::collections::BTreeMap<String, String>,
}

impl Addressee {
    /// Parse a `to:` declaration. A string is an id glob; an object names any
    /// of `id`, `role`, `labels`.
    pub fn parse(v: &Value) -> Result<Addressee, String> {
        match v {
            Value::String(s) if !s.trim().is_empty() => Ok(Addressee {
                id: Some(s.trim().to_string()),
                ..Default::default()
            }),
            Value::String(_) => Err("`to` must not be empty".into()),
            Value::Object(o) => {
                for k in o.keys() {
                    if !["id", "role", "labels"].contains(&k.as_str()) {
                        return Err(format!("unknown `to` field {k:?} (want id|role|labels)"));
                    }
                }
                let role = match o.get("role").and_then(Value::as_str) {
                    None => None,
                    Some("operator") => Some(Role::Operator),
                    Some("user") => Some(Role::User),
                    Some("agent") => Some(Role::Agent),
                    // Addressing anonymous is not a mistake worth allowing: an
                    // anonymous caller is precisely the one whose identity
                    // nothing vouches for, so a gate "answered by anonymous"
                    // records nothing at all.
                    Some("anonymous") => {
                        return Err("`to.role: anonymous` names nobody — a gate answered by an                                     unidentified caller records nothing"
                            .into());
                    }
                    Some(other) => {
                        return Err(format!(
                            "unknown `to.role` {other:?} (want operator|user|agent)"
                        ));
                    }
                };
                let mut labels = std::collections::BTreeMap::new();
                if let Some(m) = o.get("labels") {
                    let Some(m) = m.as_object() else {
                        return Err("`to.labels` must be an object of string values".into());
                    };
                    for (k, v) in m {
                        let Some(v) = v.as_str() else {
                            return Err(format!("`to.labels.{k}` must be a string"));
                        };
                        labels.insert(k.clone(), v.to_string());
                    }
                }
                let id = o
                    .get("id")
                    .and_then(Value::as_str)
                    .map(|s| s.trim().to_string())
                    .filter(|s| !s.is_empty());
                let a = Addressee { id, role, labels };
                if a.is_empty() {
                    // An addressee matching everyone is not an addressee, and
                    // silently accepting one would make a gate look routed
                    // when it is not.
                    return Err("`to` names nobody — give an id, a role or labels".into());
                }
                Ok(a)
            }
            _ => Err("`to` must be a principal-id glob or {id, role, labels}".into()),
        }
    }

    fn is_empty(&self) -> bool {
        self.id.is_none() && self.role.is_none() && self.labels.is_empty()
    }

    /// Whether this principal is who the gate is waiting for.
    pub fn matches(&self, p: &Principal) -> bool {
        // This module's own `glob`, not the registry's tool-name matcher: a
        // principal id is domain-shaped (`user:alice@acme.example`), so the
        // useful pattern is a SUFFIX (`*@finance.example`) — which the tool
        // matcher cannot express, since it only strips a trailing star.
        // Widening that one to suit this would widen every tool grant with it.
        if let Some(pat) = &self.id
            && !glob(pat, &p.id)
        {
            return false;
        }
        if let Some(r) = self.role
            && p.role != r
        {
            return false;
        }
        self.labels
            .iter()
            .all(|(k, v)| p.labels.get(k).map(String::as_str) == Some(v.as_str()))
    }

    /// A human-readable rendering, for the question, the task and the refusal
    /// — a gate that will not accept your answer has to say whose it wants.
    pub fn describe(&self) -> String {
        let mut parts = Vec::new();
        if let Some(id) = &self.id {
            parts.push(id.clone());
        }
        if let Some(r) = self.role {
            parts.push(format!("role {}", format!("{r:?}").to_lowercase()));
        }
        for (k, v) in &self.labels {
            parts.push(format!("{k}={v}"));
        }
        parts.join(", ")
    }
}

/// The governor scope key for a principal id. One source for the format,
/// because the runtime carries only the id once work is under way while the
/// A2A layer still holds the whole `Principal`.
pub fn scope_key_for(id: &str) -> String {
    format!("principal:{id}")
}

/// The admin methods (operator-only).
pub fn is_admin(method: &str) -> bool {
    matches!(
        bare(method).as_str(),
        "a2a.drain"
            | "a2a.lameduck"
            | "a2a.pause"
            | "a2a.resume"
            | "a2a.cancel"
            | "drain"
            | "lameduck"
            | "pause"
            | "resume"
            | "cancel"
    )
}

/// The method name folded for matching, owned.
///
/// Owned rather than `&'static str` because the only way to hand a lowercased
/// copy back as `'static` is `String::leak`, and `m` is the `method` member of
/// a JSON-RPC request: remote input, unbounded in length, and reached *before*
/// the caller is known to be anybody — an `Authorization: Bearer junk` header
/// resolves to the anonymous principal rather than a 401, and every request
/// passes through [`is_admin`] on its way to being refused. One leak per
/// request with an attacker-chosen name is an unbounded RSS climb driven from
/// off the box, so nothing here may outlive the call.
fn bare(m: &str) -> String {
    m.strip_prefix("a2a.")
        .map(|_| m)
        .unwrap_or(m)
        .to_ascii_lowercase()
}

/// What the transport learned about the caller.
#[derive(Debug, Clone, Default)]
pub struct CallerIdentity {
    /// The verified client-cert subject/SANs (mTLS).
    pub sans: Vec<String>,
    pub subject: Option<String>,
    /// A verified bearer subject (post token check), if the transport resolved it.
    pub bearer_ref: Option<String>,
    /// The verified AAuth agent id, set only when an inbound AAuth verifier
    /// established one; an `aauth_agent` principal rule matches against it.
    pub aauth_agent: Option<String>,
    /// Whether the connection is loopback (dev operator default).
    pub loopback: bool,
    /// Whether the framework already authenticated the peer as management
    /// (a verified client cert / matched bearer).
    pub management: bool,
}

/// Resolves a caller to a principal from the configured `a2a.principals`.
pub struct Resolver {
    principals: Vec<Compiled>,
    /// A bearer whose match resolves to the operator, when `a2a.bearer` is set
    /// and no principal claims it (the loopback/single-operator default).
    default_operator_on_bearer: bool,
    /// Whether an unconfigured deployment treats a loopback caller as the
    /// operator. True only while `a2a.principals` is empty: once an operator
    /// has written any rule, the implicit local operator disappears rather
    /// than sitting behind their matrix as a way in.
    loopback_operator: bool,
}

struct Compiled {
    matcher: v2::PrincipalMatch,
    role: Role,
    grants: Vec<String>,
    rate: Option<String>,
    budget: Option<v2::Budget>,
    labels: std::collections::BTreeMap<String, String>,
    bearer_secret: Option<String>,
}

impl Resolver {
    /// Build from settings, resolving `bearer_ref` secrets at startup.
    pub fn build(a2a: &v2::A2a, env: &dyn Fn(&str) -> Option<String>) -> Result<Resolver, String> {
        let mut principals = Vec::new();
        for p in &a2a.principals {
            let bearer_secret = match &p.matcher.bearer_ref {
                Some(r) => Some(
                    secret::resolve(r, env)
                        .map_err(|e| format!("a2a principal bearer_ref: {e}"))?,
                ),
                None => None,
            };
            principals.push(Compiled {
                matcher: p.matcher.clone(),
                role: p.role,
                grants: p.grants.clone(),
                rate: p.quotas.as_ref().and_then(|q| q.rate.clone()),
                budget: p.quotas.as_ref().and_then(|q| q.budget.clone()),
                labels: p.labels.clone(),
                bearer_secret,
            });
        }
        Ok(Resolver {
            principals,
            default_operator_on_bearer: a2a.bearer.is_some(),
            loopback_operator: a2a.principals.is_empty(),
        })
    }

    /// Resolve a caller. Matching order: explicit principal rules (first match),
    /// then the operator defaults (verified management / loopback), then
    /// anonymous.
    pub fn resolve(&self, id: &CallerIdentity, presented_bearer: Option<&str>) -> Principal {
        for c in &self.principals {
            if let Some(p) = c.matches(id, presented_bearer) {
                return p;
            }
        }
        // A configured `a2a.bearer` (server bearer) that the transport matched
        // ⇒ operator, unless a principal already claimed the connection.
        if id.management && (self.default_operator_on_bearer || self.loopback_operator) {
            return operator();
        }
        if id.loopback && self.loopback_operator {
            return operator();
        }
        Principal::anonymous()
    }

    /// A status view of the configured principals.
    pub fn status(&self) -> Value {
        json!({
            "principals": self.principals.iter().map(|c| json!({"role": format!("{:?}", c.role).to_lowercase(), "match": matcher_desc(&c.matcher), "grants": c.grants})).collect::<Vec<_>>(),
            "loopback_operator": self.loopback_operator,
        })
    }
}

impl Compiled {
    fn matches(&self, id: &CallerIdentity, presented_bearer: Option<&str>) -> Option<Principal> {
        let m = &self.matcher;
        let hit = if m.any {
            true
        } else if let Some(san) = &m.san {
            id.sans.iter().any(|s| glob(san, s))
                || id.subject.as_deref().is_some_and(|s| glob(san, s))
        } else if let Some(sub) = &m.sub {
            id.subject.as_deref().is_some_and(|s| s == sub)
                || id.bearer_ref.as_deref().is_some_and(|b| b == sub)
        } else if m.bearer_ref.is_some() {
            match (&self.bearer_secret, presented_bearer) {
                (Some(secret), Some(got)) => ct_eq(secret.as_bytes(), got.as_bytes()),
                _ => false,
            }
        } else if let Some(agent) = &m.aauth_agent {
            id.aauth_agent.as_deref().is_some_and(|a| glob(agent, a))
        } else {
            false
        };
        if !hit {
            return None;
        }
        let pid = principal_id(self.role, id, m);
        Some(Principal {
            id: pid,
            role: self.role,
            grants: self.grants.clone(),
            rate: self.rate.clone(),
            budget: self.budget.clone(),
            labels: self.labels.clone(),
        })
    }
}

fn operator() -> Principal {
    Principal {
        id: "operator".into(),
        role: Role::Operator,
        grants: vec!["*".into()],
        rate: None,
        budget: None,
        labels: Default::default(),
    }
}

fn principal_id(role: Role, id: &CallerIdentity, m: &v2::PrincipalMatch) -> String {
    let sub = id
        .subject
        .clone()
        .or_else(|| id.sans.first().cloned())
        .or_else(|| id.bearer_ref.clone())
        .or_else(|| id.aauth_agent.clone())
        .or_else(|| m.sub.clone())
        .unwrap_or_else(|| "unknown".into());
    match role {
        Role::Operator => "operator".into(),
        Role::User => format!("user:{sub}"),
        Role::Agent => format!("agent:{sub}"),
        Role::Anonymous => "anonymous".into(),
    }
}

fn matcher_desc(m: &v2::PrincipalMatch) -> Value {
    if m.any {
        json!({"any": true})
    } else if let Some(s) = &m.san {
        json!({"san": s})
    } else if let Some(s) = &m.sub {
        json!({"sub": s})
    } else if m.bearer_ref.is_some() {
        json!({"bearer_ref": "***"})
    } else if let Some(a) = &m.aauth_agent {
        json!({"aauth_agent": a})
    } else {
        json!({})
    }
}

/// A `*`-glob match (`*` = any run of chars; else literal).
fn glob(pattern: &str, s: &str) -> bool {
    if pattern == "*" {
        return true;
    }
    if let Some(pos) = pattern.find('*') {
        let (pre, post) = (&pattern[..pos], &pattern[pos + 1..]);
        return s.starts_with(pre) && s.ends_with(post) && s.len() >= pre.len() + post.len();
    }
    pattern == s
}

/// Constant-time byte compare.
fn ct_eq(a: &[u8], b: &[u8]) -> bool {
    if a.len() != b.len() {
        return false;
    }
    let mut d = 0u8;
    for (x, y) in a.iter().zip(b.iter()) {
        d |= x ^ y;
    }
    d == 0
}

#[cfg(test)]
mod tests {
    use super::*;
    use serde_json::json;

    fn a2a(doc: Value) -> v2::A2a {
        serde_json::from_value(doc).unwrap()
    }
    fn ident(sans: &[&str], sub: Option<&str>, mgmt: bool, loopback: bool) -> CallerIdentity {
        CallerIdentity {
            sans: sans.iter().map(|s| s.to_string()).collect(),
            subject: sub.map(str::to_string),
            management: mgmt,
            loopback,
            ..Default::default()
        }
    }

    #[test]
    fn resolves_roles_and_enforces_the_matrix() {
        let r = Resolver::build(
            &a2a(json!({
                "principals": [
                    {"match": {"san": "spiffe://ops/*"}, "role": "operator"},
                    {"match": {"san": "spiffe://team/*"}, "role": "user", "grants": ["knowledge.*"]},
                    {"match": {"bearer_ref": "{{secret:PEER}}"}, "role": "agent"},
                    {"match": {"any": true}, "role": "anonymous"}
                ]
            })),
            &|k| (k == "PEER").then(|| "s3cr3t".to_string()),
        )
        .unwrap();
        let op = r.resolve(&ident(&["spiffe://ops/admin"], None, true, false), None);
        assert!(op.is_operator());
        assert!(op.may("SendMessage", Some("a2a.Drain")) || op.may_command("workflow.delete"));
        let user = r.resolve(&ident(&["spiffe://team/alice"], None, true, false), None);
        assert_eq!(user.role, Role::User);
        assert_eq!(user.id, "user:spiffe://team/alice");
        assert!(user.may("SendMessage", None), "NL is allowed");
        assert!(
            user.may_command("status")
                && user.may_command("workflow.run")
                && user.may_command("knowledge.search")
        );
        assert!(
            !user.may_command("workflow.delete"),
            "not granted to a user"
        );
        assert!(!user.may("a2a.Drain", None), "admin is operator-only");
        let agent = r.resolve(&ident(&[], None, false, false), Some("s3cr3t"));
        assert_eq!(agent.role, Role::Agent);
        assert!(agent.may_command("workflow.run") && !agent.may_command("subagent.send"));
        assert!(
            r.resolve(&ident(&[], None, false, false), Some("wrong"))
                .is_anonymous()
        );
        let anon = r.resolve(&ident(&["spiffe://other/x"], None, false, false), None);
        assert!(anon.is_anonymous());
        assert!(!anon.may("SendMessage", None) && !anon.may_command("status"));
    }

    #[test]
    fn loopback_and_bearer_defaults() {
        // No principals configured + loopback ⇒ operator.
        let r = Resolver::build(&a2a(json!({})), &|_| None).unwrap();
        assert!(r.resolve(&ident(&[], None, true, true), None).is_operator());
        assert!(
            r.resolve(&ident(&[], None, false, false), None)
                .is_anonymous(),
            "non-loopback without a match is anonymous"
        );
        // A server bearer the transport matched ⇒ operator.
        let r = Resolver::build(&a2a(json!({"bearer": "{{secret:B}}"})), &|k| {
            (k == "B").then(|| "t".to_string())
        })
        .unwrap();
        assert!(
            r.resolve(&ident(&[], None, true, false), None)
                .is_operator()
        );
        assert!(glob("a*c", "abc") && glob("*", "x") && !glob("a*c", "abx"));
    }

    fn person(id: &str, role: Role, labels: &[(&str, &str)]) -> Principal {
        Principal {
            id: id.into(),
            role,
            grants: Vec::new(),
            rate: None,
            budget: None,
            labels: labels
                .iter()
                .map(|(k, v)| ((*k).to_string(), (*v).to_string()))
                .collect(),
        }
    }

    /// The whole point of an addressee: someone else cannot satisfy it. Every
    /// declared condition must hold, so adding one narrows.
    #[test]
    fn an_addressee_admits_only_who_it_names() {
        let by_id = Addressee::parse(&json!("*@finance.example")).unwrap();
        assert!(by_id.matches(&person("lead@finance.example", Role::User, &[])));
        assert!(!by_id.matches(&person("dev@eng.example", Role::User, &[])));

        // Labels are the durable form — people change, teams do not.
        let by_label =
            Addressee::parse(&json!({"role": "user", "labels": {"team": "finance"}})).unwrap();
        assert!(by_label.matches(&person("anyone", Role::User, &[("team", "finance")])));
        assert!(
            !by_label.matches(&person("anyone", Role::User, &[("team", "eng")])),
            "a different team is a different decider"
        );
        assert!(
            !by_label.matches(&person("anyone", Role::Agent, &[("team", "finance")])),
            "conditions AND: the role must hold too"
        );
        assert!(
            !by_label.matches(&person("anyone", Role::User, &[])),
            "a principal with no labels matches no label condition"
        );
    }

    /// Three declarations are refused rather than accepted-and-ignored,
    /// because each would produce a gate that LOOKS routed and is not.
    #[test]
    fn an_addressee_that_names_nobody_is_refused() {
        // Matches everyone.
        assert!(Addressee::parse(&json!({})).is_err());
        assert!(Addressee::parse(&json!("")).is_err());
        // Anonymous is precisely the identity nothing vouches for, so a gate
        // "answered by anonymous" records nothing at all.
        assert!(Addressee::parse(&json!({"role": "anonymous"})).is_err());
        // And a typo must not silently widen the gate.
        assert!(Addressee::parse(&json!({"rolle": "user"})).is_err());
        assert!(Addressee::parse(&json!({"role": "auditor"})).is_err());
        assert!(Addressee::parse(&json!({"labels": {"team": 1}})).is_err());
    }

    /// A gate that will not take your answer has to say whose it wants.
    #[test]
    fn an_addressee_describes_itself() {
        let a = Addressee::parse(&json!({"id": "u:*", "role": "user", "labels": {"team": "fin"}}))
            .unwrap();
        let d = a.describe();
        assert!(
            d.contains("u:*") && d.contains("user") && d.contains("team=fin"),
            "{d}"
        );
    }
}