ag-forge 0.15.15

Agentty is an ADE (Agentic Development Environment) for structured, controllable AI-assisted software development.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
use std::sync::Arc;

use mockall::Sequence;

use crate::client::{RealReviewRequestClient, ReviewRequestClient};
use crate::command::{ForgeCommand, ForgeCommandOutput, MockForgeCommandRunner};
use crate::model::{
    ForgeKind, ForgeRemote, ReviewRequestError, ReviewRequestMetadata, ReviewRequestState,
    ReviewRequestSummary,
};

#[test]
fn review_request_web_url_returns_error_when_summary_is_missing_url() {
    // Arrange
    let client = RealReviewRequestClient::default();
    let review_request = ReviewRequestSummary {
        display_id: "#42".to_string(),
        forge_kind: ForgeKind::GitHub,
        source_branch: "feature/forge".to_string(),
        state: ReviewRequestState::Open,
        status_summary: Some("Mergeable".to_string()),
        target_branch: "main".to_string(),
        title: "Add forge boundary".to_string(),
        web_url: String::new(),
    };

    // Act
    let error = client
        .review_request_web_url(&review_request)
        .expect_err("missing URL should be rejected");

    // Assert
    assert_eq!(
        error,
        ReviewRequestError::OperationFailed {
            forge_kind: ForgeKind::GitHub,
            message: "review request summary is missing a web URL".to_string(),
        }
    );
}

#[test]
fn review_request_web_url_returns_gitlab_url_without_provider_routing() {
    // Arrange
    let client = RealReviewRequestClient::default();
    let review_request = ReviewRequestSummary {
        display_id: "!42".to_string(),
        forge_kind: ForgeKind::GitLab,
        source_branch: "feature/forge".to_string(),
        state: ReviewRequestState::Open,
        status_summary: Some("Draft".to_string()),
        target_branch: "main".to_string(),
        title: "Add forge boundary".to_string(),
        web_url: "https://gitlab.com/agentty-xyz/agentty/-/merge_requests/42".to_string(),
    };

    // Act
    let web_url = client
        .review_request_web_url(&review_request)
        .expect("gitlab review-request URL should be returned directly");

    // Assert
    assert_eq!(
        web_url,
        "https://gitlab.com/agentty-xyz/agentty/-/merge_requests/42"
    );
}

#[tokio::test]
async fn find_by_source_branch_authenticates_once_before_github_lookup() {
    // Arrange
    let remote = github_remote();
    let mut sequence = Sequence::new();
    let mut command_runner = MockForgeCommandRunner::new();
    command_runner
        .expect_run()
        .once()
        .in_sequence(&mut sequence)
        .withf(|command| {
            command_arguments_are(
                command,
                "gh",
                &["auth", "status", "--hostname", "github.com"],
            )
        })
        .returning(|_| Box::pin(async { Ok(success_output(String::new())) }));
    command_runner
        .expect_run()
        .once()
        .in_sequence(&mut sequence)
        .withf(|command| {
            command_arguments_are(
                command,
                "gh",
                &[
                    "api",
                    "--hostname",
                    "github.com",
                    "--method",
                    "GET",
                    "repos/agentty-xyz/agentty/pulls",
                    "-f",
                    "head=agentty-xyz:feature/forge",
                    "-f",
                    "state=open",
                    "-f",
                    "sort=created",
                    "-f",
                    "direction=desc",
                    "-f",
                    "per_page=1",
                ],
            )
        })
        .returning(|_| Box::pin(async { Ok(success_output(r#"[{"number":42}]"#.to_string())) }));
    command_runner
        .expect_run()
        .once()
        .in_sequence(&mut sequence)
        .withf(|command| {
            command_arguments_are(
                command,
                "gh",
                &[
                    "pr",
                    "view",
                    "42",
                    "--repo",
                    "agentty-xyz/agentty",
                    "--json",
                    "number,title,state,url,baseRefName,headRefName,isDraft,mergeStateStatus,\
                     reviewDecision,mergedAt",
                ],
            )
        })
        .returning(|_| Box::pin(async { Ok(success_output(github_view_json())) }));
    let client = RealReviewRequestClient::new(Arc::new(command_runner));

    // Act
    let review_request = client
        .find_by_source_branch(remote, "feature/forge".to_string())
        .await
        .expect("GitHub lookup should succeed");

    // Assert
    assert_eq!(
        review_request,
        Some(ReviewRequestSummary {
            display_id: "#42".to_string(),
            forge_kind: ForgeKind::GitHub,
            source_branch: "feature/forge".to_string(),
            state: ReviewRequestState::Open,
            status_summary: Some("Approved, Mergeable".to_string()),
            target_branch: "main".to_string(),
            title: "Add forge review support".to_string(),
            web_url: "https://github.com/agentty-xyz/agentty/pull/42".to_string(),
        })
    );
}

#[tokio::test]
async fn review_request_metadata_authenticates_before_github_lookup() {
    // Arrange
    let remote = github_remote();
    let mut sequence = Sequence::new();
    let mut command_runner = MockForgeCommandRunner::new();
    command_runner
        .expect_run()
        .once()
        .in_sequence(&mut sequence)
        .withf(|command| {
            command_arguments_are(
                command,
                "gh",
                &["auth", "status", "--hostname", "github.com"],
            )
        })
        .returning(|_| Box::pin(async { Ok(success_output(String::new())) }));
    command_runner
        .expect_run()
        .once()
        .in_sequence(&mut sequence)
        .withf(|command| {
            command_arguments_are(
                command,
                "gh",
                &[
                    "pr",
                    "view",
                    "42",
                    "--repo",
                    "agentty-xyz/agentty",
                    "--json",
                    "title,body",
                ],
            )
        })
        .returning(|_| {
            Box::pin(async {
                Ok(success_output(
                    r#"{"title":"Current title","body":"Current body"}"#.to_string(),
                ))
            })
        });
    let client = RealReviewRequestClient::new(Arc::new(command_runner));

    // Act
    let metadata = client
        .review_request_metadata(remote, "#42".to_string())
        .await
        .expect("GitHub metadata lookup should succeed");

    // Assert
    assert_eq!(
        metadata,
        ReviewRequestMetadata {
            body: "Current body".to_string(),
            title: "Current title".to_string(),
        }
    );
}

#[tokio::test]
async fn refresh_review_request_stops_on_github_authentication_error() {
    // Arrange
    let remote = github_remote();
    let mut command_runner = MockForgeCommandRunner::new();
    command_runner
        .expect_run()
        .once()
        .withf(|command| {
            command_arguments_are(
                command,
                "gh",
                &["auth", "status", "--hostname", "github.com"],
            )
        })
        .returning(|_| {
            Box::pin(async {
                Ok(failure_output(
                    "You are not logged into any GitHub hosts. Run `gh auth login`.".to_string(),
                ))
            })
        });
    let client = RealReviewRequestClient::new(Arc::new(command_runner));

    // Act
    let error = client
        .refresh_review_request(remote, "#42".to_string())
        .await
        .expect_err("missing auth should stop before refresh");

    // Assert
    assert_eq!(
        error,
        ReviewRequestError::AuthenticationRequired {
            detail: Some(
                "You are not logged into any GitHub hosts. Run `gh auth login`.".to_string()
            ),
            forge_kind: ForgeKind::GitHub,
            host: "github.com".to_string(),
        }
    );
}

#[tokio::test]
async fn review_thread_mutations_authenticate_and_route_to_github_adapter() {
    // Arrange
    let remote = github_remote();
    let mut sequence = Sequence::new();
    let mut command_runner = MockForgeCommandRunner::new();
    for expected_mutation in ["addPullRequestReviewThreadReply", "resolveReviewThread"] {
        command_runner
            .expect_run()
            .once()
            .in_sequence(&mut sequence)
            .withf(|command| {
                command_arguments_are(
                    command,
                    "gh",
                    &["auth", "status", "--hostname", "github.com"],
                )
            })
            .returning(|_| Box::pin(async { Ok(success_output(String::new())) }));
        command_runner
            .expect_run()
            .once()
            .in_sequence(&mut sequence)
            .withf(move |command| {
                command.executable == "gh"
                    && command
                        .arguments
                        .iter()
                        .any(|argument| argument.contains(expected_mutation))
            })
            .returning(|_| Box::pin(async { Ok(success_output(String::new())) }));
    }
    let client = RealReviewRequestClient::new(Arc::new(command_runner));

    // Act
    let reply_result = client
        .reply_to_thread(
            remote.clone(),
            "#42".to_string(),
            "thread-1".to_string(),
            "Addressed.".to_string(),
        )
        .await;
    let resolution_result = client
        .resolve_thread(remote, "#42".to_string(), "thread-1".to_string())
        .await;

    // Assert
    assert_eq!(reply_result, Ok(()));
    assert_eq!(resolution_result, Ok(()));
}

#[tokio::test]
async fn refresh_review_request_authenticates_before_gitlab_refresh() {
    // Arrange
    let remote = gitlab_remote();
    let mut sequence = Sequence::new();
    let mut command_runner = MockForgeCommandRunner::new();
    command_runner
        .expect_run()
        .once()
        .in_sequence(&mut sequence)
        .withf(|command| {
            command_arguments_are(
                command,
                "glab",
                &["auth", "status", "--hostname", "gitlab.com"],
            )
        })
        .returning(|_| Box::pin(async { Ok(success_output(String::new())) }));
    command_runner
        .expect_run()
        .once()
        .in_sequence(&mut sequence)
        .withf(|command| {
            command_arguments_are(
                command,
                "glab",
                &[
                    "mr",
                    "view",
                    "42",
                    "--repo",
                    "https://gitlab.com/agentty-xyz/agentty",
                    "--output",
                    "json",
                ],
            )
        })
        .returning(|_| Box::pin(async { Ok(success_output(gitlab_view_json())) }));
    let client = RealReviewRequestClient::new(Arc::new(command_runner));

    // Act
    let review_request = client
        .refresh_review_request(remote, "!42".to_string())
        .await
        .expect("GitLab refresh should succeed");

    // Assert
    assert_eq!(review_request.display_id, "!42");
    assert_eq!(review_request.forge_kind, ForgeKind::GitLab);
}

/// Returns whether `command` exactly matches one expected CLI invocation.
fn command_arguments_are(
    command: &ForgeCommand,
    executable: &'static str,
    arguments: &[&str],
) -> bool {
    let expected_arguments = arguments
        .iter()
        .map(|argument| (*argument).to_string())
        .collect::<Vec<_>>();

    command.executable == executable && command.arguments == expected_arguments
}

/// Builds one normalized GitHub remote for client routing tests.
fn github_remote() -> ForgeRemote {
    ForgeRemote {
        command_working_directory: None,
        forge_kind: ForgeKind::GitHub,
        host: "github.com".to_string(),
        namespace: "agentty-xyz".to_string(),
        project: "agentty".to_string(),
        repo_url: "https://github.com/agentty-xyz/agentty.git".to_string(),
        web_url: "https://github.com/agentty-xyz/agentty".to_string(),
    }
}

/// Builds one normalized GitLab remote for client routing tests.
fn gitlab_remote() -> ForgeRemote {
    ForgeRemote {
        command_working_directory: None,
        forge_kind: ForgeKind::GitLab,
        host: "gitlab.com".to_string(),
        namespace: "agentty-xyz".to_string(),
        project: "agentty".to_string(),
        repo_url: "https://gitlab.com/agentty-xyz/agentty.git".to_string(),
        web_url: "https://gitlab.com/agentty-xyz/agentty".to_string(),
    }
}

/// Builds one successful command output with `stdout`.
fn success_output(stdout: String) -> ForgeCommandOutput {
    ForgeCommandOutput {
        exit_code: Some(0),
        stderr: String::new(),
        stdout,
    }
}

/// Builds one failed command output with `stderr`.
fn failure_output(stderr: String) -> ForgeCommandOutput {
    ForgeCommandOutput {
        exit_code: Some(1),
        stderr,
        stdout: String::new(),
    }
}

/// Returns one representative GitHub pull-request JSON response.
fn github_view_json() -> String {
    r#"{
        "number": 42,
        "title": "Add forge review support",
        "state": "OPEN",
        "url": "https://github.com/agentty-xyz/agentty/pull/42",
        "baseRefName": "main",
        "headRefName": "feature/forge",
        "isDraft": false,
        "mergeStateStatus": "CLEAN",
        "reviewDecision": "APPROVED",
        "mergedAt": null
    }"#
    .to_string()
}

/// Returns one representative GitLab merge-request JSON response.
fn gitlab_view_json() -> String {
    r#"{
        "draft": true,
        "detailed_merge_status": "can_be_merged",
        "iid": 42,
        "merge_status": "can_be_merged",
        "merged_at": null,
        "source_branch": "feature/forge",
        "state": "opened",
        "target_branch": "main",
        "title": "Add forge review support",
        "description": "Current description.",
        "web_url": "https://gitlab.com/agentty-xyz/agentty/-/merge_requests/42"
    }"#
    .to_string()
}