af-workflow 0.2.0

Spec-driven workflow chassis: typed node expressions composed into a branched DAG. Port of agent_core/workflow/v2.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
//! Database-agnostic scheduler for claimed long-running workflow instances.

use std::collections::HashMap;
use std::future::Future;
use std::panic::AssertUnwindSafe;
use std::sync::Arc;

use async_trait::async_trait;
use chrono::{DateTime, Utc};
use futures::{stream::FuturesUnordered, FutureExt, StreamExt};
use serde_json::Value;

#[derive(Debug, Clone, PartialEq)]
pub struct WorkItem {
    pub id: String,
    pub tenant_id: String,
    pub subject_id: String,
    pub spec_id: String,
    pub config: Value,
    pub cancel_requested: bool,
    pub lease_version: i64,
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub enum DriverOutcome {
    Continue,
    Reschedule { at: DateTime<Utc>, config: Value },
    Stopped,
}

#[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
pub struct SupervisorStats {
    pub claimed: usize,
    pub failed: usize,
}

#[derive(Debug, Clone, PartialEq, Eq)]
pub struct SupervisorSettings {
    pub worker_id: String,
    pub lease_secs: i64,
    pub requeue_delay_secs: i64,
    pub claim_batch: i64,
    pub concurrency: usize,
}

impl SupervisorSettings {
    fn concurrency(&self) -> usize {
        self.concurrency.max(1)
    }
}

#[async_trait]
pub trait WorkQueue: Send + Sync {
    async fn claim_due(
        &self,
        spec_ids: &[String],
        worker_id: &str,
        lease_secs: i64,
        batch: i64,
    ) -> Result<Vec<WorkItem>, String>;

    async fn renew(
        &self,
        id: &str,
        worker_id: &str,
        lease_version: i64,
        lease_secs: i64,
    ) -> Result<(), String>;
    async fn release(&self, id: &str, lease_version: i64, delay_secs: i64) -> Result<(), String>;
    async fn reschedule(
        &self,
        id: &str,
        lease_version: i64,
        at: DateTime<Utc>,
        config: Value,
    ) -> Result<(), String>;
    async fn complete(&self, id: &str, lease_version: i64) -> Result<(), String>;
    async fn mark_error(&self, id: &str, lease_version: i64, error: &str) -> Result<(), String>;
}

#[async_trait]
pub trait WorkflowDriver<Context>: Send + Sync
where
    Context: Send + Sync,
{
    fn name(&self) -> &'static str;
    fn spec_ids(&self) -> &'static [&'static str];
    fn validate_specs(&self) -> Result<(), String>;
    async fn evaluate(&self, context: &Context, item: &WorkItem) -> Result<DriverOutcome, String>;
}

pub struct DriverRegistry<Context: Send + Sync> {
    drivers: Vec<Arc<dyn WorkflowDriver<Context>>>,
    by_spec: HashMap<&'static str, Arc<dyn WorkflowDriver<Context>>>,
}

impl<Context: Send + Sync> Default for DriverRegistry<Context> {
    fn default() -> Self {
        Self {
            drivers: Vec::new(),
            by_spec: HashMap::new(),
        }
    }
}

impl<Context: Send + Sync> DriverRegistry<Context> {
    pub fn new() -> Self {
        Self::default()
    }

    /// Register a driver. Duplicate spec ownership is a startup error because
    /// dispatch must never depend on registration order.
    pub fn register(
        &mut self,
        driver: Arc<dyn WorkflowDriver<Context>>,
    ) -> Result<&mut Self, String> {
        for spec_id in driver.spec_ids() {
            if let Some(existing) = self.by_spec.get(spec_id) {
                return Err(format!(
                    "spec '{spec_id}' is claimed by both '{}' and '{}'",
                    existing.name(),
                    driver.name()
                ));
            }
            self.by_spec.insert(spec_id, driver.clone());
        }
        self.drivers.push(driver);
        Ok(self)
    }

    pub fn spec_ids(&self) -> Vec<String> {
        let mut ids = self
            .by_spec
            .keys()
            .map(|id| (*id).to_string())
            .collect::<Vec<_>>();
        ids.sort();
        ids
    }

    pub fn for_spec(&self, spec_id: &str) -> Option<&Arc<dyn WorkflowDriver<Context>>> {
        self.by_spec.get(spec_id)
    }

    pub fn names(&self) -> Vec<&'static str> {
        self.drivers.iter().map(|driver| driver.name()).collect()
    }

    pub fn is_empty(&self) -> bool {
        self.drivers.is_empty()
    }

    pub fn validate_all(&self) -> Result<(), String> {
        for driver in &self.drivers {
            driver
                .validate_specs()
                .map_err(|error| format!("driver '{}': {error}", driver.name()))?;
        }
        Ok(())
    }
}

pub async fn run_due_pass<Context, Queue, BuildContext, BuildFuture>(
    queue: &Queue,
    registry: &DriverRegistry<Context>,
    settings: &SupervisorSettings,
    build_context: BuildContext,
) -> Result<SupervisorStats, String>
where
    Context: Send + Sync + 'static,
    Queue: WorkQueue,
    BuildContext: FnOnce() -> BuildFuture,
    BuildFuture: Future<Output = Result<Context, String>> + Send,
{
    let claim_limit = settings
        .claim_batch
        .clamp(1, i64::try_from(settings.concurrency()).unwrap_or(i64::MAX));
    let items = queue
        .claim_due(
            &registry.spec_ids(),
            &settings.worker_id,
            settings.lease_secs,
            claim_limit,
        )
        .await
        .map_err(|error| format!("claim: {error}"))?;
    if items.is_empty() {
        return Ok(SupervisorStats::default());
    }

    let context = match build_context().await {
        Ok(context) => Arc::new(context),
        Err(error) => {
            for item in &items {
                let _ = queue.mark_error(&item.id, item.lease_version, &error).await;
                let _ = queue
                    .release(&item.id, item.lease_version, settings.requeue_delay_secs)
                    .await;
            }
            return Err(error);
        }
    };

    let claimed = items.len();
    let mut failed = 0;
    let mut work = items.into_iter();
    let mut tasks = FuturesUnordered::new();

    let spawn_next = |tasks: &mut FuturesUnordered<_>, work: &mut std::vec::IntoIter<WorkItem>| {
        let Some(item) = work.next() else {
            return false;
        };
        let id = item.id.clone();
        let lease_version = item.lease_version;
        let driver = registry.for_spec(&item.spec_id).cloned();
        let context = context.clone();
        let renewal_period = std::time::Duration::from_millis(
            (settings.lease_secs.clamp(1, 3600) as u64 * 1000 / 3).max(1),
        );
        tasks.push(async move {
            let evaluation = async {
                match driver {
                    Some(driver) => AssertUnwindSafe(driver.evaluate(&context, &item))
                        .catch_unwind()
                        .await
                        .map_err(|_| "driver panicked".to_string())
                        .and_then(|result| result),
                    None => Err(format!("no driver registered for spec '{}'", item.spec_id)),
                }
            };
            tokio::pin!(evaluation);
            let mut renewal = tokio::time::interval_at(
                tokio::time::Instant::now() + renewal_period,
                renewal_period,
            );
            renewal.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip);
            let result = loop {
                tokio::select! {
                    result = &mut evaluation => break result,
                    _ = renewal.tick() => {
                        if let Err(error) = queue
                            .renew(
                                &id,
                                &settings.worker_id,
                                lease_version,
                                settings.lease_secs,
                            )
                            .await
                        {
                            break Err(format!("lease renewal failed: {error}"));
                        }
                    }
                }
            };
            (id, lease_version, result)
        });
        true
    };

    for _ in 0..settings.concurrency() {
        if !spawn_next(&mut tasks, &mut work) {
            break;
        }
    }

    while let Some((id, lease_version, result)) = tasks.next().await {
        match result {
            Ok(outcome) => {
                let _ = match outcome {
                    DriverOutcome::Continue => {
                        queue
                            .release(&id, lease_version, settings.requeue_delay_secs)
                            .await
                    }
                    DriverOutcome::Reschedule { at, config } => {
                        queue.reschedule(&id, lease_version, at, config).await
                    }
                    DriverOutcome::Stopped => queue.complete(&id, lease_version).await,
                };
            }
            Err(error) => {
                failed += 1;
                let _ = queue.mark_error(&id, lease_version, &error).await;
                let _ = queue
                    .release(&id, lease_version, settings.requeue_delay_secs)
                    .await;
            }
        }
        spawn_next(&mut tasks, &mut work);
    }

    Ok(SupervisorStats { claimed, failed })
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::sync::Mutex;

    struct Context;
    struct Driver {
        valid: bool,
    }

    #[async_trait]
    impl WorkflowDriver<Context> for Driver {
        fn name(&self) -> &'static str {
            "driver"
        }
        fn spec_ids(&self) -> &'static [&'static str] {
            &["spec"]
        }
        fn validate_specs(&self) -> Result<(), String> {
            self.valid.then_some(()).ok_or_else(|| "invalid".into())
        }
        async fn evaluate(
            &self,
            _context: &Context,
            item: &WorkItem,
        ) -> Result<DriverOutcome, String> {
            if let Some(milliseconds) = item.config["sleep_ms"].as_u64() {
                tokio::time::sleep(std::time::Duration::from_millis(milliseconds)).await;
            }
            if item.config["fail"] == true {
                Err("planned".into())
            } else if item.config["reschedule"] == true {
                Ok(DriverOutcome::Reschedule {
                    at: Utc::now(),
                    config: serde_json::json!({"next": true}),
                })
            } else if item.config["stop"] == true {
                Ok(DriverOutcome::Stopped)
            } else {
                Ok(DriverOutcome::Continue)
            }
        }
    }

    #[derive(Default)]
    struct Queue {
        items: Mutex<Vec<WorkItem>>,
        released: Mutex<Vec<String>>,
        completed: Mutex<Vec<String>>,
        rescheduled: Mutex<Vec<String>>,
        errors: Mutex<Vec<String>>,
        renewals: Mutex<Vec<(String, String, i64)>>,
        renewal_error: Mutex<Option<String>>,
        claim_limits: Mutex<Vec<i64>>,
    }

    #[async_trait]
    impl WorkQueue for Queue {
        async fn claim_due(
            &self,
            _spec_ids: &[String],
            _worker_id: &str,
            _lease_secs: i64,
            batch: i64,
        ) -> Result<Vec<WorkItem>, String> {
            self.claim_limits.lock().unwrap().push(batch);
            let mut items = self.items.lock().unwrap();
            let take = items.len().min(batch as usize);
            Ok(items.drain(..take).collect())
        }

        async fn renew(
            &self,
            id: &str,
            worker_id: &str,
            lease_version: i64,
            _lease_secs: i64,
        ) -> Result<(), String> {
            self.renewals.lock().unwrap().push((
                id.to_string(),
                worker_id.to_string(),
                lease_version,
            ));
            match self.renewal_error.lock().unwrap().clone() {
                Some(error) => Err(error),
                None => Ok(()),
            }
        }

        async fn release(
            &self,
            id: &str,
            _lease_version: i64,
            _delay_secs: i64,
        ) -> Result<(), String> {
            self.released.lock().unwrap().push(id.into());
            Ok(())
        }

        async fn complete(&self, id: &str, _lease_version: i64) -> Result<(), String> {
            self.completed.lock().unwrap().push(id.into());
            Ok(())
        }

        async fn reschedule(
            &self,
            id: &str,
            _lease_version: i64,
            _at: DateTime<Utc>,
            _config: Value,
        ) -> Result<(), String> {
            self.rescheduled.lock().unwrap().push(id.into());
            Ok(())
        }

        async fn mark_error(
            &self,
            id: &str,
            _lease_version: i64,
            _error: &str,
        ) -> Result<(), String> {
            self.errors.lock().unwrap().push(id.into());
            Ok(())
        }
    }

    fn item(id: &str, fail: bool) -> WorkItem {
        WorkItem {
            id: id.into(),
            tenant_id: "tenant".into(),
            subject_id: "subject".into(),
            spec_id: "spec".into(),
            config: serde_json::json!({"fail": fail}),
            cancel_requested: false,
            lease_version: 1,
        }
    }

    fn stopped_item(id: &str) -> WorkItem {
        WorkItem {
            config: serde_json::json!({"stop": true}),
            ..item(id, false)
        }
    }

    fn settings() -> SupervisorSettings {
        SupervisorSettings {
            worker_id: "worker".into(),
            lease_secs: 60,
            requeue_delay_secs: 5,
            claim_batch: 10,
            concurrency: 3,
        }
    }

    #[tokio::test]
    async fn due_pass_releases_success_and_marks_failures() {
        let queue = Queue {
            items: Mutex::new(vec![
                item("ok", false),
                stopped_item("done"),
                item("bad", true),
            ]),
            ..Default::default()
        };
        let mut registry = DriverRegistry::new();
        registry.register(Arc::new(Driver { valid: true })).unwrap();
        let stats = run_due_pass(&queue, &registry, &settings(), || async { Ok(Context) })
            .await
            .unwrap();
        assert_eq!(
            stats,
            SupervisorStats {
                claimed: 3,
                failed: 1
            }
        );
        assert_eq!(queue.released.lock().unwrap().len(), 2);
        assert_eq!(queue.completed.lock().unwrap().as_slice(), ["done"]);
        assert_eq!(queue.errors.lock().unwrap().as_slice(), ["bad"]);
    }

    #[tokio::test]
    async fn context_failure_releases_every_claim() {
        let queue = Queue {
            items: Mutex::new(vec![item("one", false), item("two", false)]),
            ..Default::default()
        };
        let mut registry = DriverRegistry::new();
        registry.register(Arc::new(Driver { valid: true })).unwrap();
        let error = run_due_pass(&queue, &registry, &settings(), || async {
            Err::<Context, _>("context failed".into())
        })
        .await
        .unwrap_err();
        assert_eq!(error, "context failed");
        assert_eq!(queue.released.lock().unwrap().len(), 2);
        assert_eq!(queue.errors.lock().unwrap().len(), 2);
    }

    #[tokio::test]
    async fn due_pass_atomically_reschedules_driver_state() {
        let queue = Queue {
            items: Mutex::new(vec![WorkItem {
                config: serde_json::json!({"reschedule": true}),
                ..item("recurring", false)
            }]),
            ..Default::default()
        };
        let mut registry = DriverRegistry::new();
        registry.register(Arc::new(Driver { valid: true })).unwrap();
        run_due_pass(&queue, &registry, &settings(), || async { Ok(Context) })
            .await
            .unwrap();
        assert_eq!(queue.rescheduled.lock().unwrap().as_slice(), ["recurring"]);
        assert!(queue.released.lock().unwrap().is_empty());
        assert!(queue.completed.lock().unwrap().is_empty());
    }

    #[tokio::test]
    async fn due_pass_claims_only_work_that_can_start() {
        let queue = Queue {
            items: Mutex::new(vec![
                item("one", false),
                item("two", false),
                item("queued", false),
            ]),
            ..Default::default()
        };
        let mut registry = DriverRegistry::new();
        registry.register(Arc::new(Driver { valid: true })).unwrap();
        let mut settings = settings();
        settings.concurrency = 2;

        let stats = run_due_pass(&queue, &registry, &settings, || async { Ok(Context) })
            .await
            .unwrap();

        assert_eq!(stats.claimed, 2);
        assert_eq!(queue.claim_limits.lock().unwrap().as_slice(), [2]);
        assert_eq!(queue.items.lock().unwrap().len(), 1);
    }

    #[tokio::test(start_paused = true)]
    async fn long_evaluate_renews_its_lease() {
        let queue = Queue {
            items: Mutex::new(vec![WorkItem {
                config: serde_json::json!({"sleep_ms": 3500}),
                ..item("slow", false)
            }]),
            ..Default::default()
        };
        let mut registry = DriverRegistry::new();
        registry.register(Arc::new(Driver { valid: true })).unwrap();
        let mut settings = settings();
        settings.lease_secs = 3;
        settings.concurrency = 1;

        let stats = run_due_pass(&queue, &registry, &settings, || async { Ok(Context) })
            .await
            .unwrap();

        assert_eq!(stats.failed, 0);
        let renewals = queue.renewals.lock().unwrap();
        assert_eq!(renewals.len(), 3);
        assert!(renewals
            .iter()
            .all(|renewal| renewal == &("slow".into(), "worker".into(), 1)));
        assert_eq!(queue.released.lock().unwrap().as_slice(), ["slow"]);
    }

    #[tokio::test(start_paused = true)]
    async fn expired_lease_stops_evaluation() {
        let queue = Queue {
            items: Mutex::new(vec![WorkItem {
                config: serde_json::json!({"sleep_ms": 5000}),
                ..item("expired", false)
            }]),
            renewal_error: Mutex::new(Some("lease expired".into())),
            ..Default::default()
        };
        let mut registry = DriverRegistry::new();
        registry.register(Arc::new(Driver { valid: true })).unwrap();
        let mut settings = settings();
        settings.lease_secs = 3;
        settings.concurrency = 1;

        let stats = run_due_pass(&queue, &registry, &settings, || async { Ok(Context) })
            .await
            .unwrap();

        assert_eq!(stats.failed, 1);
        assert_eq!(queue.renewals.lock().unwrap().len(), 1);
        assert_eq!(queue.errors.lock().unwrap().as_slice(), ["expired"]);
    }

    #[test]
    fn registry_fails_duplicate_ownership_and_invalid_specs() {
        let mut registry = DriverRegistry::new();
        assert!(registry.is_empty());
        registry
            .register(Arc::new(Driver { valid: false }))
            .unwrap();
        assert_eq!(registry.spec_ids(), ["spec"]);
        assert_eq!(registry.names(), ["driver"]);
        assert!(registry.for_spec("spec").is_some());
        assert!(registry.validate_all().unwrap_err().contains("invalid"));
        assert!(registry
            .register(Arc::new(Driver { valid: true }))
            .err()
            .unwrap()
            .contains("both"));
    }
}