aether-wisp 0.4.16

A terminal UI for AI coding agents via the Agent Client Protocol (ACP)
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
use acp_utils::notifications::{McpServerAuthCapability, McpServerStatus, McpServerStatusEntry};
use agent_client_protocol::schema::{self as acp, SessionConfigSelectOption};
use tui::testing::render_component;
use tui::{Component, Event, KeyCode, KeyEvent, KeyModifiers, ViewContext};
use wisp::settings::menu::SettingsMenu;
use wisp::settings::overlay::{SettingsMessage, SettingsOverlay};

fn make_menu() -> SettingsMenu {
    let options = vec![
        agent_client_protocol::schema::SessionConfigOption::select(
            "provider",
            "Provider",
            "openrouter",
            vec![
                SessionConfigSelectOption::new("openrouter", "OpenRouter"),
                SessionConfigSelectOption::new("ollama", "Ollama"),
            ],
        ),
        agent_client_protocol::schema::SessionConfigOption::select(
            "model",
            "Model",
            "gpt-4o",
            vec![
                SessionConfigSelectOption::new("gpt-4o", "GPT-4o"),
                SessionConfigSelectOption::new("claude", "Claude"),
            ],
        ),
    ];
    SettingsMenu::from_config_options(&options)
}

fn make_multi_select_menu() -> SettingsMenu {
    let mut meta = serde_json::Map::new();
    meta.insert("multi_select".to_string(), serde_json::Value::Bool(true));
    let options = vec![
        agent_client_protocol::schema::SessionConfigOption::select(
            "provider",
            "Provider",
            "openrouter",
            vec![
                SessionConfigSelectOption::new("openrouter", "OpenRouter"),
                SessionConfigSelectOption::new("ollama", "Ollama"),
            ],
        ),
        agent_client_protocol::schema::SessionConfigOption::select(
            "model",
            "Model",
            "gpt-4o",
            vec![
                SessionConfigSelectOption::new("gpt-4o", "GPT-4o"),
                SessionConfigSelectOption::new("claude", "Claude"),
            ],
        )
        .meta(meta),
    ];
    SettingsMenu::from_config_options(&options)
}

fn make_server_statuses() -> Vec<McpServerStatusEntry> {
    vec![
        McpServerStatusEntry::new("github", McpServerStatus::Connected { tool_count: 5 }),
        McpServerStatusEntry::new("linear", McpServerStatus::NeedsOAuth)
            .with_auth_capability(McpServerAuthCapability::OAuth),
    ]
}

fn make_mixed_server_statuses() -> Vec<McpServerStatusEntry> {
    vec![
        McpServerStatusEntry::new("github", McpServerStatus::Connected { tool_count: 5 }),
        McpServerStatusEntry::new("math", McpServerStatus::Connected { tool_count: 3 }).with_proxied(true),
        McpServerStatusEntry::new("linear", McpServerStatus::NeedsOAuth)
            .with_auth_capability(McpServerAuthCapability::OAuth)
            .with_proxied(true),
    ]
}

fn key(code: KeyCode) -> KeyEvent {
    KeyEvent::new(code, KeyModifiers::NONE)
}

fn render_footer(overlay: &mut SettingsOverlay) -> String {
    let height = 23_usize; // 24 - 1
    overlay.update_child_viewport(height.saturating_sub(4));
    let term = render_component(|ctx| overlay.render(ctx), 80, 24);
    let output = term.get_lines();
    // Overlay fills 23 lines (indices 0-22). Footer is line 21, bottom border is line 22.
    output[21].clone()
}

fn render_plain_text(overlay: &mut SettingsOverlay) -> Vec<String> {
    let height = 23_usize;
    overlay.update_child_viewport(height.saturating_sub(4));
    let term = render_component(|ctx| overlay.render(ctx), 80, 24);
    term.get_lines()
}

fn make_auth_methods() -> Vec<acp::AuthMethod> {
    vec![
        acp::AuthMethod::Agent(acp::AuthMethodAgent::new("anthropic", "Anthropic")),
        acp::AuthMethod::Agent(acp::AuthMethodAgent::new("openrouter", "OpenRouter")),
    ]
}

/// Helper to create a `ConfigOverlay` with the server status overlay open.
/// Replaces the old `with_server_overlay()` test-only method.
async fn open_server_overlay(mut menu: SettingsMenu, statuses: Vec<McpServerStatusEntry>) -> SettingsOverlay {
    menu.add_mcp_servers_entry("1 connected, 1 needs auth");
    let mut overlay = SettingsOverlay::new(menu, statuses, vec![]);
    // Navigate past provider (0) and model (1) to MCP servers (2)
    overlay.on_event(&Event::Key(key(KeyCode::Down))).await;
    overlay.on_event(&Event::Key(key(KeyCode::Down))).await;
    overlay.on_event(&Event::Key(key(KeyCode::Enter))).await;
    overlay
}

#[test]
fn bordered_box_fills_terminal_height_minus_one() {
    let mut overlay = SettingsOverlay::new(make_menu(), vec![], vec![]);
    let term = render_component(|ctx| overlay.render(ctx), 80, 24);
    let output = term.get_lines();
    // Frame fills 23 lines, leaving the last row (index 23) empty
    assert!(!output[22].is_empty(), "line 22 should have content");
    assert!(output[23].is_empty(), "line 23 should be empty");
}

#[test]
fn title_contains_configuration() {
    let mut overlay = SettingsOverlay::new(make_menu(), vec![], vec![]);
    let term = render_component(|ctx| overlay.render(ctx), 80, 24);
    let output = term.get_lines();
    assert!(output[0].contains("Configuration"));
}

#[test]
fn footer_shows_select_and_close_for_menu() {
    let mut overlay = SettingsOverlay::new(make_menu(), vec![], vec![]);
    let term = render_component(|ctx| overlay.render(ctx), 80, 24);
    let output = term.get_lines();
    let footer = &output[21]; // second to last content line (last is bottom border at 22)
    assert!(footer.contains("[Enter] Select"), "footer: {footer}");
    assert!(footer.contains("[Esc] Close"), "footer: {footer}");
}

#[tokio::test]
async fn footer_shows_confirm_and_back_for_picker() {
    let mut overlay = SettingsOverlay::new(make_menu(), vec![], vec![]);
    // Open picker
    overlay.on_event(&Event::Key(key(KeyCode::Enter))).await;
    let term = render_component(|ctx| overlay.render(ctx), 80, 24);
    let output = term.get_lines();
    let footer = &output[21];
    assert!(footer.contains("[Enter] Confirm"), "footer: {footer}");
    assert!(footer.contains("[Esc] Back"), "footer: {footer}");
}

#[tokio::test]
async fn footer_shows_authenticate_and_back_for_servers() {
    let menu = make_menu();
    let statuses = make_server_statuses();
    let mut overlay = open_server_overlay(menu, statuses).await;
    let footer = render_footer(&mut overlay);
    assert!(footer.contains("[Enter] Authenticate OAuth servers"), "footer: {footer}");
    assert!(footer.contains("[Esc] Back"), "footer: {footer}");
}

#[test]
fn selected_entry_has_bg_color() {
    let mut overlay = SettingsOverlay::new(make_menu(), vec![], vec![]);
    let ctx = ViewContext::new((80, 24));
    let term = render_component(|c| overlay.render(c), 80, 24);
    let output = term.get_lines();
    let row =
        output.iter().position(|l| l.contains("Provider: OpenRouter")).expect("expected provider row to be rendered");
    let style = term.style_of_text(row, "Provider: OpenRouter").unwrap();
    assert_eq!(style.bg, Some(ctx.theme.highlight_bg()), "selected entry should have highlight_bg");
}

#[test]
fn render_root_menu_shows_top_level_rows() {
    let mut overlay = SettingsOverlay::new(make_menu(), vec![], vec![]);

    let lines = render_plain_text(&mut overlay);
    let text = lines.join("\n");

    assert!(text.contains("Provider: OpenRouter"), "rendered:\n{text}");
    assert!(text.contains("Model: GPT-4o"), "rendered:\n{text}");
    assert!(text.contains("[Enter] Select"), "rendered:\n{text}");
    assert!(text.contains("[Esc] Close"), "rendered:\n{text}");
}

#[tokio::test]
async fn render_picker_hides_top_level_rows() {
    let mut overlay = SettingsOverlay::new(make_menu(), vec![], vec![]);
    overlay.on_event(&Event::Key(key(KeyCode::Enter))).await;

    let lines = render_plain_text(&mut overlay);
    let text = lines.join("\n");

    assert!(text.contains("Provider search:"), "rendered:\n{text}");
    assert!(!text.contains("Provider: OpenRouter"), "rendered:\n{text}");
    assert!(!text.contains("Model: GPT-4o"), "rendered:\n{text}");
    assert!(text.contains("[Enter] Confirm"), "rendered:\n{text}");
    assert!(text.contains("[Esc] Back"), "rendered:\n{text}");
}

#[tokio::test]
async fn render_model_selector_hides_top_level_rows() {
    let mut overlay = SettingsOverlay::new(make_multi_select_menu(), vec![], vec![]);
    overlay.on_event(&Event::Key(key(KeyCode::Down))).await;
    overlay.on_event(&Event::Key(key(KeyCode::Enter))).await;

    let lines = render_plain_text(&mut overlay);
    let text = lines.join("\n");

    assert!(text.contains("Model search:"), "rendered:\n{text}");
    assert!(!text.contains("Provider: OpenRouter"), "rendered:\n{text}");
    assert!(!text.contains("Model: GPT-4o"), "rendered:\n{text}");
    assert!(text.contains("Toggle"), "rendered:\n{text}");
    assert!(text.contains("Effort: none"), "rendered:\n{text}");
    assert!(!text.contains("[Tab] Reasoning"), "rendered:\n{text}");
    assert!(text.contains("[Esc] Done"), "rendered:\n{text}");
}

#[tokio::test]
async fn render_server_overlay_hides_top_level_rows() {
    let menu = make_menu();
    let statuses = make_server_statuses();
    let mut overlay = open_server_overlay(menu, statuses).await;

    let lines = render_plain_text(&mut overlay);
    let text = lines.join("\n");

    assert!(text.contains("github  \u{2713} 5 tools"), "rendered:\n{text}");
    assert!(text.contains("linear  \u{26A1} needs authentication"), "rendered:\n{text}");
    assert!(!text.contains("Provider: OpenRouter"), "rendered:\n{text}");
    assert!(!text.contains("Model: GPT-4o"), "rendered:\n{text}");
    assert!(text.contains("[Enter] Authenticate OAuth servers"), "rendered:\n{text}");
    assert!(text.contains("[Esc] Back"), "rendered:\n{text}");
}

#[tokio::test]
async fn render_server_overlay_groups_direct_and_proxied_statuses() {
    let menu = make_menu();
    let statuses = make_mixed_server_statuses();
    let mut overlay = open_server_overlay(menu, statuses).await;
    let lines = render_plain_text(&mut overlay);
    let text = lines.join("\n");

    assert!(text.contains("Direct"), "rendered:\n{text}");
    assert!(text.contains("github  \u{2713} 5 tools"), "rendered:\n{text}");
    assert!(text.contains("Proxied"), "rendered:\n{text}");
    assert!(text.contains("math  \u{2713} 3 tools"), "rendered:\n{text}");
    assert!(text.contains("linear  \u{26A1} needs authentication"), "rendered:\n{text}");
    assert!(!text.contains("proxy  \u{2713} 1 tool"), "rendered:\n{text}");
}

#[tokio::test]
async fn render_provider_login_overlay_hides_top_level_rows() {
    let mut menu = make_menu();
    menu.add_provider_logins_entry("2 needs login");
    let mut overlay = SettingsOverlay::new(menu, vec![], make_auth_methods());
    overlay.on_event(&Event::Key(key(KeyCode::Down))).await;
    overlay.on_event(&Event::Key(key(KeyCode::Down))).await;
    let outcome = overlay.on_event(&Event::Key(key(KeyCode::Enter))).await;
    assert!(outcome.is_some());

    let lines = render_plain_text(&mut overlay);
    let text = lines.join("\n");

    assert!(text.contains("Anthropic  \u{26A1} needs login"), "rendered:\n{text}");
    assert!(text.contains("OpenRouter  \u{26A1} needs login"), "rendered:\n{text}");
    assert!(!text.contains("Provider: OpenRouter"), "rendered:\n{text}");
    assert!(!text.contains("Model: GPT-4o"), "rendered:\n{text}");
    assert!(text.contains("[Enter] Authenticate"), "rendered:\n{text}");
    assert!(text.contains("[Esc] Back"), "rendered:\n{text}");
}

#[test]
fn narrow_terminal_does_not_panic() {
    let mut overlay = SettingsOverlay::new(make_menu(), vec![], vec![]);
    let term = render_component(|ctx| overlay.render(ctx), 4, 3);
    let output = term.get_lines();
    assert!(!output.is_empty());
}

#[test]
fn very_small_terminal_shows_fallback() {
    let mut overlay = SettingsOverlay::new(make_menu(), vec![], vec![]);
    // Width must be >= text length to avoid truncation, but small enough to trigger fallback
    // MIN_WIDTH=6, MIN_HEIGHT=3, height = rows-1, so rows=3 gives height=2 < 3
    let term = render_component(|ctx| overlay.render(ctx), 30, 3);
    let output = term.get_lines();
    assert!(output[0].contains("too small"), "got: {output:?}");
}

#[test]
fn update_settings_options_never_renders_reasoning_row() {
    // Initial options include model + reasoning_effort
    let initial_options = vec![
        agent_client_protocol::schema::SessionConfigOption::select(
            "model",
            "Model",
            "claude-opus",
            vec![
                SessionConfigSelectOption::new("claude-opus", "Claude Opus"),
                SessionConfigSelectOption::new("deepseek-chat", "DeepSeek Chat"),
            ],
        ),
        agent_client_protocol::schema::SessionConfigOption::select(
            "reasoning_effort",
            "Reasoning Effort",
            "high",
            vec![
                SessionConfigSelectOption::new("none", "None"),
                SessionConfigSelectOption::new("low", "Low"),
                SessionConfigSelectOption::new("medium", "Medium"),
                SessionConfigSelectOption::new("high", "High"),
            ],
        ),
    ];
    let menu = SettingsMenu::from_config_options(&initial_options);
    let mut overlay = SettingsOverlay::new(menu, vec![], vec![]);

    // Rendered lines do not contain Reasoning Effort
    let term = render_component(|ctx| overlay.render(ctx), 80, 24);
    let text = term.get_lines().join("\n");
    assert!(!text.contains("Reasoning Effort"), "Reasoning Effort should NOT appear initially; got:\n{text}");

    // After update to model-only options, still no Reasoning Effort
    let updated_options = vec![agent_client_protocol::schema::SessionConfigOption::select(
        "model",
        "Model",
        "deepseek-chat",
        vec![
            SessionConfigSelectOption::new("claude-opus", "Claude Opus"),
            SessionConfigSelectOption::new("deepseek-chat", "DeepSeek Chat"),
        ],
    )];
    overlay.update_config_options(&updated_options);

    let term = render_component(|ctx| overlay.render(ctx), 80, 24);
    let text = term.get_lines().join("\n");
    assert!(!text.contains("Reasoning Effort"), "Reasoning Effort should NOT appear after update; got:\n{text}");
}

#[tokio::test]
async fn footer_shows_toggle_when_model_selector_open() {
    let mut overlay = SettingsOverlay::new(make_multi_select_menu(), vec![], vec![]);

    overlay.on_event(&Event::Key(key(KeyCode::Down))).await;
    overlay.on_event(&Event::Key(key(KeyCode::Enter))).await;

    let term = render_component(|ctx| overlay.render(ctx), 80, 24);
    let output = term.get_lines();
    let footer = &output[21];
    assert!(footer.contains("Toggle"), "footer: {footer}");
    assert!(footer.contains("Effort: none"), "footer: {footer}");
    assert!(!footer.contains("[Tab] Reasoning"), "footer: {footer}");
    assert!(footer.contains("[Esc] Done"), "footer: {footer}");
}

#[tokio::test]
async fn tall_terminal_shows_more_picker_items() {
    // Create a menu with many model options
    let many_models: Vec<SessionConfigSelectOption> =
        (0..20).map(|i| SessionConfigSelectOption::new(format!("model-{i}"), format!("Model {i}"))).collect();
    let options =
        vec![agent_client_protocol::schema::SessionConfigOption::select("model", "Model", "model-0", many_models)];
    let menu = SettingsMenu::from_config_options(&options);
    let mut overlay = SettingsOverlay::new(menu, vec![], vec![]);
    overlay.on_event(&Event::Key(key(KeyCode::Enter))).await; // open picker

    // Render at a tall terminal (60 rows)
    let height_tall = 59_usize; // 60 - 1
    overlay.update_child_viewport(height_tall.saturating_sub(4));
    let term_tall = render_component(|ctx| overlay.render(ctx), 80, 60);
    let tall_lines = term_tall.get_lines();
    let tall_model_lines = tall_lines.iter().filter(|l| l.contains("Model ")).count();

    // Render at a short terminal (15 rows)
    let height_short = 14_usize; // 15 - 1
    overlay.update_child_viewport(height_short.saturating_sub(4));
    let term_short = render_component(|ctx| overlay.render(ctx), 80, 15);
    let short_lines = term_short.get_lines();
    let short_model_lines = short_lines.iter().filter(|l| l.contains("Model ")).count();

    assert!(
        tall_model_lines > short_model_lines,
        "tall terminal ({tall_model_lines} items) should show more picker items than short ({short_model_lines})"
    );
}

#[tokio::test]
async fn server_overlay_esc_closes_server_not_settings_overlay() {
    let menu = make_menu();
    let statuses = make_server_statuses();
    let mut overlay = open_server_overlay(menu, statuses).await;
    assert!(render_footer(&mut overlay).contains("Authenticate OAuth servers"));

    let outcome = overlay.on_event(&Event::Key(key(KeyCode::Esc))).await;
    assert!(outcome.is_some());
    assert!(render_footer(&mut overlay).contains("[Enter] Select"));
    assert!(outcome.unwrap().is_empty());
}

#[tokio::test]
async fn multi_select_entry_opens_model_selector() {
    let mut overlay = SettingsOverlay::new(make_multi_select_menu(), vec![], vec![]);

    // Navigate to the model entry (index 1: provider=0, model=1)
    overlay.on_event(&Event::Key(key(KeyCode::Down))).await;
    overlay.on_event(&Event::Key(key(KeyCode::Enter))).await;

    let footer = render_footer(&mut overlay);
    assert!(footer.contains("Toggle"), "expected model selector, got: {footer}");
    assert!(footer.contains("Effort: none"), "expected effort label, got: {footer}");
}

#[tokio::test]
async fn connected_oauth_server_can_reauth_from_server_overlay() {
    let menu = make_menu();
    let statuses = vec![
        McpServerStatusEntry::new("remote", McpServerStatus::Connected { tool_count: 2 })
            .with_auth_capability(McpServerAuthCapability::OAuth),
    ];

    let mut overlay = open_server_overlay(menu, statuses).await;
    let messages = overlay.on_event(&Event::Key(key(KeyCode::Enter))).await.unwrap();
    match messages.as_slice() {
        [SettingsMessage::AuthenticateServer(name)] => assert_eq!(name, "remote"),
        other => panic!("messages: {other:?}"),
    }
}