aedb 0.2.3

Embedded Rust storage engine with transactional commits, WAL durability, and snapshot-consistent reads
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
use crate::error::AedbError;
use parking_lot::{Mutex, RwLock};
use serde::{Deserialize, Serialize};
use std::collections::{HashMap, VecDeque};
use std::fs::{File, OpenOptions};
use std::io::{ErrorKind, Read, Seek, SeekFrom, Write};
#[cfg(unix)]
use std::os::unix::fs::FileExt;
#[cfg(windows)]
use std::os::windows::fs::FileExt;
use std::path::{Path, PathBuf};
use std::sync::Arc;
use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};

const PAGE_STORE_MAGIC: &[u8; 8] = b"AEDBPG1\0";
const PAGE_FRAME_HEADER_BYTES: usize = 48;
const MIN_PAGE_BYTES: usize = 256;
const MAX_PAGE_BYTES: usize = 16 * 1024 * 1024;
const PAGE_STORE_WRITE_BUFFER_BYTES: usize = 4 * 1024 * 1024;

#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub struct PageId(pub u64);

#[derive(Debug, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub struct PageRef {
    pub page_id: PageId,
    pub len: u32,
    pub blake3_hash: [u8; 32],
}

#[derive(Debug)]
pub struct PagedStore {
    path: PathBuf,
    file: Mutex<File>,
    read_file: File,
    page_size: usize,
    page_stride: u64,
    cache_capacity_pages: usize,
    page_count: AtomicU64,
    dirty: AtomicBool,
    cache: RwLock<PageCache>,
}

impl PagedStore {
    pub fn open(
        data_dir: &Path,
        file_name: &str,
        page_size: usize,
        cache_capacity_pages: usize,
    ) -> Result<Self, AedbError> {
        if !(MIN_PAGE_BYTES..=MAX_PAGE_BYTES).contains(&page_size) {
            return Err(AedbError::InvalidConfig {
                message: format!(
                    "page_size must be between {MIN_PAGE_BYTES} and {MAX_PAGE_BYTES} bytes"
                ),
            });
        }
        if file_name.contains('/') || file_name.contains('\\') || file_name.is_empty() {
            return Err(AedbError::InvalidConfig {
                message: "page store file_name must be a single path segment".into(),
            });
        }

        std::fs::create_dir_all(data_dir)?;
        let path = data_dir.join(file_name);
        let mut file = OpenOptions::new()
            .read(true)
            .write(true)
            .create(true)
            .truncate(false)
            .open(&path)?;
        if file.metadata()?.len() == 0 {
            file.write_all(PAGE_STORE_MAGIC)?;
            file.flush()?;
            file.sync_all()?;
        } else {
            let mut magic = [0u8; PAGE_STORE_MAGIC.len()];
            file.seek(SeekFrom::Start(0))?;
            file.read_exact(&mut magic)?;
            if &magic != PAGE_STORE_MAGIC {
                return Err(AedbError::IntegrityError {
                    message: "page store magic mismatch".into(),
                });
            }
        }

        let page_stride = u64::try_from(PAGE_FRAME_HEADER_BYTES.saturating_add(page_size))
            .map_err(|_| AedbError::InvalidConfig {
                message: "page store stride does not fit u64".into(),
            })?;
        let file_len = file.metadata()?.len();
        let payload_len = file_len
            .checked_sub(PAGE_STORE_MAGIC.len() as u64)
            .ok_or_else(|| AedbError::IntegrityError {
                message: "page store file shorter than magic header".into(),
            })?;
        if payload_len % page_stride != 0 {
            return Err(AedbError::IntegrityError {
                message: "page store contains a partial page frame".into(),
            });
        }
        let page_count = payload_len / page_stride;
        let read_file = file.try_clone()?;
        Ok(Self {
            path,
            file: Mutex::new(file),
            read_file,
            page_size,
            page_stride,
            cache_capacity_pages,
            page_count: AtomicU64::new(page_count),
            dirty: AtomicBool::new(false),
            cache: RwLock::new(PageCache::new(cache_capacity_pages)),
        })
    }

    pub fn append_page(&self, payload: &[u8]) -> Result<PageRef, AedbError> {
        let page_len = self.validate_payload(payload)?;
        let page_ref = {
            let mut file = self.file.lock();
            let page_id = PageId(self.page_count.load(Ordering::Acquire));
            let blake3_hash = page_hash(page_id, payload);

            let mut frame = vec![0u8; PAGE_FRAME_HEADER_BYTES + self.page_size];
            frame[0..8].copy_from_slice(&page_id.0.to_le_bytes());
            frame[8..12].copy_from_slice(&page_len.to_le_bytes());
            frame[16..48].copy_from_slice(&blake3_hash);
            frame[PAGE_FRAME_HEADER_BYTES..PAGE_FRAME_HEADER_BYTES + payload.len()]
                .copy_from_slice(payload);

            file.seek(SeekFrom::End(0))?;
            file.write_all(&frame)?;
            file.flush()?;
            let next_page_count =
                page_id
                    .0
                    .checked_add(1)
                    .ok_or_else(|| AedbError::IntegrityError {
                        message: "page store page id overflow".into(),
                    })?;
            self.page_count.store(next_page_count, Ordering::Release);
            PageRef {
                page_id,
                len: page_len,
                blake3_hash,
            }
        };
        self.dirty.store(true, Ordering::Release);
        if self.cache_capacity_pages > 0 {
            self.cache
                .write()
                .insert(page_ref.page_id, page_ref.blake3_hash, payload);
        }
        Ok(page_ref)
    }

    pub fn append_pages(&self, payloads: &[&[u8]]) -> Result<Vec<PageRef>, AedbError> {
        if payloads.is_empty() {
            return Ok(Vec::new());
        }
        if let [payload] = payloads {
            return self.append_page(payload).map(|page_ref| vec![page_ref]);
        }
        let mut page_lens = Vec::with_capacity(payloads.len());
        for payload in payloads {
            page_lens.push(self.validate_payload(payload)?);
        }

        let mut refs = Vec::with_capacity(payloads.len());
        {
            let mut file = self.file.lock();
            let mut next_page_id = self.page_count.load(Ordering::Acquire);
            let mut frame = vec![0u8; PAGE_FRAME_HEADER_BYTES + self.page_size];
            let write_buf_capacity = PAGE_STORE_WRITE_BUFFER_BYTES
                .max(frame.len())
                .min(frame.len().saturating_mul(payloads.len()));
            let mut write_buf = Vec::with_capacity(write_buf_capacity);
            let mut previous_payload_len = 0usize;
            file.seek(SeekFrom::End(0))?;
            for (payload, page_len) in payloads.iter().zip(page_lens.into_iter()) {
                let page_id = PageId(next_page_id);
                let blake3_hash = page_hash(page_id, payload);
                frame[0..8].copy_from_slice(&page_id.0.to_le_bytes());
                frame[8..12].copy_from_slice(&page_len.to_le_bytes());
                frame[12..16].fill(0);
                frame[16..48].copy_from_slice(&blake3_hash);
                frame[PAGE_FRAME_HEADER_BYTES..PAGE_FRAME_HEADER_BYTES + payload.len()]
                    .copy_from_slice(payload);
                if payload.len() < previous_payload_len {
                    frame[PAGE_FRAME_HEADER_BYTES + payload.len()
                        ..PAGE_FRAME_HEADER_BYTES + previous_payload_len]
                        .fill(0);
                }
                append_frame_to_writer(&mut *file, &mut write_buf, &frame)?;
                previous_payload_len = payload.len();
                refs.push(PageRef {
                    page_id,
                    len: page_len,
                    blake3_hash,
                });
                next_page_id =
                    next_page_id
                        .checked_add(1)
                        .ok_or_else(|| AedbError::IntegrityError {
                            message: "page store page id overflow".into(),
                        })?;
            }
            flush_write_buffer(&mut *file, &mut write_buf)?;
            file.flush()?;
            self.page_count.store(next_page_id, Ordering::Release);
        }
        self.dirty.store(true, Ordering::Release);
        if self.cache_capacity_pages > 0 {
            let cache_start = refs.len().saturating_sub(self.cache_capacity_pages);
            let mut cache = self.cache.write();
            for (page_ref, payload) in refs[cache_start..]
                .iter()
                .zip(payloads[cache_start..].iter())
            {
                cache.insert(page_ref.page_id, page_ref.blake3_hash, payload);
            }
        }
        Ok(refs)
    }

    fn validate_payload(&self, payload: &[u8]) -> Result<u32, AedbError> {
        if payload.len() > self.page_size {
            return Err(AedbError::Validation(format!(
                "page payload exceeds page_size: payload_bytes={}, page_size={}",
                payload.len(),
                self.page_size
            )));
        }
        page_len_u32(payload)
    }

    pub fn read_page(&self, page_ref: &PageRef) -> Result<Vec<u8>, AedbError> {
        if self.cache_capacity_pages > 0
            && let Some((page, cached_hash)) = self.cache.read().get(&page_ref.page_id)
        {
            if cached_hash != page_ref.blake3_hash {
                return Err(AedbError::IntegrityError {
                    message: "cached page hash mismatch".into(),
                });
            }
            return Ok(page.as_ref().to_vec());
        }

        let current_count = self.page_count.load(Ordering::Acquire);
        if page_ref.page_id.0 >= current_count {
            return Err(AedbError::IntegrityError {
                message: "page reference outside page store".into(),
            });
        }
        let expected_len =
            usize::try_from(page_ref.len).map_err(|_| AedbError::IntegrityError {
                message: "page reference length does not fit usize".into(),
            })?;
        if expected_len > self.page_size {
            return Err(AedbError::IntegrityError {
                message: "page reference length exceeds page size".into(),
            });
        }
        let frame_offset = frame_offset(page_ref.page_id, self.page_stride)?;
        let frame_read_len = PAGE_FRAME_HEADER_BYTES
            .checked_add(expected_len)
            .ok_or_else(|| AedbError::IntegrityError {
                message: "page frame read length overflow".into(),
            })?;
        let mut frame_prefix = vec![0u8; frame_read_len];
        read_exact_at(&self.read_file, &mut frame_prefix, frame_offset)?;
        let stored_page_id =
            {
                let header = &frame_prefix[..PAGE_FRAME_HEADER_BYTES];
                u64::from_le_bytes(header[0..8].try_into().map_err(|_| {
                    AedbError::IntegrityError {
                        message: "invalid page id header".into(),
                    }
                })?)
            };
        if stored_page_id != page_ref.page_id.0 {
            return Err(AedbError::IntegrityError {
                message: "page id header mismatch".into(),
            });
        }
        let stored_len =
            {
                let header = &frame_prefix[..PAGE_FRAME_HEADER_BYTES];
                u32::from_le_bytes(header[8..12].try_into().map_err(|_| {
                    AedbError::IntegrityError {
                        message: "invalid page length header".into(),
                    }
                })?)
            };
        if stored_len != page_ref.len || stored_len as usize > self.page_size {
            return Err(AedbError::IntegrityError {
                message: "page length header mismatch".into(),
            });
        }
        let mut stored_hash = [0u8; 32];
        stored_hash.copy_from_slice(&frame_prefix[16..48]);
        if stored_hash != page_ref.blake3_hash {
            return Err(AedbError::IntegrityError {
                message: "page hash header mismatch".into(),
            });
        }
        frame_prefix.copy_within(PAGE_FRAME_HEADER_BYTES..frame_read_len, 0);
        frame_prefix.truncate(expected_len);
        let payload = frame_prefix;
        if page_hash(page_ref.page_id, &payload) != page_ref.blake3_hash {
            return Err(AedbError::IntegrityError {
                message: "page payload hash mismatch".into(),
            });
        }
        if self.cache_capacity_pages > 0 {
            self.cache
                .write()
                .insert(page_ref.page_id, page_ref.blake3_hash, &payload);
        }
        Ok(payload)
    }

    pub fn sync_all(&self) -> Result<(), AedbError> {
        if !self.dirty.load(Ordering::Acquire) {
            return Ok(());
        }
        let file = self.file.lock();
        if !self.dirty.load(Ordering::Acquire) {
            return Ok(());
        }
        file.sync_all()?;
        self.dirty.store(false, Ordering::Release);
        Ok(())
    }

    pub fn page_size(&self) -> usize {
        self.page_size
    }

    pub fn page_count(&self) -> u64 {
        self.page_count.load(Ordering::Acquire)
    }

    pub fn len_bytes(&self) -> u64 {
        PAGE_STORE_MAGIC.len() as u64 + self.page_count() * self.page_stride
    }

    pub fn cache_resident_pages(&self) -> usize {
        self.cache.read().resident_pages()
    }

    pub fn cache_capacity_pages(&self) -> usize {
        self.cache_capacity_pages
    }

    pub fn path(&self) -> &Path {
        &self.path
    }
}

#[cfg(unix)]
fn read_exact_at(file: &File, mut buf: &mut [u8], mut offset: u64) -> Result<(), AedbError> {
    while !buf.is_empty() {
        match file.read_at(buf, offset) {
            Ok(0) => {
                return Err(AedbError::Io(std::io::Error::new(
                    ErrorKind::UnexpectedEof,
                    "failed to fill whole page buffer",
                )));
            }
            Ok(bytes_read) => {
                offset = offset.checked_add(bytes_read as u64).ok_or_else(|| {
                    AedbError::IntegrityError {
                        message: "page read offset overflow".into(),
                    }
                })?;
                let remaining = buf;
                buf = &mut remaining[bytes_read..];
            }
            Err(err) if err.kind() == ErrorKind::Interrupted => {}
            Err(err) => return Err(AedbError::Io(err)),
        }
    }
    Ok(())
}

#[cfg(windows)]
fn read_exact_at(file: &File, mut buf: &mut [u8], mut offset: u64) -> Result<(), AedbError> {
    while !buf.is_empty() {
        match file.seek_read(buf, offset) {
            Ok(0) => {
                return Err(AedbError::Io(std::io::Error::new(
                    ErrorKind::UnexpectedEof,
                    "failed to fill whole page buffer",
                )));
            }
            Ok(bytes_read) => {
                offset = offset.checked_add(bytes_read as u64).ok_or_else(|| {
                    AedbError::IntegrityError {
                        message: "page read offset overflow".into(),
                    }
                })?;
                let remaining = buf;
                buf = &mut remaining[bytes_read..];
            }
            Err(err) if err.kind() == ErrorKind::Interrupted => {}
            Err(err) => return Err(AedbError::Io(err)),
        }
    }
    Ok(())
}

#[cfg(not(any(unix, windows)))]
compile_error!("PagedStore requires positional file reads for concurrent cold read safety");

fn append_frame_to_writer<W: Write>(
    writer: &mut W,
    write_buf: &mut Vec<u8>,
    frame: &[u8],
) -> Result<(), AedbError> {
    if frame.len() > PAGE_STORE_WRITE_BUFFER_BYTES {
        flush_write_buffer(writer, write_buf)?;
        writer.write_all(frame)?;
        return Ok(());
    }
    if write_buf.len() + frame.len() > PAGE_STORE_WRITE_BUFFER_BYTES {
        flush_write_buffer(writer, write_buf)?;
    }
    write_buf.extend_from_slice(frame);
    Ok(())
}

fn flush_write_buffer<W: Write>(writer: &mut W, write_buf: &mut Vec<u8>) -> Result<(), AedbError> {
    if !write_buf.is_empty() {
        writer.write_all(write_buf)?;
        write_buf.clear();
    }
    Ok(())
}

fn frame_offset(page_id: PageId, page_stride: u64) -> Result<u64, AedbError> {
    page_id
        .0
        .checked_mul(page_stride)
        .and_then(|offset| offset.checked_add(PAGE_STORE_MAGIC.len() as u64))
        .ok_or_else(|| AedbError::IntegrityError {
            message: "page frame offset overflow".into(),
        })
}

fn page_len_u32(payload: &[u8]) -> Result<u32, AedbError> {
    u32::try_from(payload.len())
        .map_err(|_| AedbError::Validation("page payload length does not fit u32".into()))
}

fn page_hash(page_id: PageId, payload: &[u8]) -> [u8; 32] {
    let mut hasher = blake3::Hasher::new();
    hasher.update(&page_id.0.to_le_bytes());
    hasher.update(&(payload.len() as u64).to_le_bytes());
    hasher.update(payload);
    *hasher.finalize().as_bytes()
}

#[derive(Debug)]
struct PageCache {
    capacity_pages: usize,
    pages: HashMap<PageId, CachedPage>,
    insertion_order: VecDeque<PageId>,
}

#[derive(Debug)]
struct CachedPage {
    payload: Arc<[u8]>,
    blake3_hash: [u8; 32],
}

impl PageCache {
    fn new(capacity_pages: usize) -> Self {
        Self {
            capacity_pages,
            pages: HashMap::with_capacity(capacity_pages),
            insertion_order: VecDeque::with_capacity(capacity_pages),
        }
    }

    fn resident_pages(&self) -> usize {
        self.pages.len()
    }

    fn get(&self, page_id: &PageId) -> Option<(Arc<[u8]>, [u8; 32])> {
        let cached = self.pages.get(page_id)?;
        Some((Arc::clone(&cached.payload), cached.blake3_hash))
    }

    fn insert(&mut self, page_id: PageId, blake3_hash: [u8; 32], payload: &[u8]) {
        if self.capacity_pages == 0 {
            return;
        }
        if let std::collections::hash_map::Entry::Occupied(mut cached) = self.pages.entry(page_id) {
            cached.insert(CachedPage {
                payload: Arc::from(payload),
                blake3_hash,
            });
            return;
        }
        self.insertion_order.push_back(page_id);
        self.pages.insert(
            page_id,
            CachedPage {
                payload: Arc::from(payload),
                blake3_hash,
            },
        );
        self.evict_to_capacity();
    }

    fn evict_to_capacity(&mut self) {
        while self.pages.len() > self.capacity_pages {
            let Some(page_id) = self.insertion_order.pop_front() else {
                break;
            };
            self.pages.remove(&page_id);
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::io::{Seek, SeekFrom, Write};
    use tempfile::tempdir;

    #[test]
    fn append_read_and_reopen_pages() {
        let dir = tempdir().expect("temp");
        let store = PagedStore::open(dir.path(), "rows.aedbpg", 512, 2).expect("open");
        let first = store.append_page(b"alpha").expect("append first");
        let second = store.append_page(b"beta").expect("append second");
        assert_eq!(store.page_count(), 2);
        assert_eq!(store.read_page(&first).expect("read first"), b"alpha");
        assert_eq!(store.read_page(&second).expect("read second"), b"beta");
        store.sync_all().expect("sync");
        drop(store);

        let reopened = PagedStore::open(dir.path(), "rows.aedbpg", 512, 1).expect("reopen");
        assert_eq!(reopened.page_count(), 2);
        assert_eq!(reopened.read_page(&first).expect("read first"), b"alpha");
        assert_eq!(reopened.read_page(&second).expect("read second"), b"beta");
    }

    #[test]
    fn cache_is_bounded_by_page_count() {
        let dir = tempdir().expect("temp");
        let store = PagedStore::open(dir.path(), "rows.aedbpg", 512, 2).expect("open");
        let refs = (0..4u8)
            .map(|i| store.append_page(&[i]).expect("append"))
            .collect::<Vec<_>>();
        assert_eq!(store.cache_resident_pages(), 2);
        for page_ref in &refs {
            store.read_page(page_ref).expect("read");
            assert!(store.cache_resident_pages() <= 2);
        }
    }

    #[test]
    fn append_pages_batches_contiguous_page_ids() {
        let dir = tempdir().expect("temp");
        let store = PagedStore::open(dir.path(), "rows.aedbpg", 512, 4).expect("open");
        let payloads = [
            b"batch-alpha".as_slice(),
            b"batch-beta".as_slice(),
            b"batch-gamma".as_slice(),
        ];
        let refs = store.append_pages(&payloads).expect("append batch");
        assert_eq!(refs.len(), payloads.len());
        for (expected_page_id, page_ref) in refs.iter().enumerate() {
            assert_eq!(page_ref.page_id.0, expected_page_id as u64);
            assert_eq!(
                store.read_page(page_ref).expect("read batch page"),
                payloads[expected_page_id]
            );
        }
        assert_eq!(store.page_count(), payloads.len() as u64);
    }

    #[test]
    fn append_pages_populates_only_cache_resident_tail() {
        let dir = tempdir().expect("temp");
        let store = PagedStore::open(dir.path(), "rows.aedbpg", 512, 2).expect("open");
        let payloads = [
            b"cache-alpha".as_slice(),
            b"cache-beta".as_slice(),
            b"cache-gamma".as_slice(),
            b"cache-delta".as_slice(),
        ];
        let refs = store.append_pages(&payloads).expect("append batch");
        assert_eq!(store.cache_resident_pages(), 2);
        assert_eq!(
            store.read_page(&refs[2]).expect("read cached tail"),
            payloads[2]
        );
        assert_eq!(
            store.read_page(&refs[3]).expect("read cached tail"),
            payloads[3]
        );
        assert!(store.cache_resident_pages() <= 2);
    }

    #[test]
    fn concurrent_appends_assign_unique_page_ids() {
        let dir = tempdir().expect("temp");
        let store = Arc::new(PagedStore::open(dir.path(), "rows.aedbpg", 512, 8).expect("open"));
        let mut handles = Vec::new();
        for i in 0..32u8 {
            let store = Arc::clone(&store);
            handles.push(std::thread::spawn(move || {
                store.append_page(&[i]).expect("append")
            }));
        }
        let mut refs = handles
            .into_iter()
            .map(|handle| handle.join().expect("join"))
            .collect::<Vec<_>>();
        refs.sort_by_key(|page_ref| page_ref.page_id.0);
        assert_eq!(refs.len(), 32);
        for (expected, page_ref) in refs.iter().enumerate() {
            assert_eq!(page_ref.page_id.0, expected as u64);
            let payload = store.read_page(page_ref).expect("read");
            assert_eq!(payload.len(), 1);
        }
        assert_eq!(store.page_count(), 32);
    }

    #[test]
    fn concurrent_cold_reads_do_not_share_seek_cursor() {
        let dir = tempdir().expect("temp");
        let store = Arc::new(PagedStore::open(dir.path(), "rows.aedbpg", 1024, 0).expect("open"));
        let payloads = (0..64u8)
            .map(|i| vec![i; 257 + usize::from(i % 17)])
            .collect::<Vec<_>>();
        let slices = payloads.iter().map(Vec::as_slice).collect::<Vec<_>>();
        let refs = store.append_pages(&slices).expect("append batch");
        store.sync_all().expect("sync");

        let mut handles = Vec::new();
        for _ in 0..8 {
            let store = Arc::clone(&store);
            let refs = refs.clone();
            let payloads = payloads.clone();
            handles.push(std::thread::spawn(move || {
                for _ in 0..16 {
                    for (page_ref, expected) in refs.iter().zip(payloads.iter()) {
                        assert_eq!(store.read_page(page_ref).expect("read page"), *expected);
                    }
                }
            }));
        }
        for handle in handles {
            handle.join().expect("join");
        }
    }

    #[test]
    fn read_detects_corrupted_page_payload() {
        let dir = tempdir().expect("temp");
        let store = PagedStore::open(dir.path(), "rows.aedbpg", 512, 0).expect("open");
        let page_ref = store.append_page(b"alpha").expect("append");
        store.sync_all().expect("sync");
        let path = store.path().to_path_buf();
        drop(store);

        let mut file = OpenOptions::new()
            .write(true)
            .open(path)
            .expect("open page file");
        file.seek(SeekFrom::Start(
            PAGE_STORE_MAGIC.len() as u64 + PAGE_FRAME_HEADER_BYTES as u64,
        ))
        .expect("seek payload");
        file.write_all(b"z").expect("corrupt");
        file.flush().expect("flush");
        drop(file);

        let reopened = PagedStore::open(dir.path(), "rows.aedbpg", 512, 0).expect("reopen");
        let err = reopened
            .read_page(&page_ref)
            .expect_err("corruption should be detected");
        assert!(matches!(err, AedbError::IntegrityError { .. }));
    }

    #[test]
    fn rejects_oversized_pages_and_partial_frames() {
        let dir = tempdir().expect("temp");
        let store = PagedStore::open(dir.path(), "rows.aedbpg", 512, 1).expect("open");
        let err = store
            .append_page(&vec![0u8; 513])
            .expect_err("oversized page");
        assert!(matches!(err, AedbError::Validation(_)));
        drop(store);

        let path = dir.path().join("rows.aedbpg");
        let mut file = OpenOptions::new().append(true).open(path).expect("open");
        file.write_all(b"partial").expect("partial frame");
        file.flush().expect("flush partial");
        drop(file);

        let err = PagedStore::open(dir.path(), "rows.aedbpg", 512, 1)
            .expect_err("partial frame must be rejected");
        assert!(matches!(err, AedbError::IntegrityError { .. }));
    }
}